- User Since
- Jun 25 2016, 9:00 PM (308 w, 1 d)
Sat, May 21
What the port does is:
$ file /usr/local/lib/libedit.so.0
/usr/local/lib/libedit.so.0: symbolic link to libedit.so.0.0.68
The port turns out to be a Debian-made repackaging of the NetBSD library.
Huh, as it is, it cannot pick up the base editline at all. It's looking for /lib/libedit.so.0 and ours (well, mine) is /lib/libedit.so.8.
I think I'll need to drop the "editline (ports)" option, there's no way to choose one or the other when both are installed.
Sat, Apr 30
Sun, Apr 24
Sat, Apr 23
Apr 22 2022
Apr 19 2022
Maybe if the file was mmapped and the r->fromth line found via memchr() or similar, that would be faster.
Apr 18 2022
I think I'm the one to blame for this, but I've never understood ATF and from other usage across our repo it wasn't clear to me how to properly do this.
To be honest, if I need to quote someone to make my argument stronger, it would be Chris: https://ramblings.implicit.net/c/2014/05/02/c-functions-that-should-be-avoided-part-2.html
Apr 17 2022
Apr 16 2022
Thanks again for reviewing this!
Address some of the comments made by delphij.
Apr 15 2022
Address comments by rpokala.
I decided to choose the word "period" over "dot" because the former was already here.
Rename bin2text2bin to bintrans. Update the manual page.
Apr 14 2022
Apr 13 2022
Apr 11 2022
Apr 7 2022
Remove uudecode remnants from Makefile.inc1, etc/mtree/BSD.tests.dist, targets/pseudo/tests/Makefile.depend, and targets/pseudo/userland/Makefile.depend
Address delphij's comments.
Apr 6 2022
Address mistakes, describe the magic buffer length.
Apr 5 2022
Mar 29 2022
Mar 28 2022
Hi, thanks for this review!
Hi, thanks for this review!
Hi, thanks for the review!
Mar 27 2022
Don't leak memory.
Mar 26 2022
Fortunately, the tilde-expanding function from libedit is nicely exported. Too bad this code is duplicated between sh and libedit.
Mar 25 2022
I don't use etcupdate yet, but this change looks reasonable to me.
Mar 23 2022
Mar 22 2022
Mar 18 2022
Mar 17 2022
Mar 14 2022
I missed histedit.c in the previous git add.
Mar 13 2022
Drop the flags argument from tilde_expand().
Mar 12 2022
There doesn't seem to be any specification of the diff3 behavior, so I spent some time looking for some test cases. GNU doesn't provide much directly in the source (https://git.savannah.gnu.org/cgit/diffutils.git/plain/tests/diff3) and also the mailing list isn't rich in corner cases relating to diff3. I've found some test cases for git's implementation (https://github.com/git/git/search?l=Shell&q=diff3) but I only skimmed that so I don't know how useful they are.
I am not sure about the license of the lao, tzu, tao example, I feel like it is
ancient and should be in the public domain. I'll rewrite it to produce the same
test case with a public domain poem if we need to.
Mar 10 2022
I can only see the man-page change, should I be seeing code changes in this diff as well?
Feb 23 2022
Feb 13 2022
Jan 29 2022
Nov 16 2021
Mostly implement long options for compatibility.
Nov 11 2021
Nov 6 2021
As pointed out by bapt, el_set(el, EL_BIND, "^X^E", "vi-histedit", NULL); is enough.