pstef (Piotr Stefaniak)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2016, 9:00 PM (73 w, 1 d)

Recent Activity

Jul 25 2017

pstef committed rS321487: indent(1): add option -tsn for setting tab size..
indent(1): add option -tsn for setting tab size.
Jul 25 2017, 5:05 PM

Jul 23 2017

pstef committed rS321396: indent(1): better alignment of comments on code..
indent(1): better alignment of comments on code.
Jul 23 2017, 8:26 PM
pstef committed rS321383: indent(1): rename the profile file..
indent(1): rename the profile file.
Jul 23 2017, 3:08 PM
pstef committed rS321382: indent(1): don't produce unnecessary blank lines..
indent(1): don't produce unnecessary blank lines.
Jul 23 2017, 2:33 PM
pstef committed rS321381: indent(1): don't produce unneeded space character in function declarators..
indent(1): don't produce unneeded space character in function declarators.
Jul 23 2017, 2:05 PM

May 26 2017

pstef accepted D10921: indent(1): respect SIMPLE_BACKUP_SUFFIX environment variable.
May 26 2017, 6:59 PM
pstef accepted D10921: indent(1): respect SIMPLE_BACKUP_SUFFIX environment variable.
May 26 2017, 6:47 PM

May 18 2017

pstef committed rS318471: indent(1): Support binary integer literals..
indent(1): Support binary integer literals.
May 18 2017, 5:16 PM

Mar 3 2017

pstef accepted D9682: Integrate indent tests added in r313544 into ATF/Kyua and the FreeBSD test suite.
Mar 3 2017, 8:09 PM
pstef added inline comments to D9682: Integrate indent tests added in r313544 into ATF/Kyua and the FreeBSD test suite.
Mar 3 2017, 6:43 PM

Feb 21 2017

pstef added inline comments to D9682: Integrate indent tests added in r313544 into ATF/Kyua and the FreeBSD test suite.
Feb 21 2017, 6:26 AM

Feb 20 2017

pstef added a comment to D9682: Integrate indent tests added in r313544 into ATF/Kyua and the FreeBSD test suite.

The driver calls indent as noted in r313544, with an exception: The $FreeBSD$ RCS keyword's expansion is reindented with indent, which means that the output differs from the expected output.

Feb 20 2017, 7:03 PM

Feb 10 2017

pstef committed rS313544: indent(1): add regression test cases.
indent(1): add regression test cases
Feb 10 2017, 9:31 AM
pstef closed D9007: Add regression tests for indent(1) by committing rS313544: indent(1): add regression test cases.
Feb 10 2017, 9:31 AM

Feb 9 2017

pstef updated the diff for D9007: Add regression tests for indent(1).

Together with proposed commit message:

Feb 9 2017, 10:50 PM
pstef added inline comments to D9510: usr.sbin/ndp/ndp.c: Fix style(9).
Feb 9 2017, 6:04 PM

Feb 8 2017

pstef added a comment to D9007: Add regression tests for indent(1).
In D9007#195987, @ngie wrote:
In D9007#195976, @pstef wrote:

...

I did plan to commit them incrementally in the sense that I would add a test case for a new feature together with the feature implementation. The question is rather: can these starting tests fail until I fix indent(1) so that they don't? Pedro pointed out that tests can be marked as "expected to fail", but I don't know anything about that.

It would be a bit more complicated building in "expected failures" for the test driver, but it could be done. Is there any value to committing in the failures without the code being fixed (I mean, yes, I understand the practical reasoning... I just wasn't sure if committing things now and making the problems visible is any benefit to others, except when dealing with bus factor, i.e. the issues can be tracked)?

Feb 8 2017, 1:30 PM

Feb 7 2017

pstef added a comment to D9007: Add regression tests for indent(1).
In D9007#195975, @ngie wrote:
In D9007#195939, @pstef wrote:
In D9007#193594, @ngie wrote:

Thanks for the explanations -- please provide this in your commit message.

Cheers!

Sorry to bother you, but I have some doubts and I'd prefer to ask here first than to discuss on -committers when it's too late.

My main doubt is whether the expected output should be absolutely correct in every aspect (this won't happen until after 20 to 30 commits, I think) or can the output files be good enough now and perfected later?

I think that the working tests should be committed incrementally. This will put a number of commits/MFCs under your belt, which will be helpful for completing your mentorship, and is good practice for backporting changes for indent.

Feb 7 2017, 11:09 PM
pstef added a comment to D9007: Add regression tests for indent(1).
In D9007#193594, @ngie wrote:

Thanks for the explanations -- please provide this in your commit message.

Cheers!

Feb 7 2017, 7:21 PM

Jan 21 2017

pstef added a comment to D9007: Add regression tests for indent(1).
In D9007#191694, @pstef wrote:

Any automatic regression mechanism should in essence do this:

indent ${test}.0 ${test}.0.run -P${test}.pro

and compare ${test}.0.stdout with ${test}.0.run. (Both are files. BSD indent(1) has never been able to produce re-formatted input to stdout.)

... except when input is from stdin. So this works:

Jan 21 2017, 9:08 AM
pstef added a comment to D9007: Add regression tests for indent(1).
In D9007#191648, @ngie wrote:

Much better.

Could your commit message please describe what each of the files does, e.g.

Sure.

Jan 21 2017, 8:53 AM
pstef updated the diff for D9007: Add regression tests for indent(1).

I forgot to update a file that referred to the file name where I replaced hyphens with underscores.

Jan 21 2017, 8:32 AM
pstef updated the diff for D9007: Add regression tests for indent(1).

$FreeBSD$

Jan 21 2017, 12:11 AM

Jan 20 2017

pstef updated the diff for D9007: Add regression tests for indent(1).
Jan 20 2017, 9:42 PM
pstef updated the diff for D9007: Add regression tests for indent(1).

ngie, is this better?

Jan 20 2017, 9:38 PM

Jan 15 2017

pstef added a comment to D9007: Add regression tests for indent(1).
In D9007#189929, @pfg wrote:
In D9007#189888, @email_piotr-stefaniak.me wrote:

After learning about PR 215690 I'm no longer convinced that the regression tests I'd like to have should be integrated into the FreeBSD testing suite. It sounds ridiculous that a harmless regression in a reformatting tool like indent(1) would create "bogus failures counted against our overall results". indent(1) is not a crucial part of the operating system and shouldn't be tested as rigorously. Bugs in indent(1) are not even close to an indication of overall quality of the system.

Well, I've been arguing all along that perhaps the tests don't belong in FreeBSD's tree but that you could keep them in github with travis-ci.

I see two drawbacks of that:

  1. dependency on an external mechanism,
  2. disconnection between the changes and the examples showing what the change is about.
Jan 15 2017, 4:04 PM
pstef added a comment to D9007: Add regression tests for indent(1).

After learning about PR 215690 I'm no longer convinced that the regression tests I'd like to have should be integrated into the FreeBSD testing suite. It sounds ridiculous that a harmless regression in a reformatting tool like indent(1) would create "bogus failures counted against our overall results". indent(1) is not a crucial part of the operating system and shouldn't be tested as rigorously. Bugs in indent(1) are not even close to an indication of overall quality of the system.

Jan 15 2017, 10:36 AM

Jan 11 2017

pstef added a comment to D9007: Add regression tests for indent(1).
In D9007#187030, @ngie wrote:
In D9007#186892, @email_piotr-stefaniak.me wrote:

Please do state in the commit log that the tests are currently disconnected from the build but that you intend to complete them. As before, rember to include a link to the CR.

I can help guide piotr with the integration work, once the test content is present.

I would like to leave that for someone who wants to improve the FreeBSD test suite. I don't want to spend time on learning it, I want to spend time on actually fixing things.

-_-... this is what I was concerned about.

Ok, since I'll be doing the integrating (apparently), I need you to follow a specific scheme for the filenames (standard error, standard out, input files) so I can have it automatically find all of the tests and act appropriately, like bin/sh/tests/functional_test.sh does.

Jan 11 2017, 5:44 PM
pstef added a comment to D9007: Add regression tests for indent(1).
Jan 11 2017, 5:41 PM

Jan 6 2017

pstef added a comment to D9007: Add regression tests for indent(1).

I'm on vacation. I'll be back in 1 week.

Jan 6 2017, 3:34 AM

Jan 5 2017

pstef added a comment to D9007: Add regression tests for indent(1).

Please do state in the commit log that the tests are currently disconnected from the build but that you intend to complete them. As before, rember to include a link to the CR.

Jan 5 2017, 5:51 AM

Jan 4 2017

pstef added a comment to D9007: Add regression tests for indent(1).
In D9007#186860, @ngie wrote:

I have a potential compromise: please remove the "Makefile" from the commit, integrate your tests into the FreeBSD test suite separately, open another CR for that change, and I'll approve that change once it's complete.

Jan 4 2017, 10:46 PM
pstef added a comment to D9007: Add regression tests for indent(1).
In D9007#186792, @pfg wrote:
In D9007#186751, @ngie wrote:

...
Put differently, I cannot approve this because it doesn't really integrate into the existing system I contribute to (the FreeBSD Test Suite). If pfg@ approved the commit, it's fine to commit as-is.

I haven't approved it. I like the idea of having a test suite for indent(1) but I don't see the hurry to put it into head unless it's acceptable to the FreeBSD testsuite guys.

Jan 4 2017, 7:37 PM
pstef added a comment to D9007: Add regression tests for indent(1).
In D9007#186739, @ngie wrote:

These tests are still not integrated into the FreeBSD test suite. This is a blocker from committing the change to head.

Jan 4 2017, 7:11 AM

Jan 3 2017

pstef updated the diff for D9007: Add regression tests for indent(1).

Add $FreeBSD$ in new files.

Jan 3 2017, 5:26 PM

Jan 2 2017

pstef updated the diff for D9007: Add regression tests for indent(1).

Fix details in the Makefile pointed out by ngie,
In greatest disgust, add license headers to all test case files, per suggestion from rwatson and cpercival.

Jan 2 2017, 10:16 PM
pstef updated the diff for D9010: indent(1): add option -P for loading user-provided files as profiles.

Rebased on top of SVN.
Updated date in the man page.

Jan 2 2017, 7:24 PM

Jan 1 2017

pstef added a comment to D9010: indent(1): add option -P for loading user-provided files as profiles.

Given that there is a "-npro" option already, how about renaming it to "-ppro"? This would stand for "personalized profile", but I guess we could use custom profile (-cpro) or temporary profile (-tpro). Just trying to make things look consistent ;).

Jan 1 2017, 9:28 PM
pstef added a reviewer for D9010: indent(1): add option -P for loading user-provided files as profiles: pfg.
Jan 1 2017, 8:45 PM
pstef added a comment to D9007: Add regression tests for indent(1).

This looks incorrect per style(9).

Jan 1 2017, 4:27 PM

Dec 31 2016

pstef added inline comments to D9010: indent(1): add option -P for loading user-provided files as profiles.
Dec 31 2016, 1:49 PM
pstef updated D9007: Add regression tests for indent(1).
Dec 31 2016, 12:45 PM
pstef updated the diff for D9007: Add regression tests for indent(1).

Previous version was incompatible with make -j. Use option -P from D9010 to load the profile file directly instead of doing the cp/rm dance.

Dec 31 2016, 12:42 PM
pstef added a dependent revision for D9010: indent(1): add option -P for loading user-provided files as profiles: D9007: Add regression tests for indent(1).
Dec 31 2016, 12:37 PM
pstef added a dependency for D9007: Add regression tests for indent(1): D9010: indent(1): add option -P for loading user-provided files as profiles.
Dec 31 2016, 12:37 PM
pstef retitled D9010: indent(1): add option -P for loading user-provided files as profiles from to indent(1): add option -P for loading user-provided files as profiles.
Dec 31 2016, 12:37 PM
pstef updated D9007: Add regression tests for indent(1).
Dec 31 2016, 7:59 AM
pstef updated D9007: Add regression tests for indent(1).
Dec 31 2016, 7:58 AM
pstef retitled D9007: Add regression tests for indent(1) from to Add regression tests for indent(1).
Dec 31 2016, 7:57 AM

Aug 6 2016

pstef updated D6966: Multiple improvements of indent(1).
Aug 6 2016, 7:53 PM

Aug 4 2016

pstef added a comment to D6966: Multiple improvements of indent(1).
In D6966#154186, @pfg wrote:

The enhancements have been really nice and welcome, THANKS!

Aug 4 2016, 4:18 PM
pstef updated D6966: Multiple improvements of indent(1).
Aug 4 2016, 4:06 PM

Aug 2 2016

pstef updated D6966: Multiple improvements of indent(1).
Aug 2 2016, 5:15 PM

Jul 31 2016

pstef added inline comments to D6966: Multiple improvements of indent(1).
Jul 31 2016, 4:41 PM
pstef updated the diff for D6966: Multiple improvements of indent(1).

Remove dead assignment as per clang-analyzer's complaint.
Rearrange option parsing code as per clang-analyzer's complaint about "dangling reference".
Avoid undefined behavior as per Jilles Tjoelker's complaint. Apply style(9) to the macro definitions while there.
Fix incompatible pointer type of sizeof's operand when operating on the object "typenames".

Jul 31 2016, 2:36 PM

Jul 30 2016

pstef updated the diff for D6966: Multiple improvements of indent(1).

Fixed a few "style bugs".

Jul 30 2016, 7:31 AM

Jul 29 2016

pstef added a comment to D6966: Multiple improvements of indent(1).

I left out the array bound checks for now: they wouldn't hurt but I am not sure they are necessary

They prevent triggerable undefined behavior; the code in some cases works only by accident. I don't see a reason not to commit those fixes.

Jul 29 2016, 9:26 PM

Jul 28 2016

pstef updated the diff for D6966: Multiple improvements of indent(1).

I forgot the -U9999999 the last time I updated the diff.

Jul 28 2016, 4:58 PM
pstef added a comment to D6966: Multiple improvements of indent(1).

I fixed all return (var) and sizeof(var) issues, including reported ones, not reported ones, and the ones that had been there for ages.

Jul 28 2016, 3:49 PM
pstef updated the diff for D6966: Multiple improvements of indent(1).
Jul 28 2016, 3:39 PM
pstef added a comment to D6966: Multiple improvements of indent(1).
In D6966#152751, @pfg wrote:

Very interesting: All the BSDs fixed the "typdef" typo but indent(1) generally needs much more attention.

Jul 28 2016, 3:27 PM

Jul 27 2016

pstef added a comment to D6966: Multiple improvements of indent(1).

Address comments.

Jul 27 2016, 9:56 PM
pstef added a comment to D6966: Multiple improvements of indent(1).

Answer lattera's comments.

Jul 27 2016, 9:24 PM

Jul 17 2016

pstef updated D6966: Multiple improvements of indent(1).
Jul 17 2016, 5:28 PM
pstef updated the diff for D6966: Multiple improvements of indent(1).

Add two fixes:

[bugfix] Fix breakage caused by single comment following "else"
[bugfix] Avoid out of bound access of array ps.p_stack
Jul 17 2016, 5:24 PM

Jun 26 2016

pstef updated the diff for D6966: Multiple improvements of indent(1).

A minor fix for a bug I've introduced.

Jun 26 2016, 9:46 PM
pstef added a comment to D6966: Multiple improvements of indent(1).

hi,

this /looks/ fine for me, but it's a bit late to get it into 11.0-RELEASE. I can look to commit it after the stable/11 branch tag is laid.

How's that sound?

Jun 26 2016, 4:57 AM

Jun 25 2016

pstef retitled D6966: Multiple improvements of indent(1) from to Multiple improvements of indent(1).
Jun 25 2016, 10:51 PM