User Details
- User Since
- Jun 25 2016, 9:00 PM (362 w, 1 d)
Sat, May 13
May 3 2023
What are the functions? Generally, passing a null pointer to a standard string function invokes UB regardless of the passed size, and some compilers do make optimizations based on this assumption.
Apr 29 2023
Reduce code duplication.
I was worried about some repetitive code here when adding the second source of commands (built-ins, after files from $PATH), but it became visibly worse when I started working on adding a third source (aliases). So the sooner I factor this out, the cleaner the future commits will be.
Apr 28 2023
Address reviews.
Apr 27 2023
builtincmd doesn't hold C strings, use memcmp().
Apr 26 2023
This doesn't follow the Don't Repeat Yourself principle, but currently I don't have a better idea how to express this code.
Feb 8 2023
My question about fprintf() remains unanswered, but it is not a blocker.
Feb 6 2023
Feb 5 2023
Minor style improvements, nitpicking and questions.
Jan 20 2023
Please provide more diff context (diff -U999999).
Jan 17 2023
Jan 8 2023
Back out the previous update.
The -1 was there for the i++ that the loop always performs, so it's needed regardless of whether strftime() returned 0 or more.
Split the calculation that was there before into two parts, one of which just decrements i and makes a comment on why it's done.
Minutes after posting the previous version, I thought about handling the rare corner case when strftime() returns 0.
Simplify the code part a bit.
Also improve comments and some variable names.
Jan 2 2023
When I was looking at this code today, I thought that the unconditional memccpy() is a bit wasteful in the \D{} case, because the one copied byte is a special case and when it's noticed, the copied byte is overwriten by strcpy() with "%X".
There is little to be gained in either performance or legibility of the code, but when I rewrote this locally to be less wasteful, it didn't look much worse, nor did it look much better.
Opinions?
Jan 1 2023
In this iteration I tried to address all new feedback.
I also was annoyed by the current formatting of the file, so this is a diff against D37926 where I reduce indentation.
Dec 29 2022
Drop PS4 support and update the manual page changes according to feedback.
Dec 24 2022
Dec 22 2022
Dec 20 2022
Hi, thanks for working on this.
Dec 16 2022
LGTM FWIW
Dec 15 2022
Dec 14 2022
Should this version become the default? On the one hand, it has POLA violation potential, on the other hand, it's what the command does under another system.
Dec 13 2022
Dec 12 2022
hw: column width ((h)ard (w)idth?)
Nov 24 2022
Nov 4 2022
If you intend to do more work on these files, I suggest improving the style before introducing more significant changes. There is a lot of inherited stylistic issues here, unfortunately.
I think you have a typo in the description and you meant "braces" - I meantion it just in case you planned to copy it to the commit message.
Nov 2 2022
Oct 31 2022
Would it be possible to omit the compat subdirectory from the import?
Oct 30 2022
@kib, sorry about not providing some aspects of the context of this change, I thought this was a good enough draft to get the first few reviews, but in hindsight it looks just lazy of me.
Oct 23 2022
Oct 21 2022
But the summary contains the same phrase twice, seems unintentional.
Oct 18 2022
Please remember to tag the commit as Relnotes: yes.
Aug 25 2022
Aug 24 2022
Aug 23 2022
Aug 22 2022
Aug 21 2022
Aug 20 2022
Aug 19 2022
@jilles is this patch in a good shape now?
Aug 16 2022
I already started looking into adding it to prevent my cat from powering off my system
Aug 7 2022
Rename base64.h to b64.h.
Aug 6 2022
Jul 31 2022
Add the missing semicolon in Symbol.map.
Add base64.h to INCS.
Jul 30 2022
Slightly change the approach: each not_fcnumber() check, keep consuming options until we need to jump to the next argptr.
Add a couple of test cases.
Jul 28 2022
Jul 26 2022
I've seen patches where BCPL-style comments are abused to form what we're used to see as block comments. So if we start allowing them, maybe say that they're allowed under some conditions (not sure what to specify here or how).
Jul 22 2022
@jilles what do you think about this one?
Jul 21 2022
Jul 19 2022
A little unfortunate to have these strange backslash sequences spread out further, but it's nothing that bash doesn't do.
Jul 18 2022
Simplify and add comments.
Handle rare cases the way bash does it.
Remove debugging changes not meant for review.
Place the result of strftime() in the right place instead of always at the beginning of the buffer.
Simplify conditional early exit.
Jul 17 2022
I've made the mistake of assuming that the first token has to be an option, but of course fc -1 must work.
Jul 16 2022
I accept this revision. I don't mind declarations after statements, but others might.