Page MenuHomeFreeBSD

pstef (Piotr Stefaniak)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2016, 9:00 PM (266 w, 2 d)

Recent Activity

Thu, Jul 15

pstef added a comment to D31146: cron: Implement -s command option.
In D31146#701876, @gbe wrote:

The man page part looks good, but I am a little bit confused, on my FreeBSD systems I see

root 66156 0.0 0.0 12800 1680 - Is 7Jul21 0:04.38 /usr/sbin/cron -s

when executing 'ps axuw'. So it seems, that some kind of a '-s' option is already implemented.

Thu, Jul 15, 9:34 AM

Jun 17 2021

pstef added inline comments to D30802: man9: add hz(9) and hardclock(9).
Jun 17 2021, 5:01 PM
pstef added inline comments to D30804: NOTES: Update the HZ entry with latest advice..
Jun 17 2021, 4:52 PM

May 20 2021

pstef accepted D29917: BeFS support for fstyp command.
May 20 2021, 7:38 PM

May 8 2021

pstef added inline comments to D30149: Example of basic OSS audio application.
May 8 2021, 12:39 PM

May 5 2021

pstef committed R10:c69775749f2b: getdirentries.2: remove unnecessary space (authored by pstef).
getdirentries.2: remove unnecessary space
May 5 2021, 11:06 AM
pstef committed R10:6ac7b0221f45: Balance parentheses in sysctl descriptions (authored by pstef).
Balance parentheses in sysctl descriptions
May 5 2021, 11:06 AM
pstef committed R10:2556ee3a27af: sh: fix debug build (authored by pstef).
sh: fix debug build
May 5 2021, 11:06 AM
pstef committed R10:bee62aa5a69f: sh: silence sanitizer (authored by pstef).
sh: silence sanitizer
May 5 2021, 11:06 AM
pstef committed R10:21b292072409: sh(1): autocomplete commands (authored by pstef).
sh(1): autocomplete commands
May 5 2021, 11:06 AM

May 3 2021

pstef accepted D29493: sh: implement persistent history storage.
May 3 2021, 5:18 AM

May 2 2021

pstef accepted D29493: sh: implement persistent history storage.

if (fd == -1 || (f = fdopen(fd, "w")) == NULL) and it will LGTM.

May 2 2021, 6:21 PM

Apr 30 2021

pstef added a comment to D29493: sh: implement persistent history storage.

I tested the save/restore history capabilities that are built into libedit and so far it looks good to me.

Apr 30 2021, 6:12 AM

Apr 11 2021

pstef committed R10:1fdd6934d596: getdirentries.2: remove unnecessary space (authored by pstef).
getdirentries.2: remove unnecessary space
Apr 11 2021, 9:18 AM
pstef committed R10:a212f56d10d0: Balance parentheses in sysctl descriptions (authored by pstef).
Balance parentheses in sysctl descriptions
Apr 11 2021, 8:38 AM
pstef committed R10:1a4e959eb34a: sh: fix debug build (authored by pstef).
sh: fix debug build
Apr 11 2021, 7:26 AM

Apr 7 2021

pstef added a comment to D26447: add deprecation notice to ftpd.

Hum, not a core system functionality? May I remind you that ftp://ftp.freebsd.org exists? Though it probably does not run the base system ftpd, it DOES run that functionality.

Apr 7 2021, 6:41 AM

Apr 6 2021

pstef accepted D26447: add deprecation notice to ftpd.

If there are security bugs in ftpd that will force us to release errata. It won't be the vocal users' responsibility to handle it. On the other hand, it wouldn't painful to pkg install ftpd unless you're emotionally attached. The existence of ftpd in base also provokes suggestions to maintain and enhance it (for example with encryption support).

Apr 6 2021, 1:56 PM

Apr 5 2021

pstef abandoned D29255: make shell started by "jexec -l [-U user] jail" a login shell.
Apr 5 2021, 7:32 PM
pstef added inline comments to D29591: gptboot.efi: Add man page.
Apr 5 2021, 7:25 PM

Apr 1 2021

pstef committed R10:5a18515b3143: sh: silence sanitizer (authored by pstef).
sh: silence sanitizer
Apr 1 2021, 5:34 AM

Mar 31 2021

pstef added inline comments to D29493: sh: implement persistent history storage.
Mar 31 2021, 7:48 AM
pstef added inline comments to D29493: sh: implement persistent history storage.
Mar 31 2021, 7:34 AM
pstef added inline comments to D29493: sh: implement persistent history storage.
Mar 31 2021, 1:48 AM

Mar 30 2021

pstef added inline comments to D29493: sh: implement persistent history storage.
Mar 30 2021, 9:09 PM
pstef added inline comments to D29493: sh: implement persistent history storage.
Mar 30 2021, 9:08 PM
pstef accepted D29494: sh: improve emacs mode.
Mar 30 2021, 8:21 PM
pstef added inline comments to D29493: sh: implement persistent history storage.
Mar 30 2021, 8:16 PM
pstef added inline comments to D29020: efifb,vbefb: implement vd_fini.
Mar 30 2021, 1:52 PM

Mar 29 2021

pstef committed R10:b315a7296d2a: sh(1): autocomplete commands (authored by pstef).
sh(1): autocomplete commands
Mar 29 2021, 9:23 AM
pstef closed D29361: sh(1): autocomplete commands.
Mar 29 2021, 9:22 AM

Mar 28 2021

pstef updated the diff for D29361: sh(1): autocomplete commands.

I believe that all reported issues (and more) have been addressed.

Mar 28 2021, 4:36 PM

Mar 27 2021

pstef committed R10:0e9d4b8b7574: security.7: fix typo in sysctl name (authored by pstef).
security.7: fix typo in sysctl name
Mar 27 2021, 6:49 PM

Mar 26 2021

pstef committed R10:4233882f4ed3: security.7: fix typo in sysctl name (authored by pstef).
security.7: fix typo in sysctl name
Mar 26 2021, 9:30 PM

Mar 24 2021

pstef updated the diff for D29361: sh(1): autocomplete commands.

Add code to remove duplicates.

Mar 24 2021, 8:18 AM

Mar 22 2021

pstef added inline comments to D29361: sh(1): autocomplete commands.
Mar 22 2021, 7:47 AM
pstef updated the diff for D29361: sh(1): autocomplete commands.

Apply some of the fixes suggested by Jilles.

Mar 22 2021, 7:30 AM

Mar 21 2021

pstef added a comment to D29361: sh(1): autocomplete commands.

Thanks, I tried to fix all the obvious mistakes. I will have to test and think about the rest of your comments.

Mar 21 2021, 7:28 PM
pstef updated the diff for D29361: sh(1): autocomplete commands.

Address mistakes pointed out by Alex.

Mar 21 2021, 7:25 PM
pstef updated the summary of D29361: sh(1): autocomplete commands.
Mar 21 2021, 2:46 PM
pstef requested review of D29361: sh(1): autocomplete commands.
Mar 21 2021, 2:29 PM

Mar 16 2021

pstef updated the diff for D29255: make shell started by "jexec -l [-U user] jail" a login shell.

@kevans pointed out to me that my previous patch replaces the name with a dash character, while login(1) only prepends the dash to the original program name, so that's probably what shells expect. I did try to fix that, it seems to work for the few cases that I tested, but in the meantime someone asked about Linux jails, which I looked into. Those can't be properly supported since our getpwnam won't work with the underlying system's structure; so while it is possible to spawn a login shell, the shell would always be /bin/sh which under standard Ubuntu seems to translate into dash, not a great shell for interactive use.

Mar 16 2021, 10:50 PM

Mar 14 2021

pstef updated the diff for D29255: make shell started by "jexec -l [-U user] jail" a login shell.

Agree with jamie's comments.

Mar 14 2021, 7:08 PM
pstef requested review of D29255: make shell started by "jexec -l [-U user] jail" a login shell.
Mar 14 2021, 2:18 PM

Aug 14 2020

pstef added inline comments to D26064: Check XHCI endpoint state before issuing XHCI endpoint commands.
Aug 14 2020, 10:41 AM

Aug 3 2020

pstef committed rS363788: MFC 363621: sh(1): print a newline when ^D quits sh.
MFC 363621: sh(1): print a newline when ^D quits sh
Aug 3 2020, 6:54 AM

Jul 31 2020

pstef committed rS363724: MFC r363268:.
MFC r363268:
Jul 31 2020, 7:37 AM

Jul 27 2020

pstef closed D25813: sh(1): print a newline when ^D exits sh.
Jul 27 2020, 6:46 PM
pstef committed rS363621: sh(1): print a newline when ^D quits sh.
sh(1): print a newline when ^D quits sh
Jul 27 2020, 6:46 PM
pstef accepted D25398: w: remove proc_compare().

I would also remove the "most interesting" comment.

Jul 27 2020, 5:46 AM

Jul 26 2020

pstef updated the summary of D25813: sh(1): print a newline when ^D exits sh.
Jul 26 2020, 10:42 AM
pstef requested review of D25813: sh(1): print a newline when ^D exits sh.
Jul 26 2020, 10:42 AM

Jul 25 2020

pstef committed rS363525: MFC r342576-342577,342645,342812,342881,343231,343399 (by trasz):.
MFC r342576-342577,342645,342812,342881,343231,343399 (by trasz):
Jul 25 2020, 11:57 AM

Jul 17 2020

pstef committed rS363268: Promote use of unprivileged users for building ports by documenting SU_CMD..
Promote use of unprivileged users for building ports by documenting SU_CMD.
Jul 17 2020, 6:33 AM
pstef closed D25433: ports.7: mention SU_CMD.
Jul 17 2020, 6:33 AM · portmgr, manpages

Jul 16 2020

pstef updated the diff for D25433: ports.7: mention SU_CMD.

Phrasing by Daniel O'Connor.

Jul 16 2020, 8:50 AM · portmgr, manpages

Jul 4 2020

pstef committed rS362924: MFC r362705 and r362707:.
MFC r362705 and r362707:
Jul 4 2020, 6:35 AM

Jun 29 2020

pstef committed rS362773: MFC r362495:.
MFC r362495:
Jun 29 2020, 6:28 AM

Jun 27 2020

pstef committed rS362707: ps(1): don't try to handle non-SMP systems.
ps(1): don't try to handle non-SMP systems
Jun 27 2020, 8:02 PM
pstef closed D25377: ps(1): reuse keyword "cpu" to show CPU number.
Jun 27 2020, 7:09 PM
pstef committed rS362705: ps(1): reuse keyword "cpu" to show CPU number.
ps(1): reuse keyword "cpu" to show CPU number
Jun 27 2020, 7:09 PM
pstef added a comment to D25487: kern.tty_info_kstacks: add a compact format.
In D25487#562808, @mjg wrote:

Side note is that I think the shorter format should be the default.

Jun 27 2020, 3:10 PM
pstef committed rS362673: MFC r362429 and r362430:.
MFC r362429 and r362430:
Jun 27 2020, 9:01 AM

Jun 26 2020

pstef added a comment to D25433: ports.7: mention SU_CMD.
In D25433#562475, @0mp wrote:

Just a note for your consideration: I wonder if we should mention there, that people often use set SU_CMD to use sudo (I do at least):

.if exists(/usr/local/bin/sudo)
SU_CMD= /usr/local/bin/sudo -E sh -c
.endif
Jun 26 2020, 9:13 PM · portmgr, manpages
pstef added a comment to D25433: ports.7: mention SU_CMD.

What I did is I think consistent with the rest of the file, for example

.It Cm fetch
Fetch all of the files needed to build this port from the sites
listed in
.Va MASTER_SITES
and
.Va PATCH_SITES .
See
.Va FETCH_CMD , MASTER_SITE_OVERRIDE
and
.Va MASTER_SITE_BACKUP .
Jun 26 2020, 9:06 PM · portmgr, manpages

Jun 25 2020

pstef updated the diff for D25377: ps(1): reuse keyword "cpu" to show CPU number.

Don't make keyword descriptions even less sorted than they are now.

Jun 25 2020, 2:49 PM
pstef added a comment to D25447: lib/flua: Add bindings for libifconfig.

I can see some potential for automation and orchestration.

Jun 25 2020, 2:39 PM

Jun 24 2020

pstef edited projects for D25433: ports.7: mention SU_CMD, added: portmgr; removed Ports Committers.
Jun 24 2020, 8:58 PM · portmgr, manpages
pstef added a project to D25433: ports.7: mention SU_CMD: Ports Committers.
Jun 24 2020, 8:56 PM · portmgr, manpages
pstef edited projects for D25433: ports.7: mention SU_CMD, added: manpages; removed docs.
Jun 24 2020, 8:50 PM · portmgr, manpages
pstef added a project to D25433: ports.7: mention SU_CMD: docs.
Jun 24 2020, 8:36 PM · portmgr, manpages
pstef requested review of D25433: ports.7: mention SU_CMD.
Jun 24 2020, 8:33 PM · portmgr, manpages

Jun 23 2020

pstef committed rS362547: pstat(8): improve the Size header width after r358181.
pstat(8): improve the Size header width after r358181
Jun 23 2020, 6:19 PM
pstef added a comment to D25398: w: remove proc_compare().

It's not immediately obvious to me why rS29310 would render this a no-op, but I know that the use of ki_estcpu instead of ki_pctcpu is bogus for anything but the 4BSD scheduler.

Jun 23 2020, 5:04 PM
pstef closed D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.
Jun 23 2020, 3:23 AM
pstef closed D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.
Jun 23 2020, 3:17 AM

Jun 22 2020

pstef committed rS362508: MFC r358405 (by hrs):.
MFC r358405 (by hrs):
Jun 22 2020, 7:16 PM
pstef committed rS362507: MFC r357186 (by imp): Remove old device list.
MFC r357186 (by imp): Remove old device list
Jun 22 2020, 7:09 PM
pstef committed rS362506: MFC r357186 (by imp): Remove old device list.
MFC r357186 (by imp): Remove old device list
Jun 22 2020, 7:09 PM
pstef committed rS362495: strtok(3): make it easier to find the RETURN VALUES section.
strtok(3): make it easier to find the RETURN VALUES section
Jun 22 2020, 11:03 AM

Jun 21 2020

pstef committed rS362469: MFC r349235 (by allanjude):.
MFC r349235 (by allanjude):
Jun 21 2020, 8:23 PM
pstef accepted D24844: libc/resolv: attempt to fix the test under WARNS=6.
Jun 21 2020, 1:12 PM
pstef added a comment to D23429: rescue: add fetch.

This seems big, I'd suggest asking freebsd-arch@

Jun 21 2020, 8:56 AM
pstef accepted D23942: Document that gettimeofday() is obsolescent.
Jun 21 2020, 8:22 AM
pstef added inline comments to D24844: libc/resolv: attempt to fix the test under WARNS=6.
Jun 21 2020, 8:06 AM
pstef accepted D25009: flua: add ucl library.
Jun 21 2020, 8:00 AM
pstef accepted D25174: w: use locale-based format specifiers.
Jun 21 2020, 7:56 AM
pstef added inline comments to D25365: Early WIP: convert login.conf to UCL.
Jun 21 2020, 7:52 AM
pstef added a comment to D25338: Do not recommend sleeping when using vipw(8) non-interactively.

I would move the "The mechanism for checking for password file modifications requires that the modification time of the password file changes." part under a NOTES section and then remove the BUGS section.

Jun 21 2020, 7:29 AM

Jun 20 2020

pstef retitled D25377: ps(1): reuse keyword "cpu" to show CPU number from ps(1): add a cpu# flag to ps(1): reuse keyword "cpu" to show CPU number.
Jun 20 2020, 10:56 PM
pstef updated the diff for D25377: ps(1): reuse keyword "cpu" to show CPU number.

Handle non-SMP systems

Jun 20 2020, 10:44 PM
pstef updated the diff for D25377: ps(1): reuse keyword "cpu" to show CPU number.

Changed my mind, the new functionality will replace the old one.

Jun 20 2020, 9:53 PM
pstef updated the summary of D25377: ps(1): reuse keyword "cpu" to show CPU number.
Jun 20 2020, 7:31 PM
pstef updated the summary of D25377: ps(1): reuse keyword "cpu" to show CPU number.
Jun 20 2020, 7:30 PM
pstef requested review of D25377: ps(1): reuse keyword "cpu" to show CPU number.
Jun 20 2020, 7:30 PM
pstef closed D25369: Make vipw error message less cryptic.
Jun 20 2020, 6:20 AM
pstef committed rS362430: Make vipw error message less cryptic.
Make vipw error message less cryptic
Jun 20 2020, 6:20 AM
pstef committed rS362429: libutil: remove extraneous ": " from error messages.
libutil: remove extraneous ": " from error messages
Jun 20 2020, 6:11 AM
pstef updated the summary of D25369: Make vipw error message less cryptic.
Jun 20 2020, 1:10 AM
pstef requested review of D25369: Make vipw error message less cryptic.
Jun 20 2020, 1:10 AM