Page MenuHomeFreeBSD

pstef (Piotr Stefaniak)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2016, 9:00 PM (421 w, 3 d)

Recent Activity

Jun 7 2024

pstef added a comment to D45073: sh(1): Improve recommendation of use of -e.

I'd say that we shouldn't make any recommendations on how to use parts of a language in our manual. We should instead focus on facts, list them all and describe as they are. If there is some kind of interaction between parts of the language that is possibly counter-intuitive then we can and probably should indicate directly or indirectly that something requires consideration, but at the same time we should keep the manual free of judgement.

Jun 7 2024, 7:43 PM

May 6 2024

pstef committed rG3f0b80bc1537: ps: handle incorrect -D values (authored by jamie_catflap.org).
ps: handle incorrect -D values
May 6 2024, 5:15 PM

Mar 14 2024

pstef added a comment to D42327: vfs mount: Consistently use ENODEV internally for an invalid fstype.
Mar 14 2024, 4:51 PM

Mar 9 2024

pstef added a comment to D42327: vfs mount: Consistently use ENODEV internally for an invalid fstype.

@jhb do you think the following is related?

Mar 9 2024, 9:33 PM

Feb 18 2024

pstef committed rGc8691d183da3: tcp: Silence a -Wunused-function warning in tcp_ratelimit.h (authored by markj).
tcp: Silence a -Wunused-function warning in tcp_ratelimit.h
Feb 18 2024, 2:29 PM

Feb 16 2024

pstef abandoned D43301: Ports: update www/netsurf to 3.11.

Already committed.

Feb 16 2024, 6:30 PM

Feb 8 2024

pstef committed rG94ddf40c0f5d: tcp_wrappers: silence a few warnings (authored by pstef).
tcp_wrappers: silence a few warnings
Feb 8 2024, 5:45 PM
pstef committed rG43b7fec10b6b: libcompat: silence -Wdeprecated-non-prototype (authored by pstef).
libcompat: silence -Wdeprecated-non-prototype
Feb 8 2024, 5:45 PM

Feb 6 2024

pstef committed rG12bae251fbfa: libcompat: silence -Wdeprecated-non-prototype (authored by pstef).
libcompat: silence -Wdeprecated-non-prototype
Feb 6 2024, 7:34 PM
pstef closed D43723: libcompat: silence -Wdeprecated-non-prototype.
Feb 6 2024, 7:34 PM

Feb 3 2024

pstef requested review of D43723: libcompat: silence -Wdeprecated-non-prototype.
Feb 3 2024, 6:18 PM

Jan 23 2024

pstef accepted D43558: bintrans: Add base64 to name list in manual page..
Jan 23 2024, 3:37 PM

Jan 22 2024

pstef committed rG8297ff13fb60: tcp_wrappers: silence a few warnings (authored by pstef).
tcp_wrappers: silence a few warnings
Jan 22 2024, 4:25 PM
pstef closed D43531: tcp_wrappers: silence a -Wdeprecated-non-prototype warning.
Jan 22 2024, 4:24 PM

Jan 21 2024

pstef added a comment to D43518: Implement kcmp(2).

FWIW, Chromium also complains about the lack of kcmp.

Jan 21 2024, 7:17 PM
pstef retitled D43531: tcp_wrappers: silence a -Wdeprecated-non-prototype warning from tcp_wrappers: silence a few warnings to tcp_wrappers: silence a -Wdeprecated-non-prototype warning.
Jan 21 2024, 10:33 AM
pstef requested review of D43531: tcp_wrappers: silence a -Wdeprecated-non-prototype warning.
Jan 21 2024, 10:18 AM

Jan 4 2024

pstef added a reviewer for D43301: Ports: update www/netsurf to 3.11: Contributor Reviewers (ports).
Jan 4 2024, 11:13 AM
pstef requested review of D43301: Ports: update www/netsurf to 3.11.
Jan 4 2024, 11:08 AM

Dec 3 2023

pstef added a comment to D42880: wireguard: extend ifconfig.

I'm not sure about how useful this is to me. I use ifconfig to take a glance at all interfaces and if I want to learn more specifically about the state of the wg interface, I just run wg. I know it's obvious, I just mean that I never missed this information when looking at ifconfig output. On the other hand, with this patch, the output is longer and somewhat less readable.

Dec 3 2023, 4:02 PM

Nov 29 2023

pstef added inline comments to D42832: EN for OpenZFS data corruption issue.
Nov 29 2023, 6:13 PM

Nov 11 2023

pstef accepted D42552: Update ps.1 regarding -D option and wrong assumption about -p x/d interaction.
Nov 11 2023, 7:44 PM

Oct 25 2023

pstef accepted D42327: vfs mount: Consistently use ENODEV internally for an invalid fstype.

Thanks for the information and apologies for the mess.
For me the case where the filesystem name was wrong and mount complained about file not existing was more common and more annoying since it was easy to see that the designated mount point clearly existed.

Oct 25 2023, 4:01 PM

Oct 24 2023

pstef added a comment to D42327: vfs mount: Consistently use ENODEV internally for an invalid fstype.

What are the user-facing errors in various cases after this?

Oct 24 2023, 6:36 PM

Sep 30 2023

pstef added a comment to D42027: netlink: fix accessing freed memory.

I'm not sure but it seems that on the changed lines you replaced space indentation with tabs.

Sep 30 2023, 3:40 PM

Sep 24 2023

pstef accepted D41949: mailmap: Add pstef and val.
Sep 24 2023, 10:05 AM

Sep 23 2023

pstef committed rGa675eaec5aef: sh: implement PS1 \D to print current time (authored by pstef).
sh: implement PS1 \D to print current time
Sep 23 2023, 6:29 PM
pstef closed D35840: sh: implement PS1 \D to print current time.
Sep 23 2023, 6:28 PM

Sep 14 2023

pstef added inline comments to D41849: virtio: add comment on the spec for vring struct.
Sep 14 2023, 6:29 AM
pstef added inline comments to D41851: virtio: start simple, document virtio_endian(9).
Sep 14 2023, 6:28 AM · manpages
pstef added inline comments to D41853: virtio: add introduction to virtio, document virtio.h.
Sep 14 2023, 6:23 AM
pstef added inline comments to D41852: virtio: add man page for virtqueue(9) functions.
Sep 14 2023, 6:05 AM

Sep 12 2023

pstef committed rGc996638497d1: tslog.4: fix typo (authored by pstef).
tslog.4: fix typo
Sep 12 2023, 7:11 PM
pstef committed rG8e5c53af831b: sh: also auto-complete functions (authored by pstef).
sh: also auto-complete functions
Sep 12 2023, 4:43 PM
pstef committed rGbec7b9a21979: sh: introduce a function to iterate over all hashed commands (authored by pstef).
sh: introduce a function to iterate over all hashed commands
Sep 12 2023, 4:43 PM
pstef committed rG0fd450e2895e: sh: tab-complete aliases (authored by pstef).
sh: tab-complete aliases
Sep 12 2023, 4:43 PM
pstef committed rG2fc4a84ed828: sh: introduce a function to iterate over all aliases (authored by pstef).
sh: introduce a function to iterate over all aliases
Sep 12 2023, 4:43 PM
pstef committed rG63b6e661d25c: sh: reindent a for loop in parser.c (authored by pstef).
sh: reindent a for loop in parser.c
Sep 12 2023, 4:43 PM
pstef closed D40619: sh: auto-complete functions and aliases.
Sep 12 2023, 4:43 PM
pstef closed D37926: sh: reindent a for loop in parser.c.
Sep 12 2023, 4:43 PM

Aug 25 2023

pstef requested changes to D16132: New cmb(3) library and cmb(1) utility.

As of stable/14 this no longer compiles for me due to

/usr/src/lib/libcmb/cmb.c:854:6: error: invalid argument type 'void' to unary expression
        if (!BN_zero(count))
            ^~~~~~~~~~~~~~~
/usr/src/lib/libcmb/cmb.c:1032:7: error: invalid argument type 'void' to unary expression
                if (!BN_zero(seq))
                    ^~~~~~~~~~~~~
2 errors generated.
Aug 25 2023, 5:58 PM

Aug 24 2023

pstef committed rG5c0a1c15ff8c: ps: add a new option -D to reimplement tree traversal (authored by pstef).
ps: add a new option -D to reimplement tree traversal
Aug 24 2023, 4:38 PM
pstef committed rGf06e32e9b9e4: Revert "ps: extend the non-standard option -d (tree view) to work with -p" (authored by pstef).
Revert "ps: extend the non-standard option -d (tree view) to work with -p"
Aug 24 2023, 4:37 PM
pstef added a reverting change for rGca8c0d5e8110: ps: extend the non-standard option -d (tree view) to work with -p: rGf06e32e9b9e4: Revert "ps: extend the non-standard option -d (tree view) to work with -p".
Aug 24 2023, 4:37 PM
pstef closed D41231: ps: split tree traversal to a separate option.
Aug 24 2023, 4:37 PM

Aug 20 2023

pstef updated the diff for D41231: ps: split tree traversal to a separate option.
  1. -D doesn't imply -d anymore. I found that to be unnecessarily limiting, now users can decide on the visual format.
  2. The usage output and the manual page are updated.
Aug 20 2023, 8:04 AM

Aug 19 2023

pstef updated the diff for D41231: ps: split tree traversal to a separate option.

Add -D both.

Aug 19 2023, 11:05 PM
pstef updated the diff for D41231: ps: split tree traversal to a separate option.

Follow advice from Jamie and use -D up and -D down.

Aug 19 2023, 10:48 PM

Jul 29 2023

pstef added a reverting change for rGca8c0d5e8110: ps: extend the non-standard option -d (tree view) to work with -p: D41231: ps: split tree traversal to a separate option.
Jul 29 2023, 7:11 PM
pstef requested review of D41231: ps: split tree traversal to a separate option.
Jul 29 2023, 7:11 PM

Jul 7 2023

pstef updated the diff for D40619: sh: auto-complete functions and aliases.

Address comments from Jilles.

Jul 7 2023, 6:40 PM

Jun 29 2023

pstef accepted D40788: Restore and document -ps / -nps option..
Jun 29 2023, 1:54 PM
pstef added a comment to D40788: Restore and document -ps / -nps option..

If it's just an effort to synchronize with OpenBSD then I vote against this change. I intentionally removed this option years ago, so I have to assume that the difference here comes from the fact that OpenBSD didn't.
If, however, you want to restore this functionality for whatever reason, I will only make a face and accept it.

Jun 29 2023, 1:32 PM

Jun 20 2023

pstef updated the summary of D40619: sh: auto-complete functions and aliases.
Jun 20 2023, 8:38 AM
pstef requested review of D40619: sh: auto-complete functions and aliases.
Jun 20 2023, 8:36 AM

Jun 19 2023

pstef committed rG14dd001235f9: sh: also auto-complete built-ins (authored by pstef).
sh: also auto-complete built-ins
Jun 19 2023, 5:28 PM
pstef closed D39839: sh: also auto-complete built-ins.
Jun 19 2023, 5:28 PM

May 13 2023

pstef committed rG411942a70eb6: GENERIC: remove a stray space character (authored by pstef).
GENERIC: remove a stray space character
May 13 2023, 8:06 PM
pstef committed rG43489c142e56: sh: improve style (authored by pstef).
sh: improve style
May 13 2023, 8:06 PM

May 3 2023

pstef added a comment to D37627: Disable errors for -Wnonnull for the kernel for GCC 12..

What are the functions? Generally, passing a null pointer to a standard string function invokes UB regardless of the passed size, and some compilers do make optimizations based on this assumption.

May 3 2023, 6:35 AM

Apr 29 2023

pstef updated the diff for D39839: sh: also auto-complete built-ins.

Reduce code duplication.
I was worried about some repetitive code here when adding the second source of commands (built-ins, after files from $PATH), but it became visibly worse when I started working on adding a third source (aliases). So the sooner I factor this out, the cleaner the future commits will be.

Apr 29 2023, 8:48 PM

Apr 28 2023

pstef added inline comments to D39839: sh: also auto-complete built-ins.
Apr 28 2023, 6:45 AM
pstef updated the diff for D39839: sh: also auto-complete built-ins.

Address reviews.

Apr 28 2023, 6:44 AM

Apr 27 2023

pstef added inline comments to D39839: sh: also auto-complete built-ins.
Apr 27 2023, 4:45 PM
pstef updated the diff for D39839: sh: also auto-complete built-ins.

builtincmd doesn't hold C strings, use memcmp().

Apr 27 2023, 6:13 AM

Apr 26 2023

pstef added a comment to D39839: sh: also auto-complete built-ins.

This doesn't follow the Don't Repeat Yourself principle, but currently I don't have a better idea how to express this code.

Apr 26 2023, 8:12 PM
pstef requested review of D39839: sh: also auto-complete built-ins.
Apr 26 2023, 8:11 PM

Feb 8 2023

pstef accepted D38386: Add nproc(1).
Feb 8 2023, 7:40 PM
pstef accepted D38386: Add nproc(1).

My question about fprintf() remains unanswered, but it is not a blocker.

Feb 8 2023, 12:14 PM

Feb 6 2023

pstef accepted D38399: tarfs: Fix typo in man page..
Feb 6 2023, 3:06 PM

Feb 5 2023

pstef added inline comments to D38386: Add nproc(1).
Feb 5 2023, 10:27 AM
pstef added a comment to D38386: Add nproc(1).

TODO: write the manpage

Feb 5 2023, 10:08 AM
pstef added inline comments to D38386: Add nproc(1).
Feb 5 2023, 8:10 AM
pstef added a comment to D38386: Add nproc(1).

Minor style improvements, nitpicking and questions.

Feb 5 2023, 7:53 AM

Jan 20 2023

pstef added a comment to D38047: Multiple fixes to the NSS caching system.

Please provide more diff context (diff -U999999).

Jan 20 2023, 5:00 PM · Src Committers
pstef added inline comments to D38047: Multiple fixes to the NSS caching system.
Jan 20 2023, 4:55 PM · Src Committers

Jan 17 2023

pstef accepted D38097: df: Return non-zero status on write failure..
Jan 17 2023, 3:21 PM

Jan 8 2023

pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Back out the previous update.
The -1 was there for the i++ that the loop always performs, so it's needed regardless of whether strftime() returned 0 or more.
Split the calculation that was there before into two parts, one of which just decrements i and makes a comment on why it's done.

Jan 8 2023, 12:56 PM
pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Minutes after posting the previous version, I thought about handling the rare corner case when strftime() returns 0.

Jan 8 2023, 10:46 AM
pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Simplify the code part a bit.
Also improve comments and some variable names.

Jan 8 2023, 10:35 AM

Jan 2 2023

pstef added inline comments to D37753: Add tarfs, a filesystem backed by tarballs..
Jan 2 2023, 4:06 PM
pstef added a comment to D35840: sh: implement PS1 \D to print current time.

When I was looking at this code today, I thought that the unconditional memccpy() is a bit wasteful in the \D{} case, because the one copied byte is a special case and when it's noticed, the copied byte is overwriten by strcpy() with "%X".
There is little to be gained in either performance or legibility of the code, but when I rewrote this locally to be less wasteful, it didn't look much worse, nor did it look much better.
Opinions?

Jan 2 2023, 12:10 AM

Jan 1 2023

pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

In this iteration I tried to address all new feedback.
I also was annoyed by the current formatting of the file, so this is a diff against D37926 where I reduce indentation.

Jan 1 2023, 7:46 PM
pstef requested review of D37926: sh: reindent a for loop in parser.c.
Jan 1 2023, 7:43 PM

Dec 29 2022

pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Drop PS4 support and update the manual page changes according to feedback.

Dec 29 2022, 9:57 AM

Dec 24 2022

pstef committed rG36802990d64c: ls(1): add a -v flag to sort naturally (authored by obiwac_gmail.com).
ls(1): add a -v flag to sort naturally
Dec 24 2022, 7:23 AM
pstef committed rG149466a516b2: ping: split the visual part of -f into a new option -. (authored by pstef).
ping: split the visual part of -f into a new option -.
Dec 24 2022, 7:23 AM

Dec 22 2022

pstef added a comment to D37753: Add tarfs, a filesystem backed by tarballs..
Dec 22 2022, 10:13 PM

Dec 20 2022

pstef added a comment to D37753: Add tarfs, a filesystem backed by tarballs..

Hi, thanks for working on this.

Dec 20 2022, 5:04 PM

Dec 16 2022

pstef accepted D37712: daily 150.clean-hoststat: suppress error when using dma.

LGTM FWIW

Dec 16 2022, 2:48 PM
pstef added inline comments to D37712: daily 150.clean-hoststat: suppress error when using dma.
Dec 16 2022, 10:43 AM

Dec 15 2022

pstef added inline comments to D37695: bin/uuidgen: add support for v4 uuids.
Dec 15 2022, 7:10 AM

Dec 14 2022

pstef added a comment to D37695: bin/uuidgen: add support for v4 uuids.

Should this version become the default? On the one hand, it has POLA violation potential, on the other hand, it's what the command does under another system.

Dec 14 2022, 10:38 AM

Dec 13 2022

pstef added inline comments to D37674: add sizeof(7) man page.
Dec 13 2022, 9:30 PM
pstef accepted D37683: sizeof(7): miscellaneous edits.
Dec 13 2022, 9:16 PM
pstef added a comment to D37674: add sizeof(7) man page.

Initial review.

Dec 13 2022, 7:57 AM

Dec 12 2022

pstef accepted D37676: diff: fix side-by-side output with tabbed input.

hw: column width ((h)ard (w)idth?)

Dec 12 2022, 8:20 PM

Nov 24 2022

pstef added a reviewer for D37478: Add support for mounting single files in nullfs: mjg.
Nov 24 2022, 8:12 PM

Nov 4 2022

pstef added a comment to D37263: getty: code cleanup, part 1.

If you intend to do more work on these files, I suggest improving the style before introducing more significant changes. There is a lot of inherited stylistic issues here, unfortunately.
I think you have a typo in the description and you meant "braces" - I meantion it just in case you planned to copy it to the commit message.

Nov 4 2022, 2:02 PM

Nov 2 2022

pstef added inline comments to D37236: gzip: Add support for decompressing zstd files..
Nov 2 2022, 3:23 PM