Page MenuHomeFreeBSD

pstef (Piotr Stefaniak)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2016, 9:00 PM (308 w, 1 d)

Recent Activity

Yesterday

pstef abandoned D35282: lang/python310: Add OPTIONS for: editline, ports editline, ports readline or none.
Sun, May 22, 6:11 AM

Sat, May 21

pstef added a comment to D35282: lang/python310: Add OPTIONS for: editline, ports editline, ports readline or none.

What the port does is:
$ file /usr/local/lib/libedit.so.0
/usr/local/lib/libedit.so.0: symbolic link to libedit.so.0.0.68
The port turns out to be a Debian-made repackaging of the NetBSD library.

Sat, May 21, 11:49 PM
pstef added a comment to D35282: lang/python310: Add OPTIONS for: editline, ports editline, ports readline or none.

Huh, as it is, it cannot pick up the base editline at all. It's looking for /lib/libedit.so.0 and ours (well, mine) is /lib/libedit.so.8.

Sat, May 21, 11:16 PM
pstef added a comment to D35282: lang/python310: Add OPTIONS for: editline, ports editline, ports readline or none.

I think I'll need to drop the "editline (ports)" option, there's no way to choose one or the other when both are installed.

Sat, May 21, 11:02 PM
pstef requested review of D35282: lang/python310: Add OPTIONS for: editline, ports editline, ports readline or none.
Sat, May 21, 10:52 PM

Sat, Apr 30

pstef committed R10:d9d0812bc6e9: sh: implement persistent history storage (authored by bapt).
sh: implement persistent history storage
Sat, Apr 30, 8:05 AM
pstef committed R10:963fdecd1a26: uudecode: correct error message (authored by pstef).
uudecode: correct error message
Sat, Apr 30, 8:05 AM
pstef committed R10:2eef2f0f8f60: uu{encode,decode}: improve style (authored by pstef).
uu{encode,decode}: improve style
Sat, Apr 30, 8:05 AM
pstef committed R10:6e1f0f800689: libfetch: remove a set-but-not-used variable (authored by se).
libfetch: remove a set-but-not-used variable
Sat, Apr 30, 8:05 AM

Sun, Apr 24

pstef committed R10:ed016aa43541: base64: ignore -i as promised (authored by pstef).
base64: ignore -i as promised
Sun, Apr 24, 6:25 AM
pstef committed R10:aad4fd549589: Add a quoted-printable encoder/decoder (authored by pstef).
Add a quoted-printable encoder/decoder
Sun, Apr 24, 6:25 AM
pstef committed R10:9d68da4ee855: bintrans: make mmencode.c compilable (authored by pstef).
bintrans: make mmencode.c compilable
Sun, Apr 24, 6:25 AM
pstef committed R10:ff2b1ffbb045: bintrans: adjust mmencode.c to style(9) (authored by pstef).
bintrans: adjust mmencode.c to style(9)
Sun, Apr 24, 6:25 AM
pstef committed R10:8a65b02daca6: bintrans: import mmencode.c for quoted-printable en/de-coding (authored by pstef).
bintrans: import mmencode.c for quoted-printable en/de-coding
Sun, Apr 24, 6:25 AM
pstef closed D34933: Import a quoted-printable bidirectional converter.
Sun, Apr 24, 6:24 AM

Sat, Apr 23

pstef added a comment to D35033: bsdinstall/partedit: fix UFS auto partitioning.

Minor nit.

Sat, Apr 23, 8:40 AM

Apr 22 2022

pstef added inline comments to D34762: ctld: Fix coverity raised issues.
Apr 22 2022, 1:34 PM

Apr 19 2022

pstef accepted D34941: diff3: Clean up printing of ranges for edscript output.

Maybe if the file was mmapped and the r->fromth line found via memchr() or similar, that would be faster.

Apr 19 2022, 8:32 AM

Apr 18 2022

pstef accepted D34950: diff: tests: loosen up requirements for report_identical.

I think I'm the one to blame for this, but I've never understood ATF and from other usage across our repo it wasn't clear to me how to properly do this.

Apr 18 2022, 9:41 PM
pstef committed R10:d399eb3ef7f8: ping: split the visual part of -f into a new option -. (authored by pstef).
ping: split the visual part of -f into a new option -.
Apr 18 2022, 5:15 PM
pstef closed D34882: ping: split the visual part of -f into a new option -..
Apr 18 2022, 5:15 PM
pstef added inline comments to D34941: diff3: Clean up printing of ranges for edscript output.
Apr 18 2022, 2:02 PM
pstef committed R10:2ad786c63ae2: b64encode: implement -w to wrap lines (authored by pstef).
b64encode: implement -w to wrap lines
Apr 18 2022, 11:57 AM
pstef committed R10:540a99289bb1: Add the base64 command using b64encode and b64decode (authored by pstef).
Add the base64 command using b64encode and b64decode
Apr 18 2022, 11:57 AM
pstef committed R10:f331cf9b043a: bintrans: reinstate a test case that I lost (authored by pstef).
bintrans: reinstate a test case that I lost
Apr 18 2022, 11:57 AM
pstef closed D32945: Implement base64(1).
Apr 18 2022, 11:56 AM
pstef closed D32944: b64encode: implement -w to wrap lines.
Apr 18 2022, 11:56 AM
pstef committed R10:4cd4841a2773: Modularize uuencode and uudecode by wrapping them in bintrans.c (authored by pstef).
Modularize uuencode and uudecode by wrapping them in bintrans.c
Apr 18 2022, 8:55 AM
pstef committed R10:47bcbde91dea: bintrans: move files to a new directory (authored by pstef).
bintrans: move files to a new directory
Apr 18 2022, 8:55 AM
pstef closed D32943: Modularize uuencode and uudecode by wrapping them in bintrans.c.
Apr 18 2022, 8:55 AM
pstef added a comment to D34896: strcpy(3): Explicitly mention the recommended usage of strlcpy().

To be honest, if I need to quote someone to make my argument stronger, it would be Chris: https://ramblings.implicit.net/c/2014/05/02/c-functions-that-should-be-avoided-part-2.html

Apr 18 2022, 5:18 AM

Apr 17 2022

pstef added a comment to D34896: strcpy(3): Explicitly mention the recommended usage of strlcpy().

Playing devil's advocate, I can't help but not include (one of many) famous Ulrich's quotes:

Dammit, it is not safe. It hides bugs in programs. If a string is too long for an allocated memory block the copying must not simply silently stop. Instead the program must reallocate or signal an error. I can construct you cases where the use of these stupid functions is creating new security problem.

Admittedly, his canonical way to handle these situations uses unportable mempcpy() function, a GNU extension which returns adjusted destination, but still, all-caps scary warning might be a bit too much for the manpage, despite the almost modifier. IMHO it should be either toned down, or better elaborated.

Apr 17 2022, 6:44 PM

Apr 16 2022

pstef added a comment to D32943: Modularize uuencode and uudecode by wrapping them in bintrans.c.

Thanks again for reviewing this!

Apr 16 2022, 7:14 PM
pstef updated the diff for D32943: Modularize uuencode and uudecode by wrapping them in bintrans.c.

Address some of the comments made by delphij.

Apr 16 2022, 7:03 PM

Apr 15 2022

pstef updated the diff for D34882: ping: split the visual part of -f into a new option -..

Address comments by rpokala.
I decided to choose the word "period" over "dot" because the former was already here.

Apr 15 2022, 8:37 PM
pstef requested review of D34933: Import a quoted-printable bidirectional converter.
Apr 15 2022, 8:26 PM
pstef updated the diff for D32945: Implement base64(1).

Rebase.

Apr 15 2022, 8:20 PM
pstef updated the diff for D32944: b64encode: implement -w to wrap lines.

Rebase.

Apr 15 2022, 8:20 PM
pstef updated the diff for D32943: Modularize uuencode and uudecode by wrapping them in bintrans.c.

Rename bin2text2bin to bintrans. Update the manual page.

Apr 15 2022, 8:19 PM
pstef accepted D34912: diff3: allow diff3 ed scripts to generate deletions.
Apr 15 2022, 1:57 PM
pstef accepted D34912: diff3: allow diff3 ed scripts to generate deletions.
Apr 15 2022, 1:55 PM

Apr 14 2022

pstef added inline comments to D34912: diff3: allow diff3 ed scripts to generate deletions.
Apr 14 2022, 3:47 PM

Apr 13 2022

pstef committed R10:c8f0a1c6d756: sh: fix autocompletion for commands that share name with a directory (authored by pstef).
sh: fix autocompletion for commands that share name with a directory
Apr 13 2022, 7:02 PM

Apr 11 2022

pstef requested review of D34882: ping: split the visual part of -f into a new option -..
Apr 11 2022, 3:02 PM

Apr 7 2022

pstef updated the diff for D32943: Modularize uuencode and uudecode by wrapping them in bintrans.c.

Remove uudecode remnants from Makefile.inc1, etc/mtree/BSD.tests.dist, targets/pseudo/tests/Makefile.depend, and targets/pseudo/userland/Makefile.depend

Apr 7 2022, 2:00 PM
pstef updated the diff for D32945: Implement base64(1).

Address delphij's comments.

Apr 7 2022, 12:35 PM

Apr 6 2022

pstef updated the diff for D32944: b64encode: implement -w to wrap lines.

Address mistakes, describe the magic buffer length.

Apr 6 2022, 6:05 PM

Apr 5 2022

pstef updated the diff for D32943: Modularize uuencode and uudecode by wrapping them in bintrans.c.

Rebase.

Apr 5 2022, 7:40 PM

Mar 29 2022

pstef committed R10:ae6aa2d43daa: uudecode: move the new uudecode test from uuencode/ to uudecode/ (authored by pstef).
uudecode: move the new uudecode test from uuencode/ to uudecode/
Mar 29 2022, 5:31 AM

Mar 28 2022

pstef added a comment to D32943: Modularize uuencode and uudecode by wrapping them in bintrans.c.

Hi, thanks for this review!

Mar 28 2022, 7:23 PM
pstef added a comment to D32945: Implement base64(1).

Hi, thanks for this review!

Mar 28 2022, 7:19 PM
pstef committed R10:f5138631fb6f: uudecode: use SRCDIR in the regression test (authored by pstef).
uudecode: use SRCDIR in the regression test
Mar 28 2022, 7:02 PM
pstef added a comment to D32944: b64encode: implement -w to wrap lines.

Hi, thanks for the review!

Mar 28 2022, 6:57 PM
pstef committed R10:1b3af110bcd5: uudecode: add missing test files to Makefile (authored by pstef).
uudecode: add missing test files to Makefile
Mar 28 2022, 9:53 AM
pstef committed R10:9f3203c00314: uudecode: correct error message (authored by pstef).
uudecode: correct error message
Mar 28 2022, 7:22 AM
pstef committed R10:d5d3f5dab209: uu{encode,decode}: improve style (authored by pstef).
uu{encode,decode}: improve style
Mar 28 2022, 7:22 AM
pstef committed R10:68700941c7ad: sh: fix autocompletion for commands that share name with a directory (authored by pstef).
sh: fix autocompletion for commands that share name with a directory
Mar 28 2022, 7:22 AM
pstef closed D34544: sh: fix autocompletion for commands that share name with a directory.
Mar 28 2022, 7:21 AM

Mar 27 2022

pstef updated the diff for D34544: sh: fix autocompletion for commands that share name with a directory.

Don't leak memory.

Mar 27 2022, 8:19 PM
pstef updated the diff for D32944: b64encode: implement -w to wrap lines.
Mar 27 2022, 12:06 AM
pstef updated the diff for D32945: Implement base64(1).
Mar 27 2022, 12:05 AM
pstef updated the diff for D32943: Modularize uuencode and uudecode by wrapping them in bintrans.c.
Mar 27 2022, 12:03 AM

Mar 26 2022

pstef updated the diff for D34544: sh: fix autocompletion for commands that share name with a directory.

Fortunately, the tilde-expanding function from libedit is nicely exported. Too bad this code is duplicated between sh and libedit.

Mar 26 2022, 11:57 PM
pstef committed R10:f50cda551150: ls(1): Allow LSCOLORS to specify an underline (authored by me_cameronkatri.com).
ls(1): Allow LSCOLORS to specify an underline
Mar 26 2022, 1:44 PM
pstef committed R10:6018f775cebf: Mention kern.timecounter.alloweddeviation in nanosleep.2 (authored by pstef).
Mention kern.timecounter.alloweddeviation in nanosleep.2
Mar 26 2022, 1:43 PM

Mar 25 2022

pstef added a comment to D34674: etcupdate: remove redundant diff3 flag.

I don't use etcupdate yet, but this change looks reasonable to me.

Mar 25 2022, 4:40 PM

Mar 23 2022

pstef committed R10:c4e1fbfe56c2: mount: make libxo support more locale-aware (authored by pstef).
mount: make libxo support more locale-aware
Mar 23 2022, 3:53 PM
pstef committed R10:3f8b52c91087: mount: add libxo(3) support (authored by me_cameronkatri.com).
mount: add libxo(3) support
Mar 23 2022, 3:53 PM
pstef committed R10:540b4791d8c9: cap_fileargs: silence warnings of unused variable (authored by oshogbo).
cap_fileargs: silence warnings of unused variable
Mar 23 2022, 3:52 PM

Mar 22 2022

pstef committed R10:a4bd2216fb52: ps: fix `ps -aa` (authored by sigsys_gmail.com).
ps: fix `ps -aa`
Mar 22 2022, 6:55 PM
pstef committed R10:acec1d6969de: mount: improve error message for invalid filesystem names (authored by pstef).
mount: improve error message for invalid filesystem names
Mar 22 2022, 6:54 PM
pstef committed R10:b8c245922807: ndiscvt: remove set but not used variable (authored by pstef).
ndiscvt: remove set but not used variable
Mar 22 2022, 6:54 PM
pstef committed R10:e0414a826c21: tcp_wrappers: remove duplicate errno declarations (authored by pstef).
tcp_wrappers: remove duplicate errno declarations
Mar 22 2022, 6:54 PM
pstef committed R10:cf1507aacb3f: tcp_wrappers: include <unistd.h> (authored by pstef).
tcp_wrappers: include <unistd.h>
Mar 22 2022, 6:54 PM
pstef committed R10:c38d2d1811bf: procstat: remove set but not used variable (authored by pstef).
procstat: remove set but not used variable
Mar 22 2022, 6:54 PM
pstef committed R10:15635c0ed3b1: backlight: Remove set but not used variable (authored by pstef).
backlight: Remove set but not used variable
Mar 22 2022, 6:54 PM

Mar 18 2022

pstef committed R10:8b1f5965d9a5: procstat: remove set but not used variable (authored by pstef).
procstat: remove set but not used variable
Mar 18 2022, 9:05 AM
pstef committed R10:fde687c239e5: backlight: Remove set but not used variable (authored by pstef).
backlight: Remove set but not used variable
Mar 18 2022, 9:04 AM
pstef added a comment to D19548: Add fileargs_lstat to cap_fileargs service.

Note this was committed to the tree a couple of years ago.

Mar 18 2022, 8:26 AM

Mar 17 2022

pstef added inline comments to D19548: Add fileargs_lstat to cap_fileargs service.
Mar 17 2022, 1:12 PM

Mar 14 2022

pstef updated the diff for D34544: sh: fix autocompletion for commands that share name with a directory.

I missed histedit.c in the previous git add.

Mar 14 2022, 8:30 AM

Mar 13 2022

pstef added inline comments to D34544: sh: fix autocompletion for commands that share name with a directory.
Mar 13 2022, 6:49 PM
pstef updated the diff for D34544: sh: fix autocompletion for commands that share name with a directory.

Drop the flags argument from tilde_expand().

Mar 13 2022, 6:40 PM
pstef requested review of D34544: sh: fix autocompletion for commands that share name with a directory.
Mar 13 2022, 1:12 PM

Mar 12 2022

pstef added a comment to D34421: diff3: Add support for -A and -m.

There doesn't seem to be any specification of the diff3 behavior, so I spent some time looking for some test cases. GNU doesn't provide much directly in the source (https://git.savannah.gnu.org/cgit/diffutils.git/plain/tests/diff3) and also the mailing list isn't rich in corner cases relating to diff3. I've found some test cases for git's implementation (https://github.com/git/git/search?l=Shell&q=diff3) but I only skimmed that so I don't know how useful they are.

Mar 12 2022, 7:42 PM
pstef added a comment to D34421: diff3: Add support for -A and -m.

I am not sure about the license of the lao, tzu, tao example, I feel like it is
ancient and should be in the public domain. I'll rewrite it to produce the same
test case with a public domain poem if we need to.

Mar 12 2022, 6:43 PM

Mar 10 2022

pstef accepted D34508: diff: add support for --help and --version.
Mar 10 2022, 3:05 PM
pstef added a comment to D34508: diff: add support for --help and --version.

I can only see the man-page change, should I be seeing code changes in this diff as well?

Mar 10 2022, 2:31 PM

Feb 23 2022

pstef committed R10:9b6a8ee28d61: tcp_wrappers: remove duplicate errno declarations (authored by pstef).
tcp_wrappers: remove duplicate errno declarations
Feb 23 2022, 3:28 PM
pstef committed R10:7d636a4d3ebd: tcp_wrappers: include <unistd.h> (authored by pstef).
tcp_wrappers: include <unistd.h>
Feb 23 2022, 3:28 PM

Feb 13 2022

pstef committed R10:9ddf1ab1b9c7: Fix the spelling of '*/' in the vnic driver (authored by andrew).
Fix the spelling of '*/' in the vnic driver
Feb 13 2022, 7:19 PM

Jan 29 2022

pstef added a comment to D25338: Do not recommend sleeping when using vipw(8) non-interactively.
In D25338#770884, @0mp wrote:
Jan 29 2022, 10:01 PM

Nov 16 2021

pstef updated the diff for D32945: Implement base64(1).

Mostly implement long options for compatibility.

Nov 16 2021, 11:29 PM

Nov 11 2021

pstef retitled D32945: Implement base64(1) from Implement base64 to Implement base64(1).
Nov 11 2021, 5:38 PM
pstef requested review of D32945: Implement base64(1).
Nov 11 2021, 5:27 PM
pstef requested review of D32944: b64encode: implement -w to wrap lines.
Nov 11 2021, 5:26 PM
pstef requested review of D32943: Modularize uuencode and uudecode by wrapping them in bintrans.c.
Nov 11 2021, 5:21 PM

Nov 6 2021

pstef abandoned D32870: [WIP] sh: implement "edit-and-execute-command".

As pointed out by bapt, el_set(el, EL_BIND, "^X^E", "vi-histedit", NULL); is enough.

Nov 6 2021, 5:03 PM
pstef requested review of D32870: [WIP] sh: implement "edit-and-execute-command".
Nov 6 2021, 11:38 AM

Oct 29 2021

pstef accepted D32672: beep(1): Initial version of utility to create terminal beep via soundcard..
Oct 29 2021, 5:48 PM