Page MenuHomeFreeBSD

pstef (Piotr Stefaniak)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2016, 9:00 PM (362 w, 1 d)

Recent Activity

Sat, May 13

pstef committed rG411942a70eb6: GENERIC: remove a stray space character (authored by pstef).
GENERIC: remove a stray space character
Sat, May 13, 8:06 PM
pstef committed rG43489c142e56: sh: improve style (authored by pstef).
sh: improve style
Sat, May 13, 8:06 PM

May 3 2023

pstef added a comment to D37627: Disable errors for -Wnonnull for the kernel for GCC 12..

What are the functions? Generally, passing a null pointer to a standard string function invokes UB regardless of the passed size, and some compilers do make optimizations based on this assumption.

May 3 2023, 6:35 AM

Apr 29 2023

pstef updated the diff for D39839: sh: also auto-complete built-ins.

Reduce code duplication.
I was worried about some repetitive code here when adding the second source of commands (built-ins, after files from $PATH), but it became visibly worse when I started working on adding a third source (aliases). So the sooner I factor this out, the cleaner the future commits will be.

Apr 29 2023, 8:48 PM

Apr 28 2023

pstef added inline comments to D39839: sh: also auto-complete built-ins.
Apr 28 2023, 6:45 AM
pstef updated the diff for D39839: sh: also auto-complete built-ins.

Address reviews.

Apr 28 2023, 6:44 AM

Apr 27 2023

pstef added inline comments to D39839: sh: also auto-complete built-ins.
Apr 27 2023, 4:45 PM
pstef updated the diff for D39839: sh: also auto-complete built-ins.

builtincmd doesn't hold C strings, use memcmp().

Apr 27 2023, 6:13 AM

Apr 26 2023

pstef added a comment to D39839: sh: also auto-complete built-ins.

This doesn't follow the Don't Repeat Yourself principle, but currently I don't have a better idea how to express this code.

Apr 26 2023, 8:12 PM
pstef requested review of D39839: sh: also auto-complete built-ins.
Apr 26 2023, 8:11 PM

Feb 8 2023

pstef accepted D38386: Add nproc(1).
Feb 8 2023, 7:40 PM
pstef accepted D38386: Add nproc(1).

My question about fprintf() remains unanswered, but it is not a blocker.

Feb 8 2023, 12:14 PM

Feb 6 2023

pstef accepted D38399: tarfs: Fix typo in man page..
Feb 6 2023, 3:06 PM

Feb 5 2023

pstef added inline comments to D38386: Add nproc(1).
Feb 5 2023, 10:27 AM
pstef added a comment to D38386: Add nproc(1).

TODO: write the manpage

Feb 5 2023, 10:08 AM
pstef added inline comments to D38386: Add nproc(1).
Feb 5 2023, 8:10 AM
pstef added a comment to D38386: Add nproc(1).

Minor style improvements, nitpicking and questions.

Feb 5 2023, 7:53 AM

Jan 20 2023

pstef added a comment to D38047: Multiple fixes to the NSS caching system.

Please provide more diff context (diff -U999999).

Jan 20 2023, 5:00 PM · Src Committers
pstef added inline comments to D38047: Multiple fixes to the NSS caching system.
Jan 20 2023, 4:55 PM · Src Committers

Jan 17 2023

pstef accepted D38097: df: Return non-zero status on write failure..
Jan 17 2023, 3:21 PM

Jan 8 2023

pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Back out the previous update.
The -1 was there for the i++ that the loop always performs, so it's needed regardless of whether strftime() returned 0 or more.
Split the calculation that was there before into two parts, one of which just decrements i and makes a comment on why it's done.

Jan 8 2023, 12:56 PM
pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Minutes after posting the previous version, I thought about handling the rare corner case when strftime() returns 0.

Jan 8 2023, 10:46 AM
pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Simplify the code part a bit.
Also improve comments and some variable names.

Jan 8 2023, 10:35 AM

Jan 2 2023

pstef added inline comments to D37753: Add tarfs, a filesystem backed by tarballs..
Jan 2 2023, 4:06 PM
pstef added a comment to D35840: sh: implement PS1 \D to print current time.

When I was looking at this code today, I thought that the unconditional memccpy() is a bit wasteful in the \D{} case, because the one copied byte is a special case and when it's noticed, the copied byte is overwriten by strcpy() with "%X".
There is little to be gained in either performance or legibility of the code, but when I rewrote this locally to be less wasteful, it didn't look much worse, nor did it look much better.
Opinions?

Jan 2 2023, 12:10 AM

Jan 1 2023

pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

In this iteration I tried to address all new feedback.
I also was annoyed by the current formatting of the file, so this is a diff against D37926 where I reduce indentation.

Jan 1 2023, 7:46 PM
pstef requested review of D37926: sh: reindent a for loop in parser.c.
Jan 1 2023, 7:43 PM

Dec 29 2022

pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Drop PS4 support and update the manual page changes according to feedback.

Dec 29 2022, 9:57 AM

Dec 24 2022

pstef committed rG36802990d64c: ls(1): add a -v flag to sort naturally (authored by obiwac_gmail.com).
ls(1): add a -v flag to sort naturally
Dec 24 2022, 7:23 AM
pstef committed rG149466a516b2: ping: split the visual part of -f into a new option -. (authored by pstef).
ping: split the visual part of -f into a new option -.
Dec 24 2022, 7:23 AM

Dec 22 2022

pstef added a comment to D37753: Add tarfs, a filesystem backed by tarballs..
Dec 22 2022, 10:13 PM

Dec 20 2022

pstef added a comment to D37753: Add tarfs, a filesystem backed by tarballs..

Hi, thanks for working on this.

Dec 20 2022, 5:04 PM

Dec 16 2022

pstef accepted D37712: daily 150.clean-hoststat: suppress error when using dma.

LGTM FWIW

Dec 16 2022, 2:48 PM
pstef added inline comments to D37712: daily 150.clean-hoststat: suppress error when using dma.
Dec 16 2022, 10:43 AM

Dec 15 2022

pstef added inline comments to D37695: bin/uuidgen: add support for v4 uuids.
Dec 15 2022, 7:10 AM

Dec 14 2022

pstef added a comment to D37695: bin/uuidgen: add support for v4 uuids.

Should this version become the default? On the one hand, it has POLA violation potential, on the other hand, it's what the command does under another system.

Dec 14 2022, 10:38 AM

Dec 13 2022

pstef added inline comments to D37674: add sizeof(7) man page.
Dec 13 2022, 9:30 PM
pstef accepted D37683: sizeof(7): miscellaneous edits.
Dec 13 2022, 9:16 PM
pstef added a comment to D37674: add sizeof(7) man page.

Initial review.

Dec 13 2022, 7:57 AM

Dec 12 2022

pstef accepted D37676: diff: fix side-by-side output with tabbed input.

hw: column width ((h)ard (w)idth?)

Dec 12 2022, 8:20 PM

Nov 24 2022

pstef added a reviewer for D37478: Add support for mounting single files in nullfs: mjg.
Nov 24 2022, 8:12 PM

Nov 4 2022

pstef added a comment to D37263: getty: code cleanup, part 1.

If you intend to do more work on these files, I suggest improving the style before introducing more significant changes. There is a lot of inherited stylistic issues here, unfortunately.
I think you have a typo in the description and you meant "braces" - I meantion it just in case you planned to copy it to the commit message.

Nov 4 2022, 2:02 PM

Nov 2 2022

pstef added inline comments to D37236: gzip: Add support for decompressing zstd files..
Nov 2 2022, 3:23 PM

Oct 31 2022

pstef added a comment to D36860: diff: Import new diff algorithms from libdiff.

Would it be possible to omit the compat subdirectory from the import?

Oct 31 2022, 2:10 PM

Oct 30 2022

pstef closed D36407: ls: `-v` flag.
Oct 30 2022, 11:14 PM
pstef committed rGe2662256cdbc: ls(1): add a -v flag to sort naturally (authored by obiwac_gmail.com).
ls(1): add a -v flag to sort naturally
Oct 30 2022, 11:14 PM
pstef added inline comments to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Oct 30 2022, 4:49 PM
pstef added a comment to D35761: libc: expose a primitive version of b64_pton().

@kib, sorry about not providing some aspects of the context of this change, I thought this was a good enough draft to get the first few reviews, but in hindsight it looks just lazy of me.

Oct 30 2022, 12:13 PM

Oct 23 2022

pstef added reviewers for D35761: libc: expose a primitive version of b64_pton(): kib, imp.
Oct 23 2022, 7:32 AM

Oct 21 2022

pstef accepted D37083: top: improve sort field storage/lookup.

But the summary contains the same phrase twice, seems unintentional.

Oct 21 2022, 10:20 PM

Oct 18 2022

pstef added a comment to D37035: mailwrapper: use dma(8) over sendmail(8).

Please remember to tag the commit as Relnotes: yes.

Oct 18 2022, 2:30 PM

Aug 25 2022

pstef accepted D36314: bintrans: replace the quoted printable encoder/decoder.
Aug 25 2022, 6:29 AM

Aug 24 2022

pstef committed rG6480563d0678: sh: accept fc options grouped behind one '-' (authored by pstef).
sh: accept fc options grouped behind one '-'
Aug 24 2022, 6:23 PM
pstef committed rGead0fe475c5e: sh: nullify ENV in tests (authored by pstef).
sh: nullify ENV in tests
Aug 24 2022, 6:22 PM
pstef added inline comments to D36314: bintrans: replace the quoted printable encoder/decoder.
Aug 24 2022, 3:38 PM

Aug 23 2022

pstef added inline comments to D36314: bintrans: replace the quoted printable encoder/decoder.
Aug 23 2022, 4:02 PM

Aug 22 2022

pstef requested review of D36293: base64: implement -i/-n to ignore non-alphabet characters.
Aug 22 2022, 4:12 PM

Aug 21 2022

pstef added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Where can I find the rules for vertical spacing? I can't find it explicitly in style(9)

Aug 21 2022, 12:19 PM

Aug 20 2022

pstef committed rGa1423456415a: sh: nullify ENV in tests (authored by pstef).
sh: nullify ENV in tests
Aug 20 2022, 11:31 AM
pstef closed D35876: sh: nullify ENV in tests.
Aug 20 2022, 11:31 AM
pstef closed D35836: sh: accept fc options grouped behind one '-'.
Aug 20 2022, 11:31 AM
pstef committed rG755a1be6d015: sh: accept fc options grouped behind one '-' (authored by pstef).
sh: accept fc options grouped behind one '-'
Aug 20 2022, 11:31 AM

Aug 19 2022

pstef added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

I can do it myself this evening, if that doesn't slow you down for anything else. (Aswell as making that post on -hackers that @lwhsu mentioned, if that's still necessary.)

Aug 19 2022, 11:07 AM
pstef added a comment to D35836: sh: accept fc options grouped behind one '-'.

@jilles is this patch in a good shape now?

Aug 19 2022, 10:49 AM
pstef added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Hey guys, is there anything here that I still need to do?

Aug 19 2022, 10:42 AM

Aug 16 2022

pstef added a comment to D29577: acpi(4): mention NONE as possible setting for hw.acpi.power_button_state.

I already started looking into adding it to prevent my cat from powering off my system

Aug 16 2022, 8:51 PM
pstef committed rGe45f7e92439d: acpi(4): mention NONE as possible setting for hw.acpi.power_button_state (authored by yuripv).
acpi(4): mention NONE as possible setting for hw.acpi.power_button_state
Aug 16 2022, 8:46 PM
pstef added a comment to D36195: The simplest OSS MIDI example.

To be honest I don't know how the process works. Can you advise, please?

Aug 16 2022, 6:22 PM

Aug 7 2022

pstef updated the diff for D35761: libc: expose a primitive version of b64_pton().

Rename base64.h to b64.h.

Aug 7 2022, 8:51 AM

Aug 6 2022

pstef updated the diff for D35836: sh: accept fc options grouped behind one '-'.
Aug 6 2022, 5:43 PM

Jul 31 2022

pstef updated the diff for D35761: libc: expose a primitive version of b64_pton().

Add the missing semicolon in Symbol.map.
Add base64.h to INCS.

Jul 31 2022, 7:33 PM

Jul 30 2022

pstef updated the diff for D35836: sh: accept fc options grouped behind one '-'.

Slightly change the approach: each not_fcnumber() check, keep consuming options until we need to jump to the next argptr.
Add a couple of test cases.

Jul 30 2022, 6:57 PM

Jul 28 2022

pstef added a comment to D35960: style: Allow C++ comments.
Jul 28 2022, 2:47 PM

Jul 26 2022

pstef added inline comments to D35960: style: Allow C++ comments.
Jul 26 2022, 9:30 PM
pstef added a comment to D35960: style: Allow C++ comments.

I've seen patches where BCPL-style comments are abused to form what we're used to see as block comments. So if we start allowing them, maybe say that they're allowed under some conditions (not sure what to specify here or how).

Jul 26 2022, 9:05 PM
pstef accepted D35959: style: Tighten up one use of 'may'.
Jul 26 2022, 8:39 PM
pstef accepted D35959: style: Tighten up one use of 'may'.
Jul 26 2022, 8:23 PM
pstef added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Hey guys, is there anything here that I still need to do?

Jul 26 2022, 7:41 PM

Jul 22 2022

pstef added a comment to D35836: sh: accept fc options grouped behind one '-'.

@jilles what do you think about this one?

Jul 22 2022, 7:17 PM

Jul 21 2022

pstef requested review of D35876: sh: nullify ENV in tests.
Jul 21 2022, 6:45 PM

Jul 19 2022

pstef added inline comments to D35840: sh: implement PS1 \D to print current time.
Jul 19 2022, 8:54 PM
pstef added inline comments to D35840: sh: implement PS1 \D to print current time.
Jul 19 2022, 8:29 PM
pstef added a comment to D35840: sh: implement PS1 \D to print current time.

A little unfortunate to have these strange backslash sequences spread out further, but it's nothing that bash doesn't do.

Jul 19 2022, 4:04 PM

Jul 18 2022

pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Simplify and add comments.

Jul 18 2022, 7:42 PM
pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Handle rare cases the way bash does it.

Jul 18 2022, 4:27 PM
pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Remove debugging changes not meant for review.

Jul 18 2022, 9:49 AM
pstef edited reviewers for D35840: sh: implement PS1 \D to print current time, added: manpages; removed: docs.
Jul 18 2022, 9:41 AM
pstef set the repository for D35761: libc: expose a primitive version of b64_pton() to rG FreeBSD src repository.
Jul 18 2022, 9:41 AM
pstef set the repository for D35836: sh: accept fc options grouped behind one '-' to rG FreeBSD src repository.
Jul 18 2022, 9:41 AM
pstef added a reviewer for D35840: sh: implement PS1 \D to print current time: docs.
Jul 18 2022, 9:40 AM
pstef retitled D35761: libc: expose a primitive version of b64_pton() from Expose a primitive version of b64_pton() to libc: expose a primitive version of b64_pton().
Jul 18 2022, 9:25 AM
pstef updated the diff for D35840: sh: implement PS1 \D to print current time.

Place the result of strftime() in the right place instead of always at the beginning of the buffer.
Simplify conditional early exit.

Jul 18 2022, 8:58 AM
pstef requested review of D35840: sh: implement PS1 \D to print current time.
Jul 18 2022, 8:38 AM

Jul 17 2022

pstef updated the diff for D35836: sh: accept fc options grouped behind one '-'.

I've made the mistake of assuming that the first token has to be an option, but of course fc -1 must work.

Jul 17 2022, 11:43 AM
pstef retitled D35836: sh: accept fc options grouped behind one '-' from sh: accept options grouped behind one '-' to sh: accept fc options grouped behind one '-'.
Jul 17 2022, 10:20 AM
pstef requested review of D35836: sh: accept fc options grouped behind one '-'.
Jul 17 2022, 8:23 AM

Jul 16 2022

pstef accepted D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

I accept this revision. I don't mind declarations after statements, but others might.

Jul 16 2022, 5:06 PM
pstef accepted D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 16 2022, 7:30 AM
pstef added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 16 2022, 7:30 AM

Jul 15 2022

pstef added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 15 2022, 4:21 PM