Page MenuHomeFreeBSD

pstef (Piotr Stefaniak)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2016, 9:00 PM (226 w, 6 d)

Recent Activity

Aug 14 2020

pstef added inline comments to D26064: Check XHCI endpoint state before issuing XHCI endpoint commands.
Aug 14 2020, 10:41 AM

Aug 3 2020

pstef committed rS363788: MFC 363621: sh(1): print a newline when ^D quits sh.
MFC 363621: sh(1): print a newline when ^D quits sh
Aug 3 2020, 6:54 AM

Jul 31 2020

pstef committed rS363724: MFC r363268:.
MFC r363268:
Jul 31 2020, 7:37 AM

Jul 27 2020

pstef closed D25813: sh(1): print a newline when ^D exits sh.
Jul 27 2020, 6:46 PM
pstef committed rS363621: sh(1): print a newline when ^D quits sh.
sh(1): print a newline when ^D quits sh
Jul 27 2020, 6:46 PM
pstef accepted D25398: w: remove proc_compare().

I would also remove the "most interesting" comment.

Jul 27 2020, 5:46 AM

Jul 26 2020

pstef updated the summary of D25813: sh(1): print a newline when ^D exits sh.
Jul 26 2020, 10:42 AM
pstef requested review of D25813: sh(1): print a newline when ^D exits sh.
Jul 26 2020, 10:42 AM

Jul 25 2020

pstef committed rS363525: MFC r342576-342577,342645,342812,342881,343231,343399 (by trasz):.
MFC r342576-342577,342645,342812,342881,343231,343399 (by trasz):
Jul 25 2020, 11:57 AM

Jul 17 2020

pstef committed rS363268: Promote use of unprivileged users for building ports by documenting SU_CMD..
Promote use of unprivileged users for building ports by documenting SU_CMD.
Jul 17 2020, 6:33 AM
pstef closed D25433: ports.7: mention SU_CMD.
Jul 17 2020, 6:33 AM · portmgr, manpages

Jul 16 2020

pstef updated the diff for D25433: ports.7: mention SU_CMD.

Phrasing by Daniel O'Connor.

Jul 16 2020, 8:50 AM · portmgr, manpages

Jul 4 2020

pstef committed rS362924: MFC r362705 and r362707:.
MFC r362705 and r362707:
Jul 4 2020, 6:35 AM

Jun 29 2020

pstef committed rS362773: MFC r362495:.
MFC r362495:
Jun 29 2020, 6:28 AM

Jun 27 2020

pstef committed rS362707: ps(1): don't try to handle non-SMP systems.
ps(1): don't try to handle non-SMP systems
Jun 27 2020, 8:02 PM
pstef closed D25377: ps(1): reuse keyword "cpu" to show CPU number.
Jun 27 2020, 7:09 PM
pstef committed rS362705: ps(1): reuse keyword "cpu" to show CPU number.
ps(1): reuse keyword "cpu" to show CPU number
Jun 27 2020, 7:09 PM
pstef added a comment to D25487: kern.tty_info_kstacks: add a compact format.
In D25487#562808, @mjg wrote:

Side note is that I think the shorter format should be the default.

Jun 27 2020, 3:10 PM
pstef committed rS362673: MFC r362429 and r362430:.
MFC r362429 and r362430:
Jun 27 2020, 9:01 AM

Jun 26 2020

pstef added a comment to D25433: ports.7: mention SU_CMD.
In D25433#562475, @0mp wrote:

Just a note for your consideration: I wonder if we should mention there, that people often use set SU_CMD to use sudo (I do at least):

.if exists(/usr/local/bin/sudo)
SU_CMD= /usr/local/bin/sudo -E sh -c
.endif
Jun 26 2020, 9:13 PM · portmgr, manpages
pstef added a comment to D25433: ports.7: mention SU_CMD.

What I did is I think consistent with the rest of the file, for example

.It Cm fetch
Fetch all of the files needed to build this port from the sites
listed in
.Va MASTER_SITES
and
.Va PATCH_SITES .
See
.Va FETCH_CMD , MASTER_SITE_OVERRIDE
and
.Va MASTER_SITE_BACKUP .
Jun 26 2020, 9:06 PM · portmgr, manpages

Jun 25 2020

pstef updated the diff for D25377: ps(1): reuse keyword "cpu" to show CPU number.

Don't make keyword descriptions even less sorted than they are now.

Jun 25 2020, 2:49 PM
pstef added a comment to D25447: /usr/libexec/flua: Add bindings for libifconfig.

I can see some potential for automation and orchestration.

Jun 25 2020, 2:39 PM

Jun 24 2020

pstef edited projects for D25433: ports.7: mention SU_CMD, added: portmgr; removed Ports Committers.
Jun 24 2020, 8:58 PM · portmgr, manpages
pstef added a project to D25433: ports.7: mention SU_CMD: Ports Committers.
Jun 24 2020, 8:56 PM · portmgr, manpages
pstef edited projects for D25433: ports.7: mention SU_CMD, added: manpages; removed docs.
Jun 24 2020, 8:50 PM · portmgr, manpages
pstef added a project to D25433: ports.7: mention SU_CMD: docs.
Jun 24 2020, 8:36 PM · portmgr, manpages
pstef requested review of D25433: ports.7: mention SU_CMD.
Jun 24 2020, 8:33 PM · portmgr, manpages

Jun 23 2020

pstef committed rS362547: pstat(8): improve the Size header width after r358181.
pstat(8): improve the Size header width after r358181
Jun 23 2020, 6:19 PM
pstef added a comment to D25398: w: remove proc_compare().

It's not immediately obvious to me why rS29310 would render this a no-op, but I know that the use of ki_estcpu instead of ki_pctcpu is bogus for anything but the 4BSD scheduler.

Jun 23 2020, 5:04 PM
pstef closed D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.
Jun 23 2020, 3:23 AM
pstef closed D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.
Jun 23 2020, 3:17 AM

Jun 22 2020

pstef committed rS362508: MFC r358405 (by hrs):.
MFC r358405 (by hrs):
Jun 22 2020, 7:16 PM
pstef committed rS362507: MFC r357186 (by imp): Remove old device list.
MFC r357186 (by imp): Remove old device list
Jun 22 2020, 7:09 PM
pstef committed rS362506: MFC r357186 (by imp): Remove old device list.
MFC r357186 (by imp): Remove old device list
Jun 22 2020, 7:09 PM
pstef committed rS362495: strtok(3): make it easier to find the RETURN VALUES section.
strtok(3): make it easier to find the RETURN VALUES section
Jun 22 2020, 11:03 AM

Jun 21 2020

pstef committed rS362469: MFC r349235 (by allanjude):.
MFC r349235 (by allanjude):
Jun 21 2020, 8:23 PM
pstef accepted D24844: libc/resolv: attempt to fix the test under WARNS=6.
Jun 21 2020, 1:12 PM
pstef added a comment to D23429: rescue: add fetch.

This seems big, I'd suggest asking freebsd-arch@

Jun 21 2020, 8:56 AM
pstef accepted D23942: Document that gettimeofday() is obsolescent.
Jun 21 2020, 8:22 AM
pstef added inline comments to D24844: libc/resolv: attempt to fix the test under WARNS=6.
Jun 21 2020, 8:06 AM
pstef accepted D25009: flua: add ucl library.
Jun 21 2020, 8:00 AM
pstef accepted D25174: w: use locale-based format specifiers.
Jun 21 2020, 7:56 AM
pstef added inline comments to D25365: Early WIP: convert login.conf to UCL.
Jun 21 2020, 7:52 AM
pstef added a comment to D25338: Do not recommend sleeping when using vipw(8) non-interactively.

I would move the "The mechanism for checking for password file modifications requires that the modification time of the password file changes." part under a NOTES section and then remove the BUGS section.

Jun 21 2020, 7:29 AM

Jun 20 2020

pstef retitled D25377: ps(1): reuse keyword "cpu" to show CPU number from ps(1): add a cpu# flag to ps(1): reuse keyword "cpu" to show CPU number.
Jun 20 2020, 10:56 PM
pstef updated the diff for D25377: ps(1): reuse keyword "cpu" to show CPU number.

Handle non-SMP systems

Jun 20 2020, 10:44 PM
pstef updated the diff for D25377: ps(1): reuse keyword "cpu" to show CPU number.

Changed my mind, the new functionality will replace the old one.

Jun 20 2020, 9:53 PM
pstef updated the summary of D25377: ps(1): reuse keyword "cpu" to show CPU number.
Jun 20 2020, 7:31 PM
pstef updated the summary of D25377: ps(1): reuse keyword "cpu" to show CPU number.
Jun 20 2020, 7:30 PM
pstef requested review of D25377: ps(1): reuse keyword "cpu" to show CPU number.
Jun 20 2020, 7:30 PM
pstef closed D25369: Make vipw error message less cryptic.
Jun 20 2020, 6:20 AM
pstef committed rS362430: Make vipw error message less cryptic.
Make vipw error message less cryptic
Jun 20 2020, 6:20 AM
pstef committed rS362429: libutil: remove extraneous ": " from error messages.
libutil: remove extraneous ": " from error messages
Jun 20 2020, 6:11 AM
pstef updated the summary of D25369: Make vipw error message less cryptic.
Jun 20 2020, 1:10 AM
pstef requested review of D25369: Make vipw error message less cryptic.
Jun 20 2020, 1:10 AM

Jun 18 2020

pstef added a comment to D25312: Relax the rule against declaring variables in nested scopes..
In D25312#558270, @kib wrote:

I found empirically that it is easier to _read_ when locals are collected at the start of the function. Perhaps it is because I can see all local parameters in one place.

Jun 18 2020, 9:18 AM
pstef added a comment to D25312: Relax the rule against declaring variables in nested scopes..

I'm in favor of the change. However, it's been pointed out to me in the past that with all object declarations at the start of the function body it's easier to reason about the stack.

Except that it isn't true unless you compile at -O0: any vaguely recent compiler will reuse stack slots for variables for which it knows the lifetime cannot overlap.

Thanks for this change!

Jun 18 2020, 9:18 AM
pstef accepted D25312: Relax the rule against declaring variables in nested scopes..

I'm in favor of the change. However, it's been pointed out to me in the past that with all object declarations at the start of the function body it's easier to reason about the stack.

Jun 18 2020, 9:18 AM

May 28 2020

pstef committed rS361585: MFS r361026.
MFS r361026
May 28 2020, 1:19 PM

May 24 2020

pstef committed rS361430: MFC r361337: indent(1): add fallthrough markers.
MFC r361337: indent(1): add fallthrough markers
May 24 2020, 9:47 AM

May 21 2020

pstef committed rS361337: indent(1): add fallthrough markers.
indent(1): add fallthrough markers
May 21 2020, 5:34 PM

May 14 2020

pstef committed rS361027: MFC r360786:.
MFC r360786:
May 14 2020, 6:07 AM
pstef committed rS361026: MFC r360786:.
MFC r360786:
May 14 2020, 6:05 AM

May 7 2020

pstef committed rS360786: ps: extend the non-standard option -d (tree view) to work with -p.
ps: extend the non-standard option -d (tree view) to work with -p
May 7 2020, 4:56 PM

Apr 17 2020

pstef updated the diff for D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.

I missed that -p with single argument prevents -d from working, since I always use -a :)

Apr 17 2020, 6:25 PM

Apr 16 2020

pstef added a comment to D24407: Export argc, argv, envc, envv, and ps_strings in auxargs..

How does this relate to D16111?

Apr 16 2020, 5:31 AM

Apr 14 2020

pstef requested review of D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.

my goodness, phabricator

Apr 14 2020, 9:48 AM
pstef reclaimed D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.
Apr 14 2020, 9:48 AM
pstef abandoned D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.
Apr 14 2020, 9:46 AM

Apr 12 2020

pstef added a comment to D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.

Possible use cases:

  • ps auxd -p $$
  • ps auxd -p 1
  • while x=$(pgrep svnlite); do clear; ps auxd -p $x; sleep 2; done
  • ps auxd -p `pgrep make`
Apr 12 2020, 8:38 PM
pstef added a comment to D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.
Apr 12 2020, 6:36 PM
pstef created D24380: ps(1): extend the non-standard option -d (tree view) to work with -p.
Apr 12 2020, 2:50 PM

Aug 17 2019

pstef added inline comments to D21296: Remove some compatability with Seventh Edition UNIX realloc()..
Aug 17 2019, 6:07 AM

Aug 16 2019

D21290: zpool-features.7: Fix a typo is now accepted and ready to land.
Aug 16 2019, 10:26 AM

Aug 15 2018

pstef committed rS337862: indent(1): bug fix after r336333.
indent(1): bug fix after r336333
Aug 15 2018, 6:20 PM

Aug 11 2018

pstef committed rS337651: indent(1): revert r334640 and r334632.
indent(1): revert r334640 and r334632
Aug 11 2018, 7:20 PM

Jul 22 2018

pstef committed rS336601: Remove old Kyua test files for indent(1) after a rename..
Remove old Kyua test files for indent(1) after a rename.
Jul 22 2018, 12:45 PM

Jul 16 2018

pstef committed rS336333: indent(1): rewrite the integer/floating constant scanning part of lexi.c.
indent(1): rewrite the integer/floating constant scanning part of lexi.c
Jul 16 2018, 5:47 AM

Jul 15 2018

pstef committed rS336318: indent(1): move case_indent from parser state to the options struct.
indent(1): move case_indent from parser state to the options struct
Jul 15 2018, 9:04 PM

Jun 11 2018

pstef committed rS334944: indent(1): rename -nsac/-sac ("space after cast") to -ncs/-cs.
indent(1): rename -nsac/-sac ("space after cast") to -ncs/-cs
Jun 11 2018, 5:36 AM

Jun 10 2018

pstef committed rS334927: indent(1): group global option variables into an options structure.
indent(1): group global option variables into an options structure
Jun 10 2018, 4:44 PM

Jun 4 2018

pstef committed rS334640: indent(1): fix buildworld after r334632.
indent(1): fix buildworld after r334632
Jun 4 2018, 9:22 PM
pstef committed rS334636: indent(1): add --version option.
indent(1): add --version option
Jun 4 2018, 9:06 PM
pstef committed rS334632: indent(1): remove the STACKSIZE macro and all of its use.
indent(1): remove the STACKSIZE macro and all of its use
Jun 4 2018, 8:40 PM
pstef committed rS334630: indent(1): remove static const char copyright[].
indent(1): remove static const char copyright[]
Jun 4 2018, 8:24 PM
pstef committed rS334628: indent(1): replace BSD bcopy() with C memmove().
indent(1): replace BSD bcopy() with C memmove()
Jun 4 2018, 7:47 PM

Jun 3 2018

pstef committed rS334590: indent(1): new option -lpl.
indent(1): new option -lpl
Jun 3 2018, 9:40 PM
pstef committed rS334589: indent(1): revert introduction of -lpl.
indent(1): revert introduction of -lpl
Jun 3 2018, 9:34 PM
pstef committed rS334588: indent(1): new option -lpl (always line up to parenthesis).
indent(1): new option -lpl (always line up to parenthesis)
Jun 3 2018, 9:00 PM
pstef committed rS334587: indent(1): manual page corretions.
indent(1): manual page corretions
Jun 3 2018, 8:49 PM
pstef committed rS334583: indent(1): if an identifier can be either a typedef name or as a struct.
indent(1): if an identifier can be either a typedef name or as a struct
Jun 3 2018, 7:05 PM
pstef committed rS334581: indent(1): if the token is a "[" then neither of the blocks is relevant.
indent(1): if the token is a "[" then neither of the blocks is relevant
Jun 3 2018, 6:38 PM
pstef committed rS334580: indent(1): don't add a space after a label.
indent(1): don't add a space after a label
Jun 3 2018, 6:34 PM
pstef committed rS334579: indent(1): ignore null characters from input.
indent(1): ignore null characters from input
Jun 3 2018, 6:32 PM
pstef committed rS334578: indent(1): don't overflow di_stack[].
indent(1): don't overflow di_stack[]
Jun 3 2018, 6:29 PM
pstef committed rS334576: indent(1): improve CHECK_SIZE_ macros.
indent(1): improve CHECK_SIZE_ macros
Jun 3 2018, 6:19 PM
pstef committed rS334574: indent(1): remove troff output support.
indent(1): remove troff output support
Jun 3 2018, 5:56 PM
pstef committed rS334571: indent(1): avoid resetting last_bl to a bogus value when reallocating.
indent(1): avoid resetting last_bl to a bogus value when reallocating
Jun 3 2018, 5:11 PM
pstef committed rS334570: indent(1): the check for buffer overflow has to be done before copy.
indent(1): the check for buffer overflow has to be done before copy
Jun 3 2018, 5:08 PM