Page MenuHomeFreeBSD
Differential D43723

libcompat: silence -Wdeprecated-non-prototype
ClosedPublic
Actions

Authored by pstef on Feb 3 2024, 6:18 PM.
Tags
None
Referenced Files
F146767962: D43723.diff
Thu, Mar 5, 10:38 AM
Unknown Object (File)
Mon, Feb 23, 7:19 PM
Unknown Object (File)
Thu, Feb 12, 4:40 AM
Unknown Object (File)
Sun, Feb 8, 5:34 AM
Unknown Object (File)
Sat, Feb 7, 6:27 PM
Unknown Object (File)
Jan 31 2026, 7:38 PM
Unknown Object (File)
Jan 31 2026, 3:27 PM
Unknown Object (File)
Jan 10 2026, 10:26 PM
View All 98 Files
Subscribers
imp

Details

Reviewers
emaste
imp
Commits
rG43b7fec10b6b: libcompat: silence -Wdeprecated-non-prototype
rG12bae251fbfa: libcompat: silence -Wdeprecated-non-prototype
Summary
by removing unnecessary re-declarations and converting K&R-style
function definitions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pstef created this revision.Feb 3 2024, 6:18 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2024, 6:18 PM
pstef requested review of this revision.Feb 3 2024, 6:18 PM
imp accepted this revision.Feb 6 2024, 5:46 PM

The changes are fine. One wonders, though, if this interface is still used, or if we could retire it..

This revision is now accepted and ready to land.Feb 6 2024, 5:46 PM
emaste accepted this revision.Feb 6 2024, 6:02 PM

It's worth committing this change even though we should ultimately remove it.

Closed by commit rG12bae251fbfa: libcompat: silence -Wdeprecated-non-prototype (authored by pstef). · Explain WhyFeb 6 2024, 7:34 PM
This revision was automatically updated to reflect the committed changes.
pstef added a commit: rG12bae251fbfa: libcompat: silence -Wdeprecated-non-prototype.
pstef added a commit: rG43b7fec10b6b: libcompat: silence -Wdeprecated-non-prototype.Feb 8 2024, 5:45 PM

Revision Contents
Changeset List

PathSize
lib/
libcompat/
4.3/
10 lines

Diff 133933

View Options

lib/libcompat/4.3/rexec.c

Loading...