Page MenuHomeFreeBSD

phk (Poul-Henning Kamp)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2019, 9:11 PM (188 w, 6 d)

Recent Activity

Tue, Sep 13

phk accepted D36550: i386: Make boot loader smaller by reducing size of bootinfo.

No protests from here.

Tue, Sep 13, 8:36 PM

Sun, Aug 28

phk committed rG31937f7e843d: USB id of yet another Lenovo USB-C ethernet dongle. (authored by phk).
USB id of yet another Lenovo USB-C ethernet dongle.
Sun, Aug 28, 5:23 PM

Jun 24 2022

phk added a comment to rG3899c8a38fd1: Be consistent about functions being static..

I am not able to review this patch, sorry.

Jun 24 2022, 5:11 AM

Jan 2 2022

phk committed rG79f38143bda7: sesutil: Widen "Desc" field to fit "Drive Slot 23" (authored by phk).
sesutil: Widen "Desc" field to fit "Drive Slot 23"
Jan 2 2022, 11:46 AM

Jul 29 2021

phk committed rG272144ab4109: hexdump: Flush stdout after '*' (repeat) lines. (authored by phk).
hexdump: Flush stdout after '*' (repeat) lines.
Jul 29 2021, 6:42 AM

Jul 21 2021

phk added a comment to D31215: led: call led state functions in a context with no locks held.

Re task queues: One of the ways to drive musicians right up the wall, is to have a LED flashing erratically, but not randomly. (See also: "Vetinari Clock") I think that counts against the task-queues here.

Jul 21 2021, 5:31 PM

Jul 19 2021

phk added a comment to D31215: led: call led state functions in a context with no locks held.

I think no matter what we agree here, people will probably take notice once the commit goes in, so it may be one of those cases where starting the party pre-commit in arch@ is warranted ?

Jul 19 2021, 8:26 AM
phk added a comment to D31215: led: call led state functions in a context with no locks held.

I can see the point, but I cringe at the thought of adding a kthread to just to blink LEDs...

Jul 19 2021, 8:11 AM

Jul 9 2021

phk added a comment to D30940: proccontrol(1): implement 'nonewprivs'.

looks good to me

Jul 9 2021, 7:48 AM
phk added a comment to D30939: procctl(2): add PROC_NO_NEW_PRIVS_CTL, PROC_NO_NEW_PRIVS_STATUS.

looks OK to me.

Jul 9 2021, 7:46 AM
phk added a comment to D31101: nanobsd: enhance fill_pkg.sh.

no comments from me.

Jul 9 2021, 7:32 AM

Jul 2 2021

phk added a comment to D30988: clock_gettime: Add Linux aliases for CLOCK_*.

no comments

Jul 2 2021, 5:23 AM

Jun 20 2021

phk added a comment to D30833: Enable WITHOUT_PROFILE by default.

I still think we should switch the profiled libraries to support gcov instead of statistical profiling, but I'm fine with not building them by default.

Jun 20 2021, 10:24 PM

Jun 19 2021

phk added a comment to D30819: telnet(1): add quiet mode.

Ok with me.

Jun 19 2021, 10:52 AM

Jun 18 2021

phk accepted D30802: man9: add hz(9) and hardclock(9).
Jun 18 2021, 1:44 PM
phk added inline comments to D30802: man9: add hz(9) and hardclock(9).
Jun 18 2021, 7:02 AM

Jun 8 2021

phk added a comment to D30130: Unprivileged chroot.

I'm fine with the two new features proposed individually.

Jun 8 2021, 5:43 AM

Jun 7 2021

phk committed rGaaa28628a3e4: fifolog: Rename yyparse() to getdate_yyparse(). (authored by phk).
fifolog: Rename yyparse() to getdate_yyparse().
Jun 7 2021, 6:32 AM

May 19 2021

phk committed rGe32b2bcff02e: i2c(8): Change default mode to "transfer", which should work everywhere¹ (authored by phk).
i2c(8): Change default mode to "transfer", which should work everywhere¹
May 19 2021, 6:59 PM
phk committed rG9c10d00bf8cd: i2c(8): Add interpreted mode for batch/scripted i2c operations (authored by phk).
i2c(8): Add interpreted mode for batch/scripted i2c operations
May 19 2021, 6:58 PM
phk committed rGf4583ebabc0d: i2c(8): Polish: sort switches, dont confuse address & offset (authored by phk).
i2c(8): Polish: sort switches, dont confuse address & offset
May 19 2021, 6:58 PM

May 13 2021

phk committed rGb23362afa995: Final pass of cleanup: Get rid of gotos and general polish. (authored by phk).
Final pass of cleanup: Get rid of gotos and general polish.
May 13 2021, 12:01 PM
phk committed rG63c8d31e4f9b: Rewrite and simplify the -n argument processing. (authored by phk).
Rewrite and simplify the -n argument processing.
May 13 2021, 12:01 PM
phk committed rG7183d96e1ddb: Refactor argument processing. (authored by phk).
Refactor argument processing.
May 13 2021, 12:01 PM

May 12 2021

phk committed rG29c6e6e279b3: More refactoring & polishing. (authored by phk).
More refactoring & polishing.
May 12 2021, 9:40 PM
phk committed rG5ab41ff8e92d: More refactoring: (authored by phk).
More refactoring:
May 12 2021, 9:40 PM
phk committed rGe06874f3f6d1: Centralize offset width handling, and make it possible to specify explicit… (authored by phk).
Centralize offset width handling, and make it possible to specify explicit…
May 12 2021, 8:02 PM
phk committed rG38a4732f395b: Centralize open/close of /dev/iic%d devices (authored by phk).
Centralize open/close of /dev/iic%d devices
May 12 2021, 7:45 PM

May 11 2021

phk committed rGb2ae176d914a: Sixteen bit I2c addresses are always little endian. (authored by phk).
Sixteen bit I2c addresses are always little endian.
May 11 2021, 11:08 PM
phk committed rG9db7da1f55b3: Polish source to WARNS=6 (authored by phk).
Polish source to WARNS=6
May 11 2021, 11:00 PM

May 5 2021

phk added a comment to D30116: kern: clarify boot time.

I agree that the resume behaviour should fix uptime rather than boottime. (S/R also broke on my T480 these days).

May 5 2021, 5:53 PM
phk added inline comments to D30116: kern: clarify boot time.
May 5 2021, 6:02 AM
phk added inline comments to D30116: kern: clarify boot time.
May 5 2021, 5:47 AM
phk added a comment to D30116: kern: clarify boot time.

The reason I specifically said "set" or "stepped" instead of "adjusted" is that continous adjustments, ie: frequency changes, do not cause recalculation of the estimated boot time.

May 5 2021, 5:41 AM
phk added a comment to D30116: kern: clarify boot time.

Is 'stepped' is a better word ?

May 5 2021, 5:28 AM
phk added a comment to D30116: kern: clarify boot time.

I would go with:

May 5 2021, 5:25 AM

Apr 6 2021

phk committed rG6c709cbf03c3: Add Siemens SITOP UPS500S usb device (authored by phk).
Add Siemens SITOP UPS500S usb device
Apr 6 2021, 10:57 AM

Mar 11 2021

phk added a comment to D29209: termios: add B1500000.

Many years ago, we're talking 386BSD/FreeBSD1 days, I made a patch where you could set any damn rate you wanted, and the math would happen.

Mar 11 2021, 12:54 PM

Mar 9 2021

phk added a comment to D29162: geom: disk_alloc_nowait will allocate a disk structure w/o sleeping.

I would probably just have added the flags argument to disk_alloc()...

Mar 9 2021, 8:38 PM

Mar 4 2021

phk accepted D29047: Modernize geom_stats_snapshot_get.
Mar 4 2021, 9:04 AM

Feb 12 2021

phk added a comment to D28622: handbook/config: Add section on configuring IPv6.

I should add: I have absolutely no fine feelings about this text, feel free to beat it into any kind of shape you thing suits the project these days.

Feb 12 2021, 7:54 PM
phk added inline comments to D28622: handbook/config: Add section on configuring IPv6.
Feb 12 2021, 7:53 PM

Feb 2 2021

phk committed rGd21ce74dcce6: Register the bad read before bailing on terminal errors. (authored by phk).
Register the bad read before bailing on terminal errors.
Feb 2 2021, 12:04 PM

Jan 4 2021

phk committed rG9cfd8046a48e: Remove a space I missed in previous commit (authored by phk).
Remove a space I missed in previous commit
Jan 4 2021, 2:55 PM
phk committed rGea70ab2387e5: Use the actual credentials to create the /dev/nmdm* devices. (authored by phk).
Use the actual credentials to create the /dev/nmdm* devices.
Jan 4 2021, 1:20 PM
phk committed rG3d4ce4edd86d: Remove -g option support which was removed from bhyve in (authored by phk).
Remove -g option support which was removed from bhyve in
Jan 4 2021, 1:17 PM

Dec 30 2020

phk committed rG07b0027f6c21: Handle ports FLAVOR better. (+minor polish) (authored by phk).
Handle ports FLAVOR better. (+minor polish)
Dec 30 2020, 4:06 PM

Dec 29 2020

phk committed rG3db1b221edab: Set stdout & stderr unbuffered, so that the "telnet>" prompt (authored by phk).
Set stdout & stderr unbuffered, so that the "telnet>" prompt
Dec 29 2020, 9:08 PM

Dec 13 2020

phk committed R9:de12d7f2e996: Added Christian.Haury@sagem.fr (authored by phk).
Added Christian.Haury@sagem.fr
Dec 13 2020, 8:15 PM
phk committed R9:eb40d29eaa08: Add section with pgp keys (feel free to give it a better layout) (authored by phk).
Add section with pgp keys (feel free to give it a better layout)
Dec 13 2020, 8:15 PM
phk committed R9:cf598c51f7d8: Add an appendix with policies and insert the maintainer & contrib (authored by phk).
Add an appendix with policies and insert the maintainer & contrib
Dec 13 2020, 8:15 PM
phk committed R9:f2ddd43270e3: Fix my entry up a bit. (authored by phk).
Fix my entry up a bit.
Dec 13 2020, 8:13 PM
phk committed R9:48a021c3795e: Update my pgp key. (authored by phk).
Update my pgp key.
Dec 13 2020, 8:12 PM
phk committed R9:1ebb90ef0fc2: Redefine "suspended" a little bit (authored by phk).
Redefine "suspended" a little bit
Dec 13 2020, 8:06 PM
phk committed R9:bf12d27ebcd2: Put myself under the GNATS admin together with steve. (authored by phk).
Put myself under the GNATS admin together with steve.
Dec 13 2020, 8:06 PM
phk committed R9:a7e9d6976452: Don't sort last-modified data numerically (authored by phk).
Don't sort last-modified data numerically
Dec 13 2020, 8:05 PM
phk committed R9:656996f6b40f: Make sorting on last-modified work. (authored by phk).
Make sorting on last-modified work.
Dec 13 2020, 8:05 PM
phk committed R9:bcc6deb25a97: spelling fix (authored by phk).
spelling fix
Dec 13 2020, 8:04 PM
phk committed R9:52afc28ec4c9: Amancio Hasty has stepped down as maintainer of the bt848 driver. (authored by phk).
Amancio Hasty has stepped down as maintainer of the bt848 driver.
Dec 13 2020, 8:03 PM
phk committed R9:27220b73f62f: update my pgp key. (authored by phk).
update my pgp key.
Dec 13 2020, 8:03 PM
phk committed R9:7aa2b8d0b8bf: A slight variation of the usual thing, heavily depended on my one of the (authored by phk).
A slight variation of the usual thing, heavily depended on my one of the
Dec 13 2020, 8:03 PM
phk committed R9:073598f6ee90: Remove this script again, wosch told me how to do it a better way (thanks!) (authored by phk).
Remove this script again, wosch told me how to do it a better way (thanks!)
Dec 13 2020, 8:03 PM
phk committed R9:e67d9fc70ab9: Update my pgp-key. (authored by phk).
Update my pgp-key.
Dec 13 2020, 7:47 PM
phk committed R9:50c056cd8025: Add ache to the "Core Team Alumni" list. (authored by phk).
Add ache to the "Core Team Alumni" list.
Dec 13 2020, 7:43 PM
phk committed R9:8dae9a64c26a: Ache has asked to be removed from the core team. (authored by phk).
Ache has asked to be removed from the core team.
Dec 13 2020, 7:43 PM
phk committed R9:0127059bee19: Update my PGP key. (authored by phk).
Update my PGP key.
Dec 13 2020, 7:42 PM
phk committed R9:86b72726dba9: Add a new rule to the committers: respect other contributors as well. (authored by phk).
Add a new rule to the committers: respect other contributors as well.
Dec 13 2020, 7:37 PM
phk committed R9:99b1e62893e6: Update a couple of "my" items. (authored by phk).
Update a couple of "my" items.
Dec 13 2020, 7:15 PM
phk committed R9:b5c46e063543: Ok, I was wrong, and alphastation 255 _is_ to slow, it takes 30 minutes (authored by phk).
Ok, I was wrong, and alphastation 255 _is_ to slow, it takes 30 minutes
Dec 13 2020, 7:10 PM
phk committed R9:502e61bbe2af: Add entry about __FreeBSD_version 500101 (authored by phk).
Add entry about __FreeBSD_version 500101
Dec 13 2020, 7:09 PM
phk committed R9:df432e21fe64: Document __FreeBSD_version 500104: (authored by phk).
Document __FreeBSD_version 500104:
Dec 13 2020, 7:09 PM
phk committed R9:534c062d58ff: Ammend entry for _FreeBSD_version 500104 to mention MAJOR_AUTO (authored by phk).
Ammend entry for _FreeBSD_version 500104 to mention MAJOR_AUTO
Dec 13 2020, 7:09 PM
phk committed R9:4f8ba48dd592: Document __FreeBSD_version. (authored by phk).
Document __FreeBSD_version.
Dec 13 2020, 7:09 PM
phk committed R9:262c11c3fb54: Fix entry for 500105 which was mistakenly committed as 500005. (authored by phk).
Fix entry for 500105 which was mistakenly committed as 500005.
Dec 13 2020, 7:08 PM
phk committed R9:afc735f05274: Add my request for a microscopic fibrechannel setup so I can test my (authored by phk).
Add my request for a microscopic fibrechannel setup so I can test my
Dec 13 2020, 7:05 PM
phk committed R9:07b675c8387f: Update my fibrechannel entry to note lack of switch. (authored by phk).
Update my fibrechannel entry to note lack of switch.
Dec 13 2020, 6:58 PM
phk committed R9:bd1cf4541c72: Add entry for cdevsw updates. (authored by phk).
Add entry for cdevsw updates.
Dec 13 2020, 6:58 PM
phk committed R9:6372c7cdb2dd: document bump of __FreeBSD_version (authored by phk).
document bump of __FreeBSD_version
Dec 13 2020, 6:57 PM
phk committed R9:0135d6582937: Document __FreeBSD_version after devicedriver API megapatch. (authored by phk).
Document __FreeBSD_version after devicedriver API megapatch.
Dec 13 2020, 6:50 PM
phk committed R9:700b2889aabc: document 502113 version bump (authored by phk).
document 502113 version bump
Dec 13 2020, 6:46 PM
phk committed R9:0e3030d7789e: document 502116 (authored by phk).
document 502116
Dec 13 2020, 6:46 PM
phk committed R9:18e6cace95b5: Document 502117 (authored by phk).
Document 502117
Dec 13 2020, 6:45 PM
phk committed R9:714e95f0e93f: update (authored by phk).
update
Dec 13 2020, 6:36 PM
phk committed R9:f52d80448094: Add list of alleged candidate mobos. (authored by phk).
Add list of alleged candidate mobos.
Dec 13 2020, 6:36 PM
phk committed R9:561dc20aa41a: Document __FreeBSD_version 600008 (authored by phk).
Document __FreeBSD_version 600008
Dec 13 2020, 6:34 PM
phk committed R9:ef0bfd1a9186: Add ieee488 entry (authored by phk).
Add ieee488 entry
Dec 13 2020, 6:34 PM
phk committed R9:62211acb3d8d: Document __FreeBSD_version 600021: (authored by phk).
Document __FreeBSD_version 600021:
Dec 13 2020, 6:32 PM
phk committed R9:5207fed54df2: Got my VIA, thanks Mike. (authored by phk).
Got my VIA, thanks Mike.
Dec 13 2020, 6:31 PM
phk committed R9:3b5376ede1df: Add the begining of a NanoBSD page. (authored by phk).
Add the begining of a NanoBSD page.
Dec 13 2020, 6:30 PM
phk committed R9:52cdf70a21db: Add the actual nanobsd files. (authored by phk).
Add the actual nanobsd files.
Dec 13 2020, 6:30 PM
phk committed R9:803e748cc65e: Document __FreeBSD_version 800016 (authored by phk).
Document __FreeBSD_version 800016
Dec 13 2020, 5:55 PM

Dec 11 2020

phk added inline comments to D27571: CLOCK_ADJUST_REALTIME.
Dec 11 2020, 4:22 PM

Nov 28 2020

phk committed rS368130: Add watchdog(9) driver for the Fintek F81803 SuperIO chip.
Add watchdog(9) driver for the Fintek F81803 SuperIO chip
Nov 28 2020, 10:34 PM

Nov 26 2020

phk committed rS368052: Add support for Fintek F81803 SuperIO chip.
Add support for Fintek F81803 SuperIO chip
Nov 26 2020, 7:34 AM

Nov 24 2020

phk added a comment to D27324: IPv6: Set ifdisabled in the kernel rather than in rc.

Not sure why I'm asked to review this, not exactly my specialty, but it looks OK and sounds sensible.

Nov 24 2020, 6:45 AM

Nov 23 2020

phk committed rD54705: Update my GPG key.
Update my GPG key
Nov 23 2020, 9:00 AM

Oct 29 2020

phk accepted D26994: Document disk ioctl.
Oct 29 2020, 7:50 AM
phk added a comment to D26994: Document disk ioctl.

Well, I wrote a lot of that text myself, so I can hardly disagree with it.

Oct 29 2020, 7:50 AM

Oct 27 2020

phk accepted D26967: Remove frontstuff.

Ok with me.

Oct 27 2020, 6:27 AM

Oct 19 2020

phk accepted D26805: geom_ctl.c: remove unused header files.

Nice cleanup!

Oct 19 2020, 10:13 AM