Page MenuHomeFreeBSD

phk (Poul-Henning Kamp)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2019, 9:11 PM (278 w, 3 d)

Recent Activity

May 7 2024

phk committed rGd3831ca8e371: Remove lingering geom_bde references. (authored by phk).
Remove lingering geom_bde references.
May 7 2024, 9:26 AM
phk committed rG69956de36f8c: Remove final cross-reference to GBDE (authored by phk).
Remove final cross-reference to GBDE
May 7 2024, 7:42 AM
phk committed rG66bee50af774: Remove cross-references to GBDE (authored by phk).
Remove cross-references to GBDE
May 7 2024, 7:42 AM
phk committed rG6580f5c38dd5: Remove gbde from the "userland" pseudo-target (authored by phk).
Remove gbde from the "userland" pseudo-target
May 7 2024, 7:42 AM
phk committed rG8d2d1d651678: Remove GBDE source files (authored by phk).
Remove GBDE source files
May 7 2024, 7:41 AM
phk committed rG77bd06e43007: Add gbde rc.d script to ObsoleteFiles.inc (authored by phk).
Add gbde rc.d script to ObsoleteFiles.inc
May 7 2024, 7:41 AM
phk committed rGbbc36ba969ac: Remove documentation of GBDE rc support (authored by phk).
Remove documentation of GBDE rc support
May 7 2024, 7:41 AM
phk committed rG984764d79646: Remove GBDE stress test (authored by phk).
Remove GBDE stress test
May 7 2024, 7:41 AM
phk committed rGd50f41366bfb: Remove gbde from rescue (authored by phk).
Remove gbde from rescue
May 7 2024, 7:41 AM
phk committed rG0c7237d7e234: Remove GBDE rc support (authored by phk).
Remove GBDE rc support
May 7 2024, 7:41 AM
phk committed rG14b475c47905: Remove gbde support from swapon(8) (authored by phk).
Remove gbde support from swapon(8)
May 7 2024, 7:41 AM
phk committed rGeef9887871fd: Remove gbde.4 man page (authored by phk).
Remove gbde.4 man page
May 7 2024, 7:41 AM
phk committed rG6ac1f02be34a: Add GBDE to ObsoleteFiles.inc (authored by phk).
Add GBDE to ObsoleteFiles.inc
May 7 2024, 6:51 AM
phk committed rG74be64851263: Disconnect GBDE from the build. (Per earlier announcements of retirement.) (authored by phk).
Disconnect GBDE from the build. (Per earlier announcements of retirement.)
May 7 2024, 5:20 AM

Feb 5 2024

phk committed R9:8692c6ebce8e: New PGP key. (authored by phk).
New PGP key.
Feb 5 2024, 8:25 AM

Oct 11 2023

phk committed rGf17b69fd0fde: Move (LENOVO, TBT3LAN) from if_ure til if_cdce where it works much better (authored by phk).
Move (LENOVO, TBT3LAN) from if_ure til if_cdce where it works much better
Oct 11 2023, 3:56 PM

Aug 22 2023

phk added a comment to D41549: Deprecate fdc and fdformat for 15.

and fdcontrol(1)

Aug 22 2023, 6:28 PM
phk added a comment to D41549: Deprecate fdc and fdformat for 15.

dont forget fdwrite(1)

Aug 22 2023, 6:27 PM

Aug 16 2023

phk added a comment to D36295: [RFC} Use 115200 bps by default for serial ports.

I'm all for this, and yes, in 14 please.

Aug 16 2023, 6:48 AM

Aug 10 2023

phk committed rG4ff782c06a56: tcopy: Pick up max blocksize from sysctl kern.maxphys (authored by phk).
tcopy: Pick up max blocksize from sysctl kern.maxphys
Aug 10 2023, 2:59 PM

Aug 1 2023

phk added inline comments to D41164: RELNOTES: Note the deprecation of 32-bit platforms for 15.0..
Aug 1 2023, 5:53 AM

Jul 31 2023

phk added inline comments to D41164: RELNOTES: Note the deprecation of 32-bit platforms for 15.0..
Jul 31 2023, 7:01 PM

Jul 25 2023

phk added a comment to D41164: RELNOTES: Note the deprecation of 32-bit platforms for 15.0..

IMO the current text does a really bad job at communicating that.

Jul 25 2023, 9:55 PM
phk added a comment to D41164: RELNOTES: Note the deprecation of 32-bit platforms for 15.0..

So if I understand your position, what we are trying to say is:

Jul 25 2023, 9:06 PM
phk added a comment to D41164: RELNOTES: Note the deprecation of 32-bit platforms for 15.0..

So which is it ?

Jul 25 2023, 7:13 PM

Jul 24 2023

phk added inline comments to D41164: RELNOTES: Note the deprecation of 32-bit platforms for 15.0..
Jul 24 2023, 9:35 PM

Jun 20 2023

phk accepted D40656: fifolog: Trim some dead code and unused variables..

I think this is OK.

Jun 20 2023, 8:54 PM

Apr 30 2023

phk committed rGe0e5bf4d6283: freebsd-update: Mention 13.2-RELEASE in usage. (authored by phk).
freebsd-update: Mention 13.2-RELEASE in usage.
Apr 30 2023, 5:08 AM

Apr 24 2023

phk added a comment to rG643336549081: If copy_file_range(2) fails with EXDEV, use fall-back..

I personally find cp(1) far too important to let it fail sporadically.

Apr 24 2023, 5:24 PM

Apr 4 2023

phk committed rG643336549081: If copy_file_range(2) fails with EXDEV, use fall-back. (authored by phk).
If copy_file_range(2) fails with EXDEV, use fall-back.
Apr 4 2023, 7:41 AM

Mar 14 2023

phk added a comment to D38607: gvinum: add deprecation notice upon drive tasting.

I'm not at all familiar with (g)vinum code, but I fear the message may be very spammy (once per drive?) where you put it.

Mar 14 2023, 10:57 PM

Feb 28 2023

phk committed rG996606792ff9: Add deprecation notice to the gbde(8) program, scheduled to be removed in… (authored by phk).
Add deprecation notice to the gbde(8) program, scheduled to be removed in…
Feb 28 2023, 9:40 PM

Feb 25 2023

phk committed rG3b7d00ddbd81: Xref rc.conf in my previous addition. (authored by phk).
Xref rc.conf in my previous addition.
Feb 25 2023, 4:09 PM

Feb 15 2023

phk committed rGfe01817876a0: Add an example using /etc/rc.conf syntax (authored by phk).
Add an example using /etc/rc.conf syntax
Feb 15 2023, 11:40 AM

Jan 22 2023

phk committed rG2da12891daa2: Document another example for "binat". (authored by phk).
Document another example for "binat".
Jan 22 2023, 9:33 AM

Jan 14 2023

phk committed rGc389ad227ba5: Typo, spotted by Matteo. (authored by phk).
Typo, spotted by Matteo.
Jan 14 2023, 2:54 PM
phk committed rG017de00844ae: Add a SVG version of vector-Beastie. (authored by phk).
Add a SVG version of vector-Beastie.
Jan 14 2023, 2:32 PM

Dec 5 2022

phk committed rGc2ddf2edb4aa: tree.h: Fix SP/TAB white-space issues, add () for clarity. (authored by phk).
tree.h: Fix SP/TAB white-space issues, add () for clarity.
Dec 5 2022, 2:30 PM

Oct 3 2022

phk added a comment to D36857: time(3): Increase precision of sbt and bintime conversion functions by using gcd..
Oct 3 2022, 7:43 PM

Sep 13 2022

phk accepted D36550: i386: Make boot loader smaller by reducing size of bootinfo.

No protests from here.

Sep 13 2022, 8:36 PM

Aug 28 2022

phk committed rG31937f7e843d: USB id of yet another Lenovo USB-C ethernet dongle. (authored by phk).
USB id of yet another Lenovo USB-C ethernet dongle.
Aug 28 2022, 5:23 PM

Jun 24 2022

phk added a comment to rG3899c8a38fd1: Be consistent about functions being static..

I am not able to review this patch, sorry.

Jun 24 2022, 5:11 AM

Jan 2 2022

phk committed rG79f38143bda7: sesutil: Widen "Desc" field to fit "Drive Slot 23" (authored by phk).
sesutil: Widen "Desc" field to fit "Drive Slot 23"
Jan 2 2022, 11:46 AM

Jul 29 2021

phk committed rG272144ab4109: hexdump: Flush stdout after '*' (repeat) lines. (authored by phk).
hexdump: Flush stdout after '*' (repeat) lines.
Jul 29 2021, 6:42 AM

Jul 21 2021

phk added a comment to D31215: led: call led state functions in a context with no locks held.

Re task queues: One of the ways to drive musicians right up the wall, is to have a LED flashing erratically, but not randomly. (See also: "Vetinari Clock") I think that counts against the task-queues here.

Jul 21 2021, 5:31 PM

Jul 19 2021

phk added a comment to D31215: led: call led state functions in a context with no locks held.

I think no matter what we agree here, people will probably take notice once the commit goes in, so it may be one of those cases where starting the party pre-commit in arch@ is warranted ?

Jul 19 2021, 8:26 AM
phk added a comment to D31215: led: call led state functions in a context with no locks held.

I can see the point, but I cringe at the thought of adding a kthread to just to blink LEDs...

Jul 19 2021, 8:11 AM

Jul 9 2021

phk added a comment to D30940: proccontrol(1): implement 'nonewprivs'.

looks good to me

Jul 9 2021, 7:48 AM
phk added a comment to D30939: procctl(2): add PROC_NO_NEW_PRIVS_CTL, PROC_NO_NEW_PRIVS_STATUS.

looks OK to me.

Jul 9 2021, 7:46 AM
phk added a comment to D31101: nanobsd: enhance fill_pkg.sh.

no comments from me.

Jul 9 2021, 7:32 AM

Jul 2 2021

phk added a comment to D30988: clock_gettime: Add Linux aliases for CLOCK_*.

no comments

Jul 2 2021, 5:23 AM

Jun 20 2021

phk added a comment to D30833: Enable WITHOUT_PROFILE by default.

I still think we should switch the profiled libraries to support gcov instead of statistical profiling, but I'm fine with not building them by default.

Jun 20 2021, 10:24 PM

Jun 19 2021

phk added a comment to D30819: telnet(1): add quiet mode.

Ok with me.

Jun 19 2021, 10:52 AM

Jun 18 2021

phk accepted D30802: man9: add hz(9) and hardclock(9).
Jun 18 2021, 1:44 PM
phk added inline comments to D30802: man9: add hz(9) and hardclock(9).
Jun 18 2021, 7:02 AM

Jun 8 2021

phk added a comment to D30130: Unprivileged chroot.

I'm fine with the two new features proposed individually.

Jun 8 2021, 5:43 AM

Jun 7 2021

phk committed rGaaa28628a3e4: fifolog: Rename yyparse() to getdate_yyparse(). (authored by phk).
fifolog: Rename yyparse() to getdate_yyparse().
Jun 7 2021, 6:32 AM

May 19 2021

phk committed rGe32b2bcff02e: i2c(8): Change default mode to "transfer", which should work everywhere¹ (authored by phk).
i2c(8): Change default mode to "transfer", which should work everywhere¹
May 19 2021, 6:59 PM
phk committed rG9c10d00bf8cd: i2c(8): Add interpreted mode for batch/scripted i2c operations (authored by phk).
i2c(8): Add interpreted mode for batch/scripted i2c operations
May 19 2021, 6:58 PM
phk committed rGf4583ebabc0d: i2c(8): Polish: sort switches, dont confuse address & offset (authored by phk).
i2c(8): Polish: sort switches, dont confuse address & offset
May 19 2021, 6:58 PM

May 13 2021

phk committed rGb23362afa995: Final pass of cleanup: Get rid of gotos and general polish. (authored by phk).
Final pass of cleanup: Get rid of gotos and general polish.
May 13 2021, 12:01 PM
phk committed rG63c8d31e4f9b: Rewrite and simplify the -n argument processing. (authored by phk).
Rewrite and simplify the -n argument processing.
May 13 2021, 12:01 PM
phk committed rG7183d96e1ddb: Refactor argument processing. (authored by phk).
Refactor argument processing.
May 13 2021, 12:01 PM

May 12 2021

phk committed rG29c6e6e279b3: More refactoring & polishing. (authored by phk).
More refactoring & polishing.
May 12 2021, 9:40 PM
phk committed rG5ab41ff8e92d: More refactoring: (authored by phk).
More refactoring:
May 12 2021, 9:40 PM
phk committed rGe06874f3f6d1: Centralize offset width handling, and make it possible to specify explicit… (authored by phk).
Centralize offset width handling, and make it possible to specify explicit…
May 12 2021, 8:02 PM
phk committed rG38a4732f395b: Centralize open/close of /dev/iic%d devices (authored by phk).
Centralize open/close of /dev/iic%d devices
May 12 2021, 7:45 PM

May 11 2021

phk committed rGb2ae176d914a: Sixteen bit I2c addresses are always little endian. (authored by phk).
Sixteen bit I2c addresses are always little endian.
May 11 2021, 11:08 PM
phk committed rG9db7da1f55b3: Polish source to WARNS=6 (authored by phk).
Polish source to WARNS=6
May 11 2021, 11:00 PM

May 5 2021

phk added a comment to D30116: kern: clarify boot time.

I agree that the resume behaviour should fix uptime rather than boottime. (S/R also broke on my T480 these days).

May 5 2021, 5:53 PM
phk added inline comments to D30116: kern: clarify boot time.
May 5 2021, 6:02 AM
phk added inline comments to D30116: kern: clarify boot time.
May 5 2021, 5:47 AM
phk added a comment to D30116: kern: clarify boot time.

The reason I specifically said "set" or "stepped" instead of "adjusted" is that continous adjustments, ie: frequency changes, do not cause recalculation of the estimated boot time.

May 5 2021, 5:41 AM
phk added a comment to D30116: kern: clarify boot time.

Is 'stepped' is a better word ?

May 5 2021, 5:28 AM
phk added a comment to D30116: kern: clarify boot time.

I would go with:

May 5 2021, 5:25 AM

Apr 6 2021

phk committed rG6c709cbf03c3: Add Siemens SITOP UPS500S usb device (authored by phk).
Add Siemens SITOP UPS500S usb device
Apr 6 2021, 10:57 AM

Mar 11 2021

phk added a comment to D29209: termios: add B1500000.

Many years ago, we're talking 386BSD/FreeBSD1 days, I made a patch where you could set any damn rate you wanted, and the math would happen.

Mar 11 2021, 12:54 PM

Mar 9 2021

phk added a comment to D29162: geom: disk_alloc_nowait will allocate a disk structure w/o sleeping.

I would probably just have added the flags argument to disk_alloc()...

Mar 9 2021, 8:38 PM

Mar 4 2021

phk accepted D29047: Modernize geom_stats_snapshot_get.
Mar 4 2021, 9:04 AM

Feb 12 2021

phk added a comment to D28622: handbook/config: Add section on configuring IPv6.

I should add: I have absolutely no fine feelings about this text, feel free to beat it into any kind of shape you thing suits the project these days.

Feb 12 2021, 7:54 PM
phk added inline comments to D28622: handbook/config: Add section on configuring IPv6.
Feb 12 2021, 7:53 PM

Feb 2 2021

phk committed rGd21ce74dcce6: Register the bad read before bailing on terminal errors. (authored by phk).
Register the bad read before bailing on terminal errors.
Feb 2 2021, 12:04 PM

Jan 4 2021

phk committed rG9cfd8046a48e: Remove a space I missed in previous commit (authored by phk).
Remove a space I missed in previous commit
Jan 4 2021, 2:55 PM
phk committed rGea70ab2387e5: Use the actual credentials to create the /dev/nmdm* devices. (authored by phk).
Use the actual credentials to create the /dev/nmdm* devices.
Jan 4 2021, 1:20 PM
phk committed rG3d4ce4edd86d: Remove -g option support which was removed from bhyve in (authored by phk).
Remove -g option support which was removed from bhyve in
Jan 4 2021, 1:17 PM

Dec 30 2020

phk committed rG07b0027f6c21: Handle ports FLAVOR better. (+minor polish) (authored by phk).
Handle ports FLAVOR better. (+minor polish)
Dec 30 2020, 4:06 PM

Dec 29 2020

phk committed rG3db1b221edab: Set stdout & stderr unbuffered, so that the "telnet>" prompt (authored by phk).
Set stdout & stderr unbuffered, so that the "telnet>" prompt
Dec 29 2020, 9:08 PM

Dec 13 2020

phk committed R9:de12d7f2e996: Added Christian.Haury@sagem.fr (authored by phk).
Added Christian.Haury@sagem.fr
Dec 13 2020, 8:15 PM
phk committed R9:eb40d29eaa08: Add section with pgp keys (feel free to give it a better layout) (authored by phk).
Add section with pgp keys (feel free to give it a better layout)
Dec 13 2020, 8:15 PM
phk committed R9:cf598c51f7d8: Add an appendix with policies and insert the maintainer & contrib (authored by phk).
Add an appendix with policies and insert the maintainer & contrib
Dec 13 2020, 8:15 PM
phk committed R9:f2ddd43270e3: Fix my entry up a bit. (authored by phk).
Fix my entry up a bit.
Dec 13 2020, 8:13 PM
phk committed R9:48a021c3795e: Update my pgp key. (authored by phk).
Update my pgp key.
Dec 13 2020, 8:12 PM
phk committed R9:1ebb90ef0fc2: Redefine "suspended" a little bit (authored by phk).
Redefine "suspended" a little bit
Dec 13 2020, 8:06 PM
phk committed R9:bf12d27ebcd2: Put myself under the GNATS admin together with steve. (authored by phk).
Put myself under the GNATS admin together with steve.
Dec 13 2020, 8:06 PM
phk committed R9:a7e9d6976452: Don't sort last-modified data numerically (authored by phk).
Don't sort last-modified data numerically
Dec 13 2020, 8:05 PM
phk committed R9:656996f6b40f: Make sorting on last-modified work. (authored by phk).
Make sorting on last-modified work.
Dec 13 2020, 8:05 PM
phk committed R9:bcc6deb25a97: spelling fix (authored by phk).
spelling fix
Dec 13 2020, 8:04 PM
phk committed R9:52afc28ec4c9: Amancio Hasty has stepped down as maintainer of the bt848 driver. (authored by phk).
Amancio Hasty has stepped down as maintainer of the bt848 driver.
Dec 13 2020, 8:03 PM
phk committed R9:27220b73f62f: update my pgp key. (authored by phk).
update my pgp key.
Dec 13 2020, 8:03 PM
phk committed R9:7aa2b8d0b8bf: A slight variation of the usual thing, heavily depended on my one of the (authored by phk).
A slight variation of the usual thing, heavily depended on my one of the
Dec 13 2020, 8:03 PM