Paths

Table of Contentst

Differential D49182

watchdog: Add a new "Control" ioctl
AcceptedPublic
Actions

Authored by jhibbits on Feb 28 2025, 6:55 PM.

Tags

None

Referenced Files

	F120816696: D49182.id151696.diff
	Sat, Jun 21, 8:33 AM

	F120791600: D49182.id151696.diff
	Sat, Jun 21, 3:23 AM

	Unknown Object (File)
	Wed, Jun 18, 7:36 PM

	Unknown Object (File)
	Sun, Jun 15, 2:26 AM

	Unknown Object (File)
	Sat, Jun 14, 11:35 AM

	Unknown Object (File)
	Tue, Jun 10, 9:50 PM

	Unknown Object (File)
	Sat, May 31, 6:18 PM

	Unknown Object (File)
	May 8 2025, 6:46 AM

View All 14 Files

Subscribers

Details

Reviewers

jhb
imp
phk
stevek

Summary

In preparation for a new watchdog timeout interface using sbintime_t,
add a new control ioctl to arm, pat, and disarm the watchdog.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62696
Build 59580: arc lint + arc unit

Event Timeline

jhibbits created this revision.Feb 28 2025, 6:55 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2025, 6:55 PM

jhibbits requested review of this revision.Feb 28 2025, 6:55 PM

Harbormaster completed remote builds in B62696: Diff 151696.Feb 28 2025, 6:55 PM

jhibbits added reviewers: jhb, imp, phk, stevek.Feb 28 2025, 7:00 PM

jhibbits mentioned this in D47312: watchdog: Convert to using sbintime_t format.

jlduran added a subscriber: jlduran.Mar 2 2025, 10:13 PM

I'm fine with this.

This revision is now accepted and ready to land.Mar 12 2025, 7:52 PM

jhb added inline comments.Mar 13 2025, 4:02 PM

sys/dev/watchdog/watchdog.c
128	Do you mean to call it twice back to back with the same arguments if both `RESET` and `ENABLE` are set?

jhibbits added inline comments.Apr 29 2025, 3:13 AM

sys/dev/watchdog/watchdog.c
128	No, I intended to make it an else if here (might need to do more work in one of them, but haven't decided if I do, so keeping them separate). Will fix.

Revision Contents
Changeset List

Path

Size

sys/

dev/

watchdog/

22 lines

sys/

8 lines

usr.sbin/

watchdogd/

13 lines

Diff 151696

sys/dev/watchdog/watchdog.c

Loading...

sys/sys/watchdog.h

Loading...

usr.sbin/watchdogd/watchdogd.c

Loading...