Page MenuHomeFreeBSD

periodic 100.chksetuid: supress output if diff is purely whitespace
Needs RevisionPublic

Authored by allanjude on Sep 20 2024, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 8, 2:02 AM
Unknown Object (File)
Dec 12 2024, 6:43 PM
Unknown Object (File)
Dec 3 2024, 12:36 AM
Unknown Object (File)
Nov 28 2024, 12:08 AM
Unknown Object (File)
Nov 24 2024, 11:29 PM
Unknown Object (File)
Nov 21 2024, 11:53 AM
Unknown Object (File)
Nov 21 2024, 11:53 AM
Unknown Object (File)
Nov 20 2024, 11:40 AM

Details

Summary

the chksetuid periodic script would report differences of unchanged
files if some other file changed and made the inode column wider.

Use diff -b to suppress these actually unchanged lines

PR: 281555
Reported by: martin@lispworks.com
MFC after: 1 week
Relnotes: yes
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59539
Build 56426: arc lint + arc unit

Event Timeline

I think adding -b will not fix it (and in fact security_status_diff_flags already contains -b by default). The problem with -b is that it only ignores changes in the amount of white space, but doesn't ignore newly added whitespace.

Using -w would probably fix it.

michaelo added a subscriber: michaelo.
michaelo added inline comments.
usr.sbin/periodic/etc/security/security.functions
75

This one is redudant, -b is already default.

This revision now requires changes to proceed.Nov 11 2024, 8:16 AM
usr.sbin/periodic/etc/security/security.functions
71

Why -q twice? The manpage does not mention that invoking twice changes anything.