Page MenuHomeFreeBSD

michaelo (Michael Osipov)
User

Projects

User Details

User Since
Jul 19 2018, 5:53 PM (305 w, 21 h)

Recent Activity

Fri, May 3

michaelo added a comment to D42719: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast.

Followup review created: https://reviews.freebsd.org/D45073

Fri, May 3, 8:03 AM
michaelo added a reverting change for rGb14cfdf665bb: sh(1): Discourage use of -e.: D45073: sh(1): Remove unsubstantiated discourage use of -e.
Fri, May 3, 8:02 AM
michaelo requested review of D45073: sh(1): Remove unsubstantiated discourage use of -e.
Fri, May 3, 8:01 AM
michaelo added a comment to D42719: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast.

So I merged now the explicit exits. We have two months until next quarterly for failures. As @mandree said, enough time. I will come up with a review for the manpage as well.

Fri, May 3, 7:48 AM
michaelo closed D42719: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast.
Fri, May 3, 7:48 AM
michaelo committed R11:4280a82efe69: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast (authored by michaelo).
Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast
Fri, May 3, 7:48 AM
michaelo committed rGaa48259f3371: periodic.conf: remove long deprecated security_daily_compat_var() (authored by michaelo).
periodic.conf: remove long deprecated security_daily_compat_var()
Fri, May 3, 7:41 AM
michaelo closed D44796: periodic.conf: remove long deprecated security_daily_compat_var().
Fri, May 3, 7:41 AM

Mon, Apr 29

michaelo closed D44824: www/tomcat-native2: new port.
Mon, Apr 29, 5:10 PM
michaelo committed R11:145858d18e57: www/tomcat-native2: new port (authored by michaelo).
www/tomcat-native2: new port
Mon, Apr 29, 5:10 PM
michaelo added a comment to D44824: www/tomcat-native2: new port.

No response fron @ale , I will go ahead and push this with @jrm's approval.

Mon, Apr 29, 4:54 PM

Apr 22 2024

michaelo committed R11:8f3a81069ccc: */*: take ownership of lev@'s Subversion ports (authored by michaelo).
*/*: take ownership of lev@'s Subversion ports
Apr 22 2024, 1:15 PM
michaelo closed D44862: */*: take ownership of lev@'s Subversion ports.
Apr 22 2024, 1:15 PM
michaelo updated the diff for D44862: */*: take ownership of lev@'s Subversion ports.

Bump port revision

Apr 22 2024, 1:10 PM
michaelo added a comment to D44824: www/tomcat-native2: new port.

@ale, you want to take a look at?

Apr 22 2024, 8:45 AM
michaelo added a comment to D44862: */*: take ownership of lev@'s Subversion ports.

Stupid question: Should I bump the port revision here?

Apr 22 2024, 8:41 AM

Apr 19 2024

michaelo added a comment to D44862: */*: take ownership of lev@'s Subversion ports.

Lev approached me via e-mail whether I'd like to take ownership of it. I have agreed. He shall approve this review.

Apr 19 2024, 11:50 AM
michaelo requested review of D44862: */*: take ownership of lev@'s Subversion ports.
Apr 19 2024, 11:49 AM

Apr 17 2024

michaelo updated the diff for D44824: www/tomcat-native2: new port.

Improved version which also supports OpenSSL 1.1.1 by reverting a few changes
from Tomcat Native. Ran full Tomcat test suites, all tests pass.

Apr 17 2024, 9:41 PM
michaelo added a comment to D44824: www/tomcat-native2: new port.
In D44824#1021968, @jrm wrote:

Thanks. Looks good. Could you also run it through something like portlint -AC and portclippy/portfmt?

Apr 17 2024, 1:55 PM
michaelo added a comment to D44824: www/tomcat-native2: new port.

One important thing to note: I could bring back OpenSSL 1.1.1 support with a simple patch because

Apr 17 2024, 1:55 PM
michaelo requested review of D44824: www/tomcat-native2: new port.
Apr 17 2024, 1:27 PM
michaelo closed D44822: www/tomcat-native: take ownership.
Apr 17 2024, 8:57 AM
michaelo committed R11:e3ea2e922ea9: www/tomcat-native: take ownership (authored by michaelo).
www/tomcat-native: take ownership
Apr 17 2024, 8:57 AM
michaelo added a comment to D44822: www/tomcat-native: take ownership.

I'd also suggest to bump PORTREVISION to also reflect the future binary packages (this might not be necessary if you plan to do a quick update).

Apr 17 2024, 8:35 AM
michaelo updated the diff for D44822: www/tomcat-native: take ownership.

Bump port revision

Apr 17 2024, 8:31 AM
michaelo added a comment to D44822: www/tomcat-native: take ownership.

Ale's response: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276736#c12

Apr 17 2024, 8:30 AM
michaelo requested review of D44822: www/tomcat-native: take ownership.
Apr 17 2024, 8:24 AM
michaelo committed rGd596e573119e: freebsd-update: Don't provide copiable commands in output (authored by michaelo).
freebsd-update: Don't provide copiable commands in output
Apr 17 2024, 6:52 AM
michaelo committed rG69dbc448cf8b: freebsd-update: Don't provide copiable commands in output (authored by michaelo).
freebsd-update: Don't provide copiable commands in output
Apr 17 2024, 6:51 AM

Apr 16 2024

michaelo added a comment to D42719: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast.

So which route should I go @mandree? set or exit?

Apr 16 2024, 5:23 AM
michaelo added a comment to D42719: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast.
In D42719#1021272, @jrm wrote:

To elaborate, I felt that specifically checking for the issue at hand is unlikely to introduce any new problems, but adding set -e, which, of course, affects the whole script is more likely. That said, since @michael is prepared to take on any new problems, I'm fine either way.

Apr 16 2024, 5:23 AM

Apr 15 2024

michaelo requested review of D44796: periodic.conf: remove long deprecated security_daily_compat_var().
Apr 15 2024, 11:07 AM
michaelo added a reviewer for D42719: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast: rene.
Apr 15 2024, 6:17 AM
michaelo updated the diff for D42719: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast.

Use exit explicitly

Apr 15 2024, 6:16 AM

Apr 13 2024

michaelo added a comment to D42719: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast.

Tried || exit $? locally, same result:

Apr 13 2024, 7:38 AM

Apr 12 2024

michaelo added a comment to D42719: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast.

If the || exit $? version is preferred I will try it, no issue.

Apr 12 2024, 6:55 PM
michaelo updated the diff for D42719: Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast.

Rebased and tested again with poudriere-built packages:

Apr 12 2024, 6:53 PM

Apr 10 2024

michaelo closed D44694: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup).
Apr 10 2024, 7:04 PM
michaelo committed R11:3887897fbaa0: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup) (authored by michaelo).
Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup)
Apr 10 2024, 7:04 PM

Apr 9 2024

michaelo added a comment to D44694: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup).
In D44694#1019044, @jrm wrote:

LGTM However, someone from portmgr should approve. I'll try to get someone to look today.

Apr 9 2024, 3:38 PM
michaelo updated the diff for D44694: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup).

Remove trailing period

Apr 9 2024, 10:34 AM
michaelo added inline comments to D44694: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup).
Apr 9 2024, 10:24 AM
michaelo requested review of D44694: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup).
Apr 9 2024, 10:09 AM

Apr 1 2024

michaelo committed rGfc5208028a78: freebsd-update: mark "cron" as fetched as "fetch" itself (authored by michaelo).
freebsd-update: mark "cron" as fetched as "fetch" itself
Apr 1 2024, 7:20 PM
michaelo committed rGe54b9d17f82d: freebsd-update: mark "cron" as fetched as "fetch" itself (authored by michaelo).
freebsd-update: mark "cron" as fetched as "fetch" itself
Apr 1 2024, 7:19 PM

Mar 18 2024

michaelo closed D44403: devel/websvn: update port to 2.8.4.
Mar 18 2024, 12:30 PM
michaelo committed R11:88cc397f6157: devel/websvn: update port to 2.8.4 (authored by michaelo).
devel/websvn: update port to 2.8.4
Mar 18 2024, 12:30 PM
michaelo requested review of D44403: devel/websvn: update port to 2.8.4.
Mar 18 2024, 11:35 AM
michaelo added a comment to D43703: motd: stop prepending "uname -v" output dynamically.

Any other opinions?

Mar 18 2024, 10:11 AM
michaelo closed D44356: freebsd-update: mark "cron" as fetched as "fetch" itself.
Mar 18 2024, 10:03 AM
michaelo committed rG85c3ef77cc9f: freebsd-update: mark "cron" as fetched as "fetch" itself (authored by michaelo).
freebsd-update: mark "cron" as fetched as "fetch" itself
Mar 18 2024, 10:03 AM
michaelo committed rGc547f17816be: Add myself (michaelo) to the calendar (authored by michaelo).
Add myself (michaelo) to the calendar
Mar 18 2024, 9:47 AM
michaelo committed rG59b02bb420e3: freebsd-update: Don't provide copiable commands in output (authored by michaelo).
freebsd-update: Don't provide copiable commands in output
Mar 18 2024, 9:37 AM
michaelo closed D43700: freebsd-update: Don't provide copiable commands in output.
Mar 18 2024, 9:36 AM

Mar 15 2024

michaelo added a comment to D44356: freebsd-update: mark "cron" as fetched as "fetch" itself.
In D44356#1011926, @jrm wrote:

@cperciva, it would be good to get your approval here as well.

Mar 15 2024, 3:52 PM

Mar 14 2024

michaelo requested review of D44356: freebsd-update: mark "cron" as fetched as "fetch" itself.
Mar 14 2024, 4:49 PM

Mar 13 2024

michaelo closed D44339: print/ghostscript10: fix compilation issue with LLVM > 14.
Mar 13 2024, 8:32 PM
michaelo committed R11:5e3da22d048f: print/ghostscript10: fix compilation issue with LLVM > 14 (authored by michaelo).
print/ghostscript10: fix compilation issue with LLVM > 14
Mar 13 2024, 8:32 PM
michaelo requested changes to D44153: java/eclipse: prevent conflict install devel/git@lite if devel/git already installed.

@vvd, do you want to update this review?

Mar 13 2024, 3:48 PM
michaelo added a comment to D44339: print/ghostscript10: fix compilation issue with LLVM > 14.

Removed inline patch in favor of remote one.

Mar 13 2024, 3:23 PM
michaelo updated the diff for D44339: print/ghostscript10: fix compilation issue with LLVM > 14.

fetch patch from remote

Mar 13 2024, 3:22 PM
michaelo added inline comments to D44339: print/ghostscript10: fix compilation issue with LLVM > 14.
Mar 13 2024, 3:10 PM
michaelo added inline comments to D44339: print/ghostscript10: fix compilation issue with LLVM > 14.
Mar 13 2024, 2:47 PM
michaelo added inline comments to D44339: print/ghostscript10: fix compilation issue with LLVM > 14.
Mar 13 2024, 2:27 PM
michaelo closed D44338: www/tomcat-native: update port to 1.3.0.
Mar 13 2024, 2:17 PM
michaelo committed R11:e632a9f0646a: www/tomcat-native: update port to 1.3.0 (authored by michaelo).
www/tomcat-native: update port to 1.3.0
Mar 13 2024, 2:17 PM
michaelo added a comment to D44338: www/tomcat-native: update port to 1.3.0.
In D44338#1011233, @ale wrote:

I think you should change the WWW entry to point to 1.3

Mar 13 2024, 1:52 PM
michaelo updated the diff for D44338: www/tomcat-native: update port to 1.3.0.

apply comments from ale@

Mar 13 2024, 1:52 PM
michaelo requested review of D44339: print/ghostscript10: fix compilation issue with LLVM > 14.
Mar 13 2024, 1:37 PM
michaelo requested review of D44338: www/tomcat-native: update port to 1.3.0.
Mar 13 2024, 12:10 PM
michaelo closed D44298: print/ghostscript10: update port to 10.03.0.
Mar 13 2024, 10:34 AM
michaelo committed R11:77995e0fa8b5: print/ghostscript10: update port to 10.03.0 (authored by michaelo).
print/ghostscript10: update port to 10.03.0
Mar 13 2024, 10:34 AM

Mar 11 2024

michaelo requested review of D44298: print/ghostscript10: update port to 10.03.0.
Mar 11 2024, 11:20 AM
michaelo committed R11:90e44770f550: */*: properly depend on Maven package (authored by michaelo).
*/*: properly depend on Maven package
Mar 11 2024, 9:11 AM
michaelo closed D44229: */*: properly depend on Maven package.
Mar 11 2024, 9:11 AM

Mar 6 2024

michaelo added a comment to D43700: freebsd-update: Don't provide copiable commands in output.

This is now a minimal change, please have a look guys.

Mar 6 2024, 10:04 AM
michaelo added a comment to D44229: */*: properly depend on Maven package.
In D44229#1009025, @jrm wrote:

FYI, devel/eclipse failed in my 15.0-CURRENT 1500008 amd64 jail.

http://pkg.ftfl.ca/data/15amd64-default/2024-03-05_13h23m40s/logs/errors/eclipse-4.24_2.log

It doesn't seem like this change should have any effect, but can you verify this?

Mar 6 2024, 8:32 AM

Mar 5 2024

michaelo updated the diff for D44229: */*: properly depend on Maven package.

Include java/eclipse

Mar 5 2024, 4:37 PM
michaelo added a comment to D44229: */*: properly depend on Maven package.
In D44229#1008960, @vvd wrote:

I think you can add java/eclipse here too.
Probably https://reviews.freebsd.org/D44153 isn't actual anymore.

Mar 5 2024, 4:34 PM
michaelo added a comment to D44153: java/eclipse: prevent conflict install devel/git@lite if devel/git already installed.

FTR: https://reviews.freebsd.org/D44229

Mar 5 2024, 3:27 PM
michaelo requested review of D44229: */*: properly depend on Maven package.
Mar 5 2024, 3:26 PM

Feb 29 2024

michaelo updated the diff for D43700: freebsd-update: Don't provide copiable commands in output.

Address improvement proposal from @emaste.

Feb 29 2024, 5:06 PM
michaelo added a comment to D44153: java/eclipse: prevent conflict install devel/git@lite if devel/git already installed.

I will take care of these:

Feb 29 2024, 12:23 PM
michaelo added inline comments to D44153: java/eclipse: prevent conflict install devel/git@lite if devel/git already installed.
Feb 29 2024, 12:05 PM
michaelo added inline comments to D44153: java/eclipse: prevent conflict install devel/git@lite if devel/git already installed.
Feb 29 2024, 11:56 AM
michaelo added inline comments to D44153: java/eclipse: prevent conflict install devel/git@lite if devel/git already installed.
Feb 29 2024, 11:17 AM
michaelo added inline comments to D44153: java/eclipse: prevent conflict install devel/git@lite if devel/git already installed.
Feb 29 2024, 10:30 AM

Feb 28 2024

michaelo closed D43864: */*: Properly depend on Subversion LTS or latest with WITH_SUBVERSION_VER.
Feb 28 2024, 3:55 PM
michaelo committed R11:e83f0a9c84ea: */*: Properly depend on Subversion LTS or latest with WITH_SUBVERSION_VER (authored by michaelo).
*/*: Properly depend on Subversion LTS or latest with WITH_SUBVERSION_VER
Feb 28 2024, 3:55 PM
michaelo added a comment to D43700: freebsd-update: Don't provide copiable commands in output.

What do you think about something like Run 'freebsd-update [options] install' to proceed? It offers a reminder to include the user's necessary options but retains the example style.

Feb 28 2024, 3:14 PM
michaelo added a comment to D43700: freebsd-update: Don't provide copiable commands in output.

Although this change looks good to me, we also should consider making -d default to $(-b)/var/db/freebsd-update. *THAT* left me with broken boot environment :-/ (I've used -b /path/to/be without -d /path/to/be/var/db/freebsd-update).

Feb 28 2024, 2:11 PM

Feb 27 2024

michaelo added a comment to D43864: */*: Properly depend on Subversion LTS or latest with WITH_SUBVERSION_VER.

@lev, one day left, do you want to take a peek?

Feb 27 2024, 2:35 PM
michaelo added a comment to D43700: freebsd-update: Don't provide copiable commands in output.

Address comment.

Feb 27 2024, 2:33 PM
michaelo added inline comments to D43700: freebsd-update: Don't provide copiable commands in output.
Feb 27 2024, 2:32 PM
michaelo updated the diff for D43700: freebsd-update: Don't provide copiable commands in output.

Address typo

Feb 27 2024, 2:30 PM

Feb 16 2024

michaelo added a comment to D43864: */*: Properly depend on Subversion LTS or latest with WITH_SUBVERSION_VER.

I will give @lev two weeks to review as demanded by the maintainer timeout. So I can merge around 2024-02-27.

Feb 16 2024, 9:56 PM

Feb 14 2024

michaelo added a comment to D43703: motd: stop prepending "uname -v" output dynamically.
In D43703#1000910, @jrm wrote:

I don't have strong options either way. On the one hand, I can appreciate how this would confuse some users when they log in to a jail. On the other hand, I expect some users would miss seeing this information (by default) when they log in. While it may also be confusing, it's reporting accurate information that many would expect, i.e., version information about the running kernel.

Brainstorming ideas, what about appending something like this to /var/run/motd?

echo "$(hostname) $(uname -smi) running kernel/userland: $(uname -r)/$(freebsd-version -u)"

In a 14 jail running on a 15-CURRENT host, the output looks like this.

myhostname FreeBSD amd64 GENERIC-NODEBUG running kernel/userland: 15.0-CURRENT/14.0-RC4
Feb 14 2024, 10:53 AM

Feb 13 2024

michaelo added a comment to D43864: */*: Properly depend on Subversion LTS or latest with WITH_SUBVERSION_VER.

Ran three sets in poudiere:

Feb 13 2024, 2:52 PM
michaelo requested review of D43864: */*: Properly depend on Subversion LTS or latest with WITH_SUBVERSION_VER.
Feb 13 2024, 2:49 PM