User Details
- User Since
- Jul 19 2018, 5:53 PM (301 w, 2 d)
Mon, Apr 22
Bump port revision
@ale, you want to take a look at?
Stupid question: Should I bump the port revision here?
Fri, Apr 19
Lev approached me via e-mail whether I'd like to take ownership of it. I have agreed. He shall approve this review.
Wed, Apr 17
Improved version which also supports OpenSSL 1.1.1 by reverting a few changes
from Tomcat Native. Ran full Tomcat test suites, all tests pass.
One important thing to note: I could bring back OpenSSL 1.1.1 support with a simple patch because
- https://bz.apache.org/bugzilla/show_bug.cgi?id=66667 has not been solved
- It is almost only:
Bump port revision
Ale's response: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276736#c12
Tue, Apr 16
So which route should I go @mandree? set or exit?
Mon, Apr 15
Use exit explicitly
Sat, Apr 13
Tried || exit $? locally, same result:
Fri, Apr 12
If the || exit $? version is preferred I will try it, no issue.
Rebased and tested again with poudriere-built packages:
Wed, Apr 10
Tue, Apr 9
Remove trailing period
Mon, Apr 1
Mar 18 2024
Any other opinions?
Mar 15 2024
Mar 14 2024
Mar 13 2024
@vvd, do you want to update this review?
Removed inline patch in favor of remote one.
fetch patch from remote
apply comments from ale@
Mar 11 2024
Mar 6 2024
This is now a minimal change, please have a look guys.
Mar 5 2024
Include java/eclipse
Feb 29 2024
Address improvement proposal from @emaste.
I will take care of these:
Feb 28 2024
Feb 27 2024
@lev, one day left, do you want to take a peek?
Address comment.
Address typo
Feb 16 2024
I will give @lev two weeks to review as demanded by the maintainer timeout. So I can merge around 2024-02-27.
Feb 14 2024
Feb 13 2024
Ran three sets in poudiere:
Feb 9 2024
Feb 7 2024
Feb 2 2024
Feb 1 2024
This one comes from: https://github.com/BastilleBSD/bastille/issues/393
@emaste, as discussed, here it is.