Sounds good. You also need to bump PORTREVSION.

Should the patch be removed from other JDK ports as well?

In D48698#1111309, @michaelo wrote:

Will leave time until Saturday and then will merge.

Looks good. Ideally, we would confirm that the reverse dependencies [0] are good.

Looks good, but we should also hear from @sunpoet. (That's always implied when I approve changes to a port someone else maintains.)

In the commit log, you say,

List also the Python version limitation since none is documented.

If you're feeling motivated:

• it might be helpful (at some point) to upstream the patch
• see if portfmt -D Makefile has anything useful to say about the formatting.

It's not such a big deal in these particular cases, but as a matter of principle, I felt it was worth mentioning that pushing another committer's review without first discussing it with the committer can lead to problems. Is the commit really ready? Is the commit log ready? (Without using something like git arc Phabricator can mess with the commit log.) Are there any other commits that must be committed first?

Rather than have a messy commit log, it's best (from my perspective) to leave things as they are now.

@carlavilla, in the future, could you please not commit my work without discussing it with me first?

Incorporate correction spotted by Pau Amma

Address one more issue from Pau Amma

Address issues raised by Pau Amma

Incorporate updated Canna patches from HIROSE yuuji <yuuji@gentei.org>.

Again, update spacing between list items to be consistent.

• {author} inserts both a developer's name and email address. For consistency, insert a missing email address for someone who is not a developer.
• No functional change, but be consistent with spacing between list items.

Remove the duplicate text Ed pointed out.

Another minor source formatting tweak.

No output change. Add a space below 'OS Improvements' header for consistency.

Address Ed's comments.

Incorporate new links from Alice

In D48223#1105180, @haraldei_anduin.net wrote:

@michaelo I don't see any significant change between the output from jstack regardless of the target process running from stripped or non-stripped binaries: https://gist.github.com/snake66/319cdc0772902037610da906c0863d47

On the other hand, the openjdk build does run strip --strip-debug during the build, so not sure how much more value the extra strip run provides.

This report was written by Alice Sowerby <alice@freebsdfoundation.org>.

This report was written by Alice Sowerby <alice@freebsdfoundation.org>.

This report was written by Alice Sowerby <alice@freebsdfoundation.org>.

In D48432#1105087, @yasu wrote:

In D48432#1104894, @jrm wrote:

1. @yasu, are you able to handle updating the canna patch?

Ok, I'll request it to author after 30.1 is released.

In preparation for Emacs 30.1 [0], I build-tested USES=emacs ports and encountered errors building lang/php-mode.el. This update incorporates upstream fixes. Please let me know if this works for you, and I will commit it after editors/emacs is updated to 30.1.

1. @yasu, are you able to handle updating the canna patch?

Remove extra SUB_LIST=...

Fix port/package links

Simplify some wording and do not introduce the fasl term twice.

Remove duplicate sentence.

In D48392#1103769, @bofh wrote:

In D48392#1103768, @jrm wrote:

This was submitted based on a miscommunication. I'm preparing the Foundation entry, but waiting on some authors to share their contributions. @bofh, could you please close this revision?

I am working on an updated patch as suggested by you. Or do you want me to close the revision and send you the text?

This was submitted based on a miscommunication. I'm preparing the Foundation entry, but waiting on some authors to share their contributions. @bofh, could you please close this revision?

Another question, is this applicable to net/samba416?

In D48313#1102823, @otis wrote:

What is the rationale behind this change, please? Moreover, I guess @jrm is the best samba person in this ballroom.

Address @emaste's comments by removing more references to 13.3 in advisory-template.txt and errata-template.txt