User Details
- User Since
- Apr 10 2016, 5:00 PM (526 w, 1 d)
Yesterday
Looks good. I'll commit with some minor tweaks to the commit message to comply with the guidelines in the Committer's Guide, and to remove mention of the patches for the UUID includes. BTW, if you're not already using it, there is a commit template you can use by doing git config --add core.hooksPath .hooks. Look good to you?
This mostly looks good, but a few issues need to be addressed:
Sun, May 10
Sat, May 9
Closing since I missed an existing PR.
This also fixes a build issue with R-4.6.0. Here is a proposed commit message.
Looks good. A key change in the last two updates was to fix issues with internal non-API calls. You could add something like this to the commit message.
Wed, May 6
Tue, May 5
Mon, May 4
Thanks @ivy.
Fri, May 1
Wed, Apr 29
Tue, Apr 28
If you are a reviewer here, this is a heads-up in case you would like to test your USES=cran ports with R-4.6.0. I hope to push by the end of the work week.
Mon, Apr 27
This will be a useful verification step. I sometimes submit a review and then notice that the summary isn't displaying as I intended.
Wed, Apr 22
Mon, Apr 20
I'd say it's fine as is. My one comment verges on nitpicking, so feel free to ignore it.
I tested a few flavor/version combinations in poudriere, and they all look good.
Sat, Apr 18
Fri, Apr 17
@thj, there are a few other changes you need from D56051: https://pkg.ftfl.ca/data/16amd64-default/2026-04-17_10h57m45s/logs/errors/vpp-26.02.log
Wed, Apr 15
Install the libraries with COPYTREE_SHARE
Tue, Apr 14
As @alven noted, this was committed in bc45b7ec889c7662bbbc64d26b00424db8dcb741, and there were some follow-up fixes in 07ed11c5d4f7893f3ca5bbf72cdf46ffa4a517b2 and 68c8d4070d4a132d0fbd5f75307fd3d7beac4221. For some unknown reason, this review wasn't auto-closed, so closing it manually.
Mon, Apr 13
Apr 11 2026
Apr 10 2026
- Rather than declare a new variable to disable native compilation of FreeBSD ports, reuse the existing variable, native-comp-jit-compilation, which controls native compilation of all third-party elisp.
- Tweak documentation
- Update pkg-message
- Incorporate improvements from @mce
- Patch the build rather than delete .elc from STAGEDIR in a post-install target
Apr 8 2026
- Set @tijl as maintainer of devel/gettext-po-mode
- japanese/navi2ch/pkg-plist: Uses PLIST_SUB variable
Apr 7 2026
- Change an instance of EMACS_VERSION_SITE_LISPDIR to EMACS_VERSION_LISPDIR in textproc/yaml.el; this was accidentally missed earlier
- DEFAULT_VERSIONS+=emacs=... now sets the Emacs port and flavor used for USES=emacs:build ports
- Fix a whitespace error noted by @mandree
- Add a function to clean up stale eln-cache subdirectories left by previous Emacs builds
@mandree, I fixed one double blank line in UPDATING, but as far as I can see, all the others are false positives in generated patches such as audio/emms/files/patch-Makefile. You can see the space before tab complaints are just the diff context markers before a TAB. In these cases, because those lines were unchanged, there is a space instead of a + or -.
With what is here now, the DEFAULT_VERSIONS+=emacs... definitions have no effect. Since ports using USES=emacs no longer have flavors or runtime dependencies on any Emacs, this seemed unnecessary. Some ports (31) still have USES=emacs:build to, for example, generate autoloads.el. I hardcoded the default flavor of editors/emacs for this, though I can now appreciate that may not suit everyone.
Rebase and fix merge conflicts after @mce's refactoring of japanese/navi2ch
Apr 6 2026
Apr 5 2026
Apr 4 2026
- Fix a regexp issue in default.el.in. When I switched some regexps to be anchored at the end of string rather than end of line, I switched, e.g., "\\.elc$" to "\\.el\\" when I should have done "\\.el\\'".