User Details
- User Since
- Apr 10 2016, 5:00 PM (524 w, 5 d)
Yesterday
Wed, Apr 29
Tue, Apr 28
If you are a reviewer here, this is a heads-up in case you would like to test your USES=cran ports with R-4.6.0. I hope to push by the end of the work week.
Mon, Apr 27
This will be a useful verification step. I sometimes submit a review and then notice that the summary isn't displaying as I intended.
Wed, Apr 22
Mon, Apr 20
I'd say it's fine as is. My one comment verges on nitpicking, so feel free to ignore it.
I tested a few flavor/version combinations in poudriere, and they all look good.
Sat, Apr 18
Fri, Apr 17
@thj, there are a few other changes you need from D56051: https://pkg.ftfl.ca/data/16amd64-default/2026-04-17_10h57m45s/logs/errors/vpp-26.02.log
Wed, Apr 15
Install the libraries with COPYTREE_SHARE
Tue, Apr 14
As @alven noted, this was committed in bc45b7ec889c7662bbbc64d26b00424db8dcb741, and there were some follow-up fixes in 07ed11c5d4f7893f3ca5bbf72cdf46ffa4a517b2 and 68c8d4070d4a132d0fbd5f75307fd3d7beac4221. For some unknown reason, this review wasn't auto-closed, so closing it manually.
Mon, Apr 13
Sat, Apr 11
Fri, Apr 10
- Rather than declare a new variable to disable native compilation of FreeBSD ports, reuse the existing variable, native-comp-jit-compilation, which controls native compilation of all third-party elisp.
- Tweak documentation
- Update pkg-message
- Incorporate improvements from @mce
- Patch the build rather than delete .elc from STAGEDIR in a post-install target
Wed, Apr 8
- Set @tijl as maintainer of devel/gettext-po-mode
- japanese/navi2ch/pkg-plist: Uses PLIST_SUB variable
Tue, Apr 7
- Change an instance of EMACS_VERSION_SITE_LISPDIR to EMACS_VERSION_LISPDIR in textproc/yaml.el; this was accidentally missed earlier
- DEFAULT_VERSIONS+=emacs=... now sets the Emacs port and flavor used for USES=emacs:build ports
- Fix a whitespace error noted by @mandree
- Add a function to clean up stale eln-cache subdirectories left by previous Emacs builds
@mandree, I fixed one double blank line in UPDATING, but as far as I can see, all the others are false positives in generated patches such as audio/emms/files/patch-Makefile. You can see the space before tab complaints are just the diff context markers before a TAB. In these cases, because those lines were unchanged, there is a space instead of a + or -.
Does this approach work for your use case?Hi @freebsd_dev.thsi.be,
Rebase and fix merge conflicts after @mce's refactoring of japanese/navi2ch
Mon, Apr 6
Sun, Apr 5
Sat, Apr 4
- Fix a regexp issue in default.el.in. When I switched some regexps to be anchored at the end of string rather than end of line, I switched, e.g., "\\.elc$" to "\\.el\\" when I should have done "\\.el\\'".
Thu, Apr 2
Apr 2 2026
Apr 1 2026
I moved these changes to D56116. It's better to commit this in one go.
- Regexps like \\.el$ should be anchored at the end of the string rather the end of the line (\\.el\\).
- Move the elsip port changes from D56116 to here; it's better to make this one commit.
Tweak some pkg-messages:
Load all autoloads files installed by FreeBSD elisp ports. This mirrors what package.el does for ELPA packages, ensuring that autoloaded functions are available without requiring users to explicitly load each package.
Mar 31 2026
- Put the variable definitions in site-start.el, and the rest of the startup code in default.el. This separation makes it easier for users to selectively disable native or byte compilation.
- Rebase.
Mar 30 2026
- Add support for byte compilation
- Add variables to allow users to easily disable either byte compilation or native compilation
Mar 29 2026
I thought of this as an addendum to your work, and, ideally, we reviewers should have caught it in https://reviews.freebsd.org/D55938. Since you're busy tackling the arm32 and powerpc64 stuff, I'll take care of this.
Mar 28 2026
I responded to the commit mail, but it might be helpful to include this in the review for posterity.
Minor change to print/pdf-tools
Guard native-compile-async in site-start.el so it only runs in interactive sessions, not batch mode.