User Details
- User Since
- Apr 10 2016, 5:00 PM (548 w, 9 h)
Today
Yesterday
Sat, Oct 10
Yup, you're right.
Yup, you're right.
One thing I missed last time: You also want USE_RC_SUBR as you did in x11/framework-autorotate.
Fri, Oct 9
This looks good. Could you also verify that you built the documentation/website? A successful build helps confirm that there isn't a little nit we missed.
@aokblast Gentle ping. Do you plan to commit this?
Christos, it looks like you missed a file. In step 4 of https://docs.freebsd.org/en/articles/committers-guide/#conventions-committers, there is a link to a README file. In that file, it says you should also add text to documentation/content/en/articles/pgpkeys/_index.adoc. It looks like @des's addkey.sh script should also mention this. You used the script, right?
Same optional nit as in D60456 about the subject in the commit message.
Same optional nit as in D60456 about the subject in the commit message.
Same optional nit as in D60456 about the subject in the commit message.
I took a peek at the upstread code and noticed that the RC script does pw groupadd "$airplane_radiosd_group". It would be better if the port did this. See https://docs.freebsd.org/en/books/porters-handbook/book/#users-and-groups.
Thu, Oct 8
Tue, Oct 6
Sat, Oct 3
Fri, Oct 2
Wed, Sep 30
Tue, Sep 29
Mon, Sep 28
Sun, Sep 27
As requested, I tested D59653 and D59657 on top of 943686575d81, the commit that fixed the cold-boot panic. The test machine is the one that panicked after 4e0f283fb97a: an Intel Core i3-6100T desktop with a Winbond WEC WPCT200 rev 0x2 (TPM 1.2, TIS 1.2, no interrupt resource) attached via ACPI PNP0C31.
Sat, Sep 26
I tested this on an Intel Core i3-6100T desktop with a Winbond WEC WPCT200 rev 0x2 (TPM 1.2, TIS 1.2, no interrupt resource), attached via ACPI PNP0C31.
Fri, Sep 25
Wed, Sep 23
Also, if you want to support the tests through make test, you can add this:
+1 to fuz's comment about DISTVERSION.
Sun, Sep 13
This fails to build because it expects a python3 binary, which isn't guaranteed to be installed. https://pkg.ftfl.ca/build.html?mastername=16amd64-default&build=2026-09-13_06h47m11s
Sep 10 2026
Could you rebase onto a recent main?
Sep 8 2026
Sep 7 2026
Sep 2 2026
This looks good.