User Details
- User Since
- Apr 10 2016, 5:00 PM (538 w, 1 d)
Sat, Aug 1
Fri, Jul 31
Tue, Jul 28
Thu, Jul 23
I have the same general comment as in D58233. There are some phrases that sound non-native, but overall, I like the text's authenticity. I'm including a light rewrite here, but please consider it optional. What you have is quite good.
This reads well to me. There are a few phrases that are perhaps slightly atypical, but I like it the way it is. It comes across as authentic.
Looks good to me. I suggested an optional change to be slightly more precise.
Wed, Jul 22
Sun, Jul 19
Fri, Jul 17
Tue, Jul 14
Link to more report enties and sort
Mon, Jul 13
Mon, Jul 6
Sun, Jul 5
Jul 4 2026
Jul 2 2026
Jun 30 2026
Jun 27 2026
Jun 26 2026
Jun 25 2026
Jun 24 2026
Jun 23 2026
Jun 22 2026
Jun 21 2026
Jun 20 2026
The commit message says "are no" instead of "are not". You might consider something simpler because users can really filter out whatever they want.
Jun 15 2026
Jun 12 2026
Nit: The Committer's guide says the subject line after the prefix should be capitalized. https://docs.freebsd.org/en/articles/committers-guide/#_capitalize_the_first_letter_of_the_subject
Jun 4 2026
Thanks @guest-patmaddox. Much better. I haven't had much time to look into this or bug 292973. Do you have any thoughts on the shortcomings I mentioned in my last comment?
- Replace the hacky tree-sitter indent helper functions with cleaner rules from Pat's configuration with some minor tweaks:
- Use c-ts-mode--simple-indent-rules instead of c-ts-mode--indent-styles and c-ts-indent-offset instead of c-ts-mode-indent-offset.
- Add a fix for initializer list opening braces.
- Provide, a closing footer, and an improved docstring.
Jun 3 2026
Really update to the latest commit.
- Update to latest commit
- Do not include non-reproducible information such as build date, instead display RPIBOOT: FreeBSD package (version 20260527)
Jun 2 2026
I believe Emacs calls ls --dired and pipes the output. I think that means we have a problem because you are using ftell(stdout) (*in three different places), which will always return -1 when the output is redirected to a pipe.
May 29 2026
Base the port on the HEAD of upstream's repository, which includes some helpful fixes since the last tag. Upstream is using date-base tags, so just using lastest commit and calling it 20260527 should be fine.
Tweak COMMENT
Rename the port to rpi-usbboot
We could, and there are advantages to having the portname match the directory. For example, when you have the package installed and, based on the package name, search the ports tree for rpi-usboot, you'll get a hit.
May 28 2026
Add an rpi- prefix for the package name
May 27 2026
May 26 2026
May 25 2026
Accepting because everything looks correct to me, with the caveat that I don't often look at this code, and I haven't tested (because I don't have an Intel processor whose signature appears in an extended table).
Looks good. There is a typo in the commit message: `s/sotred/stored/'.
Looks good to me. There is a typo in the commit message: s/sepcific/specific/.
May 23 2026
Thanks both. Nice catch to fix the inverted condition. If I understand correctly, before this fix, we would never have detected an extended signature, and thus never applied microcode for processors only listed in the extended signature.