User Details
- User Since
- Apr 10 2016, 5:00 PM (414 w, 1 d)
Yesterday
I'll commit now and incorporate @pauamma_gundo.com's suggestion.
Sun, Mar 17
Sat, Mar 16
Fri, Mar 15
I committed these in two separate commits.
Hi Chris,
@cperciva, it would be good to get your approval here as well.
Thu, Mar 14
portfmt has two suggestions:
Wed, Mar 13
Looks good to me unless @vvd has something actionable regarding runtime issues.
Tue, Mar 12
Wed, Mar 6
It looks good on 14.0 amd64. http://pkg.ftfl.ca/data/14amd64-default/2024-03-05_19h14m11s/logs/eclipse-4.24_2.log
Tue, Mar 5
FYI, devel/eclipse failed in my 15.0-CURRENT 1500008 amd64 jail.
Sat, Mar 2
Fri, Mar 1
Tue, Feb 27
Mon, Feb 26
Sat, Feb 24
Everything looks good.
Fri, Feb 23
@chs, what should I look for to confirm the update has been applied?
Fix the title
I also see that we need an update, which I will also do after this lands.
I don't have AMD hardware to test, but the port changes look good. I like the sysutils/cpu-microcode-rc/files/pkg-message.in changes. Referring to the two methods as 'Early/Late loading' is clearer than the 'first/second method'.
Thu, Feb 22
Looks good. I'll commit with this log message unless there are objections.
Wed, Feb 21
Sun, Feb 18
Feb 17 2024
Your approach of creating something here that is easier to review and referencing it in Bugzilla makes sense. There have been some recent investigations into switching our tooling to something that incorporates bug reports and reviews in one place.
Feb 16 2024
I asked some doc committers on IRC to have a look.
Feb 14 2024
Thanks. These are nice updates. I added a few mostly nit-picky comments and added a few other reviewers.
Feb 13 2024
I don't have strong options either way. On the one hand, I can appreciate how this would confuse some users when they log in to a jail. On the other hand, I expect some users would miss seeing this information (by default) when they log in. While it may also be confusing, it's reporting accurate information that many would expect, i.e., version information about the running kernel.
Since this won't affect the official packages, and it's essentially the same as
.if ${PORT_OPTIONS:MBLAH} RUN_DEPENDS+= ${LOCALBASE}/bin/bin:cat/port .else ... .endif
or
.if ${FLAVOR} == blah LIB_DEPENDS+= blah.so:cat/port .else ... .endif
it seems fine to me.
Feb 11 2024
Feb 9 2024
Feb 7 2024
Ran poudriere testport for 13/14/15 amd64 with default options. Also ran it with all options on/off on 14.