Ports CommittersOrganization
ActivePublic

Recent Activity

Dec 9 2017

sunpoet added a member for Ports Committers: sunpoet.
Dec 9 2017, 11:17 AM

Nov 21 2017

lifanov closed D12793: ArangoDB FreeBSD port.
Nov 21 2017, 3:48 PM · Ports Committers
dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

I re-tested it and the port looks good now.
Would you like me to commit it?

Is there a Bugzilla issue for it?

Nov 21 2017, 3:12 PM · Ports Committers
lifanov accepted D12793: ArangoDB FreeBSD port.

I re-tested it and the port looks good now.
Would you like me to commit it?

Nov 21 2017, 3:04 PM · Ports Committers

Nov 20 2017

dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

OK, this works now and looks pretty good.
Can you consider making some configuration files @sample?
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-config

There are two steps to it:

  1. install the file with .sample suffix (like arangod.conf.sample)
  2. list it with @sample in pkg-plist: @sample %%ETCDIR%%/arangod.conf.sample

    When pkg installs a package with @sample entries, these get copied to the correct location if the files are missing and then the user can modify the configuration files without causing checksum mismatches and without the files being clobbered on package update.
Nov 20 2017, 11:25 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Install configuration files as samples.

Nov 20 2017, 11:25 PM · Ports Committers
lifanov added a comment to D12793: ArangoDB FreeBSD port.

OK, this works now and looks pretty good.
Can you consider making some configuration files @sample?
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-config

Nov 20 2017, 6:05 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Update the arangodb user directory

Nov 20 2017, 3:53 PM · Ports Committers
dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

This doesn't build for me:

/work/stage/usr/local/share/arangodb/js/server/bootstrap/coordinator-database.js
CMake Error at cmake_install.cmake:87 (file):
  file INSTALL cannot find
  "/usr/home/lifanov/src/svn/freebsd/ports/head/databases/arangodb32/work/.build/var/log/arangodb3".
gmake[1]: *** [Makefile:99: install/strip] Error 1
Nov 20 2017, 3:41 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Add the cmake patch

Nov 20 2017, 3:41 PM · Ports Committers
lifanov added a comment to D12793: ArangoDB FreeBSD port.

This doesn't build for me:

/work/stage/usr/local/share/arangodb/js/server/bootstrap/coordinator-database.js
CMake Error at cmake_install.cmake:87 (file):
  file INSTALL cannot find
  "/usr/home/lifanov/src/svn/freebsd/ports/head/databases/arangodb32/work/.build/var/log/arangodb3".
gmake[1]: *** [Makefile:99: install/strip] Error 1
Nov 20 2017, 3:31 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Update maintainer address.

Nov 20 2017, 10:11 AM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Update to 3.2.8

Nov 20 2017, 10:10 AM · Ports Committers

Nov 16 2017

dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

I'm not sure I understand what you mean - should I replace them with the actual final value - e.g. /usr/local/share, or add @dir entries for them to pkg-plist?

The directory that gets installed is /usr/local/share/arangodb3, which suggests that PORTNAME should be agangodb3?
There are several other places where arangodb3 name gets used. Example:

: ${arangod_dbpath="/var/db/arangodb3"}
: ${arangod_logpath="/var/log/arangodb3"}
: ${arangod_apppath="/var/db/arangodb3-apps"}

As for the renaming bit I was thinking of following the mongodbXY port convention and eventually add an arangodb33 port that is set to conflict with the arangodb32 port. Thoughts?

Versioning it like mongodbXY is a good idea in general, but it is useful if the two versions are incompatible or require special upgrade/migration steps (like postgresql).
Another consideration is how long do you expect people to run arangodb 3.2 once 3.3 is realeased.

Thanks!

Nov 16 2017, 9:44 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Updated to 3.2.7
Addressed reviewer comments

Nov 16 2017, 9:44 PM · Ports Committers

Nov 8 2017

lifanov added a comment to D12793: ArangoDB FreeBSD port.

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

I'm not sure I understand what you mean - should I replace them with the actual final value - e.g. /usr/local/share, or add @dir entries for them to pkg-plist?

Nov 8 2017, 2:31 PM · Ports Committers

Nov 7 2017

dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

Nov 7 2017, 3:51 PM · Ports Committers

Nov 3 2017

lifanov added a comment to D12793: ArangoDB FreeBSD port.

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

Nov 3 2017, 1:25 PM · Ports Committers

Oct 27 2017

dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Remove git dependency and add python dependency

Oct 27 2017, 5:31 PM · Ports Committers
mat added inline comments to D12793: ArangoDB FreeBSD port.
Oct 27 2017, 5:03 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Move USE_GITHUB to its rightful place.

Oct 27 2017, 4:21 PM · Ports Committers
mat added inline comments to D12793: ArangoDB FreeBSD port.
Oct 27 2017, 3:38 PM · Ports Committers

Oct 26 2017

dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Simplify the man page moving logic

Oct 26 2017, 3:22 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Do not explicitly gzip man pages.

Oct 26 2017, 2:42 PM · Ports Committers
dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

I can see in the build system that some components are hard to decouple.
Try decoupling what you can, like boost or libcurl.

Oct 26 2017, 2:41 PM · Ports Committers
lifanov added a comment to D12793: ArangoDB FreeBSD port.

I can see in the build system that some components are hard to decouple.
Try decoupling what you can, like boost or libcurl.

Oct 26 2017, 1:57 PM · Ports Committers
dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

How did you generate pkg-plist? The files listed in it are already relative to LOCALBASE and @dir should only specify directories that are empty.
The "make makeplist" target should generate a pkg-plist close to what you want, so then you need to review it and make any manual changes you need.

Oct 26 2017, 10:36 AM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Silenced stage-qa and check-orphans.

Oct 26 2017, 10:34 AM · Ports Committers
lifanov added a comment to D12793: ArangoDB FreeBSD port.

Could you also try running "make stage-qa" and "make check-orphans" please and make sure these are clean?

Oct 26 2017, 2:31 AM · Ports Committers
lifanov added a comment to D12793: ArangoDB FreeBSD port.

How did you generate pkg-plist? The files listed in it are already relative to LOCALBASE and @dir should only specify directories that are empty.
The "make makeplist" target should generate a pkg-plist close to what you want, so then you need to review it and make any manual changes you need.

Oct 26 2017, 2:22 AM · Ports Committers

Oct 25 2017

dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.
Oct 25 2017, 11:12 PM · Ports Committers
lifanov added a reviewer for D12793: ArangoDB FreeBSD port: lifanov.
Oct 25 2017, 6:46 PM · Ports Committers
lifanov added a comment to D12793: ArangoDB FreeBSD port.

Hi and welcome to FreeBSD!

Oct 25 2017, 6:46 PM · Ports Committers
dev_dudu.ro created D12793: ArangoDB FreeBSD port.
Oct 25 2017, 4:48 PM · Ports Committers

Aug 15 2017

pfg abandoned D11590: Split ccx out of cad/calculix.

Committed revision 447973.

Aug 15 2017, 12:21 AM · Ports Committers

Aug 14 2017

pfg updated the diff for D11590: Split ccx out of cad/calculix.

Update with some review from gerald@

Aug 14 2017, 1:42 AM · Ports Committers

Aug 11 2017

vanilla added a member for Ports Committers: vanilla.
Aug 11 2017, 2:20 AM

Jul 30 2017

dbaio closed D11550: net/glusterfs port update to latest 3.11.1 release by committing rP446944: net/glusterfs: Update to 3.11.1.
Jul 30 2017, 10:45 PM · Ports Committers
craig001_lerwick.hopto.org updated the diff for D11550: net/glusterfs port update to latest 3.11.1 release.

updated patch from Danilo, sync with PR

Jul 30 2017, 9:21 PM · Ports Committers

Jul 14 2017

pfg updated the diff for D11590: Split ccx out of cad/calculix.

Change according to feedback: instead of creating a -cgx part, only split away the ccx part. his is less confusing for end users and still attains our objective of constraining the fortran part in an independent port.
It also reduces the diffs.

Jul 14 2017, 3:22 PM · Ports Committers
jbeich removed a member for Ports Committers: jbeich.
Jul 14 2017, 3:06 PM
eadler unlocked Ports Committers membership.
Jul 14 2017, 2:53 PM

Jul 13 2017

pfg created D11590: Split ccx out of cad/calculix.
Jul 13 2017, 10:56 PM · Ports Committers

Jul 12 2017

craig001_lerwick.hopto.org added a comment to D11550: net/glusterfs port update to latest 3.11.1 release.

thanks Mat... new PR created;
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220674

Jul 12 2017, 1:01 PM · Ports Committers
craig001_lerwick.hopto.org updated the diff for D11550: net/glusterfs port update to latest 3.11.1 release.

empty line added as suggested

Jul 12 2017, 12:52 PM · Ports Committers
mat added a comment to D11550: net/glusterfs port update to latest 3.11.1 release.

Looks ok, feel free to submit a PR to get this committed.

Jul 12 2017, 12:45 PM · Ports Committers
craig001_lerwick.hopto.org updated the diff for D11550: net/glusterfs port update to latest 3.11.1 release.

osversion conditional moved up a touch

Jul 12 2017, 11:18 AM · Ports Committers
craig001_lerwick.hopto.org updated the diff for D11550: net/glusterfs port update to latest 3.11.1 release.

changes made as suggested by Mat with thanks....

Jul 12 2017, 11:09 AM · Ports Committers

Jul 11 2017

mat added inline comments to D11550: net/glusterfs port update to latest 3.11.1 release.
Jul 11 2017, 10:07 PM · Ports Committers
craig001_lerwick.hopto.org updated the diff for D11550: net/glusterfs port update to latest 3.11.1 release.

conditional added to fix build issue on 11.0-RELEASE (clang fails)

Jul 11 2017, 1:07 PM · Ports Committers