Thanks for the review!

In D53910#1291145, @mark_freebsdfoundation.org wrote:

In D53910#1290446, @carlavilla wrote:

In D53910#1290445, @cperciva wrote:

@carlavilla Can you try to get your changes merged so this can get committed soon? The 15.1 release cycle is about to get underway and I'm worried about this landing at a time when I'm doing a bunch of commits, especially since I stage them ahead of time and then push out when announcements are ready to go -- I don't want to have rebase problems show up at the wrong moment.

In my repo, I have the "main" page finished.
I'll try to have the rest today and send an email to core@ and doceng@

It would be fantastic to drop this (well, your repo on GH) sooner rather than later to help @cperciva out too. I am fine with 'good enough' that can be iterated on _once live_. "Perfect is the enemy of good", and when it comes to a website versus code, that mantra is ok to live with (it's not OK to live with in OS code, but let's not conflate the two things 😄 ). @vladlen has good ideas about improving i18n too, although I think the GH repo has a lot of that implemented now, which is great.

What I'd love to do is get the site live with the new version @carlavilla, get more people [from the community] interested in working on it (because it's modern!) and keep improving on things, versus letting it get stale.

I have a sub for Screaming Frog, so we can check freebsd.fortasse.org for stale/dead links and other 'code smells'. We should run it through the w3 validator, although tbf, both of these checks can happen after go live.

@fernape what are your thoughts on getting the newer (>= 0.156) hugo on CI servers, and checking the live server too?

In D53910#1290735, @carlavilla wrote:

In D53910#1290734, @mark_freebsdfoundation.org wrote:

In D53910#1290526, @bz wrote:

I just looked at the staging site. My initial comment was: that's the next level of losing links to what is available on www.freebsd.org in information and this time we are avoiding the fact that monitors are WIDE and not 4:3 anymore for 1.5 decades. 70% of the landing page is white space and if you look at the generated page we are serving blank lines of HTML and little content in vertical scrolling. Please bring SGML back. *cry*

You need to update https://freebsd.fortasse.cloud/internal/about/ to which I have no idea to get to anymore if I wouldn't know /internal/ existed. Probably a fault of the previous (current) version already.

The sidebar on /security/ is unreadable with some items spanning 2-3 lines.

The footer uses more vertical space than content on some of the menu-accessible pages.

The 5 columns under the marketing which have information have become tiny unreadable here.

Firefox on a FreeBSD Laptop.

@carlavilla latest version is now up on https://freebsd.fortasse.cloud — please take a look at that @bz 👍 You may have to hard refresh the page to get all the components. It should look like the screen shot posted yesterday, i.e. with the yellow download buttons.

Regarding whitespace and screen widths. There has been lots of research into this, and long story short, it's all led by the way we humans read. For a more skilled and lengthy overview, this is worth a watch… https://youtu.be/Jf0cjocP8Wk

Lastly, @carlavilla there is the Hugo deprecation notice in your latest work. I fixed it in this Phab the other day, I'll do it against your repo and issue a PR later today 👍 The notice looks like this on build:

WARN  deprecated: .Site.Data was deprecated in Hugo v0.156.0 and will be removed in a future release. Use hugo.Data instead.
WARN  deprecated: .Site.Sites and .Page.Sites was deprecated in Hugo v0.156.0 and will be removed in a future release. Use hugo.Sites instead.

I'm really happy to see this moving again! Let's get it deployed soon, so the world stops thinking we're a dying project. We're anything but 👏

Yes, about the warning I know, fernape@ fixed it but for some reason he reverted the change.

I just took a look and for some reason, some strings are not translated, don't know why, and the same for some icons.
Also, can you deploy the minified version?

In D53910#1290735, @carlavilla wrote:

In D53910#1290734, @mark_freebsdfoundation.org wrote:

In D53910#1290526, @bz wrote:

I just looked at the staging site. My initial comment was: that's the next level of losing links to what is available on www.freebsd.org in information and this time we are avoiding the fact that monitors are WIDE and not 4:3 anymore for 1.5 decades. 70% of the landing page is white space and if you look at the generated page we are serving blank lines of HTML and little content in vertical scrolling. Please bring SGML back. *cry*

You need to update https://freebsd.fortasse.cloud/internal/about/ to which I have no idea to get to anymore if I wouldn't know /internal/ existed. Probably a fault of the previous (current) version already.

The sidebar on /security/ is unreadable with some items spanning 2-3 lines.

The footer uses more vertical space than content on some of the menu-accessible pages.

The 5 columns under the marketing which have information have become tiny unreadable here.

Firefox on a FreeBSD Laptop.

@carlavilla latest version is now up on https://freebsd.fortasse.cloud — please take a look at that @bz 👍 You may have to hard refresh the page to get all the components. It should look like the screen shot posted yesterday, i.e. with the yellow download buttons.

Regarding whitespace and screen widths. There has been lots of research into this, and long story short, it's all led by the way we humans read. For a more skilled and lengthy overview, this is worth a watch… https://youtu.be/Jf0cjocP8Wk

Lastly, @carlavilla there is the Hugo deprecation notice in your latest work. I fixed it in this Phab the other day, I'll do it against your repo and issue a PR later today 👍 The notice looks like this on build:

WARN  deprecated: .Site.Data was deprecated in Hugo v0.156.0 and will be removed in a future release. Use hugo.Data instead.
WARN  deprecated: .Site.Sites and .Page.Sites was deprecated in Hugo v0.156.0 and will be removed in a future release. Use hugo.Sites instead.

I'm really happy to see this moving again! Let's get it deployed soon, so the world stops thinking we're a dying project. We're anything but 👏

Yes, about the warning I know, fernape@ fixed it but for some reason he reverted the change.

LGTM, provided the comment is addressed :-)