whereis(1): Simplify code
ClosedPublic
Actions

Authored by fernape on Sat, Sep 19, 5:30 PM.

Details

Reviewers

ngie

Group Reviewers

Src Committers

Commits

rG3963483523a4: whereis(1): Simplify code

Summary

Simplify the way we build paths.
Avoid decolonification of source paths. It is prone to leave memory leaks depending on its result, overwriting the b variable all the time.

Fix a memory leak while here in the call to setenv.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fernape created this revision.Sat, Sep 19, 5:30 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Sep 19, 5:30 PM

fernape requested review of this revision.Sat, Sep 19, 5:30 PM

Harbormaster completed remote builds in B77095: Diff 187241.Sat, Sep 19, 5:30 PM

fernape edited the summary of this revision. (Show Details)Sat, Sep 19, 5:32 PM

fernape added reviewers: Src Committers, ngie.

Looks great so far :)!

usr.bin/whereis/pathnames.h
35	Please track `/cddl` in the source tree (it's been present for a while).
35–51	Could `/usr/src` please be swapped out and these be changed to "subdirectories" instead of hardcoding /usr/src for each entry?
38–42	These directories have been gone for a while.

Remove gnu directories and add non-tracked ones

Harbormaster completed remote builds in B77335: Diff 187696.Fri, Sep 25, 6:00 PM

fernape added inline comments.Fri, Sep 25, 6:00 PM

usr.bin/whereis/pathnames.h
35–51	It can, but is it useful? let's say we store /usr/src in src_base. Then we need to concatenate (asprintf) src_base with sourcepaths[i] to create sourcedirs. I don't know if the tradeoff is beneficial. Or do you have a different idea?

ngie accepted this revision.Sat, Sep 26, 12:01 PM

ngie added inline comments.

usr.bin/whereis/pathnames.h
35–51	It can, but is it useful? let's say we store /usr/src in src_base. Then we need to concatenate (asprintf) src_base with sourcepaths[i] to create sourcedirs. I don't know if the tradeoff is beneficial. Or do you have a different idea? It's useful just so whereis generates useful source tree information. It doesn't have to be done now since it's an existing issue though.