virtual_oss(8): Fix error message
Needs ReviewPublic
Actions

Authored by fernape on Sat, Sep 19, 5:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 8, 10:02 PM

	Unknown Object (File)
	Thu, Oct 8, 6:15 PM

	Unknown Object (File)
	Wed, Oct 7, 2:11 PM

	Unknown Object (File)
	Tue, Oct 6, 5:45 AM

	Unknown Object (File)
	Mon, Oct 5, 8:32 PM

	Unknown Object (File)
	Mon, Oct 5, 9:28 AM

	Unknown Object (File)
	Sun, Oct 4, 7:56 PM

	Unknown Object (File)
	Sun, Oct 4, 11:24 AM

View All 28 Files

Subscribers

imp

Details

Reviewers

chris_cretaforce.gr

Group Reviewers

audio

Summary

When there is no 'audio' group, the error is:

virtual_oss: getgrnam: No error: 0

which gives absolutely no indication to the user about the underlying issue.

Instead, check for errno after calling getgrnam(3)

./virtual_oss
virtual_oss: Can't find 'audio' group.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77094
Build 73977: arc lint + arc unit

Event Timeline

fernape created this revision.Sat, Sep 19, 5:08 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Sep 19, 5:08 PM

fernape requested review of this revision.Sat, Sep 19, 5:08 PM

Harbormaster completed remote builds in B77094: Diff 187240.Sat, Sep 19, 5:08 PM

fernape edited the summary of this revision. (Show Details)Sat, Sep 19, 5:09 PM

fernape added reviewers: audio, chris_cretaforce.gr.

Revision Contents
Changeset List

Path

Size

usr.sbin/

virtual_oss/

main.c

9 lines

Diff 187240

View Options

usr.sbin/virtual_oss/virtual_oss/main.c

virtual_oss(8): Fix error messageNeeds ReviewPublicActions