In D60719#1392557, @yuri wrote:

Hi Christos,

Several problems:

1. When you add a patch you should always add a comment in the first lines of the patch explaining why is it needed. This is especially important for a patch like this one when it isn't obvious why does it solve a problem stated in the subject.
2. Bump in the Makefile is needed because this is a code change that might affect binaries on all architectures, at least from the first look.
3. Such change should be upstreamed if possible. Please mention in the patch comment whether you upstreamed it. In case of a GitHub hosted project like this one a pull request URL would be appropriate. I use the GitHub's gh CLI to create such PRs completely from the command line. gh makes it very easy.

Committed as 02a17bd8c61b

Add an empty line between entries

Add wasmtime to the affected packages

Any news regarding this review ? :)

In D60502#1388517, @jrm wrote:

This looks good. Could you also verify that you built the documentation/website? A successful build helps confirm that there isn't a little nit we missed.

Close this as https://reviews.freebsd.org/D59393 landed on main.

Update manual page according to the review by ziaee

I think this revision is not anymore relevant as the video(4) driver bumped the version to 1600020.

Rebase on current main, rename to ps5dsense, describe the full 63 byte input report, and add the manpage, sys/conf and module Makefile entries. Tested on hardware.

In D58593#1344656, @kib wrote:

What are the hypothetical KBI incompatibilities caused by the FRED commit?

Superseded by https://cgit.freebsd.org/ports/commit/?id=3aa9009bc3c5 (databases/R-cran-nanoparquet: update 0.4.3 -> 0.5.1). Abandoning this review.

Landed in https://cgit.freebsd.org/ports/commit/?id=f545ab2ee16f (devel/R-cran-roxygen2: Update to 7.3.3). Abandoning this review.

Refiled in Bugzilla at the current 1.5.4.3, keeping the --no-xattrs tar fix: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296809 — poudriere-tested on 15.1-RELEASE.

Refiled in Bugzilla at the current 1.7.0: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296806 — poudriere-tested on 15.1-RELEASE.

Continued in Bugzilla with the port refreshed to the current 0.5.1: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296805 — poudriere-tested on 15.1-RELEASE.

@mm

So will this commit land to main ? :)

Any updates regarding this patch ?
Thanks

Any updates regarding this patch ? :) @emaste @kib

In D56233#1286789, @glebius wrote:

Thanks for the change!

I'm leaving for a short offline vacation and I prefer not to push changes before that. If you find an src committer who can push - welcome. Otherwise I will be back in about a week.

In D56249#1287584, @imp wrote:

In D56249#1287432, @chris.longros_gmail.com wrote:

Drop the watchdog timer change.

Thanks! I was going to suggest this was a configuration error in the pre-execution timeout configured in the firmware and the right place to fix that is in the config of systems that need more time.

Document the resulting filename length limit in cron(8) under FILES.

In D56500#1296504, @wulf wrote:

I committed mmap()-based changes. See: https://cgit.freebsd.org/src/commit/?id=87ed6840a0a6320295f6abb43a987d20ae126cf7

In D56102#1291882, @adrian wrote:

can you add some validation of the parameter before programming it into the register? surely it's not a single 32 bit field?

In D56439#1292291, @eduardo wrote:

Thanks for you contrubution.

I still not understand why me and @yuri are called to reviewers. Best way is to open a bugzilla PR so all people see it and take a look.

Cheers

In D56439#1292291, @eduardo wrote:

Thanks for you contrubution.

I still not understand why me and @yuri are called to reviewers. Best way is to open a bugzilla PR so all people see it and take a look.

Cheers

Use canonical CRAN URL form.

@adrian any feedback on this commit? thank's in advance :)

@adrian could you please review the commit when you have time? Thanks :)

@melifaro Could I get your feedback on this commit ? Thanks!

@adrian Hi, any feedback or concerns about this commit ? :)

@emaste the commit has been approved. Can it be submitted ? :) Thanks!

@dteske Hi, this is accepted — could it be committed? Thanks!

@kib Hi, could you commit this when you time? Thanks!

@glebius Hi, could you land this at your convenience? Thanks!

@jlduran Hi, this has been accepted — could you commit it? Thanks!

@imp Hi, could this be landed when you get a chance? Thanks!

In D56345#1289609, @wulf wrote:

Looks mostly good.
There are some missing parts. TODO:

1. Add manpage. You may take share/man/man4/ps4dshock.4 as starting point. Do not forget to add missing touchpad and accelerometer support to BUGS section.
2. Add ps5dualsense.c to sys/conf/files and sys/conf/NOTES
3. Add ps5dualsense subdir to sys/modules/hid/Makefile