@brnrd what about you?

Add tests.

In D46088#1050559, @kp wrote:

I'm not opposed to this, but I believe it's incomplete. This will only accept ';' as a comment in table files. It won't work for lines in the main pf.conf.

In D45278#1033061, @bcr wrote:

net/cloud-init would be useful for cloud-y environments.

In D45278#1032837, @asomers wrote:

FYI, at $WORK the only packages we include in the DVD image are:

• ports-mgmt/pkg
• sysutils/py-salt , because Salt can install everything else
• net-mgmt/lldpd, which helps us debug network problems that would prevent Salt from working.

For desktop use, I really don't think that the packages on the DVD are very important. We can't possibly put every package on the DVD, or even the most popular packages. So what's the point of having any? Just to reduce users' download times?

Can this be either approved od rejected, please? It is now lingering.

rebase

Address comments from 0mp

In D44944#1024717, @adrian wrote:

lgtm, whats this addressing? Whats the system behaviour when the count limit is hit?

And while here, also mandoc -Tlint a bit.

I'd also suggest to bump PORTREVISION to also reflect the future binary packages (this might not be necessary if you plan to do a quick update).

Adding cy@ as he might also want have a look (as it's src component).

LGTM

LGTM.

Although this change looks good to me, we also should consider making -d default to $(-b)/var/db/freebsd-update. *THAT* left me with broken boot environment :-/ (I've used -b /path/to/be without -d /path/to/be/var/db/freebsd-update).