Page MenuHomeFreeBSD

mail/{postfix,postfix-current}: Fix version gathering for devel/mongo-c-driver
AbandonedPublic

Authored by nxjoseph on Aug 4 2026, 2:01 PM.
Tags
None
Referenced Files
F171809200: D58642.id183383.diff
Sun, Sep 13, 5:11 PM
Unknown Object (File)
Sun, Sep 6, 4:53 AM
Unknown Object (File)
Sun, Sep 6, 3:48 AM
Unknown Object (File)
Fri, Sep 4, 3:21 PM
Unknown Object (File)
Fri, Sep 4, 3:59 AM
Unknown Object (File)
Thu, Sep 3, 2:19 PM
Unknown Object (File)
Thu, Sep 3, 5:27 AM
Unknown Object (File)
Wed, Sep 2, 10:41 AM
Subscribers

Details

Reviewers
otis
osa
vvd
Summary

Hi,

I have got a report and figured that current version gathering method for devel/mongo-c-driver may not work for some use cases, such as Raivo's.

In this patch, instead of:

MONGOC_VERSION!=               cd ${.CURDIR}/../../devel/mongo-c-driver; make -V DISTVERSION

we do:

.include <bsd.port.pre.mk> (if not existent, add it since PORTSDIR variable doesn't work without it being present.)

MONGOC_VERSION!=       ${MAKE} -C ${PORTSDIR}/devel/mongo-c-driver -V DISTVERSION

Thanks in advance.

Reported by: Raivo Hool <raivo@lehma.com> (via PR #296605)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296605#c3

They also stated that ${.CURDIR:H:H} wouldn't work either, so ${PORTSDIR} seems to be the way.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

nxjoseph created this revision.
nxjoseph retitled this revision from */*: Fix version gathering for devel/mongo-c-driver to mail/{postfix,postfix-current}: Fix version gathering for devel/mongo-c-driver.Aug 6 2026, 11:15 AM
nxjoseph edited the summary of this revision. (Show Details)
nxjoseph removed a reviewer: joneum.
nxjoseph removed a subscriber: joneum.

Removed diffs for the nginx ports.

mail/postfix-current/Makefile
141

As stated in private e-mail:

$(MAKE) -C ${.CURDIR:H:H}/devel/mongo-c-driver -V DISTVERSION

seems most correct. Depending on PORTSDIR is not good as the ports can live outside /usr/ports

mail/postfix-current/Makefile
141

Hi.

That's the comment from the Ravio, the person who raised this problem.

Not going to play around with CURDIR, it's the same issue just clothed different.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296605#c5

I also wrote it in the review.

They also stated that ${.CURDIR:H:H} wouldn't work either, so ${PORTSDIR} seems to be the way.

I hear that PORTSDIR may not be good too, so I guess it's better to find a way that Ravio's work type with the overlays would not broke which I do not have a idea yet.

mail/postfix-current/Makefile
141

www/chromium has similar approach with devel/esbuild using ${PORTSDIR}.

www/chromium/Makefile:               evanw:esbuild:v${_ESBUILD_VERSION:sh}:esbuild/esbuild
www/chromium/Makefile:               _ESBUILD_VERSION=      ${MAKE} -C ${PORTSDIR}/devel/esbuild -V DISTVERSION
otis requested changes to this revision.Aug 14 2026, 5:12 PM

This issue has been fixed properly (for mail/postfix) in commit c01b34960fd5fbdc25249139e49f3c5a3baae1ef

This revision now requires changes to proceed.Aug 14 2026, 5:12 PM