User Details
- User Since
- Nov 25 2017, 1:08 AM (170 w, 9 h)
Wed, Feb 24
Tue, Feb 23
Fri, Feb 19
Thu, Feb 18
Wed, Feb 17
Tue, Feb 16
Mon, Feb 15
Looks good to me, however we'd need to get a confirmation from the maintainer he is OK with the change.
Fri, Feb 12
Thu, Feb 11
Fri, Feb 5
Thu, Feb 4
Tue, Feb 2
Sun, Jan 31
I've just tried to build the port with the following patch for the original Makefile and everything works fine.
Sat, Jan 30
Juraj, is there any specific reason to use the MASTER_SITES in this case when software distributed from GitHub?
Thu, Jan 28
Looks good to me for lang/luajit/Makefile.
Jan 26 2021
Jan 23 2021
I'm going to accept this revision and I'd recommend to update the commit message, please see my comment, thanks!
The patch looks good, please slightly update the commit message starting with the following string:
"Security update mail/mutt to 2.0.5."
Jan 22 2021
Jan 14 2021
Jan 13 2021
@ale Please let us in case you want to continue to maintain the port. Otherwise we need to find another maintainer or reset maintainer to ports@.
The MOVED file needs to be updated.
Jan 12 2021
Jan 11 2021
Looks good to me.
Jan 6 2021
Jan 3 2021
Well, let's do not bump PORTREVISION, there is no special notice about that in our Porters Handbook, so, approved.
The records to MOVED should be added once those ports move out from the ports tree.
Jan 1 2021
Dec 31 2020
Not fully aware, but probably PORTREVISION bump is required to rebuild packages with an expiration notice.
Dec 30 2020
Looks good to me.
Dec 29 2020
Looks good to me, please do not forget to update the commit message, thanks.
Dec 28 2020
That looks pretty reasonable, would be great to add something like "Make portclippy(1) happy or more happy." - just to better understand why those variables have been prefixed.
Looks good to me, however it's unclear why some variables need to be prefixed with an underscore symbol. Hope it's possible to mention that in a commit log message.
Looks good to me.
Dec 27 2020
Dec 26 2020
The patch looks good and I'd recommend to use ${INSTALL_DATA} instead of ${CP} command in the pre-install target.
Dec 22 2020
Looks good to me.
Dec 21 2020
@swills could you please provide an update, thanks!
Dec 20 2020
My thoughts are it's better to add a record about that CVE to our vuln.xml, so that record provides correct information what is vulnerable and what is not to avoid any questions in the future.
Dec 19 2020
Because of a security update of the port, an update of security/vuxml is required.
Found the PR in Bugzilla, looks good to me.
looks good to me, questions here - is it the MAINTAINER update? And if so, is there any PR has been raised for this update? And if not so, have those changes been approved by the MAINTAINER?
I'd recommend to bump PORTREVISION in this case.
Dec 18 2020
Dec 17 2020
Looks good to me.
Hi Juraj,