I understood you correctly?

We have not found confirmation of the need for new patches.

Can I commit this patch and begin to work on more important patch for fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270189 ?

Replaced patch with: EXTRA_PATCHES+= ${.CURDIR}/../phpvirtualbox/files/patch-php8

In D40115#914945, @arrowd wrote:

Are you sure this patch doesn't break anything for PHP < 8?

In D40163#914934, @rene wrote:

In D40163#914757, @vvd wrote:

In D40163#914756, @fuz wrote:

See this page for which FreeBSD releases are currently in support: https://www.freebsd.org/security/#sup
Everything older than that needs not be considered.

There are no 14.

That is what the "main" branch is, which will soon become stable/14 and 14.0

But indeed you will see all kinds of versions for 14000xx (and soon 15000xx) for "main"/ CURRENT.

I know version numbers in FreeBSD and about delayed release 14 too.
So before 14 released all > 1400000 "regarded" as supported.

In D40116#914015, @arrowd wrote:

Can we just reuse the patch from www/phpvirtualbox via EXTRA_PATCHES?

Probably yes - diff is line numbers for 1 patch:

$ diff -ur www/phpvirtualbox/files/patch-php8 www/phpvirtualbox-legacy/files/patch-php8 
--- www/phpvirtualbox/files/patch-php8  2023-05-16 15:26:53.429336000 +0300
+++ www/phpvirtualbox-legacy/files/patch-php8   2022-06-20 20:08:48.125357000 +0300
@@ -160,7 +160,7 @@
 diff -ur panes/settingsDisplay.html.orig panes/settingsDisplay.html
 --- panes/settingsDisplay.html.orig
 +++ panes/settingsDisplay.html
-@@ -77,9 +77,9 @@
+@@ -68,9 +68,9 @@
                <th><span class='translate'>Authentication Method:</span></th>
                <td>
               <select name='vboxSettingsDisplayVRDEAuth' id='vboxSettingsDisplayVRDEAuthID' style='width: 100%'>

Build tested in poudriere on 12.4, 13.1 and 13.2 amd64.

In D40163#914756, @fuz wrote:

See this page for which FreeBSD releases are currently in support: https://www.freebsd.org/security/#sup
Everything older than that needs not be considered.

In D40163#914751, @arrowd wrote:

What's the point in fixing unsupported versions of 13 and 14?

Renamed MANUAL to DOCS after discussion with Zirias in IRC.

Removed double REINPLACE_CMD for src/VBox/HostDrivers/adpctl/VBoxNetAdpCtl.cpp - 1st is in patch.

After discussion in IRC did several improvements.

Replaced all "/usr/local" with %%LOCALBASE%% and "/usr/local/lib/virtualbox" with %%VBOX_DIR%%.

PATH changed to: /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin

Added #cmakedefine PIPEWIRE_FOUND 1 to pass on option PIPEWIRE_FOUND from cmake to sources.

In D40088#913176, @arrowd wrote:

It builds for me on 14-CURRENT, but doesn't work: I'm getting INTERNAL_ERROR 3 on a VM start. Does it work for you on 13?

Yes, it was made like in krfb.

I think it was copy&paste from console issue - tabs replaced with spaces and etc.
"git diff > spectacle.diff" and uploaded file spectacle.diff now.

I think it was copy&paste from console issue - tabs replaced with spaces and etc.
"git diff > krfb.diff" and uploaded file krfb.diff now.

https://cgit.freebsd.org/doc/commit/?id=ecc5e5585bc1b277d789869f1eac773af8751523

Can I commit this?