Upstream committed our patches to 3.5.1 branch - replaced audio/audacity/files/patch-* with patch from this commit.

Removed unused LIB_DEPENDS:

Warning: you might not need LIB_DEPENDS on libasound.so
Warning: you might not need LIB_DEPENDS on libcurl.so
Warning: you might not need LIB_DEPENDS on libopenjp2.so
Warning: you might not need LIB_DEPENDS on libpng.so
Warning: you might not need LIB_DEPENDS on libturbojpeg.so

And pet portclippy.

In D44661#1018693, @Alexander88207_protonmail.com wrote:

https://man.freebsd.org/cgi/man.cgi?query=rtld&sektion=1&apropos=0&manpath=FreeBSD+14.0-RELEASE+and+Ports

  LD_LIBMAP	  A library replacement	list in	 the  same  format  as
			  libmap.conf(5).  For convenience, the	characters `='
			  and  `,'  can	 be used instead of a space and	a new-
			  line.	 This variable is parsed after libmap.conf(5),
			  and will override its	entries.  This variable	is un-
			  set for set-user-ID and set-group-ID programs.

Thanks. It work for me with LD_LIBMAP env too!

Did you test run game using this launcher?
What versions did you tested?

2. Yes. Maybe ask user if he have troubles with run. But this can affect other java graphic applications.
3. Same for 1 - if user have troubles he can try set env variables.

I never used any launchers for Minecraft.
I'm using shell script for run it: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278014#c2
I don't know how I can help here. :-(

Maybe add record to UPDATING?

I read all patch and it look good for me: PORTREVISION++, *_DEPENDS=${DBD_MYSQL}, *USES+=mysql.
If you want me to test the build in poudriere, I need more time.

ping @nc.

ping nc@

But just for now to fix breakage commit patch from this review (or even revert).
Then prepare better solution maybe even with exp-run.

What do you think about USES=p5-DBD-mysql with options 4, 5 and MariaDB?

In this review:
mail/opendmarc
multimedia/zoneminder

IMHO,

1. We need same patches for all other consumers of the p5-DBD-mysql.
2. And record in UPDATING too.

Need help with both.

In D44490#1014853, @eduardo wrote:

Myabe flavour can help.

flavors will have same problem as separated ports since they cannot be installed both in same system.

Create USES=glfw with option devel: USES=glfw:devel.
If user want to use glfw:devel then he must set DEFAULT_VERSIONS+=glfw=devel.
In default configuration lwjgl3 is broken - it's bad.
I forgot that a lot of users use pkg instead of build from ports.
Same issue if add option with EXTRAPATCHES to the port.

In D44490#1014839, @eduardo wrote:

Hello,

My first impression is that adding 14 upstream patches to a port based on a release is not good.
We usually use patches to fix something and in this case we are promoting glfw -> glfw-devel.

My sugestion is to create a glfw-devel so we can use devel features in ports that needs it.

The full list of arches is here: https://www.freebsd.org/platforms/

ping again

ping

Better handle with libffi.

Replaced static link with libffi with dynamic!