Page MenuHomeFreeBSD

meka_tilda.center (Goran Mekić)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2019, 8:59 AM (213 w, 5 d)

Recent Activity

Thu, Aug 31

meka_tilda.center updated the diff for D41627: Lower minimal USB audio buffer size limit from 2ms to 1ms.
Thu, Aug 31, 2:46 PM · multimedia
meka_tilda.center added a comment to D41627: Lower minimal USB audio buffer size limit from 2ms to 1ms.
In D41627#949637, @mav wrote:

I am sorry, but once again: in this patch you change allowed minimum, but do not change the default on line 99, right?

I guess heat got to my head :) Thank you, good catch! Update is coming.

Thu, Aug 31, 2:29 PM · multimedia
meka_tilda.center added a comment to D41627: Lower minimal USB audio buffer size limit from 2ms to 1ms.
In D41627#949189, @mav wrote:

After your initial commit Hans reduced the default value from 8ms to the minimum of 2ms. I wonder if it is still OK or you'd like to reduce default also.

As a disclaimer, I know very little to nothing about USB.

Thu, Aug 31, 8:14 AM · multimedia

Tue, Aug 29

meka_tilda.center retitled D36795: Example of audio/MIDI with select(2), poll(2) and kqueue(2) from Example of audio/MIDI with select(2) and poll(2) to Example of audio/MIDI with select(2), poll(2) and kqueue(2).
Tue, Aug 29, 2:28 PM
meka_tilda.center retitled D41627: Lower minimal USB audio buffer size limit from 2ms to 1ms from Lower USB audio buffer size from 2ms to 1ms to Lower minimal USB audio buffer size limit from 2ms to 1ms.
Tue, Aug 29, 8:42 AM · multimedia
meka_tilda.center requested review of D41627: Lower minimal USB audio buffer size limit from 2ms to 1ms.
Tue, Aug 29, 8:42 AM · multimedia

Jul 6 2023

meka_tilda.center added a comment to D20967: new MAC policy module - mac_ipacl.

If you're going to change format, why not use tree, as it feels natural for sysctl. One existing example would be dev.pcm.<number> so following that, we could have security.mac.ipacl.<jid>.<rule> and .family and .address (or maybe .range) as leafs. It is not set in stone that it has to be like that, but given it's sysctl, it feels more natural to me, so please give it a thought. Also, as it is about jail, it would also feel more natural to have this tunables under security.jail.<jid>

Jul 6 2023, 5:06 PM · GSoC Students, GSoC Admins

Jul 4 2023

meka_tilda.center added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

This patch fails to apply to CURRENT. I am using dhcpcd-10 since it was released (and used previous versions) for DHCP, SLAAC and DHCPv6, all on the same network. That's the closest to testing I can get in current state. If this patch is updated I would love to test it. Of course, if updating patch is required, I would love to do it, but at this point I'm not sure I know how.

Jul 4 2023, 9:13 AM

Jul 3 2023

meka_tilda.center added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

Is there something we can do to make dhcpcd part of 14.0-RELEASE besides testing this patch?

Jul 3 2023, 2:07 PM

Jun 19 2023

meka_tilda.center abandoned D39011: Enable jail(8) to parse all config files.
Jun 19 2023, 8:10 AM

Jun 17 2023

meka_tilda.center updated the diff for D36795: Example of audio/MIDI with select(2), poll(2) and kqueue(2).

Added kqueue/kevent example and made the choice of select/poll/kqueue selectable on runtime.

Jun 17 2023, 8:14 AM

Jun 7 2023

meka_tilda.center added a comment to D36795: Example of audio/MIDI with select(2), poll(2) and kqueue(2).

The poll(2) part is added

Jun 7 2023, 11:32 PM
meka_tilda.center updated the diff for D36795: Example of audio/MIDI with select(2), poll(2) and kqueue(2).
Jun 7 2023, 10:14 PM

May 21 2023

meka_tilda.center added a comment to D40188: Add ".include" directive to jail.conf.

I you use git format-patch -1 -U9999 and apply it with git am <patch>, you get the whole commit with the message. Not strictly needed, but makes life easier.

May 21 2023, 7:49 AM · Jails

May 12 2023

meka_tilda.center updated the diff for D39011: Enable jail(8) to parse all config files.

Add FILES section to jail(8) and add -F option to usage() function.

May 12 2023, 8:22 AM

May 10 2023

meka_tilda.center updated the diff for D39011: Enable jail(8) to parse all config files.
May 10 2023, 10:59 PM

May 5 2023

meka_tilda.center added a reviewer for D39011: Enable jail(8) to parse all config files: jamie.
May 5 2023, 12:22 PM
meka_tilda.center updated the diff for D39011: Enable jail(8) to parse all config files.
May 5 2023, 12:13 PM
meka_tilda.center added inline comments to D39011: Enable jail(8) to parse all config files.
May 5 2023, 11:55 AM
meka_tilda.center updated the diff for D39011: Enable jail(8) to parse all config files.
May 5 2023, 11:53 AM

Mar 21 2023

meka_tilda.center updated the diff for D39011: Enable jail(8) to parse all config files.

Save original value of cfname and restore it after handling glob config.

Mar 21 2023, 4:45 PM
meka_tilda.center updated the diff for D39011: Enable jail(8) to parse all config files.

Thank you for detailed review. I omitted the change for the style, as almost all of them were already present before my change, like not having {} on if. I personally don't have preferences for style so I'll do whatever maintainer thinks is right. I would like to keep style changes out of this patch, if possible.

Mar 21 2023, 4:02 PM

Mar 20 2023

meka_tilda.center updated the diff for D39011: Enable jail(8) to parse all config files.
Mar 20 2023, 7:01 AM

Mar 15 2023

meka_tilda.center added inline comments to D39011: Enable jail(8) to parse all config files.
Mar 15 2023, 8:35 PM

Mar 10 2023

meka_tilda.center updated the diff for D39011: Enable jail(8) to parse all config files.

Sort the includes.

Mar 10 2023, 6:14 PM
meka_tilda.center requested review of D39011: Enable jail(8) to parse all config files.
Mar 10 2023, 11:36 AM

Mar 1 2023

meka_tilda.center added a comment to D38826: Fix multiple rc.d/jail and jail.conf.d issues.

I like the overall idea, thank you for adding more conf.ds to FreeBSD!

Something I do not understand: My "dormant", cron-initiated jails will always start upon boot (i.e., /etc/jail.anotherjail.conf, while anotherjail not in jail_list)?

Regarding the code itself, wouldn't it be better to create a function, something like:

all_jail_confs()
{
	local jail_conf_locations

	jail_conf_locations="$jail_conf $jail_conf_dir/*.conf /etc/jail.*.conf"
	if [ -f "$1" ]; then
		jail_conf_locations="$1 $jail_conf_locations"
	fi

	cat $jail_conf_locations 2>/dev/null
}

And use it instead of repeating the same code in 5 places?

Mar 1 2023, 11:41 AM · Jails

Nov 21 2022

meka_tilda.center requested review of D37451: Add dnctl rc.d service.
Nov 21 2022, 12:32 PM
meka_tilda.center updated the diff for D37431: Fix ipfw/dnctl detection.
Nov 21 2022, 12:29 PM
meka_tilda.center updated the diff for D37431: Fix ipfw/dnctl detection.
Nov 21 2022, 12:25 PM
meka_tilda.center retitled D37431: Fix ipfw/dnctl detection from Fix ipfw/dnctl detection and add dnctl rc.d service to Fix ipfw/dnctl detection.
Nov 21 2022, 12:25 PM

Nov 20 2022

meka_tilda.center added a comment to D36795: Example of audio/MIDI with select(2), poll(2) and kqueue(2).

I think that would not be the simplest example, and I was aiming at simplicity. My idea with audio, MIDI and combined example was to make it as simple as possible. Next examples are going to be harder topics: handling 24bit audio in different endianess, ability to choose between select, poll and kqueue and combining it all into one big example at the end. That being said, can we keep this example as is?

Nov 20 2022, 12:12 AM

Nov 19 2022

meka_tilda.center updated the summary of D37431: Fix ipfw/dnctl detection.
Nov 19 2022, 4:56 PM
meka_tilda.center updated subscribers of D37431: Fix ipfw/dnctl detection.
Nov 19 2022, 4:55 PM

Nov 18 2022

meka_tilda.center requested review of D37431: Fix ipfw/dnctl detection.
Nov 18 2022, 5:00 AM

Sep 29 2022

meka_tilda.center requested review of D36795: Example of audio/MIDI with select(2), poll(2) and kqueue(2).
Sep 29 2022, 2:14 PM

Aug 17 2022

meka_tilda.center added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

I did a little research and it turns out that SIOCSPFXFLUSH_IN6 is only supported on FreeBSD and derivatives like DragonflyBSD so the check if it's defined is practically check if it's running on FreeBSD. As NetBSD removed it and OpenBSD doesn't have it, what will happen if we remove the SIOCSPFXFLUSH_IN6 call from dhcpcd?

Aug 17 2022, 2:05 PM
meka_tilda.center added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

As nd6.c states /* flush all the prefix advertised by routers */ and route that dhcpcd removes is definetely not advertized by any router but set as part of ifconfig re0 inet6 ...., maybe the bug is on FreeBSD side?

Aug 17 2022, 9:23 AM

Aug 16 2022

meka_tilda.center added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

Please note there's a bug in dhcpcd and/or FreeBSD: https://github.com/NetworkConfiguration/dhcpcd/pull/121. Could somebody more experienced with networking take a look, please? In short, without the mentioned PR, dhcpcd removes IPv6 routes from bridge0 interface while re0 is being configured. Thank you!

Aug 16 2022, 9:16 PM
meka_tilda.center updated the diff for D36195: The simplest OSS MIDI example.
Aug 16 2022, 6:40 PM
meka_tilda.center added a comment to D36195: The simplest OSS MIDI example.

I think it's just a matter of you saying how you want to be referred to in the author field of the git commit :) But I think it requires a "name <email>" format.

I though "git format-patch" will do the right thing here. But anway "Goran Mekić <meka@tilda.center>" is prefered.

Aug 16 2022, 6:39 PM
meka_tilda.center added a comment to D36195: The simplest OSS MIDI example.

As for formatting, this is the output that indent(1) produced. Can you tell me what would make it better?

Aug 16 2022, 5:13 PM
meka_tilda.center added a comment to D36195: The simplest OSS MIDI example.

To be honest I don't know how the process works. Can you advise, please?

Aug 16 2022, 5:13 PM
meka_tilda.center updated the diff for D36195: The simplest OSS MIDI example.
Aug 16 2022, 10:21 AM

Aug 14 2022

meka_tilda.center updated the diff for D36195: The simplest OSS MIDI example.
Aug 14 2022, 9:57 PM
meka_tilda.center updated the diff for D36195: The simplest OSS MIDI example.
Aug 14 2022, 7:51 PM
meka_tilda.center requested review of D36195: The simplest OSS MIDI example.
Aug 14 2022, 1:12 AM
meka_tilda.center abandoned D21336: Make dummynet kernel module independent from IPFW.
Aug 14 2022, 1:05 AM

Jun 26 2021

meka_tilda.center added a comment to D30149: Example of basic OSS audio application.

Is there anything I can improve? Did I miss something?

Jun 26 2021, 10:45 AM

Jun 1 2021

meka_tilda.center updated the diff for D30149: Example of basic OSS audio application.

Licence and install fixed

Jun 1 2021, 11:07 AM

May 23 2021

meka_tilda.center updated the diff for D30149: Example of basic OSS audio application.

My apologies, I missinterpreted the "inline" part.

May 23 2021, 10:57 AM
meka_tilda.center updated the diff for D30149: Example of basic OSS audio application.

Make internal functions static

May 23 2021, 10:06 AM
meka_tilda.center updated the diff for D30149: Example of basic OSS audio application.

I fixed all from previous comments, except printf formating. I tried to mimic pf.c: https://cgit.freebsd.org/src/tree/sys/netpfil/pf/pf.c#n646 where arguments are on the next line 4 spaces indented to the right relative to start of function name. I also read style(9) one more time and I can't find what I did wrong, so if it's still wrong, please advise.

May 23 2021, 9:23 AM

May 6 2021

meka_tilda.center updated the diff for D30149: Example of basic OSS audio application.

I didn't even know indent exists. Thank you!

May 6 2021, 6:24 PM
meka_tilda.center requested review of D30149: Example of basic OSS audio application.
May 6 2021, 5:49 PM

May 5 2021

meka_tilda.center updated the diff for D30027: Improve sndstat man page.

Nitpicking is good, it keeps docs perfect.

May 5 2021, 8:22 AM

May 4 2021

meka_tilda.center updated the diff for D30027: Improve sndstat man page.

As only one object from nvlist is explained, I decided to go with "an nvlist object".

May 4 2021, 10:02 AM

May 2 2021

meka_tilda.center updated the diff for D30027: Improve sndstat man page.

Update the patch with suggestions by Ka Ho Ng. Sorry it took so much time (vaccine problems), and forgive me if I do something wrong on reviews as it is the first time I'm using it.

May 2 2021, 11:23 PM

Apr 28 2021

meka_tilda.center requested review of D30027: Improve sndstat man page.
Apr 28 2021, 1:53 PM

Jun 18 2020

meka_tilda.center added a comment to D21336: Make dummynet kernel module independent from IPFW.

Yes, it's still relevant. I'm very slow at progress on PF+Dummynet integration, but I am working on it, and dummynet not depending on IPFW is essential.

Jun 18 2020, 12:41 PM

Aug 20 2019

meka_tilda.center edited reviewers for D21336: Make dummynet kernel module independent from IPFW, added: thj; removed: tj.
Aug 20 2019, 10:14 AM
meka_tilda.center created D21336: Make dummynet kernel module independent from IPFW.
Aug 20 2019, 10:13 AM