sound: Start each channel individually
ClosedPublic
Actions

Authored by meka_tilda.center on Jun 3 2026, 2:10 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 6, 3:03 PM

	Unknown Object (File)
	Sat, Jul 4, 11:48 AM

	Unknown Object (File)
	Sat, Jul 4, 11:32 AM

	Unknown Object (File)
	Fri, Jul 3, 12:36 AM

	Unknown Object (File)
	Thu, Jun 11, 11:41 PM

	Unknown Object (File)
	Wed, Jun 10, 5:09 PM

	Unknown Object (File)
	Wed, Jun 10, 2:25 PM

	Unknown Object (File)
	Mon, Jun 8, 9:38 PM

View All 16 Files

Subscribers

imp

Details

Reviewers

christos

Commits

rG0665d5b9d38a: sound: Start each channel individually
rG47ae0a869c7d: sound: Start each channel individually

Summary

Unlock all members before starting any of them. Holding multiple channel locks while calling chn_start() on a virtual channel can trigger the parent, which acquires PCM_LOCK() while other virtual channels are still locked -- a lock order reversal.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

meka_tilda.center created this revision.Jun 3 2026, 2:10 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 3 2026, 2:10 AM

meka_tilda.center requested review of this revision.Jun 3 2026, 2:10 AM

christos accepted this revision.Jun 8 2026, 10:06 AM

This revision is now accepted and ready to land.Jun 8 2026, 10:06 AM

Closed by commit rG47ae0a869c7d: sound: Start each channel individually (authored by meka_tilda.center, committed by christos). · Explain WhyWed, Jun 17, 10:53 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG47ae0a869c7d: sound: Start each channel individually.

christos added a commit: rG0665d5b9d38a: sound: Start each channel individually.Tue, Jun 30, 6:24 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

dsp.c

25 lines

Diff 179912

View Options

sound: Start each channel individuallyClosedPublicActions