Paths

Table of Contentst

sound examples: Fix buffer mapping/allocation
ClosedPublic
Actions

Authored by meka_tilda.center on Wed, Nov 26, 6:43 PM.

Tags

None

Referenced Files

	F140039923: D53939.diff
	Fri, Dec 19, 10:09 AM

	Unknown Object (File)
	Tue, Dec 16, 12:22 PM

	Unknown Object (File)
	Tue, Dec 2, 10:21 PM

	Unknown Object (File)
	Sun, Nov 30, 7:53 PM

	Unknown Object (File)
	Sun, Nov 30, 4:46 PM

	Unknown Object (File)
	Sun, Nov 30, 9:45 AM

	Unknown Object (File)
	Sun, Nov 30, 3:16 AM

	Unknown Object (File)
	Sun, Nov 30, 3:05 AM

View All 9 Files

Subscribers

imp

Details

Reviewers

christos

Commits

rG7587270512d1: sound examples: Fix buffer mapping/allocation
rGebf1d98d6072: sound examples: Fix buffer mapping/allocation

Summary

The buffer in struct config should be allocated or mmap'ed. The code without this patch allocates the buffer unconditionally, even for mmap configs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

meka_tilda.center created this revision.Wed, Nov 26, 6:43 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Nov 26, 6:43 PM

meka_tilda.center requested review of this revision.Wed, Nov 26, 6:43 PM

christos accepted this revision.Wed, Nov 26, 7:30 PM

This revision is now accepted and ready to land.Wed, Nov 26, 7:30 PM

Closed by commit rGebf1d98d6072: sound examples: Fix buffer mapping/allocation (authored by meka_tilda.center, committed by christos). · Explain WhyWed, Nov 26, 7:34 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGebf1d98d6072: sound examples: Fix buffer mapping/allocation.

christos added a commit: rG7587270512d1: sound examples: Fix buffer mapping/allocation.Fri, Nov 28, 2:36 PM

Revision Contents
Changeset List

Path

Size

share/

examples/

sound/

oss.h

21 lines

Diff 167154

View Options

share/examples/sound/oss.h

sound examples: Fix buffer mapping/allocationClosedPublicActions