Also I've just attached a patch to chase these updates in
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=215747&action=diff

This is OK for math/sage: it compiles and installs cleanly, and the examples from Maxima (built with ECL) are OK:

I guess it's hard to do it here, and easier to do it as part of ecl update?

Sure, please do it. Thanks!

I tested it with ECL-20.4.24 from PR 247283, but pkg-plist is not versioned:

Just committed.

With r538922 (math/maxima) committed by salvadore, this revision becomes committable.

Since we cannot have an answer from mat@, I would follow tcberner's advice and suggest this simple patch:

Follow-up D24959 and directly depends on math/maxima. The proposed math/maxima-sage is no more needed!

Great! With this revision xmaxima works fine.

OK. As far as math/sage is concerned, it is OK (Sage does not use xmaxima).

This is fine to be used by math/sage!

You are right: I thought I had acknowledged SageMath everywhere, but missed this one.

About info directory: I haven't done anything. Let me know if you need anything once your investigations are done.

About the info dir: it is from Sage, when running maxima_console. But you're right, I don't see it directly from Maxima: I'll investigate it.

Good job! I have rebuilt Sage with your version of Maxima, without any problem, and the tests cases works fine.

In D24959#554634, @salvadore wrote:

This should work. I still have to finish testing it, but I had the first successfull poudriere build.
With ECL on I got a file linked to libgc-threaded.so and thus I should add libgc-threaded.so:devel/boehm-gc-threaded dependency. However I suspect that this happens only when ecl is built with THREADS on (it's the default). In that case, I think I should not declare the dependecy since:

• if ECL is installed with THREADS on libgc-threaded.so installed as well;
• if ECL is installed with THREADS off maxima is not linked to libgc-threaded.so.

Is that correct?

Do not depend on ecl-sage but directly on lang/ecl after D25096 has been committed.

Replace by a better option in D25096 .
Thanks salvadore!

OIK for me, thanks!

Remark 1: the first time I built it on my workstation, without deinstalling my proposed version of ecl-sage, I got this error:
Error: /usr/local/bin/ecl is linked to /usr/local/lib//libecl.so.16.1 from lang/ecl-sage but it is not declared as a dependency
This means that it tries at first to link with the installed library, and this could possibly cause problem when upgrading.

For those interested, a poudriere log is available at https://people.freebsd.org/~thierry/sage-math-9.1.log.bz2

With this version, I would say that it's now committable (pending D24958 and D24959, and blocked by PR 242509):

In D24195#551218, @arrowd wrote:

Are there any open Bugzilla PRs that should be resolved first, or this diff can be committed right away?

Here we are!

In D24959#550269, @salvadore wrote:

Ok, let's add the ECL option then and set it as default.
Do you want to modify your review yourself or do you prefer that I commandeer the revision and make the changes?