Page MenuHomeFreeBSD

editors/neovim: Update to 0.12.1
ClosedPublic

Authored by laurent on Sun, Apr 12, 8:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 20, 5:02 AM
Unknown Object (File)
Sat, Apr 18, 6:46 PM
Unknown Object (File)
Sat, Apr 18, 10:37 AM
Unknown Object (File)
Sat, Apr 18, 9:57 AM
Unknown Object (File)
Sat, Apr 18, 9:54 AM
Unknown Object (File)
Sat, Apr 18, 7:57 AM
Unknown Object (File)
Sat, Apr 18, 5:24 AM
Unknown Object (File)
Fri, Apr 17, 3:21 PM

Details

Summary

Changes:
https://github.com/neovim/neovim/commit/7ac5a26d5633a41d7e291141488ca635242973a5

Restrict tests to unittest target while functionaltest target fails

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

laurent created this revision.
This revision is now accepted and ready to land.Mon, Apr 13, 1:21 PM
This revision was automatically updated to reflect the committed changes.

Am I the only one who sees this a bit weird to be committed without a single word from port maintainer and without reference to them in commit message? I don't think version updates fall into blanket approval category, and as a maintainer myself, would like to see no such surprises...

@vsasjason_gmail.com you're right, it would be weird without the maintainer consent, but @adamw has given consent for this on the ports-developer mailing list. This work is to help him out.

[...] I'm not able to pay enough attention to FreeBSD, and I'm falling pretty rapidly behind.
For a few weeks, please do anything you feel is best with anything I normally maintain.

I mentioned that I would and he approved my involvement.

So yes, it's unusual, but not weird.

@vsasjason_gmail.com you're right, it would be weird without the maintainer consent, but @adamw has given consent for this on the ports-developer mailing list. This work is to help him out.

[...] I'm not able to pay enough attention to FreeBSD, and I'm falling pretty rapidly behind.
For a few weeks, please do anything you feel is best with anything I normally maintain.

I mentioned that I would and he approved my involvement.

So yes, it's unusual, but not weird.

Thanks for prompt response. Perhaps it makes sense to include commit metaline "Approved by: adamw (email, implicit)" or smth like that.
Sorry for the noise.

Thanks for prompt response. Perhaps it makes sense to include commit metaline "Approved by: adamw (email, implicit)" or smth like that.
Sorry for the noise.

It's not a bad idea and I'll do this in future commits. Thanks!