Changes:
https://github.com/neovim/neovim/commit/7ac5a26d5633a41d7e291141488ca635242973a5
Restrict tests to unittest target while functionaltest target fails
Differential D56359
editors/neovim: Update to 0.12.1 Authored by laurent on Sun, Apr 12, 8:40 AM. Tags None Referenced Files
Subscribers
Details
Changes: Restrict tests to unittest target while functionaltest target fails
Diff Detail
Event TimelineComment Actions Am I the only one who sees this a bit weird to be committed without a single word from port maintainer and without reference to them in commit message? I don't think version updates fall into blanket approval category, and as a maintainer myself, would like to see no such surprises... Comment Actions @vsasjason_gmail.com you're right, it would be weird without the maintainer consent, but @adamw has given consent for this on the ports-developer mailing list. This work is to help him out.
I mentioned that I would and he approved my involvement. So yes, it's unusual, but not weird. Comment Actions Thanks for prompt response. Perhaps it makes sense to include commit metaline "Approved by: adamw (email, implicit)" or smth like that. Comment Actions
It's not a bad idea and I'll do this in future commits. Thanks! |