I will hold off committing this until the evening (a couple of hours from now), in case there's further feedback. Otherwise I don't want to keep your setup broken. We can always revert later on if we find a better approach.

In D56467#1292553, @markj wrote:

This fixes my problem, but if my device wasn't in the puc(4) device table, uart(4) would still try to attach to it and trigger the hang. So, there might still be some problem with the original change. Certainly this is incrementally better, so it's okay with me.

I will commit when I get back home, I'm currently traveling.

Sorry, forgot about this completely, it looks fine to me, thanks for committing it.

This has been superseded by https://reviews.freebsd.org/D56107 which is simpler and also solves the issue. Closing the revision now.

Attempt to fix the QEMU segfault.

It might be easier if I just switch Xen to use lapic_ipi_alloc() like mentioned in the other commit. That would prevent more Xen stuff leaking into generic headers which is not specially nice.

I'm afraid I don't know that much about FRED to make a proper review of the FRED bits, some comments about the Xen side. Let me know if you would like me to prepare a patch to switch Xen to use lapic_ipi_alloc()like the HyperV code does, that would remove the need for Xen specific checks in trap_fred_extint().

Can you paste the contents of /var/log/xen/qemu-<domain name>.log?

Ping? I would like to get this done sooner rather than later so the SeaBIOS port is functional again. Without this change the generated SeaBIOS firmware image is non-functional.

I've tested with this fix and I'm able to build all the USE_BINUTILS ports, except for GCC which I haven't tried because my box runs out of memory when building it.

Do not take over the STRIP makefile variable, which is already used in bsd.port.mk to signal whether the install program should strip the binaries. Instead define STRIP_CMD and use STRIP just for the environment variables.

In D55509#1273416, @mat wrote:

Well, like everything committer related, it's in the committer's guide https://docs.freebsd.org/en/articles/committers-guide/#ports-exp-run, but I don't see what would break with this change.

There are not too many ports with USE_BINUTILS though, you could test build them :-)

Does it need an exp-run? Because I have no idea how to do that.

Can I please get an Ack/Nack from portmgr? This is required for SeaBIOS to be functional again when built on FreeBSD >= 15.

Add missing DIST_SUBDIR for xen-kernel

Adjust usage of ACPI_REDUCED_HARDWARE and remove elvis operator.

Picked the last couple of people that modified that file, and you happened to be there :). Thanks, will wait a bit for someone from ports to voice an opinion.

I think I'm missing the previous changes that introduce the support for KVM, as those haven't landed in the git repository yet. FWIW, while the CPUID has been reserved on Xen, the implementation is not done, so there's no way to test it on Xen.

I'm also fine if you just want to import the new headers from Xen 4.21. I haven't imported new ones recently because I didn't have a need for them, but our headers are now pristine imports from the xen.git ones, we don't carry any FreeBSD specific changes in there.

Tested with an amd64 VM live migration and still can see the ARP on resume.

Thanks, LGTM. Some months require the use of an apostrophe, so it needs to be factored into the months names.

Thanks for the review, will get the extra newlines removed and this committed.

Fix comments by markj.

Colin, could you please add Elliot Reviewed by tag when committing, if this turns out to fix the issues you saw on AWS? Thanks.

Thanks, will adjust tomorrow and commit.