Page MenuHomeFreeBSD

royger (Roger Pau Monné)
User

Projects

User Details

User Since
May 18 2014, 2:32 AM (417 w, 1 d)

Recent Activity

Fri, May 6

royger committed R10:e99c0c8b79b0: xen: Prevent buffer overflow in privcmd ioctl (authored by Dan Carpenter <dan.carpenter@oracle.com>).
xen: Prevent buffer overflow in privcmd ioctl
Fri, May 6, 8:10 AM

Sat, Apr 23

royger accepted D35001: xen: Use devclass_find to lookup devclasses in identify..

Thanks!

Sat, Apr 23, 6:20 AM

Fri, Apr 22

royger added a comment to D35001: xen: Use devclass_find to lookup devclasses in identify..
In D35001#793469, @jhb wrote:

I'm axing the devclass argument to DRIVER_MODULE since it is unused the vast majority of the time. If you'd rather not hardcode the string we could instead use driver->name instead of the hardcoded string.

Note however that we hardcode the driver name a few lines below in the call to BUS_ADD_CHILD, so if we are really worried about that then we need to change BUS_ADD_CHILD to also use driver->name.

Fri, Apr 22, 3:08 PM

Thu, Apr 21

royger added a comment to D35001: xen: Use devclass_find to lookup devclasses in identify..

Hm, isn't this more fragile, as we need to keep the string in driver_t in sync with the call to devclass_find()?

Thu, Apr 21, 8:18 AM

Apr 12 2022

royger committed R10:a1a5c5351659: x86/xen: fallback when VCPUOP_send_nmi is not available (authored by royger).
x86/xen: fallback when VCPUOP_send_nmi is not available
Apr 12 2022, 8:08 AM
royger committed R10:590f093f74f2: xen/blkback: fix reconnection of backend (authored by royger).
xen/blkback: fix reconnection of backend
Apr 12 2022, 8:08 AM
royger committed R10:499d685b02d4: xen/netback: do not attempt to connect in the Initialised state (authored by royger).
xen/netback: do not attempt to connect in the Initialised state
Apr 12 2022, 8:08 AM
royger closed D34841: xen/acpi: upload Cx and Px data to Xen.
Apr 12 2022, 8:05 AM
royger committed R10:b93f47eaeef7: xen/acpi: upload Cx and Px data to Xen (authored by royger).
xen/acpi: upload Cx and Px data to Xen
Apr 12 2022, 8:05 AM

Apr 8 2022

royger requested review of D34841: xen/acpi: upload Cx and Px data to Xen.
Apr 8 2022, 8:11 AM

Mar 30 2022

royger committed R11:b717e6878059: {emulators,sysutils}/xen-{kernel,tools}: update to 4.16.0 (authored by royger).
{emulators,sysutils}/xen-{kernel,tools}: update to 4.16.0
Mar 30 2022, 10:31 AM

Mar 23 2022

royger committed R10:b6370a2c00e1: vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized (authored by royger).
vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized
Mar 23 2022, 2:53 PM
royger committed R10:ad4277c7250c: vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized (authored by royger).
vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized
Mar 23 2022, 1:53 PM
royger committed R10:41a0aef5048a: vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized (authored by royger).
vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized
Mar 23 2022, 1:48 PM
royger committed R10:88aff320c805: x86/xen: fix CPUID signature (authored by royger).
x86/xen: fix CPUID signature
Mar 23 2022, 1:47 PM

Mar 18 2022

royger committed R10:1ca34862dc45: x86/tsc: fetch frequency from CPUID when running on Xen (authored by royger).
x86/tsc: fetch frequency from CPUID when running on Xen
Mar 18 2022, 9:21 AM
royger closed D34581: x86/tsc: fetch frequency from CPUID when running on Xen.
Mar 18 2022, 9:21 AM

Mar 17 2022

royger updated the diff for D34581: x86/tsc: fetch frequency from CPUID when running on Xen.

Pull out tsc_init calls from the early_clock_source_init() handlers.

Mar 17 2022, 1:39 PM
royger committed R10:0518832011ca: vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized (authored by royger).
vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized
Mar 17 2022, 1:32 PM
royger closed D34392: vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized.
Mar 17 2022, 1:31 PM
royger added a comment to D34581: x86/tsc: fetch frequency from CPUID when running on Xen.

It might be better to pull tsc_init() call out of the hook implementation, now that all of them call it anyway.

Mar 17 2022, 12:53 PM
royger updated the diff for D34581: x86/tsc: fetch frequency from CPUID when running on Xen.
  • Rebase over changes in tsc.c.
  • Add KASSERT.
  • Call tsc_init from Xen PVH early_clock_source_init hook.
Mar 17 2022, 12:27 PM
royger closed D34580: xen: fix CPUID signature.
Mar 17 2022, 11:57 AM
royger committed R10:396a8479b0ac: x86/xen: fix CPUID signature (authored by royger).
x86/xen: fix CPUID signature
Mar 17 2022, 11:57 AM
royger updated the diff for D34392: vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized.

Update vt man page.

Mar 17 2022, 11:54 AM
royger added inline comments to D34581: x86/tsc: fetch frequency from CPUID when running on Xen.
Mar 17 2022, 11:29 AM

Mar 16 2022

royger added inline comments to D34581: x86/tsc: fetch frequency from CPUID when running on Xen.
Mar 16 2022, 6:41 PM
royger requested review of D34581: x86/tsc: fetch frequency from CPUID when running on Xen.
Mar 16 2022, 4:42 PM
royger requested review of D34580: xen: fix CPUID signature.
Mar 16 2022, 4:39 PM

Feb 28 2022

royger requested review of D34392: vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized.
Feb 28 2022, 9:29 AM

Feb 7 2022

royger committed R10:ad7dd5149910: xen: switch to use headers in contrib (authored by ehem_freebsd_m5p.com).
xen: switch to use headers in contrib
Feb 7 2022, 9:17 AM
royger committed R10:b6da4ec609ce: xen: remove leftover bits missed in commit ac3ede5371 (authored by ehem_freebsd_m5p.com).
xen: remove leftover bits missed in commit ac3ede5371
Feb 7 2022, 9:17 AM
royger committed R10:476438e81f1e: xen: remove public headers in sys/xen/interface (authored by royger).
xen: remove public headers in sys/xen/interface
Feb 7 2022, 9:17 AM
royger committed R10:3a9fd8242b35: xen: import Xen 4.16 public headers in sys/contrib/ (authored by royger).
xen: import Xen 4.16 public headers in sys/contrib/
Feb 7 2022, 9:17 AM
royger committed R10:759ae58c0049: xen/grant-table: remove explicit linear mapping additions (authored by royger).
xen/grant-table: remove explicit linear mapping additions
Feb 7 2022, 9:17 AM
royger closed D31206: xen: remove leftover bits missed in commit ac3ede5371.
Feb 7 2022, 9:16 AM
royger closed D29602: xen/grant-table: remove explicit linear mapping additions.
Feb 7 2022, 9:16 AM

Feb 3 2022

royger accepted D34153: x86 atomics: use lock prefix unconditionally.

s/read hardware/real hardware/ in the commit message I think.

Feb 3 2022, 10:21 AM

Jan 18 2022

royger committed R10:e0516c7553da: x86/apic: remove apic_ops (authored by royger).
x86/apic: remove apic_ops
Jan 18 2022, 9:20 AM
royger committed R10:2450da67764c: x86/xen: use x{2}APIC if virtualized by hardware (authored by royger).
x86/xen: use x{2}APIC if virtualized by hardware
Jan 18 2022, 9:20 AM
royger closed D33917: x86/apic: remove apic_ops.
Jan 18 2022, 9:19 AM

Jan 17 2022

royger updated the diff for D33917: x86/apic: remove apic_ops.

Update comment.

Jan 17 2022, 3:54 PM
royger requested review of D33917: x86/apic: remove apic_ops.
Jan 17 2022, 3:53 PM
royger committed R10:ad15eeeaba30: x86/xen: fallback when VCPUOP_send_nmi is not available (authored by royger).
x86/xen: fallback when VCPUOP_send_nmi is not available
Jan 17 2022, 10:10 AM

Jan 13 2022

royger committed R10:7d06c761c8ab: x86/madt: allow Xen guest to use x2APIC mode (authored by royger).
x86/madt: allow Xen guest to use x2APIC mode
Jan 13 2022, 4:16 PM
royger closed D33877: x86/madt: allow Xen guest to use x2APIC mode.
Jan 13 2022, 4:16 PM
royger requested review of D33877: x86/madt: allow Xen guest to use x2APIC mode.
Jan 13 2022, 4:01 PM
royger committed R10:ca46f3289d96: xen: use an hypercall for shutdown and reboot (authored by royger).
xen: use an hypercall for shutdown and reboot
Jan 13 2022, 3:55 PM
royger edited reviewers for D33876: xen/netfront: deal with mbuf data crossing a page boundary, added: network; removed: royger.
Jan 13 2022, 3:37 PM
royger requested review of D33876: xen/netfront: deal with mbuf data crossing a page boundary.
Jan 13 2022, 3:37 PM

Dec 29 2021

royger closed D33680: mbuf_tags: use explicitly sized type for 'type' parameter.
Dec 29 2021, 8:26 AM
royger committed R10:60e749da3c8b: mbuf_tags: use explicitly sized type for 'type' parameter (authored by royger).
mbuf_tags: use explicitly sized type for 'type' parameter
Dec 29 2021, 8:26 AM

Dec 28 2021

royger updated the diff for D33680: mbuf_tags: use explicitly sized type for 'type' parameter.

Fix kp comments

Dec 28 2021, 2:32 PM
royger added a comment to D33680: mbuf_tags: use explicitly sized type for 'type' parameter.

Thanks! Will run the universe build if there are no further comments.

Dec 28 2021, 2:15 PM
royger edited reviewers for D33680: mbuf_tags: use explicitly sized type for 'type' parameter, added: network, transport; removed: royger.
Dec 28 2021, 8:56 AM
royger requested review of D33680: mbuf_tags: use explicitly sized type for 'type' parameter.
Dec 28 2021, 8:56 AM

Nov 23 2021

royger committed R11:e050de4b9c32: sysutils/xen-tools: fix build with clang 13.0.0 (authored by royger).
sysutils/xen-tools: fix build with clang 13.0.0
Nov 23 2021, 1:48 PM
royger committed R11:96cede86ff9a: emulators/xen-kernel: fix build with clang 13.0.0 (authored by royger).
emulators/xen-kernel: fix build with clang 13.0.0
Nov 23 2021, 1:48 PM

Nov 18 2021

royger committed R10:50d7d967bbfd: xen/privcmd: fix MMAP_RESOURCE ioctl to copy out results (authored by royger).
xen/privcmd: fix MMAP_RESOURCE ioctl to copy out results
Nov 18 2021, 8:47 AM

Nov 17 2021

royger added inline comments to D30935: xen/intr: move interrupt balancing into xen_intr_alloc_isrc().
Nov 17 2021, 8:39 AM

Nov 16 2021

royger added inline comments to D30935: xen/intr: move interrupt balancing into xen_intr_alloc_isrc().
Nov 16 2021, 4:23 PM

Nov 12 2021

royger added a comment to D30726: xen/intr: rework locking, prepare xen_intr_alloc_isrc() for split.

Thanks for the update, I'm going over the dependencies to check how this all fits together.

Nov 12 2021, 2:55 PM
royger added inline comments to D30935: xen/intr: move interrupt balancing into xen_intr_alloc_isrc().
Nov 12 2021, 2:49 PM

Nov 10 2021

royger added a comment to D30726: xen/intr: rework locking, prepare xen_intr_alloc_isrc() for split.

Forgot to hit summit yesterday...

Nov 10 2021, 4:35 PM

Nov 8 2021

royger added a comment to D30726: xen/intr: rework locking, prepare xen_intr_alloc_isrc() for split.

I'm unsure you actually need to split those apart. Wouldn't Arm also require some kind of locking of the architecture specific bits?

See D30936. The goal is everything being protected by xen_intr_x86_lock is very x86-specific and destined to split away from this file. Whereas the portions which remain protected by xen_intr_isrc_lock are mostly architecture-independent and will remain in this file. Splitting the locks allows them to be static.

Nov 8 2021, 5:27 PM
royger added a comment to D30726: xen/intr: rework locking, prepare xen_intr_alloc_isrc() for split.

I'm unsure you actually need to split those apart. Wouldn't Arm also require some kind of locking of the architecture specific bits?

Nov 8 2021, 3:31 PM

Oct 27 2021

royger added a comment to D31206: xen: remove leftover bits missed in commit ac3ede5371.

Can you please base this on top of current code? AFAICT there's no need to move those fields to xen_arch_isrc just to end up removing them afterwards.

Oct 27 2021, 4:10 PM
royger accepted D31206: xen: remove leftover bits missed in commit ac3ede5371.
Oct 27 2021, 4:04 PM

Oct 21 2021

royger committed R10:5bb67f5f3f59: xen/devices: purge uses of intr_machdep.h (authored by ehem_freebsd_m5p.com).
xen/devices: purge uses of intr_machdep.h
Oct 21 2021, 7:41 AM
royger closed D29959: xen/devices: purge uses of intr_machdep.h.
Oct 21 2021, 7:41 AM
royger committed R10:535badd1b8d2: xen/pcifront: purge from tree (authored by royger).
xen/pcifront: purge from tree
Oct 21 2021, 7:41 AM

Oct 20 2021

royger added inline comments to D29959: xen/devices: purge uses of intr_machdep.h.
Oct 20 2021, 10:34 AM

Oct 15 2021

royger accepted D29959: xen/devices: purge uses of intr_machdep.h.

LGTM, will push

Oct 15 2021, 8:35 AM

Sep 17 2021

royger accepted D32008: Remove support for FreeBSD 11.4.

For Xen bits.

Sep 17 2021, 8:03 PM

Aug 31 2021

royger added a comment to D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.

No, then you would be doing arithmetic on a void pointer, which isn't officially legal (size of void being undefined). Better to do the math on integers and cast to the correct type.

Aug 31 2021, 4:50 PM
royger added a comment to D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.

On second thought it might have been easier to just cast to void * and forget about the parentheses.

Aug 31 2021, 2:46 PM

Aug 29 2021

royger added a comment to D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.
In D31711#715619, @dim wrote:

I think you can also remove the cast to vm_paddr_t while there, the field is declared as uint64_t.

Hm, won't that give problems on i386? I'll see what a i386 build does.

Aug 29 2021, 3:53 PM
royger accepted D31711: xen: Fix warning by adding KERNBASE to vm_paddr_t before casting.

I think you can also remove the cast to vm_paddr_t while there, the field is declared as uint64_t.

Aug 29 2021, 2:15 PM

Aug 12 2021

royger committed R10:5e4279a8f35a: loader: fix multiboot loading on UEFI (authored by royger).
loader: fix multiboot loading on UEFI
Aug 12 2021, 7:24 AM
royger committed R10:f4c6843ec2b9: xen: use correct cache attributes for Xen specific memory regions (authored by royger).
xen: use correct cache attributes for Xen specific memory regions
Aug 12 2021, 7:24 AM
royger closed D31507: loader: fix multiboot loading on UEFI.
Aug 12 2021, 7:24 AM
royger added a comment to D31507: loader: fix multiboot loading on UEFI.
In D31507#710357, @kib wrote:

Note that 'relocatable' means variyng not VA, but PA. Loader still maps the kernel at KERNBASE.

Aug 12 2021, 6:48 AM

Aug 11 2021

royger requested review of D31507: loader: fix multiboot loading on UEFI.
Aug 11 2021, 3:05 PM

Aug 2 2021

royger committed R10:82bf6a2566ba: xen/timer: fix amd64 LINT kernel build (authored by royger).
xen/timer: fix amd64 LINT kernel build
Aug 2 2021, 9:33 AM

Jul 28 2021

royger committed R10:ac959cf54421: xen: introduce xen_has_percpu_evtchn() (authored by julien_xen.org).
xen: introduce xen_has_percpu_evtchn()
Jul 28 2021, 3:31 PM
royger committed R10:46c46edd1889: xen/control: print warning on call of xctrl_suspend() (authored by julien_xen.org).
xen/control: print warning on call of xctrl_suspend()
Jul 28 2021, 3:31 PM
royger committed R10:7de88bb4a2e8: xen/grant_table: cleanup max_nr_grant_frames() (authored by ehem_freebsd_m5p.com).
xen/grant_table: cleanup max_nr_grant_frames()
Jul 28 2021, 3:31 PM
royger closed D29402: xen: introduce xen_support_evtchn_bind().
Jul 28 2021, 3:30 PM
royger committed R10:0b4f30c2366c: xen/control: introduce xen_pv_shutdown_handler() (authored by julien_xen.org).
xen/control: introduce xen_pv_shutdown_handler()
Jul 28 2021, 3:30 PM
royger closed D29599: xen/control: print warning on call of xctrl_suspend().
Jul 28 2021, 3:30 PM
royger committed R10:69c6eee7567b: xen: introduce xen_pv_disks_disabled() (authored by julien_xen.org).
xen: introduce xen_pv_disks_disabled()
Jul 28 2021, 3:30 PM
royger closed D29840: xen/grant_table: cleanup max_nr_grant_frames().
Jul 28 2021, 3:30 PM
royger committed R10:5f7000832791: xen/netfront: introduce xen_pv_nics_disabled() (authored by julien_xen.org).
xen/netfront: introduce xen_pv_nics_disabled()
Jul 28 2021, 3:30 PM
royger closed D29406: xen/control: introduce xen_pv_shutdown_handler().
Jul 28 2021, 3:30 PM
royger committed R10:c89f1f12b07b: xen/xen-os: move inclusion of machine/xen-os.h later (authored by ehem_freebsd_m5p.com).
xen/xen-os: move inclusion of machine/xen-os.h later
Jul 28 2021, 3:30 PM
royger closed D29403: xen: introduce xen_pv_disks_disabled().
Jul 28 2021, 3:30 PM
royger committed R10:e627e25d761f: xen/xenpv: remove low memory limit for non-x86 (authored by ehem_freebsd_m5p.com).
xen/xenpv: remove low memory limit for non-x86
Jul 28 2021, 3:30 PM
royger closed D29405: xen/netfront: introduce xen_pv_nics_disabled().
Jul 28 2021, 3:30 PM
royger committed R10:9976c5a540c1: xen/intr: use __func__ instead of function names (authored by ehem_freebsd_m5p.com).
xen/intr: use __func__ instead of function names
Jul 28 2021, 3:30 PM
royger closed D29811: xen/xen-os: move inclusion of machine/xen-os.h later.
Jul 28 2021, 3:29 PM