Page MenuHomeFreeBSD

royger (Roger Pau Monné)
User

Projects

User Details

User Since
May 18 2014, 2:32 AM (375 w, 3 d)

Recent Activity

Wed, Jul 14

royger added a comment to D29402: xen: introduce xen_support_evtchn_bind().

I would name this xen_percpu_evtchn{_enabled} or some such. Given the current usage I think xen_support_evtchn_rebind is confusing, as it's not about rebinding an event channel, but being able to assign event channels to vCPUs.

Wed, Jul 14, 11:30 AM

Wed, Jul 7

royger committed R11:53c01d65985f: sysutils/xen-tools: fix build with go installed (authored by royger).
sysutils/xen-tools: fix build with go installed
Wed, Jul 7, 7:23 AM

Fri, Jul 2

royger added inline comments to D29733: kvmclock driver with vDSO support.
Fri, Jul 2, 7:26 AM

Thu, Jul 1

royger added inline comments to D29733: kvmclock driver with vDSO support.
Thu, Jul 1, 11:09 AM

Wed, Jun 30

royger added a comment to D29733: kvmclock driver with vDSO support.

Just replied to the most controversial part I think, will try to review the rest tomorrow.

Wed, Jun 30, 5:33 PM

Jun 22 2021

royger committed R11:fa0f04a80fb6: emulators/xen-kernel: import fix for cache attributes (authored by royger).
emulators/xen-kernel: import fix for cache attributes
Jun 22 2021, 2:55 PM
royger committed R11:d0e59dedfb1b: emulators/xen-kernel: remove stale patch files (authored by royger).
emulators/xen-kernel: remove stale patch files
Jun 22 2021, 2:55 PM

Jun 16 2021

royger added a comment to D29733: kvmclock driver with vDSO support.

Thanks and sorry for the delay! Mostly nits, I think the only major question is whether you need to use the dma system to allocate the memory for the vcpu time infos. I think it would be fine to just use plain malloc.

Jun 16 2021, 3:17 PM
royger resigned from D30278: sysutils/edk2: Rename xen flavor to xen_x64.
Jun 16 2021, 1:00 PM

Jun 15 2021

royger added inline comments to D30648: xen/intr: move x86 bits into xen_arch_isrc_t structure.
Jun 15 2021, 9:38 AM

Jun 11 2021

royger added a comment to D30725: xen/intr: protect xen_intr_port_to_isrc[] during resume.

Thanks! For the record: the lock is not currently needed given the only caller has APs and interrupts disabled. I'm fine with adding this safeguard, but it should be noted in the commit message IMO that this is not currently an issue.

Jun 11 2021, 3:09 PM

May 20 2021

royger committed R11:8790f67654a9: sysutils/xen-tools: improve ivshmem check (authored by royger).
sysutils/xen-tools: improve ivshmem check
May 20 2021, 1:48 PM
royger committed R11:97632df2b3f8: sysutils/xen-tools: fix build on FreeBSD 12 (authored by royger).
sysutils/xen-tools: fix build on FreeBSD 12
May 20 2021, 7:00 AM
royger closed D30329: sysutils/edk2: update to 202102.
May 20 2021, 7:00 AM
royger committed R11:ef0c9c2a7940: sysutils/edk2: update to 202102 (authored by royger).
sysutils/edk2: update to 202102
May 20 2021, 7:00 AM
royger closed D30328: sysutils/edk2: use default gcc.
May 20 2021, 7:00 AM
royger committed R11:998bc2159759: sysutils/edk2: use default gcc (authored by royger).
sysutils/edk2: use default gcc
May 20 2021, 7:00 AM

May 18 2021

royger requested review of D30329: sysutils/edk2: update to 202102.
May 18 2021, 11:30 AM
royger requested review of D30328: sysutils/edk2: use default gcc.
May 18 2021, 11:28 AM
royger committed R10:9e14ac116e70: x86/xen: further PVHv1 removal cleanup (authored by royger).
x86/xen: further PVHv1 removal cleanup
May 18 2021, 8:45 AM

May 17 2021

royger accepted D30316: xen: Remove leftover bits missed in commit ac3ede5371.

Thanks! There's also some ELFNOTES that are now stale, but will cleanup later.

May 17 2021, 4:59 PM
royger accepted D30306: xen-tools: Handle DOCS correctly.

I wondered about this, but since makeplist didn't suggest the prefix I didn't do it. Did I maybe overlook at poudriere output?

May 17 2021, 12:47 PM
royger added a comment to D30278: sysutils/edk2: Rename xen flavor to xen_x64.

LGTM, just one minor nit in the MOVED file I think. Thanks for fixing the xen-tools package also!

May 17 2021, 12:41 PM
royger committed R10:2117a66af54f: xen: remove hypervisor_info (authored by mhorne).
xen: remove hypervisor_info
May 17 2021, 9:44 AM
royger committed R10:c93e6ea344a1: xen: remove support for PVHv1 bootpath (authored by mhorne).
xen: remove support for PVHv1 bootpath
May 17 2021, 9:44 AM
royger committed R10:ac3ede5371af: x86/xen: remove PVHv1 code (authored by royger).
x86/xen: remove PVHv1 code
May 17 2021, 9:43 AM
royger closed D30228: x86/xen: remove PVHv1 code.
May 17 2021, 9:43 AM

May 14 2021

royger updated the diff for D30228: x86/xen: remove PVHv1 code.

Address comments from Elliott.

May 14 2021, 10:11 AM

May 13 2021

royger added a comment to D30228: x86/xen: remove PVHv1 code.

This isn't quite what I had expected, I was expecting more of cfa0b7b82fbdda56d7160569def5c6133eb045aa to be reverted. That though appears to have been done in a separate commit which isn't here.

May 13 2021, 11:06 AM
royger added a comment to D29873: etc/ttys: add the xen console.
In D29873#675696, @imp wrote:

The only reason to maybe add it is that our ttys are the same everywhere and we'd like to go to 1 ttys since the need to have it be radically different has passed away.

Given this, I'm kind of tempted to pull the trigger and merge to a single file at the same time as adding the Xen console device.

May 13 2021, 8:01 AM

May 12 2021

royger requested review of D30228: x86/xen: remove PVHv1 code.
May 12 2021, 11:53 AM
royger closed D30225: sysutils/edk2: add Xen platform.
May 12 2021, 8:58 AM
royger committed R11:5e92a126a922: {emulators,sysutils}/xen-{kernel,tools}: update to 4.15.0 (authored by royger).
{emulators,sysutils}/xen-{kernel,tools}: update to 4.15.0
May 12 2021, 8:58 AM
royger committed R11:565eb7e544c8: sysutils/edk2: add Xen platform (authored by royger).
sysutils/edk2: add Xen platform
May 12 2021, 8:58 AM
royger added inline comments to D30225: sysutils/edk2: add Xen platform.
May 12 2021, 8:14 AM
royger abandoned D30212: sysutils/uefi-edk2-xen: introduce port.

Made this a flavour of the edk2 port: https://reviews.freebsd.org/D30225

May 12 2021, 7:29 AM
royger requested review of D30225: sysutils/edk2: add Xen platform.
May 12 2021, 7:28 AM

May 11 2021

royger committed R10:4772e86beb08: xen/blkback: fix reconnection of backend (authored by royger).
xen/blkback: fix reconnection of backend
May 11 2021, 2:16 PM
royger requested review of D30212: sysutils/uefi-edk2-xen: introduce port.
May 11 2021, 11:27 AM

May 6 2021

royger added inline comments to D29733: kvmclock driver with vDSO support.
May 6 2021, 9:54 AM
royger added a comment to D29733: kvmclock driver with vDSO support.

pvclock_softc_init feels slightly weird, as it's not a real softc, same with pvclock_attach or detach, as they are not called from the typical bus functions (ie: there's no identify/probe for example, and neither are part of a device_method_t struct). I would just use pvclock_private, and have a single pvclock_init/pvclock_destroy set of helpers. Attempting to make them look like DEVMETHOD is IMO confusing.

May 6 2021, 9:37 AM

May 3 2021

royger added a comment to D29873: etc/ttys: add the xen console.

Think about this, should D29873 add the Xen virtual console device to the sbin/init/ttys.* files for all architectures? This would keep these files consistent and at least one other architecture is looking at potential Xen support. My only question would be the treatment of x86. As of FreeBSD 12, the Xen code was using the emulated serial port as console instead of the ring. Should the ring device be added for x86 even though it currently isn't used?

May 3 2021, 7:46 AM

Apr 29 2021

royger added a comment to D30006: xen/intr: change return of xen_intr_handle_upcall() to match filter.

You will also need to change the call to intr_execute_handlers as that's x86 specific also? And the lapic_eoi call.

Apr 29 2021, 8:06 AM

Apr 28 2021

royger added inline comments to D29733: kvmclock driver with vDSO support.
Apr 28 2021, 5:15 PM
royger added a comment to D29733: kvmclock driver with vDSO support.

LGTM, just one request

Apr 28 2021, 2:35 PM

Apr 27 2021

royger added a comment to D29404: xen: introduce PCPU_ID_GET().

If this patch has to make progress the commit message needs to be updated to reflect why a vCPU ID filed might not be needed, and that having a per-arch helper allows to abstract away whether it's a completely different CPU field or just abstracted away from existing data.

Apr 27 2021, 10:07 AM
royger added inline comments to D29404: xen: introduce PCPU_ID_GET().
Apr 27 2021, 10:06 AM

Apr 22 2021

royger added a comment to D29873: etc/ttys: add the xen console.

If someone has FreeBSD on a server where Domain 0 does not belong to them, then it could be undesirable to treat the Xen console as secure. Running FreeBSD as a DomU on one's own server, almost certainly you want the console considered secure.

I'll try to come up with better language.

Apr 22 2021, 7:05 AM

Apr 21 2021

royger added a comment to D29874: xen/arm64: add xen early init.

If you only need such early detection for the console support, maybe you could consider placing it in the console probe hook instead?

Apr 21 2021, 8:01 AM
royger added inline comments to D29874: xen/arm64: add xen early init.
Apr 21 2021, 8:00 AM
royger added a comment to D29873: etc/ttys: add the xen console.

I think the code is fine, I'm however having trouble parsing the commit message: "Guests on someone else's hardware may disable this, but for one's own hardware this is valuable.", could you please reword to something easier to parse? What do you mean with 'someone else's hardware'?

Apr 21 2021, 7:53 AM
royger added inline comments to D29875: xen/arm64: add handling of Xen device-tree.
Apr 21 2021, 7:51 AM
royger accepted D29406: xen/control: introduce xen_pv_shutdown_handler().
Apr 21 2021, 7:40 AM
royger accepted D29403: xen: introduce xen_pv_disks_disabled().

My point is that maybe instead of an inline function you can introduce a define instead, ie:

#define xen_disable_pv_disks false

For Arm, and leave the x86 as-is, just moving the extern declaration into the arch specific xen-os.h.

Did you misread the commit or make a mistake when reading the Phabricator file list? Whether or not that approach is used, sys/xen/xen-os.h still needs to be modified to remove xen_disable_pv_disks from there. No definition or declaration is added for ARM in this commit. The commits for sys/arm64/include/xen/xen-os.h aren't yet present.

Apr 21 2021, 7:39 AM

Apr 20 2021

royger added a comment to D29313: arm64: initial support for px30 and rk3326.

Sorry, I didn't have any more time to look into the clock ordering stuff. Using the link doesn't work fine here because FreeBSD will try to initialise clocks that rely on link sources and then fail. IMO the best way would be to init clocks once all the dependencies are meet, but I haven't looked into how to do it, maybe try to init the clock and just postpone if the full dependency tree cannot be initialised?

Apr 20 2021, 2:19 PM

Apr 6 2021

royger accepted D29499: xen/intr: use __func__ instead of function names.

I don't have a strong opinion on the rewording of the assert messages. @mhorne would you be OK if I commit this with the fixed error != 0 check?

Apr 6 2021, 2:49 PM
royger added a comment to D29599: xen/control: print warning on call of xctrl_suspend().

The commit message doesn't seem to match the actual code, it says: "implement suspend as panic for ARM" yet xctrl_suspend for Arm is just a printf, not a panic.

Apr 6 2021, 2:47 PM
royger added a comment to D29598: xen/blkfront: WRITE_BARRIER and FLUSH_DISKCACHE require barrier.

The commit message needs to be adjusted, as it contains a question. All memory shared with Xen is of type WB (the default attribute), but I'm not sure I see the point of the question, the bus_dmamap_sync checks that the submitted segments match the requirement of the underlying device in terms of aligments, sizes and boundaries, or else bounces it to some temporary memory. This cannot be avoided AFAICT. A very good test for the dmamap stuff is newfs, which tends to do weird block writes that trigger the dmamap bouncing for blkfront IIRC.

Apr 6 2021, 2:45 PM
royger added a comment to D29597: xen/console: add support for HVM and ARM console.

I think the comment about pmap not being initialized for HVM needs some clarification.

Apr 6 2021, 1:52 PM
royger added a comment to D29403: xen: introduce xen_pv_disks_disabled().

That is pretty well what the series does. Introduces sys/arm64/include/xen/xen-os.h with xen_pv_disks_disabled() as a static inline which returns false. The real question is whether to adjust history by introducing all of these at the same time as the function is introduced generally. I suspect that is likely better, I think this may be better via e-mail.

Apr 6 2021, 1:41 PM
royger requested review of D29602: xen/grant-table: remove explicit linear mapping additions.
Apr 6 2021, 11:20 AM
royger accepted D29304: xen/xenpv: remove low memory limit for non-x86.
Apr 6 2021, 9:33 AM
royger accepted D29041: xen/timer: make xen timer optional.
Apr 6 2021, 9:27 AM
royger accepted D29500: xen/intr: use struct xenisrc * as xen_intr_handle_t.

LGTM, I'm however tempted to s/__inline/inline/ at commit unless there's a reason to explicitly use __inline.

Apr 6 2021, 9:20 AM
royger accepted D29351: xen: create VM_MEMATTR_XEN for Xen memory mappings.

I'm happy with this, will queue it.

Apr 6 2021, 7:33 AM

Mar 25 2021

royger added inline comments to D29041: xen/timer: make xen timer optional.
Mar 25 2021, 4:04 PM
royger accepted D29042: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c.
Mar 25 2021, 4:02 PM
royger added inline comments to D29304: xen/xenpv: remove low memory limit for non-x86.
Mar 25 2021, 4:02 PM
royger added inline comments to D29305: xen/grant_table: adjust use of pmap_kenter() for aarch64.
Mar 25 2021, 3:55 PM
royger accepted D29306: xen/control: disable 15226522304868a8312a84f8ff549fdc6bbf54db on !x86.

I'm fine with this, if in the future other arches require some arch specific stuff to be executed at a similar place we could introduce an arch-specific hook (ie: xen_cpu_resumed or some such, I'm bad at naming).

Mar 25 2021, 3:41 PM
royger added a comment to D29307: xen/public: replace typeof() with __typeof__().

I usually import the whole headers at once in order to keep them in sync with specific versions. I would be fine if you just pick the whole contents of the public/ folder after your change and dump it directly on FreeBSD.

Mar 25 2021, 3:39 PM
royger added a comment to D29351: xen: create VM_MEMATTR_XEN for Xen memory mappings.

One minor comment. I have some comments about gnttab_map, but I would make those in the relevant patch. Maybe we should just name this VM_MEMATTR_XEN and drop the _SHARED suffix.

Mar 25 2021, 3:36 PM
royger added a comment to D29404: xen: introduce PCPU_ID_GET().

I'm not sure why this is needed, as I would expect that just using PCPU_GET(vcpu_id) or PCPU_ID_GET(cpu, vcpu_id) if you need to fetch the vcpu id of a different CPU to be enough.

Mar 25 2021, 3:25 PM
royger added a comment to D29402: xen: introduce xen_support_evtchn_bind().

I think the commit message needs some kind of adjustments, as it seems to mix event channel rebind with having setup a vector callback for event channel notification delivery?

Mar 25 2021, 3:19 PM
royger added a comment to D29403: xen: introduce xen_pv_disks_disabled().

Forgot to ask on the previous patch, but I guess the tunable won't be available to Arm guests anyway, in which case it might be easier to just force xen_disable_pv_disks to false for Arm:

Mar 25 2021, 3:11 PM
royger accepted D29405: xen/netfront: introduce xen_pv_nics_disabled().
Mar 25 2021, 3:09 PM
royger added a comment to D29406: xen/control: introduce xen_pv_shutdown_handler().

Just one minor comment.

Mar 25 2021, 3:08 PM
royger accepted D29407: xen/xen-os: don't let anyone else defining __XEN_INTERFACE_VERSION__.
Mar 25 2021, 3:07 PM

Mar 23 2021

royger committed R10:4489124c0472: xen/netback: do not attempt to connect in the Initialised state (authored by royger).
xen/netback: do not attempt to connect in the Initialised state
Mar 23 2021, 10:08 AM

Mar 20 2021

royger accepted D29296: xnb: Don't pass SIOC{ADD,DEL}MULTI to ifmedia_ioctl()..

LGTM. Thanks!

Mar 20 2021, 8:30 AM

Mar 17 2021

royger updated the summary of D29313: arm64: initial support for px30 and rk3326.
Mar 17 2021, 11:41 AM
royger requested review of D29313: arm64: initial support for px30 and rk3326.
Mar 17 2021, 11:40 AM

Mar 15 2021

royger committed R10:b55c0d5f56bd: xen: move x86-specific xen_vector_callback_enabled to sys/x86 (authored by julien.grall_citrix.com).
xen: move x86-specific xen_vector_callback_enabled to sys/x86
Mar 15 2021, 1:22 PM
royger closed D29040: xen: move x86-specific xen_vector_callback_enabled to sys/x86.
Mar 15 2021, 1:22 PM
royger closed D29043: xen/xenusb: always include xen/xen-os.h rather than machine/xen/xen-os.h.
Mar 15 2021, 1:21 PM
royger committed R10:ff5272ca7149: xen/xenusb: always include xen/xen-os.h rather than machine/xen/xen-os.h (authored by julien.grall_citrix.com).
xen/xenusb: always include xen/xen-os.h rather than machine/xen/xen-os.h
Mar 15 2021, 1:21 PM

Mar 4 2021

royger added a comment to D29042: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c.

Yeah, I've got no idea what-so-ever why one might feel xenpv.c should be
in a "bus" directory. No similarity to any type of bus. No devices
attached at all. Certainly not a bus.

Mar 4 2021, 5:31 PM
royger added a comment to D29040: xen: move x86-specific xen_vector_callback_enabled to sys/x86.

Also, the 'Adapted-to-HEAD-by' tag is not really a standard tag, and doesn't mention the original author either. I would just add a line saying:

Mar 4 2021, 9:11 AM
royger accepted D29040: xen: move x86-specific xen_vector_callback_enabled to sys/x86.

LGTM, we should make this a bool type also.

Mar 4 2021, 9:06 AM
royger added a comment to D29041: xen/timer: make xen timer optional.

Some minor comments.

Mar 4 2021, 9:02 AM
royger accepted D29043: xen/xenusb: always include xen/xen-os.h rather than machine/xen/xen-os.h.

LGTM.

Mar 4 2021, 8:57 AM
royger added a comment to D29042: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c.

I would consider placing it in sys/dev/xen/bus/xenpv.c

Mar 4 2021, 8:57 AM

Mar 3 2021

royger committed rP567091: sysutils/xen-tools: remove markdown depenmdency.
sysutils/xen-tools: remove markdown depenmdency
Mar 3 2021, 3:55 PM

Mar 1 2021

royger committed R10:a2c0e94ccfaf: xen: remove x86-ism from Xen common code (authored by ehem_freebsd_m5p.com).
xen: remove x86-ism from Xen common code
Mar 1 2021, 12:34 PM
royger closed D28831: xen: remove x86-ism from Xen common code.
Mar 1 2021, 12:33 PM
royger added inline comments to D28982: xen: move common variables and code off of sys/x86/xen/hvm.c.
Mar 1 2021, 11:01 AM

Feb 23 2021

royger added a comment to D28831: xen: remove x86-ism from Xen common code.

Do you have a git repo I can pick this patch from? So that it has the proper Author field. Also in FreeBSD we tend to use the 'Sponsored by:' tag to credit the company that paid for the work (if any):

Feb 23 2021, 3:56 PM
royger accepted D28831: xen: remove x86-ism from Xen common code.
Feb 23 2021, 3:49 PM
royger added a comment to D28849: loader: use display pixel density for font autoselection.

Don't really have much knowledge in this area to provide a meaningful review I'm afraid.

Feb 23 2021, 3:45 PM
royger committed R10:0eaa97f0e862: stand/multiboot2: fix header length check (authored by royger).
stand/multiboot2: fix header length check
Feb 23 2021, 3:08 PM