Page MenuHomeFreeBSD

royger (Roger Pau Monné)
User

Projects

User Details

User Since
May 18 2014, 2:32 AM (257 w, 1 d)

Recent Activity

Mar 15 2019

royger committed rP495786: sysutils/xen-tools: add QEMU migration fix.
sysutils/xen-tools: add QEMU migration fix
Mar 15 2019, 12:38 PM
royger closed D19591: sysutils/xen-tools: add QEMU migration fix.
Mar 15 2019, 12:38 PM
royger added a comment to D19591: sysutils/xen-tools: add QEMU migration fix.

Shouldn't this patch be added to EXTRA_PATCHES?

Mar 15 2019, 11:51 AM
royger updated the diff for D19592: sysutils/xen-tools: remove docs option.
  • Use a explicit target to only build man pages, instead of using the generic docs target and expecting only the man pages to be built.
  • Remove the markdown dependency, the html files can be easily fetched from https://xenbits.xen.org/docs/.
Mar 15 2019, 11:45 AM
royger added a comment to D19592: sysutils/xen-tools: remove docs option.
In D19592#419471, @mat wrote:

What happened to all the html files in DOCSDIR?

Mar 15 2019, 11:26 AM
royger updated the summary of D19592: sysutils/xen-tools: remove docs option.
Mar 15 2019, 10:22 AM
royger created D19592: sysutils/xen-tools: remove docs option.
Mar 15 2019, 10:20 AM
royger created D19591: sysutils/xen-tools: add QEMU migration fix.
Mar 15 2019, 10:01 AM

Mar 13 2019

royger added a comment to D19521: sysutils/xen-tools: fix plist when DOCS option is disabled.
In D19521#418756, @mat wrote:

The manpages should not be behind the DOCS option, they should either always be installed, or be behind a MANPAGES option (that defaults to on).

Mar 13 2019, 3:01 PM

Mar 12 2019

royger committed rP495458: emulators/xen-kernel: backport fixes and apply XSAs.
emulators/xen-kernel: backport fixes and apply XSAs
Mar 12 2019, 3:02 PM
royger closed D19413: emulators/xen-kernel: backport fixes.
Mar 12 2019, 3:02 PM
royger added a comment to D19521: sysutils/xen-tools: fix plist when DOCS option is disabled.

Forgot to ask but can you commit this?

Mar 12 2019, 2:56 PM
royger updated the diff for D19413: emulators/xen-kernel: backport fixes.

Update to add patches for XSA-{284,287,290,292-294}

Mar 12 2019, 11:38 AM

Mar 11 2019

royger accepted D19521: sysutils/xen-tools: fix plist when DOCS option is disabled.

LGTM, thanks!

Mar 11 2019, 4:31 PM
royger added a comment to D19413: emulators/xen-kernel: backport fixes.

Ping?

Mar 11 2019, 4:31 PM

Mar 1 2019

royger updated the diff for D19413: emulators/xen-kernel: backport fixes.

Add a couple more of backported fixes that should improve the
user-experience, ie: prevent Xen from crashing or deadlocking.

Mar 1 2019, 5:27 PM
royger retitled D19413: emulators/xen-kernel: backport fixes from emulators/xen-kernel: fix for dom0 lapic EOIs Backport a patch to correctly forward dom0 lapic EOIs to the underlying lapic when required. to emulators/xen-kernel: backport fixes.
Mar 1 2019, 5:25 PM
royger created D19413: emulators/xen-kernel: backport fixes.
Mar 1 2019, 8:24 AM

Feb 27 2019

royger committed rP494055: xen-kernel & xen-tools: fix ignore message.
xen-kernel & xen-tools: fix ignore message
Feb 27 2019, 2:01 PM
royger closed D19387: xen-kernel & xen-tools: fix ignore message.
Feb 27 2019, 2:01 PM
royger created D19387: xen-kernel & xen-tools: fix ignore message.
Feb 27 2019, 1:32 PM
royger committed rP494043: emulators/xen-kernel & sysutils/xen-tools: update to 4.11.1.
emulators/xen-kernel & sysutils/xen-tools: update to 4.11.1
Feb 27 2019, 10:03 AM
royger closed D19293: emulators/xen-kernel & sysutils/xen-tools: update to 4.11.1.
Feb 27 2019, 10:03 AM
royger committed rP494040: emulators/xen-kernel411 & sysutils/xen-tools411: drop version number from port.
emulators/xen-kernel411 & sysutils/xen-tools411: drop version number from port
Feb 27 2019, 9:45 AM
royger committed rP494039: emulators/xen-kernel411 & sysutils/xen-tools411: drop version number from port.
emulators/xen-kernel411 & sysutils/xen-tools411: drop version number from port
Feb 27 2019, 9:40 AM
royger closed D19284: emulators/xen-kernel411: drop version number from port.
Feb 27 2019, 9:40 AM
royger closed D19283: emulators/xen-kernel47: deprecate.
Feb 27 2019, 9:36 AM
royger committed rP494037: emulators/xen-kernel47 & sysutils/xen-tools47: deprecate.
emulators/xen-kernel47 & sysutils/xen-tools47: deprecate
Feb 27 2019, 9:36 AM

Feb 22 2019

royger added a comment to D19294: handbook/xen: minor fixes.

Thank you very much for reviewing them! No rush to commit.

Feb 22 2019, 2:52 PM
royger set the repository for D19294: handbook/xen: minor fixes to rD FreeBSD doc repository.
Feb 22 2019, 11:40 AM
royger created D19294: handbook/xen: minor fixes.
Feb 22 2019, 11:39 AM
royger created D19293: emulators/xen-kernel & sysutils/xen-tools: update to 4.11.1.
Feb 22 2019, 9:58 AM
royger updated the diff for D19284: emulators/xen-kernel411: drop version number from port.

Remove previous MOVED entry.

Feb 22 2019, 9:55 AM

Feb 21 2019

royger added a comment to D19284: emulators/xen-kernel411: drop version number from port.

Thanks, I'm afraid this is kind of messy however. There was a previous line on the MOVED file from the xen-{kernel/tools} -> xen-{kernel/tools}-47, and now poudriere tells me:

# poudriere testport -o emulators/xen-kernel -j 130-20190207-amd64 -p local -J 16
[00:00:00] Creating the reference jail... done
[00:00:01] Warning: !!! Jail is newer than host. (Jail: 1300010, Host: 1300008) !!!
[00:00:01] Warning: This is not supported.
[00:00:01] Warning: Host kernel must be same or newer than jail.
[00:00:01] Warning: Expect build failures.
[00:00:02] Mounting system devices for 130-20190207-amd64-local
[00:00:02] Mounting ports/packages/distfiles
[00:00:02] Stashing existing package repository
[00:00:02] Mounting packages from: /usr/local/poudriere/data/packages/130-20190207-amd64-local
[00:00:02] Copying /var/db/ports from: /usr/local/etc/poudriere.d/130-20190207-amd64-local-options
/etc/resolv.conf -> /usr/local/poudriere/data/.m/130-20190207-amd64-local/ref/etc/resolv.conf
[00:00:03] Starting jail 130-20190207-amd64-local
[00:00:06] Ports supports: FLAVORS SELECTED_OPTIONS
[00:00:06] MOVED: emulators/xen-kernel moved to emulators/xen-kernel47
[...]

Is this fine?

Feb 21 2019, 5:48 PM
royger updated the diff for D19284: emulators/xen-kernel411: drop version number from port.

Fix package suffix

Feb 21 2019, 5:30 PM
royger created D19284: emulators/xen-kernel411: drop version number from port.
Feb 21 2019, 4:03 PM
royger created D19283: emulators/xen-kernel47: deprecate.
Feb 21 2019, 4:02 PM

Feb 13 2019

royger committed rP492838: xen-tools411: add optional SPICE support.
xen-tools411: add optional SPICE support
Feb 13 2019, 9:44 AM

Feb 11 2019

royger added a comment to D19107: xen: add troubleshooting section.

If it's not too much hassle please commit it :)

Feb 11 2019, 5:59 PM
royger committed rP492704: xen-kernel411: use an explicit build-only target in do-build.
xen-kernel411: use an explicit build-only target in do-build
Feb 11 2019, 5:38 PM
royger updated the diff for D19107: xen: add troubleshooting section.

Apply requested fixes, run igor.

Feb 11 2019, 11:11 AM
royger updated the diff for D19106: xen: miscellaneous fixes to the documentation.

Apply requested fixes, run igor.

Feb 11 2019, 11:11 AM
royger added a comment to D19106: xen: miscellaneous fixes to the documentation.

Thanks, all fixed :).

Feb 11 2019, 11:10 AM
royger added a comment to D19107: xen: add troubleshooting section.

Thanks, new version coming.

Feb 11 2019, 11:10 AM

Feb 7 2019

royger created D19107: xen: add troubleshooting section.
Feb 7 2019, 3:23 PM
royger created D19106: xen: miscellaneous fixes to the documentation.
Feb 7 2019, 3:22 PM

Jan 30 2019

royger committed rS343573: xen: introduce a new way to setup event channel upcall.
xen: introduce a new way to setup event channel upcall
Jan 30 2019, 11:35 AM

Nov 26 2018

royger committed rS340982: MFC r338628: xen: limit the usage of PIRQs to a legacy PVH Dom0.
MFC r338628: xen: limit the usage of PIRQs to a legacy PVH Dom0
Nov 26 2018, 4:54 PM

Nov 20 2018

royger committed rP485430: xen: add XSA patches.
xen: add XSA patches
Nov 20 2018, 2:17 PM

Nov 14 2018

royger accepted D17977: Convert the number of MSI IRQs on x86 from a constant to a tunable..

I plan to get rid of the Xen specific MSI implementation soon.

Nov 14 2018, 4:49 PM

Oct 31 2018

royger committed rP483559: xen: add XSA-278 fix.
xen: add XSA-278 fix
Oct 31 2018, 8:35 AM

Oct 10 2018

royger accepted D17487: Provide string functions for use before ifuncs get resolved..

Thanks, this allows to fix the Xen boot issue. Would you mind including the following diff into your patch?

Oct 10 2018, 7:31 AM

Sep 13 2018

royger committed rS338632: xen: temporary disable SMAP when forwarding hypercalls from user-space.
xen: temporary disable SMAP when forwarding hypercalls from user-space
Sep 13 2018, 7:15 AM
royger committed rS338631: xen: legacy PVH fixes for the new interrupt count.
xen: legacy PVH fixes for the new interrupt count
Sep 13 2018, 7:14 AM
royger closed D17015: lapic: skip setting intrcnt if lapic is not present.
Sep 13 2018, 7:13 AM
royger committed rS338630: lapic: skip setting intrcnt if lapic is not present.
lapic: skip setting intrcnt if lapic is not present
Sep 13 2018, 7:13 AM
royger committed rS338629: xen: fix setting legacy PVH vcpu id.
xen: fix setting legacy PVH vcpu id
Sep 13 2018, 7:12 AM
royger committed rS338628: xen: limit the usage of PIRQs to a legacy PVH Dom0.
xen: limit the usage of PIRQs to a legacy PVH Dom0
Sep 13 2018, 7:11 AM
royger committed rS338627: xen: fix initial kenv setup for legacy PVH.
xen: fix initial kenv setup for legacy PVH
Sep 13 2018, 7:10 AM
royger committed rS338626: xen: remove xenpv_set_ids.
xen: remove xenpv_set_ids
Sep 13 2018, 7:08 AM
royger committed rS338625: xen: fix PV IPI setup.
xen: fix PV IPI setup
Sep 13 2018, 7:07 AM
royger closed D17013: xen: fix setting vcpu id for APs.
Sep 13 2018, 7:07 AM
royger committed rS338624: msi: remove the check that interrupt sources have been added.
msi: remove the check that interrupt sources have been added
Sep 13 2018, 7:06 AM
royger closed D17001: msi: remove the check that interrupt sources have been added.
Sep 13 2018, 7:06 AM
royger committed rS338623: x86bios: use M_NOWAIT with mallocs.
x86bios: use M_NOWAIT with mallocs
Sep 13 2018, 7:04 AM
royger closed D17000: x86bios: use M_NOWAIT with mallocs.
Sep 13 2018, 7:04 AM

Sep 10 2018

royger committed rP479377: xen-tools411: re-add markdown.
xen-tools411: re-add markdown
Sep 10 2018, 9:10 AM

Sep 6 2018

royger updated the diff for D17013: xen: fix setting vcpu id for APs.
  • Bind PV IPI event channels once vcpu_id is set.
Sep 6 2018, 1:56 PM
royger committed rP479027: xen-tools411: remove markdown and pandoc DOCS dependency.
xen-tools411: remove markdown and pandoc DOCS dependency
Sep 6 2018, 12:30 PM
royger added inline comments to D17013: xen: fix setting vcpu id for APs.
Sep 6 2018, 12:25 PM
royger added a comment to D17013: xen: fix setting vcpu id for APs.

I wonder, can we make this work by changing the lines

PCPU_SET(vcpu_id, (regs[0] & XEN_HVM_CPUID_VCPU_ID_PRESENT) ?
       regs[1] : PCPU_GET(acpi_id));

in xen_hvm_cpu_init to

PCPU_SET(vcpu_id, (regs[0] & XEN_HVM_CPUID_VCPU_ID_PRESENT) ?
       regs[1] : -1);

and then resurrecting xen_set_vcpu_id but having it only set vcpu_id if it is currently set to -1?
That way if we have XEN_HVM_CPUID_VCPU_ID_PRESENT we'll get vcpu_id from there (and it doesn't matter if that runs before acpi_id is set) and if we don't then we'll fill in the right value slightly later (after acpi_id is set, but we don't need to be running on the AP in question at that point).

Sep 6 2018, 12:25 PM

Sep 5 2018

royger added inline comments to D17015: lapic: skip setting intrcnt if lapic is not present.
Sep 5 2018, 9:04 AM
royger added a comment to D17001: msi: remove the check that interrupt sources have been added.
In D17001#362843, @jhb wrote:
In D17001#362583, @kib wrote:

Would be useful to assert that there is no IO APICs or AT PICs configured when num_io_irqs == 0, but I am not sure that this is straightforward.

I thought about this too, but I didn't find any straightforward way to check whether there are any PICs in the system. I will wait for John in case he has a suggestion.

There isn't a good way to assert that. The ATPIC code always assumes it can use the first 16 IRQs if 'device atpic' is enabled in the kernel which is a bit of a landmine. 'device atpic' isn't in GENERIC, but it might be nice to force it to be disabled for this particular Xen case? Or is there an emulated ATPIC with no useful interrupts? (In a kernel without 'device atpic' we use unconditional logic to init the 8259A's into a silent state.) If Xen is still providing a dummy set of 8259A's, then I think what I'd actually prefer is to patch the SYSINIT in local_apic.c that does 'apic_setup_io' to bump num_io_irqs up to 16 if it is still zero to avoid any possible conflicts with IRQs 0 - 15. Note that one idea I'm considering is removing MINIMUM_MSI_INT post-branch so that MSI IRQs would start at the end of the PIC range rather than at 256 in which case explicitly reserving 0-15 would still matter.

Sep 5 2018, 8:58 AM
royger updated the diff for D17013: xen: fix setting vcpu id for APs.
  • Remove xenpv_set_ids.
  • Make sure acpi_id is set when starting APs.
Sep 5 2018, 7:26 AM

Sep 4 2018

royger created D17015: lapic: skip setting intrcnt if lapic is not present.
Sep 4 2018, 3:13 PM
royger created D17013: xen: fix setting vcpu id for APs.
Sep 4 2018, 2:55 PM

Sep 3 2018

royger added a comment to D17001: msi: remove the check that interrupt sources have been added.
In D17001#362583, @kib wrote:

Would be useful to assert that there is no IO APICs or AT PICs configured when num_io_irqs == 0, but I am not sure that this is straightforward.

Sep 3 2018, 10:39 AM
royger added a comment to D17000: x86bios: use M_NOWAIT with mallocs.
In D17000#362586, @kib wrote:

They are not too large, what I see is: "contigmalloc - size: 0x1000 low: 0x1000 high: 0xa0000", which should be fulfillable. I guess there's something else that allocates this memory, but I have no idea of what yet. This is probably a glitch of running as a PVH guest, which has no BIOS and no reserved regions < 1MB.

Ah so it is low memory. Does it make sense to init bios at all, on such machine ?

Sep 3 2018, 10:26 AM
royger updated the diff for D17000: x86bios: use M_NOWAIT with mallocs.
  • Add newline at the start of x86bios_unmap_mem.
  • Use consistent order for the flags.
Sep 3 2018, 10:20 AM
royger added a comment to D17000: x86bios: use M_NOWAIT with mallocs.
In D17000#362579, @kib wrote:

This is in fact worrying. How large are these requests ? If they cannot be satisfied at the early boot stage, then they cannot be at all, I think.

Sep 3 2018, 10:15 AM
royger created D17001: msi: remove the check that interrupt sources have been added.
Sep 3 2018, 9:25 AM
royger created D17000: x86bios: use M_NOWAIT with mallocs.
Sep 3 2018, 9:13 AM

Aug 24 2018

royger updated the test plan for D16881: Remove {max/min}_offset, use vm_map_{max/min}..
Aug 24 2018, 4:17 PM
royger added a comment to D16881: Remove {max/min}_offset, use vm_map_{max/min}..

I'm going on vacations for the whole next week and I'm not taking any computer, so I won't be able to commit this. If someone feels like picking this up in the meantime that's great, if not I will pick it up in two weeks.

Aug 24 2018, 4:16 PM
royger updated the diff for D16881: Remove {max/min}_offset, use vm_map_{max/min}..

Remove unrelated netfront change.

Aug 24 2018, 3:34 PM
royger created D16881: Remove {max/min}_offset, use vm_map_{max/min}..
Aug 24 2018, 3:32 PM
royger accepted D16861: Dynamically allocate IRQ ranges on x86..

Tested with Xen on amd64, no issues. Thanks.

Aug 24 2018, 11:22 AM
royger committed rP477953: xen-tools411: build a working hvmloader.
xen-tools411: build a working hvmloader
Aug 24 2018, 10:10 AM

Aug 23 2018

royger added a comment to D16861: Dynamically allocate IRQ ranges on x86..

The following diff on top of your patch seem to fix the issue:

diff --git a/sys/x86/xen/xen_intr.c b/sys/x86/xen/xen_intr.c
index 4b64ac36b774..c7328ad71e27 100644
--- a/sys/x86/xen/xen_intr.c
+++ b/sys/x86/xen/xen_intr.c
@@ -634,17 +634,13 @@ xen_intr_init(void *dummy __unused)
 	mtx_init(&xen_intr_isrc_lock, "xen-irq-lock", NULL, MTX_DEF);
Aug 23 2018, 2:29 PM
royger added a comment to D16861: Dynamically allocate IRQ ranges on x86..

This panics quite early with the following trace:

/boot/kernel/kernel text=0x167caa8 data=0x1cdac8+0x79c1f0 syms=[0x8+0x1803c0+0x8+0x19cd3e]
/boot/entropy size=0x1000
Booting...
GDB: no debug ports present
KDB: debugger backends: ddb
KDB: current backend: ddb
---<<BOOT>>---
Copyright (c) 1992-2018 The FreeBSD Project.
Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
	The Regents of the University of California. All rights reserved.
FreeBSD is a registered trademark of The FreeBSD Foundation.
FreeBSD 12.0-ALPHA2 #0 d016733ea(master)-dirty: Thu Aug 23 13:55:07 UTC 2018
    root@freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64
FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based on LLVM 6.0.1)
WARNING: WITNESS option enabled, expect reduced performance.
VT(vga): text 80x25
XEN: Hypervisor version 4.12 detected.
CPU: Intel(R) Xeon(R) CPU E3-1230 v6 @ 3.50GHz (3504.12-MHz K8-class CPU)
  Origin="GenuineIntel"  Id=0x906e9  Family=0x6  Model=0x9e  Stepping=9
  Features=0x1fc3fbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT>
  Features2=0xfffa3203<SSE3,PCLMULQDQ,SSSE3,FMA,CX16,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,TSCDLT,AESNI,XSAVE,OSXSAVE,AVX,F16C,RDRAND,HV>
  AMD Features=0x2c100800<SYSCALL,NX,Page1GB,RDTSCP,LM>
  AMD Features2=0x121<LAHF,ABM,Prefetch>
  Structured Extended Features=0x1c6fbb<FSGSBASE,TSCADJ,BMI1,HLE,AVX2,SMEP,BMI2,ERMS,INVPCID,RTM,NFPUSG,MPX,RDSEED,ADX,SMAP>
  Structured Extended Features3=0xc000000<IBPB,STIBP>
  XSAVE Features=0xf<XSAVEOPT,XSAVEC,XINUSE,XSAVES>
  AMD Extended Feature Extensions ID EBX=0x1000
Hypervisor: Origin = "XenVMMXenVMM"
real memory  = 16768827392 (15992 MB)
avail memory = 16202080256 (15451 MB)
Event timer "LAPIC" quality 100
ACPI APIC Table: <Xen HVM>
WARNING: L1 data cache covers fewer APIC IDs than a core (0 < 1)
WARNING: L2 data cache covers fewer APIC IDs than a core (0 < 1)
WARNING: L3 data cache covers fewer APIC IDs than a core (0 < 1)
FreeBSD/SMP: Multiprocessor System Detected: 8 CPUs
FreeBSD/SMP: 1 package(s) x 8 cache groups x 1 core(s)
random: unblocking device.
panic: Assertion intrcnt_index < nintrcnt failed at /usr/src/sys/x86/x86/intr_machdep.c:468
cpuid = 0
time = 1
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xffffffff82696900
vpanic() at vpanic+0x1a3/frame 0xffffffff82696960
panic() at panic+0x43/frame 0xffffffff826969c0
intrcnt_add() at intrcnt_add+0xc1/frame 0xffffffff826969e0
xen_intr_init() at xen_intr_init+0xd0/frame 0xffffffff82696a50
mi_startup() at mi_startup+0x118/frame 0xffffffff82696a70
btext() at btext+0x2c
KDB: enter: panic
[ thread pid 0 tid 100000 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db>
Aug 23 2018, 1:58 PM

Aug 17 2018

royger committed rP477433: xen-tools411: fix pkg-plist.
xen-tools411: fix pkg-plist
Aug 17 2018, 3:03 PM
royger committed rS337960: build: skip the database check when generating install media.
build: skip the database check when generating install media
Aug 17 2018, 7:27 AM
royger closed D16638: build: skip the database check when generating install media.
Aug 17 2018, 7:27 AM

Aug 16 2018

royger committed rP477316: xen411: apply fixes for XSA-269, XSA-272 and XSA-273.
xen411: apply fixes for XSA-269, XSA-272 and XSA-273
Aug 16 2018, 9:02 AM
royger added a comment to D16638: build: skip the database check when generating install media.

Ping?

Aug 16 2018, 7:24 AM

Aug 14 2018

royger committed rP477143: xen-tools411: bump port version after r477080..
xen-tools411: bump port version after r477080.
Aug 14 2018, 9:03 AM

Aug 13 2018

royger committed rP477080: xen-tools411: use HAS_CONFIGURE instead of GNU_CONFIGURE.
xen-tools411: use HAS_CONFIGURE instead of GNU_CONFIGURE
Aug 13 2018, 5:16 PM

Aug 9 2018

royger added a reviewer for D16638: build: skip the database check when generating install media: emaste.
Aug 9 2018, 9:42 AM
royger created D16638: build: skip the database check when generating install media.
Aug 9 2018, 8:40 AM

Aug 8 2018

royger added a comment to D16507: build: skip the database check for the distributeworld target.

So it seems there are still issues even after this fix, now I'm seeing:

Aug 8 2018, 2:15 PM