Page MenuHomeFreeBSD

royger (Roger Pau Monné)
User

Projects

User Details

User Since
May 18 2014, 2:32 AM (274 w, 5 d)

Recent Activity

Tue, Aug 13

royger committed rP508824: xen-{tools/kernel}: update to 4.12.1.
xen-{tools/kernel}: update to 4.12.1
Tue, Aug 13, 1:40 PM
royger closed D21227: xen-{tools/kernel}: update to 4.12.1.
Tue, Aug 13, 1:40 PM

Mon, Aug 12

royger created D21227: xen-{tools/kernel}: update to 4.12.1.
Mon, Aug 12, 2:14 PM

Mon, Jul 29

royger closed D21028: emulators/xen-kernel: fix foreign mappings.
Mon, Jul 29, 2:59 PM
royger committed rP507571: emulators/xen-kernel: fix foreign mappings.
emulators/xen-kernel: fix foreign mappings
Mon, Jul 29, 2:59 PM
royger added a comment to D21028: emulators/xen-kernel: fix foreign mappings.

tyvm!

Mon, Jul 29, 2:58 PM
royger added a comment to D21028: emulators/xen-kernel: fix foreign mappings.

Hello, can I please get this approved?

Mon, Jul 29, 10:44 AM

Fri, Jul 26

royger added a comment to D21028: emulators/xen-kernel: fix foreign mappings.

Ping? This is an almost trivial change, since it's a straight backport from an upstream commit.

Fri, Jul 26, 8:13 AM

Jul 22 2019

royger created D21028: emulators/xen-kernel: fix foreign mappings.
Jul 22 2019, 4:25 PM

Jul 3 2019

royger committed rP505754: xen-{kernel/tools}: switch back to LLVM toolchain.
xen-{kernel/tools}: switch back to LLVM toolchain
Jul 3 2019, 2:25 PM
royger closed D20816: xen-{kernel/tools}: switch back to LLVM toolchain.
Jul 3 2019, 2:25 PM

Jul 1 2019

royger retitled D20816: xen-{kernel/tools}: switch back to LLVM toolchain from xen-{kernel/tools}: switch back to LLVM toolchain Backport upstream fixes to correctly build Xen using LLVM 8 toolchain. Note the fixes are not strictly needed for xen-tools since the Xen shim build is only ever supposed to be booted using the... to xen-{kernel/tools}: switch back to LLVM toolchain.
Jul 1 2019, 9:58 AM
royger created D20816: xen-{kernel/tools}: switch back to LLVM toolchain.
Jul 1 2019, 9:51 AM

Jun 28 2019

royger added a comment to D20770: arm64: Move "segments" array from bus_dma_tag to bus_dmamap..

Interestingly enough on arm and powerpc that array is stored as a part of dma map structure, so we might run into that anyway.
Anyway I agree with you that we need to have the same behavior across architectures.

Jun 28 2019, 2:08 PM
royger added a comment to D20770: arm64: Move "segments" array from bus_dma_tag to bus_dmamap..

Can you be more specific about the flow that can lead to overwrite the segs array?

Basically if you have a lot of threads doing DMA loads on the same tag concurrently there is a small chance of the segs array being overwritten before it is read in the callback.
It is a rare race, but reproducible.

Hm, I'm not sure I see how that's supposed to happen. busdma_swi already takes a lock (dmat->common.lockfunc) to prevent issuing multiple loads on the same tag, thus there should be no overwriting while the caller callback is using tag->segs?

Well, I'm not sure how dusdma_swi can help us in this case.
If you go through the flow starting at bus_dmamap_load, then going into bounce_bus_dmamap_load_buffer no lock is acquired there.

Right, the lock is only used for the deferred callback.
I think this is fine, but should be done for x86 also at least (that's where arm64 busdma code is coming from). This expected behaviour should also be mentioned on the busdma man page.
I think the general expectation of busdma code is that you serialize loads when using the same tag, but I cannot find an explicit reference to it on the man page, and IMO the locking section is too vague and doesn't explicitly say that you are not supposed to issue concurrent load calls using the same tag.

Ok, so as you said we have two ways to proceed from here:

  1. Modify the manual to explicitly require the user to serialize all loads on the same tag.

Do we know if all existing drivers follow that rule?

  1. Move the segmets array on all architectures.

I could prepare the patch, but frankly I don't feel competent enough to make such design decision.

Jun 28 2019, 1:31 PM

Jun 27 2019

royger added a comment to D20770: arm64: Move "segments" array from bus_dma_tag to bus_dmamap..

Can you be more specific about the flow that can lead to overwrite the segs array?

Basically if you have a lot of threads doing DMA loads on the same tag concurrently there is a small chance of the segs array being overwritten before it is read in the callback.
It is a rare race, but reproducible.

Hm, I'm not sure I see how that's supposed to happen. busdma_swi already takes a lock (dmat->common.lockfunc) to prevent issuing multiple loads on the same tag, thus there should be no overwriting while the caller callback is using tag->segs?

Well, I'm not sure how dusdma_swi can help us in this case.
If you go through the flow starting at bus_dmamap_load, then going into bounce_bus_dmamap_load_buffer no lock is acquired there.

Jun 27 2019, 2:55 PM

Jun 26 2019

royger added a comment to D20770: arm64: Move "segments" array from bus_dma_tag to bus_dmamap..

Can you be more specific about the flow that can lead to overwrite the segs array?

Basically if you have a lot of threads doing DMA loads on the same tag concurrently there is a small chance of the segs array being overwritten before it is read in the callback.
It is a rare race, but reproducible.

Jun 26 2019, 3:37 PM
royger added a comment to D20770: arm64: Move "segments" array from bus_dma_tag to bus_dmamap..

I'm not sure I understand the motivation behind that change, is this fixing an existing issue with a specific driver?

Jun 26 2019, 2:43 PM

Jun 20 2019

royger committed rP504632: emulators/xen-kernel: use binutils to workaround LLD 8 bug.
emulators/xen-kernel: use binutils to workaround LLD 8 bug
Jun 20 2019, 3:25 PM
royger closed D20706: emulators/xen-kernel: use binutils to workaround LLD 8 bug.
Jun 20 2019, 3:25 PM
royger created D20706: emulators/xen-kernel: use binutils to workaround LLD 8 bug.
Jun 20 2019, 9:26 AM

May 15 2019

royger committed rP501706: xen: add fixes for XSA-297 (MDS).
xen: add fixes for XSA-297 (MDS)
May 15 2019, 10:25 AM
royger closed D20265: xen: add fixes for XSA-297 (MDS).
May 15 2019, 10:25 AM
royger added a comment to D20265: xen: add fixes for XSA-297 (MDS).

Fixed in the new version, thanks!

May 15 2019, 9:53 AM
royger updated the diff for D20265: xen: add fixes for XSA-297 (MDS).

s/FILESDIR/PATCHDIR/

May 15 2019, 9:52 AM
royger created D20265: xen: add fixes for XSA-297 (MDS).
May 15 2019, 8:14 AM

May 6 2019

royger committed rS347183: geom: fix initialization order.
geom: fix initialization order
May 6 2019, 9:48 AM
royger closed D20148: geom: fix initialization order.
May 6 2019, 9:48 AM

May 3 2019

royger added a comment to D20148: geom: fix initialization order.

I suspect you'll need to bump some g_raid parts as well- it has modules declared at SI_SUB_DRIVERS/SI_ORDER_{FIRST,SECOND,THIRD} that I suspect could/should be bumped to SECOND/THIRD/FOURTH -- but I haven't had time to dig into it and examine the dependencies there.

May 3 2019, 2:31 PM
royger created D20148: geom: fix initialization order.
May 3 2019, 2:13 PM

Apr 24 2019

royger committed rP499848: xen: update to 4.12.
xen: update to 4.12
Apr 24 2019, 2:21 PM
royger closed D20038: xen: update to 4.12.
Apr 24 2019, 2:21 PM
royger created D20038: xen: update to 4.12.
Apr 24 2019, 9:18 AM

Mar 15 2019

royger committed rP495786: sysutils/xen-tools: add QEMU migration fix.
sysutils/xen-tools: add QEMU migration fix
Mar 15 2019, 12:38 PM
royger closed D19591: sysutils/xen-tools: add QEMU migration fix.
Mar 15 2019, 12:38 PM
royger added a comment to D19591: sysutils/xen-tools: add QEMU migration fix.

Shouldn't this patch be added to EXTRA_PATCHES?

Mar 15 2019, 11:51 AM
royger updated the diff for D19592: sysutils/xen-tools: remove docs option.
  • Use a explicit target to only build man pages, instead of using the generic docs target and expecting only the man pages to be built.
  • Remove the markdown dependency, the html files can be easily fetched from https://xenbits.xen.org/docs/.
Mar 15 2019, 11:45 AM
royger added a comment to D19592: sysutils/xen-tools: remove docs option.
In D19592#419471, @mat wrote:

What happened to all the html files in DOCSDIR?

Mar 15 2019, 11:26 AM
royger updated the summary of D19592: sysutils/xen-tools: remove docs option.
Mar 15 2019, 10:22 AM
royger created D19592: sysutils/xen-tools: remove docs option.
Mar 15 2019, 10:20 AM
royger created D19591: sysutils/xen-tools: add QEMU migration fix.
Mar 15 2019, 10:01 AM

Mar 13 2019

royger added a comment to D19521: sysutils/xen-tools: fix plist when DOCS option is disabled.
In D19521#418756, @mat wrote:

The manpages should not be behind the DOCS option, they should either always be installed, or be behind a MANPAGES option (that defaults to on).

Mar 13 2019, 3:01 PM

Mar 12 2019

royger committed rP495458: emulators/xen-kernel: backport fixes and apply XSAs.
emulators/xen-kernel: backport fixes and apply XSAs
Mar 12 2019, 3:02 PM
royger closed D19413: emulators/xen-kernel: backport fixes.
Mar 12 2019, 3:02 PM
royger added a comment to D19521: sysutils/xen-tools: fix plist when DOCS option is disabled.

Forgot to ask but can you commit this?

Mar 12 2019, 2:56 PM
royger updated the diff for D19413: emulators/xen-kernel: backport fixes.

Update to add patches for XSA-{284,287,290,292-294}

Mar 12 2019, 11:38 AM

Mar 11 2019

royger accepted D19521: sysutils/xen-tools: fix plist when DOCS option is disabled.

LGTM, thanks!

Mar 11 2019, 4:31 PM
royger added a comment to D19413: emulators/xen-kernel: backport fixes.

Ping?

Mar 11 2019, 4:31 PM

Mar 1 2019

royger updated the diff for D19413: emulators/xen-kernel: backport fixes.

Add a couple more of backported fixes that should improve the
user-experience, ie: prevent Xen from crashing or deadlocking.

Mar 1 2019, 5:27 PM
royger retitled D19413: emulators/xen-kernel: backport fixes from emulators/xen-kernel: fix for dom0 lapic EOIs Backport a patch to correctly forward dom0 lapic EOIs to the underlying lapic when required. to emulators/xen-kernel: backport fixes.
Mar 1 2019, 5:25 PM
royger created D19413: emulators/xen-kernel: backport fixes.
Mar 1 2019, 8:24 AM

Feb 27 2019

royger committed rP494055: xen-kernel & xen-tools: fix ignore message.
xen-kernel & xen-tools: fix ignore message
Feb 27 2019, 2:01 PM
royger closed D19387: xen-kernel & xen-tools: fix ignore message.
Feb 27 2019, 2:01 PM
royger created D19387: xen-kernel & xen-tools: fix ignore message.
Feb 27 2019, 1:32 PM
royger committed rP494043: emulators/xen-kernel & sysutils/xen-tools: update to 4.11.1.
emulators/xen-kernel & sysutils/xen-tools: update to 4.11.1
Feb 27 2019, 10:03 AM
royger closed D19293: emulators/xen-kernel & sysutils/xen-tools: update to 4.11.1.
Feb 27 2019, 10:03 AM
royger committed rP494040: emulators/xen-kernel411 & sysutils/xen-tools411: drop version number from port.
emulators/xen-kernel411 & sysutils/xen-tools411: drop version number from port
Feb 27 2019, 9:45 AM
royger committed rP494039: emulators/xen-kernel411 & sysutils/xen-tools411: drop version number from port.
emulators/xen-kernel411 & sysutils/xen-tools411: drop version number from port
Feb 27 2019, 9:40 AM
royger closed D19284: emulators/xen-kernel411: drop version number from port.
Feb 27 2019, 9:40 AM
royger closed D19283: emulators/xen-kernel47: deprecate.
Feb 27 2019, 9:36 AM
royger committed rP494037: emulators/xen-kernel47 & sysutils/xen-tools47: deprecate.
emulators/xen-kernel47 & sysutils/xen-tools47: deprecate
Feb 27 2019, 9:36 AM

Feb 22 2019

royger added a comment to D19294: handbook/xen: minor fixes.

Thank you very much for reviewing them! No rush to commit.

Feb 22 2019, 2:52 PM
royger set the repository for D19294: handbook/xen: minor fixes to rD FreeBSD doc repository.
Feb 22 2019, 11:40 AM
royger created D19294: handbook/xen: minor fixes.
Feb 22 2019, 11:39 AM
royger created D19293: emulators/xen-kernel & sysutils/xen-tools: update to 4.11.1.
Feb 22 2019, 9:58 AM
royger updated the diff for D19284: emulators/xen-kernel411: drop version number from port.

Remove previous MOVED entry.

Feb 22 2019, 9:55 AM

Feb 21 2019

royger added a comment to D19284: emulators/xen-kernel411: drop version number from port.

Thanks, I'm afraid this is kind of messy however. There was a previous line on the MOVED file from the xen-{kernel/tools} -> xen-{kernel/tools}-47, and now poudriere tells me:

# poudriere testport -o emulators/xen-kernel -j 130-20190207-amd64 -p local -J 16
[00:00:00] Creating the reference jail... done
[00:00:01] Warning: !!! Jail is newer than host. (Jail: 1300010, Host: 1300008) !!!
[00:00:01] Warning: This is not supported.
[00:00:01] Warning: Host kernel must be same or newer than jail.
[00:00:01] Warning: Expect build failures.
[00:00:02] Mounting system devices for 130-20190207-amd64-local
[00:00:02] Mounting ports/packages/distfiles
[00:00:02] Stashing existing package repository
[00:00:02] Mounting packages from: /usr/local/poudriere/data/packages/130-20190207-amd64-local
[00:00:02] Copying /var/db/ports from: /usr/local/etc/poudriere.d/130-20190207-amd64-local-options
/etc/resolv.conf -> /usr/local/poudriere/data/.m/130-20190207-amd64-local/ref/etc/resolv.conf
[00:00:03] Starting jail 130-20190207-amd64-local
[00:00:06] Ports supports: FLAVORS SELECTED_OPTIONS
[00:00:06] MOVED: emulators/xen-kernel moved to emulators/xen-kernel47
[...]

Is this fine?

Feb 21 2019, 5:48 PM
royger updated the diff for D19284: emulators/xen-kernel411: drop version number from port.

Fix package suffix

Feb 21 2019, 5:30 PM
royger created D19284: emulators/xen-kernel411: drop version number from port.
Feb 21 2019, 4:03 PM
royger created D19283: emulators/xen-kernel47: deprecate.
Feb 21 2019, 4:02 PM

Feb 13 2019

royger committed rP492838: xen-tools411: add optional SPICE support.
xen-tools411: add optional SPICE support
Feb 13 2019, 9:44 AM

Feb 11 2019

royger added a comment to D19107: xen: add troubleshooting section.

If it's not too much hassle please commit it :)

Feb 11 2019, 5:59 PM
royger committed rP492704: xen-kernel411: use an explicit build-only target in do-build.
xen-kernel411: use an explicit build-only target in do-build
Feb 11 2019, 5:38 PM
royger updated the diff for D19107: xen: add troubleshooting section.

Apply requested fixes, run igor.

Feb 11 2019, 11:11 AM
royger updated the diff for D19106: xen: miscellaneous fixes to the documentation.

Apply requested fixes, run igor.

Feb 11 2019, 11:11 AM
royger added a comment to D19106: xen: miscellaneous fixes to the documentation.

Thanks, all fixed :).

Feb 11 2019, 11:10 AM
royger added a comment to D19107: xen: add troubleshooting section.

Thanks, new version coming.

Feb 11 2019, 11:10 AM

Feb 7 2019

royger created D19107: xen: add troubleshooting section.
Feb 7 2019, 3:23 PM
royger created D19106: xen: miscellaneous fixes to the documentation.
Feb 7 2019, 3:22 PM

Jan 30 2019

royger committed rS343573: xen: introduce a new way to setup event channel upcall.
xen: introduce a new way to setup event channel upcall
Jan 30 2019, 11:35 AM

Nov 26 2018

royger committed rS340982: MFC r338628: xen: limit the usage of PIRQs to a legacy PVH Dom0.
MFC r338628: xen: limit the usage of PIRQs to a legacy PVH Dom0
Nov 26 2018, 4:54 PM

Nov 20 2018

royger committed rP485430: xen: add XSA patches.
xen: add XSA patches
Nov 20 2018, 2:17 PM

Nov 14 2018

royger accepted D17977: Convert the number of MSI IRQs on x86 from a constant to a tunable..

I plan to get rid of the Xen specific MSI implementation soon.

Nov 14 2018, 4:49 PM

Oct 31 2018

royger committed rP483559: xen: add XSA-278 fix.
xen: add XSA-278 fix
Oct 31 2018, 8:35 AM

Oct 10 2018

royger accepted D17487: Provide string functions for use before ifuncs get resolved..

Thanks, this allows to fix the Xen boot issue. Would you mind including the following diff into your patch?

Oct 10 2018, 7:31 AM

Sep 13 2018

royger committed rS338632: xen: temporary disable SMAP when forwarding hypercalls from user-space.
xen: temporary disable SMAP when forwarding hypercalls from user-space
Sep 13 2018, 7:15 AM
royger committed rS338631: xen: legacy PVH fixes for the new interrupt count.
xen: legacy PVH fixes for the new interrupt count
Sep 13 2018, 7:14 AM
royger closed D17015: lapic: skip setting intrcnt if lapic is not present.
Sep 13 2018, 7:13 AM
royger committed rS338630: lapic: skip setting intrcnt if lapic is not present.
lapic: skip setting intrcnt if lapic is not present
Sep 13 2018, 7:13 AM
royger committed rS338629: xen: fix setting legacy PVH vcpu id.
xen: fix setting legacy PVH vcpu id
Sep 13 2018, 7:12 AM
royger committed rS338628: xen: limit the usage of PIRQs to a legacy PVH Dom0.
xen: limit the usage of PIRQs to a legacy PVH Dom0
Sep 13 2018, 7:11 AM
royger committed rS338627: xen: fix initial kenv setup for legacy PVH.
xen: fix initial kenv setup for legacy PVH
Sep 13 2018, 7:10 AM
royger committed rS338626: xen: remove xenpv_set_ids.
xen: remove xenpv_set_ids
Sep 13 2018, 7:08 AM
royger committed rS338625: xen: fix PV IPI setup.
xen: fix PV IPI setup
Sep 13 2018, 7:07 AM
royger closed D17013: xen: fix setting vcpu id for APs.
Sep 13 2018, 7:07 AM
royger committed rS338624: msi: remove the check that interrupt sources have been added.
msi: remove the check that interrupt sources have been added
Sep 13 2018, 7:06 AM
royger closed D17001: msi: remove the check that interrupt sources have been added.
Sep 13 2018, 7:06 AM
royger committed rS338623: x86bios: use M_NOWAIT with mallocs.
x86bios: use M_NOWAIT with mallocs
Sep 13 2018, 7:04 AM
royger closed D17000: x86bios: use M_NOWAIT with mallocs.
Sep 13 2018, 7:04 AM

Sep 10 2018

royger committed rP479377: xen-tools411: re-add markdown.
xen-tools411: re-add markdown
Sep 10 2018, 9:10 AM