Page MenuHomeFreeBSD

royger (Roger Pau Monné)
User

Projects

User Details

User Since
May 18 2014, 2:32 AM (355 w, 1 d)

Recent Activity

Thu, Mar 4

royger added a comment to D29042: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c.

Yeah, I've got no idea what-so-ever why one might feel xenpv.c should be
in a "bus" directory. No similarity to any type of bus. No devices
attached at all. Certainly not a bus.

Thu, Mar 4, 5:31 PM
royger added a comment to D29040: xen: move x86-specific xen_vector_callback_enabled to sys/x86.

Also, the 'Adapted-to-HEAD-by' tag is not really a standard tag, and doesn't mention the original author either. I would just add a line saying:

Thu, Mar 4, 9:11 AM
royger accepted D29040: xen: move x86-specific xen_vector_callback_enabled to sys/x86.

LGTM, we should make this a bool type also.

Thu, Mar 4, 9:06 AM
royger added a comment to D29041: xen/timer: make xen timer optional.

Some minor comments.

Thu, Mar 4, 9:02 AM
royger accepted D29043: xen/xenusb: always include xen/xen-os.h rather than machine/xen/xen-os.h.

LGTM.

Thu, Mar 4, 8:57 AM
royger added a comment to D29042: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c.

I would consider placing it in sys/dev/xen/bus/xenpv.c

Thu, Mar 4, 8:57 AM

Wed, Mar 3

royger committed rP567091: sysutils/xen-tools: remove markdown depenmdency.
sysutils/xen-tools: remove markdown depenmdency
Wed, Mar 3, 3:55 PM

Mon, Mar 1

royger committed R10:a2c0e94ccfaf: xen: remove x86-ism from Xen common code (authored by ehem_freebsd_m5p.com).
xen: remove x86-ism from Xen common code
Mon, Mar 1, 12:34 PM
royger closed D28831: xen: remove x86-ism from Xen common code.
Mon, Mar 1, 12:33 PM
royger added inline comments to D28982: xen: Break hypervisor_info off of sys/x86/xen/hvm.c.
Mon, Mar 1, 11:01 AM

Tue, Feb 23

royger added a comment to D28831: xen: remove x86-ism from Xen common code.

Do you have a git repo I can pick this patch from? So that it has the proper Author field. Also in FreeBSD we tend to use the 'Sponsored by:' tag to credit the company that paid for the work (if any):

Tue, Feb 23, 3:56 PM
royger accepted D28831: xen: remove x86-ism from Xen common code.
Tue, Feb 23, 3:49 PM
royger added a comment to D28849: loader: use display pixel density for font autoselection.

Don't really have much knowledge in this area to provide a meaningful review I'm afraid.

Tue, Feb 23, 3:45 PM
royger committed R10:0eaa97f0e862: stand/multiboot2: fix header length check (authored by royger).
stand/multiboot2: fix header length check
Tue, Feb 23, 3:08 PM
royger committed R10:ab379c15af6f: stand/multiboot2: fix error message format (authored by royger).
stand/multiboot2: fix error message format
Tue, Feb 23, 3:08 PM
royger added a comment to D28849: loader: use display pixel density for font autoselection.

Works for me, now the font seems fine on a 2160p monitor, and there's no black bar at the bottom of the screen.

Tue, Feb 23, 2:43 PM

Mon, Feb 22

royger committed R10:808d4aad1022: xen-blkback: fix leak of grant maps on ring setup failure (authored by royger).
xen-blkback: fix leak of grant maps on ring setup failure
Mon, Feb 22, 3:51 PM
royger added a comment to D28551: xendomains rc script for xen-tools to allow automatic guest start/stop.

I have some comments, could you please send this upstream to xen-devel against xen.git? I don't plan to carry custom rc.d scripts in the package. If you don't feel comfortable sending it yourself I can pick it up.

Mon, Feb 22, 9:50 AM

Fri, Feb 19

royger added a comment to D28693: prepare-commit-msg: add "Fixes:" .

The parentheses just seem to be making use of two of the 72 columns which we have until we need to add a newline.
Do we need them?

Fri, Feb 19, 8:34 AM

Tue, Feb 16

royger committed rP565411: emulators/xen-kernel: fix EFI calling convention.
emulators/xen-kernel: fix EFI calling convention
Tue, Feb 16, 4:03 PM
royger committed R10:97527e9c4fd3: bi_load: only add MODULEP on arches that have it defined (authored by royger).
bi_load: only add MODULEP on arches that have it defined
Tue, Feb 16, 3:15 PM
royger committed R10:952667da986c: xen/efi: introduce a PV interface for EFI run time services for dom0 (authored by royger).
xen/efi: introduce a PV interface for EFI run time services for dom0
Tue, Feb 16, 2:29 PM
royger committed R10:27d3902679cd: efirt: add hooks for diverging EFI implementations (authored by royger).
efirt: add hooks for diverging EFI implementations
Tue, Feb 16, 2:29 PM
royger closed D28620: efirt: add hooks for diverging EFI implementations.
Tue, Feb 16, 2:29 PM
royger closed D28621: xen/efi: introduce a PV interface for EFI run time services for dom0.
Tue, Feb 16, 2:29 PM
royger closed D28619: xen/boot: allow specifying boot method when booted from Xen.
Tue, Feb 16, 2:28 PM
royger committed R10:a2495c36678c: xen/boot: allow specifying boot method when booted from Xen (authored by royger).
xen/boot: allow specifying boot method when booted from Xen
Tue, Feb 16, 2:28 PM
royger closed D28497: stand/multiboot2: add support for booting a Xen dom0 in UEFI mode.
Tue, Feb 16, 2:28 PM
royger committed R10:adda2797eb2a: stand/multiboot2: add support for booting a Xen dom0 in UEFI mode (authored by royger).
stand/multiboot2: add support for booting a Xen dom0 in UEFI mode
Tue, Feb 16, 2:28 PM
royger closed D28496: stand/efi: add modulep to kernel metadata.
Tue, Feb 16, 2:28 PM
royger committed R10:7d3259775cb6: stand/efi: add modulep to kernel metadata (authored by royger).
stand/efi: add modulep to kernel metadata
Tue, Feb 16, 2:28 PM
royger closed D28495: stand/efi: allow not exiting boot services.
Tue, Feb 16, 2:27 PM
royger committed R10:ed87efbe24a5: stand/efi: allow not exiting boot services (authored by royger).
stand/efi: allow not exiting boot services
Tue, Feb 16, 2:27 PM
royger updated the diff for D28619: xen/boot: allow specifying boot method when booted from Xen.
  • Move bootmethod declaration to x86_var.h.
  • Remove extern declaration from pv.c.
Tue, Feb 16, 11:40 AM
royger updated the diff for D28619: xen/boot: allow specifying boot method when booted from Xen.
  • Move bootmethod definition to x86/cpu_machdep.c.
  • Declare it in md_var.h.
Tue, Feb 16, 10:30 AM
royger added a comment to D28497: stand/multiboot2: add support for booting a Xen dom0 in UEFI mode.

@tsoome let me know if you are happy with this version, as I would like to commit it soon-ish. Thanks!

Tue, Feb 16, 9:25 AM
royger accepted D28693: prepare-commit-msg: add "Fixes:" .

Other projects I work with use the Fixes tag with the following format:

Tue, Feb 16, 8:45 AM

Mon, Feb 15

royger added inline comments to D28621: xen/efi: introduce a PV interface for EFI run time services for dom0.
Mon, Feb 15, 3:47 PM
royger added inline comments to D28621: xen/efi: introduce a PV interface for EFI run time services for dom0.
Mon, Feb 15, 10:00 AM
royger updated the diff for D28621: xen/efi: introduce a PV interface for EFI run time services for dom0.
  • Fix module unload.
  • Make module depend on efirt.
Mon, Feb 15, 9:52 AM
royger added inline comments to D28621: xen/efi: introduce a PV interface for EFI run time services for dom0.
Mon, Feb 15, 9:40 AM
royger updated the diff for D28620: efirt: add hooks for diverging EFI implementations.
  • Add comment in efi_ops struct to describe the intended usage.
  • Introduce active_efi_ops as a pointer to the currently in-use efi_ops.
Mon, Feb 15, 9:34 AM

Fri, Feb 12

royger added a comment to D28621: xen/efi: introduce a PV interface for EFI run time services for dom0.

Thanks for the comment!

Fri, Feb 12, 6:44 PM
royger added a comment to D28620: efirt: add hooks for diverging EFI implementations.

For the reference, the user of this new interface is at: https://reviews.freebsd.org/D28621

Fri, Feb 12, 4:04 PM
royger requested review of D28621: xen/efi: introduce a PV interface for EFI run time services for dom0.
Fri, Feb 12, 4:03 PM
royger requested review of D28620: efirt: add hooks for diverging EFI implementations.
Fri, Feb 12, 4:02 PM
royger requested review of D28619: xen/boot: allow specifying boot method when booted from Xen.
Fri, Feb 12, 4:00 PM

Tue, Feb 9

royger added inline comments to D28551: xendomains rc script for xen-tools to allow automatic guest start/stop.
Tue, Feb 9, 8:09 AM
royger added a comment to D28551: xendomains rc script for xen-tools to allow automatic guest start/stop.

Please send the patch to xen-devel@lists.xenproject.org against the upstream Xen repository (http://xenbits.xen.org/gitweb/?p=xen.git;a=summary) (ie: place it in tools/hotplug/FreeBSD/rc.d/xendomains.in). It makes no sense to carry a custom script in the port when we can have it added upstream.

Tue, Feb 9, 7:50 AM

Mon, Feb 8

royger updated the diff for D28497: stand/multiboot2: add support for booting a Xen dom0 in UEFI mode.
  • Introduce a mb2hdr struct to pass information between the load and the exec functions.
  • Bail out at load if there's no keep BS tag.
  • Add the tags we unconditionally set to the check in MULTIBOOT_HEADER_TAG_INFORMATION_REQUEST.
Mon, Feb 8, 11:06 AM
royger added a comment to D28497: stand/multiboot2: add support for booting a Xen dom0 in UEFI mode.

Thanks for the review! Will try to fix the comments later and update.

Mon, Feb 8, 9:53 AM

Feb 5 2021

royger requested review of D28497: stand/multiboot2: add support for booting a Xen dom0 in UEFI mode.
Feb 5 2021, 12:58 PM
royger requested review of D28496: stand/efi: add modulep to kernel metadata.
Feb 5 2021, 12:58 PM
royger requested review of D28495: stand/efi: allow not exiting boot services.
Feb 5 2021, 12:57 PM

Feb 3 2021

royger committed R10:51ab5e0d82c1: stand/multiboot: adjust the protocol between loader and kernel (authored by royger).
stand/multiboot: adjust the protocol between loader and kernel
Feb 3 2021, 2:12 PM

Feb 2 2021

royger closed D28238: bhyve/ioapic: improve the tracking of IRR bit.
Feb 2 2021, 8:51 AM
royger committed R10:5ea878684f6c: bhyve/ioapic: improve the tracking of IRR bit (authored by royger).
bhyve/ioapic: improve the tracking of IRR bit
Feb 2 2021, 8:51 AM
royger closed D28237: bhyve/ioapic: only account for asserted line in edge mode.
Feb 2 2021, 8:50 AM
royger committed R10:d7d067698a38: bhyve/ioapic: only account for asserted line in level mode (authored by royger).
bhyve/ioapic: only account for asserted line in level mode
Feb 2 2021, 8:50 AM
royger closed D28236: bhyve/vioapic: remove an extra pin masked check.
Feb 2 2021, 8:50 AM
royger committed R10:49429cf9be7f: bhyve/vioapic: remove an extra pin masked check (authored by royger).
bhyve/vioapic: remove an extra pin masked check
Feb 2 2021, 8:50 AM

Feb 1 2021

royger closed D28412: stand/amd64: remove unused addr parameter from bi_load64.
Feb 1 2021, 2:42 PM
royger committed R10:45ecda8ebf80: stand/amd64: remove unused addr parameter from bi_load64 (authored by royger).
stand/amd64: remove unused addr parameter from bi_load64
Feb 1 2021, 2:42 PM

Jan 29 2021

royger committed R10:b6d85a5f51e4: stand/multiboot: adjust the protocol between loader and kernel (authored by royger).
stand/multiboot: adjust the protocol between loader and kernel
Jan 29 2021, 2:30 PM
royger closed D28411: stand/multiboot: adjust the protocol between loader and kernel.
Jan 29 2021, 2:29 PM
royger committed rP563208: emulators/xen-kernel,sysutils/xen-tools: update to 4.14.1.
emulators/xen-kernel,sysutils/xen-tools: update to 4.14.1
Jan 29 2021, 2:22 PM
royger updated the diff for D28411: stand/multiboot: adjust the protocol between loader and kernel.

Fix comments by tsoome.

Jan 29 2021, 12:36 PM
royger requested review of D28412: stand/amd64: remove unused addr parameter from bi_load64.
Jan 29 2021, 11:56 AM
royger requested review of D28411: stand/multiboot: adjust the protocol between loader and kernel.
Jan 29 2021, 11:56 AM

Jan 21 2021

royger committed R10:d9bd043f93df: xen: allow limiting the amount of duplicated pending xenstore watches (authored by royger).
xen: allow limiting the amount of duplicated pending xenstore watches
Jan 21 2021, 9:14 AM

Jan 19 2021

royger requested review of D28238: bhyve/ioapic: improve the tracking of IRR bit.
Jan 19 2021, 2:26 PM
royger requested review of D28237: bhyve/ioapic: only account for asserted line in edge mode.
Jan 19 2021, 2:26 PM
royger requested review of D28236: bhyve/vioapic: remove an extra pin masked check.
Jan 19 2021, 2:25 PM
royger requested review of D28235: arcgit: exclude ignored files from the untracked check.
Jan 19 2021, 2:25 PM

Jan 14 2021

royger closed D28095: gitignore: expand list of ignored files.
Jan 14 2021, 4:06 PM
royger committed R10:a67522b22dd9: gitignore: expand list of ignored files (authored by royger).
gitignore: expand list of ignored files
Jan 14 2021, 4:06 PM

Jan 11 2021

royger added inline comments to D28095: gitignore: expand list of ignored files.
Jan 11 2021, 6:38 PM
royger updated the summary of D28095: gitignore: expand list of ignored files.
Jan 11 2021, 5:50 PM
royger updated the diff for D28095: gitignore: expand list of ignored files.

Expand the list of file patterns to ignore.

Jan 11 2021, 5:50 PM
royger added a comment to D28095: gitignore: expand list of ignored files.

?cscope.out is removed, is that intentional?

Jan 11 2021, 5:43 PM
royger added a comment to D28095: gitignore: expand list of ignored files.

I wonder whether to also add '~.' to the list of patterns.

Jan 11 2021, 5:41 PM
royger added reviewers for D28095: gitignore: expand list of ignored files: emaste, lwhsu, uqs, imp.
Jan 11 2021, 5:40 PM
royger requested review of D28095: gitignore: expand list of ignored files.
Jan 11 2021, 5:35 PM
royger committed R10:d1eb05aa0c3a: xen: remove .swp file from public headers (authored by royger).
xen: remove .swp file from public headers
Jan 11 2021, 5:17 PM
royger committed R10:a7650787905d: xen/privcmd: implement the restrict ioctl (authored by Roger Pau Monne <roger.pau@citrix.com>).
xen/privcmd: implement the restrict ioctl
Jan 11 2021, 3:37 PM
royger committed R10:ed78016d005c: xen/privcmd: implement the dm op ioctl (authored by Roger Pau Monne <roger.pau@citrix.com>).
xen/privcmd: implement the dm op ioctl
Jan 11 2021, 3:37 PM
royger committed R10:5ed9deef6b1e: xen: update interface headers (authored by royger).
xen: update interface headers
Jan 11 2021, 3:37 PM
royger committed R10:658860e2d070: xen/privcmd: implement the map resource ioctl (authored by Roger Pau Monne <roger.pau@citrix.com>).
xen/privcmd: implement the map resource ioctl
Jan 11 2021, 3:37 PM
royger committed R10:147e593921d7: xen/privcmd: split setup of virtual address range into helper (authored by royger).
xen/privcmd: split setup of virtual address range into helper
Jan 11 2021, 3:37 PM
royger committed R10:f713a5b37ecb: xen/privcmd: make some integers unsigned (authored by royger).
xen/privcmd: make some integers unsigned
Jan 11 2021, 3:37 PM

Dec 30 2020

royger committed R10:4e4e43dc9e1a: xen: allow limiting the amount of duplicated pending xenstore watches (authored by royger).
xen: allow limiting the amount of duplicated pending xenstore watches
Dec 30 2020, 10:19 AM
royger committed R10:2ae75536d370: xen/xenstore: remove unused functions (authored by royger).
xen/xenstore: remove unused functions
Dec 30 2020, 10:19 AM

Dec 8 2020

royger added a comment to D17737: PR225864: use latest CLDR timedef for Catalan.

LGTM. I've cheked the rules and the new format seems to match them. Note I'm not a linguist at all. Do you know which complaints the original submitter had?

Dec 8 2020, 12:06 PM

Aug 27 2020

royger committed rP546327: emulators/xen-kernel & sysutils/xen-tools: update to 4.14.0.
emulators/xen-kernel & sysutils/xen-tools: update to 4.14.0
Aug 27 2020, 7:59 AM

Aug 26 2020

royger committed rP546292: misc/seabios: update to 1.14.0.
misc/seabios: update to 1.14.0
Aug 26 2020, 4:10 PM

Aug 21 2020

royger added a comment to D6611: net: translate inbound checksum offloading flags to outbound when forwarding.
In D6611#580267, @jhb wrote:

I think one question is how can you really identify these packets? You can send a packet into a VM (e.g. via an if_tap interface from a localhost connection) but that VM might itself forward the packet internally to another interface that then heads out onto the wire. You can't really know that before you send the packet into the if_tap, and the VM itself doesn't know which interfaces are internal and which are not.

I considered & rejected some magic solution where we constrain virtual interface mac addresses to a range that is unique and which can be easily checked. Then we'd know if a packet came in on a virtual interface & needs checksumming. But that doesn't work if the VM has pass-thru access to a physical NIC and can send a packet w/o going through the host.

Aug 21 2020, 1:25 PM

Aug 18 2020

royger added a comment to D6656: net/tso: use the most restrictive segment size to perform the calculations.

I'm confused. t_maxsegsize is basically the connection's MSS, eg, what the NIC is supposed to break the TSO into. However if_hw_tsomaxsegsize is the max size of the TSO to be broken up. Eg, on a NIC without oddball limitations, if_hw_tsomaxsegcount might be 64, if_hw_tsomaxsegsize might be 65535. That means that TSO is supposed to send a max of 64K down to the NIC, in a max of 64 packets. If t_maxseg is less than 1000, then we'd have to limit the TSO to 64 packets.

It seems like by restricting if_hw_tsomaxsegsize to t_maxseg, you're essentially turning off TSO, since you're only allowing one MSS to be sent at a time.

Ugh, I'm wrong. I was confusing t_tsomax with t_tsomaxsegsize. I forgot that some NICs are apparently so broken that they limit TSO seg sizes.

Aug 18 2020, 12:49 PM
royger added a comment to D6611: net: translate inbound checksum offloading flags to outbound when forwarding.

This will break some NICs (see comments on D6656 -- basically, if you're setting CSUM_TCP then you need to replace the TCP checksum with the pseudohdr checksum, and store the offset of the TCP header's checksum in csum_data).

The important question is: If the packet has already had its checksum checked, then the checksum is correct. Why not update the checksum normally and send the packet without checksum offload enabled?

Aug 18 2020, 11:22 AM

Aug 13 2020

royger added a comment to D6611: net: translate inbound checksum offloading flags to outbound when forwarding.

Is there any concern or additional work needed for ipV6?

Aug 13 2020, 2:40 PM

Jun 23 2020

royger closed D24482: sysutils/xen-tools: fix build with clang and lld 10.
Jun 23 2020, 3:16 AM