Page MenuHomeFreeBSD

Add DEV_XENTIMER option
Needs RevisionPublic

Authored by kvinupriya_gmail.com on Dec 10 2024, 11:30 PM.
Tags
None
Referenced Files
F174705423: D48024.id147801.diff
Mon, Oct 5, 8:57 AM
Unknown Object (File)
Mon, Oct 5, 1:04 AM
Unknown Object (File)
Mon, Oct 5, 12:48 AM
Unknown Object (File)
Sun, Oct 4, 5:00 PM
Unknown Object (File)
Sun, Oct 4, 4:08 AM
Unknown Object (File)
Fri, Oct 2, 9:04 PM
Unknown Object (File)
Thu, Oct 1, 1:30 PM
Unknown Object (File)
Thu, Sep 24, 4:26 AM

Details

Reviewers
royger
Summary

Check for DEV_XENTIMER in pv.c as xen_timer.c code that implements
the xen_clock_init is under "options xentimer" in the files file.

Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61078
Build 57962: arc lint + arc unit

Event Timeline

Looks reasonable to me. Though the option is primarily to allow removing the timer on ARM/RISC-V (where it doesn't presently work). I'm unsure whether it is possible to avoid on x86.

royger requested changes to this revision.Dec 11 2024, 7:57 AM
royger added inline comments.
sys/x86/xen/pv.c
111

Won't this lead to a call into NULL when booted as Xen PVH guest but without DEV_XENTIMER enabled? See clock_init().

You need an else branch here to define it to the native function (native_clock_source_init()), or otherwise patch the callers to only call early_clock_source_init if != NULL.

This revision now requires changes to proceed.Dec 11 2024, 7:57 AM