Page MenuHomeFreeBSD

xen/debug: remove usage of sbuf_{clear,finish}() on drained sbuf
ClosedPublic

Authored by royger on May 2 2024, 2:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 10, 8:42 PM
Unknown Object (File)
Mon, Aug 10, 10:17 AM
Unknown Object (File)
Sat, Aug 8, 5:50 PM
Unknown Object (File)
Sat, Aug 8, 9:35 AM
Unknown Object (File)
Mon, Aug 3, 11:02 PM
Unknown Object (File)
Sun, Jul 19, 11:57 PM
Unknown Object (File)
Jul 5 2026, 6:48 PM
Unknown Object (File)
Jun 28 2026, 5:13 PM

Details

Summary

Using sbuf_clear() on a drained sbuf is explicitly prohibited, and using
sbuf_finish() after printing a trace leads to a single trace being printed, as
after calling sbuf_finish() further attempts to use the same sbuf will lead to
a panic.

While there also switch to using xen_emergency_print() instead of attempting to
write directly to the hypervisor console. xen_emergency_print() can be
implemented per-arch to use a different mechanism than the console hypercall
(note the default implementation still uses the console hypercall).

Fixes: df62b8a25f47 ('xen: add a handler for the debug interrupt')
Sponsored by: Cloud Software Group

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped