Page MenuHomeFreeBSD

xen: expose support for poweroff/reboot/suspend on xenbus
Needs ReviewPublic

Authored by royger on Tue, Oct 1, 9:14 AM.
Tags
None
Referenced Files
F99277156: D46859.diff
Mon, Oct 7, 11:14 PM
Unknown Object (File)
Sat, Oct 5, 11:39 PM
Unknown Object (File)
Thu, Oct 3, 1:55 PM
Unknown Object (File)
Tue, Oct 1, 6:05 PM
Subscribers

Details

Summary

Some toolstacks won't attempt the signal power actions on xenbus unless the VM
explicitly exposes support for them. FreeBSD supports all power actions, hence
signal on xenbus such support by setting the nodes to the value of "1".

Sponsored by: Cloud Software Group

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

royger requested review of this revision.Tue, Oct 1, 9:14 AM

This looks ok to me aside from style nits. I don't know Xen well enough to properly review the substance of the change.

sys/dev/xen/control/control.c
401

Extra newline.

502

Extra newline.

508

Extra newline.

Thanks for the review, will get the extra newlines removed and this committed.

sys/dev/xen/control/control.c
401

Oh, we finally changed the style to not mandate an empty newline if there are no local varaibles in a function:

static void
usage(void)
{
       /* Optional blank line goes here. */

Optionally, insert a blank line at the beginning of functions with no
local variables.   Older versions of this style document required the
blank line convention, so it is widely used in existing code.