Page MenuHomeFreeBSD

Ports CommittersOrganization
ActivePublic

Recent Activity

Sep 20 2018

tobik added a member for Ports Committers: tobik.
Sep 20 2018, 12:00 PM

Aug 16 2018

0mp added a comment to D15350: Tidy up ports.7 manual.
In D15350#356103, @bjk wrote:
In D15350#350715, @0mp wrote:
In D15350#348437, @bjk wrote:

Can you remind me why the .Dq Li is supposed to be better for inline commands?

As fair as I know we tend to use Dq Li instead of Nm make Cm build-like for inline commands. This is the style we follow in make.conf.5, src.conf.5, mqueufs.5. The Nm-based formatting is used in rc.conf.5 and find.1 on the other hand.

AFAICT, Dq Li is a more popular way to format commands.

The argument which is in favor of Dq Li is that we tend to make commands in Examples sections literal. We very rarely add Nm-like formatting to examples. Hence for the sake of consistency I'm proposing this change from Nm ... to Dq Li. 馃槃

What do you think about it, @bjk?

I see this is basically overcome by events, but thank you for the explanation/research -- your proposal seems reasonable to me.

Aug 16 2018, 3:26 PMPorts Committers, Doc Committers, manpages
bjk added a comment to D15350: Tidy up ports.7 manual.
In D15350#350715, @0mp wrote:
In D15350#348437, @bjk wrote:

Can you remind me why the .Dq Li is supposed to be better for inline commands?

As fair as I know we tend to use Dq Li instead of Nm make Cm build-like for inline commands. This is the style we follow in make.conf.5, src.conf.5, mqueufs.5. The Nm-based formatting is used in rc.conf.5 and find.1 on the other hand.

AFAICT, Dq Li is a more popular way to format commands.

The argument which is in favor of Dq Li is that we tend to make commands in Examples sections literal. We very rarely add Nm-like formatting to examples. Hence for the sake of consistency I'm proposing this change from Nm ... to Dq Li. 馃槃

What do you think about it, @bjk?

Aug 16 2018, 2:55 PMPorts Committers, Doc Committers, manpages
0mp closed D15350: Tidy up ports.7 manual.
Aug 16 2018, 1:29 PMPorts Committers, Doc Committers, manpages
krion accepted D15350: Tidy up ports.7 manual.
Aug 16 2018, 6:53 AMPorts Committers, Doc Committers, manpages
eadler accepted D15350: Tidy up ports.7 manual.
Aug 16 2018, 5:15 AMPorts Committers, Doc Committers, manpages

Aug 15 2018

0mp added a reviewer for D15350: Tidy up ports.7 manual: bcr.
Aug 15 2018, 1:55 PMPorts Committers, Doc Committers, manpages

Aug 1 2018

0mp added a member for Ports Committers: 0mp.
Aug 1 2018, 3:42 PM

Jul 31 2018

0mp added a comment to D15350: Tidy up ports.7 manual.
In D15350#348437, @bjk wrote:

Can you remind me why the .Dq Li is supposed to be better for inline commands?

Jul 31 2018, 1:27 AMPorts Committers, Doc Committers, manpages

Jul 24 2018

bjk added a comment to D15350: Tidy up ports.7 manual.

Can you remind me why the .Dq Li is supposed to be better for inline commands?

Jul 24 2018, 12:46 AMPorts Committers, Doc Committers, manpages

Jul 20 2018

mat accepted D15350: Tidy up ports.7 manual.

No idea what this is/does.

Jul 20 2018, 11:34 AMPorts Committers, Doc Committers, manpages

Jul 19 2018

0mp added reviewers for D15350: Tidy up ports.7 manual: krion, mat.
Jul 19 2018, 12:37 PMPorts Committers, Doc Committers, manpages
0mp updated the summary of D15350: Tidy up ports.7 manual.
Jul 19 2018, 12:36 PMPorts Committers, Doc Committers, manpages
0mp updated the diff for D15350: Tidy up ports.7 manual.

Update the patch after recent changes to ports.7.

Jul 19 2018, 12:31 PMPorts Committers, Doc Committers, manpages

May 14 2018

dch added a watcher for Ports Committers: dch.
May 14 2018, 12:58 PM

May 8 2018

0mp created D15350: Tidy up ports.7 manual.
May 8 2018, 11:33 AMPorts Committers, Doc Committers, manpages

Apr 22 2018

dbaio added a member for Ports Committers: dbaio.
Apr 22 2018, 9:26 PM

Feb 12 2018

daniel.engberg.lists_pyret.net updated the summary of D14195: treewide: Remove netbsd master site alias.
Feb 12 2018, 1:47 PMPorts Committers, portmgr

Feb 6 2018

daniel.engberg.lists_pyret.net added a comment to D14195: treewide: Remove netbsd master site alias.

Fix ntraceroute port

Feb 6 2018, 9:55 AMPorts Committers, portmgr
daniel.engberg.lists_pyret.net updated the diff for D14195: treewide: Remove netbsd master site alias.

Fix ntraceroute, fix suggested by @mat

Feb 6 2018, 9:54 AMPorts Committers, portmgr
mat added inline comments to D14195: treewide: Remove netbsd master site alias.
Feb 6 2018, 9:37 AMPorts Committers, portmgr
daniel.engberg.lists_pyret.net updated the diff for D14195: treewide: Remove netbsd master site alias.

New patch generated using -U9999 as per request, no change otherwise

Feb 6 2018, 8:44 AMPorts Committers, portmgr

Feb 5 2018

mat added a comment to D14195: treewide: Remove netbsd master site alias.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Feb 5 2018, 10:52 PMPorts Committers, portmgr
cy accepted D14195: treewide: Remove netbsd master site alias.

Some of these ports should probably be deprecated and removed... I'll look into deprecating tripwire12,

Feb 5 2018, 6:29 AMPorts Committers, portmgr

Feb 4 2018

daniel.engberg.lists_pyret.net added reviewers for D14195: treewide: Remove netbsd master site alias: zi, cy.
Feb 4 2018, 11:38 PMPorts Committers, portmgr
daniel.engberg.lists_pyret.net updated the diff for D14195: treewide: Remove netbsd master site alias.
Feb 4 2018, 7:13 PMPorts Committers, portmgr
eadler accepted D14195: treewide: Remove netbsd master site alias.

LGTM though some of these will want maintainer notification/approval.

Feb 4 2018, 7:10 PMPorts Committers, portmgr
daniel.engberg.lists_pyret.net updated the summary of D14195: treewide: Remove netbsd master site alias.
Feb 4 2018, 7:10 PMPorts Committers, portmgr
daniel.engberg.lists_pyret.net added a comment to D14195: treewide: Remove netbsd master site alias.

Most of these ports are ancient and while I do understand that http://www.minix3.org/distfiles-backup/ isn't ideal it's in most cases the only reliable site I could find hosting the tarballs.

Feb 4 2018, 7:07 PMPorts Committers, portmgr
daniel.engberg.lists_pyret.net created D14195: treewide: Remove netbsd master site alias.
Feb 4 2018, 6:48 PMPorts Committers, portmgr

Dec 9 2017

sunpoet added a member for Ports Committers: sunpoet.
Dec 9 2017, 11:17 AM

Nov 21 2017

lifanov closed D12793: ArangoDB FreeBSD port.
Nov 21 2017, 3:48 PMPorts Committers
dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

I re-tested it and the port looks good now.
Would you like me to commit it?

Is there a Bugzilla issue for it?

Nov 21 2017, 3:12 PMPorts Committers
lifanov accepted D12793: ArangoDB FreeBSD port.

I re-tested it and the port looks good now.
Would you like me to commit it?

Nov 21 2017, 3:04 PMPorts Committers

Nov 20 2017

dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

OK, this works now and looks pretty good.
Can you consider making some configuration files @sample?
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-config

There are two steps to it:

  1. install the file with .sample suffix (like arangod.conf.sample)
  2. list it with @sample in pkg-plist: @sample %%ETCDIR%%/arangod.conf.sample

    When pkg installs a package with @sample entries, these get copied to the correct location if the files are missing and then the user can modify the configuration files without causing checksum mismatches and without the files being clobbered on package update.
Nov 20 2017, 11:25 PMPorts Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Install configuration files as samples.

Nov 20 2017, 11:25 PMPorts Committers
lifanov added a comment to D12793: ArangoDB FreeBSD port.

OK, this works now and looks pretty good.
Can you consider making some configuration files @sample?
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-config

Nov 20 2017, 6:05 PMPorts Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Update the arangodb user directory

Nov 20 2017, 3:53 PMPorts Committers
dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

This doesn't build for me:

/work/stage/usr/local/share/arangodb/js/server/bootstrap/coordinator-database.js
CMake Error at cmake_install.cmake:87 (file):
  file INSTALL cannot find
  "/usr/home/lifanov/src/svn/freebsd/ports/head/databases/arangodb32/work/.build/var/log/arangodb3".
gmake[1]: *** [Makefile:99: install/strip] Error 1
Nov 20 2017, 3:41 PMPorts Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Add the cmake patch

Nov 20 2017, 3:41 PMPorts Committers
lifanov added a comment to D12793: ArangoDB FreeBSD port.

This doesn't build for me:

/work/stage/usr/local/share/arangodb/js/server/bootstrap/coordinator-database.js
CMake Error at cmake_install.cmake:87 (file):
  file INSTALL cannot find
  "/usr/home/lifanov/src/svn/freebsd/ports/head/databases/arangodb32/work/.build/var/log/arangodb3".
gmake[1]: *** [Makefile:99: install/strip] Error 1
Nov 20 2017, 3:31 PMPorts Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Update maintainer address.

Nov 20 2017, 10:11 AMPorts Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Update to 3.2.8

Nov 20 2017, 10:10 AMPorts Committers

Nov 16 2017

dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

I'm not sure I understand what you mean - should I replace them with the actual final value - e.g. /usr/local/share, or add @dir entries for them to pkg-plist?

The directory that gets installed is /usr/local/share/arangodb3, which suggests that PORTNAME should be agangodb3?
There are several other places where arangodb3 name gets used. Example:

: ${arangod_dbpath="/var/db/arangodb3"}
: ${arangod_logpath="/var/log/arangodb3"}
: ${arangod_apppath="/var/db/arangodb3-apps"}

As for the renaming bit I was thinking of following the mongodbXY port convention and eventually add an arangodb33 port that is set to conflict with the arangodb32 port. Thoughts?

Versioning it like mongodbXY is a good idea in general, but it is useful if the two versions are incompatible or require special upgrade/migration steps (like postgresql).
Another consideration is how long do you expect people to run arangodb 3.2 once 3.3 is realeased.

Thanks!

Nov 16 2017, 9:44 PMPorts Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Updated to 3.2.7
Addressed reviewer comments

Nov 16 2017, 9:44 PMPorts Committers

Nov 8 2017

lifanov added a comment to D12793: ArangoDB FreeBSD port.

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

I'm not sure I understand what you mean - should I replace them with the actual final value - e.g. /usr/local/share, or add @dir entries for them to pkg-plist?

Nov 8 2017, 2:31 PMPorts Committers

Nov 7 2017

dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

Nov 7 2017, 3:51 PMPorts Committers

Nov 3 2017

lifanov added a comment to D12793: ArangoDB FreeBSD port.

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

Nov 3 2017, 1:25 PMPorts Committers

Oct 27 2017

dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Remove git dependency and add python dependency

Oct 27 2017, 5:31 PMPorts Committers
mat added inline comments to D12793: ArangoDB FreeBSD port.
Oct 27 2017, 5:03 PMPorts Committers