Page MenuHomeFreeBSD

crees (Chris Rees)
User

Projects

User Details

User Since
Sep 9 2014, 5:25 PM (290 w, 5 d)

Recent Activity

Tue, Mar 31

crees added a comment to D21450: rc.subr(8): Set procname to command by default to match documentation.

This needs some heavy testing, for which I'm afraid I just don't have the capacity for at the moment. I've been bitten quite hard recently by a 'simple' rc change recently so I'm reluctant to put my stamp on it!

Tue, Mar 31, 10:01 AM

Wed, Mar 25

crees committed rD54014: Document the use of '-retro' to actually get a visible background..
Document the use of '-retro' to actually get a visible background.
Wed, Mar 25, 10:57 AM

Sun, Mar 22

crees accepted D23816: Porter Handbook: document Uses/cabal.mk.

I have a comment on the MAINTAINER line, but agree with @bcr.

Sun, Mar 22, 1:06 PM

Feb 13 2020

crees added a comment to D23585: Include warning about unintended consequences of using the operator account, and add note about GELI passing TRIM/UNMAP requests to ZFS FAQ.

They are separate actions, so should be separate commits and therefore separate reviews, but I'm happy to split them this time.

Feb 13 2020, 10:02 PM
crees added a comment to D23589: Porter's Handbook: explain ports signature policy for older ports.

https://www.bayofrum.net/~crees/patches/patch-obsolete-headers-porter.diff

Feb 13 2020, 9:20 PM
crees added a comment to D23589: Porter's Handbook: explain ports signature policy for older ports.

Mat does indeed mean that the paragraph should be removed, and I'm inclined to agree- we don't have any

Feb 13 2020, 9:11 PM
crees committed rP526065: Mark BROKEN on head, and make a couple of rc script fixes.
Mark BROKEN on head, and make a couple of rc script fixes
Feb 13 2020, 8:43 PM
crees committed rD53892: Document the new range ability for USES=pgsql..
Document the new range ability for USES=pgsql.
Feb 13 2020, 8:30 PM

Feb 12 2020

crees added a comment to D23590: Correct policy for new ports' summary standard format.

I'll deal with whitespace separately.

Feb 12 2020, 6:12 PM
crees updated the diff for D23590: Correct policy for new ports' summary standard format.

This matches your suggestions.

Feb 12 2020, 6:11 PM
crees added a comment to D23590: Correct policy for new ports' summary standard format.

There are a couple of tagging issues I'll fix before committing, yes.

Feb 12 2020, 5:33 PM
crees accepted D23585: Include warning about unintended consequences of using the operator account, and add note about GELI passing TRIM/UNMAP requests to ZFS FAQ.

Looks great. If no one else does so, I'll commit this in a few days when I get a chance.

Feb 12 2020, 12:29 PM

Feb 10 2020

crees commandeered D23590: Correct policy for new ports' summary standard format.

Ok, no worries, I'll commit when Mat approves.

Feb 10 2020, 9:19 PM
crees accepted D23590: Correct policy for new ports' summary standard format.

Docs approval granted. Not sure if Mat wants to comment as it's a bugs part.

Feb 10 2020, 7:46 PM

Feb 9 2020

crees requested changes to D23590: Correct policy for new ports' summary standard format.

Do you have a rendered version? I think the diff is missing a bit.

Feb 9 2020, 4:24 PM
crees added a comment to D23589: Porter's Handbook: explain ports signature policy for older ports.

While I agree with the sentiment, is this definitely policy?

Feb 9 2020, 4:10 PM

Feb 8 2020

crees added a comment to D23585: Include warning about unintended consequences of using the operator account, and add note about GELI passing TRIM/UNMAP requests to ZFS FAQ.

Do you think some actual examples might help? As an example perhaps the shutdown privilege, but can you think of any others?

Feb 8 2020, 7:19 PM

Feb 1 2020

crees accepted D23451: Update jenkins-admin@ members.

Please go ahead.

Feb 1 2020, 8:09 AM

Jan 27 2020

crees abandoned D23240: x11-drivers/xorg-drivers: Add the vmware drivers by default.

This isn't necessary to make X run in vmware, so including it in xorg-drivers is overkill.

Jan 27 2020, 2:56 PM

Jan 25 2020

crees committed rP524045: audio/oss: Fix build on head.
audio/oss: Fix build on head
Jan 25 2020, 4:07 PM

Jan 18 2020

crees accepted D23248: Update installation instructions for KDE Plasma.

Go ahead.

Jan 18 2020, 9:41 AM

Jan 17 2020

crees retitled D23240: x11-drivers/xorg-drivers: Add the vmware drivers by default from x11-drivers/xorg-drivers to x11-drivers/xorg-drivers: Add the vmware drivers by default.
Jan 17 2020, 7:19 PM
crees created D23240: x11-drivers/xorg-drivers: Add the vmware drivers by default.
Jan 17 2020, 7:17 PM
crees committed rP523353: x11/xdm: minor fixes.
x11/xdm: minor fixes
Jan 17 2020, 7:07 PM
crees committed rP523348: audio/oss: Fix build on recent FreeBSD.
audio/oss: Fix build on recent FreeBSD
Jan 17 2020, 6:52 PM

Jan 8 2020

crees committed rP522434: Add simple rc script for xdm..
Add simple rc script for xdm.
Jan 8 2020, 4:29 PM

Jan 6 2020

crees committed rP522282: MFH: r522277.
MFH: r522277
Jan 6 2020, 9:34 PM
crees committed rP522277: x11/cde: update to 2.3.1 and unbreak.
x11/cde: update to 2.3.1 and unbreak
Jan 6 2020, 9:27 PM

Jan 3 2020

crees committed rD53753: Use the correct format string for ISO date..
Use the correct format string for ISO date.
Jan 3 2020, 5:59 PM

Jan 2 2020

crees committed rP521837: audio/oss: timeout has been removed in favour of callback(9).
audio/oss: timeout has been removed in favour of callback(9)
Jan 2 2020, 3:06 PM

Dec 28 2019

crees added a comment to D22708: Fix the Ethernet+WiFi example.

If the note is below the example, consider that approved as well (remember the blank line in between).

Dec 28 2019, 10:09 PM

Dec 24 2019

crees committed rP520805: audio/oss: Silence further compiler warning; perhaps this will help..
audio/oss: Silence further compiler warning; perhaps this will help.
Dec 24 2019, 1:37 PM

Dec 21 2019

crees closed D22895: Add missing word to "Do I need a SSD for ZIL?" FAQ.
Dec 21 2019, 2:24 PM
crees committed rD53703: Add missing 'performance' to 'can improve system'..
Add missing 'performance' to 'can improve system'.
Dec 21 2019, 2:24 PM
crees accepted D22895: Add missing word to "Do I need a SSD for ZIL?" FAQ.

I'll commit this shortly.

Dec 21 2019, 8:51 AM

Dec 16 2019

crees committed rP520256: Fix build on head- missing headers resulted in implicit incompatible.
Fix build on head- missing headers resulted in implicit incompatible
Dec 16 2019, 1:29 PM

Dec 15 2019

crees accepted D22708: Fix the Ethernet+WiFi example.

Please go ahead and commit with my approval.

Dec 15 2019, 7:20 PM

Dec 9 2019

crees committed rP519628: Build ipv6 and ipv4 versions together and package both..
Build ipv6 and ipv4 versions together and package both.
Dec 9 2019, 7:07 PM
crees abandoned D21578: net/opentracker: add flavours to enable both packages to be build..

Thanks Mat- sometimes the best answer is completely different! I'll build both versions and install them alongside each other- in a package this size, flavours are overkill.

Dec 9 2019, 7:04 PM
crees planned changes to D21578: net/opentracker: add flavours to enable both packages to be build..
Dec 9 2019, 2:25 PM

Dec 4 2019

crees committed rD53655: Simplify language by removing spurious comma..
Simplify language by removing spurious comma.
Dec 4 2019, 11:53 AM
crees closed D22648: Remove spurious comma..
Dec 4 2019, 11:53 AM
crees accepted D22648: Remove spurious comma..

Great, will commit, thanks.

Dec 4 2019, 11:50 AM

Dec 3 2019

crees accepted D22648: Remove spurious comma..
Dec 3 2019, 9:26 PM

Nov 6 2019

crees accepted D22262: Support --all-repeats in uniq(1) for compatibility with gnu coreutils..

Manpage and usage changes look fine.

Nov 6 2019, 8:37 PM

Sep 22 2019

crees added a comment to D21578: net/opentracker: add flavours to enable both packages to be build..

Hello portmgr,

Sep 22 2019, 5:36 PM

Sep 21 2019

crees committed rP512528: audio/oss: Improve handling when sound.ko is compiled into the kernel..
audio/oss: Improve handling when sound.ko is compiled into the kernel.
Sep 21 2019, 6:13 PM

Sep 9 2019

crees committed rS352107: Reverse the referenced tables..
Reverse the referenced tables.
Sep 9 2019, 8:48 PM
crees committed rP511699: net/get_iplayer: update to 3.22.
net/get_iplayer: update to 3.22
Sep 9 2019, 8:33 PM
crees added a reviewer for D21578: net/opentracker: add flavours to enable both packages to be build.: portmgr.
Sep 9 2019, 8:17 PM
crees created D21578: net/opentracker: add flavours to enable both packages to be build..
Sep 9 2019, 8:17 PM

Aug 28 2019

crees committed rP510065: Missing dependency.
Missing dependency
Aug 28 2019, 2:28 PM
crees added a comment to D21450: rc.subr(8): Set procname to command by default to match documentation.

Inline.

Aug 28 2019, 1:31 PM

Jul 12 2019

D20925: Added Two Articles about FreeBSD to Press Section is now accepted and ready to land.

Apart from line 36's removal, all looks good.

Jul 12 2019, 3:30 PM

Jun 20 2019

crees committed rP504733: x11/cde: Add dtlogin rc script.
x11/cde: Add dtlogin rc script
Jun 20 2019, 7:19 PM
crees committed rP504718: sysutils/reed: Update to 5.6.
sysutils/reed: Update to 5.6
Jun 20 2019, 7:09 PM

Jun 19 2019

crees committed rP504525: sysutils/reed: Remove sys/dir.h.
sysutils/reed: Remove sys/dir.h
Jun 19 2019, 8:30 AM

May 15 2019

crees committed rP501749: devel/arcanist: Split into arcanist-lib and arcanist..
devel/arcanist: Split into arcanist-lib and arcanist.
May 15 2019, 8:53 PM
crees closed D19920: devel/arcanist: Add slave to avoid conflicting with archivers/arc.
May 15 2019, 8:53 PM

May 2 2019

crees updated the diff for D19920: devel/arcanist: Add slave to avoid conflicting with archivers/arc.

OK, Mat's feedback incorporated.

May 2 2019, 7:56 PM

Apr 25 2019

crees committed rP500060: Don't overwrite PORTREVISION from the slave, following readline update..
Don't overwrite PORTREVISION from the slave, following readline update.
Apr 25 2019, 6:35 PM
crees updated the diff for D19920: devel/arcanist: Add slave to avoid conflicting with archivers/arc.

NO_FETCH isn't actually a thing of course.

Apr 25 2019, 12:52 AM
crees added a comment to D19920: devel/arcanist: Add slave to avoid conflicting with archivers/arc.

Poudriere builds both no problem:

Apr 25 2019, 12:41 AM
crees retitled D19920: devel/arcanist: Add slave to avoid conflicting with archivers/arc from devel/arcanist: Add flavour to avoid conflicting with archivers/arc to devel/arcanist: Add slave to avoid conflicting with archivers/arc.
Apr 25 2019, 12:40 AM

Apr 24 2019

crees committed rP499900: MFH: r499898.
MFH: r499898
Apr 24 2019, 7:36 PM
crees committed rP499898: x11/cde: Fix building on FreeBSD 12.
x11/cde: Fix building on FreeBSD 12
Apr 24 2019, 7:34 PM
crees updated the diff for D19920: devel/arcanist: Add slave to avoid conflicting with archivers/arc.

Create slave port -lib to install everything except the symlink, and change devel/arcanist to only install the bin symlink

Apr 24 2019, 7:25 PM
crees committed rD52957: Hint switch between virtual terminals from Xorg.
Hint switch between virtual terminals from Xorg
Apr 24 2019, 6:33 PM

Apr 16 2019

crees added a comment to D19920: devel/arcanist: Add slave to avoid conflicting with archivers/arc.

Yeah, I wondered what would happen about the php flavours :(

Apr 16 2019, 12:04 PM
crees committed rD52928: Give a hint to curses navigation.
Give a hint to curses navigation
Apr 16 2019, 10:03 AM
crees updated the diff for D19920: devel/arcanist: Add slave to avoid conflicting with archivers/arc.

Nope, CONFLICTS has changed its behaviour, so remove the globs entirely.

Apr 16 2019, 9:15 AM
crees updated the diff for D19920: devel/arcanist: Add slave to avoid conflicting with archivers/arc.

Just realised, the CONFLICTS line should have [0-9] in it.

Apr 16 2019, 9:13 AM
crees created D19920: devel/arcanist: Add slave to avoid conflicting with archivers/arc.
Apr 16 2019, 9:11 AM

Apr 10 2019

crees added a comment to D18670: Minor speedup for load_kld function.

Thanks very much for the explanation-- I think my terminology is just off here (I do understand what you mean). I have some ideas to get this to work, but I'll get back when I've tried them, may not be for a few days.

Apr 10 2019, 12:21 PM
crees reopened D18670: Minor speedup for load_kld function.

I've reverted the patch for now (thanks again Jilles for your approval).

Apr 10 2019, 8:22 AM
crees committed rS346072: Revert r346017 pending compiled-in zfs fix.
Revert r346017 pending compiled-in zfs fix
Apr 10 2019, 7:51 AM

Apr 7 2019

crees committed rS346017: Remove now unnecessary kldstat check before attempting to load modules..
Remove now unnecessary kldstat check before attempting to load modules.
Apr 7 2019, 6:32 PM
crees closed D18670: Minor speedup for load_kld function.
Apr 7 2019, 6:32 PM
crees added a comment to D18670: Minor speedup for load_kld function.

Fantastic, thanks for the approval and tip.

Apr 7 2019, 6:24 PM

Apr 5 2019

crees added a comment to D18670: Minor speedup for load_kld function.

I have performed a visual only review.

Apr 5 2019, 9:17 PM

Feb 26 2019

crees added a comment to D19244: Mark almost all Haskell ports for expiration..

At the risk of hijacking this conversation, I don't remember where I put my copy of the patch, but i remember it working correctly! Please go ahead and commit, it won't hurt :)

Feb 26 2019, 9:45 PM
crees added a comment to rD52831: Document kernel compile options for ipfw.

Thanks @bcr- had it open anyway.

Feb 26 2019, 9:34 PM
crees committed rD52831: Document kernel compile options for ipfw.
Document kernel compile options for ipfw
Feb 26 2019, 9:22 PM
crees closed D18484: Update the ipfw section in the Handbook: kernel options, ipfw0, configuration.
Feb 26 2019, 9:22 PM
crees added a comment to D18484: Update the ipfw section in the Handbook: kernel options, ipfw0, configuration.

Unlees @bcr commits it first or objects, I'll do it.

Feb 26 2019, 8:47 PM
crees added a comment to D19244: Mark almost all Haskell ports for expiration..

@rene, would you still like rmport patched? I can't remember why I reverted it.

Feb 26 2019, 7:45 PM

Jan 29 2019

crees added a comment to D19012: sysctl has not -R option.

I think it should be NRTbdehnotqx, shouldn't it? I'm sure most of our manpages are like that.

Jan 29 2019, 3:29 PM

Jan 15 2019

crees added a comment to D18818: Uses/pgsql.mk: PostgreSQL option to install a version between an interval.

Committed, thanks!

Jan 15 2019, 9:53 PM
crees committed rP490431: Add facility to give a range of allowable versions for postgresql.
Add facility to give a range of allowable versions for postgresql
Jan 15 2019, 9:51 PM
crees closed D18818: Uses/pgsql.mk: PostgreSQL option to install a version between an interval.
Jan 15 2019, 9:51 PM

Jan 11 2019

crees accepted D18818: Uses/pgsql.mk: PostgreSQL option to install a version between an interval.

Please get the MAX fixed too and it's great.

Jan 11 2019, 6:22 PM
crees requested changes to D18818: Uses/pgsql.mk: PostgreSQL option to install a version between an interval.

I think this should work-- how have you tested this?

Jan 11 2019, 12:18 PM

Jan 6 2019

crees accepted D10087: route(8): clarify -prefixlen description.

Docs approval not necessarily needed, but given for a green tick there.

Jan 6 2019, 9:13 PM

Dec 29 2018

crees retitled D18686: docs/41089 pax(1) -B option does not mention interaction with -z option from docs/31089 pax(1) -B option does not mention interaction with -z option to docs/41089 pax(1) -B option does not mention interaction with -z option.
Dec 29 2018, 11:09 PM · docs
crees committed rS342601: Add a note that the use of -B option does not guarantee a size of fragment.
Add a note that the use of -B option does not guarantee a size of fragment
Dec 29 2018, 11:09 PM
crees closed D18686: docs/41089 pax(1) -B option does not mention interaction with -z option.
Dec 29 2018, 11:09 PM · docs
crees added inline comments to D18686: docs/41089 pax(1) -B option does not mention interaction with -z option.
Dec 29 2018, 9:52 PM · docs
crees created D18686: docs/41089 pax(1) -B option does not mention interaction with -z option.
Dec 29 2018, 9:52 PM · docs
crees added a comment to D18682: ports.7: Add an example of getting dependencies without building.

I would assume that people with their own repo will understand that the default options case doesn't apply to them, so that final comment is probably OK.

Dec 29 2018, 8:39 PM
crees accepted D18666: Remove legacy rc.d infrastructure references.

Looks great, thanks!

Dec 29 2018, 7:49 PM