- User Since
- Sep 9 2014, 5:25 PM (316 w, 3 h)
Jun 15 2020
The submitter of ports/238089 has asked for py-pillow to be removed from dependencies unless mono-heapviz is used, as it's a heavy dependency:
Jun 12 2020
May 5 2020
May 1 2020
That's true, but isn't it normal to have 'first affected version' and 'first fixed version'?
Apr 17 2020
Apr 15 2020
I'll agree with Conrad and Jilles in that it's adding a configuration value (needlessly?) and doesn't really do what it's advertised to do anyway.
Apr 14 2020
I'm not sure the /dev/null bit is necessary here now since that was presumably originally to ignore the failed amount of root, in the days before the -A option was a thing. In fact, I think it's undesirable as any errors from umount -A are now something we need to see.
Apr 12 2020
The 'and' makes it explicit to me that 1.6 is affected. You can think of it as 'version 1.6 and versions up to ...', but I know Romance languages like yours are stricter on leaving out nouns than English.
An en-dash is the correct one to use, but the historical ones don't really need urgently changing now. Maybe some day someone will fix it, but it's not really a big deal :)
You don't touch $FreeBSD$- that's dealt with by Subversion :)
I meant, so I could see what it looks like :)
Have you rendered this somewhere? Can't see any issues in the code.
Mar 31 2020
This needs some heavy testing, for which I'm afraid I just don't have the capacity for at the moment. I've been bitten quite hard recently by a 'simple' rc change recently so I'm reluctant to put my stamp on it!
Mar 25 2020
Mar 22 2020
I have a comment on the MAINTAINER line, but agree with @bcr.
Feb 13 2020
They are separate actions, so should be separate commits and therefore separate reviews, but I'm happy to split them this time.
Mat does indeed mean that the paragraph should be removed, and I'm inclined to agree- we don't have any
Feb 12 2020
I'll deal with whitespace separately.
This matches your suggestions.
There are a couple of tagging issues I'll fix before committing, yes.
Looks great. If no one else does so, I'll commit this in a few days when I get a chance.
Feb 10 2020
Ok, no worries, I'll commit when Mat approves.
Docs approval granted. Not sure if Mat wants to comment as it's a bugs part.
Feb 9 2020
Do you have a rendered version? I think the diff is missing a bit.
While I agree with the sentiment, is this definitely policy?
Feb 8 2020
Do you think some actual examples might help? As an example perhaps the shutdown privilege, but can you think of any others?
Feb 1 2020
Jan 27 2020
This isn't necessary to make X run in vmware, so including it in xorg-drivers is overkill.
Jan 25 2020
Jan 18 2020
Jan 17 2020
Jan 8 2020
Jan 6 2020
Jan 3 2020
Jan 2 2020
Dec 28 2019
If the note is below the example, consider that approved as well (remember the blank line in between).
Dec 24 2019
Dec 21 2019
I'll commit this shortly.
Dec 16 2019
Dec 15 2019
Please go ahead and commit with my approval.
Dec 9 2019
Thanks Mat- sometimes the best answer is completely different! I'll build both versions and install them alongside each other- in a package this size, flavours are overkill.
Dec 4 2019
Dec 3 2019
Nov 6 2019
Manpage and usage changes look fine.
Sep 22 2019
Sep 21 2019
Sep 9 2019
Aug 28 2019
Jul 12 2019
Apart from line 36's removal, all looks good.
Jun 20 2019
Jun 19 2019
May 15 2019
May 2 2019
OK, Mat's feedback incorporated.
Apr 25 2019
NO_FETCH isn't actually a thing of course.
Poudriere builds both no problem:
Apr 24 2019
Create slave port -lib to install everything except the symlink, and change devel/arcanist to only install the bin symlink
Apr 16 2019
Yeah, I wondered what would happen about the php flavours :(
Nope, CONFLICTS has changed its behaviour, so remove the globs entirely.
Just realised, the CONFLICTS line should have [0-9] in it.
Apr 10 2019
Thanks very much for the explanation-- I think my terminology is just off here (I do understand what you mean). I have some ideas to get this to work, but I'll get back when I've tried them, may not be for a few days.
I've reverted the patch for now (thanks again Jilles for your approval).