Page MenuHomeFreeBSD

Fix audio/oss build under 14-CURRENT
ClosedPublic

Authored by cy on Oct 19 2021, 3:47 PM.

Details

Summary

The following commit to 14-CURRENT renamed struct device to struct _device.

commit dfff37765ce4ea4fd7db4d293b459dc84008f411
Author: Mark Johnston <markj@FreeBSD.org>
Date: Mon Apr 12 09:32:30 2021 -0400

Rename struct device to struct _device

types.h defines device_t as a typedef of struct device *.  struct device
is defined in subr_bus.c and almost all of the kernel uses device_t.
The LinuxKPI also defines a struct device, so type confusion can occur.

This causes bugs and ambiguity for debugging tools.  Rename the FreeBSD
struct device to struct _device.

Reviewed by:    gbe (man pages)
Reviewed by:    rpokala, imp, jhb
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D29676

A check for __FreeBSD_version > 1400009 resolves the issue.

Test Plan

Builds here.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cy requested review of this revision.Oct 19 2021, 3:47 PM
cy created this revision.

You absolutely rock- I didn't see that when I looked before, thank you!

This revision is now accepted and ready to land.Oct 19 2021, 5:15 PM
This revision was automatically updated to reflect the committed changes.

NP. I run -CURRENT and monitor the ML