Page MenuHomeFreeBSD
Differential D28438

fetch(3); Add support of HTTPS_PROXY/https_proxy environment variables
Needs ReviewPublic
Actions

Authored by yasu on Jan 31 2021, 5:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 14, 3:48 AM
Unknown Object (File)
Thu, May 14, 3:45 AM
Unknown Object (File)
Thu, May 14, 3:45 AM
Unknown Object (File)
Thu, May 14, 3:44 AM
Unknown Object (File)
Tue, May 12, 12:09 AM
Unknown Object (File)
Mon, May 11, 12:33 PM
Unknown Object (File)
Fri, May 8, 7:54 PM
Unknown Object (File)
Tue, May 5, 8:16 PM
View All Files
Subscribers
crees
imp

Details

Reviewers
des
Group Reviewers
manpages
Summary

Add support of HTTPS_PROXY/https_proxy environment variables. They
works similar to FTP_PROXY/ftp_proxy environment variables for FTP
scheme. That is, if scheme of request URL is "https" fetch(3) checks
if following environment variables are set in this order.

  1. HTTPS_PROXY
  2. https_proxy
  3. HTTP_PROXY
  4. http_proxy

And the value of first one set is used as setting of proxy for https.

Test Plan

It isn't possbile test it with unit test because web server and proxy
are required to test. I've been using this patch with -CURRENT and
it seems to work fine at least for me.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36639
Build 33528: arc lint + arc unit

Event Timeline

yasu created this revision.Jan 31 2021, 5:15 PM
Herald added a reviewer: manpages. · View Herald TranscriptJan 31 2021, 5:15 PM
Herald added a subscriber: imp. · View Herald Transcript
yasu requested review of this revision.Jan 31 2021, 5:15 PM
Harbormaster completed remote builds in B36639: Diff 83185.Jan 31 2021, 5:15 PM
crees accepted this revision as: manpages.Mar 6 2021, 2:11 PM
crees added a subscriber: crees.

Couple of minor nits-- if they're fixed (or if HTTP is correct above) then fine for manpages.

.Dd bump on commit :)

lib/libfetch/fetch.3
659

HTTP or HTTPS?

868

We use the serial comma.

Revision Contents
Changeset List

PathSize
lib/
libfetch/
22 lines
32 lines

Diff 83185

View Options

lib/libfetch/fetch.3

Loading...
View Options

lib/libfetch/http.c

Loading...