Page MenuHomeFreeBSD

salvadore (Lorenzo Salvadore)
User

Projects

User Details

User Since
Apr 2 2019, 6:04 PM (52 w, 4 d)

Recent Activity

Yesterday

salvadore committed rP530525: emulators/wine: Change tested variable for master port detection.
emulators/wine: Change tested variable for master port detection
Fri, Apr 3, 9:40 PM
salvadore closed D24262: emulators/wine: Change tested variable for master port detection.
Fri, Apr 3, 9:40 PM
salvadore added a comment to D24262: emulators/wine: Change tested variable for master port detection.

Does this fix a bug actually happening? I'm still okay, just pointing out that from a priority perspective.

Fri, Apr 3, 9:36 PM

Thu, Apr 2

salvadore added a comment to D24262: emulators/wine: Change tested variable for master port detection.

Sure. Didn't I pre-approve this backport from wine-devel?

Thu, Apr 2, 5:12 PM
salvadore created D24262: emulators/wine: Change tested variable for master port detection.
Thu, Apr 2, 4:03 PM

Wed, Apr 1

salvadore committed rP530237: sysutils/burp-devel: Update to 2.3.24.
sysutils/burp-devel: Update to 2.3.24
Wed, Apr 1, 8:07 PM
salvadore closed D24104: sysutils/burp-devel: Update to 2.3.24.
Wed, Apr 1, 8:07 PM
salvadore added a comment to D24104: sysutils/burp-devel: Update to 2.3.24.

Can someone please approve this patch (at least one of my mentors) or suggest more improvements?
I do not want to hurry, but I am under the impression that this review has been forgotten (I am starting to forgetting it myself).

Wed, Apr 1, 1:52 PM

Mon, Mar 30

salvadore committed rD54024: it_IT/articles/Makefile.inc: Fix mistake.
it_IT/articles/Makefile.inc: Fix mistake
Mon, Mar 30, 8:29 PM
salvadore closed D24223: it_IT/articles/Makefile.inc: Fix mistake.
Mon, Mar 30, 8:29 PM
salvadore created D24223: it_IT/articles/Makefile.inc: Fix mistake.
Mon, Mar 30, 4:03 PM

Sat, Mar 28

salvadore updated the summary of D19800: Gives more fexibility to kernel installation.
Sat, Mar 28, 6:52 PM
salvadore updated the diff for D19800: Gives more fexibility to kernel installation.

Fix style: before I used ifndef, but it seems that if !defined is prefered.

Sat, Mar 28, 6:50 PM
salvadore updated the diff for D19800: Gives more fexibility to kernel installation.

Rename USEKERNNAME to USEKERNCONFNAME and reverts logic: now if USEKERNCONFNAME is defined then directory will be called as kernel configurations, otherwise everything works as usual.

Sat, Mar 28, 6:48 PM

Fri, Mar 27

salvadore committed rD54018: it_IT/Makefile: Add articles directory.
it_IT/Makefile: Add articles directory
Fri, Mar 27, 10:37 PM
salvadore closed D24184: it_IT/Makefile: Add articles directory.
Fri, Mar 27, 10:37 PM
salvadore committed rP529281: math/wxmaxima: Remove obsolete patch.
math/wxmaxima: Remove obsolete patch
Fri, Mar 27, 8:49 PM
salvadore closed D24205: math/wxmaxima: Remove obsolete patch.
Fri, Mar 27, 8:49 PM
salvadore created D24205: math/wxmaxima: Remove obsolete patch.
Fri, Mar 27, 6:09 PM
salvadore committed rP529246: misc/xiphos: Properly refers to git commit 9e573336.
misc/xiphos: Properly refers to git commit 9e573336
Fri, Mar 27, 1:36 PM
salvadore closed D24190: misc/xiphos: Properly refers to commit 9e573336.
Fri, Mar 27, 1:36 PM
salvadore added a comment to D24167: emulators/wine-devel: Change tested variable for master port detection.
Fri, Mar 27, 10:53 AM
salvadore added a comment to D24167: emulators/wine-devel: Change tested variable for master port detection.
In D24167#532246, @scf wrote:

While I am late to the review, I was able to build i386-wine-devel-5.4,1 in an i386 jail and subsequently, within a amd64 jail. Thank you!

Fri, Mar 27, 10:51 AM

Thu, Mar 26

salvadore updated the diff for D24104: sysutils/burp-devel: Update to 2.3.24.

Patch updated!

Thu, Mar 26, 10:59 PM
salvadore added a comment to D24190: misc/xiphos: Properly refers to commit 9e573336.

Ah, I don't remeber why I added that digit. Maybe it would have worked without it but I added it to have the same number of digits than in the example in the porter's handbook.

Thu, Mar 26, 5:07 PM
salvadore added a comment to D24190: misc/xiphos: Properly refers to commit 9e573336.

The port is working but not respecting the standard way of using git commits.
I did a similar mistake with math/wxmaxima some days ago: https://docs.freebsd.org/cgi/getmsg.cgi?fetch=2811607+0+archive/2020/svn-ports-head/20200315.svn-ports-head . The issue is present in misc/xiphos and this patch should fix it. (Tests are running.)

Thu, Mar 26, 4:07 PM
salvadore committed rP529197: misc/sword: Replace use of REINPLACE_CMD by a patch.
misc/sword: Replace use of REINPLACE_CMD by a patch
Thu, Mar 26, 3:55 PM
salvadore closed D23568: misc/sword: remove unnecessary use of REINPLACE_CMD.
Thu, Mar 26, 3:55 PM

Wed, Mar 25

salvadore created D24190: misc/xiphos: Properly refers to commit 9e573336.
Wed, Mar 25, 10:32 PM
salvadore added a comment to D24167: emulators/wine-devel: Change tested variable for master port detection.

Committed. If this commit works as expected, we will need to forward it to emulators/wine, as emulators/i386-wine is affected by the same bug.

Wed, Mar 25, 10:07 PM
salvadore committed rP529132: emulators/wine-devel: Change tested variable for master port detection.
emulators/wine-devel: Change tested variable for master port detection
Wed, Mar 25, 10:04 PM
salvadore closed D24167: emulators/wine-devel: Change tested variable for master port detection.
Wed, Mar 25, 10:04 PM
salvadore updated the summary of D24184: it_IT/Makefile: Add articles directory.
Wed, Mar 25, 8:49 PM
salvadore updated the diff for D24184: it_IT/Makefile: Add articles directory.

Update .po and .xml file so that now the test build works.

Wed, Mar 25, 8:46 PM
salvadore created D24184: it_IT/Makefile: Add articles directory.
Wed, Mar 25, 5:25 PM
salvadore added a comment to D23568: misc/sword: remove unnecessary use of REINPLACE_CMD.

I added my mentors to the review. If they approve it, I will commit it (commit message identical to the title of this review).

Wed, Mar 25, 3:59 PM
salvadore added reviewers for D23568: misc/sword: remove unnecessary use of REINPLACE_CMD: gerald, tcberner.
Wed, Mar 25, 3:57 PM

Tue, Mar 24

salvadore committed rD54013: it_IT/articles/bsdl-gpl: Add Italian translation.
it_IT/articles/bsdl-gpl: Add Italian translation
Tue, Mar 24, 10:33 PM
salvadore closed D23598: Translate the bsdl-gpl article in Italian.
Tue, Mar 24, 10:33 PM
salvadore added a comment to D24167: emulators/wine-devel: Change tested variable for master port detection.

Thanks, I will commit it if all tests passes.
I hope @scf can find the time to look at this review since he is one of the users who reported it, if I recall correctly.

Tue, Mar 24, 2:04 PM
salvadore updated the summary of D24167: emulators/wine-devel: Change tested variable for master port detection.
Tue, Mar 24, 11:43 AM
salvadore updated the diff for D24167: emulators/wine-devel: Change tested variable for master port detection.

Try with WINE_SLAVE_BUILD variable, defined in emulators/i386-wine-devel/Makefile.i386. I would have liked to remove that variable later, but apparently it can still be useful.

Tue, Mar 24, 11:42 AM

Mon, Mar 23

salvadore added a comment to D24167: emulators/wine-devel: Change tested variable for master port detection.

Still not the good test: i386-wine-devel does not work with _POSTMKINCLUDED.
I need to study better the issue.

Mon, Mar 23, 9:32 PM
salvadore updated the summary of D24167: emulators/wine-devel: Change tested variable for master port detection.
Mon, Mar 23, 4:48 PM
salvadore updated the diff for D24167: emulators/wine-devel: Change tested variable for master port detection.

MASTERDIR breaks wine-devel. Try with _POSTMKINCLUDED, which is what bsd.port.mk uses at line 1580.

Mon, Mar 23, 4:47 PM
salvadore updated the summary of D24167: emulators/wine-devel: Change tested variable for master port detection.
Mon, Mar 23, 4:33 PM
salvadore created D24167: emulators/wine-devel: Change tested variable for master port detection.
Mon, Mar 23, 4:31 PM

Sun, Mar 22

salvadore added a comment to D24104: sysutils/burp-devel: Update to 2.3.24.

By the way, I just realized that up to now we have indeed distributed through binary packages the modified rc script, without any declaration on copyrights and license for these modifications. And we regularly do that in the ports tree for any port that patches the files it fetches. I guess then that it would be fine to just continue doing that?

Sun, Mar 22, 3:34 PM
salvadore added a comment to D24104: sysutils/burp-devel: Update to 2.3.24.

You're right 0mp, I forgot about the binary packages...
I asked for help to the FreeBSD Foundation as you suggested. I am still confused about this topic.

Sun, Mar 22, 3:26 PM

Sat, Mar 21

salvadore updated the diff for D24104: sysutils/burp-devel: Update to 2.3.24.

Address received comments

Sat, Mar 21, 11:52 PM
salvadore added a comment to D24104: sysutils/burp-devel: Update to 2.3.24.

I added portmgr as reviewers: maybe they can help on the licensing issue.

Sat, Mar 21, 11:19 AM
salvadore added a reviewer for D24104: sysutils/burp-devel: Update to 2.3.24: portmgr.
Sat, Mar 21, 11:18 AM
salvadore added a comment to D24104: sysutils/burp-devel: Update to 2.3.24.

The license change. The current license is fine for us, and I am not sure you can simply put a more restrictive license on something in the public domain (but in any case: what's the advantage)? If you want to proceed with that, we'd need to consult some legal experts.

Sat, Mar 21, 11:17 AM

Fri, Mar 20

salvadore committed rP528784: Update i386-wine-devel/files/nvidia.sh.
Update i386-wine-devel/files/nvidia.sh
Fri, Mar 20, 3:23 PM

Thu, Mar 19

salvadore added a comment to D24127: Resurrect biology/linux-foldingathome.

I still have to test the patch properly, but here is some initial feedback:

  • the port builds successfully on 13.0-CURRENT r358923 (but I have not tested it yet, due to the fact that I run a custom kernel and similar issues);
  • etc/fahclient/config.xml file is with CRLF line terminators;
  • it would be nice to have an option to join the FreeBSD team (according to https://www.leidinger.net/blog/category/freebsd/linuxolator/ its number is 11743).
Thu, Mar 19, 11:52 PM

Tue, Mar 17

salvadore created D24104: sysutils/burp-devel: Update to 2.3.24.
Tue, Mar 17, 9:54 PM
salvadore committed rP528581: math/wxmaxima: Update to 20.03.1.
math/wxmaxima: Update to 20.03.1
Tue, Mar 17, 2:42 PM

Mon, Mar 16

salvadore committed rS359028: Add tcberner as co-mentor for salvadore.
Add tcberner as co-mentor for salvadore
Mon, Mar 16, 11:38 PM

Sun, Mar 15

salvadore updated subscribers of D23568: misc/sword: remove unnecessary use of REINPLACE_CMD.
Sun, Mar 15, 10:06 AM
salvadore added a comment to D23568: misc/sword: remove unnecessary use of REINPLACE_CMD.

It seems this review has been forgotten for a month. In the meantime I became a (mentored) committer: do you want me to commit it?

Sun, Mar 15, 10:05 AM

Fri, Mar 13

salvadore committed rP528378: emulators/i386-wine: Use standard ports infrastructure for ARCH.
emulators/i386-wine: Use standard ports infrastructure for ARCH
Fri, Mar 13, 9:11 PM
salvadore committed rP528347: math/wxmaxima: Update to git commit 68fead0.
math/wxmaxima: Update to git commit 68fead0
Fri, Mar 13, 12:33 PM

Thu, Mar 12

salvadore added a comment to D23598: Translate the bsdl-gpl article in Italian.

Added another pair of committers who committed in the past to Italian documentation.

Thu, Mar 12, 8:23 PM
salvadore added reviewers for D23598: Translate the bsdl-gpl article in Italian: blackend, trhodes.
Thu, Mar 12, 8:22 PM

Wed, Mar 11

salvadore committed rP528249: emulators/i386-wine-devel: Use standard ports infrastructure for ARCH.
emulators/i386-wine-devel: Use standard ports infrastructure for ARCH
Wed, Mar 11, 7:50 PM

Tue, Mar 10

salvadore committed rP528199: www/phalcon: Portscout fix and minor cleanup.
www/phalcon: Portscout fix and minor cleanup
Tue, Mar 10, 10:03 PM

Sat, Mar 7

salvadore added a comment to D23598: Translate the bsdl-gpl article in Italian.

I added ale as a reviewer since he is a doc committer and worked on the Italian documentation according to svn logs. Maybe he can approve this translation.

Sat, Mar 7, 6:41 PM
salvadore added a reviewer for D23598: Translate the bsdl-gpl article in Italian: ale.
Sat, Mar 7, 6:40 PM

Mar 3 2020

salvadore committed rP527659: Add debug support for math/wxmaxima.
Add debug support for math/wxmaxima
Mar 3 2020, 12:45 AM

Mar 1 2020

salvadore committed rP527552: Update sysutils/bsdstats to 6.2.
Update sysutils/bsdstats to 6.2
Mar 1 2020, 1:27 PM
salvadore committed rP527549: Resurrect, update and adopt misc/xiphos.
Resurrect, update and adopt misc/xiphos
Mar 1 2020, 12:47 PM

Feb 28 2020

salvadore added a comment to D23598: Translate the bsdl-gpl article in Italian.

As @madpilot doesn't have doc commit bit (the same happens with me in pt_BR), a doc committer needs to review/approve this patch so he can proceed with the commit, and that part will be necessary.

Feb 28 2020, 12:06 PM
salvadore updated the diff for D23598: Translate the bsdl-gpl article in Italian.

I addressed last comment from madpilot.
I also recreated the diff using the --show-copies-as-adds option: without it the content of Makefile, copied fron en_US.ISO8859-1/articles/bsdl-gpl/Makefile was not visible.

Feb 28 2020, 10:17 AM

Feb 27 2020

salvadore committed rP527259: Update lang/ecl from 15.3.7 to 16.1.3.
Update lang/ecl from 15.3.7 to 16.1.3
Feb 27 2020, 2:58 PM
salvadore committed rP527251: Update math/wxmaxima from 20.02.1 to 20.02.4.
Update math/wxmaxima from 20.02.1 to 20.02.4
Feb 27 2020, 12:19 PM

Feb 26 2020

salvadore added a comment to D23598: Translate the bsdl-gpl article in Italian.

Sorry, I had forgotten to mark the comments as done (I have used phabricator only a few times, I still need to get more familiar with it).

Feb 26 2020, 6:56 PM

Feb 25 2020

salvadore committed rP527076: Migrate the STAGING option to use option helpers.
Migrate the STAGING option to use option helpers
Feb 25 2020, 12:12 PM

Feb 23 2020

salvadore committed rP526919: Update math/wxmaxima from 20.01.3 to 20.02.1.
Update math/wxmaxima from 20.01.3 to 20.02.1
Feb 23 2020, 12:55 PM

Feb 22 2020

salvadore committed rS358250: Add myself (salvadore) as a ports committer.
Add myself (salvadore) as a ports committer
Feb 22 2020, 5:56 PM
salvadore committed rD53934: Add myself (salvadore) as a ports committer.
Add myself (salvadore) as a ports committer
Feb 22 2020, 5:53 PM

Feb 14 2020

salvadore updated the diff for D23598: Translate the bsdl-gpl article in Italian.

Thanks @madpilot for all the useful comments. I have followed all of them almost exactly, with very few exceptions.
For example, I choosed "riassunto comparativo delle licenze" instead of "riassunto comparativo tra le licenze" considering that you normaly make "un riassunto di qualcosa" or "un paragone o una comparazione tra due cose" and thus the choice was between "riassunto comparativo di" or "paragone riassuntivo tra".
About "economico beneficio trasferibile" -> "beneficio economico trasferibile" I did not accept the suggestion because I understood that my original translation was so bad that it was misleading, so I correct it with "beneficio trasferibile poco costoso" (the original is "cheap protable benefit").
I also corrected the "casalinghi" place by accepting the suggestion ("sistemi proprietari"), but also correcting the meaning of the translation: in the original text the systems were home made and became proprietary while in my precedent translation it was the opposite... Now the right direction has been restored.
About the comment on the Italian research center CNR, I maintained the US examples by definining them as americans and I added the CNR specifying it as an Italian example.

Feb 14 2020, 11:21 PM
salvadore added a comment to D23589: Porter's Handbook: explain ports signature policy for older ports.

@crees Feel free to commandeer the review if you need it to submit the right patch in the most natural way: I would not take offense :)

Feb 14 2020, 9:30 PM

Feb 12 2020

salvadore added a comment to D23589: Porter's Handbook: explain ports signature policy for older ports.

I proposed this patch because I feel there is some confusion on the topic. This feeling comes from my own experience when I was a new contributor.

Feb 12 2020, 8:12 PM

Feb 11 2020

salvadore updated subscribers of D23598: Translate the bsdl-gpl article in Italian.
Feb 11 2020, 8:53 AM
salvadore added a comment to D23598: Translate the bsdl-gpl article in Italian.

I updated the test plan as you suggested.

Feb 11 2020, 8:52 AM
salvadore updated the test plan for D23598: Translate the bsdl-gpl article in Italian.
Feb 11 2020, 8:47 AM

Feb 10 2020

salvadore added a comment to D23590: Correct policy for new ports' summary standard format.

When we know about Mat, please keep in mind that I have no commit bit, so someone else should commit the patch for me. Thanks.

Feb 10 2020, 7:56 PM
salvadore created D23598: Translate the bsdl-gpl article in Italian.
Feb 10 2020, 8:54 AM

Feb 9 2020

salvadore updated the diff for D23590: Correct policy for new ports' summary standard format.

Sorry, I was copying the diff from a bug report I created long time ago and I copied it wrong. Now it should be fixed.
If anyone wants to see the bug report, you can find it at
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232816

Feb 9 2020, 10:04 PM
salvadore created D23590: Correct policy for new ports' summary standard format.
Feb 9 2020, 3:06 PM
salvadore created D23589: Porter's Handbook: explain ports signature policy for older ports.
Feb 9 2020, 2:57 PM
salvadore created D23588: Fixes to the bsdl-gpl article.
Feb 9 2020, 2:25 PM

Feb 7 2020

salvadore accepted D23568: misc/sword: remove unnecessary use of REINPLACE_CMD.

You're right.
Let's commit it then.

Feb 7 2020, 2:59 PM
salvadore added a comment to D23568: misc/sword: remove unnecessary use of REINPLACE_CMD.

I understand that the file you add does the same thing than the ${REINPLACE_CMD}, but why do you prefer using a file? I do not see the advantage. On the contrary I see disadvantages:

  • your file is more byte expensive than the ${REINPLACE_CMD} (sure, in 2020 it does not do much difference for most users, but we never know);
  • your file is harder to maintain: it might need to be recreated for any update of the port, while the ${REINPLACE_CMD} will most probably always work.
Feb 7 2020, 2:19 PM

Feb 4 2020

salvadore added a member for docs: salvadore.
Feb 4 2020, 3:05 PM

Feb 2 2020

salvadore updated the diff for D23473: Update quarterly status reports README.

Sorry, I had forgotten to fix the list numbers after I removed a section, which has been included in the precedent section.

Feb 2 2020, 11:12 PM
salvadore created D23473: Update quarterly status reports README.
Feb 2 2020, 11:08 PM

Jan 20 2020

salvadore updated the diff for D23256: Create 2019Q4 quarterly status report.

Fix issues with list, headers and <blockquote> tags.

Jan 20 2020, 5:45 PM

Jan 19 2020

salvadore created D23256: Create 2019Q4 quarterly status report.
Jan 19 2020, 12:01 AM

Jan 18 2020

salvadore added a comment to D14154: bsd.gecko.mk: add conditional for ccache.

This revision is accepted and ready to land since months. Can a committer commit it please?

Jan 18 2020, 10:53 AM