I moved the comment from within the patch to the top of it: it is a different style than the one used by Thierry for the other patches he introduced, but I think it makes more sense in this case.

Remove the use of "You".

Fix commit r537957 by removing 'make fetch' and using 'make makesum' only.

@mckusick, @bcr: Thanks for the pointers! At the end I set MFC after: 2 weeks, choosing the maximal value suggested by mckusick. It's true that it's an easy patch, but it's also true that nothing was broken, so there is no urgency.

Also, can someone please point me to some documentation about MFC on the base tree? I can't find any which is complete enough.

@mckusick: Thanks! Does that count as a src committer approval? I ask because as ports committer, according to the committer guide, I need a src committer approval to commit to the base tree, but you are not listed in share/misc/committers-src.dot.

Use the release file instead of patching the sources downloaded with USE_GITHUB, as suggested by tcberner.

I fixed the issue following thierry's suggestion.
And I also fixed the issue with the man pages.

In D25303#558653, @zeising wrote:

In D25303#558622, @thierry wrote:

I tested it with ECL-20.4.24 from PR 247283, but pkg-plist is not versioned:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/ecl-20.4.24/%%BINNAME%%.fas
Error: Orphaned: man/de/man1/%%BINNAME%%.1.gz
Error: Orphaned: man/ru/man1/%%BINNAME%%.1.gz
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/ecl-16.1.3/%%BINNAME%%.fas

I can add this as a fix in my update for ecl if you want.
I guess it's hard to do it here, and easier to do it as part of ecl update?

In D25266#558504, @mckusick wrote:

One other suggestion is to change "normal" to "timeshare" or perhaps "timeshr" as that name is more descriptive of what is being reported.

I added the level for the normal case as suggested. Thanks mckusick for your feedback!

@thierry: Please be particularly careful to extra-patch-src_hayat.lisp: a chunk of the original patch you submitted is no more appliable to maxima 5.44.0.

Thanks bcr, I have put the cross-reference as you suggested.

@mckusick: As you can see the patch I am submitting is different from what we discussed by mail. As suggested in the summary of the review, this is due to the fact that I think realtime priorities are a different concept than standard scheduler priorities: looking at man 1 rtprio, at sys/sys/rtprio.h and at sys/kern/kern_resource.c, I think realtime priorities work as follow.

I edited the patch following thierry's suggestion and added a comment to
remember what's the issue with that dependency.

Sorry, I forgot about a warning from mat: line 11 is now part of the comment started at line 10.
I have to look at this review again.

This time I have tested it properly in a poudriere jail. (Only one, I hope it's enough.)

@olgeni: Thanks! I am going to commit it in a minute.

@crees: Feel free to get this. I took it only because I read on IRC that this review needed attention, but I don't know much about mono and you will surely do a better work than me.
However you should probably take a look at https://reviews.freebsd.org/D24988 , which tries to improve this patch.

@gerald: It must be it.

@tcberner: Thanks! I wonder what I was trying to remember then.

Unfortunately I think it is very unlikely that thoses patches can be merged upstream: I have introduced them because their build system is very complicate to use on FreeBSD (and I guess on Linux as well as soon as something is non standard) and I found easier to completely bypass it. What upstream should do, in my opinion, is redesigning it from scratch, but this would need much more work than my patches and I think they lack the time to deal with it.

We talked about pointy hats long time ago and I never had the occasion to wear one. If I remember correctly, it's the hat I can wear to make trivial commits without the need to wait for maintainer approval or maintainer timeout: can I wear one now?

Change CONFIGURE_ARGS+= --with-wish=${WISH} into XMAXIMA_CONFIGURE_WITH= wish=${WISH}.

Fix xmaxima bug about documentation. This also introduces an XMAXIMA option (enabled by default) because to have xmaxima working we need to ensure that DOCS and TEST are on, which is done by using XMAXIMA_IMPLIES. This also has the advantage to remove USES= tk for users who want to disable XMAXIMA.

On second thought, I am going to try to fix the documentation bug for xmaxima now. I hope it to be easy enough and if it is it will save me some testing.

I can commit it and I will do it in a minute.
Thanks!

In D24959#554935, @thierry wrote:

But the problem with xmaxima reported in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246599#c5 is still there:

when I launch xmaxima (not wxmaxima as written in the PR!), it displays the error:

Documentation not found in '/usr/local/share/maxima/5.43.2'

Either the online doc must be moved from $DOCSDIR to $DATADIR, as it was done in my initial proposition, or the code must be patched to find it.

• Add init-cl.lisp patch. I have added a comment about the patch being borrowed from SageMath as you did for all other files. See however https://reviews.freebsd.org/D25180 (I think you forgot a reference for lang/ecl).

@thierry: Correct me if I am wrong, but I think you took that patch from https://git.sagemath.org/sage.git/tree/build/pkgs/ecl/patches/src/implib.patch .
It is probably useful to acknowledge SageMath, both for reference and for copyright (by the way, I am trusting you that we can add to the ports tree all the patches you borrowed -- both for ecl and for maxima -- without legal issues: I am not a lawyer and I have not checked).

In D24959#554776, @thierry wrote:

I don't understand how it could work, because it looks like it only removes a comment… but it does, and the problem is fixed!

About info directory: I haven't done anything. Let me know if you need anything once your investigations are done.

I confirm that maxima links to libgc-threaded.so.1 if and only if ecl is built with threads.

Please consider it as a work in progress. There are still a few things I have to check and fix.

Remove a useless line that I had left commented and a comment not so useful.

This should work. I still have to finish testing it, but I had the first successfull poudriere build.
With ECL on I got a file linked to libgc-threaded.so and thus I should add libgc-threaded.so:devel/boehm-gc-threaded dependency. However I suspect that this happens only when ecl is built with THREADS on (it's the default). In that case, I think I should not declare the dependecy since:

• if ECL is installed with THREADS on libgc-threaded.so installed as well;
• if ECL is installed with THREADS off maxima is not linked to libgc-threaded.so.

Is that correct?

I committed the changes you proposed. Since you proposed them (and I tested them successfully) I considered them approved although I later noticed this review was marked as needing changes. I hope it is not a problem.