Page MenuHomeFreeBSD

salvadore (Lorenzo Salvadore)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Apr 2 2019, 6:04 PM (77 w, 2 d)
Roles
Disabled

Recent Activity

Jun 23 2020

salvadore removed a member for Ports Committers: salvadore.
Jun 23 2020, 9:45 AM
salvadore removed a member for docs: salvadore.
Jun 23 2020, 9:44 AM
salvadore removed a member for committers: salvadore.
Jun 23 2020, 9:44 AM
salvadore requested review of D25244: lang/ecl: Fix r538595.
Jun 23 2020, 3:26 AM
salvadore closed D25180: lang/ecl: Fix missing reference to SageMath.
Jun 23 2020, 3:26 AM
salvadore closed D24741: htdocs/news/status.xml: Update e-mail address for submissions.
Jun 23 2020, 3:23 AM
salvadore requested review of D25296: sysutils/bsdstats: Update to 7.1.
Jun 23 2020, 3:22 AM
salvadore closed D25244: lang/ecl: Fix r538595.
Jun 23 2020, 3:21 AM
salvadore updated the diff for D25244: lang/ecl: Fix r538595.

I moved the comment from within the patch to the top of it: it is a different style than the one used by Thierry for the other patches he introduced, but I think it makes more sense in this case.

Jun 23 2020, 3:21 AM
salvadore closed D25158: emulators/i386-wine-devel: Fix distinfo-update.
Jun 23 2020, 3:21 AM
salvadore closed D25172: articles/contributing: Suggest checking build warnings through our CI.
Jun 23 2020, 3:21 AM
salvadore requested review of D25172: articles/contributing: Suggest checking build warnings through our CI.
Jun 23 2020, 3:21 AM
salvadore updated the diff for D25172: articles/contributing: Suggest checking build warnings through our CI.

Remove the use of "You".

Jun 23 2020, 3:21 AM
salvadore requested review of D25180: lang/ecl: Fix missing reference to SageMath.
Jun 23 2020, 3:21 AM
salvadore updated the diff for D25158: emulators/i386-wine-devel: Fix distinfo-update.

Fix commit r537957 by removing 'make fetch' and using 'make makesum' only.

Jun 23 2020, 3:21 AM
salvadore requested review of D25158: emulators/i386-wine-devel: Fix distinfo-update.
Jun 23 2020, 3:21 AM
salvadore closed D25042: emulators/i386-wine-devel: Transform maintainance target into script.
Jun 23 2020, 3:21 AM
salvadore closed D25109: sysutils/bsdstats: Switch to https for WWW.
Jun 23 2020, 3:20 AM
salvadore requested review of D25109: sysutils/bsdstats: Switch to https for WWW.
Jun 23 2020, 3:20 AM
salvadore requested review of D24748: Handbook: List new freebsd-quarterly-calls mailing list.
Jun 23 2020, 3:17 AM
salvadore requested review of D24741: htdocs/news/status.xml: Update e-mail address for submissions.
Jun 23 2020, 3:16 AM
salvadore closed D24381: books/porters-handbook: Fix mistake in vuln.xml description.
Jun 23 2020, 3:16 AM
salvadore closed D24607: emulators/i386-wine-devel: Simplify PLIST variables.
Jun 23 2020, 3:16 AM
salvadore requested review of D24607: emulators/i386-wine-devel: Simplify PLIST variables.
Jun 23 2020, 3:16 AM

Jun 21 2020

salvadore committed rP539770: Drop ports maintainership.
Drop ports maintainership
Jun 21 2020, 3:36 PM

Jun 19 2020

salvadore committed rP539671: misc/xiphos: Update to 4.2.1.
misc/xiphos: Update to 4.2.1
Jun 19 2020, 5:37 PM
salvadore closed D25320: misc/xiphos: Update to 4.2.1.
Jun 19 2020, 5:37 PM
salvadore added a comment to D25266: bin/ps: Make the rtprio option actually show realtime priorities.

@mckusick, @bcr: Thanks for the pointers! At the end I set MFC after: 2 weeks, choosing the maximal value suggested by mckusick. It's true that it's an easy patch, but it's also true that nothing was broken, so there is no urgency.

Jun 19 2020, 9:33 AM
salvadore closed D25266: bin/ps: Make the rtprio option actually show realtime priorities.
Jun 19 2020, 9:28 AM
salvadore committed rS362369: bin/ps: Make the rtprio option actually show realtime priorities.
bin/ps: Make the rtprio option actually show realtime priorities
Jun 19 2020, 9:28 AM

Jun 18 2020

salvadore added a comment to D25266: bin/ps: Make the rtprio option actually show realtime priorities.

Also, can someone please point me to some documentation about MFC on the base tree? I can't find any which is complete enough.

Jun 18 2020, 11:58 PM
salvadore added a comment to D25266: bin/ps: Make the rtprio option actually show realtime priorities.

@mckusick: Thanks! Does that count as a src committer approval? I ask because as ports committer, according to the committer guide, I need a src committer approval to commit to the base tree, but you are not listed in share/misc/committers-src.dot.

Jun 18 2020, 10:46 PM
salvadore requested review of D25350: emulators/i386-wine-devel: Fix mono and gecko dependencies.
Jun 18 2020, 10:00 PM
salvadore updated the diff for D25320: misc/xiphos: Update to 4.2.1.

Use the release file instead of patching the sources downloaded with USE_GITHUB, as suggested by tcberner.

Jun 18 2020, 5:52 PM
salvadore updated the diff for D25303: math/maxima: Update to 5.44.0.

I fixed the issue following thierry's suggestion.
And I also fixed the issue with the man pages.

Jun 18 2020, 1:55 PM
salvadore added a comment to D25303: math/maxima: Update to 5.44.0.

I tested it with ECL-20.4.24 from PR 247283, but pkg-plist is not versioned:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/ecl-20.4.24/%%BINNAME%%.fas
Error: Orphaned: man/de/man1/%%BINNAME%%.1.gz
Error: Orphaned: man/ru/man1/%%BINNAME%%.1.gz
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/ecl-16.1.3/%%BINNAME%%.fas

I can add this as a fix in my update for ecl if you want.
I guess it's hard to do it here, and easier to do it as part of ecl update?

Jun 18 2020, 11:25 AM
salvadore added a comment to D25266: bin/ps: Make the rtprio option actually show realtime priorities.

One other suggestion is to change "normal" to "timeshare" or perhaps "timeshr" as that name is more descriptive of what is being reported.

Jun 18 2020, 11:23 AM
salvadore added inline comments to D25296: sysutils/bsdstats: Update to 7.1.
Jun 18 2020, 11:04 AM
salvadore added inline comments to D25296: sysutils/bsdstats: Update to 7.1.
Jun 18 2020, 10:57 AM
salvadore added inline comments to D25320: misc/xiphos: Update to 4.2.1.
Jun 18 2020, 9:18 AM
salvadore requested review of D25320: misc/xiphos: Update to 4.2.1.
Jun 18 2020, 9:18 AM

Jun 16 2020

salvadore updated the diff for D25266: bin/ps: Make the rtprio option actually show realtime priorities.

I added the level for the normal case as suggested. Thanks mckusick for your feedback!

Jun 16 2020, 10:46 PM
salvadore committed rP539385: emulators/i386-wine-devel: Fix conflict with x11/nvidia-driver.
emulators/i386-wine-devel: Fix conflict with x11/nvidia-driver
Jun 16 2020, 10:39 PM
salvadore added a comment to D25303: math/maxima: Update to 5.44.0.

@thierry: Please be particularly careful to extra-patch-src_hayat.lisp: a chunk of the original patch you submitted is no more appliable to maxima 5.44.0.

Jun 16 2020, 10:14 PM
salvadore requested review of D25303: math/maxima: Update to 5.44.0.
Jun 16 2020, 10:08 PM
salvadore added a reviewer for D25266: bin/ps: Make the rtprio option actually show realtime priorities: Src Committers.
Jun 16 2020, 1:55 PM

Jun 15 2020

salvadore committed rP538922: math/maxima: Add ECL and SAGE options.
math/maxima: Add ECL and SAGE options
Jun 15 2020, 5:08 PM
salvadore closed D24959: math/maxima: Add ECL and SAGE options.
Jun 15 2020, 5:08 PM

Jun 14 2020

salvadore updated the diff for D25266: bin/ps: Make the rtprio option actually show realtime priorities.

Thanks bcr, I have put the cross-reference as you suggested.

Jun 14 2020, 3:29 PM
salvadore added a comment to D25266: bin/ps: Make the rtprio option actually show realtime priorities.

@mckusick: As you can see the patch I am submitting is different from what we discussed by mail. As suggested in the summary of the review, this is due to the fact that I think realtime priorities are a different concept than standard scheduler priorities: looking at man 1 rtprio, at sys/sys/rtprio.h and at sys/kern/kern_resource.c, I think realtime priorities work as follow.

Jun 14 2020, 10:08 AM
salvadore requested review of D25266: bin/ps: Make the rtprio option actually show realtime priorities.
Jun 14 2020, 9:51 AM

Jun 13 2020

salvadore updated the diff for D24959: math/maxima: Add ECL and SAGE options.

I edited the patch following thierry's suggestion and added a comment to
remember what's the issue with that dependency.

Jun 13 2020, 10:12 PM
salvadore committed rP538656: lang/ecl: Fix r538595.
lang/ecl: Fix r538595
Jun 13 2020, 9:26 AM

Jun 12 2020

salvadore added a comment to D25244: lang/ecl: Fix r538595.

Sorry, I forgot about a warning from mat: line 11 is now part of the comment started at line 10.
I have to look at this review again.

Jun 12 2020, 12:18 PM
salvadore added a comment to D25244: lang/ecl: Fix r538595.

This time I have tested it properly in a poudriere jail. (Only one, I hope it's enough.)

Jun 12 2020, 11:40 AM
salvadore committed rP538595: lang/ecl: Fix missing reference to SageMath.
lang/ecl: Fix missing reference to SageMath
Jun 12 2020, 10:36 AM
salvadore added a comment to D25180: lang/ecl: Fix missing reference to SageMath.

@olgeni: Thanks! I am going to commit it in a minute.

Jun 12 2020, 10:33 AM
salvadore added a comment to D23300: lang/mono: take maintainership, update to 6.8.0.105.

@crees: Feel free to get this. I took it only because I read on IRC that this review needed attention, but I don't know much about mono and you will surely do a better work than me.
However you should probably take a look at https://reviews.freebsd.org/D24988 , which tries to improve this patch.

Jun 12 2020, 10:19 AM · mono
salvadore added a comment to D25180: lang/ecl: Fix missing reference to SageMath.

@gerald: It must be it.

Jun 12 2020, 9:56 AM

Jun 11 2020

salvadore added a comment to D25180: lang/ecl: Fix missing reference to SageMath.

@tcberner: Thanks! I wonder what I was trying to remember then.

Jun 11 2020, 8:36 PM
salvadore committed rP538538: emulators/i386-wine-devel: Fix distinfo-update.
emulators/i386-wine-devel: Fix distinfo-update
Jun 11 2020, 8:29 PM
salvadore committed rP538535: math/cocoalib: Update to 0.99710.
math/cocoalib: Update to 0.99710
Jun 11 2020, 8:22 PM
salvadore closed D25234: math/cocoalib: Update to 0.99710.
Jun 11 2020, 8:22 PM
salvadore added a comment to D25234: math/cocoalib: Update to 0.99710.

Unfortunately I think it is very unlikely that thoses patches can be merged upstream: I have introduced them because their build system is very complicate to use on FreeBSD (and I guess on Linux as well as soon as something is non standard) and I found easier to completely bypass it. What upstream should do, in my opinion, is redesigning it from scratch, but this would need much more work than my patches and I think they lack the time to deal with it.

Jun 11 2020, 8:18 PM
salvadore added a comment to D25180: lang/ecl: Fix missing reference to SageMath.

We talked about pointy hats long time ago and I never had the occasion to wear one. If I remember correctly, it's the hat I can wear to make trivial commits without the need to wait for maintainer approval or maintainer timeout: can I wear one now?

Jun 11 2020, 7:47 PM
salvadore requested review of D25234: math/cocoalib: Update to 0.99710.
Jun 11 2020, 3:29 PM

Jun 10 2020

salvadore committed rP538402: x11-wm/hikari: Update to 2.0.1.
x11-wm/hikari: Update to 2.0.1
Jun 10 2020, 3:39 PM

Jun 9 2020

salvadore updated subscribers of D24959: math/maxima: Add ECL and SAGE options.
Jun 9 2020, 8:04 PM
salvadore updated the diff for D24959: math/maxima: Add ECL and SAGE options.

Change CONFIGURE_ARGS+= --with-wish=${WISH} into XMAXIMA_CONFIGURE_WITH= wish=${WISH}.

Jun 9 2020, 7:15 PM
salvadore committed rD54222: htdocs/news/status: Update README.
htdocs/news/status: Update README
Jun 9 2020, 11:23 AM
salvadore closed D25193: htdocs/news/status: Update README.
Jun 9 2020, 11:23 AM

Jun 8 2020

salvadore updated the summary of D24959: math/maxima: Add ECL and SAGE options.
Jun 8 2020, 10:02 PM
salvadore requested review of D25193: htdocs/news/status: Update README.
Jun 8 2020, 9:17 PM
salvadore updated the summary of D24959: math/maxima: Add ECL and SAGE options.
Jun 8 2020, 5:49 PM
salvadore updated the diff for D24959: math/maxima: Add ECL and SAGE options.

Fix xmaxima bug about documentation. This also introduces an XMAXIMA option (enabled by default) because to have xmaxima working we need to ensure that DOCS and TEST are on, which is done by using XMAXIMA_IMPLIES. This also has the advantage to remove USES= tk for users who want to disable XMAXIMA.

Jun 8 2020, 5:46 PM
salvadore added a comment to D24959: math/maxima: Add ECL and SAGE options.

On second thought, I am going to try to fix the documentation bug for xmaxima now. I hope it to be easy enough and if it is it will save me some testing.

Jun 8 2020, 10:17 AM
salvadore committed rD54220: articles/contributing: Suggest checking build warnings through our CI.
articles/contributing: Suggest checking build warnings through our CI
Jun 8 2020, 9:55 AM
salvadore added a comment to D25172: articles/contributing: Suggest checking build warnings through our CI.

I can commit it and I will do it in a minute.
Thanks!

Jun 8 2020, 9:51 AM
salvadore added a comment to D24959: math/maxima: Add ECL and SAGE options.

But the problem with xmaxima reported in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246599#c5 is still there:

when I launch xmaxima (not wxmaxima as written in the PR!), it displays the error:

Documentation not found in '/usr/local/share/maxima/5.43.2'

Either the online doc must be moved from $DOCSDIR to $DATADIR, as it was done in my initial proposition, or the code must be patched to find it.

Jun 8 2020, 9:42 AM

Jun 7 2020

salvadore retitled D24959: math/maxima: Add ECL and SAGE options from math/maxima: Add ecl support to math/maxima: Add ECL and SAGE options.
Jun 7 2020, 10:59 PM
salvadore updated the diff for D24959: math/maxima: Add ECL and SAGE options.
  • Add init-cl.lisp patch. I have added a comment about the patch being borrowed from SageMath as you did for all other files. See however https://reviews.freebsd.org/D25180 (I think you forgot a reference for lang/ecl).
Jun 7 2020, 10:54 PM
salvadore added a comment to D25180: lang/ecl: Fix missing reference to SageMath.

@thierry: Correct me if I am wrong, but I think you took that patch from https://git.sagemath.org/sage.git/tree/build/pkgs/ecl/patches/src/implib.patch .
It is probably useful to acknowledge SageMath, both for reference and for copyright (by the way, I am trusting you that we can add to the ports tree all the patches you borrowed -- both for ecl and for maxima -- without legal issues: I am not a lawyer and I have not checked).

Jun 7 2020, 10:15 PM
salvadore updated the test plan for D25180: lang/ecl: Fix missing reference to SageMath.
Jun 7 2020, 10:11 PM
salvadore added a comment to D24959: math/maxima: Add ECL and SAGE options.

I don't understand how it could work, because it looks like it only removes a comment… but it does, and the problem is fixed!

Jun 7 2020, 8:23 PM
salvadore updated the diff for D24959: math/maxima: Add ECL and SAGE options.

About info directory: I haven't done anything. Let me know if you need anything once your investigations are done.

Jun 7 2020, 4:25 PM
salvadore added a comment to D24959: math/maxima: Add ECL and SAGE options.

I confirm that maxima links to libgc-threaded.so.1 if and only if ecl is built with threads.

Jun 7 2020, 12:55 PM
salvadore added a comment to D24959: math/maxima: Add ECL and SAGE options.

Please consider it as a work in progress. There are still a few things I have to check and fix.

Jun 7 2020, 12:44 AM
salvadore updated the diff for D24959: math/maxima: Add ECL and SAGE options.

Remove a useless line that I had left commented and a comment not so useful.

Jun 7 2020, 12:33 AM
salvadore retitled D24959: math/maxima: Add ECL and SAGE options from New port: math/maxima-sage to math/maxima: Add ecl support.
Jun 7 2020, 12:31 AM
salvadore updated the diff for D24959: math/maxima: Add ECL and SAGE options.

This should work. I still have to finish testing it, but I had the first successfull poudriere build.
With ECL on I got a file linked to libgc-threaded.so and thus I should add libgc-threaded.so:devel/boehm-gc-threaded dependency. However I suspect that this happens only when ecl is built with THREADS on (it's the default). In that case, I think I should not declare the dependecy since:

  • if ECL is installed with THREADS on libgc-threaded.so installed as well;
  • if ECL is installed with THREADS off maxima is not linked to libgc-threaded.so.

Is that correct?

Jun 7 2020, 12:27 AM

Jun 6 2020

salvadore committed rP538088: math/libnormaliz: Update to 3.8.5.
math/libnormaliz: Update to 3.8.5
Jun 6 2020, 1:20 PM

Jun 5 2020

salvadore updated the summary of D25158: emulators/i386-wine-devel: Fix distinfo-update.
Jun 5 2020, 9:27 PM
salvadore retitled D25158: emulators/i386-wine-devel: Fix distinfo-update from emulators/i386-wine-devel: Revert r537957 to emulators/i386-wine-devel: Fix distinfo-update.
Jun 5 2020, 9:27 PM
salvadore committed rP538019: sysutils/bsdstats: Give maintainership to scrappy.
sysutils/bsdstats: Give maintainership to scrappy
Jun 5 2020, 1:52 PM

Jun 4 2020

salvadore added a comment to D25042: emulators/i386-wine-devel: Transform maintainance target into script.

I committed the changes you proposed. Since you proposed them (and I tested them successfully) I considered them approved although I later noticed this review was marked as needing changes. I hope it is not a problem.

Jun 4 2020, 8:19 PM
salvadore committed rP537957: emulators/i386-wine-devel: Small simplification for distinfo-update.
emulators/i386-wine-devel: Small simplification for distinfo-update
Jun 4 2020, 8:15 PM

Jun 3 2020

salvadore committed rP537855: Put some ports back in the pool.
Put some ports back in the pool
Jun 3 2020, 9:54 PM
salvadore closed D25110: Put some ports back to the pool.
Jun 3 2020, 9:54 PM
salvadore committed rP537854: sysutils/bsdstats: Switch to https for WWW.
sysutils/bsdstats: Switch to https for WWW
Jun 3 2020, 9:51 PM
salvadore committed rP537836: x11-wm/hikari: Update to 2.0.0.
x11-wm/hikari: Update to 2.0.0
Jun 3 2020, 7:28 PM