In D24262#534074, @gerald wrote:

Does this fix a bug actually happening? I'm still okay, just pointing out that from a priority perspective.

In D24262#533806, @gerald wrote:

Sure. Didn't I pre-approve this backport from wine-devel?

Can someone please approve this patch (at least one of my mentors) or suggest more improvements?
I do not want to hurry, but I am under the impression that this review has been forgotten (I am starting to forgetting it myself).

Fix style: before I used ifndef, but it seems that if !defined is prefered.

Rename USEKERNNAME to USEKERNCONFNAME and reverts logic: now if USEKERNCONFNAME is defined then directory will be called as kernel configurations, otherwise everything works as usual.

In D24167#532246, @scf wrote:

While I am late to the review, I was able to build i386-wine-devel-5.4,1 in an i386 jail and subsequently, within a amd64 jail. Thank you!

Patch updated!

Ah, I don't remeber why I added that digit. Maybe it would have worked without it but I added it to have the same number of digits than in the example in the porter's handbook.

The port is working but not respecting the standard way of using git commits.
I did a similar mistake with math/wxmaxima some days ago: https://docs.freebsd.org/cgi/getmsg.cgi?fetch=2811607+0+archive/2020/svn-ports-head/20200315.svn-ports-head . The issue is present in misc/xiphos and this patch should fix it. (Tests are running.)

Committed. If this commit works as expected, we will need to forward it to emulators/wine, as emulators/i386-wine is affected by the same bug.

Update .po and .xml file so that now the test build works.

I added my mentors to the review. If they approve it, I will commit it (commit message identical to the title of this review).

Thanks, I will commit it if all tests passes.
I hope @scf can find the time to look at this review since he is one of the users who reported it, if I recall correctly.

Try with WINE_SLAVE_BUILD variable, defined in emulators/i386-wine-devel/Makefile.i386. I would have liked to remove that variable later, but apparently it can still be useful.

Still not the good test: i386-wine-devel does not work with _POSTMKINCLUDED.
I need to study better the issue.

MASTERDIR breaks wine-devel. Try with _POSTMKINCLUDED, which is what bsd.port.mk uses at line 1580.

By the way, I just realized that up to now we have indeed distributed through binary packages the modified rc script, without any declaration on copyrights and license for these modifications. And we regularly do that in the ports tree for any port that patches the files it fetches. I guess then that it would be fine to just continue doing that?

You're right 0mp, I forgot about the binary packages...
I asked for help to the FreeBSD Foundation as you suggested. I am still confused about this topic.

Address received comments

I added portmgr as reviewers: maybe they can help on the licensing issue.

In D24104#530869, @gerald wrote:

The license change. The current license is fine for us, and I am not sure you can simply put a more restrictive license on something in the public domain (but in any case: what's the advantage)? If you want to proceed with that, we'd need to consult some legal experts.

I still have to test the patch properly, but here is some initial feedback:

• the port builds successfully on 13.0-CURRENT r358923 (but I have not tested it yet, due to the fact that I run a custom kernel and similar issues);
• etc/fahclient/config.xml file is with CRLF line terminators;
• it would be nice to have an option to join the FreeBSD team (according to https://www.leidinger.net/blog/category/freebsd/linuxolator/ its number is 11743).

It seems this review has been forgotten for a month. In the meantime I became a (mentored) committer: do you want me to commit it?

Added another pair of committers who committed in the past to Italian documentation.

I added ale as a reviewer since he is a doc committer and worked on the Italian documentation according to svn logs. Maybe he can approve this translation.

In D23598#518221, @dbaio wrote:

As @madpilot doesn't have doc commit bit (the same happens with me in pt_BR), a doc committer needs to review/approve this patch so he can proceed with the commit, and that part will be necessary.

I addressed last comment from madpilot.
I also recreated the diff using the --show-copies-as-adds option: without it the content of Makefile, copied fron en_US.ISO8859-1/articles/bsdl-gpl/Makefile was not visible.

Sorry, I had forgotten to mark the comments as done (I have used phabricator only a few times, I still need to get more familiar with it).

Thanks @madpilot for all the useful comments. I have followed all of them almost exactly, with very few exceptions.
For example, I choosed "riassunto comparativo delle licenze" instead of "riassunto comparativo tra le licenze" considering that you normaly make "un riassunto di qualcosa" or "un paragone o una comparazione tra due cose" and thus the choice was between "riassunto comparativo di" or "paragone riassuntivo tra".
About "economico beneficio trasferibile" -> "beneficio economico trasferibile" I did not accept the suggestion because I understood that my original translation was so bad that it was misleading, so I correct it with "beneficio trasferibile poco costoso" (the original is "cheap protable benefit").
I also corrected the "casalinghi" place by accepting the suggestion ("sistemi proprietari"), but also correcting the meaning of the translation: in the original text the systems were home made and became proprietary while in my precedent translation it was the opposite... Now the right direction has been restored.
About the comment on the Italian research center CNR, I maintained the US examples by definining them as americans and I added the CNR specifying it as an Italian example.

@crees Feel free to commandeer the review if you need it to submit the right patch in the most natural way: I would not take offense :)

I proposed this patch because I feel there is some confusion on the topic. This feeling comes from my own experience when I was a new contributor.

I updated the test plan as you suggested.

When we know about Mat, please keep in mind that I have no commit bit, so someone else should commit the patch for me. Thanks.

Sorry, I was copying the diff from a bug report I created long time ago and I copied it wrong. Now it should be fixed.
If anyone wants to see the bug report, you can find it at
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232816

You're right.
Let's commit it then.

I understand that the file you add does the same thing than the ${REINPLACE_CMD}, but why do you prefer using a file? I do not see the advantage. On the contrary I see disadvantages:

• your file is more byte expensive than the ${REINPLACE_CMD} (sure, in 2020 it does not do much difference for most users, but we never know);
• your file is harder to maintain: it might need to be recreated for any update of the port, while the ${REINPLACE_CMD} will most probably always work.

Sorry, I had forgotten to fix the list numbers after I removed a section, which has been included in the precedent section.

Fix issues with list, headers and <blockquote> tags.

This revision is accepted and ready to land since months. Can a committer commit it please?