LGTM

In D37201#844760, @jrm wrote:

To be clear, I'm just referring to the style changes mostly to conform to Chapter 15. Order of Variables in Port Makefiles and a few other style issues. It's kind of like style(9) for ports. No problem if you prefer to leave things as is, but could you clarify?

In D37201#844432, @jrm wrote:

Also, if you are good with these changes, I can do the same for devel/valgrind.

Yes, please add the devel/valgrind-devel patch.

I've pushed a couple of changes upstream. Could you try building from source

I have a commit bit for the Valgrind source repo and I prefer to make changes directly there rather than maintain patches in the ports tree.

I've put much more detailed regtest failure analysis here

Accepted

Looks OK now. make && make install worked, running the regression suite on the installed Valgrind gave me expected redults.

I had a go at building, replacing valgrind-dev Makefile and distinfo. I got