Review from markj.

Review from markj.

Review from markj.

Review from markj.

Review from markj.

Review from markj.

Update manpage as requested.

Update manpage.

In D56517#1294475, @minsoochoo0122_proton.me wrote:

Since we have [[maybe_unused]] in C23, could you elaborate why we need this to be in <sys/cdefs.h>?

Note that I did not remove all existing definitions of __maybe_unused, only the one in linuxkpi which was causing build issues. There's another one in OpenZFS (two actually, one for Linux and one for FreeBSD) and one in the WPA utils.

Rebase.

Rebase.

Rebase.

Rebase.

Review from emaste and markj.

In D55803#1291246, @emaste wrote:

There doesn't seem to be a general definition of __maybe_unused in FreeBSD

Ah, yes. We seem two have three copies of the #define in our tree, two under sys/, but it's not generally available. We could perhaps define it in cdefs.h, but independent of this change.

In D55803#1288531, @emaste wrote:

Or, something along the lines of:

size_t res __maybe_unused;
res = iov_to_buf(...);
assert (res == VTSCSI_IN_HEADER_LEN(q->vsq_sc);

Rebase.

Rebase.

Rebase.

Rebase.

Rebase, and update commit message.

Rebase.

Rebase.

Improve comment regarding QUERY TASK false negatives.

Rebase.

Rebase.

Garbage-collect a comment obsoleted by this change.

I don't know how or why, but this change makes my test system panic at boot:

Rebase.

Rebase.

Review from markj.

Review from markj.

Remove check for total == 0.

Review from markj.

Review from markj.

Review from markj.

Review from markj.

Review from emaste.

Fix commit message.

Address review by jhb.

In D55800#1276422, @jhb wrote:

The error of having assert() invoke code that is required (such that the code will just flat out break if you build with NDEBUG) still needs fixing. Siva's version fixes that bigger bug. I think It's fine if buf_to_iov() returns size_t, but I think the -1 is still useful from iov_to_buf to avoid ambiguity for a return value of 0. reallocf() is also a good fix.

Don't invoke iov_to_buf() from an assert() expression.

Rebase.

Rebase, and add cleanup code to go with all the new checks for success.

Address review from markj.

Rebase.

Rebase.

Rebase.

Rebase.

Address review from markj.

Address review from markj.

Sync with latest illumos bits after code review.

Sync with latest illumos bits after code review.

Sync with latest illumos bits after code review.

Update commit message.

Update commit message.

Adapt to the recent bhyve header refactoring.

Add only a forward declaration of struct pcpu to md_var.h as suggested by markj.