User Details
- User Since
- Apr 28 2018, 3:44 AM (446 w, 5 d)
Tue, Nov 17
Mon, Nov 16
Sep 14 2026
This review is now obsolete and will be abandoned. Most of the work has been rewritten in Lua and split into four ports with flavors. In total, they create 27 new packages, most of which are bsdinstall-gpu-*.
Aug 11 2026
I’ve updated the diff with the review feedback.
Jul 25 2026
I originally used Gitorious. When I created my Gitorious account, GitHub didn't exist yet, or at least I wasn't aware of it. Both companies were founded in 2008. In 2015, GitLab acquired Gitorious, and since then most of my open source projects have been hosted under the same GitLab account, except for my blog.
Jul 21 2026
Does this diff target src/contrib/ or the upstream GitLab project repository?
Jul 17 2026
You made some interesting points that probably deserve to be explored in more detail and in a different context.
Jul 14 2026
Thanks to everyone for the reviews.
I'll update to fix all the reported issues. To keep things clean, I won't reply to every single comment; I'll only respond to a few to document the rationale for future development.
Jul 10 2026
Hi, I’m on vacation right now. I’ll have a look next week since reading on my phone is a bit uncomfortable.
Jun 29 2026
My goal 4-5 years ago, when I started implementing bsddialog, was to provide a command-line interface that was almost fully compatible with LGPL dialog. The main reason was that most of the existing components already use dialog(1), so in many cases I could simply replace dialog with bsddialog. The work was quite hard and tedious, as anyone can see just by looking at the dialog(1) command-line options in the manual page. Replacing dialog with bsddialog in bsdconfig alone required several months, and that was by far the most difficult task.
Mar 30 2026
Mar 19 2026
I believe this review is quite old and can likely be closed at this point.
Nov 24 2025
Nov 7 2025
Thank you for finding this issue and the fix.
Nov 4 2025
Nov 3 2025
Oct 25 2025
Oct 10 2025
Thank you for the review, I updated to fix.
Oct 9 2025
Oct 7 2025
Oct 4 2025
Aug 20 2025
Aug 15 2025
Jul 14 2025
Thank you for the review. I updated the diff to fix
Thank you for the review. I updated the diff to fix.
Jul 13 2025
Jul 10 2025
Thank you for the review, I updated the diff to fix.
Jul 6 2025
Thank you very much for the review. I’ve updated the diff to incorporate the suggestions and improvements.
Thank you for the review, I'll update to fix.
Jul 3 2025
Fix: pane(s) -> panel(s)
Jul 1 2025
Jun 29 2025
Jun 22 2025
Jun 18 2025
Jun 17 2025
May 31 2025
May 9 2025
OK, I remember the problem described in PR286655, I found it testing the installer on a 32bit (cheap) raspberry and watching a video on youtube (2 years ago). Of course "num extracted bytes" > "max int", I obseverd things like "-676330 files read" (negative num).
I fixed like in this review and now it is in main/CURRENT: I kept %lli because previously libdpv printed a %lli and I changed int to long long int.
Feb 25 2025
Feb 17 2025
Jan 25 2025
Aug 20 2024
Jun 8 2024
Probably the review title and description can be changed, because it wants to introduce GUI for timezone. (Otherwise, if its purpose is adding backtitle to tzsetup (timezone) we can add just 5-6 lines to tzsetup.c :D). Maybe:
May 27 2024
May 25 2024
I fixed in upstream (https://gitlab.com/alfix/bsddialog/-/commit/ce220b82ad546d3518a805750e5ee6add73f1fbf) because the problem also appears in other places in this file. I'll test and import the new version 1.0.3 by 2-3 days.
May 20 2024
Ok, I have the same patch locally.
May 16 2024
Jan 28 2024
LGTM
LGTM. I tested the new selectdists file in the my XFCE Terminal. I wrote some tip, you can consider or ignore.
Nov 23 2023
Nov 17 2023
Nov 3 2023
New solution.