Page MenuHomeFreeBSD
Differential D45344

bsdinstall: Fix wpa_suppicant PSK configuration
AbandonedPublic
Actions

Authored by garga on May 24 2024, 3:02 PM.
Tags
None
Referenced Files
F132756109: D45344.id139056.diff
Sun, Oct 19, 4:39 PM
F132689352: D45344.diff
Sun, Oct 19, 1:57 AM
Unknown Object (File)
Fri, Oct 17, 7:41 AM
Unknown Object (File)
Wed, Oct 8, 6:25 AM
Unknown Object (File)
Fri, Oct 3, 5:24 PM
Unknown Object (File)
Fri, Oct 3, 1:24 AM
Unknown Object (File)
Thu, Oct 2, 9:26 AM
Unknown Object (File)
Tue, Sep 30, 7:05 AM
View All 69 Files
Subscribers
des
imp
jrtc27

Details

Reviewers
asiciliano
Summary

Delete first line, which contains SSID, and capture second line
containing password

Approved by:
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 57901
Build 54789: arc lint + arc unit

Event Timeline

garga created this revision.May 24 2024, 3:02 PM
Herald added subscribers: jrtc27, imp. · View Herald TranscriptMay 24 2024, 3:02 PM
garga requested review of this revision.May 24 2024, 3:02 PM
Harbormaster completed remote builds in B57900: Diff 139045.May 24 2024, 3:02 PM
jrtc27 added a comment.May 24 2024, 4:55 PM

I don’t understand how this diff relates to the commit message. Whether PASS contains a space or not, using its expansion and deleting its first line are two quite different things.

garga updated this revision to Diff 139056.May 24 2024, 5:30 PM

Improved commit message

Harbormaster completed remote builds in B57901: Diff 139056.May 24 2024, 5:30 PM
jrtc27 added a comment.EditedMay 24 2024, 5:44 PM
In D45344#1034535, @garga wrote:

Improved commit message

arc diff doesn't update the message in Phabricator

garga edited the summary of this revision. (Show Details)May 24 2024, 6:11 PM
asiciliano added a comment.May 25 2024, 12:51 AM

I fixed in upstream (https://gitlab.com/alfix/bsddialog/-/commit/ce220b82ad546d3518a805750e5ee6add73f1fbf) because the problem also appears in other places in this file. I'll test and import the new version 1.0.3 by 2-3 days.

des added a subscriber: des.May 25 2024, 7:35 AM

I would rather filter the output from bsddialog so PASS never contained the SSID in the first place.

garga abandoned this revision.May 27 2024, 12:31 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
scripts/
2 lines

Diff 139056

View Options

usr.sbin/bsdinstall/scripts/wlanconfig

Loading...