Page MenuHomeFreeBSD

bsdinstall: Fix wpa_suppicant PSK configuration
AbandonedPublic

Authored by garga on May 24 2024, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 6:25 AM
Unknown Object (File)
Fri, Oct 3, 5:24 PM
Unknown Object (File)
Fri, Oct 3, 1:24 AM
Unknown Object (File)
Thu, Oct 2, 9:26 AM
Unknown Object (File)
Tue, Sep 30, 7:05 AM
Unknown Object (File)
Mon, Sep 29, 3:19 PM
Unknown Object (File)
Thu, Sep 25, 8:35 PM
Unknown Object (File)
Thu, Sep 25, 7:59 PM
Subscribers

Details

Reviewers
asiciliano
Summary

Delete first line, which contains SSID, and capture second line
containing password

Approved by:
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 57901
Build 54789: arc lint + arc unit

Event Timeline

garga requested review of this revision.May 24 2024, 3:02 PM

I don’t understand how this diff relates to the commit message. Whether PASS contains a space or not, using its expansion and deleting its first line are two quite different things.

Improved commit message

arc diff doesn't update the message in Phabricator

I fixed in upstream (https://gitlab.com/alfix/bsddialog/-/commit/ce220b82ad546d3518a805750e5ee6add73f1fbf) because the problem also appears in other places in this file. I'll test and import the new version 1.0.3 by 2-3 days.

I would rather filter the output from bsddialog so PASS never contained the SSID in the first place.