Page MenuHomeFreeBSD

bsdinstall(8): add desktop script
Needs ReviewPublic

Authored by asiciliano on Mon, Mar 30, 5:22 PM.
Tags
None
Referenced Files
F150724283: D56167.id.diff
Fri, Apr 3, 3:28 PM
F150643242: D56167.diff
Fri, Apr 3, 1:21 AM
F150643133: D56167.diff
Fri, Apr 3, 1:20 AM
F150625869: D56167.id.diff
Thu, Apr 2, 10:13 PM
Unknown Object (File)
Thu, Apr 2, 7:40 AM
Unknown Object (File)
Thu, Apr 2, 7:29 AM
Unknown Object (File)
Thu, Apr 2, 3:45 AM
Unknown Object (File)
Wed, Apr 1, 3:34 PM
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Add a desktop script to install and set up a graphical environment. The current goal is to provide a simple option in bsdinstall to install the GPU driver, SDDM, and KDE. I have received some requests for additional functionality, such as allowing users to choose the display manager instead of SDDM due to potential future issues; it is not yet clear whether the KDE project will continue developing its main display manager without systemd.

Obviously, if there are requests, more options and graphical environments can be added in the future.

Sponsored by: The FreeBSD Foundation

Test Plan

The main testing challenge has been the large number of existing GPUs. I only have access to a recent laptop with an AMD GPU and an older 2011 laptop with NVIDIA Optimus (NVIDIA GPU + Intel GPU).

The call for testing has been very helpful, https://github.com/alfonsosiciliano/kde-installer-dialogs/blob/main/cft.md

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I can't help but feel a lot of this belongs in packages rather than being big splats of hard-coded config that bsdinstall writes out that risks getting stale when ports gets updated

usr.sbin/bsdinstall/scripts/desktop
21

I did $3 >= 1000 && $3 < 32000 in CheriBSD, since there is an upper limit too above which you're back to system users.

56

Don't we force this non-empty elsewhere?

91

Arm + BIOS?..

usr.sbin/bsdinstall/scripts/desktop
93

I don't think this is true? You can get drm-kmod for arm64? (And drm-subtree if you vendor it in your tree)

david_ixit.cz added inline comments.
usr.sbin/bsdinstall/scripts/desktop
91

What I recall I saw some aarch64 board with BIOS, it's not extra common, but also not rare.