bsdinstall(8): add desktop script
Needs ReviewPublic
Actions

Authored by asiciliano on Mon, Mar 30, 5:22 PM.

Details

Reviewers: None

Summary

Add a desktop script to install and set up a graphical environment. The current goal is to provide a simple option in bsdinstall to install the GPU driver, SDDM, and KDE. I have received some requests for additional functionality, such as allowing users to choose the display manager instead of SDDM due to potential future issues; it is not yet clear whether the KDE project will continue developing its main display manager without systemd.

Obviously, if there are requests, more options and graphical environments can be added in the future.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

asiciliano created this revision.Mon, Mar 30, 5:22 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptMon, Mar 30, 5:22 PM

asiciliano requested review of this revision.Mon, Mar 30, 5:22 PM

I can't help but feel a lot of this belongs in packages rather than being big splats of hard-coded config that bsdinstall writes out that risks getting stale when ports gets updated

usr.sbin/bsdinstall/scripts/desktop
21	I did `$3 >= 1000 && $3 < 32000` in CheriBSD, since there is an upper limit too above which you're back to system users.
56	Don't we force this non-empty elsewhere?
91	Arm + BIOS?..

jrtc27 added inline comments.Mon, Mar 30, 6:27 PM

usr.sbin/bsdinstall/scripts/desktop
93	I don't think this is true? You can get drm-kmod for arm64? (And drm-subtree if you vendor it in your tree)

david_ixit.cz added a subscriber: david_ixit.cz.Wed, Apr 1, 9:09 PM

david_ixit.cz added inline comments.

usr.sbin/bsdinstall/scripts/desktop
91	What I recall I saw some aarch64 board with BIOS, it's not extra common, but also not rare.

arrowd added a subscriber: arrowd.Mon, Apr 13, 4:35 PM

arrowd added inline comments.

usr.sbin/bsdinstall/scripts/desktop
106	IIRC, Optimus is not a correct term anymore. The thing is called "NVIDIA PRIME" now.
307	That's a rather large config file. How much is it different from the `.sample` one provided by the package?
354	`pkg` should create `config.ini` out of `config.ini.sample` automatically. Does it not?
363	These two knobs are not needed anymore.
424	Pulseaudio has its own way of autostarting. Is this really required?

ziaee added a subscriber: ziaee.Mon, Apr 13, 6:17 PM

ziaee added inline comments.

usr.sbin/bsdinstall/scripts/desktop
2–5	The hyphen was for a long abandoned parser, and we removed it from our style guides. Currently, for spdx only licenses the style guides suggest putting the copyright line above the spdx tag.

taosecurity_gmail.com added a subscriber: taosecurity_gmail.com.Thu, Apr 23, 12:47 AM

taosecurity_gmail.com added inline comments.

usr.sbin/bsdinstall/scripts/desktop
106	This is not correct. NVIDIA Optimus and NVIDIA PRIME are different. Optimus remains the official hardware brand name for NVIDIA's laptop graphics-switching technology. Modern versions are often called Advanced Optimus. It enables switching without reboots by using a hardware MUX switch. PRIME (and the related nvidia-prime tool) is the specific implementation and set of scripts used to make Optimus technology work on Linux systems. I wanted to make sure the original code remained and was not erroneously changed. Thank you!