Page MenuHomeFreeBSD

dteske (Devin Teske)
src committer

Projects

User Details

User Since
Sep 2 2014, 7:30 PM (502 w, 4 d)

Creator/Maintainer of FreeBSD bootloader-menu/bsdconfig/dpv/dwatch/figpar/sysrc
Maintainer of FreeBSD base/bsdinstall/DTrace/forth/jail/netgraph/ports/vnet
Maintainer of FreeBSD ports: (net-p2p) shx (sysutils) bsdconfig cmocka DTraceToolkit dwatch-gource dwatch-pwsnoop host-setup mping ssd_report sysrc tzdialog zfs-stats-lite
Drive-by's: (devel) p4d p4web (emulators) xen xen-kernel (net) pptpclient (ports-mgmt) pkg (sysutils) getssl syslinux vzvol

Recent Activity

Feb 9 2024

dteske updated dteske.
Feb 9 2024, 5:51 AM

Jan 20 2024

dteske updated the diff for D43516: New version of jng (2.0).

Fix variable name in awk -- s/time/tm/

Jan 20 2024, 12:33 AM

Jan 19 2024

dteske added a reviewer for D43516: New version of jng (2.0): julian.
Jan 19 2024, 8:04 PM
dteske updated the test plan for D43516: New version of jng (2.0).
Jan 19 2024, 7:35 PM
dteske retitled D43516: New version of jng (2.0) from New version of jng to New version of jng (2.0).
Jan 19 2024, 7:34 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:34 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:33 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:31 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:30 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:28 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:26 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:24 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:23 PM
dteske updated the diff for D43516: New version of jng (2.0).

Advertise -j option in stats usage statement

Jan 19 2024, 7:22 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:18 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:16 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:16 PM
dteske updated the summary of D43516: New version of jng (2.0).
Jan 19 2024, 7:15 PM
dteske updated subscribers of D43516: New version of jng (2.0).
Jan 19 2024, 7:13 PM
dteske updated the diff for D43516: New version of jng (2.0).

Bump copyright

Jan 19 2024, 7:11 PM
dteske updated the diff for D43516: New version of jng (2.0).

Update

Jan 19 2024, 7:11 PM
dteske requested review of D43516: New version of jng (2.0).
Jan 19 2024, 7:05 PM

Oct 22 2023

dteske committed rG608da65de955: bsdconfig: Add `network' keyword (authored by dteske).
bsdconfig: Add `network' keyword
Oct 22 2023, 6:50 PM
dteske closed D42242: bsdconfig: Add `network' keyword.
Oct 22 2023, 6:50 PM

Oct 17 2023

dteske updated the diff for D42242: bsdconfig: Add `network' keyword.

Full context as-requested by emaste

Oct 17 2023, 12:05 AM
dteske added a comment to D42242: bsdconfig: Add `network' keyword.

FYI for future Phabricator uploads please include full context, e.g. git show -U99999 <hash>. Details are at https://wiki.freebsd.org/action/show/Phabricator

Oct 17 2023, 12:01 AM

Oct 16 2023

dteske requested review of D42242: bsdconfig: Add `network' keyword.
Oct 16 2023, 11:47 PM

Sep 1 2022

dteske accepted D36206: bsdinstall(8): replace ntpdate by ntpd_sync_on_start on the 'services' dialog.

LGTM

Sep 1 2022, 4:44 PM
dteske closed D36051: Update dwatch-json to 1.2, maintainership.
Sep 1 2022, 1:04 AM · DTrace
dteske committed R11:542fb2297a9e: sysutils/dwatch-json: update to 1.2, restore maintainership (authored by dteske).
sysutils/dwatch-json: update to 1.2, restore maintainership
Sep 1 2022, 1:04 AM

Aug 27 2022

dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Bump port to 1.2 so we catch latest development (the inclusion of a dashboard for the Block I/O stats)

Aug 27 2022, 2:15 AM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Fix distinfo

Aug 27 2022, 1:33 AM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Update diff before applying to head

Aug 27 2022, 12:20 AM · DTrace
dteske added a comment to D36051: Update dwatch-json to 1.2, maintainership.

I was working on committing this and went to go apply the patch to the tree and the patch no longer applies cleanly.

Aug 27 2022, 12:11 AM · DTrace

Aug 23 2022

dteske added a reviewer for D36051: Update dwatch-json to 1.2, maintainership: ler.
Aug 23 2022, 10:14 PM · DTrace
dteske removed a reviewer for D36051: Update dwatch-json to 1.2, maintainership: shurd.
Aug 23 2022, 9:00 PM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Add missing dashboard examples from 1.1

Aug 23 2022, 4:18 PM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Fixup package COMMENT to match what I have set for 1.1

Aug 23 2022, 4:06 PM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Pepper [@]sample

Aug 23 2022, 3:33 PM · DTrace
dteske updated the summary of D36051: Update dwatch-json to 1.2, maintainership.
Aug 23 2022, 3:26 PM · DTrace
dteske added a comment to D36051: Update dwatch-json to 1.2, maintainership.

You’re probably already aware, but ports has a commit hook so that commit messages should start the first line with “category/portname: description”.

So commit message should have first line:
sysutils/dwatch-json: update to 1.1, restore maintainership

Aug 23 2022, 3:26 PM · DTrace
dteske updated the summary of D36051: Update dwatch-json to 1.2, maintainership.
Aug 23 2022, 4:02 AM · DTrace
dteske updated the summary of D36051: Update dwatch-json to 1.2, maintainership.
Aug 23 2022, 4:01 AM · DTrace

Aug 22 2022

dteske reclaimed D36051: Update dwatch-json to 1.2, maintainership.

Reclaim

Aug 22 2022, 11:51 PM · DTrace
dteske abandoned D36051: Update dwatch-json to 1.2, maintainership.

Tested and ready for re-review

Aug 22 2022, 11:50 PM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Add missing io-sample conf

Aug 22 2022, 11:45 PM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

makesum for 1.1

Aug 22 2022, 11:38 PM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Add symbolic link entries from 1.1

Aug 22 2022, 11:23 PM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Add missing config to plist for 1.1

Aug 22 2022, 11:17 PM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Update pkg-descr for 1.1

Aug 22 2022, 11:16 PM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Update the plist for 1.1

Aug 22 2022, 11:13 PM · DTrace
dteske updated the diff for D36051: Update dwatch-json to 1.2, maintainership.

Abandon the update to 0.5 and update to 1.1

Aug 22 2022, 11:10 PM · DTrace
dteske added a reviewer for D36051: Update dwatch-json to 1.2, maintainership: 0mp.
Aug 22 2022, 11:01 PM · DTrace
dteske retitled D36051: Update dwatch-json to 1.2, maintainership from Update dwatch-json to 0.5, maintainership to Update dwatch-json to 1.1, maintainership.
Aug 22 2022, 11:00 PM · DTrace

Aug 16 2022

dteske accepted D35357: bsdinstall: add variables to allow skipping over some phases of the install.

Great work. I gave it a thorough check, inside and out. Green-lit to go.

Aug 16 2022, 6:50 PM

Aug 6 2022

dteske updated subscribers of D36051: Update dwatch-json to 1.2, maintainership.
Aug 6 2022, 12:42 AM · DTrace
dteske updated subscribers of D36051: Update dwatch-json to 1.2, maintainership.
Aug 6 2022, 12:41 AM · DTrace
dteske added a comment to D36051: Update dwatch-json to 1.2, maintainership.

From my 2018 BSDCAN presentation slides, here are the modules in base ... we're not going to add "dwatch-" prefix to all those simply because a PORT convention says that a PORT should install files named the same as the PORT when the PORT should follow BASE convention already set forth 6 years ago

Aug 6 2022, 12:30 AM · DTrace
dteske added a comment to D36051: Update dwatch-json to 1.2, maintainership.

I discussed this submission with dteske on IRC and possibly have a few suggestions:

PORTNAME should correspond to the naming convention of installed files and usecase whenever possible, so dwatch-json --> dwatch-json-net and preferably libexec/dwatch/json-net* --> libexec/dwatch/dwatch-json-net*

Grafnet should be broken out, put in a separate port and be set as a dependency (if required) as it doesn't seem to be a hard requirement and/or limited to dwatch-json-net looking at pkg-descr

Aug 6 2022, 12:21 AM · DTrace

Aug 5 2022

dteske requested review of D36051: Update dwatch-json to 1.2, maintainership.
Aug 5 2022, 5:45 PM · DTrace

Jul 1 2022

dteske requested changes to D33381: rc.subr: Do not apply limits unless requested.

I have two suggestions, but you're only meant to pick one. I don't care which. Minor optimization or major optimization.

Jul 1 2022, 8:16 PM · rc

Jun 29 2022

dteske requested changes to D35588: bsdinstall: allow setting the root password via env variables.

Sorry for being late to the party

Jun 29 2022, 4:16 AM

Jun 2 2022

dteske accepted D35355: bsdinstall: allow overriding DISTRIBUTIONS in the normal auto mode.

There we go. This looks to be all good.

Jun 2 2022, 5:20 PM

Jun 1 2022

dteske added a comment to D35355: bsdinstall: allow overriding DISTRIBUTIONS in the normal auto mode.

The raw diff [1] looks funny. The "before" (line removed) doesn't match what is in head [2].

Jun 1 2022, 10:23 PM

May 31 2022

dteske added a comment to D35357: bsdinstall: add variables to allow skipping over some phases of the install.
In D35357#801773, @brd wrote:

Can we discuss perhaps using K&R style naming?

That is to say, BSDINSTALL_SKIP_* instead of BSDINSTALL_*_SKIP -- it would go a long way to being able to more-easily grep-out the skippable options and also open the prefix to being used in other parts of bsdinstall that are unrelated (read: other scripts/functions)

I was thinking in a follow up commit about adding more variables, BSDINSTALL_TIME_NAME and BSDINSTALL_TIME_DESC to populate the menu in finalconfig(). Doing it that way seemed a bit nicer to me, but I don't feel strongly about it. So instead we could use BSDINSTALL_SKIP_*, BSDINSTALL_NAME_* and BSDINSTALL_DESC_*.

May 31 2022, 4:59 PM

May 30 2022

dteske requested changes to D35357: bsdinstall: add variables to allow skipping over some phases of the install.

Can we discuss perhaps using K&R style naming?

May 30 2022, 6:10 PM
dteske added inline comments to D35355: bsdinstall: allow overriding DISTRIBUTIONS in the normal auto mode.
May 30 2022, 6:08 PM
dteske added a comment to D35355: bsdinstall: allow overriding DISTRIBUTIONS in the normal auto mode.

I will also note that the removal of the "export" may cause issues. There would be other acceptable solutions, such as:

May 30 2022, 5:55 PM
dteske requested changes to D35355: bsdinstall: allow overriding DISTRIBUTIONS in the normal auto mode.

Changes required.

May 30 2022, 5:54 PM

May 28 2022

dteske added a comment to D35331: bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS.

Oh, sorry about that. I'll commit the fix. I didn't even realize that it was possible to leak memory in sh.

May 28 2022, 10:33 PM

May 27 2022

dteske updated the diff for D35331: bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS.

Fix a memory leak introduced by previous commit.

May 27 2022, 9:33 PM
dteske commandeered D35331: bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS.
May 27 2022, 9:24 PM
dteske requested changes to D35331: bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS.
May 27 2022, 9:23 PM
dteske reopened D35331: bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS.

This is not what I wanted. The second diff (that I prematurely accepted) that you committed omits the f_isset call

May 27 2022, 9:12 PM
dteske added a comment to D35331: bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS.

Do you need me to commit this or do you have a venue/access?

May 27 2022, 12:06 AM

May 26 2022

dteske accepted D35331: bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS.

Looks good

May 26 2022, 11:41 PM
dteske requested changes to D35331: bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS.

The change to use f_isset in 2 places is a good one, thank you. However, I have issue with the removal of the call to "local" above the second hunk.

May 26 2022, 10:26 PM

Apr 18 2022

dteske added a comment to D34755: bsdconfig(8): Add bsddialog(1) support.

This looks pretty well thought out. Give me some time to review it and get back to you. Thank you for your efforts.

Apr 18 2022, 8:06 PM

Oct 9 2021

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

Looks good to me.

I'm playing with this utility on my stable/13 and I like the idea very much. It feels unixy to me in that the tool is abstract enough for me to apply it to various problems which may be difficult to define beforehand. But I can already see myself using this instead of generating permutations with recursive CTEs in SQL like I sometimes do.

Also, although I'm not sure anyone will find this meaningful, cmb reminds me of a problem I was solving recently at job, feeding a Cassandra table random data:

The table and its keyspace were defined as follows:
CREATE KEYSPACE test WITH REPLICATION = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 };
CREATE TABLE test.base(part text, ord text, fill text, PRIMARY KEY((part), ord));

We feed the table like this:
# base32 -w 2000 < /dev/urandom | cut -b1-3,4-8,9- --output-delimiter=, | cqlsh -u $CASS_USER -e 'COPY test.base FROM STDIN'

Cutting base32 output into columns of arbitrary length gives us control over cardinality of each column; specifically we want to know the upper bound on the number of partitions and the number of rows in each partition. Given a set of k (32 in base32) characters, the number of n-tuples (n characters in a column) is k^n. For example, taking the first 3 letters of each line to use in the partitioning column gives us the upper bound of 32^3 partitions, which is 32768.

Forgive the verbosity and being Ubuntu-specific (base32, cut --output-delimiter, /dev/urandom), but I hope you get the idea: I tend to use unix tools when interacting with other tools or services, databases especially.

By the way, the util and the library seem small enough:

-r-xr-xr-x  1 root  wheel    46K Aug  5 14:17 /usr/bin/indent
-r--r--r--  1 root  wheel    21K Aug 15 17:49 /usr/lib/libcmb.so.0
-r-xr-xr-x  1 root  wheel    31K Aug 15 17:50 /usr/bin/cmb
Oct 9 2021, 12:15 AM
dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.
In D16132#626980, @gbe wrote:

LGTM for the man page related things.

Oct 9 2021, 12:13 AM
dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

Hi markj,

Yes, it was suggested that I make a port first.

However, everybody seems to be ignoring what I am saying regarding the utility of this tool being equitable to seq, jot, and friends.

Just yesterday, I did the following:

cmb -d / {a..z} | xargs stat 2>&1 | dpv -l -

The purpose was to generate millions of stat errors so that I could work on some filesystem patches to improve the performance of stat in nfsd.

Could I have used jot? Maybe, but it would have been more difficult.
Could I have used seq? Maybe, but same problems as jot. I needed discretely unique test matter.

I have been ignoring the suggestion to put it into ports because not one single person has even addressed the use-cases for base.

How would one make an argument for jot or seq being in base? If you pretend that they are not in base, what arguments would you use to introduce them?

cmb is kind of like that -- it has a million uses. Asking why we should have it in base is kind of like asking why we should have bc in base.

cmb is a math tool. A very powerful tool that fills a myriad requirements, not to mention the following use-case which I will once-again reiterate that has once again been ignored ...

I don't care about the build option survey. It was an example.

I care about using this for combinatoric combination of ports given various options.

Let's talk about dialog4ports -- a tool that lives in ports that is required by ports. So many times this has caused me headaches and I really don't want to go down that road. It is very frustrating when you get into a situation where ports needs X from ports but you can't compile it because your base and ports frameworks have diverged so you then have to devolve into first updating your base shared Mk files relied-on by ports. It's real shit-show.

Putting cmb in base will allow it to:
a. solve math problems
b. allow me to work on base enhancements with only base (think Filesystem debugging, filesystem optimizations, memory testing, scheduler profiling, etc.)
c. be usable by ports without being stuck in the quagmire-catch-22 described above

Regarding the prior discussion, I just see that the original thread on -announce appears to end with you saying that you would make a port. That didn't happen, and since there was some objection to putting cmb and libcmb straight into the base system, we should make sure that those objections won't be raised again after a commit. The right way to do that is to follow up on the lists, like -hackers and -arch, since only a small handful of developers are subscribed to this review.

I understand that cmb is intended to be a general-purpose utility, but that alone is not sufficient for putting it in the base system. jot(1) and seq(1) make for an interesting comparison since seq's functionality is a subset of jot's; seq was added to the base system relatively recently, specifically to make us more compatible with other unix environments. jot predates FreeBSD and comes from a time where a batteries-included approach to shipping an OS was more important than it is today.

I personally think that cmb would be an interesting addition to the base system, but there should be some concrete justification for it to be there. The build option survey is not really a compelling example. A ports target that builds a port with all possible combinations of options seems useful, but is there currently some work in progress to implement that? I understand that having the ports framework depend on a port is painful, but unless the absence of cmb from the base system is currently blocking a useful project, I don't see why this is a strong argument for not making a cmb port. You've written a number of large sh-based components of the base system - could any of them make use of cmb? My point is just that I believe that you could successfully argue for cmb's inclusion in the base system, but the idea first needs to be socialized more fully. A port is a reasonable alternative in the meantime and will make it easy for others to try using cmb.

Oct 9 2021, 12:13 AM

Oct 8 2021

dteske committed rG1c64959bff17: bsdconfig: Comments (authored by dteske).
bsdconfig: Comments
Oct 8 2021, 11:32 PM

Sep 22 2021

dteske accepted D25711: freebsd-update(8): Add -j flag to support jails.

Just a simple bogon in the src bits, after which I will approve

Sep 22 2021, 8:28 PM

May 10 2021

dteske requested changes to D30015: Add zfskeys script to /etc/rc.d for auto-loading zfs keys.
May 10 2021, 7:47 PM

Dec 11 2020

dteske requested changes to D25711: freebsd-update(8): Add -j flag to support jails.

Just a simple bogon in the src bits, after which I will approve

Dec 11 2020, 4:43 PM

Aug 3 2020

dteske added a comment to D25343: Ensure logging retained when BSDINSTALL_LOG is not changed by preamble.

Thank for submitting. Give me a chance to review, but I do believe this looks like a good candidate for commit. Thank you

Aug 3 2020, 9:18 PM
dteske added a comment to D6757: Fix file descriptor and memory leaks in libdpv.

Sorry for the delay, had a disk failure take out my operations for a full 4 weeks, but finally got all the data recovered and back up and running

Aug 3 2020, 9:13 PM

Jul 3 2020

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

Hi markj,

Jul 3 2020, 2:03 AM

Jun 20 2020

dteske added a comment to D6757: Fix file descriptor and memory leaks in libdpv.

I've only a couple changes I'll make before committing with reference to OP. Instead of "doclose" I will use "opened" which makes the code easier to read.

Jun 20 2020, 8:44 PM
dteske commandeered D6757: Fix file descriptor and memory leaks in libdpv.

Take

Jun 20 2020, 8:42 PM

May 26 2020

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

I'm going to set an ETIMEOUT of 30 days. If there is no objection, I will import to base HEAD.

May 26 2020, 5:04 PM

May 20 2020

dteske committed rS361309: MFC r361300: Fix indentation in bsdinstall-created wpa_supplicant.conf.
MFC r361300: Fix indentation in bsdinstall-created wpa_supplicant.conf
May 20 2020, 11:27 PM
dteske committed rS361305: MFC r361300: Fix indentation in bsdinstall-created wpa_supplicant.conf.
MFC r361300: Fix indentation in bsdinstall-created wpa_supplicant.conf
May 20 2020, 10:21 PM
dteske committed rS361300: Fix indentation in bsdinstall-created wpa_supplicant.conf.
Fix indentation in bsdinstall-created wpa_supplicant.conf
May 20 2020, 9:39 PM
dteske closed D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.
May 20 2020, 9:39 PM
dteske updated the diff for D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.

Indentation fixes. Fix whitespace for consistency. Fix >80c lines.

May 20 2020, 9:00 PM
dteske commandeered D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.

Pre-update commandeer

May 20 2020, 8:59 PM

Apr 30 2020

dteske accepted D24640: bsdinstall: do a `certctl rehash` upon installation of configuration.

LGTM

Apr 30 2020, 7:48 PM

Apr 12 2020

dteske added a comment to D24378: Add mention of wireless option in bsdconfig.

@crees oh, didn't know @debdrup wasn't a committer. You know how you get so used to seeing someone's name in your TL that you just assume they are in-the-fold ;D lol

Apr 12 2020, 8:41 PM
dteske accepted D24378: Add mention of wireless option in bsdconfig.
Apr 12 2020, 8:40 PM