Page MenuHomeFreeBSD

dteske (Devin Teske)
src and ports committer

Projects

User Details

User Since
Sep 2 2014, 7:30 PM (254 w, 1 d)

Creator/Maintainer of FreeBSD bootloader-menu/bsdconfig/dpv/dwatch/figpar/sysrc
Maintainer of FreeBSD base/bsdinstall/DTrace/forth/jail/netgraph/ports/vnet
Maintainer of FreeBSD ports: (net-p2p) shx (sysutils) bsdconfig cmocka DTraceToolkit dwatch-gource dwatch-pwsnoop host-setup mping ssd_report sysrc tzdialog zfs-stats-lite
Drive-by's: (devel) p4d p4web (emulators) xen xen-kernel (net) pptpclient (ports-mgmt) pkg (sysutils) getssl syslinux vzvol

Recent Activity

Sat, Jun 22

dteske committed rS349289: `libjail/jail.c' includes both <sys/param.h> and <sys/types.h>.
`libjail/jail.c' includes both <sys/param.h> and <sys/types.h>
Sat, Jun 22, 3:39 PM
dteske closed D20637: Unnecessary Include Header Removal.
Sat, Jun 22, 3:39 PM
dteske accepted D20637: Unnecessary Include Header Removal.
Sat, Jun 22, 3:33 PM

Jun 15 2019

dteske added a comment to D20637: Unnecessary Include Header Removal.

@rgrimes @cem If one of you approve, I'll go ahead and usher it in

Jun 15 2019, 12:36 AM
dteske added a comment to D20637: Unnecessary Include Header Removal.

I approve of this change. But since I have not committed in a while, want to get sign-off from at least one other person.

Jun 15 2019, 12:35 AM
dteske added reviewers for D20637: Unnecessary Include Header Removal: rgrimes, cem.
Jun 15 2019, 12:34 AM

Feb 7 2019

dteske added a comment to D19036: Update mvneta/e6000sw for new style Distributed Switch Architecture Device Tree Bindings.

Try to get ahold of mw@ and loos@ to review

Feb 7 2019, 7:43 AM · network, ARM, arm64
dteske added inline comments to D19036: Update mvneta/e6000sw for new style Distributed Switch Architecture Device Tree Bindings.
Feb 7 2019, 7:30 AM · network, ARM, arm64

Jan 6 2019

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

Thanks! I have a huge update coming this month that will bring in lots of changes. Hoping you could revisit just afterward.

Jan 6 2019, 5:02 PM

Dec 20 2018

dteske accepted D15879: sysutils/DTraceToolkit: remove missing providers in FreeBSD 12.0-CURRRENT.
Dec 20 2018, 3:49 PM

Dec 11 2018

dteske added inline comments to D18481: rc.subr: Implement list_vars without using 'read'.
Dec 11 2018, 1:03 AM

Dec 10 2018

dteske added inline comments to D18481: rc.subr: Implement list_vars without using 'read'.
Dec 10 2018, 10:53 PM
dteske added inline comments to D18481: rc.subr: Implement list_vars without using 'read'.
Dec 10 2018, 6:14 AM

Dec 8 2018

dteske added inline comments to D18481: rc.subr: Implement list_vars without using 'read'.
Dec 8 2018, 4:04 AM
dteske added inline comments to D18481: rc.subr: Implement list_vars without using 'read'.
Dec 8 2018, 3:35 AM

Nov 11 2018

dteske committed rS340348: MFC r339971: Add new rc keywords: enable, disable, delete.
MFC r339971: Add new rc keywords: enable, disable, delete
Nov 11 2018, 6:05 AM

Nov 5 2018

dteske updated the diff for D16132: New cmb(3) library and cmb(1) utility.

Add support for `-i random' for seeking to a random position.
Updated manual with new examples.

Nov 5 2018, 2:47 AM

Nov 4 2018

dteske updated the diff for D16132: New cmb(3) library and cmb(1) utility.

Add support for negative `-i num' values
(for seeking to the back-end of a series)

Nov 4 2018, 11:22 PM

Nov 3 2018

dteske updated the diff for D16132: New cmb(3) library and cmb(1) utility.

+ cmb(1,3): Fix broken handling of -i num when given -k -1
+ cmb(3): Remove a stray newline
+ cmb(3): Add show_empty option for including the empty-set
+ cmb(1): Add -e option for showing the empty-set

Nov 3 2018, 7:24 PM
dteske planned changes to D16132: New cmb(3) library and cmb(1) utility.

Bugs already fixed for next update:
+ -i NUM was broken with -k -1

Nov 3 2018, 6:58 PM
dteske updated the diff for D16132: New cmb(3) library and cmb(1) utility.

Update to address feedback from adridg

Nov 3 2018, 12:30 AM

Nov 2 2018

dteske committed rS340091: Update awk(1) manual to state an exception to egrep(1)-like RE syntax.
Update awk(1) manual to state an exception to egrep(1)-like RE syntax
Nov 2 2018, 11:03 PM
dteske closed D17739: Update awk(1) manual to accurately describe regex syntax..
Nov 2 2018, 11:03 PM

Nov 1 2018

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

Comments in general not tied to a specific line of code:

  • The -c and -i flags ask for a deterministic order of the combinations. If I use -c 4 -i 1 I expect 4 combinations (whatever they may be). If I use -c 3 -i 2 I expect the last three of those four combinations. So the ordering must be consistent. It is, in your implementation, but the documentation doesn't guarantee that.
Nov 1 2018, 10:25 PM
dteske added inline comments to D16132: New cmb(3) library and cmb(1) utility.
Nov 1 2018, 10:14 PM
dteske updated the diff for D16132: New cmb(3) library and cmb(1) utility.

cmb(1): Add missing -n option to usage and give a more informative usage
cmb(3): Fix style issue of single-line for-loops
cmb(3): API changes to cmb_print(1) and struct cmb_config

Nov 1 2018, 3:05 AM

Oct 31 2018

dteske committed rS339977: MFC r339843: Fix jail examples in jib, jng, README.
MFC r339843: Fix jail examples in jib, jng, README
Oct 31 2018, 11:08 PM
dteske committed rS339971: Add new rc keywords: enable, disable, delete.
Add new rc keywords: enable, disable, delete
Oct 31 2018, 8:37 PM
dteske closed D17113: Add new rc keywords: enable, disable, delete.
Oct 31 2018, 8:37 PM
dteske updated the diff for D16132: New cmb(3) library and cmb(1) utility.

Address feedback and minor improvements:
+ Move static variables out of header (adridg)
+ Remove "All rights reserved" from copyrights (0mp)
+ Add EXAMPLES section to cmb(1) manual (0mp)
+ Add missing $FreeBSD$ (0mp)
+ Update cmb(1,3) HISTORY section [s/12.0/13.0/]
+ Improved error checking for 64-bit integer overflow
+ Fix copy-paste error in cmb(3) manual (/#endif/d)
+ Use errno(2) instead of errx(3) in cmb(3) library
+ Sync with upstream version 0.7 of [lib]cmb
+ Fix style(9) issue of single-line if-statements
+ Add missing $FrauBSD$ keyword to cmb(1) manual
+ Remove redundant RCS keywords from cmb(1)

Oct 31 2018, 12:27 AM

Oct 30 2018

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.
In D16132#379579, @0mp wrote:

Also, is there a pattern for the use of Qq, Dq and Ql (instead of Dq Li)?

Oct 30 2018, 11:44 PM
dteske added inline comments to D16132: New cmb(3) library and cmb(1) utility.
Oct 30 2018, 10:32 PM
dteske added a comment to D17739: Update awk(1) manual to accurately describe regex syntax..

If no additional comments, I'll move ahead without adding the date (which I could not figure out how to add)

Oct 30 2018, 6:03 PM
dteske added inline comments to D16132: New cmb(3) library and cmb(1) utility.
Oct 30 2018, 6:00 PM
dteske added inline comments to D16132: New cmb(3) library and cmb(1) utility.
Oct 30 2018, 5:35 PM
dteske updated the diff for D16132: New cmb(3) library and cmb(1) utility.

Remove WARNS=6 (this is the default)

Oct 30 2018, 3:05 AM
dteske updated the diff for D16132: New cmb(3) library and cmb(1) utility.

Make integer overflow with -t print -1 under MK_OPENSSL=no

Oct 30 2018, 3:01 AM
dteske updated the diff for D16132: New cmb(3) library and cmb(1) utility.

Update patch for 13.0, bug fix, and libname edits

Oct 30 2018, 2:50 AM

Oct 29 2018

dteske added a comment to D17739: Update awk(1) manual to accurately describe regex syntax..
In D17739#379438, @imp wrote:
In D17739#379046, @jmg wrote:

oh, don't forget to bump date!

There's no date to bump?

Add one :)

This manual is not written in standard mdoc from what I can see. It's like it was written by martians.
It doesn't have any of the normal anchors I am familiar with.
I'll just shoehorn a date in here somewhere and hope it works. If it does, I'll hoist it up for review.

Oct 29 2018, 11:04 PM
dteske added a comment to D17739: Update awk(1) manual to accurately describe regex syntax..
In D17739#379438, @imp wrote:
In D17739#379046, @jmg wrote:

oh, don't forget to bump date!

There's no date to bump?

Add one :)

Oct 29 2018, 10:57 PM
dteske added a comment to D17739: Update awk(1) manual to accurately describe regex syntax..
In D17739#379439, @imp wrote:

Looks good to me...
Not sure about the \f syntax, but other places use it...

Oct 29 2018, 10:53 PM
dteske added a comment to D17739: Update awk(1) manual to accurately describe regex syntax..
In D17739#379046, @jmg wrote:

oh, don't forget to bump date!

Oct 29 2018, 9:44 PM

Oct 28 2018

dteske committed rS339845: Sort i18n messages in bsdinstall zfsboot.
Sort i18n messages in bsdinstall zfsboot
Oct 28 2018, 10:09 PM
dteske committed rS339844: Fix dialog autosizing to accomodate for hline.
Fix dialog autosizing to accomodate for hline
Oct 28 2018, 7:29 PM
dteske committed rS339843: Fix jail examples in jib, jng, README.
Fix jail examples in jib, jng, README
Oct 28 2018, 6:33 PM
dteske closed D17697: Fix jail examples in jib, jng, README.
Oct 28 2018, 6:32 PM
dteske added a reviewer for D17739: Update awk(1) manual to accurately describe regex syntax.: bapt.
Oct 28 2018, 6:20 PM
dteske created D17739: Update awk(1) manual to accurately describe regex syntax..
Oct 28 2018, 6:15 PM
dteske committed rS339830: Adjust for 80-columns..
Adjust for 80-columns.
Oct 28 2018, 12:58 AM

Oct 27 2018

dteske added a comment to D17697: Fix jail examples in jib, jng, README.

Do you have a commit bit or do you need me to ferry this in?

Oct 27 2018, 12:27 PM
dteske accepted D17697: Fix jail examples in jib, jng, README.

Looks good.

Oct 27 2018, 12:25 PM
dteske added inline comments to D17697: Fix jail examples in jib, jng, README.
Oct 27 2018, 2:32 AM

Oct 26 2018

dteske requested changes to D17697: Fix jail examples in jib, jng, README.
Oct 26 2018, 11:10 PM
dteske committed rS339783: Add blank line after each item in "ngctl ls -l".
Add blank line after each item in "ngctl ls -l"
Oct 26 2018, 7:16 PM
dteske committed rS339768: Adjust bsdinstall zfsboot code to 80-columns and whitespace fixes.
Adjust bsdinstall zfsboot code to 80-columns and whitespace fixes
Oct 26 2018, 5:25 AM
dteske committed rS339760: Fix dialog autosizing in bsdinstall auto error messages.
Fix dialog autosizing in bsdinstall auto error messages
Oct 26 2018, 2:08 AM
dteske committed rS339759: Whitespace alignment in bsdinstall hostname.
Whitespace alignment in bsdinstall hostname
Oct 26 2018, 1:57 AM
dteske committed rS339758: Sort i18n strings in bsdinstall hostname.
Sort i18n strings in bsdinstall hostname
Oct 26 2018, 1:48 AM
dteske committed rS339756: Add improved error checking to bsdinstall hostname.
Add improved error checking to bsdinstall hostname
Oct 26 2018, 1:06 AM
dteske committed rS339755: Fix dialog autosizing in bsdinstall hostname.
Fix dialog autosizing in bsdinstall hostname
Oct 26 2018, 12:08 AM

Oct 25 2018

dteske committed rS339752: Remove vestigial DIALOG_ITEM_HELP value in bsdconfig dialog.subr.
Remove vestigial DIALOG_ITEM_HELP value in bsdconfig dialog.subr
Oct 25 2018, 11:32 PM

Oct 24 2018

dteske committed rS339699: MFC r339509: Fix loader.conf(5) "password" feature.
MFC r339509: Fix loader.conf(5) "password" feature
Oct 24 2018, 11:31 PM
dteske committed rS339698: MFC r339509: Fix loader.conf(5) "password" feature.
MFC r339509: Fix loader.conf(5) "password" feature
Oct 24 2018, 11:21 PM
dteske committed rS339697: MFC r339509: Fix loader.conf(5) "password" feature.
MFC r339509: Fix loader.conf(5) "password" feature
Oct 24 2018, 11:17 PM
dteske committed rS339696: MFC r339509: Fix loader.conf(5) "password" feature.
MFC r339509: Fix loader.conf(5) "password" feature
Oct 24 2018, 11:14 PM
dteske updated the diff for D17113: Add new rc keywords: enable, disable, delete.

Rebase following r339413 and add patch for rc.conf(5) manual

Oct 24 2018, 5:56 PM

Oct 21 2018

dteske committed rS339509: Restore the ability to prevent the user from interrupting the boot process.
Restore the ability to prevent the user from interrupting the boot process
Oct 21 2018, 12:16 AM

Oct 2 2018

dteske committed rP481138: [New Port] sysutils/dwatch-json: FreeBSD dwatch profiles to produce JSON logs.
[New Port] sysutils/dwatch-json: FreeBSD dwatch profiles to produce JSON logs
Oct 2 2018, 10:12 PM
dteske closed D17316: [New Port] sysutils/dwatch-json: FreeBSD dwatch profiles to produce JSON logs.
Oct 2 2018, 10:12 PM
dteske updated the diff for D17316: [New Port] sysutils/dwatch-json: FreeBSD dwatch profiles to produce JSON logs.

Fix wrong URL in pkg-descr and update to 0.4.1 (and convert to pkg-plist)

Oct 2 2018, 2:22 AM
dteske planned changes to D17316: [New Port] sysutils/dwatch-json: FreeBSD dwatch profiles to produce JSON logs.
Oct 2 2018, 2:14 AM

Oct 1 2018

dteske updated the diff for D17316: [New Port] sysutils/dwatch-json: FreeBSD dwatch profiles to produce JSON logs.

Address feedback from mat@ and update to 0.3.1

Oct 1 2018, 2:13 AM

Sep 25 2018

dteske added a comment to D17113: Add new rc keywords: enable, disable, delete.

Thanks @lme for checking for potential conflict.

Sep 25 2018, 6:51 PM
dteske updated the diff for D17316: [New Port] sysutils/dwatch-json: FreeBSD dwatch profiles to produce JSON logs.

Update to 0.1.1

Sep 25 2018, 6:46 PM
dteske updated the diff for D17316: [New Port] sysutils/dwatch-json: FreeBSD dwatch profiles to produce JSON logs.

Make `portlint -A' happy

Sep 25 2018, 6:27 PM
dteske created D17316: [New Port] sysutils/dwatch-json: FreeBSD dwatch profiles to produce JSON logs.
Sep 25 2018, 6:22 PM

Sep 24 2018

dteske added a comment to D17113: Add new rc keywords: enable, disable, delete.

I just thought of something ...

Sep 24 2018, 8:36 PM

Sep 19 2018

dteske retitled D17113: Add new rc keywords: enable, disable, delete from Add new rc keywords: enable, disable, rcdelete to Add new rc keywords: enable, disable, delete.
Sep 19 2018, 1:38 AM
dteske updated the summary of D17113: Add new rc keywords: enable, disable, delete.
Sep 19 2018, 12:39 AM
dteske updated the diff for D17113: Add new rc keywords: enable, disable, delete.

Provide a new offering

Sep 19 2018, 12:35 AM
dteske commandeered D17113: Add new rc keywords: enable, disable, delete.

Take

Sep 19 2018, 12:35 AM

Sep 18 2018

dteske added inline comments to D17113: Add new rc keywords: enable, disable, delete.
Sep 18 2018, 11:29 PM
dteske added inline comments to D17113: Add new rc keywords: enable, disable, delete.
Sep 18 2018, 11:13 PM

Sep 11 2018

dteske added inline comments to D16857: Introduce certctl(8).
Sep 11 2018, 10:36 PM
dteske added a comment to D17113: Add new rc keywords: enable, disable, delete.

This patch is a good effort. Let's keep building upon it and get it ready for when head is thawed on Sep 23. Thank you for resurrecting this topic.

Sep 11 2018, 10:04 PM
dteske requested changes to D17113: Add new rc keywords: enable, disable, delete.
Sep 11 2018, 9:59 PM
dteske added a reviewer for D17113: Add new rc keywords: enable, disable, delete: dteske.
Sep 11 2018, 9:32 PM

Aug 31 2018

dteske added inline comments to D16857: Introduce certctl(8).
Aug 31 2018, 5:06 AM
dteske added a comment to D16857: Introduce certctl(8).

The patch is showing usr.sbin/certctl/trustctl.sh -- is this a phab issue or did the file not get renamed in the patch?

Aug 31 2018, 5:05 AM

Aug 29 2018

dteske added inline comments to D16857: Introduce certctl(8).
Aug 29 2018, 6:59 AM
dteske added inline comments to D16857: Introduce certctl(8).
Aug 29 2018, 6:59 AM

Aug 23 2018

dteske accepted D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Aug 23 2018, 10:45 PM
dteske added inline comments to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Aug 23 2018, 10:42 PM
dteske added a comment to D16857: Introduce certctl(8).

Template suggestion because file is pretty large

Aug 23 2018, 9:04 PM
dteske requested changes to D16857: Introduce certctl(8).

Hope this helps

Aug 23 2018, 9:00 PM
dteske added a comment to D16857: Introduce certctl(8).

Corrections

Aug 23 2018, 8:58 PM

Aug 22 2018

dteske added a comment to D16839: Add SCTP support to dtrace.

Thank you so much for your work on this. It is very much appreciated.

Aug 22 2018, 11:20 PM
dteske added a comment to D16839: Add SCTP support to dtrace.

I would just like to comment for the record that I wish there was more time before the 12.0 release so that I could have created dwatch profiles to simplify tapping into these new hooks. I don't have enough time to develop that before 12.0 is completely frozen.

Aug 22 2018, 4:29 PM
dteske added a comment to D16839: Add SCTP support to dtrace.

Please run igor -Dgpxy on the manual changes. OK to ignore any nits it complains about that you didn't introduce yourself.

Aug 22 2018, 4:27 PM
dteske added a comment to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.

Additional comments following an update

Aug 22 2018, 4:26 PM