- User Since
- Sep 2 2014, 7:30 PM (202 w, 4 d)
Can you expand your patch to include the creation of a corresponding dwatch module? It's easy ...
Worth mentioning, I tested on stable/11 (for MFC consideration).
Testing was successful. Everything worked as expected. Cheers.
Thu, Jul 19
Aside from testing with what comes with FreeBSD base, I also wanted to make sure that this change would be handled well by my DTrace network visualizer (sysutils/dwatch-gource in ports).
I have used both your attached udpio.d (taken from dtrace_udp(4) in the EXAMPLES section) as well as "dwatch -X udp" in the base system to confirm the pre-patch state. A probe fires when nc (in the given test case of "nc -u 127.0.0.1 1234") sends the datagram but no probe fires for the receive.
Removed bapt and closed (was already committed but not closed because phab bugette)
Mon, Jul 16
If it's OK, I'd like to run some tests with dwatch to make sure that I don't need to patch my code for any change in functionality. I don't suspect this to be the case, but just want to make sure. If you're fine to wait another day or two for my testing, I'll definitely stamp approval
Sat, Jul 7
Update diff to just the low-hanging (non-vendor) changes
Fri, Jul 6
Thu, Jul 5
Wed, Jul 4
I think this is a bug in phabricator. The review was in "closed" state and committed. Then a comment caused it to go back into "Needs Review". The person that added the comment (antoine) even came back and accepted and it still shows as "Needs Review". Can't close this ticket until it is in approved. I'd rather not use the sledgehammer of removing all the reviewers.
@antoine can you accept so I can close?
Tue, Jul 3
Fri, Jun 29
Been thinking about this for the past day. I can't think of any suitable value for either prefix or suffix. I'm open to suggestions -- perhaps you've delt with this in the past and have a suggestion for suitable value when this occurs.
Thu, Jun 28
Wed, Jun 27
Tue, Jun 26
Sun, Jun 24
Sat, Jun 23
Turns out they only look similar. download forwards to HTTPS and http://ftp.freebsd.org/ also has a different structure to access the data. For example, on download, the releases are in /ftp/releases/ while on http://ftp.freebsd.org/ the releases are in /pub/FreeBSD/releases/
To prevent the "This revision was not accepted when it landed; it landed in state Needs Review." moniker being attached to thsi review, can you re-approve?
Jun 21 2018
Jun 20 2018
Add sysutils/Makefile modification
Blocked by pre-commit hook:
Add sysutils/Makefile modification
Embiggen pkg-descr ^_^
Trim pkg-descr for relevancy
Jun 18 2018
Address feedback from mat
Make pkg-descr more descriptive
Thanks for the explanation, cheers!
Address feedback by bapt
Add support for smart utility by Chuck Tuffli
Jun 17 2018
Jun 16 2018
I don't agree with this change in its current iteration as it will break scripts which expect *addr to be translated to a NULL pointer should the pointer indeed be NULL. Changing the default value from a NULL pointer to an adhoc string (specifically in the context of changing it in the translator) puts the onus on script writers to test for the explicit string constant instead of NULL. This may be fine if the translator were not already established, but these are already well into their years.
Jun 7 2018
Jun 3 2018
Jun 1 2018
May 31 2018
Also note: I removed check of OPSYS because it looks like it can be "DragonFly" which in my mind would have an OSVERSION that tracks with FreeBSD's. Willing to put back OPSYS check, thoughts?