I second what @ngie said -- seems like default should be enabled (POLA and all)

In D58133#1394590, @bcr wrote:

OK from manpages for these latest changes.

@wanpengqian_gmail.com Thank you for the submission. Committed to 16.0-CURRENT

LGTM

In D60835#1395292, @uzsolt wrote:

So If I understand it correctly can't split really into two stages only just an ugly workaround (build and install into a temp directory). In this case the BUILD_DEPENDS+=...math/R is unnecessary in cran.mk. Thanks for explanation.

@uzsolt @jrm I created D60843 to capture the separation of build and install stages

Rebase, update build tag, improve descr

BUILD_DEPENDS cleanup looks good

In D60835#1395063, @uzsolt wrote:

Only an idea: can we separate the build and install stage in "R CMD INSTALL"? I'd prefer it. Today I don't have time to test but maybe the "R CMD INSTALL --build" (with fine tuning) works (I did only one small test).
If exist a solution can introduce into cran.mk.
I don't know but maybe there are cran ports that have real build-time dependencies (required only building e.g. gmake in other regular ports).

What do you think?

(IMHO the cran.mk it isn't perfect e.g. doesn't respect TEST_ENV variable)

@jlduran (and others), I've sent a call-for-review (CFR) to freebsd-jail@ ML -- if no response over the next 4 weeks, I'll probably merge without additional feedback

In D60817#1395160, @fuz wrote:

In src, we have certain people who shall remain nameless that will jump on you if you don't have at least one reviewer (which is ridiculous considering that very same person commits 50% of their submissions with zero reviewers). I don't know if we have any such people in the ports-committers but that's what I am trying to avoid by getting a reviewer on all my changes.

In ports, we don't usually post things for review unless review is explicitly desired. So don't worry about it and just push your changes directly, unless they require approval (e.g. by maintainer or portmgr) or you wish for review. You'll also find most code review in ports to happen on Bugzilla, but Phab is definitely allowed.

In D60817#1395137, @fuz wrote:

Could you do me a favour and only submit your DR once it is complete on your side and you expect no more changes to be done unless the reviewer find something?
It is quite irritating to review a change set and then to have to go back and review it again because you have decided to piggyback more changes onto it.
If you continue doing this, I'll start to let your DRs sit for a few days to “cool off” before I look at them so I can be more certain that I'll have to review only once.

Fix non-root service airplane-radiosd status

Bring in additional usability improvements

One last usability improvement. Show a bosd error if the lid-switchd
socket is unwritable, pointing the user at lid-switchd(8) man-page,
informing them that they have to pw groupmod lid_switchd -m username
and log-out then back in to join the group that is able to talk to
the lid-switchd daemon through its socket owned by root:lid_switchd

Slurp in a couple more changes

Note that making these all consistent is another step toward asking portmgr if we can then remove them, following the introduction of sensible default introduced by D59678 (we wouldn't remove all WWW from every R-cran-* port, just potentially the ones that set the same value as the default introduced by D59678)

Inspired by D60718 and follow-up to D59714

ALL regression tests passing

Fix off-by-one error introduced by Diff 4 (187779) s/<=/</

Much better! A patched system now raises no exception on tests 3 and 4 (out of 5) as-shown below:

Issue was an off-by-one introduced in Diff 4 (187779), the enum/target_resolved rewrite for kib

makesum to pull in recent fix and tag move

This is a follow-up to D59924

In D59924#1387450, @dteske wrote:

@fuz thanks, I will raise a follow-up

In D60773#1394435, @kfv wrote:

Cool. OK then, I'll do a DR for it shortly.

In D60682#1393904, @salvadore wrote:

Approved once the [.filename] macro is used for filenames, thanks!

In D60681#1391917, @jrm wrote:

The commit message subject says, "x11/bhotkeys: Update to 1.2", but the changes are to x11/bhotkeys-audio. Other than that, everything looks good to me.

In D60035#1390644, @kib wrote:

In D60035#1390556, @markj wrote:

Could you please add some tests?

I believe dteske@ will add converted tests from b98d169d1f910e0b28c7

In D60035#1390426, @kib wrote:

Ping?

Fix copy/pasta in pkg-descr (jrm)

Override Cargo.toml's rust version because lang/rust is 1.98.1

Fix RUN_DEPENDS

Update distinfo

Sort RUN_DEPENDS as-per portfmt -D Makefile