dteske (Devin Teske)
User

Projects

User Details

User Since
Sep 2 2014, 7:30 PM (151 w, 1 h)

Recent Activity

Jun 8 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Fixed typo as part of last update. Marking inline comments as done.

Jun 8 2017, 1:52 AM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

I've only just started playing with it, but I'll point out that the usage seems misleading: dwatch doesn't really take a (dtrace) probe as input, it takes a function or syscall name and constructs a probe name.

Jun 8 2017, 1:51 AM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

I am running an open public beta of this software. To test the software that is currently submitted here for review, head over to pkg.fraubsd.org in your browser, pick an architecture, and either follow the instructions for setting up the FrauBSD pkg repository and say "pkg install fraubsd/dwatch" or download the dwatch tarball and install with "pkg add PKGFILENAME.txz"

Jun 8 2017, 1:44 AM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Complete overhaul in an effort to address earlier feedback.

Jun 8 2017, 1:14 AM

May 25 2017

dteske committed rS318891: Fix long standing issue in bsdconfig's keymap selection.
Fix long standing issue in bsdconfig's keymap selection
May 25 2017, 6:16 PM
dteske closed D8734: HBSD: fix long standing issue in bsdconfig's keymap selection by committing rS318891: Fix long standing issue in bsdconfig's keymap selection.
May 25 2017, 6:16 PM
dteske added a comment to D8734: HBSD: fix long standing issue in bsdconfig's keymap selection.

@dteske will you commit it?

May 25 2017, 5:37 PM
dteske accepted D10895: Make the ZFS min_auto_ashift=12 setting persistent.

LGTM

May 25 2017, 5:32 PM

May 19 2017

dteske accepted D10738: bsdinstall: mount is not needed for the ZFS install case.

LGTM

May 19 2017, 5:28 PM

May 18 2017

dteske requested changes to D10738: bsdinstall: mount is not needed for the ZFS install case.
May 18 2017, 10:00 PM

May 3 2017

dteske added a comment to D10585: Document "MFC to" and "MFC with" commit tags.

"MFC after" and "X-MFC-after" are two different things.

That's precisely my point. X-MFC-after is being used intentionally to avoid being parsed by the MFC script, because the commit author believes the MFC reminder script will not be able to parse the value. That's distinct from X-MFC-to or X-MFC-with, where MFC to or MFC with would not cause trouble for the reminder script.

May 3 2017, 6:09 PM
dteske added a comment to D10585: Document "MFC to" and "MFC with" commit tags.

Can we add "MFC before:"?

I don't want to make this too long and would prefer to avoid special cases that have only occasional use. Right now it is unlikely "MFC before" could be automatically parsed. By its nature it will be somewhat unrestricted text, and even if we did parse it I don't think we want to build tooling to make the reminder script aware of upcoming branch / release dates.

May 3 2017, 6:08 PM
dteske requested changes to D10585: Document "MFC to" and "MFC with" commit tags.

Can we add "MFC before:"? E.g., "If the commit should be merged before some particular branch creation, specify the branch name(s)." Example: "MFC before: RC-3". Used by bz and gjb. See revisions 285733, 285082, 285078, 285076, 259427, 259426, 185435, and 148871.

May 3 2017, 5:11 PM

Apr 26 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Update to apply cleanly to HEAD
Add "-x" option to enable probe tracing
Don't set caller_execname unless hooked on syscall::execve
Fix indentation in generated dtrace(1) code
Beautify generated dtrace(1) code
Fix nested DTrace predicates; "-t test" now works with profiles
Postpone jail predicate generation until after profile loading
Fix a missing ".Ar" in dwatch(8) manual
Update examples/profile_template to include EVENT_TEST info
Change "kill" profile to print unmodified pid_t argument
Fix signedness in printf for signal argument in "kill" profile
Add code to "vop_*" profiles to NULL-ify transient variables
Optimize vnode-walking process in VFS profiles
Fix ellipsis generation for paths exceeding DEPTH_MAX in VFS profiles
Update VFS profiles to use EVENT_TEST instead of EVENT for predicates
Fix incorrect "probe ID" comments generated by vop_rename profile

Apr 26 2017, 10:19 PM

Apr 25 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Update patch to apply cleanly to HEAD
Fix generation of ellipsis for trailing arguments
Remove double-quotes on $COUNT which is guaranteed to be a number

Apr 25 2017, 11:33 PM

Apr 20 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Add "-t test" option for customizing dtrace(1) predicate
Add "-j jail" option for limiting events to a jail name/jid
Change "-p" option (disable profiles) to "-P"
Add "-p pid" option for watching a particular process id
When given "-D-" perform all error checks before reading stdin
Issue an error and exit if group in "-g name" does not exist
Fix spurious double-error when given bad user in "-u name"
Given "-u user" and "-g group" but not "-q", display user before group
Use walltimestamp instead of timestamp for event date/time
Very minor refactoring for code readability
Make ending semi-colon for "-D code" optional
Whitespace and comments
Minor fixes to grammar and punctuation in manual
Sort examples in manual by flag being demonstrated
Add the following examples to manual:
dwatch -f '(mk|rm)dir' execve
dwatch -g wheel execve
dwatch -j 0 execve
dwatch -j myjail execve
dwatch -l 'read$'
dwatch -p 1234 execve
dwatch -q -t 'arg2<10' -D 'printf("%d",arg2)' write
dwatch -v -p 1234 execve

Apr 20 2017, 12:13 AM

Mar 29 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Update diff to apply cleanly to HEAD
Make -q flag squelch errors from dtrace(1)

Mar 29 2017, 8:12 PM

Mar 28 2017

dteske added a reviewer for D10006: Add dwatch(8) for watching processes as they enter dtrace probe: avg.
Mar 28 2017, 4:09 AM

Mar 27 2017

dteske added a member for DTrace: dteske.
Mar 27 2017, 6:43 PM
dteske added a reviewer for D10006: Add dwatch(8) for watching processes as they enter dtrace probe: DTrace.
Mar 27 2017, 6:40 PM
dteske added a reviewer for D10006: Add dwatch(8) for watching processes as they enter dtrace probe: skreuzer.
Mar 27 2017, 6:21 PM
dteske added a reviewer for D10006: Add dwatch(8) for watching processes as they enter dtrace probe: gnn.
Mar 27 2017, 6:21 PM
dteske removed a reviewer for D10006: Add dwatch(8) for watching processes as they enter dtrace probe: gnn.
Mar 27 2017, 6:21 PM

Mar 23 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

I wanted to take a moment to explain why the probe syntax for dwatch(8) is "[provider:[module:]]function" and not "[provider:[module:[function:]]]name" as is the probe syntax for dtrace(1).

Mar 23 2017, 7:24 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Incorporate much feedback from previous comments on this review
Update patch to apply cleanly to head
Make lchmod a hard link to chmod
Make vop_{lookup,mkdir,mknod,remove,rmdir} a hard link to vop_create
Change terminology to name dwatch(8) modules to instead profiles
NB: Prevents term modules from being confused with dtrace(1)
Improve readability and simplify code
Move -e code option to -D code for injecting DTrace event detail code
Move -p action option to -e name for modifying the event action
Move -M option to -p for disabling profiles (formerly termed modules)
Update usage statement to be more clear about what a "probe" is
NB: Instead of "probe" show that we expect "[provider:[module:]]function"
Simplify profile loading
Set $FILE $PROFILE and $PROBE before loading profile(s)
Consolidate file descriptor operations
Fix a bug where -u root or -g root did not work as expected
NB: Also fixed -u 0 and -g 0 which suffered from the same issue
Add further clarification to the manual page with respect to probe format
Add examples to the manual page
Move examples/module_template to examples/profile_template
Improve comments in examples/profile_template
Reduce size of profiles, removing comments inherited from profile_template
Add numerical suffixes in nanosleep profile (s for seconds; ns for nanosec)
Add support for -l -e name [pattern] syntax
NB: The -l [pattern] syntax did not support -e name before

Mar 23 2017, 12:29 AM

Mar 22 2017

dteske planned changes to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

I have thought of a way to massively reduce the size of the diff. In the spirit of asomers observation that several of the modules are quite similar, I've decided to improve the functionality provided to modules which will allow the modules to be linked to each other whilst preserving explicit probe value.

Mar 22 2017, 5:59 PM

Mar 21 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

The first thing I tried (without having fully read the manpage) was "dwatch sched:::on-cpu", which of course gives an error.

Mar 21 2017, 12:09 AM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Optimize filtration

Mar 21 2017, 12:05 AM

Mar 20 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

When a dwatch(8) module does not define DETAILS, default to pproc_dump()

Mar 20 2017, 11:59 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Fix mdoc warning: .It macros in lists of type `tag-list' require arguments

Mar 20 2017, 11:57 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Allow modules to contain hyphen in their name

Mar 20 2017, 11:51 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Add `-p action' flag, example usage: dwatch -p on-cpu sched::

Mar 20 2017, 11:45 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Update patch to apply cleanly against latest HEAD

Mar 20 2017, 11:25 PM

Mar 18 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Move back to cddl/usr.sbin to live amongst similarly [BSD] licensed zfsd
Update ObsoleteFiles.inc to remove deprecated/removed watch_* scripts
Fix a copy/paste issue in the manual (s/lchmod/nanosleep/)
Add usr/libexec/dwatch to etc/mtree/BSD.usr.dist

Mar 18 2017, 4:17 PM

Mar 17 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

@dteske Don't forget to update etc/mtree/BSD.usr.dist

Mar 17 2017, 6:42 PM

Mar 16 2017

dteske added inline comments to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.
Mar 16 2017, 3:49 PM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

I'll point out that the usage seems misleading: dwatch doesn't really take a (dtrace) probe as input,
it takes a function or syscall name and constructs a probe name.

Mar 16 2017, 3:44 PM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

A few observations that may help answer the Q of "usr.sbin vs cddl/usr.sbin"...

Mar 16 2017, 12:08 AM

Mar 15 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Back out of cddl and whack deprecated share/dtrace scripts

Mar 15 2017, 11:35 PM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.
In D10006#206784, @gnn wrote:

New, BSD license, code does not need to be in cddl.

Mar 15 2017, 11:29 PM

Mar 14 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Address comments

Mar 14 2017, 9:48 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Move utility from usr.sbin/dwatch to cddl/usr.sbin/dwatch

Mar 14 2017, 8:40 PM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they enter dtrace probe.

Since dwatch depends on dtrace, which is CDDL-licensed, shouldn't dwatch live in cddl/usr.sbin/dwatch instead of usr.sbin/dwatch? That way it can easily be excluded from a CDDL-free build.

Mar 14 2017, 8:30 PM
dteske created D10006: Add dwatch(8) for watching processes as they enter dtrace probe.
Mar 14 2017, 8:00 PM

Feb 9 2017

dteske added a comment to D9480: security/openssl: Enable ASM by default.

For reference, here's where this all stemmed from https://fraubsd.org/doc/nginx_plus_with_ports_openssl_and_aesni.png

Feb 9 2017, 8:47 PM
dteske added a comment to D9480: security/openssl: Enable ASM by default.

Tried closing this revision but because asomers blocked it, phabricator tells me it can't be closed.

Feb 9 2017, 2:34 AM
dteske added 1 commit(s) for D9480: security/openssl: Enable ASM by default: rP433671: security/openssl: Enable ASM by default.
Feb 9 2017, 2:32 AM
dteske added an edge to rP433671: security/openssl: Enable ASM by default: D9480: security/openssl: Enable ASM by default.
Feb 9 2017, 2:32 AM
dteske accepted D9480: security/openssl: Enable ASM by default.
Feb 9 2017, 2:26 AM
dteske added a comment to D9480: security/openssl: Enable ASM by default.

Bumping the .so revision puts a big onus on some vendors to recompile their software for almost zero reason.

Feb 9 2017, 1:43 AM

Feb 7 2017

dteske added a comment to D9480: security/openssl: Enable ASM by default.

I think we need a "PORTREVISION= 1"

Feb 7 2017, 10:04 PM

Feb 4 2017

dteske added a comment to D9419: Add HISTORY and AUTHORS section to timeout(1) manual.
In D9419#194594, @ngie wrote:
  1. Could you please run igor on the manpage?
Feb 4 2017, 5:29 PM
dteske added a comment to D9419: Add HISTORY and AUTHORS section to timeout(1) manual.
In D9419#194594, @ngie wrote:
  1. Wasn't AUTHORS supposed to be above HISTORY?
Feb 4 2017, 5:27 PM

Feb 2 2017

dteske added a reviewer for D9419: Add HISTORY and AUTHORS section to timeout(1) manual: ngie.
Feb 2 2017, 7:59 PM
dteske updated subscribers of D9419: Add HISTORY and AUTHORS section to timeout(1) manual.
Feb 2 2017, 6:08 PM
dteske updated the diff for D9419: Add HISTORY and AUTHORS section to timeout(1) manual.

Bump .Dd

Feb 2 2017, 6:07 PM
dteske retitled D9419: Add HISTORY and AUTHORS section to timeout(1) manual from to Add HISTORY and AUTHORS section to timeout(1) manual.
Feb 2 2017, 6:00 PM

Jan 8 2017

dteske committed rS311690: MFC improvements to bsdinstall's wlanconfig module.
MFC improvements to bsdinstall's wlanconfig module
Jan 8 2017, 6:14 PM
dteske committed rS311686: MFC r309716: Add support for "hidden" Wi-Fi networks.
MFC r309716: Add support for "hidden" Wi-Fi networks
Jan 8 2017, 4:56 PM

Dec 13 2016

dteske committed rS310038: Revert r309918 -- modern POSIX has deprecated -<#>/+<#> syntax.
Revert r309918 -- modern POSIX has deprecated -<#>/+<#> syntax
Dec 13 2016, 10:32 PM
dteske committed rS310011: MFC r308615 [brd]:.
MFC r308615 [brd]:
Dec 13 2016, 4:53 AM
dteske committed rS310010: MFC r309504: Fix bug preventing limits(1) from being applied.
MFC r309504: Fix bug preventing limits(1) from being applied
Dec 13 2016, 4:50 AM
dteske committed rS310009: MFC r307159: Add jail_confwarn="NO" (default YES).
MFC r307159: Add jail_confwarn="NO" (default YES)
Dec 13 2016, 4:47 AM
dteske committed rS310008: MFC r306012 [trasz]:.
MFC r306012 [trasz]:
Dec 13 2016, 4:45 AM
dteske committed rS310007: MFC r306011 [trasz]:.
MFC r306011 [trasz]:
Dec 13 2016, 4:44 AM
dteske committed rS310006: MFC r306009 [trasz]:.
MFC r306009 [trasz]:
Dec 13 2016, 4:43 AM
dteske committed rS310005: MFC r305969 [trasz]:.
MFC r305969 [trasz]:
Dec 13 2016, 4:42 AM
dteske committed rS310004: MFC r305968 [trasz]:.
MFC r305968 [trasz]:
Dec 13 2016, 4:40 AM
dteske committed rS310003: MFC r303943: Allow enforce_statfs (see jail(8)) to be set per jail.
MFC r303943: Allow enforce_statfs (see jail(8)) to be set per jail
Dec 13 2016, 4:37 AM
dteske committed rS310002: MFC r302798 [cy]: Restore lost comment from r301295..
MFC r302798 [cy]: Restore lost comment from r301295.
Dec 13 2016, 4:35 AM
dteske committed rS310001: Merge missing mergeinfo for r303877.
Merge missing mergeinfo for r303877
Dec 13 2016, 4:25 AM
dteske committed rS309998: It's completely pointless to replace newlines with space.
It's completely pointless to replace newlines with space
Dec 13 2016, 2:57 AM
dteske committed rS309997: The flags of a WLAN need to be quoted (they contain things like brackets).
The flags of a WLAN need to be quoted (they contain things like brackets)
Dec 13 2016, 2:54 AM
dteske committed rS309996: Simplify single-line if statements.
Simplify single-line if statements
Dec 13 2016, 2:48 AM
dteske committed rS309995: Simplify loop by moving predicate to clause.
Simplify loop by moving predicate to clause
Dec 13 2016, 2:47 AM
dteske committed rS309994: Wordsmithing.
Wordsmithing
Dec 13 2016, 2:46 AM
dteske committed rS309993: Why test $? when you can test the command.
Why test $? when you can test the command
Dec 13 2016, 2:46 AM
dteske committed rS309992: Restore previous comment.
Restore previous comment
Dec 13 2016, 2:45 AM
dteske committed rS309991: Both simplify bringup of interface after changes and catch errors in debug.
Both simplify bringup of interface after changes and catch errors in debug
Dec 13 2016, 2:44 AM
dteske committed rS309990: Calculate proper size of menu list dialog.
Calculate proper size of menu list dialog
Dec 13 2016, 2:42 AM
dteske committed rS309989: There's an API function for catching errors and displaying them or.
There's an API function for catching errors and displaying them or
Dec 13 2016, 2:41 AM
dteske committed rS309988: There's an API function for displaying pauses.
There's an API function for displaying pauses
Dec 13 2016, 2:30 AM
dteske committed rS309987: There's an API function for displaying yes/no dialogs.
There's an API function for displaying yes/no dialogs
Dec 13 2016, 2:29 AM
dteske committed rS309986: There's an API function for displaying errors.
There's an API function for displaying errors
Dec 13 2016, 2:27 AM
dteske committed rS309985: Comment.
Comment
Dec 13 2016, 2:25 AM
dteske committed rS309984: Whitespace alignment.
Whitespace alignment
Dec 13 2016, 2:23 AM
dteske committed rS309983: Relying on dialog auto-sizing (width/height/rows = 0) is a mistake.
Relying on dialog auto-sizing (width/height/rows = 0) is a mistake
Dec 13 2016, 2:22 AM
dteske committed rS309982: Remove unnecessary quotes.
Remove unnecessary quotes
Dec 13 2016, 2:16 AM
dteske committed rS309981: Add missing quotes.
Add missing quotes
Dec 13 2016, 2:15 AM
dteske committed rS309980: In awk, if you're going to append a newline to your printf.
In awk, if you're going to append a newline to your printf
Dec 13 2016, 2:14 AM
dteske committed rS309979: This statement has too many backslashes.
This statement has too many backslashes
Dec 13 2016, 2:13 AM
dteske committed rS309978: Neither printf (and as is commonly known) nor print need parens in awk.
Neither printf (and as is commonly known) nor print need parens in awk
Dec 13 2016, 2:12 AM
dteske committed rS309977: Whitespace and alignment.
Whitespace and alignment
Dec 13 2016, 2:11 AM
dteske committed rS309976: You don't need parentheses for awk's printf.
You don't need parentheses for awk's printf
Dec 13 2016, 2:07 AM
dteske committed rS309975: Continued resolution of conveluted statement.
Continued resolution of conveluted statement
Dec 13 2016, 2:05 AM
dteske committed rS309974: These two error messages have always been backwards since inception.
These two error messages have always been backwards since inception
Dec 13 2016, 2:02 AM
dteske committed rS309973: Why use $? when you can use the command itself.
Why use $? when you can use the command itself
Dec 13 2016, 1:59 AM
dteske committed rS309972: If the first ping succeeded, why on Earth should we ping it again?.
If the first ping succeeded, why on Earth should we ping it again?
Dec 13 2016, 1:56 AM
dteske committed rS309971: Start deconstructing a conveluted hunk of code.
Start deconstructing a conveluted hunk of code
Dec 13 2016, 1:54 AM
dteske committed rS309970: Remove completely unnecesary parentheses.
Remove completely unnecesary parentheses
Dec 13 2016, 1:52 AM