Just a simple bogon in the src bits, after which I will approve

Thank for submitting. Give me a chance to review, but I do believe this looks like a good candidate for commit. Thank you

Sorry for the delay, had a disk failure take out my operations for a full 4 weeks, but finally got all the data recovered and back up and running

Hi markj,

I've only a couple changes I'll make before committing with reference to OP. Instead of "doclose" I will use "opened" which makes the code easier to read.

Take

I'm going to set an ETIMEOUT of 30 days. If there is no objection, I will import to base HEAD.

Indentation fixes. Fix whitespace for consistency. Fix >80c lines.

Pre-update commandeer

LGTM

@crees oh, didn't know @debdrup wasn't a committer. You know how you get so used to seeing someone's name in your TL that you just assume they are in-the-fold ;D lol

Thank you!

Returning to this, as I still want to add it to base.

In D23641#525823, @emaste wrote:

Ping?

The purpose of the awk is to trim a single leading-tab from the input.

In D16132#498554, @hselasky wrote:

In pkg we have a SAT solver. Can you explain how your CMB compares to a SAT solver?

I've had time to reflect, and I sincerely apologize for my unreasonable reaction to a reasonable inquiry.

Remove PORTVERSION

Remove PORTVERSION

In D22681#496190, @jhb wrote:

Erm, there's this bit in bsd.port.Mk:

.if defined(DISTVERSION)
DEV_ERROR+=     "Defining both PORTVERSION and DISTVERSION is wrong, only set one, if necessary, set DISTNAME"
.endif

I suspect DEV_ERROR means it only errors if you have DEVELOPER=yes set in /etc/make.conf as the porter's handbook recommends (see the start of chapter 3 at https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html). I ran into this error the other day myself when I had a bug in one of my ports (was including bsd.port.mk again after bsd.port.pre.mk).

So maybe before you blast someone with "please test before submitting reviews" maybe *you* should test

You know that field in Phabricator and arc that says "Test Plan"?

Remove extra newline

Remove extra newline as-per mat's instruction

Remove extra newline as-per mat

Remove extra newline as-per mat

Remove extra newline per-mat

Remove extra newline

Drop Makefile change from review (done by addport)

Drop Makefile change from review (done by addport)

Drop Makefile change from review (done by addport)

Drop Makefile change from review (done by addport)

Drop Makefile change from review (done by addport)

Update LICENSE in Makefile

In D22628#495001, @mat wrote:

That is only one line of code worth. What problem are you trying to solve?

Remove noninja args to USES=cmake

In D22628#495001, @mat wrote:

That is only one line of code worth. What problem are you trying to solve?

Overhaul [lib]cmb offerings to address previous feedback