Page MenuHomeFreeBSD

dteske (Devin Teske)
src and ports committer

Projects

User Details

User Since
Sep 2 2014, 7:30 PM (211 w, 13 h)

Creator/Maintainer of FreeBSD bootloader-menu/bsdconfig/dpv/dwatch/figpar/sysrc
Maintainer of FreeBSD base/bsdinstall/DTrace/forth/jail/netgraph/ports/vnet
Maintainer of FreeBSD ports: (net-p2p) shx (sysutils) bsdconfig cmocka DTraceToolkit dwatch-gource dwatch-pwsnoop host-setup mping ssd_report sysrc tzdialog zfs-stats-lite
Drive-by's: (devel) p4d p4web (emulators) xen xen-kernel (net) pptpclient (ports-mgmt) pkg (sysutils) getssl syslinux vzvol

Recent Activity

Today

dteske retitled D17113: Add new rc keywords: enable, disable, delete from Add new rc keywords: enable, disable, rcdelete to Add new rc keywords: enable, disable, delete.
Wed, Sep 19, 1:38 AM
dteske updated the summary of D17113: Add new rc keywords: enable, disable, delete.
Wed, Sep 19, 12:39 AM
dteske updated the diff for D17113: Add new rc keywords: enable, disable, delete.

Provide a new offering

Wed, Sep 19, 12:35 AM
dteske commandeered D17113: Add new rc keywords: enable, disable, delete.

Take

Wed, Sep 19, 12:35 AM

Yesterday

dteske added inline comments to D17113: Add new rc keywords: enable, disable, delete.
Tue, Sep 18, 11:29 PM
dteske added inline comments to D17113: Add new rc keywords: enable, disable, delete.
Tue, Sep 18, 11:13 PM

Tue, Sep 11

dteske added inline comments to D16857: Introduce certctl(8).
Tue, Sep 11, 10:36 PM
dteske added a comment to D17113: Add new rc keywords: enable, disable, delete.

This patch is a good effort. Let's keep building upon it and get it ready for when head is thawed on Sep 23. Thank you for resurrecting this topic.

Tue, Sep 11, 10:04 PM
dteske requested changes to D17113: Add new rc keywords: enable, disable, delete.
Tue, Sep 11, 9:59 PM
dteske added a reviewer for D17113: Add new rc keywords: enable, disable, delete: dteske.
Tue, Sep 11, 9:32 PM

Fri, Aug 31

dteske added inline comments to D16857: Introduce certctl(8).
Fri, Aug 31, 5:06 AM
dteske added a comment to D16857: Introduce certctl(8).

The patch is showing usr.sbin/certctl/trustctl.sh -- is this a phab issue or did the file not get renamed in the patch?

Fri, Aug 31, 5:05 AM

Wed, Aug 29

dteske added inline comments to D16857: Introduce certctl(8).
Wed, Aug 29, 6:59 AM
dteske added inline comments to D16857: Introduce certctl(8).
Wed, Aug 29, 6:59 AM

Thu, Aug 23

dteske accepted D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Thu, Aug 23, 10:45 PM
dteske added inline comments to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Thu, Aug 23, 10:42 PM
dteske added a comment to D16857: Introduce certctl(8).

Template suggestion because file is pretty large

Thu, Aug 23, 9:04 PM
dteske requested changes to D16857: Introduce certctl(8).

Hope this helps

Thu, Aug 23, 9:00 PM
dteske added a comment to D16857: Introduce certctl(8).

Corrections

Thu, Aug 23, 8:58 PM

Wed, Aug 22

dteske added a comment to D16839: Add SCTP support to dtrace.

Thank you so much for your work on this. It is very much appreciated.

Wed, Aug 22, 11:20 PM
dteske added a comment to D16839: Add SCTP support to dtrace.

I would just like to comment for the record that I wish there was more time before the 12.0 release so that I could have created dwatch profiles to simplify tapping into these new hooks. I don't have enough time to develop that before 12.0 is completely frozen.

Wed, Aug 22, 4:29 PM
dteske added a comment to D16839: Add SCTP support to dtrace.

Please run igor -Dgpxy on the manual changes. OK to ignore any nits it complains about that you didn't introduce yourself.

Wed, Aug 22, 4:27 PM
dteske added a comment to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.

Additional comments following an update

Wed, Aug 22, 4:26 PM

Aug 11 2018

dteske committed rS337611: dwatch(1): Add systop profile.
dwatch(1): Add systop profile
Aug 11 2018, 6:32 AM
dteske committed rS337610: dwatch(1): Fix syntax error in vop_readdir profile.
dwatch(1): Fix syntax error in vop_readdir profile
Aug 11 2018, 6:13 AM

Aug 10 2018

dteske added a reviewer for D16157: Update dpv(1) to support compilation on Linux and Mac OS X: adrian.
Aug 10 2018, 8:45 PM
dteske added a reviewer for D16157: Update dpv(1) to support compilation on Linux and Mac OS X: emaste.
Aug 10 2018, 8:45 PM
dteske added a comment to D16153: Update dpv(3) to support compilation on Linux and Mac OS X.

Ping. Is the GNUmakefiles that are an issue? I gues I can host those in my forked OS, but I sincerely believe the other changes are good because it allows people to take the source code from FreeBSD and compile it without modification (assuming they have something like the included GNUmakefiles)

Aug 10 2018, 8:44 PM
dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

Ping. Reasons for having this in base are similar to basic reasoning for jot, seq, and other argument processing/generating utilities. cmb fills a gap in UNIX that should have been filled decades ago but nobody gave the effort (I suspect because it is a very difficult problem to solve; and given the complexity required, I can absolutely see why nobody has ever BSD-licensed such a tool).

Aug 10 2018, 8:42 PM
dteske committed rS337589: Fix misspellings of transmitter/transmitted.
Fix misspellings of transmitter/transmitted
Aug 10 2018, 8:37 PM
dteske closed D16025: Fix misspellings of transmit, transmitter, and transmitted.
Aug 10 2018, 8:37 PM
dteske committed rS337588: MFC SVN r336350: Send sysrc(8) error message to stderr (not stdout).
MFC SVN r336350: Send sysrc(8) error message to stderr (not stdout)
Aug 10 2018, 8:08 PM

Jul 23 2018

dteske added inline comments to D15879: sysutils/DTraceToolkit: remove missing providers in FreeBSD 12.0-CURRRENT.
Jul 23 2018, 12:33 AM

Jul 21 2018

dteske added a comment to D16377: Add dtrace network provider for UDP-Lite.

Can you expand your patch to include the creation of a corresponding dwatch module? It's easy ...

cd cddl/usr.sbin/dwatch/libexec
sed -e 's/udp/&lite/g;s/length/coverage/g' udp > udplite
echo "$( awk '(line=$1)||1;NF==2&&sub(/udp/,"&lite");/^LINKS/&&gsub(/udp/,"&lite"){_[n++]=$0}/udplite-send/{for(x=0;x<n;)print _[x++]}' Makefile )" > Makefile

Not that easy:

tuexen@head:~/head/cddl/usr.sbin/dwatch/libexec % echo "$( awk '(line=$1)||1;NF==2&&sub(/udp/,"&lite");/^LINKS/&&gsub(/udp/,"&lite"){_[n++]=$0}/udplite-send/{for(x=0;x<n;)print _[x++]}' Makefile )" > Makefile
Illegal variable name.
Jul 21 2018, 6:01 AM
dteske added a comment to D16377: Add dtrace network provider for UDP-Lite.

Can you expand your patch to include the creation of a corresponding dwatch module? It's easy ...

Jul 21 2018, 4:43 AM

Jul 20 2018

dteske added a comment to D16046: Add UDP receive probes.

Worth mentioning, I tested on stable/11 (for MFC consideration).

Jul 20 2018, 3:56 AM
dteske accepted D16046: Add UDP receive probes.

Testing was successful. Everything worked as expected. Cheers.

Jul 20 2018, 3:40 AM

Jul 19 2018

dteske added a comment to D16046: Add UDP receive probes.

Aside from testing with what comes with FreeBSD base, I also wanted to make sure that this change would be handled well by my DTrace network visualizer (sysutils/dwatch-gource in ports).

Jul 19 2018, 7:11 PM
dteske added inline comments to D16046: Add UDP receive probes.
Jul 19 2018, 7:02 PM
dteske added a comment to D16046: Add UDP receive probes.

I have used both your attached udpio.d (taken from dtrace_udp(4) in the EXAMPLES section) as well as:

Jul 19 2018, 6:52 PM
dteske closed D15875: [New Port] sysutils/mping.

Removed bapt and closed (was already committed but not closed because phab bugette)

Jul 19 2018, 6:26 PM
dteske removed a reviewer for D15875: [New Port] sysutils/mping: bapt.
Jul 19 2018, 6:25 PM
dteske added a comment to D16046: Add UDP receive probes.

@dteske Did you had a chance to test it?

Jul 19 2018, 4:12 PM

Jul 16 2018

dteske added a comment to D16046: Add UDP receive probes.

If it's OK, I'd like to run some tests with dwatch to make sure that I don't need to patch my code for any change in functionality. I don't suspect this to be the case, but just want to make sure. If you're fine to wait another day or two for my testing, I'll definitely stamp approval

Jul 16 2018, 11:36 PM
dteske committed rS336350: sysrc(8): Send error message to stderr (not stdout).
sysrc(8): Send error message to stderr (not stdout)
Jul 16 2018, 6:53 PM
dteske added inline comments to D16046: Add UDP receive probes.
Jul 16 2018, 6:43 PM

Jul 7 2018

dteske updated the diff for D16025: Fix misspellings of transmit, transmitter, and transmitted.

Update diff to just the low-hanging (non-vendor) changes

Jul 7 2018, 9:57 PM
dteske added a comment to D16025: Fix misspellings of transmit, transmitter, and transmitted.

I would like an opinion on which ones should be fixed and which should perhaps be left alone.

I'd like every one of them to ultimately be fixed. Fix the low-hanging ones first. Submit patches to the vendors of the code we're using, make sure that they apply it.

API ones are the hardest. Those that are private or internal to FreeBSD should be fixed I think. For public ones that could be used by the rest of the world we should probably follow our usual deprecation routine.

Jul 7 2018, 9:38 PM

Jul 6 2018

dteske committed rD51974: Generate a new (not expired) key.
Generate a new (not expired) key
Jul 6 2018, 9:30 PM
dteske created D16157: Update dpv(1) to support compilation on Linux and Mac OS X.
Jul 6 2018, 5:25 AM
dteske created D16156: Update figpar(3) to support compilation on Linux and Mac OS X.
Jul 6 2018, 4:51 AM

Jul 5 2018

dteske commandeered D15875: [New Port] sysutils/mping.
Jul 5 2018, 10:17 PM
dteske created D16153: Update dpv(3) to support compilation on Linux and Mac OS X.
Jul 5 2018, 9:53 PM
dteske removed a reviewer for D16132: New cmb(3) library and cmb(1) utility: eadler.
Jul 5 2018, 3:35 AM
dteske created D16132: New cmb(3) library and cmb(1) utility.
Jul 5 2018, 3:14 AM

Jul 4 2018

dteske added a comment to D15875: [New Port] sysutils/mping.

I think this is a bug in phabricator. The review was in "closed" state and committed. Then a comment caused it to go back into "Needs Review". The person that added the comment (antoine) even came back and accepted and it still shows as "Needs Review". Can't close this ticket until it is in approved. I'd rather not use the sledgehammer of removing all the reviewers.

Jul 4 2018, 6:31 AM
dteske added a comment to D15875: [New Port] sysutils/mping.

@antoine can you accept so I can close?

Jul 4 2018, 3:33 AM
dteske resigned from D15875: [New Port] sysutils/mping.
Jul 4 2018, 3:31 AM
dteske accepted D15875: [New Port] sysutils/mping.
Jul 4 2018, 3:29 AM
dteske committed rS335927: MFC SVN r335750: Fix typo in top-level Makefile.
MFC SVN r335750: Fix typo in top-level Makefile
Jul 4 2018, 3:24 AM
dteske committed rS335926: MFC SVN r335750: Fix typo in top-level Makefile.
MFC SVN r335750: Fix typo in top-level Makefile
Jul 4 2018, 3:23 AM

Jul 3 2018

dteske committed rS335914: MFC SVN r290340: Fix typo in error message.
MFC SVN r290340: Fix typo in error message
Jul 3 2018, 10:11 PM
dteske closed D3997: [patch] Fixed a typo in distfetch.c.
Jul 3 2018, 10:11 PM
dteske committed rP473855: sysutils/mping: Update to 0.1.4 and add PKGNAMESUFFIX.
sysutils/mping: Update to 0.1.4 and add PKGNAMESUFFIX
Jul 3 2018, 9:47 PM
dteske closed D16106: Update mping to 0.1.4 and add PKGNAMESUFFIX.
Jul 3 2018, 9:47 PM
dteske added a comment to D15875: [New Port] sysutils/mping.

It could be PKGNAMESUFFIX= -shell or PKGNAMESUFFIX= -fraubsd

Jul 3 2018, 2:07 AM
dteske created D16106: Update mping to 0.1.4 and add PKGNAMESUFFIX.
Jul 3 2018, 2:07 AM

Jun 29 2018

dteske added a comment to D15875: [New Port] sysutils/mping.

Been thinking about this for the past day. I can't think of any suitable value for either prefix or suffix. I'm open to suggestions -- perhaps you've delt with this in the past and have a suggestion for suitable value when this occurs.

Jun 29 2018, 10:19 PM

Jun 28 2018

dteske committed rS335758: Add mergeinfo for MFC r335607.
Add mergeinfo for MFC r335607
Jun 28 2018, 7:02 AM

Jun 27 2018

dteske committed rS335750: Fix typo in top-level Makefile.
Fix typo in top-level Makefile
Jun 27 2018, 10:16 PM
dteske committed rS335744: MFC r335607: check-password.4th(8): Fix manual [in]accuracy.
MFC r335607: check-password.4th(8): Fix manual [in]accuracy
Jun 27 2018, 9:22 PM
dteske committed rS335735: MFC r335607: check-password.4th(8): Fix manual [in]accuracy.
MFC r335607: check-password.4th(8): Fix manual [in]accuracy
Jun 27 2018, 8:50 PM
dteske added a comment to D15875: [New Port] sysutils/mping.
In D15875#339613, @imp wrote:

I wouldn't worry about it...

Jun 27 2018, 6:39 PM
dteske committed rP473453: [New Port] sysutils/mping.
[New Port] sysutils/mping
Jun 27 2018, 6:35 PM
dteske closed D15875: [New Port] sysutils/mping.
Jun 27 2018, 6:35 PM

Jun 26 2018

dteske added inline comments to D16025: Fix misspellings of transmit, transmitter, and transmitted.
Jun 26 2018, 11:02 PM
dteske added a comment to D16025: Fix misspellings of transmit, transmitter, and transmitted.

Hrm. Phabricator seems to think there's no context for your diff here. What's that all about?

Jun 26 2018, 11:00 PM
dteske created D16025: Fix misspellings of transmit, transmitter, and transmitted.
Jun 26 2018, 7:10 PM

Jun 24 2018

dteske committed rS335607: check-password.4th(8): Fix manual [in]accuracy.
check-password.4th(8): Fix manual [in]accuracy
Jun 24 2018, 7:29 PM

Jun 23 2018

dteske planned changes to D15984: bsdconfig: Change DNS name for HTTP main dist.

Turns out they only look similar. download forwards to HTTPS and http://ftp.freebsd.org/ also has a different structure to access the data. For example, on download, the releases are in /ftp/releases/ while on http://ftp.freebsd.org/ the releases are in /pub/FreeBSD/releases/

Jun 23 2018, 11:47 PM
dteske created D15984: bsdconfig: Change DNS name for HTTP main dist.
Jun 23 2018, 11:38 PM
dteske added a comment to D15875: [New Port] sysutils/mping.

To prevent the "This revision was not accepted when it landed; it landed in state Needs Review." moniker being attached to this review, can you re-approve?

Jun 23 2018, 9:23 PM

Jun 21 2018

dteske committed rS335488: MFC r335306: bsdconfig: Make examples optional.
MFC r335306: bsdconfig: Make examples optional
Jun 21 2018, 3:11 PM
dteske committed rS335487: MFC r335308: bsdconfig: Fix a bug when editing users.
MFC r335308: bsdconfig: Fix a bug when editing users
Jun 21 2018, 3:02 PM
dteske committed rS335485: MFC r335308: bsdconfig: Fix a bug when editing users.
MFC r335308: bsdconfig: Fix a bug when editing users
Jun 21 2018, 2:55 PM
dteske committed rS335484: MFC r335280-r335281, r335302: sysrc.subr updates.
MFC r335280-r335281, r335302: sysrc.subr updates
Jun 21 2018, 2:42 PM
dteske committed rS335480: MFC r330886: Install files added in SVN's r295373, r295457, r295542.
MFC r330886: Install files added in SVN's r295373, r295457, r295542
Jun 21 2018, 2:21 PM

Jun 20 2018

dteske committed rP472940: sysutils/ssd_report: Remove unnecessary FLAVOR declaration.
sysutils/ssd_report: Remove unnecessary FLAVOR declaration
Jun 20 2018, 10:29 PM
dteske closed D15934: Remove unnecessary FLAVOR declaration.
Jun 20 2018, 10:29 PM
dteske created D15934: Remove unnecessary FLAVOR declaration.
Jun 20 2018, 7:17 PM
dteske updated the diff for D15875: [New Port] sysutils/mping.

Add sysutils/Makefile modification

Jun 20 2018, 6:46 PM
dteske committed rP472896: [New Port] sysutils/ssd_report.
[New Port] sysutils/ssd_report
Jun 20 2018, 6:32 PM
dteske closed D15876: [New Port] sysutils/ssd_report.
Jun 20 2018, 6:32 PM
dteske added a comment to D15876: [New Port] sysutils/ssd_report.

Blocked by pre-commit hook:

Jun 20 2018, 6:08 PM
dteske added 1 blocking reviewer(s) for D15876: [New Port] sysutils/ssd_report: portmgr.
Jun 20 2018, 6:07 PM
dteske added a reviewer for D15876: [New Port] sysutils/ssd_report: portmgr.
Jun 20 2018, 6:07 PM
dteske updated the diff for D15876: [New Port] sysutils/ssd_report.

Add sysutils/Makefile modification

Jun 20 2018, 6:06 PM
dteske committed rS335409: MFC r334303: sysrc(8): Test variable names for invalid characters.
MFC r334303: sysrc(8): Test variable names for invalid characters
Jun 20 2018, 6:24 AM
dteske committed rS335408: MFC r330878-r330879, r330939, r330948: Man-page updates.
MFC r330878-r330879, r330939, r330948: Man-page updates
Jun 20 2018, 6:12 AM
dteske committed rS335407: dpv(3): MFC r330943, r335264.
dpv(3): MFC r330943, r335264
Jun 20 2018, 5:51 AM