dteske (Devin Teske)
Resources

Projects

User Details

User Since
Sep 2 2014, 7:30 PM (202 w, 4 d)

Recent Activity

Today

dteske added a comment to D16377: Add dtrace network provider for UDP-Lite.

Can you expand your patch to include the creation of a corresponding dwatch module? It's easy ...

cd cddl/usr.sbin/dwatch/libexec
sed -e 's/udp/&lite/g;s/length/coverage/g' udp > udplite
echo "$( awk '(line=$1)||1;NF==2&&sub(/udp/,"&lite");/^LINKS/&&gsub(/udp/,"&lite"){_[n++]=$0}/udplite-send/{for(x=0;x<n;)print _[x++]}' Makefile )" > Makefile

Not that easy:

tuexen@head:~/head/cddl/usr.sbin/dwatch/libexec % echo "$( awk '(line=$1)||1;NF==2&&sub(/udp/,"&lite");/^LINKS/&&gsub(/udp/,"&lite"){_[n++]=$0}/udplite-send/{for(x=0;x<n;)print _[x++]}' Makefile )" > Makefile
Illegal variable name.
Sat, Jul 21, 6:01 AM
dteske added a comment to D16377: Add dtrace network provider for UDP-Lite.

Can you expand your patch to include the creation of a corresponding dwatch module? It's easy ...

Sat, Jul 21, 4:43 AM

Yesterday

dteske added a comment to D16046: Add UDP receive probes.

Worth mentioning, I tested on stable/11 (for MFC consideration).

Fri, Jul 20, 3:56 AM
dteske accepted D16046: Add UDP receive probes.

Testing was successful. Everything worked as expected. Cheers.

Fri, Jul 20, 3:40 AM

Thu, Jul 19

dteske added a comment to D16046: Add UDP receive probes.

Aside from testing with what comes with FreeBSD base, I also wanted to make sure that this change would be handled well by my DTrace network visualizer (sysutils/dwatch-gource in ports).

Thu, Jul 19, 7:11 PM
dteske added inline comments to D16046: Add UDP receive probes.
Thu, Jul 19, 7:02 PM
dteske added a comment to D16046: Add UDP receive probes.

I have used both your attached udpio.d (taken from dtrace_udp(4) in the EXAMPLES section) as well as "dwatch -X udp" in the base system to confirm the pre-patch state. A probe fires when nc (in the given test case of "nc -u 127.0.0.1 1234") sends the datagram but no probe fires for the receive.

Thu, Jul 19, 6:52 PM
dteske closed D15875: [New Port] sysutils/mping.

Removed bapt and closed (was already committed but not closed because phab bugette)

Thu, Jul 19, 6:26 PM
dteske removed a reviewer for D15875: [New Port] sysutils/mping: bapt.
Thu, Jul 19, 6:25 PM
dteske added a comment to D16046: Add UDP receive probes.

@dteske Did you had a chance to test it?

Thu, Jul 19, 4:12 PM

Mon, Jul 16

dteske added a comment to D16046: Add UDP receive probes.

If it's OK, I'd like to run some tests with dwatch to make sure that I don't need to patch my code for any change in functionality. I don't suspect this to be the case, but just want to make sure. If you're fine to wait another day or two for my testing, I'll definitely stamp approval

Mon, Jul 16, 11:36 PM
dteske committed rS336350: sysrc(8): Send error message to stderr (not stdout).
sysrc(8): Send error message to stderr (not stdout)
Mon, Jul 16, 6:53 PM
dteske added inline comments to D16046: Add UDP receive probes.
Mon, Jul 16, 6:43 PM

Sat, Jul 7

dteske updated the diff for D16025: Fix misspellings of transmit, transmitter, and transmitted.

Update diff to just the low-hanging (non-vendor) changes

Sat, Jul 7, 9:57 PM
dteske added a comment to D16025: Fix misspellings of transmit, transmitter, and transmitted.

I would like an opinion on which ones should be fixed and which should perhaps be left alone.

I'd like every one of them to ultimately be fixed. Fix the low-hanging ones first. Submit patches to the vendors of the code we're using, make sure that they apply it.

API ones are the hardest. Those that are private or internal to FreeBSD should be fixed I think. For public ones that could be used by the rest of the world we should probably follow our usual deprecation routine.

Sat, Jul 7, 9:38 PM

Fri, Jul 6

dteske committed rD51974: Generate a new (not expired) key.
Generate a new (not expired) key
Fri, Jul 6, 9:30 PM
dteske created D16157: Update dpv(1) to support compilation on Linux and Mac OS X.
Fri, Jul 6, 5:25 AM
dteske created D16156: Update figpar(3) to support compilation on Linux and Mac OS X.
Fri, Jul 6, 4:51 AM

Thu, Jul 5

dteske commandeered D15875: [New Port] sysutils/mping.
Thu, Jul 5, 10:17 PM
dteske created D16153: Update dpv(3) to support compilation on Linux and Mac OS X.
Thu, Jul 5, 9:53 PM
dteske removed a reviewer for D16132: New cmb(3) library and cmb(1) utility: eadler.
Thu, Jul 5, 3:35 AM
dteske created D16132: New cmb(3) library and cmb(1) utility.
Thu, Jul 5, 3:14 AM

Wed, Jul 4

dteske added a comment to D15875: [New Port] sysutils/mping.

I think this is a bug in phabricator. The review was in "closed" state and committed. Then a comment caused it to go back into "Needs Review". The person that added the comment (antoine) even came back and accepted and it still shows as "Needs Review". Can't close this ticket until it is in approved. I'd rather not use the sledgehammer of removing all the reviewers.

Wed, Jul 4, 6:31 AM
dteske added a comment to D15875: [New Port] sysutils/mping.

@antoine can you accept so I can close?

Wed, Jul 4, 3:33 AM
dteske resigned from D15875: [New Port] sysutils/mping.
Wed, Jul 4, 3:31 AM
dteske accepted D15875: [New Port] sysutils/mping.
Wed, Jul 4, 3:29 AM
dteske committed rS335927: MFC SVN r335750: Fix typo in top-level Makefile.
MFC SVN r335750: Fix typo in top-level Makefile
Wed, Jul 4, 3:24 AM
dteske committed rS335926: MFC SVN r335750: Fix typo in top-level Makefile.
MFC SVN r335750: Fix typo in top-level Makefile
Wed, Jul 4, 3:23 AM

Tue, Jul 3

dteske committed rS335914: MFC SVN r290340: Fix typo in error message.
MFC SVN r290340: Fix typo in error message
Tue, Jul 3, 10:11 PM
dteske closed D3997: [patch] Fixed a typo in distfetch.c.
Tue, Jul 3, 10:11 PM
dteske committed rP473855: sysutils/mping: Update to 0.1.4 and add PKGNAMESUFFIX.
sysutils/mping: Update to 0.1.4 and add PKGNAMESUFFIX
Tue, Jul 3, 9:47 PM
dteske closed D16106: Update mping to 0.1.4 and add PKGNAMESUFFIX.
Tue, Jul 3, 9:47 PM
dteske added a comment to D15875: [New Port] sysutils/mping.

It could be PKGNAMESUFFIX= -shell or PKGNAMESUFFIX= -fraubsd

Tue, Jul 3, 2:07 AM
dteske created D16106: Update mping to 0.1.4 and add PKGNAMESUFFIX.
Tue, Jul 3, 2:07 AM

Fri, Jun 29

dteske added a comment to D15875: [New Port] sysutils/mping.

Been thinking about this for the past day. I can't think of any suitable value for either prefix or suffix. I'm open to suggestions -- perhaps you've delt with this in the past and have a suggestion for suitable value when this occurs.

Fri, Jun 29, 10:19 PM

Thu, Jun 28

dteske committed rS335758: Add mergeinfo for MFC r335607.
Add mergeinfo for MFC r335607
Thu, Jun 28, 7:02 AM

Wed, Jun 27

dteske committed rS335750: Fix typo in top-level Makefile.
Fix typo in top-level Makefile
Wed, Jun 27, 10:16 PM
dteske committed rS335744: MFC r335607: check-password.4th(8): Fix manual [in]accuracy.
MFC r335607: check-password.4th(8): Fix manual [in]accuracy
Wed, Jun 27, 9:22 PM
dteske committed rS335735: MFC r335607: check-password.4th(8): Fix manual [in]accuracy.
MFC r335607: check-password.4th(8): Fix manual [in]accuracy
Wed, Jun 27, 8:50 PM
dteske added a comment to D15875: [New Port] sysutils/mping.
In D15875#339613, @imp wrote:

I wouldn't worry about it...

Wed, Jun 27, 6:39 PM
dteske committed rP473453: [New Port] sysutils/mping.
[New Port] sysutils/mping
Wed, Jun 27, 6:35 PM
dteske closed D15875: [New Port] sysutils/mping.
Wed, Jun 27, 6:35 PM

Tue, Jun 26

dteske added inline comments to D16025: Fix misspellings of transmit, transmitter, and transmitted.
Tue, Jun 26, 11:02 PM
dteske added a comment to D16025: Fix misspellings of transmit, transmitter, and transmitted.

Hrm. Phabricator seems to think there's no context for your diff here. What's that all about?

Tue, Jun 26, 11:00 PM
dteske created D16025: Fix misspellings of transmit, transmitter, and transmitted.
Tue, Jun 26, 7:10 PM

Sun, Jun 24

dteske committed rS335607: check-password.4th(8): Fix manual [in]accuracy.
check-password.4th(8): Fix manual [in]accuracy
Sun, Jun 24, 7:29 PM

Sat, Jun 23

dteske planned changes to D15984: bsdconfig: Change DNS name for HTTP main dist.

Turns out they only look similar. download forwards to HTTPS and http://ftp.freebsd.org/ also has a different structure to access the data. For example, on download, the releases are in /ftp/releases/ while on http://ftp.freebsd.org/ the releases are in /pub/FreeBSD/releases/

Sat, Jun 23, 11:47 PM
dteske created D15984: bsdconfig: Change DNS name for HTTP main dist.
Sat, Jun 23, 11:38 PM
dteske added a comment to D15875: [New Port] sysutils/mping.

To prevent the "This revision was not accepted when it landed; it landed in state Needs Review." moniker being attached to thsi review, can you re-approve?

Sat, Jun 23, 9:23 PM

Jun 21 2018

dteske committed rS335488: MFC r335306: bsdconfig: Make examples optional.
MFC r335306: bsdconfig: Make examples optional
Jun 21 2018, 3:11 PM
dteske committed rS335487: MFC r335308: bsdconfig: Fix a bug when editing users.
MFC r335308: bsdconfig: Fix a bug when editing users
Jun 21 2018, 3:02 PM
dteske committed rS335485: MFC r335308: bsdconfig: Fix a bug when editing users.
MFC r335308: bsdconfig: Fix a bug when editing users
Jun 21 2018, 2:55 PM
dteske committed rS335484: MFC r335280-r335281, r335302: sysrc.subr updates.
MFC r335280-r335281, r335302: sysrc.subr updates
Jun 21 2018, 2:42 PM
dteske committed rS335480: MFC r330886: Install files added in SVN's r295373, r295457, r295542.
MFC r330886: Install files added in SVN's r295373, r295457, r295542
Jun 21 2018, 2:21 PM

Jun 20 2018

dteske committed rP472940: sysutils/ssd_report: Remove unnecessary FLAVOR declaration.
sysutils/ssd_report: Remove unnecessary FLAVOR declaration
Jun 20 2018, 10:29 PM
dteske closed D15934: Remove unnecessary FLAVOR declaration.
Jun 20 2018, 10:29 PM
dteske created D15934: Remove unnecessary FLAVOR declaration.
Jun 20 2018, 7:17 PM
dteske updated the diff for D15875: [New Port] sysutils/mping.

Add sysutils/Makefile modification

Jun 20 2018, 6:46 PM
dteske committed rP472896: [New Port] sysutils/ssd_report.
[New Port] sysutils/ssd_report
Jun 20 2018, 6:32 PM
dteske closed D15876: [New Port] sysutils/ssd_report.
Jun 20 2018, 6:32 PM
dteske added a comment to D15876: [New Port] sysutils/ssd_report.

Blocked by pre-commit hook:

Jun 20 2018, 6:08 PM
dteske added 1 blocking reviewer(s) for D15876: [New Port] sysutils/ssd_report: portmgr.
Jun 20 2018, 6:07 PM
dteske added a reviewer for D15876: [New Port] sysutils/ssd_report: portmgr.
Jun 20 2018, 6:07 PM
dteske updated the diff for D15876: [New Port] sysutils/ssd_report.

Add sysutils/Makefile modification

Jun 20 2018, 6:06 PM
dteske committed rS335409: MFC r334303: sysrc(8): Test variable names for invalid characters.
MFC r334303: sysrc(8): Test variable names for invalid characters
Jun 20 2018, 6:24 AM
dteske committed rS335408: MFC r330878-r330879, r330939, r330948: Man-page updates.
MFC r330878-r330879, r330939, r330948: Man-page updates
Jun 20 2018, 6:12 AM
dteske committed rS335407: dpv(3): MFC r330943, r335264.
dpv(3): MFC r330943, r335264
Jun 20 2018, 5:51 AM
dteske committed rS335406: dpv(3): MFC r330943, r335264.
dpv(3): MFC r330943, r335264
Jun 20 2018, 5:45 AM
dteske committed rS335405: MFC r335277:.
MFC r335277:
Jun 20 2018, 5:10 AM
dteske updated the diff for D15876: [New Port] sysutils/ssd_report.

Embiggen pkg-descr ^_^

Jun 20 2018, 4:53 AM
dteske updated the diff for D15875: [New Port] sysutils/mping.

Trim pkg-descr for relevancy

Jun 20 2018, 3:32 AM

Jun 18 2018

dteske added inline comments to D15875: [New Port] sysutils/mping.
Jun 18 2018, 10:16 PM
dteske updated the diff for D15876: [New Port] sysutils/ssd_report.

Address feedback from mat

Jun 18 2018, 9:34 PM
dteske updated the diff for D15875: [New Port] sysutils/mping.

Make pkg-descr more descriptive

Jun 18 2018, 9:24 PM
dteske added a comment to D15879: sysutils/DTraceToolkit: remove missing providers in FreeBSD 12.0-CURRRENT.
In D15879#336047, @dch wrote:

Options to move forward:

  • use 1200000 as the bracket and accept we're also excluding a period where this did work
  • use 1200031 and probably get pretty close but not be certain
  • hope Mark or Devin shares some insight on where/how providers are created for syscalls[1]
  • rebuild 12.0+ports at that point last year and bisect furiously

FWIW I also found that syscall::*lstat*:return works everywhere, so that is probably
the easiest option, but I'd still like to understand how dtrace providers are generated
for syscalls.

Jun 18 2018, 9:02 PM
dteske accepted D15855: Fix dtrace output of IP addresses as strings.

Thanks for the explanation, cheers!

Jun 18 2018, 7:08 AM
dteske updated the diff for D15875: [New Port] sysutils/mping.

Address feedback by bapt

Jun 18 2018, 6:55 AM
dteske updated the diff for D15876: [New Port] sysutils/ssd_report.

Add support for smart utility by Chuck Tuffli

Jun 18 2018, 6:37 AM
dteske created D15876: [New Port] sysutils/ssd_report.
Jun 18 2018, 1:18 AM

Jun 17 2018

dteske created D15875: [New Port] sysutils/mping.
Jun 17 2018, 11:32 PM
dteske committed rS335308: bsdconfig: Fix a bug when editing users.
bsdconfig: Fix a bug when editing users
Jun 17 2018, 10:09 PM
dteske committed rS335306: bsdconfig: Make examples optional.
bsdconfig: Make examples optional
Jun 17 2018, 9:09 PM
dteske committed rS335302: sysrc.subr: Fix a comment for accuracy.
sysrc.subr: Fix a comment for accuracy
Jun 17 2018, 8:33 PM
dteske committed rS335281: sysrc.subr: Fix display when value is "-n".
sysrc.subr: Fix display when value is "-n"
Jun 17 2018, 6:25 AM
dteske committed rS335280: sysrc.subr: Fix handling of files with missing newline at EOF.
sysrc.subr: Fix handling of files with missing newline at EOF
Jun 17 2018, 6:04 AM
dteske committed rS335277: sysrc(8): Exit with failure on API error.
sysrc(8): Exit with failure on API error
Jun 17 2018, 3:33 AM

Jun 16 2018

dteske requested changes to D15855: Fix dtrace output of IP addresses as strings.

I don't agree with this change in its current iteration as it will break scripts which expect *addr to be translated to a NULL pointer should the pointer indeed be NULL. Changing the default value from a NULL pointer to an adhoc string (specifically in the context of changing it in the translator) puts the onus on script writers to test for the explicit string constant instead of NULL. This may be fine if the translator were not already established, but these are already well into their years.

Jun 16 2018, 8:57 PM
dteske committed rS335264: Fix comparison between pointer and char literal.
Fix comparison between pointer and char literal
Jun 16 2018, 8:01 PM

Jun 7 2018

dteske committed rS334780: MFC r334594: dwatch(1): Update manual to reference actual release.
MFC r334594: dwatch(1): Update manual to reference actual release
Jun 7 2018, 1:08 PM

Jun 3 2018

dteske committed rS334594: dwatch(1): Update manual to reference actual release.
dwatch(1): Update manual to reference actual release
Jun 3 2018, 11:49 PM

Jun 1 2018

dteske committed rP471295: sysutils/dwatch-*: IGNORE if missing FreeBSD dwatch(1).
sysutils/dwatch-*: IGNORE if missing FreeBSD dwatch(1)
Jun 1 2018, 9:25 PM
dteske closed D15621: sysutils/dwatch-*: IGNORE if missing FreeBSD dwatch(1).
Jun 1 2018, 9:25 PM

May 31 2018

dteske added a comment to D15621: sysutils/dwatch-*: IGNORE if missing FreeBSD dwatch(1).

Also note: I removed check of OPSYS because it looks like it can be "DragonFly" which in my mind would have an OSVERSION that tracks with FreeBSD's. Willing to put back OPSYS check, thoughts?

May 31 2018, 5:50 PM
dteske updated the diff for D15621: sysutils/dwatch-*: IGNORE if missing FreeBSD dwatch(1).

Refactor IGNORE

May 31 2018, 5:46 PM

May 30 2018

dteske created D15621: sysutils/dwatch-*: IGNORE if missing FreeBSD dwatch(1).
May 30 2018, 6:39 PM
dteske committed rS334392: MFC SVN r334261-334262,334359: dwatch(1) touch-ups.
MFC SVN r334261-334262,334359: dwatch(1) touch-ups
May 30 2018, 6:27 PM
dteske closed D15612: sysutils/dwatch-gource: Update to 0.9.
May 30 2018, 5:49 PM
dteske committed rP471140: sysutils/dwatch-gource: Update to 0.9.
sysutils/dwatch-gource: Update to 0.9
May 30 2018, 5:49 PM

May 29 2018

dteske committed rS334359: dwatch(1): Fix "-t test" for post-processing profiles.
dwatch(1): Fix "-t test" for post-processing profiles
May 29 2018, 10:36 PM
dteske created D15612: sysutils/dwatch-gource: Update to 0.9.
May 29 2018, 10:21 PM