Page MenuHomeFreeBSD

dteske (Devin Teske)
src and ports committer

Projects

User Details

User Since
Sep 2 2014, 7:30 PM (401 w, 5 d)

Creator/Maintainer of FreeBSD bootloader-menu/bsdconfig/dpv/dwatch/figpar/sysrc
Maintainer of FreeBSD base/bsdinstall/DTrace/forth/jail/netgraph/ports/vnet
Maintainer of FreeBSD ports: (net-p2p) shx (sysutils) bsdconfig cmocka DTraceToolkit dwatch-gource dwatch-pwsnoop host-setup mping ssd_report sysrc tzdialog zfs-stats-lite
Drive-by's: (devel) p4d p4web (emulators) xen xen-kernel (net) pptpclient (ports-mgmt) pkg (sysutils) getssl syslinux vzvol

Recent Activity

Mon, Apr 18

dteske added a comment to D34755: bsdconfig(8): Add bsddialog(1) support.

This looks pretty well thought out. Give me some time to review it and get back to you. Thank you for your efforts.

Mon, Apr 18, 8:06 PM

Oct 9 2021

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

Looks good to me.

I'm playing with this utility on my stable/13 and I like the idea very much. It feels unixy to me in that the tool is abstract enough for me to apply it to various problems which may be difficult to define beforehand. But I can already see myself using this instead of generating permutations with recursive CTEs in SQL like I sometimes do.

Also, although I'm not sure anyone will find this meaningful, cmb reminds me of a problem I was solving recently at job, feeding a Cassandra table random data:

The table and its keyspace were defined as follows:
CREATE KEYSPACE test WITH REPLICATION = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 };
CREATE TABLE test.base(part text, ord text, fill text, PRIMARY KEY((part), ord));

We feed the table like this:
# base32 -w 2000 < /dev/urandom | cut -b1-3,4-8,9- --output-delimiter=, | cqlsh -u $CASS_USER -e 'COPY test.base FROM STDIN'

Cutting base32 output into columns of arbitrary length gives us control over cardinality of each column; specifically we want to know the upper bound on the number of partitions and the number of rows in each partition. Given a set of k (32 in base32) characters, the number of n-tuples (n characters in a column) is k^n. For example, taking the first 3 letters of each line to use in the partitioning column gives us the upper bound of 32^3 partitions, which is 32768.

Forgive the verbosity and being Ubuntu-specific (base32, cut --output-delimiter, /dev/urandom), but I hope you get the idea: I tend to use unix tools when interacting with other tools or services, databases especially.

By the way, the util and the library seem small enough:

-r-xr-xr-x  1 root  wheel    46K Aug  5 14:17 /usr/bin/indent
-r--r--r--  1 root  wheel    21K Aug 15 17:49 /usr/lib/libcmb.so.0
-r-xr-xr-x  1 root  wheel    31K Aug 15 17:50 /usr/bin/cmb
Oct 9 2021, 12:15 AM
dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.
In D16132#626980, @gbe wrote:

LGTM for the man page related things.

Oct 9 2021, 12:13 AM
dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

Hi markj,

Yes, it was suggested that I make a port first.

However, everybody seems to be ignoring what I am saying regarding the utility of this tool being equitable to seq, jot, and friends.

Just yesterday, I did the following:

cmb -d / {a..z} | xargs stat 2>&1 | dpv -l -

The purpose was to generate millions of stat errors so that I could work on some filesystem patches to improve the performance of stat in nfsd.

Could I have used jot? Maybe, but it would have been more difficult.
Could I have used seq? Maybe, but same problems as jot. I needed discretely unique test matter.

I have been ignoring the suggestion to put it into ports because not one single person has even addressed the use-cases for base.

How would one make an argument for jot or seq being in base? If you pretend that they are not in base, what arguments would you use to introduce them?

cmb is kind of like that -- it has a million uses. Asking why we should have it in base is kind of like asking why we should have bc in base.

cmb is a math tool. A very powerful tool that fills a myriad requirements, not to mention the following use-case which I will once-again reiterate that has once again been ignored ...

I don't care about the build option survey. It was an example.

I care about using this for combinatoric combination of ports given various options.

Let's talk about dialog4ports -- a tool that lives in ports that is required by ports. So many times this has caused me headaches and I really don't want to go down that road. It is very frustrating when you get into a situation where ports needs X from ports but you can't compile it because your base and ports frameworks have diverged so you then have to devolve into first updating your base shared Mk files relied-on by ports. It's real shit-show.

Putting cmb in base will allow it to:
a. solve math problems
b. allow me to work on base enhancements with only base (think Filesystem debugging, filesystem optimizations, memory testing, scheduler profiling, etc.)
c. be usable by ports without being stuck in the quagmire-catch-22 described above

Regarding the prior discussion, I just see that the original thread on -announce appears to end with you saying that you would make a port. That didn't happen, and since there was some objection to putting cmb and libcmb straight into the base system, we should make sure that those objections won't be raised again after a commit. The right way to do that is to follow up on the lists, like -hackers and -arch, since only a small handful of developers are subscribed to this review.

I understand that cmb is intended to be a general-purpose utility, but that alone is not sufficient for putting it in the base system. jot(1) and seq(1) make for an interesting comparison since seq's functionality is a subset of jot's; seq was added to the base system relatively recently, specifically to make us more compatible with other unix environments. jot predates FreeBSD and comes from a time where a batteries-included approach to shipping an OS was more important than it is today.

I personally think that cmb would be an interesting addition to the base system, but there should be some concrete justification for it to be there. The build option survey is not really a compelling example. A ports target that builds a port with all possible combinations of options seems useful, but is there currently some work in progress to implement that? I understand that having the ports framework depend on a port is painful, but unless the absence of cmb from the base system is currently blocking a useful project, I don't see why this is a strong argument for not making a cmb port. You've written a number of large sh-based components of the base system - could any of them make use of cmb? My point is just that I believe that you could successfully argue for cmb's inclusion in the base system, but the idea first needs to be socialized more fully. A port is a reasonable alternative in the meantime and will make it easy for others to try using cmb.

Oct 9 2021, 12:13 AM

Oct 8 2021

dteske committed R10:1c64959bff17: bsdconfig: Comments (authored by dteske).
bsdconfig: Comments
Oct 8 2021, 11:32 PM

Sep 22 2021

dteske accepted D25711: freebsd-update(8): Add -j flag to support jails.

Just a simple bogon in the src bits, after which I will approve

Sep 22 2021, 8:28 PM

May 10 2021

dteske requested changes to D30015: Add zfskeys script to /etc/rc.d for auto-loading zfs keys.
May 10 2021, 7:47 PM

Dec 11 2020

dteske requested changes to D25711: freebsd-update(8): Add -j flag to support jails.

Just a simple bogon in the src bits, after which I will approve

Dec 11 2020, 4:43 PM

Aug 3 2020

dteske added a comment to D25343: Ensure logging retained when BSDINSTALL_LOG is not changed by preamble.

Thank for submitting. Give me a chance to review, but I do believe this looks like a good candidate for commit. Thank you

Aug 3 2020, 9:18 PM
dteske added a comment to D6757: Fix file descriptor and memory leaks in libdpv.

Sorry for the delay, had a disk failure take out my operations for a full 4 weeks, but finally got all the data recovered and back up and running

Aug 3 2020, 9:13 PM

Jul 3 2020

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

Hi markj,

Jul 3 2020, 2:03 AM

Jun 20 2020

dteske added a comment to D6757: Fix file descriptor and memory leaks in libdpv.

I've only a couple changes I'll make before committing with reference to OP. Instead of "doclose" I will use "opened" which makes the code easier to read.

Jun 20 2020, 8:44 PM
dteske commandeered D6757: Fix file descriptor and memory leaks in libdpv.

Take

Jun 20 2020, 8:42 PM

May 26 2020

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

I'm going to set an ETIMEOUT of 30 days. If there is no objection, I will import to base HEAD.

May 26 2020, 5:04 PM

May 20 2020

dteske committed rS361309: MFC r361300: Fix indentation in bsdinstall-created wpa_supplicant.conf.
MFC r361300: Fix indentation in bsdinstall-created wpa_supplicant.conf
May 20 2020, 11:27 PM
dteske committed rS361305: MFC r361300: Fix indentation in bsdinstall-created wpa_supplicant.conf.
MFC r361300: Fix indentation in bsdinstall-created wpa_supplicant.conf
May 20 2020, 10:21 PM
dteske committed rS361300: Fix indentation in bsdinstall-created wpa_supplicant.conf.
Fix indentation in bsdinstall-created wpa_supplicant.conf
May 20 2020, 9:39 PM
dteske closed D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.
May 20 2020, 9:39 PM
dteske updated the diff for D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.

Indentation fixes. Fix whitespace for consistency. Fix >80c lines.

May 20 2020, 9:00 PM
dteske commandeered D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.

Pre-update commandeer

May 20 2020, 8:59 PM

Apr 30 2020

dteske accepted D24640: bsdinstall: do a `certctl rehash` upon installation of configuration.

LGTM

Apr 30 2020, 7:48 PM

Apr 12 2020

dteske added a comment to D24378: Add mention of wireless option in bsdconfig.

@crees oh, didn't know @debdrup wasn't a committer. You know how you get so used to seeing someone's name in your TL that you just assume they are in-the-fold ;D lol

Apr 12 2020, 8:41 PM
dteske accepted D24378: Add mention of wireless option in bsdconfig.
Apr 12 2020, 8:40 PM
dteske accepted D24378: Add mention of wireless option in bsdconfig.

Thank you!

Apr 12 2020, 6:15 PM

Apr 10 2020

dteske added a reviewer for D24359: Add Farsi/Persian locales: mmokhi.
Apr 10 2020, 7:59 PM

Mar 11 2020

dteske accepted D24037: Add missing DTrace files for WITHOUT_CDDL=yes..
Mar 11 2020, 11:23 PM

Mar 6 2020

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

Returning to this, as I still want to add it to base.

Mar 6 2020, 9:35 PM

Mar 2 2020

dteske added a comment to D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.

Ping?

Mar 2 2020, 6:28 PM

Feb 14 2020

dteske requested changes to D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.

The purpose of the awk is to trim a single leading-tab from the input.

Feb 14 2020, 11:01 PM

Jan 26 2020

dteske requested changes to D23224: bsdinstall: Provide help text for partitioning options.
Jan 26 2020, 3:24 AM

Jan 3 2020

dteske committed rP521892: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization.
[New Port] math/R-cran-alabama: Constrained Nonlinear Optimization
Jan 3 2020, 12:57 AM
dteske closed D22675: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization.
Jan 3 2020, 12:57 AM

Jan 2 2020

dteske committed rP521862: [New Port] math/R-cran-ADGofTest: Anderson-Darling GoF test.
[New Port] math/R-cran-ADGofTest: Anderson-Darling GoF test
Jan 2 2020, 5:58 PM
dteske closed D22673: [New Port] math/R-cran-ADGofTest: Anderson-Darling GoF test.
Jan 2 2020, 5:58 PM

Dec 22 2019

dteske added a comment to D16132: New cmb(3) library and cmb(1) utility.

In pkg we have a SAT solver. Can you explain how your CMB compares to a SAT solver?

Dec 22 2019, 8:04 PM

Dec 6 2019

dteske added a comment to D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library.

I've had time to reflect, and I sincerely apologize for my unreasonable reaction to a reasonable inquiry.

Dec 6 2019, 9:14 PM
dteske committed rP519127: [New Port] math/R-cran-acepack: ACE and AVAS for selecting multiple regression….
[New Port] math/R-cran-acepack: ACE and AVAS for selecting multiple regression…
Dec 6 2019, 9:48 AM
dteske closed D22667: [New Port] math/R-cran-acepack: ACE and AVAS for selecting multiple regression transformations.
Dec 6 2019, 9:48 AM
dteske committed rP519125: sysutils/cmocka: Update cmocka from version 1.1.3 to 1.1.5.
sysutils/cmocka: Update cmocka from version 1.1.3 to 1.1.5
Dec 6 2019, 9:37 AM
dteske closed D22629: sysutils/cmocka: Update cmocka from version 1.1.3 to 1.1.5.
Dec 6 2019, 9:37 AM
dteske committed rP519124: sysutils/ssd_report: Update ssd_report from version 0.2 to 0.4.
sysutils/ssd_report: Update ssd_report from version 0.2 to 0.4
Dec 6 2019, 9:27 AM
dteske closed D22627: sysutils/ssd_report: Update ssd_report from version 0.2 to 0.4.
Dec 6 2019, 9:26 AM

Dec 5 2019

dteske added a reviewer for D22629: sysutils/cmocka: Update cmocka from version 1.1.3 to 1.1.5: mat.
Dec 5 2019, 1:57 AM
dteske added a reviewer for D22627: sysutils/ssd_report: Update ssd_report from version 0.2 to 0.4: mat.
Dec 5 2019, 1:57 AM

Dec 4 2019

dteske added inline comments to D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library.
Dec 4 2019, 11:23 PM
dteske updated the diff for D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library.

Remove PORTVERSION

Dec 4 2019, 11:11 PM
dteske updated the diff for D22675: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization.

Remove PORTVERSION

Dec 4 2019, 11:10 PM
dteske added inline comments to D22675: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization.
Dec 4 2019, 11:06 PM
dteske added a comment to D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library.
In D22681#496190, @jhb wrote:

Erm, there's this bit in bsd.port.Mk:

.if defined(DISTVERSION)
DEV_ERROR+=     "Defining both PORTVERSION and DISTVERSION is wrong, only set one, if necessary, set DISTNAME"
.endif

I suspect DEV_ERROR means it only errors if you have DEVELOPER=yes set in /etc/make.conf as the porter's handbook recommends (see the start of chapter 3 at https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html). I ran into this error the other day myself when I had a bug in one of my ports (was including bsd.port.mk again after bsd.port.pre.mk).

Dec 4 2019, 11:04 PM
dteske added inline comments to D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library.
Dec 4 2019, 10:59 PM
dteske added inline comments to D22675: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization.
Dec 4 2019, 8:40 PM
dteske removed a reviewer for D22627: sysutils/ssd_report: Update ssd_report from version 0.2 to 0.4: mat.
Dec 4 2019, 8:23 PM
dteske removed a reviewer for D22629: sysutils/cmocka: Update cmocka from version 1.1.3 to 1.1.5: mat.
Dec 4 2019, 8:23 PM
dteske removed a reviewer for D22667: [New Port] math/R-cran-acepack: ACE and AVAS for selecting multiple regression transformations: mat.
Dec 4 2019, 8:23 PM
dteske removed a reviewer for D22673: [New Port] math/R-cran-ADGofTest: Anderson-Darling GoF test: mat.
Dec 4 2019, 8:23 PM
dteske removed a reviewer for D22675: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization: mat.
Dec 4 2019, 8:23 PM
dteske removed a reviewer for D22676: [New Port] devel/R-cran-bigmemory.sri: A shared resource interface for Bigmemory Project packages: mat.
Dec 4 2019, 8:23 PM
dteske removed a reviewer for D22677: [New Port] devel/R-cran-bigmemory: Manage Massive Matrices with Shared Memory and Memory-Mapped Files: mat.
Dec 4 2019, 8:23 PM
dteske removed a reviewer for D22679: [New Port] devel/R-cran-blob: A Simple S3 Class for Representing Vectors of Binary Data ('BLOBS'): mat.
Dec 4 2019, 8:23 PM
dteske removed a reviewer for D22680: [New Port] graphics/R-cran-bmp: Read Windows Bitmap (BMP) Images: mat.
Dec 4 2019, 8:23 PM
dteske removed a reviewer for D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library: mat.
Dec 4 2019, 8:22 PM
dteske added a comment to D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library.

So maybe before you blast someone with "please test before submitting reviews" maybe *you* should test

Dec 4 2019, 8:22 PM
dteske added a comment to D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library.

You know that field in Phabricator and arc that says "Test Plan"?

Dec 4 2019, 8:21 PM
dteske added inline comments to D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library.
Dec 4 2019, 8:17 PM
dteske added inline comments to D22675: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization.
Dec 4 2019, 8:04 PM
dteske updated the test plan for D16132: New cmb(3) library and cmb(1) utility.
Dec 4 2019, 7:36 PM
dteske updated the summary of D16132: New cmb(3) library and cmb(1) utility.
Dec 4 2019, 7:36 PM
dteske updated the summary of D16132: New cmb(3) library and cmb(1) utility.
Dec 4 2019, 7:35 PM
dteske updated the summary of D16132: New cmb(3) library and cmb(1) utility.
Dec 4 2019, 7:33 PM
dteske updated the summary of D16132: New cmb(3) library and cmb(1) utility.
Dec 4 2019, 7:32 PM
dteske updated the summary of D16132: New cmb(3) library and cmb(1) utility.
Dec 4 2019, 7:24 PM
dteske updated the diff for D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library.

Remove extra newline

Dec 4 2019, 7:07 PM
dteske updated the diff for D22680: [New Port] graphics/R-cran-bmp: Read Windows Bitmap (BMP) Images.

Remove extra newline as-per mat's instruction

Dec 4 2019, 7:06 PM
dteske updated the diff for D22679: [New Port] devel/R-cran-blob: A Simple S3 Class for Representing Vectors of Binary Data ('BLOBS').

Remove extra newline as-per mat

Dec 4 2019, 7:04 PM
dteske updated the diff for D22677: [New Port] devel/R-cran-bigmemory: Manage Massive Matrices with Shared Memory and Memory-Mapped Files.

Remove extra newline as-per mat

Dec 4 2019, 6:58 PM
dteske updated the diff for D22675: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization.

Remove extra newline per-mat

Dec 4 2019, 6:53 PM
dteske updated the diff for D22676: [New Port] devel/R-cran-bigmemory.sri: A shared resource interface for Bigmemory Project packages.

Remove extra newline

Dec 4 2019, 6:52 PM
dteske created D22681: [New Port] graphics/R-cran-Cairo: R Graphics Device using Cairo Graphics Library.
Dec 4 2019, 6:50 PM
dteske created D22680: [New Port] graphics/R-cran-bmp: Read Windows Bitmap (BMP) Images.
Dec 4 2019, 6:37 PM
dteske updated the diff for D22677: [New Port] devel/R-cran-bigmemory: Manage Massive Matrices with Shared Memory and Memory-Mapped Files.

Drop Makefile change from review (done by addport)

Dec 4 2019, 6:29 PM
dteske updated the diff for D22676: [New Port] devel/R-cran-bigmemory.sri: A shared resource interface for Bigmemory Project packages.

Drop Makefile change from review (done by addport)

Dec 4 2019, 6:29 PM
dteske updated the diff for D22675: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization.

Drop Makefile change from review (done by addport)

Dec 4 2019, 6:28 PM
dteske updated the diff for D22673: [New Port] math/R-cran-ADGofTest: Anderson-Darling GoF test.

Drop Makefile change from review (done by addport)

Dec 4 2019, 6:28 PM
dteske updated the diff for D22667: [New Port] math/R-cran-acepack: ACE and AVAS for selecting multiple regression transformations.

Drop Makefile change from review (done by addport)

Dec 4 2019, 6:28 PM
dteske created D22679: [New Port] devel/R-cran-blob: A Simple S3 Class for Representing Vectors of Binary Data ('BLOBS').
Dec 4 2019, 6:25 PM
dteske added inline comments to D22676: [New Port] devel/R-cran-bigmemory.sri: A shared resource interface for Bigmemory Project packages.
Dec 4 2019, 5:30 PM
dteske created D22677: [New Port] devel/R-cran-bigmemory: Manage Massive Matrices with Shared Memory and Memory-Mapped Files.
Dec 4 2019, 5:19 PM
dteske created D22676: [New Port] devel/R-cran-bigmemory.sri: A shared resource interface for Bigmemory Project packages.
Dec 4 2019, 5:09 PM
dteske updated the diff for D22673: [New Port] math/R-cran-ADGofTest: Anderson-Darling GoF test.

Update LICENSE in Makefile

Dec 4 2019, 4:58 PM
dteske created D22675: [New Port] math/R-cran-alabama: Constrained Nonlinear Optimization.
Dec 4 2019, 4:51 PM
dteske created D22673: [New Port] math/R-cran-ADGofTest: Anderson-Darling GoF test.
Dec 4 2019, 4:36 PM
dteske retitled D22627: sysutils/ssd_report: Update ssd_report from version 0.2 to 0.4 from Update sysutils/ssd_report from version 0.2 to 0.4 to sysutils/ssd_report: Update ssd_report from version 0.2 to 0.4.
Dec 4 2019, 8:08 AM
dteske retitled D22667: [New Port] math/R-cran-acepack: ACE and AVAS for selecting multiple regression transformations from [New Port] math/R-cran-acepack to [New Port] math/R-cran-acepack: ACE and AVAS for selecting multiple regression transformations.
Dec 4 2019, 8:08 AM
dteske created D22667: [New Port] math/R-cran-acepack: ACE and AVAS for selecting multiple regression transformations.
Dec 4 2019, 8:03 AM

Dec 2 2019

dteske abandoned D22628: Add doxygen settings to Mk/Uses.
Dec 2 2019, 6:11 PM
dteske added inline comments to D22628: Add doxygen settings to Mk/Uses.
Dec 2 2019, 6:11 PM
dteske added a comment to D22628: Add doxygen settings to Mk/Uses.
In D22628#495001, @mat wrote:

That is only one line of code worth. What problem are you trying to solve?

Dec 2 2019, 6:10 PM
dteske added inline comments to D22629: sysutils/cmocka: Update cmocka from version 1.1.3 to 1.1.5.
Dec 2 2019, 5:55 PM
dteske updated the diff for D22629: sysutils/cmocka: Update cmocka from version 1.1.3 to 1.1.5.

Remove noninja args to USES=cmake

Dec 2 2019, 5:54 PM
dteske added inline comments to D22629: sysutils/cmocka: Update cmocka from version 1.1.3 to 1.1.5.
Dec 2 2019, 5:44 PM