https://reviews.freebsd.org/D58855 is up and it fixes not only this problem but fontconfig and other symlink issues

Drop FONTCONFIG_PATH, /var/run/dbus fixed by https://reviews.freebsd.org/D58855

Eliminate procfs guard in favor of https://reviews.freebsd.org/D58855

Leaning toward abandoning this in favor of a namei fix for the absolute-symlink fallback (same PR). Write-up shortly.

Implement per-arch hooks akin to mdthread; no arch ifdefs in common code

Resurrect informational message (~markj)

Address inline comments and fix for 80c

Address inline comments (kib)

In D58789#1349424, @ziaee wrote:

Oh man, this is a feature I have wanted!

Move storyline to [new] ATF test (markj, inquire_JohnEricson.me)

Fix -h / -v combinations with -hold / -release (jrm)

The fontconfig setup is really a fix for CURRENT that deals with broken symlink resolution at-present -- that needs to be bisected separately, but until then keeping the setting is harmless and produces the desired results even on CURRENT

Tested dbus integration with working pause/play, rewind, and fast-forward integration, and screensaver inhibit all working regardless of whether WM is bus-less or not. In a bus-less WM session, it brings its own bus run that tears down on browser exit

1. Fix dbus integration (dbus-launch -> dbus-run-session)
2. Remove BRAVE_WIDEVINE from SUB_LIST (arrowd)
3. Fix pulseaudio detection (pre-existing issue)
4. Favor angle-on-vulkan over Mesa GL (w/ pkg-message updates)
5. Remove unnecessary FONTCONFIG_FILE (rely on FONTCONFIG_PATH) (~arrowd)

Add copyright for diff addition and output "Comparing" line to stderr

Caught a few more technical debt issues in the wrapper:

In D58784#1349422, @adrian wrote:

In D58784#1349402, @dteske wrote:

In D58784#1349393, @arrowd wrote:

In D58784#1349385, @dteske wrote:

Also, currently battling an issue where dbus-launch sticks around after browser exit. Expect a fix for that to come in the next update too.

Is it really needed, by the way? Applications should only create buses if they want to have a separate bus for their own needs. Does Brave talk to its children via dbus?

The value-add we bring with dbus-launch is inhibition of screensaver invocation when Netflix is playing.

All part of my master plan to replace my Apple TV with a Framework Laptop 12

sure but shouldn't your X environment be starting dbus-launch and setting up the XDG stuff for its window manager and child processes to run in?

In D58784#1349393, @arrowd wrote:

In D58784#1349385, @dteske wrote:

Also, currently battling an issue where dbus-launch sticks around after browser exit. Expect a fix for that to come in the next update too.

Is it really needed, by the way? Applications should only create buses if they want to have a separate bus for their own needs. Does Brave talk to its children via dbus?

Also, currently battling an issue where dbus-launch sticks around after browser exit. Expect a fix for that to come in the next update too.

In D58792#1349067, @inquire_JohnEricson.me wrote:

Oh I didn't mean a real-world test with actual xorg, I meant a small test of connect/connectat itself ensuring we get the correct error code.

See D58406 for the sort of test I'm talking about.

In addition to the two cleanup tasks for later today (eliminating FONTCONFIG_FILE and setting only FONTCONFIG_PATH plus eliminating BRAVE_WIDEVINE substitution), I propose we move from GL rendering to vulkan when the wrapper detects it as viable (passing --use-angle=vulkan).

In D58784#1349097, @iwtcex_gmail.com wrote:

I don't exactly enjoy my time trying to understand LLM dumps on the bug tracker. That itself is pretty rude.

In D58784#1349069, @arrowd wrote:

dteske removed a subscriber: iwtcex_gmail.com.

What's this about?

In D58780#1349075, @monwarez_mailoo.org wrote:

Have you tested the impact with ports like:

games/linux-steam-utils
www/linux-widevine-cdm
emulators/wine-proton
emulators/libc6-shim

By testing I mean that steam should still run,
Games that was running with wine-proton before should still works, games that was running with either lsu chroot option should still works if they were working before.
For widevine, drm content should still be playable after this patch.
For libc6-shim, I guess that it is already tested with steam, but I would assume that if cuda was working before, it should still works after.

In D58792#1349062, @inquire_JohnEricson.me wrote:

Sorry about the breakage! I have no authority here, but would you mind writing a test for this? See where the other connectat test are.

Inline comments (kib)

This is a fix for regression introduced by D58405

Address inline comments

@arrowd thank you, if all looks good, I'll commit it with your re-approval

Prefer %%LOCALBASE%% over %%PREFIX%% and rely solely on Dbus relaunch sentinel

Remove default-value variables for brevity (arrowd)

Remove runtime dependency on liux-widevine-cdm

Remove comment (adrian)

👍 excellent

In D58735#1347641, @yuri wrote:

Approved.
Please commit it.

In the proposed commit message, there's a typo:

On the proposed commit messages, I think Robert (@fuz) will agree, I think we would put:

In D58700#1347447, @kfv wrote:

In D58700#1347007, @dteske wrote:

Alternative to .mailmap is freefall:/var/forward/kfv

I don't think .mailmap is related to our freefall email forwarding, it’s only used by Git to map multiple email addresses/names to a single canonical identity.