Creator/Maintainer of FreeBSD bootloader-menu/bsdconfig/dpv/dwatch/figpar/sysrc
Maintainer of FreeBSD base/bsdinstall/DTrace/forth/jail/netgraph/ports/vnet
Maintainer of FreeBSD ports: (net-p2p) shx (sysutils) bsdconfig cmocka DTraceToolkit dwatch-gource dwatch-pwsnoop host-setup mping ssd_report sysrc tzdialog zfs-stats-lite
Drive-by's: (devel) p4d p4web (emulators) xen xen-kernel (net) pptpclient (ports-mgmt) pkg (sysutils) getssl syslinux vzvol
User Details
- User Since
- Sep 2 2014, 7:30 PM (544 w, 6 d)
Feb 9 2024
Jan 20 2024
Fix variable name in awk -- s/time/tm/
Jan 19 2024
Advertise -j option in stats usage statement
Oct 22 2023
Oct 17 2023
Full context as-requested by emaste
Oct 16 2023
Sep 1 2022
LGTM
Aug 27 2022
Bump port to 1.2 so we catch latest development (the inclusion of a dashboard for the Block I/O stats)
Fix distinfo
Update diff before applying to head
I was working on committing this and went to go apply the patch to the tree and the patch no longer applies cleanly.
Aug 23 2022
Add missing dashboard examples from 1.1
Fixup package COMMENT to match what I have set for 1.1
Pepper [@]sample
Aug 22 2022
Reclaim
Tested and ready for re-review
Add missing io-sample conf
makesum for 1.1
Add symbolic link entries from 1.1
Add missing config to plist for 1.1
Update pkg-descr for 1.1
Update the plist for 1.1
Abandon the update to 0.5 and update to 1.1
Aug 16 2022
Great work. I gave it a thorough check, inside and out. Green-lit to go.
Aug 6 2022
From my 2018 BSDCAN presentation slides, here are the modules in base ... we're not going to add "dwatch-" prefix to all those simply because a PORT convention says that a PORT should install files named the same as the PORT when the PORT should follow BASE convention already set forth 6 years ago
Aug 5 2022
Jul 1 2022
I have two suggestions, but you're only meant to pick one. I don't care which. Minor optimization or major optimization.
Jun 29 2022
Sorry for being late to the party
Jun 2 2022
There we go. This looks to be all good.
Jun 1 2022
The raw diff [1] looks funny. The "before" (line removed) doesn't match what is in head [2].
May 31 2022
May 30 2022
Can we discuss perhaps using K&R style naming?
I will also note that the removal of the "export" may cause issues. There would be other acceptable solutions, such as:
Changes required.
May 28 2022
May 27 2022
Fix a memory leak introduced by previous commit.
This is not what I wanted. The second diff (that I prematurely accepted) that you committed omits the f_isset call
Do you need me to commit this or do you have a venue/access?
May 26 2022
Looks good
The change to use f_isset in 2 places is a good one, thank you. However, I have issue with the removal of the call to "local" above the second hunk.
Apr 18 2022
This looks pretty well thought out. Give me some time to review it and get back to you. Thank you for your efforts.
Oct 9 2021
Oct 8 2021
Sep 22 2021
May 10 2021
Dec 11 2020
Just a simple bogon in the src bits, after which I will approve
Aug 3 2020
Thank for submitting. Give me a chance to review, but I do believe this looks like a good candidate for commit. Thank you
Sorry for the delay, had a disk failure take out my operations for a full 4 weeks, but finally got all the data recovered and back up and running
Jul 3 2020
Hi markj,
Jun 20 2020
I've only a couple changes I'll make before committing with reference to OP. Instead of "doclose" I will use "opened" which makes the code easier to read.
May 26 2020
I'm going to set an ETIMEOUT of 30 days. If there is no objection, I will import to base HEAD.
May 20 2020
Indentation fixes. Fix whitespace for consistency. Fix >80c lines.
Pre-update commandeer
Apr 30 2020
LGTM