dteske (Devin Teske)
Resources

Projects

User Details

User Since
Sep 2 2014, 7:30 PM (181 w, 5 d)

Recent Activity

Today

dteske added inline comments to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.
Mon, Feb 26, 1:30 AM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

New profiles added:

Mon, Feb 26, 12:33 AM
dteske committed rS329996: Consistent casing for fallback SIGCHLD (s/Unknown/unknown/).
Consistent casing for fallback SIGCHLD (s/Unknown/unknown/)
Mon, Feb 26, 12:04 AM
dteske committed rS329995: Updates and enhancements to signal.d to aid DTrace scripting.
Updates and enhancements to signal.d to aid DTrace scripting
Mon, Feb 26, 12:00 AM

Sat, Feb 24

dteske committed rS329914: Updates and enhancements to io.d to aid DTrace scripting.
Updates and enhancements to io.d to aid DTrace scripting
Sat, Feb 24, 5:13 PM

Wed, Feb 21

dteske planned changes to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

@gnn: Excited as I am for the accept, I have one last final (big) change to finalize the code before commit.

Wed, Feb 21, 6:50 PM

Fri, Feb 16

dteske committed rP461989: Follow up to r461982.
Follow up to r461982
Fri, Feb 16, 8:46 AM
dteske committed rP461982: new port sysutils/getssl: Local LetsEncrypt client.
new port sysutils/getssl: Local LetsEncrypt client
Fri, Feb 16, 4:54 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Feb 16, 4:54 AM
dteske committed rS329353: Add inline to errno.d for translating int to string.
Add inline to errno.d for translating int to string
Fri, Feb 16, 4:22 AM

Thu, Feb 15

dteske committed rS329334: Add the following errno definitions to /usr/lib/dtrace/errno.d.
Add the following errno definitions to /usr/lib/dtrace/errno.d
Thu, Feb 15, 6:37 PM

Tue, Feb 13

dteske requested changes to D14313: New Port: sysutils/getssl.

If you install portlint (/usr/ports/ports-mgmt/portlint) and run "portlint -a" you'll see a couple warnings that we should take care of.

Tue, Feb 13, 12:29 AM

Mon, Feb 12

dteske committed rS329188: Use tabs in io.d, fix alignment issues, remove extraneous newlines.
Use tabs in io.d, fix alignment issues, remove extraneous newlines
Mon, Feb 12, 11:54 PM

Sun, Feb 11

dteske committed rS329115: Fix typo in dtrace_tcp(4).
Fix typo in dtrace_tcp(4)
Sun, Feb 11, 3:02 AM

Sun, Feb 4

dteske requested changes to D14169: Extending the bsdinstall(8) documentation to include ZFS scripted installation.

I ran mandoc -mdoc -Tlint against your patched bsdinstall.8. Lines 373, 507, and 509 need attention.

Sun, Feb 4, 12:57 PM

Sat, Feb 3

dteske added a reviewer for D14169: Extending the bsdinstall(8) documentation to include ZFS scripted installation: dteske.
Sat, Feb 3, 7:35 PM

Thu, Feb 1

dteske closed D14039: sysutils/vzvol: update maintainer email.

Closed by commit rP460627: sysutils/vzvol: Update to 0.6.1

Thu, Feb 1, 8:26 PM
dteske committed rP460627: sysutils/vzvol: Update to 0.6.1.
sysutils/vzvol: Update to 0.6.1
Thu, Feb 1, 8:19 PM
dteske closed D14086: sysutils/vzvol: Update to 0.6.1.
Thu, Feb 1, 8:19 PM

Wed, Jan 31

dteske added a comment to D13946: (WIP) rc: Allow environment to override sourced rc.conf.

I understand the double-underbar prefix as an analog to MAKE_CONF but right above RC_CONF is RC_PID; could we make it RC_CONF to be more internally consistent within the given file?

Wed, Jan 31, 7:01 PM
dteske added a reviewer for D13946: (WIP) rc: Allow environment to override sourced rc.conf: dteske.
Wed, Jan 31, 6:58 PM

Tue, Jan 30

dteske accepted D14086: sysutils/vzvol: Update to 0.6.1.

Will try and commit tonight

Tue, Jan 30, 12:30 AM
dteske accepted D14064: Change the installer default to not install ports.
Tue, Jan 30, 12:22 AM

Sun, Jan 28

dteske added a comment to D10320: usr.bin/netstat: -n should not print symbolic names.

In my review of other systems the printing of "default" for this is common and has a long history, changing it at this point in the game would probably be a POLA and possibly break some scripts. I have worked around the issue that caused me to notice this in another way.

We may want to change this into a man page fix that adds the fact that 0.0.0.0/0 is printed as "default" even with the -n option.

Sun, Jan 28, 1:56 AM
dteske added a comment to D10320: usr.bin/netstat: -n should not print symbolic names.

There are three vantage points:

Sun, Jan 28, 1:24 AM

Jan 25 2018

dteske accepted D14039: sysutils/vzvol: update maintainer email.
Jan 25 2018, 5:16 PM

Jan 22 2018

dteske added a reviewer for D13994: sysutils/vzvol v0.6.0 update: dteske.
Jan 22 2018, 8:01 PM

Jan 20 2018

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Updated patch to apply cleanly to head.

Jan 20 2018, 2:52 AM

Jan 12 2018

dteske accepted D13877: DTrace: Add jailname/jid builtins.

After you explained that zonename is for compatibility, making it easier to port scripts from Solaris, this seems like a good change. Thank you for you hard work. Cheers!

Jan 12 2018, 2:43 PM · DTrace
dteske requested changes to D13877: DTrace: Add jailname/jid builtins.

I just noticed that the ifdef for solaris was removed, resulting in the declaration of zonename. Was this intentional, and if-so, why?

Jan 12 2018, 1:06 PM · DTrace
dteske added a comment to D13877: DTrace: Add jailname/jid builtins.

Tracing on a per-jail basis using a predicate was already possible (example below):

someprobe /curthread->td_proc->p_ucred->cr_prison->pr_id == $1/
{
        /* some actions */
}

That's true, however, this exposes a stable interface that people can use without following pointers in the D script and instead simply calling into a builtin variable. I'd imagine this is the same reason why you would want to have execname, errno, uid, gid and others, as they can also be accessible via other, more primitive builtins.

Jan 12 2018, 1:04 PM · DTrace

Jan 11 2018

dteske added a comment to D13877: DTrace: Add jailname/jid builtins.

Tracing on a per-jail basis using a predicate was already possible (example below):

Jan 11 2018, 11:47 PM · DTrace

Jan 4 2018

dteske committed rP458020: New port: sysutils/vzvol: Feature-rich ZFS zvol management tool.
New port: sysutils/vzvol: Feature-rich ZFS zvol management tool
Jan 4 2018, 9:56 AM

Dec 14 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Code changes:

  • Allow "-E code" to be passed multiple times
  • Make "-F" use same glyphs as dtrace(1) (e.g., "->" instead of "=>")
Dec 14 2017, 12:20 PM

Dec 12 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Code updates:

  • Make -F option show default details
  • Fix -F option to work with -E code
Dec 12 2017, 7:43 AM

Nov 22 2017

dteske accepted D13190: Fix indentation in bsdinstall-created wpa_supplicant.conf.
Nov 22 2017, 2:31 PM

Nov 16 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

If you have pkg.fraubsd.org configured, you can say "pkg upgrade dwatch" to try this code.

Nov 16 2017, 12:05 AM
dteske retitled D10006: Add dwatch(8) for watching processes as they trigger dtrace probe from Add dwatch(8) for watching processes as they enter dtrace probe to Add dwatch(8) for watching processes as they trigger dtrace probe.
Nov 16 2017, 12:04 AM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Updates incorporating feedback and bug fixen.

Nov 16 2017, 12:01 AM

Oct 14 2017

dteske added inline comments to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Oct 14 2017, 11:55 PM

Oct 13 2017

dteske added inline comments to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Oct 13 2017, 10:18 PM
dteske requested changes to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.

Add comments and request changes

Oct 13 2017, 9:34 PM

Oct 6 2017

dteske committed rS324371: MFC SVN r295342-295344.
MFC SVN r295342-295344
Oct 6 2017, 6:22 PM

Sep 12 2017

dteske accepted D12346: Don't complain about missing mountpoints for scripted installations..
Sep 12 2017, 10:12 PM
dteske added a reviewer for D12346: Don't complain about missing mountpoints for scripted installations.: dteske.
Sep 12 2017, 9:45 PM
dteske added inline comments to D12346: Don't complain about missing mountpoints for scripted installations..
Sep 12 2017, 9:45 PM

Sep 11 2017

dteske accepted D12270: Update sysutils/docker-freebsd to somewhere circa v17.05.0.

Great work! (can't think of anything else other than known pending issues e.g., PORT_EPOCH and version which is blocked by need to generate a tag; getting this far we can totally leverage this for runtime testing to get to a tag-point where we are happy with the runtime performance).

Sep 11 2017, 10:15 PM

Sep 8 2017

dteske added inline comments to D12270: Update sysutils/docker-freebsd to somewhere circa v17.05.0.
Sep 8 2017, 5:41 PM
dteske added inline comments to D12270: Update sysutils/docker-freebsd to somewhere circa v17.05.0.
Sep 8 2017, 5:38 PM
dteske added inline comments to D12270: Update sysutils/docker-freebsd to somewhere circa v17.05.0.
Sep 8 2017, 5:36 PM
dteske added inline comments to D12270: Update sysutils/docker-freebsd to somewhere circa v17.05.0.
Sep 8 2017, 5:11 PM

Sep 7 2017

dteske updated the summary of D12270: Update sysutils/docker-freebsd to somewhere circa v17.05.0.
Sep 7 2017, 10:51 PM
dteske updated the summary of D12270: Update sysutils/docker-freebsd to somewhere circa v17.05.0.
Sep 7 2017, 10:51 PM
dteske retitled D12270: Update sysutils/docker-freebsd to somewhere circa v17.05.0 from update docker-freebsd to somewhere circa v17.05.0 to Update sysutils/docker-freebsd to somewhere circa v17.05.0.
Sep 7 2017, 10:50 PM
dteske added inline comments to D12270: Update sysutils/docker-freebsd to somewhere circa v17.05.0.
Sep 7 2017, 10:43 PM
dteske added inline comments to D12270: Update sysutils/docker-freebsd to somewhere circa v17.05.0.
Sep 7 2017, 7:28 PM

Aug 16 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.
In D10006#206784, @gnn wrote:

New, BSD license, code does not need to be in cddl. Most of the new D scripts and programs go into either share/dtrace or the DTrace Toolkit port. Since this is a script I'd put it into share/dtrace if you want it in the src tree.

I'd agree with this... My gut feeling is that I'd look for it in /usr/share/dtrace or maybe /usr/share/examples/dtrace, probably the former. where it is on porridge (/usr/share/dtrace/watch_kill)

Aug 16 2017, 7:15 PM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

so, like is this getting committed some time?

Aug 16 2017, 6:47 PM

Jun 8 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Fixed typo as part of last update. Marking inline comments as done.

Jun 8 2017, 1:52 AM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

I've only just started playing with it, but I'll point out that the usage seems misleading: dwatch doesn't really take a (dtrace) probe as input, it takes a function or syscall name and constructs a probe name.

Jun 8 2017, 1:51 AM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

I am running an open public beta of this software. To test the software that is currently submitted here for review, head over to pkg.fraubsd.org in your browser, pick an architecture, and either follow the instructions for setting up the FrauBSD pkg repository and say "pkg install fraubsd/dwatch" or download the dwatch tarball and install with "pkg add PKGFILENAME.txz"

Jun 8 2017, 1:44 AM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Complete overhaul in an effort to address earlier feedback.

Jun 8 2017, 1:14 AM

May 25 2017

dteske committed rS318891: Fix long standing issue in bsdconfig's keymap selection.
Fix long standing issue in bsdconfig's keymap selection
May 25 2017, 6:16 PM
dteske closed D8734: HBSD: fix long standing issue in bsdconfig's keymap selection by committing rS318891: Fix long standing issue in bsdconfig's keymap selection.
May 25 2017, 6:16 PM
dteske added a comment to D8734: HBSD: fix long standing issue in bsdconfig's keymap selection.

@dteske will you commit it?

May 25 2017, 5:37 PM
dteske accepted D10895: Make the ZFS min_auto_ashift=12 setting persistent.

LGTM

May 25 2017, 5:32 PM

May 19 2017

dteske accepted D10738: bsdinstall: mount is not needed for the ZFS install case.

LGTM

May 19 2017, 5:28 PM

May 18 2017

dteske requested changes to D10738: bsdinstall: mount is not needed for the ZFS install case.
May 18 2017, 10:00 PM

May 3 2017

dteske added a comment to D10585: Document "MFC to" and "MFC with" commit tags.

"MFC after" and "X-MFC-after" are two different things.

That's precisely my point. X-MFC-after is being used intentionally to avoid being parsed by the MFC script, because the commit author believes the MFC reminder script will not be able to parse the value. That's distinct from X-MFC-to or X-MFC-with, where MFC to or MFC with would not cause trouble for the reminder script.

May 3 2017, 6:09 PM
dteske added a comment to D10585: Document "MFC to" and "MFC with" commit tags.

Can we add "MFC before:"?

I don't want to make this too long and would prefer to avoid special cases that have only occasional use. Right now it is unlikely "MFC before" could be automatically parsed. By its nature it will be somewhat unrestricted text, and even if we did parse it I don't think we want to build tooling to make the reminder script aware of upcoming branch / release dates.

May 3 2017, 6:08 PM
dteske requested changes to D10585: Document "MFC to" and "MFC with" commit tags.

Can we add "MFC before:"? E.g., "If the commit should be merged before some particular branch creation, specify the branch name(s)." Example: "MFC before: RC-3". Used by bz and gjb. See revisions 285733, 285082, 285078, 285076, 259427, 259426, 185435, and 148871.

May 3 2017, 5:11 PM

Apr 26 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Update to apply cleanly to HEAD
Add "-x" option to enable probe tracing
Don't set caller_execname unless hooked on syscall::execve
Fix indentation in generated dtrace(1) code
Beautify generated dtrace(1) code
Fix nested DTrace predicates; "-t test" now works with profiles
Postpone jail predicate generation until after profile loading
Fix a missing ".Ar" in dwatch(8) manual
Update examples/profile_template to include EVENT_TEST info
Change "kill" profile to print unmodified pid_t argument
Fix signedness in printf for signal argument in "kill" profile
Add code to "vop_*" profiles to NULL-ify transient variables
Optimize vnode-walking process in VFS profiles
Fix ellipsis generation for paths exceeding DEPTH_MAX in VFS profiles
Update VFS profiles to use EVENT_TEST instead of EVENT for predicates
Fix incorrect "probe ID" comments generated by vop_rename profile

Apr 26 2017, 10:19 PM

Apr 25 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Update patch to apply cleanly to HEAD
Fix generation of ellipsis for trailing arguments
Remove double-quotes on $COUNT which is guaranteed to be a number

Apr 25 2017, 11:33 PM

Apr 20 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Add "-t test" option for customizing dtrace(1) predicate
Add "-j jail" option for limiting events to a jail name/jid
Change "-p" option (disable profiles) to "-P"
Add "-p pid" option for watching a particular process id
When given "-D-" perform all error checks before reading stdin
Issue an error and exit if group in "-g name" does not exist
Fix spurious double-error when given bad user in "-u name"
Given "-u user" and "-g group" but not "-q", display user before group
Use walltimestamp instead of timestamp for event date/time
Very minor refactoring for code readability
Make ending semi-colon for "-D code" optional
Whitespace and comments
Minor fixes to grammar and punctuation in manual
Sort examples in manual by flag being demonstrated
Add the following examples to manual:
dwatch -f '(mk|rm)dir' execve
dwatch -g wheel execve
dwatch -j 0 execve
dwatch -j myjail execve
dwatch -l 'read$'
dwatch -p 1234 execve
dwatch -q -t 'arg2<10' -D 'printf("%d",arg2)' write
dwatch -v -p 1234 execve

Apr 20 2017, 12:13 AM

Mar 29 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Update diff to apply cleanly to HEAD
Make -q flag squelch errors from dtrace(1)

Mar 29 2017, 8:12 PM

Mar 28 2017

dteske added a reviewer for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe: avg.
Mar 28 2017, 4:09 AM

Mar 27 2017

dteske added a member for DTrace: dteske.
Mar 27 2017, 6:43 PM
dteske added a reviewer for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe: DTrace.
Mar 27 2017, 6:40 PM
dteske added a reviewer for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe: skreuzer.
Mar 27 2017, 6:21 PM
dteske added a reviewer for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe: gnn.
Mar 27 2017, 6:21 PM
dteske removed a reviewer for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe: gnn.
Mar 27 2017, 6:21 PM

Mar 23 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

I wanted to take a moment to explain why the probe syntax for dwatch(8) is "[provider:[module:]]function" and not "[provider:[module:[function:]]]name" as is the probe syntax for dtrace(1).

Mar 23 2017, 7:24 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Incorporate much feedback from previous comments on this review
Update patch to apply cleanly to head
Make lchmod a hard link to chmod
Make vop_{lookup,mkdir,mknod,remove,rmdir} a hard link to vop_create
Change terminology to name dwatch(8) modules to instead profiles
NB: Prevents term modules from being confused with dtrace(1)
Improve readability and simplify code
Move -e code option to -D code for injecting DTrace event detail code
Move -p action option to -e name for modifying the event action
Move -M option to -p for disabling profiles (formerly termed modules)
Update usage statement to be more clear about what a "probe" is
NB: Instead of "probe" show that we expect "[provider:[module:]]function"
Simplify profile loading
Set $FILE $PROFILE and $PROBE before loading profile(s)
Consolidate file descriptor operations
Fix a bug where -u root or -g root did not work as expected
NB: Also fixed -u 0 and -g 0 which suffered from the same issue
Add further clarification to the manual page with respect to probe format
Add examples to the manual page
Move examples/module_template to examples/profile_template
Improve comments in examples/profile_template
Reduce size of profiles, removing comments inherited from profile_template
Add numerical suffixes in nanosleep profile (s for seconds; ns for nanosec)
Add support for -l -e name [pattern] syntax
NB: The -l [pattern] syntax did not support -e name before

Mar 23 2017, 12:29 AM

Mar 22 2017

dteske planned changes to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

I have thought of a way to massively reduce the size of the diff. In the spirit of asomers observation that several of the modules are quite similar, I've decided to improve the functionality provided to modules which will allow the modules to be linked to each other whilst preserving explicit probe value.

Mar 22 2017, 5:59 PM

Mar 21 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

The first thing I tried (without having fully read the manpage) was "dwatch sched:::on-cpu", which of course gives an error.

Mar 21 2017, 12:09 AM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Optimize filtration

Mar 21 2017, 12:05 AM

Mar 20 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

When a dwatch(8) module does not define DETAILS, default to pproc_dump()

Mar 20 2017, 11:59 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Fix mdoc warning: .It macros in lists of type `tag-list' require arguments

Mar 20 2017, 11:57 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Allow modules to contain hyphen in their name

Mar 20 2017, 11:51 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Add `-p action' flag, example usage: dwatch -p on-cpu sched::

Mar 20 2017, 11:45 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Update patch to apply cleanly against latest HEAD

Mar 20 2017, 11:25 PM

Mar 18 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Move back to cddl/usr.sbin to live amongst similarly [BSD] licensed zfsd
Update ObsoleteFiles.inc to remove deprecated/removed watch_* scripts
Fix a copy/paste issue in the manual (s/lchmod/nanosleep/)
Add usr/libexec/dwatch to etc/mtree/BSD.usr.dist

Mar 18 2017, 4:17 PM

Mar 17 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

@dteske Don't forget to update etc/mtree/BSD.usr.dist

Mar 17 2017, 6:42 PM

Mar 16 2017

dteske added inline comments to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.
Mar 16 2017, 3:49 PM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

I'll point out that the usage seems misleading: dwatch doesn't really take a (dtrace) probe as input,
it takes a function or syscall name and constructs a probe name.

Mar 16 2017, 3:44 PM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

A few observations that may help answer the Q of "usr.sbin vs cddl/usr.sbin"...

Mar 16 2017, 12:08 AM

Mar 15 2017

dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Back out of cddl and whack deprecated share/dtrace scripts

Mar 15 2017, 11:35 PM
dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.
In D10006#206784, @gnn wrote:

New, BSD license, code does not need to be in cddl.

Mar 15 2017, 11:29 PM

Mar 14 2017

dteske added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Address comments

Mar 14 2017, 9:48 PM
dteske updated the diff for D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

Move utility from usr.sbin/dwatch to cddl/usr.sbin/dwatch

Mar 14 2017, 8:40 PM