Page MenuHomeFreeBSD

debdrup (Daniel Ebdrup)
User

Projects

User Details

User Since
Jan 12 2018, 3:33 PM (254 w, 2 d)

Recent Activity

Oct 10 2022

debdrup accepted D33677: Mention vendor driver for if_re.

Apologies for taking so long, life got in the way.

Oct 10 2022, 2:33 PM

Sep 18 2022

debdrup added a comment to D36619: Deprecate telnetd.

mdoc(7) looks good

Sep 18 2022, 8:12 AM

Sep 12 2022

debdrup added inline comments to D36513: domains: rewrite documentation to describe present state.
Sep 12 2022, 5:15 PM

Jul 9 2022

debdrup accepted D35756: pkg: Add limited --debug/-d support.

I spotted a few nits, but they're not worth holding up the review for as they can be fixed before the commit is pushed.

Jul 9 2022, 8:00 AM

Jul 5 2022

debdrup added a comment to D35694: Add ts(1) command.

Other than the question, I'm still happy with the mdoc, so will accept once that's been answered.

Jul 5 2022, 10:45 AM

Jul 4 2022

debdrup accepted D35694: Add ts(1) command.

mdoc(7) looks good to me.

Jul 4 2022, 6:04 AM

Jul 2 2022

debdrup added a comment to D35694: Add ts(1) command.

I cant immediately spot any other nits with the mdoc, but perhaps you should add a note about when ts(1) was added to FreeBSD in the history section header?

Jul 2 2022, 4:26 PM

Jun 10 2022

debdrup committed R9:0454aae0d40c: status/2022q1: Fix space issue (authored by debdrup).
status/2022q1: Fix space issue
Jun 10 2022, 11:35 AM
debdrup committed R9:e6cacb6ecf7d: status/README: Add an order of operations (authored by debdrup).
status/README: Add an order of operations
Jun 10 2022, 11:29 AM
debdrup committed R9:3847af12e0c7: status/2022q1: Fix several small nits noticed late (authored by debdrup).
status/2022q1: Fix several small nits noticed late
Jun 10 2022, 3:04 AM

Jun 8 2022

debdrup accepted D35402: status/report-2022-01-2022-03: Add report.

I don't think there's anything else I remarked on that needs to be addressed, so if everyone else would accept it if theirs has been dealt with, we can get the needful done.

Jun 8 2022, 4:57 AM

Jun 6 2022

debdrup accepted D35405: Make SYNOPSIS match DESCRIPTION..

As for the change, it looks good to me - but as I'm sure you know, you need extra approval too. ;)

Jun 6 2022, 1:16 PM

Jun 4 2022

debdrup updated subscribers of D35402: status/report-2022-01-2022-03: Add report.

I've made some suggestions for where various entries belong, but that's about it I think.

Jun 4 2022, 1:35 PM

May 27 2022

debdrup added a comment to D35326: glabel.8: Warn against using generic labels on a shared device.

mdoc(7) syntax looks good to me, so once the other issues pointed out with the manual page have been fixed, I'm happy to accept it.

May 27 2022, 8:57 AM

May 23 2022

debdrup accepted D35283: mutex(9): correct man page, mtx_trylock_spin returns int not void.

I'm happy with mdoc(7) syntax since .Dd was bumped ;)

May 23 2022, 10:36 AM
debdrup accepted D35246: Fix grammar nit in versions chapter as discussed with bsdimp in email..

Looks good to go, go ahead and commit @imp

May 23 2022, 10:33 AM

May 8 2022

debdrup accepted D32551: if(9): Implement support for nvlist-based set- and get- network interface capabilities..

mdoc looks good to me.

May 8 2022, 4:05 PM

May 7 2022

debdrup added a comment to D32551: if(9): Implement support for nvlist-based set- and get- network interface capabilities..

.Dd also needs to be bumped.

May 7 2022, 11:17 PM

Apr 22 2022

debdrup accepted D34933: Import a quoted-printable bidirectional converter.

mdoc(7) looks good to me, but please remember to bump .Dd before you commit. :)

Apr 22 2022, 7:12 PM

Apr 21 2022

debdrup added a comment to D35015: handbook/zfs: Changes zfs send -P into zfs send -p.

I think it's ready to go now, and the summary should work better as a descriptive commit message. :)

Apr 21 2022, 9:55 AM
debdrup retitled D35015: handbook/zfs: Changes zfs send -P into zfs send -p from Handbook/zfs: Changes zfs send -P into zfs send -p to handbook/zfs: Changes zfs send -P into zfs send -p.
Apr 21 2022, 9:54 AM
debdrup accepted D35015: handbook/zfs: Changes zfs send -P into zfs send -p.

You're absolutely right, -P means parsable, whereas -p means properties.
You should probably explain that in the commit log, though - may I edit the summary?

Apr 21 2022, 9:25 AM

Apr 19 2022

debdrup accepted D34969: Tweaks to the software licensing page.

Looks good to me, so assuming it builds, you're good to go. :)

Apr 19 2022, 7:02 PM
debdrup added a comment to D34969: Tweaks to the software licensing page.

For one-sentence-per-line changes, we generally like to keep them as separate commits.
However, I think it's okay for this commit since you're changing so little.

Apr 19 2022, 6:56 PM

Apr 18 2022

debdrup added a comment to D34947: setkey(8): Clarify language around AEAD ciphers..

Ss, like Sh, should be capitalized according to mdoc(7).

Apr 18 2022, 8:06 PM
debdrup accepted D34946: Refactor version list in user handbook intro.

Looks good to me.

Apr 18 2022, 6:56 PM
debdrup committed R9:e8543cd9ce71: arch-handbook: Fix a few nits (authored by debdrup).
arch-handbook: Fix a few nits
Apr 18 2022, 2:35 PM
debdrup committed R9:821ac7145039: arch-handbook: Convert to one sentence per line (authored by debdrup).
arch-handbook: Convert to one sentence per line
Apr 18 2022, 2:35 PM
debdrup committed R9:954bbbabe38e: arch-handbook: Update boot chapter (authored by Isa <isa@isoux.org>).
arch-handbook: Update boot chapter
Apr 18 2022, 2:35 PM

Apr 13 2022

debdrup added a comment to D34896: strcpy(3): Explicitly mention the recommended usage of strlcpy().

I'd prefer if you used .Sy or .Em rather than capitalization.

Apr 13 2022, 9:23 AM

Apr 12 2022

debdrup committed rGbd1eafcdd02a: protect(1): Correct typo and add newline (authored by debdrup).
protect(1): Correct typo and add newline
Apr 12 2022, 10:41 AM

Apr 11 2022

debdrup committed rGc8b6be0f7d1b: protect.1: document existence of _oomprotect (authored by a.wolk_fudosecurity.com).
protect.1: document existence of _oomprotect
Apr 11 2022, 10:27 PM
debdrup closed D30334: protect.1: document existence of _oomprotect.
Apr 11 2022, 10:26 PM · manpages, docs
debdrup commandeered D30334: protect.1: document existence of _oomprotect.

I apologize deeply for losing track of this one (and the change to rc.subr(8), although I think I managed to address that one).

Apr 11 2022, 10:23 PM · manpages, docs
debdrup added a comment to D30336: rc.subr.8: document argument_cmd override pitfalls.

I ended up documenting this in bd6dce978c1, I believe - can you confirm?

Apr 11 2022, 10:19 PM · rc, manpages, docs

Apr 9 2022

debdrup added a comment to D34852: KTR: Add CTR() and TR() macros which accept a variable number of arguments..

Manual page syntax looks good, but it'd be nice to have a mention of the timing in the HISTORY section.

Apr 9 2022, 9:17 AM

Apr 7 2022

debdrup added a comment to D34690: RDMA driver for Intel(R) Ethernet Controller E810.

Have you run the manual page through mandoc -Tlint and igor from textproc/igor?

Apr 7 2022, 2:10 PM
debdrup accepted D34672: siftr: expose t_flags2 in siftr output.

Manual page looks good to me, but please remember to bump .Dd before pushing. ;)

Apr 7 2022, 7:34 AM

Apr 5 2022

debdrup added inline comments to D34347: savecore: add an option to save a live minidump.
Apr 5 2022, 10:26 AM

Apr 2 2022

debdrup accepted D34731: bikeshed.7: the backstory.
Apr 2 2022, 11:00 AM

Apr 1 2022

debdrup accepted D34632: Intel (R) QAT driver.

Manual page looks good to me from a syntax perspective, and I wasn't able to spot any other issues.

Apr 1 2022, 10:04 AM
debdrup requested changes to D34731: bikeshed.7: the backstory.

Please run mandoc -Tlint and igor on the manual page, you'll see that there's a few minor nits that need to be fixed.

Apr 1 2022, 9:43 AM
debdrup added inline comments to D34632: Intel (R) QAT driver.
Apr 1 2022, 9:36 AM

Mar 24 2022

debdrup added a comment to D34662: ifconfig.8: Add capability codes descriptions from handbook.

Syntax looks good, and it matches what I remember of my CCIE Wireless courses.

Mar 24 2022, 8:40 PM
debdrup accepted D34663: handbook: Move capabilities' description to ifconfig(8).

Looks good to me.

Mar 24 2022, 8:40 PM

Mar 23 2022

debdrup committed rG4b1e2c2f77d3: bsdinstall(8): Usage example of tar doesn't work (authored by farhan_farhan.codes).
bsdinstall(8): Usage example of tar doesn't work
Mar 23 2022, 9:02 PM
debdrup closed D34649: bsdinstall.8 tar command order of argument breakage.
Mar 23 2022, 9:01 PM · manpages
debdrup commandeered D34649: bsdinstall.8 tar command order of argument breakage.

Commandeering this now that @rpokala has approved it on IRC.

Mar 23 2022, 8:59 PM · manpages
debdrup accepted D34649: bsdinstall.8 tar command order of argument breakage.

mdoc syntax hasn't really changed and .Dd has been bumped, so this can be commited and pushed.

Mar 23 2022, 8:48 PM · manpages

Mar 22 2022

debdrup added a comment to D34632: Intel (R) QAT driver.

There are also some lines that exceed 80 characters in width, so the manual page needs to be rewrapped.

Mar 22 2022, 4:39 PM

Mar 20 2022

debdrup accepted D34615: sysctl(8): Mention CTLFLAG_SKIP.

Good to go.

Mar 20 2022, 6:25 PM
debdrup accepted D34615: sysctl(8): Mention CTLFLAG_SKIP.

I only spotted one minor nit, so I'll accept this and you can commit and push at your convenience after you've fixed it.

Mar 20 2022, 6:06 PM

Mar 16 2022

debdrup accepted D34576: wpa_supplicant.conf.5: add note about scan_ssid=1 eavesdropping.

Looks good to me.

Mar 16 2022, 8:27 AM

Mar 15 2022

debdrup accepted D34565: tslog.4: Document what TSLOG excels at.

Looks good to me.

Mar 15 2022, 7:07 PM
debdrup accepted D34566: boottrace.4: Document that boottrace is good at tracing one-shot events.

A nice little addition to have. :)

Mar 15 2022, 7:07 PM
debdrup accepted D32551: if(9): Implement support for nvlist-based set- and get- network interface capabilities..

Manual page looks good, I'll let others review the code.

Mar 15 2022, 7:06 PM
debdrup accepted D34570: Porter's Handbook: Document Uses=elfctl.

Looks good to me.

Mar 15 2022, 7:05 PM
debdrup added a comment to D32551: if(9): Implement support for nvlist-based set- and get- network interface capabilities..

I only noticed one thing in the mdoc syntax.

Mar 15 2022, 11:42 AM

Mar 14 2022

debdrup added a reviewer for D34556: Summer of Code page Fixes: docs.

My initial pass of it looks good, but consider waiting for someone else to look over it too.

Mar 14 2022, 11:29 PM

Mar 13 2022

debdrup accepted D34545: Chase mixer(8) command-line interface changes.

The mdoc syntax looks good to me.

Mar 13 2022, 3:39 PM

Mar 9 2022

debdrup added a comment to D34508: diff: add support for --help and --version.

A tiny nit with the mdoc syntax, otherwise it looks good to me.

Mar 9 2022, 12:07 PM
debdrup added a comment to D34502: libmd: export and document *Fd/*FdChunk interfaces.

I think you should add the "nearly" qualifier to identical, as saying they're identical and then mentioning an exception seems contradictory to me.

Mar 9 2022, 11:11 AM
debdrup accepted D34504: kern: add devctl_notifyf().

Manual page changes look good to me.

Mar 9 2022, 11:07 AM

Mar 8 2022

debdrup accepted D34482: pf: support basic L3 filtering in the Ethernet rules.

Please remember to bump .Dd on pf.conf.5 - other than that, manual page looks fine.

Mar 8 2022, 9:26 PM

Mar 4 2022

debdrup accepted D34438: time.3: Update ERRORS section.
Mar 4 2022, 5:47 PM
debdrup accepted D34430: tslog.4: Document TSLOG.

Manual page looks good to me.

Mar 4 2022, 5:46 PM

Mar 3 2022

debdrup added a comment to D34421: diff3: Add support for -A and -m.

I spotted one thing in the manual page, otherwise it looks good to me.

Mar 3 2022, 12:39 PM

Mar 2 2022

debdrup added a comment to D34410: Delete 25th anniversary image from FreeBSD website.

Yeah, let's hold off on celebrating the 30th anniversary until it actually happens, shall we? :)

Mar 2 2022, 6:34 PM

Mar 1 2022

debdrup committed R9:ba500062d0df: status: Fix typos in README (authored by debdrup).
status: Fix typos in README
Mar 1 2022, 8:23 PM
debdrup closed D34404: Title for FreeBSD quarterly status report April–June 2021 and January-March 2021.
Mar 1 2022, 8:14 PM
debdrup committed R9:78899464820c: status: Fix introduction in reports (authored by fel1x.mintchoco.development_gmail.com).
status: Fix introduction in reports
Mar 1 2022, 8:14 PM
debdrup accepted D34404: Title for FreeBSD quarterly status report April–June 2021 and January-March 2021.

I'll get this committed and pushed too, since it's such a trivial little fix.

Mar 1 2022, 8:10 PM
debdrup accepted D34373: Change capitalization of NGINX and NVIDIA on FreeBSD website.

Accepting as docs to avoid the confusion over misclick.

Mar 1 2022, 8:05 PM
debdrup closed D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.
Mar 1 2022, 7:59 PM
debdrup committed R9:ae80d7bad0d0: relnotes: Remove references to documentation for !-RELEASE (authored by fel1x.mintchoco.development_gmail.com).
relnotes: Remove references to documentation for !-RELEASE
Mar 1 2022, 7:58 PM
debdrup added a comment to D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.

After you commit this, can you close these related bugzillas? 1 2

Mar 1 2022, 12:38 PM

Feb 28 2022

debdrup added a comment to D34385: Update Apple descriptions in the handbook..

I think my suggestion is generic enough to give an indication of the amount of code used, without making it appear like a big portion of the code is taken from FreeBSD (which is a pretty common myth).

Feb 28 2022, 12:31 PM

Feb 27 2022

debdrup accepted D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.

I'll accept as docs and wait for releng, then I'll commit once it's been accepted by them.

Feb 27 2022, 9:04 PM
debdrup added a comment to D34385: Update Apple descriptions in the handbook..

To add to what I said before, they've gotten pretty good at publishing what they include, if you can make head or tails of their snapshot release style.

Feb 27 2022, 8:53 PM
debdrup added a comment to D34385: Update Apple descriptions in the handbook..

I'm not sure I like this change, because without mentioning Mac OS X/macOS (the latter of which should probably be used), there's a lot more information to cover about the links between macOS and the Apple OSS distribution collection which includes XNU (where parts of the code enumerated here come from FreeBSD, because they originally came from BSD out of CSRG), along with the userland and the toolchain, libraries - and it's really not the FreeBSDs responsibility to keep track of all of that.

Feb 27 2022, 8:50 PM
debdrup added a comment to D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.

My name is 'Minsoo Choo', and email is 'fel1x.mintchoco.development@gmail.com'.
And I have a question. Can I change my email in my previous commits if I change my email address for development?(I'm considering to use ProtonMail)

Feb 27 2022, 8:34 PM
debdrup added a comment to D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.

While waiting for @releng to approve this, I'd like to know what you'd like to have listed as the author?
Usually it's in the form of git commit --author "Givenname Familyname <user AT example.org>".

Feb 27 2022, 5:15 PM
debdrup added inline comments to D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.
Feb 27 2022, 11:44 AM
debdrup accepted D30350: acpiconf(8): Add libxo(3) support.

Manual page change looks good to me.

Feb 27 2022, 11:38 AM

Feb 24 2022

debdrup added a comment to D34360: ctf: Add definitions for CTFv3.

What about changes to src/share/man/man5/ctf.5?

Feb 24 2022, 11:42 AM

Feb 18 2022

debdrup added inline comments to D33275: Add a manual page for boottrace.
Feb 18 2022, 8:28 PM

Feb 16 2022

debdrup accepted D34169: freebsd-update.8: Document CreateBootEnv.

Looks good to me :)

Feb 16 2022, 4:33 PM

Feb 14 2022

debdrup accepted D34100: handbook: Misc fixes to Introduction chapter.

I think this is ready to land now? So far as I can see everything's been addressed and a one-over didn't make anything else stand out.

Feb 14 2022, 5:17 PM

Feb 13 2022

debdrup added a comment to D34259: Report I/O stats from the CAM_IOSCHED_DYNAMIC extension.

Please run igor and mandoc -Tlint on the manual page - because among other things that they check for, I see that .Dd isn't bumped.

Feb 13 2022, 11:45 AM

Feb 11 2022

debdrup accepted D32978: cleankernel: A target to delete the kernel compile file.

Looks good to me, though the summary (and thereby, the commit) should be "there's times". :)

Feb 11 2022, 5:31 PM

Feb 7 2022

debdrup added a comment to D34169: freebsd-update.8: Document CreateBootEnv.

Other than the nit and the question of when it should be pushed, this change looks good to me.

Feb 7 2022, 1:23 PM

Feb 3 2022

debdrup accepted D34100: handbook: Misc fixes to Introduction chapter.

I think this is ready to go now?

Feb 3 2022, 7:22 PM
debdrup accepted D34139: tcpsso, a tool to set socket options for TCP endpoints via the command line.

OK from manpages then. :)

Feb 3 2022, 12:27 PM
debdrup added a comment to D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

Have you run mandoc -Tlint and igor on the manual page?

Feb 3 2022, 12:01 PM
debdrup added a comment to D34139: tcpsso, a tool to set socket options for TCP endpoints via the command line.

mandoc -Tlint shows a few nits that I'd like to see corrected before this is committed.

Feb 3 2022, 11:58 AM
debdrup accepted D34154: Disallow setting of ECN bits with setsockopt().

mdoc changes look good to me

Feb 3 2022, 11:50 AM

Feb 2 2022

debdrup added a comment to D33275: Add a manual page for boottrace.

I made some comments here - but it looks to me like both my comments have or will be addressed shortly?

Feb 2 2022, 3:31 PM
debdrup accepted D34128: filemon: Reject FILEMON_SET_FD commands when the fd is a kqueue.

Manual page changes look good to me, can't comment on the code.

Feb 2 2022, 8:01 AM

Jan 31 2022

debdrup added inline comments to D31929: boottrace(1): small wrapper utility.
Jan 31 2022, 6:53 PM
debdrup updated subscribers of D34099: Add GNU/Linux instructions.
In D34099#771267, @pauamma_gundo.com wrote:

ObMeta; I can't make edit suggestions on this review as the button is missing from inline comments for some reason.

Jan 31 2022, 6:14 PM