- User Since
- Jan 12 2018, 3:33 PM (140 w, 5 d)
Jul 29 2020
Jul 28 2020
Fix errant newline
Jul 18 2020
Jul 17 2020
Wordsmith the sentente to match behaviour described in r318443
Jul 16 2020
Jul 14 2020
Here's a few nits I noticed.
Jul 11 2020
Welp, I screwed up.
Fix a tiny issue about characters not being allowed in /bin/sh
At the request of @allanjude, I'm commandeering this to make a little change so that sysrc doesn't try to operate on files it can't work on.
Jul 5 2020
Comma use looks good to me.
Jun 26 2020
Well, an actual doc persons opinion is more valuable than mine, so I defer :)
I'm not completely sure about .It Va, but the Va macro is not documented in mandoc(7) and only appears in some openbsd mandoc.samples man-page which doesn't seem to be connected to their or our build, where it's referenced as a variable.
.Ql also isn't documented in mandoc(7), however it's a quoted literal according to groff_mdoc(7) from textproc/groff, so I think it's fine.
Jun 23 2020
Fix .Dd nit and nc path nit.
Add comment explaining what the example achieves, add nc(1) to SEE ALSO section
Use -N to close nc again after the file has EOF'd.
Jun 20 2020
Looks marklar to me!
Jun 14 2020
Aside from these two nits, I think it would be best to do s/a\.out/progname/g as a.out is only supported via COMPAT_43 on FreeBSD, and - as far as I know - isn't used anymore. This also has the added benefit of bringing it in line with the example used just above the section where a.out is currently mentioned.
Jun 13 2020
Jun 12 2020
I've been using this script for about a week, and it does exactly what it says on the tin.
Since devfs.conf only gets read on boot, I think handling this script via devd is the perfect way to handle devices that can disappear and reappear.
Jun 9 2020
Looks good to me :)
Jun 6 2020
Minor nit, that I'm not absolutely sure about.
I thought I had run lint, but you've pretty much proved I didn't. My apologies, and deep thanks.
Jun 5 2020
I wonder if it would be appropriate to ask @woodsb02 whether his instructions on https://wiki.freebsd.org/BenWoods/DebuggingPorts could be added as a section of this handbook page, or perhaps a note made about it instructing the user to look at the wiki? It seems very appropriate, as otherwise, people might not know how to get debugging symbols for third party programs supplied by ports.
Additionally, should there also be a section noting that debugging symbols for -RELEASE is included in the base-dbg and kernel-dbg distribution sets available on all installation media but -bootonly and -memdisk-mini images? People building from source might also need to be directed towards the appropriate page.
May 24 2020
Did you mean to add some reviewers for this too? :)
Looks like @rwatson might have some thoughts on this :)
May 16 2020
Minor nits only.
May 14 2020
Thank you very much :)
May 13 2020
For what it's worth (not much, since I'm not yet a doc commiter), the manual page looks good.
Remove BUGS section
May 12 2020
Add licese, taken from commiters guide and bump .Dd
May 11 2020
Bumping this, in the hopes it doesn't get lost.
May 4 2020
Adding the diff via the website apparently accepts the key, whereas php-arcanist fails silently.
Apr 18 2020
Syntactically and lexicographically, this makes sense to me.
As to whether it matters kernel-defined behavior, that's outside my area of expertise.
Apr 16 2020
For compatibility's sake, I think using <br /> (ie. a space between r and forward-slash) is better.
Some older browsers require and while newer browsers seem to do fine with either, they certainly don't complain.
Apr 15 2020
Cross-reference man-pages listed in this document
I must've missed .Fx on a separate line the first time around.
Fix .Fx macro to be on its own line
Apr 14 2020
Replace Xr with Nm as it, at least in less, bolds the commands making it easier to read.
Glad to have so many reviews :)
Remove ministat, add stat, remove erroneous comma, wordsmithed the history section, and addressed issue to clarify that FreeBSD base contains more than just man-pages.
I believe I've addressed the issues.
Address typo, .Fx, macro usage, s/Cm/Xr/g, capitalization, inconsistent period, and wordsmithed a bit.
There is a generated html file of the first version of the man-page available here.
Apr 12 2020
I was unsure about bumping the $FreeBSD line so I opted not to.
Is there documentation for when it should be updated?
I already did correcting and typo passes when commiting/merging these to the freebsd/freebsd-quarterly github repo, so it has my implicit approval. :)
Apr 11 2020
Looks good to me now.
Apr 7 2020
For the entire document, please do s/screenreader-friendly/screen-reader friendly/g so that it uses the same verbiage.
Mar 26 2020
According to mdoc(7), the .Li macro is deprecated - should Ql be used instead?
Feb 27 2020
Anyone who's still using tcsh after all these years might recognize that export is a Bourne shell thing - but it's absolutely vital that it's documented in case new people come along.
Feb 25 2020
I don't wish to cause unnecessary noise, but it seems the accepted-status got lost in bumping things, so I'm wondering if you lost track of this review as I did?
Feb 13 2020
I hope it's okay that I'm (apparently) combining two reviews into one? Or should I resubmit on each? I thought arc could handle multiple outstanding reviews, but apparently not.
Added recently discovered filename tag around /dev
Feb 10 2020
Looks good to me, but I'll defer to other people to approve.
You might also wanna check with igor, as mentioned on IRC.
Feb 8 2020
Add some examples as suggested by cress.
Feb 3 2020
When you get around to it, you're welcome to commit this - as I don't have src access. :)
Edited the date of the man-page.
Jan 15 2020
I think it might be a good idea to add the docs group as reviewers for this.
Jan 5 2020
Dec 29 2019
Feel free to commit at your leisure then - since I still don't have svn access, just project membership (that I need to get setup).
Oct 26 2019
If the VM high watermark levels are tweaked, OOM from ZFS on swap can be entirely avoided. Don't know if this is relevant?
Sep 22 2019
The description of what it does makes sense, although I can't spot if that's actually what the code does.
Sep 6 2019
I think you need to actually add them as reviewers?
Aug 26 2019
The feedback I provided on the git repo has been fixed, so I'm more than happy with this change. I don't have permission to accept nor commit it, though.