Page MenuHomeFreeBSD

debdrup (Daniel Ebdrup)
User

Projects

User Details

User Since
Jan 12 2018, 3:33 PM (210 w, 5 d)

Recent Activity

Yesterday

debdrup accepted D30984: man(1): Add full search (-K) flag.

I think it's time we land this, as I've been recently reminded just how nice it'd be to have this. :)

Wed, Jan 26, 9:01 AM

Tue, Jan 25

debdrup accepted D33968: handbook: Drop the git mailing lists list from Mirrors.
Tue, Jan 25, 11:58 AM

Sun, Jan 23

debdrup added a comment to D34004: website: Rework the downloads table.

Shouldn't you also be changing things for 12.3-RELEASE?

Sun, Jan 23, 5:07 AM

Sat, Jan 22

debdrup accepted D33982: handbook: Drop duplicated URLs in Mirrors.

Seems fine, but I hope you're checking with nc -z from freefall.f.o if they're working. ;)

Sat, Jan 22, 12:55 AM

Fri, Jan 21

debdrup added a comment to D33968: handbook: Drop the git mailing lists list from Mirrors.

That's fair - perhaps link to it instead?

Fri, Jan 21, 4:45 PM
debdrup added a comment to D33967: handbook: Don't mention svnlite; it's obsolete.

The handbook is as much, if not more, for -RELEASE than it is for -CURRENT - so I'm of the belief that something is in the process of being deprecated when it has been removed in -CURRENT and until it's final existence in the last -RELEASE is end-of-life'd.

Fri, Jan 21, 4:44 PM
debdrup accepted D33965: handbook: drop the "(ftp)" suffixes from the mirrors list.
Fri, Jan 21, 12:05 AM
debdrup accepted D33966: handbook: Don't mention certificates in Mirrors.
Fri, Jan 21, 12:04 AM
debdrup accepted D33967: handbook: Don't mention svnlite; it's obsolete.
Fri, Jan 21, 12:04 AM
debdrup added a comment to D33968: handbook: Drop the git mailing lists list from Mirrors.

I don't think we should be removing references to these mailing lists as I know for a fact that I'm not the only one that uses them or might need them in the future.

Fri, Jan 21, 12:04 AM

Thu, Jan 20

debdrup added a comment to D33963: handbook: Drop nonexistant Bulgarian mirrors.

Have you contacted the hostmaster for the domain, before removing it?

Thu, Jan 20, 4:20 PM

Wed, Jan 19

debdrup accepted D33952: handbook: Split off HTTP mirrors into a separate section.

Looks good to me, but make sure you build- and view-test it in a browser before pushing, please.

Wed, Jan 19, 6:40 PM
debdrup accepted D33948: handbook: Clean up the bits on ext2.
Wed, Jan 19, 6:39 PM
debdrup accepted D33949: handbook: Don't start the Obtaining chapter with snail mail.
Wed, Jan 19, 5:03 PM
debdrup added inline comments to D33948: handbook: Clean up the bits on ext2.
Wed, Jan 19, 5:02 PM

Tue, Jan 18

debdrup accepted D33883: Switch to using drive-supplied timeouts for the sa(4) driver..

Manual page looks good.

Tue, Jan 18, 5:46 PM

Sun, Jan 16

debdrup accepted D33909: handbook: Further tweaks to Linuxulator chapter.

After a40cf4175c901 that you implemented last year, is a privileged prompt necessary, or would it be better to recommend using unprivileged chroot after toggling the sysctl OID?

Sun, Jan 16, 6:32 PM
debdrup accepted D33908: security.7: Minor fixes for ASLR sysctl descriptions.
Sun, Jan 16, 4:02 PM
debdrup accepted D33883: Switch to using drive-supplied timeouts for the sa(4) driver..

I'm gonna go ahead and approve this, and leave the choice of macro up to you prior to when you commit and push. :)

Sun, Jan 16, 2:48 AM

Fri, Jan 14

debdrup committed R10:9f0b56872c1f: carp(4): Make regex additionally match on VLAN interfaces (authored by debdrup).
carp(4): Make regex additionally match on VLAN interfaces
Fri, Jan 14, 8:45 PM
debdrup added a comment to D33883: Switch to using drive-supplied timeouts for the sa(4) driver..

I have a little bit of mdoc(7) feedback.

Fri, Jan 14, 7:14 PM

Tue, Jan 11

debdrup accepted D33738: handbook: Update the first chunk of Linuxulator chapter.

With my final 2 nitpicks, I think it is. Approve at will once they're addressed.

Tue, Jan 11, 5:34 PM
debdrup accepted D33842: linux: Make compat.linux.preserve_vstatus default to 1.

mdoc(7) changes look good to me, don't really have opinions on whether it should be the default but it seems like a good idea from a brief look at what termios(4) is.

Tue, Jan 11, 2:20 PM
debdrup added a comment to D33738: handbook: Update the first chunk of Linuxulator chapter.

Is this ready for approval so it can land? It looks to me like it is.

Tue, Jan 11, 2:07 PM
debdrup accepted D33840: man: Remove mention of EXT_RESOURCES.

Looks good to me.

Tue, Jan 11, 2:02 PM
debdrup added a member for manpages: debdrup.
Tue, Jan 11, 2:02 PM

Mon, Jan 10

debdrup accepted D33738: handbook: Update the first chunk of Linuxulator chapter.

Thanks! I wonder, should perhaps igor(1) warn about this, or am I using the wrong tool?

Mon, Jan 10, 4:43 PM
debdrup requested changes to D33738: handbook: Update the first chunk of Linuxulator chapter.

I just noticed one other thing:
The document goes from using one line per sentence to splitting sentences in the middle, which as far as I know causes problems.

Mon, Jan 10, 1:49 PM

Sat, Jan 8

debdrup added a comment to D33677: Mention vendor driver for if_re.

thanks for looking at the patch!

adding a note to the bugs section is prob the most appropriate as we are directing ppl to check out the vendor driver in case they have problems with the in-source one.

Sat, Jan 8, 1:30 PM

Fri, Jan 7

debdrup accepted D33772: linux: More man page tweaks.

You know, I think you're right that it looks better. Do your thing!

Fri, Jan 7, 1:01 PM

Thu, Jan 6

debdrup added a comment to D33772: linux: More man page tweaks.

Only spotted one minor thing which I think is just an honest mistake.

Thu, Jan 6, 3:14 PM

Wed, Jan 5

debdrup added a comment to D33750: handbook: Get rid of "(R)" in "Linux(R)".

Maybe it's worth mentioning that (R) gets rendered by AsciiDoctor as ® as is both outlined here and can be spotted on the rendered output of the existing page.

Wed, Jan 5, 6:32 PM

Tue, Jan 4

debdrup accepted D33733: Add a "bgnow" NFS mount option that causes the mount to go background immediately.

mdoc formatting looks good to me too, but maybe someone else wants to chime in on the code?

Tue, Jan 4, 11:59 AM

Mon, Jan 3

debdrup requested changes to D33677: Mention vendor driver for if_re.

Firstly, please see the Phabricator wiki article for information on how to create a full-context diff - it makes it easier for us to make in-line suggestions.

Mon, Jan 3, 11:17 AM

Sun, Jan 2

debdrup accepted D33720: linux(4): man page tweaks.

Looks good to me too.

Sun, Jan 2, 11:55 PM

Sat, Jan 1

debdrup accepted D33713: iwlwifi: clarify page update.

This looks good to me, and I'm sure bcr approves of you remembering to bump .Dd too ;)

Sat, Jan 1, 7:42 PM

Dec 12 2021

debdrup added a comment to D33394: style.mdoc.5: Document the conventions for -width.
In D33394#755020, @0mp wrote:

Perhaps it would be nice to mention that sometimes the best idea is to set -width to the longest item "of reasonable length" (less than 10 characters?).

Dec 12 2021, 11:40 PM
debdrup accepted D33394: style.mdoc.5: Document the conventions for -width.
Dec 12 2021, 11:39 PM
debdrup added a comment to D33392: handbook: Update the section about Nvidia drivers.

I think it's better to recommend nvidia-modeset, since it should let Xorg use the modesetting driver that's being used for i915kms, radeonkms, and amdgpu.

Dec 12 2021, 11:38 PM

Dec 11 2021

debdrup accepted D33385: intro(3): Fix formatting.

LGTM. :)

Dec 11 2021, 2:47 PM
debdrup accepted D33386: hier(7): add some new Xrs, remove some unrelated ones.

LGTM. :)

Dec 11 2021, 2:47 PM
debdrup added a comment to D20468: if_vether, ported from OpenBSD.

Is something going wrong with some tooling? Because it looks like your diffs are being applied as comments, not to the revision itself?

Dec 11 2021, 2:47 PM

Dec 5 2021

debdrup added a comment to D33275: WIP: Add a manual page for boottrace.

Would it be an idea to refer to this manual page from boot(9), boot(8), and/or some other relevant manual pages - to make it easier to discover?

Dec 5 2021, 11:29 PM
debdrup added inline comments to D20468: if_vether, ported from OpenBSD.
Dec 5 2021, 12:17 PM

Dec 2 2021

debdrup committed R9:fbb8fe55531a: website/docproj: Correct link to wiki article (authored by debdrup).
website/docproj: Correct link to wiki article
Dec 2 2021, 8:02 PM
debdrup accepted D33232: style.mdoc: Prefer Ql to Dq Li for literal display.

LGTM. :)

Dec 2 2021, 5:27 PM

Nov 30 2021

debdrup abandoned D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

This landed with commit bd6dce978c1a, but I forgot to add the differential revision tag.

Nov 30 2021, 1:15 AM
debdrup committed R10:bd6dce978c1a: rc.conf(5): Add _limits, _login_class, and _oomprotect (authored by debdrup).
rc.conf(5): Add _limits, _login_class, and _oomprotect
Nov 30 2021, 1:09 AM

Nov 27 2021

debdrup added inline comments to D33138: elf.5: Document compressed section headers.
Nov 27 2021, 4:08 PM
debdrup added a comment to D33138: elf.5: Document compressed section headers.

I think it'd be nice to get all other functions marked up properly too, unless they're part of display blocks (Bd Ed macros in mdoc).

Nov 27 2021, 3:11 PM

Nov 26 2021

debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Address feedback by PauAmma

Nov 26 2021, 9:40 PM
debdrup retitled D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect from rc.conf(5): Add _limits, _loginclass, and _oomprotect to rc.conf(5): Add _limits, _login_class, and _oomprotect.
Nov 26 2021, 9:40 PM

Nov 22 2021

debdrup added a comment to D31919: Finiding hugo, python, asciidoctor, asciidoctor-pdf, rougify in different platform so users do not need to create symbolic links manually.

The proper way to solve this would be to use /usr/bin/env $BINARY because if that doesn't work, the OS that the tree is being built on isn't POSIX-compliant at all.

Nov 22 2021, 12:23 AM · docs

Nov 18 2021

debdrup accepted D33043: add new entries related to NFS to rc.conf.5.

This looks good to me.

Nov 18 2021, 3:24 PM

Nov 17 2021

debdrup added inline comments to D33031: git-arc: with "create" allow to specify parent of the first commit.
Nov 17 2021, 3:03 PM

Nov 16 2021

debdrup accepted D32976: Initial clean up the language in the manual pages..

There's only one minor nit, but otherwise it looks good to me.

Nov 16 2021, 1:56 PM

Nov 15 2021

debdrup committed R9:d4b1dbdb8347: status: Correct heading levels (authored by debdrup).
status: Correct heading levels
Nov 15 2021, 6:01 PM
debdrup committed R9:999ad0261c59: status: Announce the July-September 2021 status report (authored by debdrup).
status: Announce the July-September 2021 status report
Nov 15 2021, 4:46 PM
debdrup committed R9:041d8d974298: status: Add the third status report for 2021 (authored by debdrup).
status: Add the third status report for 2021
Nov 15 2021, 4:25 PM

Nov 13 2021

debdrup added a comment to D32979: ps(1): let J flag list all jailed processes.

Are there other places where -(j|J) -1 is used to list all jails, instead of simply doing -(j|J)?

Nov 13 2021, 12:39 AM
debdrup added a comment to D32976: Initial clean up the language in the manual pages..

Also, to channel bcr:
Remember to bump .Dd :)

Nov 13 2021, 12:36 AM

Nov 10 2021

debdrup added inline comments to D30012: cp(1): Make -P work without -R as per POSIX.
Nov 10 2021, 11:36 PM

Nov 3 2021

debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Try to address feedback by a.wolk

Nov 3 2021, 2:43 PM

Oct 16 2021

debdrup added a comment to D32299: [docs] Remove i386-wine from docs.

I don't think enough context was included, because I'm still seeing "Context not available" - any chance you can use arcanist from ports/packages (as described on the wiki article I linked earlier) or src/tools/tools/git/git-arc.sh (which can be installed by doing make -C /usr/src/tools/tools/git/ install (which requires arcanist, git, and textproc/jq?

Oct 16 2021, 4:13 PM · docs
debdrup added a comment to D32299: [docs] Remove i386-wine from docs.

Could you please update the diff to one made using the instructions on the Phabricator wiki article?

Oct 16 2021, 10:47 AM · docs

Oct 14 2021

debdrup added a comment to D32485: Porter's handbook: Mention git-format-patch(1) in using git to make patches.

This is only true if you use format-patch?

I believe you need to use git-am(1) to get the metadata (author, timestamps, et cetera) applied.

Oct 14 2021, 10:35 AM

Oct 13 2021

debdrup added a comment to D32476: New man page arswitch(4).

Here's a few things I noticed.

Oct 13 2021, 7:03 AM · docs

Oct 3 2021

debdrup added a comment to D32269: prometheus_sysctl_exporter(8): filter output using a regex.

For the record, the mdoc looks good to me now.
I can't speak to the code.

Oct 3 2021, 7:17 PM
debdrup accepted D32269: prometheus_sysctl_exporter(8): filter output using a regex.
In D32269#728549, @rew wrote:

Which item macros are you referring to?

Oct 3 2021, 7:16 PM
debdrup added a comment to D32269: prometheus_sysctl_exporter(8): filter output using a regex.

Did the item macros disappear by choice? Just checking.

Oct 3 2021, 5:16 PM

Oct 2 2021

debdrup added a comment to D32278: da(4): Add some sysctl descriptions.

Just a minor nit, otherwise it looks good to me.

Oct 2 2021, 10:18 AM
debdrup added a comment to D32269: prometheus_sysctl_exporter(8): filter output using a regex.

I noticed that there are several places where a phrase is entirely or almost entirely repeated, and in my experience that's the sort of thing that makes it hard to scan through a manual page quickly - so I think it might be a good idea to rephrase things a bit.
Ideally I'd also really like to see the words include and exclude be used, as they're the kind of keywords that one would look for when dealing with this kind of thing.

Oct 2 2021, 9:19 AM

Sep 29 2021

debdrup added a watcher for manpages: debdrup.
Sep 29 2021, 9:14 PM
debdrup accepted D32213: freebsd-src-lsp: fix bear '--append' flag.

LGTM. :)

Sep 29 2021, 12:34 PM

Sep 3 2021

debdrup accepted D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

I've given it another once-over, and am pretty happy with it, so unless anyone else has any interjections, I say it's good to go.

Sep 3 2021, 11:46 AM · ZFS

Aug 30 2021

debdrup added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
In D31707#715576, @bcr wrote:

That's right. My understanding is that everything is a dataset unless it was created by "zfs create -V ...", which for me is a volume (and used in this way). As you said, it may change or even blur some more with future changes. My idea is to use them consistently, for example mention datasets everywhere when it comes to ZFS features. When involving mountpoints, I'd refer to file systems, like this: "Mount the dataset as a file system into the directory tree." That way, we use it only when necessary, but keep the dataset syntax. Same when it involves volumes.

Aug 30 2021, 2:27 PM · ZFS

Aug 29 2021

debdrup added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
In D31707#715576, @bcr wrote:

Maybe one more reason to use dataset more to avoid this ambiguity? ;-)

Aug 29 2021, 2:14 PM · ZFS

Aug 28 2021

debdrup added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

These are a few things I spotted, but I'm not sure I caught everything and I'm on the wrong side of entirely sober. :)

Aug 28 2021, 8:30 PM · ZFS
debdrup added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Can you switch this diff to one with context? It makes it easier to make suggestions. :)

Aug 28 2021, 4:02 PM · ZFS

Aug 16 2021

debdrup added a comment to D30703: add gone_in.9.

Just some minor nits.

Aug 16 2021, 8:51 PM

Jul 24 2021

debdrup committed R9:bcfca170d353: status: Add second quarter report to index (authored by debdrup).
status: Add second quarter report to index
Jul 24 2021, 10:23 AM
debdrup committed R9:72e8866aef18: status: Fix include path (authored by debdrup).
status: Fix include path
Jul 24 2021, 7:45 AM
debdrup committed R9:4409b133e33f: status: Fix off-by-one error (authored by debdrup).
status: Fix off-by-one error
Jul 24 2021, 7:23 AM
debdrup committed R9:f3d95f113dac: news: Add entry for April-June 2021 Status Report (authored by debdrup).
news: Add entry for April-June 2021 Status Report
Jul 24 2021, 7:23 AM
debdrup committed R9:16f48fcdc9fd: status/README: Update instructions to reflect reality (authored by debdrup).
status/README: Update instructions to reflect reality
Jul 24 2021, 7:23 AM
debdrup committed R9:f62dd74286cc: status: Change due date to match next report (authored by debdrup).
status: Change due date to match next report
Jul 24 2021, 7:23 AM

Jul 23 2021

debdrup committed R9:22d8dce4d69c: status: Fix issues with double entry and off-by-one error (authored by debdrup).
status: Fix issues with double entry and off-by-one error
Jul 23 2021, 6:59 PM

Jul 22 2021

debdrup committed R9:6a54f4a06121: status: Add the April-July 2021 status report (authored by debdrup).
status: Add the April-July 2021 status report
Jul 22 2021, 2:10 PM

Jun 29 2021

debdrup resigned from D30938: handbook/cutting_edge: document the n-number.

I clearly shouldn't review things when I'm tired. Sorry. :(

Jun 29 2021, 4:02 PM
debdrup accepted D30938: handbook/cutting_edge: document the n-number.

Seems like an excellent idea.

Jun 29 2021, 3:32 PM

Jun 11 2021

debdrup accepted D30739: Move the developer-centric bits from handbook/mirrors to committers-guide.
Jun 11 2021, 6:41 PM
debdrup added a comment to D28062: UPDATING: Change update procedure to use etcupdate(8) over mergemaster(8).

I don't really have time for this right now, so someone else can go ahead and commit it once it's been accepted.

Jun 11 2021, 4:30 PM

Jun 1 2021

debdrup added a comment to D30589: git: document how to merge a pull request from github..
In D30589#687207, @imp wrote:

I don't like the passive voice, due to forced conditioning in high school Freshman English.... however, I know that's the style here...

Jun 1 2021, 7:38 PM
debdrup added a comment to D30589: git: document how to merge a pull request from github..

The documentation team prefers to avoid use of 'you' in the handbook (and any other documentation).

Jun 1 2021, 7:22 AM

May 18 2021

debdrup added a comment to D30334: protect.1: document existence of _oomprotect.

Have you tested with textproc/igor and mandoc -T lint?

May 18 2021, 4:37 PM · manpages, docs
debdrup added a comment to D30336: rc.subr.8: document argument_cmd override pitfalls.

Updated the raw diff using the git show -U999999 <commit-hash> > change.diff method. Hope that helps! :)

May 18 2021, 4:32 PM · manpages, docs
debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Address feedback by 0mp

May 18 2021, 4:04 PM
debdrup added a comment to D30336: rc.subr.8: document argument_cmd override pitfalls.

The current diff you've uploaded lacks context for Phabricator to tell which part of the file it applies to (I don't know why Phabricator can't always figure out the context), which is why the "Context not available" message appears.

May 18 2021, 4:02 PM · manpages, docs
debdrup added a comment to D30334: protect.1: document existence of _oomprotect.

Yes, it would be good to have a documented method of checking the protected flag, so go ahead and add that.

May 18 2021, 2:30 PM · manpages, docs
debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Fix cross reference

May 18 2021, 2:08 PM