Page MenuHomeFreeBSD

debdrup (Daniel Ebdrup)
User

Projects

User Details

User Since
Jan 12 2018, 3:33 PM (203 w, 4 d)

Recent Activity

Sun, Dec 5

debdrup added a comment to D33275: WIP: Add a manual page for boottrace.

Would it be an idea to refer to this manual page from boot(9), boot(8), and/or some other relevant manual pages - to make it easier to discover?

Sun, Dec 5, 11:29 PM
debdrup added inline comments to D20468: if_vether, ported from OpenBSD.
Sun, Dec 5, 12:17 PM

Thu, Dec 2

debdrup committed R9:fbb8fe55531a: website/docproj: Correct link to wiki article (authored by debdrup).
website/docproj: Correct link to wiki article
Thu, Dec 2, 8:02 PM
debdrup accepted D33232: style.mdoc: Prefer Ql to Dq Li for literal display.

LGTM. :)

Thu, Dec 2, 5:27 PM

Tue, Nov 30

debdrup abandoned D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

This landed with commit bd6dce978c1a, but I forgot to add the differential revision tag.

Tue, Nov 30, 1:15 AM
debdrup committed R10:bd6dce978c1a: rc.conf(5): Add _limits, _login_class, and _oomprotect (authored by debdrup).
rc.conf(5): Add _limits, _login_class, and _oomprotect
Tue, Nov 30, 1:09 AM

Sat, Nov 27

debdrup added inline comments to D33138: elf.5: Document compressed section headers.
Sat, Nov 27, 4:08 PM
debdrup added a comment to D33138: elf.5: Document compressed section headers.

I think it'd be nice to get all other functions marked up properly too, unless they're part of display blocks (Bd Ed macros in mdoc).

Sat, Nov 27, 3:11 PM

Fri, Nov 26

debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Address feedback by PauAmma

Fri, Nov 26, 9:40 PM
debdrup retitled D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect from rc.conf(5): Add _limits, _loginclass, and _oomprotect to rc.conf(5): Add _limits, _login_class, and _oomprotect.
Fri, Nov 26, 9:40 PM

Mon, Nov 22

debdrup added a comment to D31919: Finiding hugo, python, asciidoctor, asciidoctor-pdf, rougify in different platform so users do not need to create symbolic links manually.

The proper way to solve this would be to use /usr/bin/env $BINARY because if that doesn't work, the OS that the tree is being built on isn't POSIX-compliant at all.

Mon, Nov 22, 12:23 AM · docs

Thu, Nov 18

debdrup accepted D33043: add new entries related to NFS to rc.conf.5.

This looks good to me.

Thu, Nov 18, 3:24 PM

Wed, Nov 17

debdrup added inline comments to D33031: git-arc: with "create" allow to specify parent of the first commit.
Wed, Nov 17, 3:03 PM

Tue, Nov 16

debdrup accepted D32976: Initial clean up the language in the manual pages..

There's only one minor nit, but otherwise it looks good to me.

Tue, Nov 16, 1:56 PM

Mon, Nov 15

debdrup committed R9:d4b1dbdb8347: status: Correct heading levels (authored by debdrup).
status: Correct heading levels
Mon, Nov 15, 6:01 PM
debdrup committed R9:999ad0261c59: status: Announce the July-September 2021 status report (authored by debdrup).
status: Announce the July-September 2021 status report
Mon, Nov 15, 4:46 PM
debdrup committed R9:041d8d974298: status: Add the third status report for 2021 (authored by debdrup).
status: Add the third status report for 2021
Mon, Nov 15, 4:25 PM

Sat, Nov 13

debdrup added a comment to D32979: ps(1): let J flag list all jailed processes.

Are there other places where -(j|J) -1 is used to list all jails, instead of simply doing -(j|J)?

Sat, Nov 13, 12:39 AM
debdrup added a comment to D32976: Initial clean up the language in the manual pages..

Also, to channel bcr:
Remember to bump .Dd :)

Sat, Nov 13, 12:36 AM

Wed, Nov 10

debdrup added inline comments to D30012: cp(1): Make -P work without -R as per POSIX.
Wed, Nov 10, 11:36 PM

Nov 3 2021

debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Try to address feedback by a.wolk

Nov 3 2021, 2:43 PM

Oct 16 2021

debdrup added a comment to D32299: [docs] Remove i386-wine from docs.

I don't think enough context was included, because I'm still seeing "Context not available" - any chance you can use arcanist from ports/packages (as described on the wiki article I linked earlier) or src/tools/tools/git/git-arc.sh (which can be installed by doing make -C /usr/src/tools/tools/git/ install (which requires arcanist, git, and textproc/jq?

Oct 16 2021, 4:13 PM · docs
debdrup added a comment to D32299: [docs] Remove i386-wine from docs.

Could you please update the diff to one made using the instructions on the Phabricator wiki article?

Oct 16 2021, 10:47 AM · docs

Oct 14 2021

debdrup added a comment to D32485: Porter's handbook: Mention git-format-patch(1) in using git to make patches.

This is only true if you use format-patch?

I believe you need to use git-am(1) to get the metadata (author, timestamps, et cetera) applied.

Oct 14 2021, 10:35 AM

Oct 13 2021

debdrup added a comment to D32476: New man page arswitch(4).

Here's a few things I noticed.

Oct 13 2021, 7:03 AM · docs

Oct 3 2021

debdrup added a comment to D32269: prometheus_sysctl_exporter(8): filter output using a regex.

For the record, the mdoc looks good to me now.
I can't speak to the code.

Oct 3 2021, 7:17 PM
debdrup accepted D32269: prometheus_sysctl_exporter(8): filter output using a regex.
In D32269#728549, @rew wrote:

Which item macros are you referring to?

Oct 3 2021, 7:16 PM
debdrup added a comment to D32269: prometheus_sysctl_exporter(8): filter output using a regex.

Did the item macros disappear by choice? Just checking.

Oct 3 2021, 5:16 PM

Oct 2 2021

debdrup added a comment to D32278: da(4): Add some sysctl descriptions.

Just a minor nit, otherwise it looks good to me.

Oct 2 2021, 10:18 AM
debdrup added a comment to D32269: prometheus_sysctl_exporter(8): filter output using a regex.

I noticed that there are several places where a phrase is entirely or almost entirely repeated, and in my experience that's the sort of thing that makes it hard to scan through a manual page quickly - so I think it might be a good idea to rephrase things a bit.
Ideally I'd also really like to see the words include and exclude be used, as they're the kind of keywords that one would look for when dealing with this kind of thing.

Oct 2 2021, 9:19 AM

Sep 29 2021

debdrup added a watcher for manpages: debdrup.
Sep 29 2021, 9:14 PM
debdrup accepted D32213: freebsd-src-lsp: fix bear '--append' flag.

LGTM. :)

Sep 29 2021, 12:34 PM

Sep 3 2021

debdrup accepted D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

I've given it another once-over, and am pretty happy with it, so unless anyone else has any interjections, I say it's good to go.

Sep 3 2021, 11:46 AM · ZFS

Aug 30 2021

debdrup added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
In D31707#715576, @bcr wrote:

That's right. My understanding is that everything is a dataset unless it was created by "zfs create -V ...", which for me is a volume (and used in this way). As you said, it may change or even blur some more with future changes. My idea is to use them consistently, for example mention datasets everywhere when it comes to ZFS features. When involving mountpoints, I'd refer to file systems, like this: "Mount the dataset as a file system into the directory tree." That way, we use it only when necessary, but keep the dataset syntax. Same when it involves volumes.

Aug 30 2021, 2:27 PM · ZFS

Aug 29 2021

debdrup added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.
In D31707#715576, @bcr wrote:

Maybe one more reason to use dataset more to avoid this ambiguity? ;-)

Aug 29 2021, 2:14 PM · ZFS

Aug 28 2021

debdrup added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

These are a few things I spotted, but I'm not sure I caught everything and I'm on the wrong side of entirely sober. :)

Aug 28 2021, 8:30 PM · ZFS
debdrup added a comment to D31707: Convert ZFS chapter to active voice and remove weasel/unnecessary words.

Can you switch this diff to one with context? It makes it easier to make suggestions. :)

Aug 28 2021, 4:02 PM · ZFS

Aug 16 2021

debdrup added a comment to D30703: add gone_in.9.

Just some minor nits.

Aug 16 2021, 8:51 PM

Jul 24 2021

debdrup committed R9:bcfca170d353: status: Add second quarter report to index (authored by debdrup).
status: Add second quarter report to index
Jul 24 2021, 10:23 AM
debdrup committed R9:72e8866aef18: status: Fix include path (authored by debdrup).
status: Fix include path
Jul 24 2021, 7:45 AM
debdrup committed R9:4409b133e33f: status: Fix off-by-one error (authored by debdrup).
status: Fix off-by-one error
Jul 24 2021, 7:23 AM
debdrup committed R9:f3d95f113dac: news: Add entry for April-June 2021 Status Report (authored by debdrup).
news: Add entry for April-June 2021 Status Report
Jul 24 2021, 7:23 AM
debdrup committed R9:16f48fcdc9fd: status/README: Update instructions to reflect reality (authored by debdrup).
status/README: Update instructions to reflect reality
Jul 24 2021, 7:23 AM
debdrup committed R9:f62dd74286cc: status: Change due date to match next report (authored by debdrup).
status: Change due date to match next report
Jul 24 2021, 7:23 AM

Jul 23 2021

debdrup committed R9:22d8dce4d69c: status: Fix issues with double entry and off-by-one error (authored by debdrup).
status: Fix issues with double entry and off-by-one error
Jul 23 2021, 6:59 PM

Jul 22 2021

debdrup committed R9:6a54f4a06121: status: Add the April-July 2021 status report (authored by debdrup).
status: Add the April-July 2021 status report
Jul 22 2021, 2:10 PM

Jun 29 2021

debdrup resigned from D30938: handbook/cutting_edge: document the n-number.

I clearly shouldn't review things when I'm tired. Sorry. :(

Jun 29 2021, 4:02 PM
debdrup accepted D30938: handbook/cutting_edge: document the n-number.

Seems like an excellent idea.

Jun 29 2021, 3:32 PM

Jun 11 2021

debdrup accepted D30739: Move the developer-centric bits from handbook/mirrors to committers-guide.
Jun 11 2021, 6:41 PM
debdrup added a comment to D28062: UPDATING: Change update procedure to use etcupdate(8) over mergemaster(8).

I don't really have time for this right now, so someone else can go ahead and commit it once it's been accepted.

Jun 11 2021, 4:30 PM

Jun 1 2021

debdrup added a comment to D30589: git: document how to merge a pull request from github..
In D30589#687207, @imp wrote:

I don't like the passive voice, due to forced conditioning in high school Freshman English.... however, I know that's the style here...

Jun 1 2021, 7:38 PM
debdrup added a comment to D30589: git: document how to merge a pull request from github..

The documentation team prefers to avoid use of 'you' in the handbook (and any other documentation).

Jun 1 2021, 7:22 AM

May 18 2021

debdrup added a comment to D30334: protect.1: document existence of _oomprotect.

Have you tested with textproc/igor and mandoc -T lint?

May 18 2021, 4:37 PM · manpages, docs
debdrup added a comment to D30336: rc.subr.8: document argument_cmd override pitfalls.

Updated the raw diff using the git show -U999999 <commit-hash> > change.diff method. Hope that helps! :)

May 18 2021, 4:32 PM · manpages, docs
debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Address feedback by 0mp

May 18 2021, 4:04 PM
debdrup added a comment to D30336: rc.subr.8: document argument_cmd override pitfalls.

The current diff you've uploaded lacks context for Phabricator to tell which part of the file it applies to (I don't know why Phabricator can't always figure out the context), which is why the "Context not available" message appears.

May 18 2021, 4:02 PM · manpages, docs
debdrup added a comment to D30334: protect.1: document existence of _oomprotect.

Yes, it would be good to have a documented method of checking the protected flag, so go ahead and add that.

May 18 2021, 2:30 PM · manpages, docs
debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Fix cross reference

May 18 2021, 2:08 PM
debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Address feedback by ceri

May 18 2021, 2:06 PM
debdrup added a comment to D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.
In D30330#681159, @ceri wrote:

One last nit, sorry - could you sort these alphabetically, with _limits and _login_class above _nice and _oomprotect after it?

May 18 2021, 2:01 PM
debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Address feedback by ceri and Adam Wolk

May 18 2021, 1:31 PM
debdrup added a comment to D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

I found out the hard way, that an rc script overriding start_cmd ignores some mechanisms. This may be by design. Those ignored are at the least:

  • _oomprotect
  • _user
  • _limits
  • _fib
  • _chdir
  • _nice

Unfortunately, some ports like PostgreSQL redefine start_cmd which would make _oomprotect="ALL" silently not work for the database. I am not sure where it would be a good place, but I think it would be worthwhile to document that redefining ${name}_cmd has such a pitfall.

May 18 2021, 1:30 PM
debdrup updated the test plan for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.
May 18 2021, 12:53 PM
debdrup requested review of D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.
May 18 2021, 12:52 PM

May 12 2021

debdrup accepted D30161: documentation/Makefile: add requirements target.
May 12 2021, 5:14 PM
debdrup added a comment to D30161: documentation/Makefile: add requirements target.

Looks good to me, let's get this commited.

May 12 2021, 5:14 PM

May 7 2021

debdrup added a comment to D30161: documentation/Makefile: add requirements target.

I think it would be better to check for the individual component parts, as @ygy suggests, and if any of them aren't found, recommend installing ports/textproc/docproj - but only print the error message once, even if multiple dependencies aren't found.

May 7 2021, 3:08 PM

May 5 2021

debdrup committed R9:2bbfb011a29e: status: Announce the January-March 2021 status report (authored by debdrup).
status: Announce the January-March 2021 status report
May 5 2021, 11:47 PM

May 1 2021

debdrup committed R9:7e8ef67b718a: status: Add the 2021q1 status report (authored by debdrup).
status: Add the 2021q1 status report
May 1 2021, 6:04 PM
debdrup committed R9:1a966ab954ad: status: Bump deadline for new submissions (authored by debdrup).
status: Bump deadline for new submissions
May 1 2021, 6:04 PM

Apr 28 2021

debdrup added a comment to D30004: Add sections to the handbook on cpu frequency control.

[source,shell] would indicate that a particular section using monospaced blocked text is a shell script.

Apr 28 2021, 8:00 AM

Apr 24 2021

debdrup added a comment to D28609: textproc/docproj: Add required dependencies of the new documentation tree.

@dbaio Since it has been approved by a ports commiter (you), doceng (bcr), and a doc commiter (me), can I go ahead and commit this to the ports tree, or do you want to?

Apr 24 2021, 7:36 AM

Apr 23 2021

debdrup added a comment to D28609: textproc/docproj: Add required dependencies of the new documentation tree.

I will note that PDF is mentioned as an optional part in the FDP quickstart, but I don't think it's going worth holding up the review over this.

Apr 23 2021, 8:18 AM

Apr 22 2021

debdrup accepted D29919: handbook: Make the Git URL table name more descriptive.
Apr 22 2021, 7:52 AM

Apr 16 2021

debdrup accepted D29786: books/fdp-primer: Fix pdf build command.

Yes please!

Apr 16 2021, 7:20 AM
debdrup accepted D29717: books/porters-handbook: Add a note about portsmon out of service.
Apr 16 2021, 7:18 AM

Apr 12 2021

debdrup accepted D29715: articles/contributing: Update ports resources.
Apr 12 2021, 2:04 PM

Apr 11 2021

debdrup accepted D29702: route(8): Add an example how to print the routing tables.
Apr 11 2021, 2:54 PM
debdrup accepted D29704: Fixup formatting for the routing work..

Adding a bunch of spaces doesn't need much approval, but have some anyway. :)

Apr 11 2021, 2:44 PM

Apr 10 2021

debdrup added a comment to D29275: Relnotes/13.0: Add routing work description.

Only one tiny nit left, then you can go ahead and commit it with Approved by: debdrup

Apr 10 2021, 12:44 PM
debdrup accepted D29275: Relnotes/13.0: Add routing work description.

Looks good to me now, go ahead and commit with Approved by: debdrup

Apr 10 2021, 12:06 PM

Apr 5 2021

debdrup accepted D29570: Update the "Choosing an Architecture" text.
Apr 5 2021, 10:26 AM

Mar 31 2021

debdrup committed R10:646bae45e102: fortune/freebsd-tips: Fix markup and wording (authored by debdrup).
fortune/freebsd-tips: Fix markup and wording
Mar 31 2021, 11:20 AM

Mar 30 2021

debdrup committed R10:c2a39987e6f1: fortune/freebsd-tips: Add a few fortunes (authored by debdrup).
fortune/freebsd-tips: Add a few fortunes
Mar 30 2021, 5:40 PM
debdrup committed R10:547817631948: fortune/freebsd-tips: Remove errant spaces (authored by debdrup).
fortune/freebsd-tips: Remove errant spaces
Mar 30 2021, 5:39 PM
debdrup committed R10:968ad154ce71: fortune/freebsd-tips: Remove bogus fortune (authored by debdrup).
fortune/freebsd-tips: Remove bogus fortune
Mar 30 2021, 5:39 PM
debdrup accepted D29490: Update 13.0 aarch SD card images based on actual filenames.

Looks good to me. :)

Mar 30 2021, 11:26 AM

Mar 26 2021

debdrup closed D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.
Mar 26 2021, 10:01 PM
debdrup committed R9:7859bada6955: handbook/cutting-edge: Recommend etcupdate(8) (authored by driesm).
handbook/cutting-edge: Recommend etcupdate(8)
Mar 26 2021, 10:01 PM

Mar 23 2021

debdrup added a comment to D28609: textproc/docproj: Add required dependencies of the new documentation tree.
In D28609#658423, @driesm.michiels_gmail.com wrote:

I don't understand why the legacy docs are still there. They are not kept up to date as far as I can tell.

Mar 23 2021, 7:42 PM

Mar 22 2021

debdrup committed R9:2bd242be8075: relnotes/13.0: change manul page reference (authored by debdrup).
relnotes/13.0: change manul page reference
Mar 22 2021, 10:21 PM
debdrup closed D29281: Relnotes/13.0: changed AES-NI identification by geli.
Mar 22 2021, 10:21 PM
debdrup committed R9:3cce9c309963: relnotes/13.0: note changed AES-NI identification by geli (authored by freebsd_michael-bueker.de).
relnotes/13.0: note changed AES-NI identification by geli
Mar 22 2021, 10:21 PM

Mar 21 2021

debdrup committed R10:815209920f1d: rc.conf(5): Remove left-over variables (authored by tobias.rehbein_web.de).
rc.conf(5): Remove left-over variables
Mar 21 2021, 12:11 AM

Mar 20 2021

debdrup accepted D29281: Relnotes/13.0: changed AES-NI identification by geli.

Looks good to me.

Mar 20 2021, 10:14 AM

Mar 19 2021

debdrup committed R10:794f9f43c8ab: rc.conf(5): Bump date on .Dd (authored by debdrup).
rc.conf(5): Bump date on .Dd
Mar 19 2021, 3:55 AM

Mar 18 2021

debdrup added a comment to D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

The patch doesn't apply cleanly for me, and it doesn't look like a trivial fix.

Mar 18 2021, 6:03 PM
debdrup committed R10:c39dda81923a: rc.conf(5): Document the 'workstation' firewall_type (authored by tobias.rehbein_web.de).
rc.conf(5): Document the 'workstation' firewall_type
Mar 18 2021, 5:41 PM
debdrup committed R10:21864048f392: inetd.conf: Wordsmith recommendation (authored by debdrup).
inetd.conf: Wordsmith recommendation
Mar 18 2021, 2:22 PM
debdrup accepted D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

The only thing I'd note is that [source,bash] should be [source,shell].

Mar 18 2021, 1:41 PM