User Details
- User Since
- Jan 12 2018, 3:33 PM (356 w, 9 h)
Sep 27 2024
Seems like the latest diff hasn't been uploaded yet, but once it is uploaded, I think this is ready to land?
Sep 9 2024
Please remember to mark this review as abandoned.
Sep 7 2024
Did a pass on the remaining bit that was added, but it's entirely possible I've missed something.
Sep 6 2024
I did a quick first pass since I had a bit of energy remaining.
Sep 4 2024
Jan 29 2024
Jan 9 2024
Jan 6 2024
Dec 22 2023
mdoc(7) syntax looks fine to me.
There are already includes in the file for newsyslog.conf.d/ and the local variant of it.
If I correctly understand how newsyslog works, setting the different values in the include file would override them when the configuration is read by newsyslog?
Dec 7 2023
I think it'd be a good idea to add these as an include - that way, it's easier to enable or disable on a case-by-case basis.
Aug 21 2023
Only spotted two minor nits, but they can be fixed before pushing as they don't have to hold up things.
Jul 21 2023
Spotted some minor nits, but these can be fixed when it's pushed.
Jun 15 2023
Putting aside the debate over the toor user for another time, using it as an example user doesn't seem like the best option, as it's meant to rescue systems.
May 30 2023
I only spotted a minor nit.
May 23 2023
mdoc(7) changes look good to me, can't speak to the code.
Looks good to me.
May 3 2023
Apr 12 2023
Mar 27 2023
Feb 28 2023
To add a bit of context from a conversation on IRC, this review is intended to make it much easier to define jail(8) variables globally at the top of jail.conf(5), you only need to instanciate the name of a jail and optionally some per-jail values.
Feb 21 2023
Please remember to bump .Dd :)
Feb 7 2023
I'm perfectly satisfied with this import, since I've used the sendcalls script and had a hand in crafting the template.
Feb 5 2023
Looks good to me!
Feb 4 2023
Just a few nits that I noticed that may be worth considering.
Feb 3 2023
The mdoc(7) changes look good to me.
Dec 20 2022
Manual page looks good to me, with the exception of one minor nit.
Oct 10 2022
Apologies for taking so long, life got in the way.
Sep 18 2022
Sep 12 2022
Jul 9 2022
I spotted a few nits, but they're not worth holding up the review for as they can be fixed before the commit is pushed.
Jul 5 2022
Other than the question, I'm still happy with the mdoc, so will accept once that's been answered.
Jul 4 2022
Jul 2 2022
I cant immediately spot any other nits with the mdoc, but perhaps you should add a note about when ts(1) was added to FreeBSD in the history section header?
Jun 10 2022
Jun 8 2022
I don't think there's anything else I remarked on that needs to be addressed, so if everyone else would accept it if theirs has been dealt with, we can get the needful done.
Jun 6 2022
As for the change, it looks good to me - but as I'm sure you know, you need extra approval too. ;)
Jun 4 2022
I've made some suggestions for where various entries belong, but that's about it I think.
May 27 2022
mdoc(7) syntax looks good to me, so once the other issues pointed out with the manual page have been fixed, I'm happy to accept it.
May 23 2022
I'm happy with mdoc(7) syntax since .Dd was bumped ;)
Looks good to go, go ahead and commit @imp
May 8 2022
mdoc looks good to me.
May 7 2022
.Dd also needs to be bumped.
Apr 22 2022
mdoc(7) looks good to me, but please remember to bump .Dd before you commit. :)
Apr 21 2022
I think it's ready to go now, and the summary should work better as a descriptive commit message. :)
You're absolutely right, -P means parsable, whereas -p means properties.
You should probably explain that in the commit log, though - may I edit the summary?
Apr 19 2022
Looks good to me, so assuming it builds, you're good to go. :)
For one-sentence-per-line changes, we generally like to keep them as separate commits.
However, I think it's okay for this commit since you're changing so little.
Apr 18 2022
Ss, like Sh, should be capitalized according to mdoc(7).
Looks good to me.
Apr 13 2022
I'd prefer if you used .Sy or .Em rather than capitalization.
Apr 12 2022
Apr 11 2022
I apologize deeply for losing track of this one (and the change to rc.subr(8), although I think I managed to address that one).
I ended up documenting this in bd6dce978c1, I believe - can you confirm?
Apr 9 2022
Manual page syntax looks good, but it'd be nice to have a mention of the timing in the HISTORY section.
Apr 7 2022
Have you run the manual page through mandoc -Tlint and igor from textproc/igor?
Manual page looks good to me, but please remember to bump .Dd before pushing. ;)
Apr 5 2022
Apr 2 2022
Apr 1 2022
Manual page looks good to me from a syntax perspective, and I wasn't able to spot any other issues.
Please run mandoc -Tlint and igor on the manual page, you'll see that there's a few minor nits that need to be fixed.
Mar 24 2022
Syntax looks good, and it matches what I remember of my CCIE Wireless courses.
Looks good to me.
Mar 23 2022
Commandeering this now that @rpokala has approved it on IRC.
mdoc syntax hasn't really changed and .Dd has been bumped, so this can be commited and pushed.
Mar 22 2022
There are also some lines that exceed 80 characters in width, so the manual page needs to be rewrapped.
Mar 20 2022
I only spotted one minor nit, so I'll accept this and you can commit and push at your convenience after you've fixed it.
Mar 16 2022
Looks good to me.
Mar 15 2022
Looks good to me.
A nice little addition to have. :)
Manual page looks good, I'll let others review the code.
Looks good to me.
I only noticed one thing in the mdoc syntax.
Mar 14 2022
My initial pass of it looks good, but consider waiting for someone else to look over it too.
Mar 13 2022
The mdoc syntax looks good to me.
Mar 9 2022
A tiny nit with the mdoc syntax, otherwise it looks good to me.
I think you should add the "nearly" qualifier to identical, as saying they're identical and then mentioning an exception seems contradictory to me.
Manual page changes look good to me.
Mar 8 2022
Please remember to bump .Dd on pf.conf.5 - other than that, manual page looks fine.
Mar 4 2022
Mar 3 2022
I spotted one thing in the manual page, otherwise it looks good to me.