In D28264#632315, @jrtc27 wrote:

Ah, I hadn't twigged that it was going read-only so far in advance of the migration. The error message is technically correct I guess, needs a doceng approval, and this kind of thing is a bit of a special case.

In D28264#632202, @jrtc27 wrote:

Don't know if I'm supposed to be able to push with a Reviewed by: + Approved by: debdrup, or if something just hates me, but I get "FATAL: VREF/APPROVERS-CHECK/doc: helper program exit status 65280", so could you please commit this for me?

Looks good to me, thank you for your attention to detail. :)

From a manual page point of view, this looks good to me.

Interacting with kyau, the test suite, is described here on the wiki.

In D28248#631871, @pauamma_gundo.com wrote:

Haven't run it through xmllint or igor yet, I first wanted to get a substantive review on my first draft. I will do so before submitting a 2nd draft, although perhaps I should wait to hear from Carlavilla before doing that. What's their username here?

Looks good to me now. :)

Just a few nits, otherwise it looks good to me. :)

Have you checked with xmllint?

Address feedback from 0mp

Address feedback by 0mp

Address feedback by PauAmma

Address feedback from PauAmma.

Address feedback by PauAmma.

Address feedback from PauAmma.

Addressed feedback from PauAmma.

Remember that we're in 2021 now

Bump future deadline

Fix whitespace issues

Fix whitespaces

You might also consider adding this, below the EXAMPLES section header:
".Sh COMPATABILITY
The
.Va allow.dying
parameter has been deprecated and doesn't work like it used to, but is still supported."

Here's a few nits I noticed.
Otherwise, it looks good to me.

In D28091#627733, @jrtc27 wrote:

Hm, my instinct would be to make it include GENERIC-MMCCAM instead and then turn of debugging, especially given the name.

Looks good to me (but that's not surprising, since it's just trimming). :)

I noticed @grehan is missing from this review, but is attached to the others - is that intentional?

I think you've addressed all the feedback and had approvals from everyone attached ;)

Do I remember wrong, or does Zstd also offer the option to adaptively compress at as high a level as possible while maintaining bandwidth, or is that only for zfs send|receive? If so, should that also be mentioned?

For something as specific as kerberos, I think it makes sense to link to the internet archive of the page, rather than getting rid of the link as it's not typically something that people would easily find on their own.

Looks good to me, too. :)

How about something like:

<para>Spell-checking with fully-featured dictionaries is encouraged, and can
  be accomplished by using <package>textproc/hunspell</package> or
  <package>textproc/aspell</package> combined with
  <package>textproc/en-hunspell</package> or
  <package>textproc/en-aspell</package>, respectively.</para>

Would it make sense to mention hunspell/aspell too? While igor does do some spellchecking, it does so on a rather limited set of words defined in the init_spellingerrors function.

Reattach text that was accidentally cut off

Fix wording and alphabetically list cross-references

In D27033#608294, @lbartoletti wrote:

And youtube-dl is back

In D27033#603653, @bapt wrote:

First this has nothing to do with BINARY_ALIAS it tries to import a python module and fails, it does not tries to find a binary in the path.

Second youtube-dl is not dead, they just made a release downloadable at https://youtube-dl.org/

In D27033#603441, @tcberner wrote:

www/py-pafy will require some care:

Traceback (most recent call last):
  File "/wrkdirs/usr/ports/www/py-pafy/work-py38/pafy-0.5.5/pafy/pafy.py", line 51, in <module>
    import youtube_dl
ModuleNotFoundError: No module named 'youtube_dl'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 13, in <module>
    from pafy import __version__
  File "/wrkdirs/usr/ports/www/py-pafy/work-py38/pafy-0.5.5/pafy/__init__.py", line 7, in <module>
    from .pafy import new
  File "/wrkdirs/usr/ports/www/py-pafy/work-py38/pafy-0.5.5/pafy/pafy.py", line 54, in <module>
    raise ImportError(
ImportError: pafy: youtube-dl not found; you can use the internal backend by setting the environmental variable PAFY_BACKEND to "internal". It is not enabled by default because it is not as well maintained as the youtube-dl backend.
*** Error code 1

Address feedback

Approved with gusto :)

Approved :)

This is an exceptionally good idea that I should have thought of, since I've been following the calendar discussion on the mailing lists.
However, the dates aren't quite right - the "new" official deadlines are listed in ./doc/en_US.ISO8859-1/htdocs/news/status/README and basically amount to being the last day of a given quarter (barring the exception for late reports and portmgr@).

I don't know how that snuck in, but it's gone. :)

Squash errant whitespace

Fix news entry