Page MenuHomeFreeBSD

debdrup (Daniel Ebdrup)
User

Projects

User Details

User Since
Jan 12 2018, 3:33 PM (179 w, 5 h)

Recent Activity

Fri, Jun 11

debdrup accepted D30739: Move the developer-centric bits from handbook/mirrors to committers-guide.
Fri, Jun 11, 6:41 PM
debdrup added a comment to D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).

I don't really have time for this right now, so someone else can go ahead and commit it once it's been accepted.

Fri, Jun 11, 4:30 PM

Tue, Jun 1

debdrup added a comment to D30589: git: document how to merge a pull request from github..
In D30589#687207, @imp wrote:

I don't like the passive voice, due to forced conditioning in high school Freshman English.... however, I know that's the style here...

Tue, Jun 1, 7:38 PM
debdrup added a comment to D30589: git: document how to merge a pull request from github..

The documentation team prefers to avoid use of 'you' in the handbook (and any other documentation).

Tue, Jun 1, 7:22 AM

May 18 2021

debdrup added a comment to D30334: protect.1: document existence of _oomprotect.

Have you tested with textproc/igor and mandoc -T lint?

May 18 2021, 4:37 PM · manpages, docs
debdrup added a comment to D30336: rc.subr.8: document argument_cmd override pitfalls.

Updated the raw diff using the git show -U999999 <commit-hash> > change.diff method. Hope that helps! :)

May 18 2021, 4:32 PM · manpages, docs
debdrup updated the diff for D30330: rc.conf(5): Add _limits, _loginclass, and _oomprotect.

Address feedback by 0mp

May 18 2021, 4:04 PM
debdrup added a comment to D30336: rc.subr.8: document argument_cmd override pitfalls.

The current diff you've uploaded lacks context for Phabricator to tell which part of the file it applies to (I don't know why Phabricator can't always figure out the context), which is why the "Context not available" message appears.

May 18 2021, 4:02 PM · manpages, docs
debdrup added a comment to D30334: protect.1: document existence of _oomprotect.

Yes, it would be good to have a documented method of checking the protected flag, so go ahead and add that.

May 18 2021, 2:30 PM · manpages, docs
debdrup updated the diff for D30330: rc.conf(5): Add _limits, _loginclass, and _oomprotect.

Fix cross reference

May 18 2021, 2:08 PM
debdrup updated the diff for D30330: rc.conf(5): Add _limits, _loginclass, and _oomprotect.

Address feedback by ceri

May 18 2021, 2:06 PM
debdrup added a comment to D30330: rc.conf(5): Add _limits, _loginclass, and _oomprotect.
In D30330#681159, @ceri wrote:

One last nit, sorry - could you sort these alphabetically, with _limits and _login_class above _nice and _oomprotect after it?

May 18 2021, 2:01 PM
debdrup updated the diff for D30330: rc.conf(5): Add _limits, _loginclass, and _oomprotect.

Address feedback by ceri and Adam Wolk

May 18 2021, 1:31 PM
debdrup added a comment to D30330: rc.conf(5): Add _limits, _loginclass, and _oomprotect.

I found out the hard way, that an rc script overriding start_cmd ignores some mechanisms. This may be by design. Those ignored are at the least:

  • _oomprotect
  • _user
  • _limits
  • _fib
  • _chdir
  • _nice

Unfortunately, some ports like PostgreSQL redefine start_cmd which would make _oomprotect="ALL" silently not work for the database. I am not sure where it would be a good place, but I think it would be worthwhile to document that redefining ${name}_cmd has such a pitfall.

May 18 2021, 1:30 PM
debdrup updated the test plan for D30330: rc.conf(5): Add _limits, _loginclass, and _oomprotect.
May 18 2021, 12:53 PM
debdrup requested review of D30330: rc.conf(5): Add _limits, _loginclass, and _oomprotect.
May 18 2021, 12:52 PM

May 12 2021

debdrup accepted D30161: documentation/Makefile: add requirements target.
May 12 2021, 5:14 PM
debdrup added a comment to D30161: documentation/Makefile: add requirements target.

Looks good to me, let's get this commited.

May 12 2021, 5:14 PM

May 7 2021

debdrup added a comment to D30161: documentation/Makefile: add requirements target.

I think it would be better to check for the individual component parts, as @ygy suggests, and if any of them aren't found, recommend installing ports/textproc/docproj - but only print the error message once, even if multiple dependencies aren't found.

May 7 2021, 3:08 PM

May 5 2021

debdrup committed R9:2bbfb011a29e: status: Announce the January-March 2021 status report (authored by debdrup).
status: Announce the January-March 2021 status report
May 5 2021, 11:47 PM

May 1 2021

debdrup committed R9:7e8ef67b718a: status: Add the 2021q1 status report (authored by debdrup).
status: Add the 2021q1 status report
May 1 2021, 6:04 PM
debdrup committed R9:1a966ab954ad: status: Bump deadline for new submissions (authored by debdrup).
status: Bump deadline for new submissions
May 1 2021, 6:04 PM

Apr 28 2021

debdrup added a comment to D30004: Add sections to the handbook on cpu frequency control.

[source,shell] would indicate that a particular section using monospaced blocked text is a shell script.

Apr 28 2021, 8:00 AM

Apr 24 2021

debdrup added a comment to D28609: textproc/docproj: Add required dependencies of the new documentation tree.

@dbaio Since it has been approved by a ports commiter (you), doceng (bcr), and a doc commiter (me), can I go ahead and commit this to the ports tree, or do you want to?

Apr 24 2021, 7:36 AM

Apr 23 2021

debdrup added a comment to D28609: textproc/docproj: Add required dependencies of the new documentation tree.

I will note that PDF is mentioned as an optional part in the FDP quickstart, but I don't think it's going worth holding up the review over this.

Apr 23 2021, 8:18 AM

Apr 22 2021

debdrup accepted D29919: handbook: Make the Git URL table name more descriptive.
Apr 22 2021, 7:52 AM

Apr 16 2021

debdrup accepted D29786: books/fdp-primer: Fix pdf build command.

Yes please!

Apr 16 2021, 7:20 AM
debdrup accepted D29717: books/porters-handbook: Add a note about portsmon out of service.
Apr 16 2021, 7:18 AM

Apr 12 2021

debdrup accepted D29715: articles/contributing: Update ports resources.
Apr 12 2021, 2:04 PM

Apr 11 2021

debdrup accepted D29702: route(8): Add an example how to print the routing tables.
Apr 11 2021, 2:54 PM
debdrup accepted D29704: Fixup formatting for the routing work..

Adding a bunch of spaces doesn't need much approval, but have some anyway. :)

Apr 11 2021, 2:44 PM

Apr 10 2021

debdrup added a comment to D29275: Relnotes/13.0: Add routing work description.

Only one tiny nit left, then you can go ahead and commit it with Approved by: debdrup

Apr 10 2021, 12:44 PM
debdrup accepted D29275: Relnotes/13.0: Add routing work description.

Looks good to me now, go ahead and commit with Approved by: debdrup

Apr 10 2021, 12:06 PM

Apr 5 2021

debdrup accepted D29570: Update the "Choosing an Architecture" text.
Apr 5 2021, 10:26 AM

Mar 31 2021

debdrup committed R10:646bae45e102: fortune/freebsd-tips: Fix markup and wording (authored by debdrup).
fortune/freebsd-tips: Fix markup and wording
Mar 31 2021, 11:20 AM

Mar 30 2021

debdrup committed R10:c2a39987e6f1: fortune/freebsd-tips: Add a few fortunes (authored by debdrup).
fortune/freebsd-tips: Add a few fortunes
Mar 30 2021, 5:40 PM
debdrup committed R10:547817631948: fortune/freebsd-tips: Remove errant spaces (authored by debdrup).
fortune/freebsd-tips: Remove errant spaces
Mar 30 2021, 5:39 PM
debdrup committed R10:968ad154ce71: fortune/freebsd-tips: Remove bogus fortune (authored by debdrup).
fortune/freebsd-tips: Remove bogus fortune
Mar 30 2021, 5:39 PM
debdrup accepted D29490: Update 13.0 aarch SD card images based on actual filenames.

Looks good to me. :)

Mar 30 2021, 11:26 AM

Mar 26 2021

debdrup closed D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.
Mar 26 2021, 10:01 PM
debdrup committed R9:7859bada6955: handbook/cutting-edge: Recommend etcupdate(8) (authored by driesm.michiels_gmail.com).
handbook/cutting-edge: Recommend etcupdate(8)
Mar 26 2021, 10:01 PM

Mar 23 2021

debdrup added a comment to D28609: textproc/docproj: Add required dependencies of the new documentation tree.

I don't understand why the legacy docs are still there. They are not kept up to date as far as I can tell.

Mar 23 2021, 7:42 PM

Mar 22 2021

debdrup committed R9:2bd242be8075: relnotes/13.0: change manul page reference (authored by debdrup).
relnotes/13.0: change manul page reference
Mar 22 2021, 10:21 PM
debdrup closed D29281: Relnotes/13.0: changed AES-NI identification by geli.
Mar 22 2021, 10:21 PM
debdrup committed R9:3cce9c309963: relnotes/13.0: note changed AES-NI identification by geli (authored by freebsd_michael-bueker.de).
relnotes/13.0: note changed AES-NI identification by geli
Mar 22 2021, 10:21 PM

Mar 21 2021

debdrup committed R10:815209920f1d: rc.conf(5): Remove left-over variables (authored by tobias.rehbein_web.de).
rc.conf(5): Remove left-over variables
Mar 21 2021, 12:11 AM

Mar 20 2021

debdrup accepted D29281: Relnotes/13.0: changed AES-NI identification by geli.

Looks good to me.

Mar 20 2021, 10:14 AM

Mar 19 2021

debdrup committed R10:794f9f43c8ab: rc.conf(5): Bump date on .Dd (authored by debdrup).
rc.conf(5): Bump date on .Dd
Mar 19 2021, 3:55 AM

Mar 18 2021

debdrup added a comment to D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

The patch doesn't apply cleanly for me, and it doesn't look like a trivial fix.

Mar 18 2021, 6:03 PM
debdrup committed R10:c39dda81923a: rc.conf(5): Document the 'workstation' firewall_type (authored by tobias.rehbein_web.de).
rc.conf(5): Document the 'workstation' firewall_type
Mar 18 2021, 5:41 PM
debdrup committed R10:21864048f392: inetd.conf: Wordsmith recommendation (authored by debdrup).
inetd.conf: Wordsmith recommendation
Mar 18 2021, 2:22 PM
debdrup accepted D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

The only thing I'd note is that [source,bash] should be [source,shell].

Mar 18 2021, 1:41 PM

Mar 16 2021

debdrup added a comment to D29285: Alternative formatting on freebsd/developer/* blocks.

I would also suggest adding a link to https://wiki.freebsd.org/IRC/Cloaks, as that explains the requirements, et cetera.

Mar 16 2021, 5:46 PM
debdrup accepted D29285: Alternative formatting on freebsd/developer/* blocks.

Once you've tested that it looks good, with make -C /usr/doc/documentation (run|build), you're welcome to go ahead and commit this. :)

Mar 16 2021, 1:47 PM

Mar 15 2021

debdrup accepted D29278: Use the man: keyword instead of {{< manpage >}}..
In D29278#655642, @jhb wrote:

Honestly, I had written most of the next change using the old syntax and then saw this in some new changes when I rebased. I already had in my mind to ask for a shorter syntax as the old one is pretty verbose, especially compared to the old SGML entities we had for DocBook. The man: keyword is quite nice though and is as compact as the old style.

Mar 15 2021, 11:57 PM
debdrup added a comment to D29281: Relnotes/13.0: changed AES-NI identification by geli.

Can you find a commit hash for this changed behaviour?

Mar 15 2021, 11:30 PM
debdrup added a comment to D29278: Use the man: keyword instead of {{< manpage >}}..

Nevermind, just after I wrote that, I remembered something.
It's implemented using doc/shared/lib/ManPageMacro/extension.rb

Mar 15 2021, 11:08 PM
debdrup updated subscribers of D29278: Use the man: keyword instead of {{< manpage >}}..

I'm not an asciidoc expert, do we have some local docs for these?

Mar 15 2021, 11:06 PM
debdrup added a comment to D29275: Relnotes/13.0: Add routing work description.

I'm unsure about inlining commit hashes or revisions, so I think @gjb will have to weigh in on whether commit hashes should be referenced at the end like it's done with other things mentioned in the release notes.
I'm more partial to this, as this is how release notes have always looked, but I'm not against the change, as long as it's uniform across the whole document.

Mar 15 2021, 11:00 PM
debdrup added a comment to D29257: A few notes on new routing stack..

The author of the feature has added D29275 which was being worked on before this review started?
So it seems like this has been overcome by events.

Mar 15 2021, 10:46 PM
debdrup committed R9:78c640cfbcfa: relnotes/13.0: Fix typo and markup (authored by debdrup).
relnotes/13.0: Fix typo and markup
Mar 15 2021, 1:19 AM
debdrup committed R9:85d4d20558af: relnotes/13.0: Add note about new usbhid driver (authored by debdrup).
relnotes/13.0: Add note about new usbhid driver
Mar 15 2021, 12:55 AM
debdrup added a comment to D29257: A few notes on new routing stack..

I would also highly recommend adding some commit hashes.
If my memory serves, several of the commits involved have information that's relevant in configuring these new features.

Mar 15 2021, 12:24 AM

Mar 14 2021

debdrup added inline comments to D29252: handbook: update mirrors to include git.
Mar 14 2021, 11:16 AM

Mar 13 2021

debdrup added a comment to D29244: Various updates to the 13.0 release notes..
In D29244#654741, @gjb wrote:

Lack of help, in addition to my infamiliarity with asciidoc/hugo, ... well, I am only one person.

Mar 13 2021, 10:32 AM

Mar 9 2021

debdrup accepted D29144: Make author email address follow RFC 5322.

Looks good to me!

Mar 9 2021, 3:33 PM

Mar 7 2021

debdrup added a comment to D28609: textproc/docproj: Add required dependencies of the new documentation tree.

I'll happily give approval for this from docs if it helps this commited.
It's much easier to remember one port than a handful (or having to look them up in the FDP).

Mar 7 2021, 8:25 PM
debdrup accepted D29115: wg(4): Fix an example in the manual page.

Looks good to me.

Mar 7 2021, 7:01 PM

Mar 6 2021

debdrup accepted D28939: development(7): update to reflect Git transition.

Looks good to me now, let's get this landed.

Mar 6 2021, 12:58 PM

Mar 5 2021

debdrup closed D29003: add a release note about VirtIO v1 fixes.
Mar 5 2021, 10:32 PM · docs, releng
debdrup committed R9:b0a8663bb4ef: add a release note about VirtIO v1 fixes (authored by me_igalic.co).
add a release note about VirtIO v1 fixes
Mar 5 2021, 10:32 PM
debdrup closed D29096: Fix typos as requested..
Mar 5 2021, 8:58 PM
debdrup committed R9:adbe84dccb8d: porters-handbook: Fix typos (authored by pauamma_gundo.com).
porters-handbook: Fix typos
Mar 5 2021, 8:58 PM
debdrup requested changes to D29003: add a release note about VirtIO v1 fixes.

I've rephrased it a bit, to avoid multiple sentences which rendered as separate lines when built.

Mar 5 2021, 7:51 AM · docs, releng

Feb 27 2021

debdrup added inline comments to D28939: development(7): update to reflect Git transition.
Feb 27 2021, 3:32 PM

Feb 26 2021

debdrup added a comment to D27656: Add examples to show how to enforce password policy with pam_passwdqc(8) when user password has expired.

More to the point, adding a few lines is not going to waste peoples diskspace as much as you think, as manual pages are compressed when installed.

Feb 26 2021, 9:25 PM
debdrup added a comment to D27656: Add examples to show how to enforce password policy with pam_passwdqc(8) when user password has expired.

My point is that if that's what this change does, it's not evident that that's what it does.

Feb 26 2021, 9:24 PM
debdrup requested changes to D27656: Add examples to show how to enforce password policy with pam_passwdqc(8) when user password has expired.

After talking it over on IRC, I think this needs little more descriptive information as to what the options in the config files do.

Feb 26 2021, 7:33 PM
debdrup committed R10:bc3bba70d834: inetd: Add examples from manual page and other sources (authored by debdrup).
inetd: Add examples from manual page and other sources
Feb 26 2021, 7:08 PM
debdrup closed D28882: inetd: Add examples from manual page and other sources.
Feb 26 2021, 7:07 PM
debdrup added a comment to D28939: development(7): update to reflect Git transition.

I was only going to remark on the gitrepo thing, but that's already had multiple layers of paint, so I shan't belabor the point.

Feb 26 2021, 3:04 PM
debdrup committed R10:1bf86687c2eb: etc/shells: Add a reference to the ftpd manpage (authored by ceri <ceri@submonkey.net>).
etc/shells: Add a reference to the ftpd manpage
Feb 26 2021, 1:12 PM

Feb 25 2021

debdrup added a comment to D28882: inetd: Add examples from manual page and other sources.

I mean, we should do this: https://cgit.freebsd.org/src/commit/?id=655fa04406010e56822802e12bf52f42e333988b to fix in a better way.

Also, what stands for VTI? virtual interface? It's non-trivial to me and maybe we can have its full name?

Feb 25 2021, 6:26 PM
debdrup added a comment to D28882: inetd: Add examples from manual page and other sources.

I somehow feel the better fix is creating if_wg MLINK.

Feb 25 2021, 11:20 AM
debdrup updated the diff for D28882: inetd: Add examples from manual page and other sources.

Address feeeback by @yuripv and @brueffer

Feb 25 2021, 11:20 AM

Feb 24 2021

debdrup updated the summary of D28882: inetd: Add examples from manual page and other sources.
Feb 24 2021, 8:26 PM
debdrup updated the summary of D28882: inetd: Add examples from manual page and other sources.
Feb 24 2021, 8:26 PM
debdrup updated the diff for D28882: inetd: Add examples from manual page and other sources.

Rework review to address outstanding issues with examples

Feb 24 2021, 8:23 PM
debdrup retitled D28882: inetd: Add examples from manual page and other sources from inetd.conf: Add entries for Samba sharing and rsyncd to inetd: Add examples from manual page and other sources.
Feb 24 2021, 8:22 PM
debdrup added a comment to D26123: [handbook] Remove reference to cusueeme.

It's possible Phabricator mangled things.

Feb 24 2021, 6:40 PM
debdrup added a comment to D28882: inetd: Add examples from manual page and other sources.

Just being curious, what's the benefit of running rsyncd through inetd instead of using its standalone daemon?

Feb 24 2021, 10:39 AM
debdrup accepted D28905: committers-guide: update commit trailer descriptions.

I forgot to accept this, didn't I.

Feb 24 2021, 8:43 AM
debdrup accepted D26123: [handbook] Remove reference to cusueeme.

Once these two minor things have been fixed (which can be done before commiting pushing), it looks good to me.

Feb 24 2021, 8:42 AM

Feb 23 2021

debdrup closed D28898: rc.conf(5): Add note about parallel startup variable.
Feb 23 2021, 9:27 PM
debdrup committed R10:408edcca0746: rc.conf(5): Add note about parallel startup variable (authored by debdrup).
rc.conf(5): Add note about parallel startup variable
Feb 23 2021, 9:27 PM
debdrup added a comment to D28905: committers-guide: update commit trailer descriptions.

Just one small thing, and as long as it builds (which it should, from the looks of it), it looks good to me.

Feb 23 2021, 7:44 PM
debdrup committed R10:ef1a1fc7e828: release(7) Fix mistake noted in review (authored by debdrup).
release(7) Fix mistake noted in review
Feb 23 2021, 6:12 PM
debdrup closed D28881: release(7): Remove stray references to DOC* variables.
Feb 23 2021, 6:08 PM
debdrup committed R10:f695e960672d: release(7): Remove stray references to DOC* variables (authored by debdrup).
release(7): Remove stray references to DOC* variables
Feb 23 2021, 6:08 PM
debdrup updated the diff for D28881: release(7): Remove stray references to DOC* variables.

This time actually correct the hash length, pointed out by @lwhsu

Feb 23 2021, 4:39 PM