Details
- Reviewers
salvadore kp - Commits
- R9:47c2526aa8a7: 2023q2 status: add pf report
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| website/content/en/status/report-2023-04-2023-06/pf.adoc | ||
|---|---|---|
| 28 | Should also include Sponsored by: The FreeBSD Foundation for Naman's work. | |
| website/content/en/status/report-2023-04-2023-06/pf.adoc | ||
|---|---|---|
| 3 | Maybe add a brief introduction, like pf is one of the firewalls included in FreeBSD, and is probably the most popular. pf was created by the OpenBSD project and subsequently ported to FreeBSD. | |
| website/content/en/status/report-2023-04-2023-06/pf.adoc | ||
|---|---|---|
| 45 | These should not have the [Dxxxxx] I believe, so that the URL itself is displayed while we want | |
The report needs some work on formatting:
- please use one sentence per line;
- please respect the usual sections sorting (see other reports to find many examples): title, links, contacts, body of the reports, sponsors, if any.
Also please consider adding some references to manual pages where appropriate using the man macro, e.g. man pf[4].
| website/content/en/status/report-2023-04-2023-06/pf.adoc | ||
|---|---|---|
| 45 | Please add a pair of empty brackets [] at the end of each second URL, e.g. link:https://reviews.freebsd.org/D40911[D40911] URL link:https://reviews.freebsd.org/D40911[] + | |
Spotted some minor nits, but these can be fixed when it's pushed.
| website/content/en/status/report-2023-04-2023-06/pf.adoc | ||
|---|---|---|
| 31–32 | AsciiDoc needs a plus at the end of each sentence that's supposed to form part of the same paragraph, but be listed on one line (unless it's in bullet point form). | |
| 41 | Also needs a plus here. | |
| 47–55 | I don't know if it matters, but I think it'd be a good idea to have a space before the plus charracter. Last line doesn't need the plus character. | |
Thanks, a few more changes and I think it is ready.
| website/content/en/status/report-2023-04-2023-06/pf.adoc | ||
|---|---|---|
| 2 | Maybe use a capital P: "Pf Improvements"? | |
| 21 | I suggest using man:pf[4] in the first pf occurrence. | |
| 24 | s/backport/Backport/ Since "Improvements" has been written with a capital "I", probably it woule be better to also write "Syntax" with a capital "S" for consistency. | |
| 27 | s/configration/configuration/ | |
| 29 | ==== pfsync Protocol Versioning or ==== Pfsync Protocol Versioning | |
| 31 | man:pfsync[4] | |
| 34 | ==== pfsync: transport over IPv6 or ==== Pfsync: Transport Over IPv6 | |