Page MenuHomeFreeBSD

cxgbetool(8): cleanup
AcceptedPublic

Authored by yuri_aetern.org on Dec 27 2022, 4:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 10, 2:49 AM
Unknown Object (File)
Wed, May 8, 12:55 AM
Unknown Object (File)
Wed, May 8, 12:55 AM
Unknown Object (File)
Tue, May 7, 8:20 PM
Unknown Object (File)
Wed, May 1, 7:22 PM
Unknown Object (File)
Apr 18 2024, 6:04 AM
Unknown Object (File)
Dec 29 2023, 9:26 PM
Unknown Object (File)
Dec 20 2023, 8:30 AM

Details

Reviewers
np
Group Reviewers
manpages
Summary
  • use Bl -column instead of TS which allows us to use macros inside the table cells
  • fix a lot of other issues reported by mandoc -Tlint
Test Plan

mandoc -Tlint (empty now)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Patched manual page now renders.

Changes other than to tables affect markup only, not text. (I can't tell for changes to tables.)

Adding np@ as it's somewhat "external" man page, want to be sure it won't break the process for vendor.

This man page is still broken.
@np can you take a look at this review, please.

Sorry I missed this previously. This man page has a dependency on groff and I'd like to get rid of it eventually (the dependency, not the man page). But my manpage-fu is weak and I'm not sure how to figure out exactly which parts need groff. Will these proposed changes make any difference as far as reliance on groff goes? Okay to check this in either way.

man cxgbetool

This manpage needs groff(1) to be rendered
First install groff(1):
pkg install groff

This revision is now accepted and ready to land.Apr 12 2023, 3:16 AM
@np wrote:

But my manpage-fu is weak and I'm not sure how to figure out exactly which parts need groff.

I believe it's those table tags:

_
ipv4    T{
.Cm type ipv4
T}      T{
incoming packet is an IPv4 datagram.
T}

Need to convert them to .Bl/.It+Ta/.El, but we'd better ask someone from the manpages to be sure.

Need to convert them to .Bl/.It+Ta/.El, but we'd better ask someone from the manpages to be sure.

Yes, these are the correct macros to use for lists.

If the submitter wants to fix it, I'll be happy to commit it.