Page MenuHomeFreeBSD

freebsd_igalic.co (Mina Galić)
User

Projects

User Details

User Since
Nov 7 2020, 6:11 PM (180 w, 4 d)

Recent Activity

Thu, Apr 18

freebsd_igalic.co added reviewers for D44835: virtio: add scmi to the build system: andrew, bryanv, cristian.marussi_arm.com.
Thu, Apr 18, 11:46 AM
freebsd_igalic.co requested review of D44835: virtio: add scmi to the build system.
Thu, Apr 18, 11:43 AM
freebsd_igalic.co added a comment to D43047: vtscmi: Add a virtio-scmi driver.

I'm a bit late to the party, but is there a reason why this module wasn't hooked into the build system?

Thu, Apr 18, 11:05 AM

Tue, Mar 26

freebsd_igalic.co requested review of D44521: hvsock: make pcb declaration private.
Tue, Mar 26, 10:33 PM
freebsd_igalic.co requested review of D44520: hvsock: remove useless casts, checks & functions.
Tue, Mar 26, 10:33 PM
freebsd_igalic.co requested review of D44519: hvsock: make protosw functions static.
Tue, Mar 26, 10:30 PM
freebsd_igalic.co requested review of D44518: hvsock: Use zfree(9) instead of non-standard bzero(3).
Tue, Mar 26, 10:27 PM
freebsd_igalic.co abandoned D44516: hvsock: fix comments and debug output.

duplicate. Thanks arcanist…

Tue, Mar 26, 10:26 PM
freebsd_igalic.co requested review of D44517: hvsock: fix comments and debug output.
Tue, Mar 26, 10:25 PM
freebsd_igalic.co requested review of D44516: hvsock: fix comments and debug output.
Tue, Mar 26, 10:24 PM

Feb 27 2024

freebsd_igalic.co accepted D44022: Add missing "be"..
Feb 27 2024, 10:44 PM

Jan 26 2024

freebsd_igalic.co updated subscribers of D43624: [2/2] [WIP] Import heimdal 7.8.0.

not to be a total buzzkill, but, have you seen @cy's post on arch about this https://lists.freebsd.org/archives/freebsd-arch/2023-December/000580.html

Jan 26 2024, 11:28 PM · Contributor Reviews (src)

Jan 18 2024

freebsd_igalic.co accepted D42722: handbook: update current version before freebsd-upgrade.
Jan 18 2024, 11:12 PM

Jan 2 2024

freebsd_igalic.co added inline comments to D43239: Use gnu17 for buildkernel.
Jan 2 2024, 7:41 PM · Contributor Reviews (src)

Dec 29 2023

freebsd_igalic.co added a comment to D43232: nanobsd: Revert back to 1G (really 927M) partitions for rescue..

i really hope the title there,

Dec 29 2023, 6:44 PM

Dec 4 2023

freebsd_igalic.co accepted D42893: pkgbase: treat all the kernel packages the same way.
Dec 4 2023, 9:41 AM

Nov 24 2023

freebsd_igalic.co added a comment to D42721: ifconfig: add -D option to print driver name for interface.

I updated comments, but am waiting for more input before making this behavior the default (or something other than -D).

Nov 24 2023, 8:46 PM

Nov 23 2023

freebsd_igalic.co added a comment to D42721: ifconfig: add -D option to print driver name for interface.

I've edited the title summary, to be more explicit about original name vs driver name, so we don't forget about this on commit

Nov 23 2023, 1:56 PM
freebsd_igalic.co retitled D42721: ifconfig: add -D option to print driver name for interface from ifconfig: add -D option to fetch driver/original interface names to ifconfig: add -D option to fetch interface's driver name.
Nov 23 2023, 1:54 PM
freebsd_igalic.co added a comment to D42721: ifconfig: add -D option to print driver name for interface.

I'm still a little worried about script breakage if the default output changes, but we can try it on main to see if there are complaints.

Nov 23 2023, 1:51 PM
freebsd_igalic.co added a comment to D42721: ifconfig: add -D option to print driver name for interface.
In D42721#974727, @kp wrote:

Tools should not attempt to draw conclusions from interface group memberships.

Nov 23 2023, 11:14 AM

Nov 22 2023

freebsd_igalic.co added a comment to D42721: ifconfig: add -D option to print driver name for interface.

General questions:

Nov 22 2023, 6:04 PM

Nov 21 2023

freebsd_igalic.co added a comment to D36259: rc: also run NAME_setup on NAME_reload.

can you show me an example of this in action?
how are you using it in your ports?

Nov 21 2023, 10:04 AM · rc

Nov 17 2023

freebsd_igalic.co added a comment to D42651: pkgbase: create source package.

pr ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268401

Nov 17 2023, 5:44 PM
freebsd_igalic.co added inline comments to D42651: pkgbase: create source package.
Nov 17 2023, 4:44 PM

Nov 14 2023

freebsd_igalic.co added a reviewer for D39895: release: build pkgbase packages if WITH_PKGBASE is set: pkgbase.
Nov 14 2023, 1:48 PM
freebsd_igalic.co added a reviewer for D41873: pkgbase: Move libz and libcrypt from runtime to clibs: pkgbase.
Nov 14 2023, 1:46 PM · pkgbase

Nov 10 2023

freebsd_igalic.co added a comment to D41815: pkgbase: Move headers and libs out of runtime and utilities.

this would've been nice to MFC
bit late for the current release, but there's always a next one

Nov 10 2023, 7:30 PM
freebsd_igalic.co accepted D42544: oomprotect sshd and local_unbound + documentation (incl. syslogd).

👍

Nov 10 2023, 9:09 AM

Nov 2 2023

freebsd_igalic.co accepted D42444: pkgbase: set a default set of kernel for when PACKAGE_BUILDING=1.
Nov 2 2023, 5:24 PM
freebsd_igalic.co added inline comments to D42444: pkgbase: set a default set of kernel for when PACKAGE_BUILDING=1.
Nov 2 2023, 1:28 PM

Oct 5 2023

freebsd_igalic.co added inline comments to D42095: release: Let caroot depend on certctl, not vice versa..
Oct 5 2023, 10:18 PM
freebsd_igalic.co accepted D40530: certctl: invoke with LOCALBASE set.

looks plausible!

Oct 5 2023, 9:58 PM
freebsd_igalic.co added a comment to D40529: certctl.8: document LOCALBASE.

👍 otherwise.

Oct 5 2023, 9:13 PM

Oct 4 2023

freebsd_igalic.co updated the summary of D27161: growfs: make exit codes more consistent.
Oct 4 2023, 10:25 AM
freebsd_igalic.co updated the diff for D27161: growfs: make exit codes more consistent.

update commit message

Oct 4 2023, 10:24 AM

Oct 3 2023

freebsd_igalic.co updated the diff for D27161: growfs: make exit codes more consistent.

s/signaled with/indicated by/g

Oct 3 2023, 2:13 PM
freebsd_igalic.co updated the summary of D27161: growfs: make exit codes more consistent.
Oct 3 2023, 1:50 PM
freebsd_igalic.co updated the diff for D27161: growfs: make exit codes more consistent.

there are no harmless errors (yet)

Oct 3 2023, 1:50 PM
freebsd_igalic.co updated the diff for D27161: growfs: make exit codes more consistent.

never start a sentence with .Nm

Oct 3 2023, 12:58 PM
freebsd_igalic.co updated the diff for D27161: growfs: make exit codes more consistent.

address @PauAmma's review

Oct 3 2023, 12:41 PM

Sep 28 2023

freebsd_igalic.co added reviewers for D42013: porters handbook: make example follow suggestions in text: portmgr, doceng.
Sep 28 2023, 6:33 PM
freebsd_igalic.co requested review of D42013: porters handbook: make example follow suggestions in text.
Sep 28 2023, 5:52 PM

Sep 26 2023

freebsd_igalic.co updated the diff for D41887: domain(9): better link functions to implement a protosw.

address @yurpv's feedback.

Sep 26 2023, 12:53 PM · manpages
freebsd_igalic.co added inline comments to D41949: mailmap: Add pstef and val.
Sep 26 2023, 10:35 AM
freebsd_igalic.co added inline comments to D41851: virtio: start simple, document virtio_endian(9).
Sep 26 2023, 10:27 AM · manpages
freebsd_igalic.co added a comment to D41852: virtio: add man page for virtqueue(9) functions.

I'm very hesitant to consider these - or other virtio methods from other pending reviews - as man "Section 9 - Kernel Interfaces".

Sep 26 2023, 6:17 AM

Sep 25 2023

freebsd_igalic.co added inline comments to D41852: virtio: add man page for virtqueue(9) functions.
Sep 25 2023, 9:29 PM
freebsd_igalic.co added a comment to D41852: virtio: add man page for virtqueue(9) functions.

Thanks for working on this, here's my comments after a first pass.

Sep 25 2023, 9:15 PM
freebsd_igalic.co abandoned D41968: vendor/nvi: fix last left-over K&R function declaration.

a new release was made just today, and @bapt said he'll merge that next week.

Sep 25 2023, 5:28 PM

Sep 24 2023

freebsd_igalic.co retitled D41968: vendor/nvi: fix last left-over K&R function declaration from fix last left-over K&R function declaration (#121) to vendor/nvi: fix last left-over K&R function declaration.
Sep 24 2023, 8:20 PM
freebsd_igalic.co requested review of D41968: vendor/nvi: fix last left-over K&R function declaration.
Sep 24 2023, 8:19 PM

Sep 23 2023

freebsd_igalic.co added reviewers for D41949: mailmap: Add pstef and val: pstef, val_packett.cool.
Sep 23 2023, 8:07 PM
freebsd_igalic.co requested review of D41949: mailmap: Add pstef and val.
Sep 23 2023, 8:07 PM
freebsd_igalic.co added inline comments to D41947: regcomp: use unsigned char when testing for escapes.
Sep 23 2023, 2:10 PM

Sep 22 2023

freebsd_igalic.co added a comment to D41852: virtio: add man page for virtqueue(9) functions.

i believe to now have addressed all of your remarks, @fernape.

Sep 22 2023, 1:17 PM
freebsd_igalic.co updated the diff for D41852: virtio: add man page for virtqueue(9) functions.
Sep 22 2023, 1:16 PM
freebsd_igalic.co added a comment to D41851: virtio: start simple, document virtio_endian(9).

i think this is ready to land now.

Sep 22 2023, 12:56 PM · manpages
freebsd_igalic.co retitled D41851: virtio: start simple, document virtio_endian(9) from virtio: start simple with virtio_endian(9) to virtio: start simple, document virtio_endian(9).
Sep 22 2023, 12:52 PM · manpages
freebsd_igalic.co updated the diff for D41851: virtio: start simple, document virtio_endian(9).
Sep 22 2023, 12:51 PM · manpages

Sep 21 2023

freebsd_igalic.co accepted D41931: Add .mailmap to correct some author data.

fantastic! Thank you!

Sep 21 2023, 6:31 PM
freebsd_igalic.co added a comment to D41853: virtio: add introduction to virtio, document virtio.h.

One additional thing: virtio.9 is not hooked to the build. Could you add it to the Makefile?

Sep 21 2023, 2:20 PM
freebsd_igalic.co added a comment to D41850: virtio: remove virtio_alloc_virtqueues' flags arg.

Should this be MFC'd?
is it it safe?
are there any third-party vendors who might stumble over this API change?

Sep 21 2023, 12:50 PM
freebsd_igalic.co added a comment to D41848: virtio: use bool for boolean functions.

I reckon this commit can easily be MFC'd without causing too much breakage

Sep 21 2023, 12:49 PM

Sep 20 2023

freebsd_igalic.co added a comment to D41920: local-unbound: remove stray config.h.in backup.

now somebody just needs to commit it…

Sep 20 2023, 2:29 PM
freebsd_igalic.co added a comment to D41919: vendor/unbound: ignore *~.

you will have to land this one yourself tho, since I have no commit ;)

Sep 20 2023, 2:28 PM
freebsd_igalic.co updated the diff for D41853: virtio: add introduction to virtio, document virtio.h.

*actually* address @fernape's review

Sep 20 2023, 10:09 AM
freebsd_igalic.co added inline comments to D41853: virtio: add introduction to virtio, document virtio.h.
Sep 20 2023, 10:01 AM
freebsd_igalic.co updated the diff for D41853: virtio: add introduction to virtio, document virtio.h.

address @fernape's review

Sep 20 2023, 10:01 AM

Sep 19 2023

freebsd_igalic.co added reviewers for D41920: local-unbound: remove stray config.h.in backup: cy, delphij, des.
Sep 19 2023, 9:38 PM
freebsd_igalic.co requested review of D41920: local-unbound: remove stray config.h.in backup.
Sep 19 2023, 9:37 PM
freebsd_igalic.co added reviewers for D41919: vendor/unbound: ignore *~: cy, des, delphij.
Sep 19 2023, 9:31 PM
freebsd_igalic.co requested review of D41919: vendor/unbound: ignore *~.
Sep 19 2023, 9:30 PM
freebsd_igalic.co added a comment to D41794: Add mitigations(7) describing our vulnerability mitigations.

lots of mentions of "FreeBSD" in the text. Should we replace that with .Fx?

Sep 19 2023, 8:24 PM
freebsd_igalic.co added reviewers for D41851: virtio: start simple, document virtio_endian(9): alfredo, cperciva, mhorne.

add more reviewers

Sep 19 2023, 3:09 PM · manpages
freebsd_igalic.co added reviewers for D41852: virtio: add man page for virtqueue(9) functions: alfredo, mhorne, cperciva.

add more reviewers

Sep 19 2023, 3:08 PM
freebsd_igalic.co added reviewers for D41853: virtio: add introduction to virtio, document virtio.h: cperciva, mhorne, alfredo.

add more reviewers

Sep 19 2023, 3:06 PM

Sep 18 2023

freebsd_igalic.co updated the diff for D41887: domain(9): better link functions to implement a protosw.

address review from @andrew_tao173.riddles.org.uk

Sep 18 2023, 11:38 AM · manpages

Sep 17 2023

freebsd_igalic.co accepted D41892: pkgbase: Add instructions for upgrading past 78847e1.
Sep 17 2023, 10:19 AM
freebsd_igalic.co added a reviewer for D41892: pkgbase: Add instructions for upgrading past 78847e1: pkgbase.
Sep 17 2023, 10:18 AM

Sep 16 2023

freebsd_igalic.co added a reviewer for D41887: domain(9): better link functions to implement a protosw: manpages.
Sep 16 2023, 1:10 PM · manpages
freebsd_igalic.co requested review of D41887: domain(9): better link functions to implement a protosw.
Sep 16 2023, 1:09 PM · manpages

Sep 15 2023

freebsd_igalic.co added a reviewer for D41853: virtio: add introduction to virtio, document virtio.h: bryanv.
Sep 15 2023, 7:03 AM
freebsd_igalic.co added a reviewer for D41852: virtio: add man page for virtqueue(9) functions: bryanv.
Sep 15 2023, 7:02 AM
freebsd_igalic.co added a reviewer for D41851: virtio: start simple, document virtio_endian(9): bryanv.
Sep 15 2023, 7:01 AM · manpages
freebsd_igalic.co abandoned D41849: virtio: add comment on the spec for vring struct.

aye.
i didn't know Linux virtio headers were bsd licensed.
in fact, I didn't dare look at them for fear i would breach copyright.

Sep 15 2023, 6:56 AM

Sep 14 2023

freebsd_igalic.co added a reviewer for D41861: pkgbase: Split out manpages by default: pkgbase.
Sep 14 2023, 2:53 PM · pkgbase
freebsd_igalic.co added a comment to D41853: virtio: add introduction to virtio, document virtio.h.

thank you for the review @pstef .
This update should address it.

Sep 14 2023, 11:08 AM
freebsd_igalic.co updated the diff for D41853: virtio: add introduction to virtio, document virtio.h.
Sep 14 2023, 11:07 AM
freebsd_igalic.co added a comment to D41852: virtio: add man page for virtqueue(9) functions.

thanks for the review @pstef .
This update should fix it.

Sep 14 2023, 10:55 AM
freebsd_igalic.co updated the diff for D41852: virtio: add man page for virtqueue(9) functions.
Sep 14 2023, 10:54 AM
freebsd_igalic.co added a comment to D41851: virtio: start simple, document virtio_endian(9).

thank you for the review @pstef!
This update addresses your comments.

Sep 14 2023, 10:45 AM · manpages
freebsd_igalic.co updated the diff for D41851: virtio: start simple, document virtio_endian(9).
Sep 14 2023, 10:44 AM · manpages
freebsd_igalic.co updated the diff for D41850: virtio: remove virtio_alloc_virtqueues' flags arg.

thanks to @cognet for catching this rebase botch

Sep 14 2023, 10:37 AM
freebsd_igalic.co updated the diff for D41848: virtio: use bool for boolean functions.

thanks to @cognet for helping catch this rebase fuckup.

Sep 14 2023, 10:33 AM
freebsd_igalic.co added inline comments to D41848: virtio: use bool for boolean functions.
Sep 14 2023, 12:09 AM

Sep 13 2023

freebsd_igalic.co added a comment to D41850: virtio: remove virtio_alloc_virtqueues' flags arg.

remotely related: https://github.com/freebsd/freebsd-src/pull/827

Sep 13 2023, 11:40 PM
freebsd_igalic.co removed a reviewer for D41850: virtio: remove virtio_alloc_virtqueues' flags arg: jrtc27.

removing jrtc27 again, as per IRC, she's:

Sep 13 2023, 11:20 PM
freebsd_igalic.co added a reviewer for D41849: virtio: add comment on the spec for vring struct: bryanv.
Sep 13 2023, 11:18 PM
freebsd_igalic.co added a reviewer for D41848: virtio: use bool for boolean functions: bryanv.
Sep 13 2023, 11:17 PM