In D44520#1015375, @glebius wrote:

…
I'd suggest to split this changeset into 3 separate parts, which actually are unrelated:

• Remove useless SOCK_STREAM checks
• Remove useless casts of so_pcb

I'm a bit late to the party, but is there a reason why this module wasn't hooked into the build system?

duplicate. Thanks arcanist…

not to be a total buzzkill, but, have you seen @cy's post on arch about this https://lists.freebsd.org/archives/freebsd-arch/2023-December/000580.html

i really hope the title there,

In D42721#975425, @karels wrote:

I updated comments, but am waiting for more input before making this behavior the default (or something other than -D).

I've edited the title summary, to be more explicit about original name vs driver name, so we don't forget about this on commit

In D42721#974767, @karels wrote:

I'm still a little worried about script breakage if the default output changes, but we can try it on main to see if there are complaints.

In D42721#974727, @kp wrote:

Tools should not attempt to draw conclusions from interface group memberships.

General questions:

can you show me an example of this in action?
how are you using it in your ports?

pr ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268401

this would've been nice to MFC
bit late for the current release, but there's always a next one

👍

looks plausible!

👍 otherwise.

update commit message

s/signaled with/indicated by/g

there are no harmless errors (yet)

never start a sentence with .Nm

address @PauAmma's review

address @yurpv's feedback.

In D41852#957171, @bryanv wrote:

I'm very hesitant to consider these - or other virtio methods from other pending reviews - as man "Section 9 - Kernel Interfaces".

In D41852#957094, @mhorne wrote:

Thanks for working on this, here's my comments after a first pass.

a new release was made just today, and @bapt said he'll merge that next week.

i believe to now have addressed all of your remarks, @fernape.

i think this is ready to land now.

fantastic! Thank you!

In D41853#955715, @fernape wrote:

One additional thing: virtio.9 is not hooked to the build. Could you add it to the Makefile?

Should this be MFC'd?
is it it safe?
are there any third-party vendors who might stumble over this API change?

I reckon this commit can easily be MFC'd without causing too much breakage

now somebody just needs to commit it…

you will have to land this one yourself tho, since I have no commit ;)

*actually* address @fernape's review

address @fernape's review

lots of mentions of "FreeBSD" in the text. Should we replace that with .Fx?

add more reviewers

add more reviewers

add more reviewers

address review from @andrew_tao173.riddles.org.uk

aye.
i didn't know Linux virtio headers were bsd licensed.
in fact, I didn't dare look at them for fear i would breach copyright.

thank you for the review @pstef .
This update should address it.

thanks for the review @pstef .
This update should fix it.

thank you for the review @pstef!
This update addresses your comments.

thanks to @cognet for catching this rebase botch

thanks to @cognet for helping catch this rebase fuckup.

remotely related: https://github.com/freebsd/freebsd-src/pull/827

removing jrtc27 again, as per IRC, she's: