Page MenuHomeFreeBSD

andrew_tao173.riddles.org.uk (Andrew Gierth)
User

Projects

User Details

User Since
Mar 15 2018, 5:43 AM (271 w, 6 d)

Recent Activity

Fri, May 26

andrew_tao173.riddles.org.uk updated the diff for D40194: Guile ports: remove conflicts and add flavors.

Add remaining guile ports; this should now be complete.

Fri, May 26, 2:54 PM

Tue, May 23

andrew_tao173.riddles.org.uk updated the diff for D40194: Guile ports: remove conflicts and add flavors.

Update with more ports, and improved logic in guile.mk.

Tue, May 23, 11:27 AM

Mon, May 22

andrew_tao173.riddles.org.uk abandoned D24325: New port lang/guile3.

Superseded by https://reviews.freebsd.org/D40194

Mon, May 22, 9:02 AM

Sun, May 21

andrew_tao173.riddles.org.uk added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

so... two years after everyone seems to have accepted it, maybe someone would commit it?

Sun, May 21, 9:12 PM
andrew_tao173.riddles.org.uk requested review of D40194: Guile ports: remove conflicts and add flavors.
Sun, May 21, 8:22 PM

Tue, May 9

andrew_tao173.riddles.org.uk added a comment to D39641: dd: Fix SIGINT handling..

I have to agree with kib here, the right fix is to unblock the signal around open/read/write/close rather than this business with flags.

Tue, May 9, 8:36 AM

Oct 10 2021

andrew_tao173.riddles.org.uk added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

The obvious example is doing this in make.conf:

Oct 10 2021, 6:24 AM
andrew_tao173.riddles.org.uk added inline comments to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..
Oct 10 2021, 6:00 AM

Jun 24 2021

andrew_tao173.riddles.org.uk added a comment to D30880: fsck_ufs: fix background fsck in preen mode.

The whole handling of fsreadfd and fswritefd makes me itch. They are opened and closed at random places, and some places test for them being < 0, but they are not statically initialized to -1 nor set to -1 when closed. I would honestly not be surprised if there were some weird combination of options that caused data blocks to be written to stdin rather than the disk.

Jun 24 2021, 5:35 PM
andrew_tao173.riddles.org.uk requested changes to D30880: fsck_ufs: fix background fsck in preen mode.

As far as I can tell, gjournal_check assumes fswritefd is already open, so this is no good.

Jun 24 2021, 5:51 AM

Feb 12 2021

andrew_tao173.riddles.org.uk added a comment to D28633: lualoader: handle local module errors more gracefully.

Looks basically sane to me.

Feb 12 2021, 11:44 PM

Jan 28 2021

andrew_tao173.riddles.org.uk added a comment to D24325: New port lang/guile3.

The comment about aclocal/guile.m4 file is not relevant anymore?

Jan 28 2021, 10:15 AM

Jan 27 2021

andrew_tao173.riddles.org.uk updated the diff for D24325: New port lang/guile3.

Update to 3.0.5, removing patches that were fixed upstream

Jan 27 2021, 9:33 PM

Jan 17 2021

andrew_tao173.riddles.org.uk updated the summary of D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..
Jan 17 2021, 2:04 AM
andrew_tao173.riddles.org.uk updated the diff for D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

Don't fold case of variable names. Allow using var@ to unset variables, since some places distinguish between empty and undefined values.

Jan 17 2021, 2:01 AM

Jan 4 2021

andrew_tao173.riddles.org.uk abandoned D27847: rc scripts vs. .pkgsave.

Abandoning; Mina has taken this over in D27962

Jan 4 2021, 10:35 PM

Dec 30 2020

andrew_tao173.riddles.org.uk added inline comments to D27847: rc scripts vs. .pkgsave.
Dec 30 2020, 7:21 PM
andrew_tao173.riddles.org.uk requested review of D27847: rc scripts vs. .pkgsave.
Dec 30 2020, 2:46 PM

Dec 13 2020

andrew_tao173.riddles.org.uk accepted D27589: lang/lua54 - Update to 5.4.2.

You could have just put this one on bugzilla with maintainer-approval set on the patch, for a routine update putting it up here seems overkill.

Dec 13 2020, 1:48 AM

Nov 15 2020

andrew_tao173.riddles.org.uk added inline comments to D27223: [2/2] _umtx_op: introduce 32-bit/i386 flags for operations.
Nov 15 2020, 12:45 PM

Nov 9 2020

andrew_tao173.riddles.org.uk requested review of D27154: Add error checks to @shell.
Nov 9 2020, 7:58 PM

Oct 19 2020

andrew_tao173.riddles.org.uk updated the diff for D24325: New port lang/guile3.

Update to 3.0.4 plus cherry-picked JIT fixes for arm.

Oct 19 2020, 8:31 PM

Oct 15 2020

andrew_tao173.riddles.org.uk added a comment to D24430: Update porters handbook for Lua changes.

Any chance of some review or action on this please?

Oct 15 2020, 1:19 PM
andrew_tao173.riddles.org.uk updated the diff for D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

Update to 5.4.1

Oct 15 2020, 1:11 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D25797: lang/lua53 - Correct variable order in Makefile..

Here's one that updates to 5.3.6 and has more extensive changes to variable order that satisfies portclippy, barring the use of a few variables it doesn't know about.

Oct 15 2020, 1:07 PM

Aug 10 2020

andrew_tao173.riddles.org.uk added a comment to D25365: Early WIP: convert login.conf to UCL.

Your login.conf changes need to be rebased against an up-to-date version from current - you're undoing the introduction of the "mail" capability and other changes related to environment vars from D21481.

Aug 10 2020, 7:41 AM

Jul 31 2020

andrew_tao173.riddles.org.uk requested review of D25902: Add warning against leapseconds to src.conf manpage..
Jul 31 2020, 2:44 AM

Jul 27 2020

andrew_tao173.riddles.org.uk updated the diff for D24430: Update porters handbook for Lua changes.

Rewrite to match changes to logic, and extend some parts slightly.

Jul 27 2020, 3:35 AM

Jul 26 2020

andrew_tao173.riddles.org.uk added a comment to D25797: lang/lua53 - Correct variable order in Makefile..

Also PORTREVISION should not be changed if there are no functional changes, since you'd just be forcing rebuilds/updates of every dependent port for no reason.

Jul 26 2020, 4:57 AM
andrew_tao173.riddles.org.uk added a comment to D25797: lang/lua53 - Correct variable order in Makefile..

5.3.6 is imminent, if there's any point at all in doing this cosmetic change then it could at least be folded into that.

Jul 26 2020, 4:56 AM

Jul 25 2020

andrew_tao173.riddles.org.uk accepted D25784: Add `flavors` support to devel/lua-luarocks.
Jul 25 2020, 6:05 AM
andrew_tao173.riddles.org.uk added a comment to D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

Ah, I thought I had mucked something. Shall I restore them?

Jul 25 2020, 6:04 AM · Restricted Project

Jul 24 2020

andrew_tao173.riddles.org.uk added a comment to D25784: Add `flavors` support to devel/lua-luarocks.

I still think it's nuts to install multiple luarocks installations when the big feature of luarocks 3.x was the ability to handle multiple lua versions. But I'll withdraw my objection.

Jul 24 2020, 10:22 PM
andrew_tao173.riddles.org.uk added a comment to D14709: [new port] lang/lua54 - new port for Lua 5.4.0.
  • Removed non-relevant ports packages included by mistake
Jul 24 2020, 9:59 PM · Restricted Project
andrew_tao173.riddles.org.uk requested changes to D25784: Add `flavors` support to devel/lua-luarocks.

What's the justification for adding flavors, given that one luarocks install is supposed to be able to manage multiple lua versions?

When I try installing LuaRocks from ports/pkg I always get 5.2, regardless of the installed version of lua (due to the FreeBSD default Lua version of 5.2). The FreeBSD default means Luarocks is also configured for Lua 5.2 and the executable/script is called luarocks52. Perhaps I've done something wrong and there is an easier way around that, but this seems to perfectly fit the use case for flavors?

Jul 24 2020, 11:58 AM

Jul 23 2020

andrew_tao173.riddles.org.uk added a comment to D25784: Add `flavors` support to devel/lua-luarocks.

I think, in fact, the only useful change would be to install config files for every supported lua version rather than just the default one.

Jul 23 2020, 8:54 PM
andrew_tao173.riddles.org.uk added inline comments to D24492: Change version selection logic in Mk/Uses/lua.mk.
Jul 23 2020, 8:44 PM
andrew_tao173.riddles.org.uk added a comment to D25784: Add `flavors` support to devel/lua-luarocks.

What's the justification for adding flavors, given that one luarocks install is supposed to be able to manage multiple lua versions?

Jul 23 2020, 12:54 PM

Jul 21 2020

andrew_tao173.riddles.org.uk added inline comments to D24492: Change version selection logic in Mk/Uses/lua.mk.
Jul 21 2020, 4:09 PM
andrew_tao173.riddles.org.uk added inline comments to D24492: Change version selection logic in Mk/Uses/lua.mk.
Jul 21 2020, 3:26 PM

Jul 6 2020

andrew_tao173.riddles.org.uk updated the diff for D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.

Updates to address comments.

Jul 6 2020, 2:42 AM

Jun 30 2020

andrew_tao173.riddles.org.uk added a comment to D24492: Change version selection logic in Mk/Uses/lua.mk.

Lua 5.4.0 is now released, so this is now a blocking issue for the lua54 port.

Jun 30 2020, 12:21 AM

Jun 23 2020

andrew_tao173.riddles.org.uk updated the diff for D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

Move to an earlier place in processing (in fact the earliest possible place, just after PKGORIGIN is set).

Jun 23 2020, 3:23 AM

Jun 16 2020

andrew_tao173.riddles.org.uk added a comment to D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.
In D22189#557452, @mat wrote:

Is it possible to have the flavors not conflict with each other? Like, the full flavor only install the bits that are enabled by the options.

Jun 16 2020, 8:30 PM

Jun 5 2020

andrew_tao173.riddles.org.uk accepted D25038: execvPe: obviate the need for potentially large stack allocations.

I think this addresses all of my points.

Jun 5 2020, 5:42 PM
andrew_tao173.riddles.org.uk requested changes to D25038: execvPe: obviate the need for potentially large stack allocations.
Jun 5 2020, 3:15 PM
andrew_tao173.riddles.org.uk added inline comments to D25038: execvPe: obviate the need for potentially large stack allocations.
Jun 5 2020, 10:51 AM
andrew_tao173.riddles.org.uk added a comment to D25038: execvPe: obviate the need for potentially large stack allocations.

Will we be able to wrap this up before the conclusion of the 11.4 release cycle, or is this suddenly going to get bumped into SA status?

It's also not clear to me if we're now-satisfied with the changes, including stack alignment.

Jun 5 2020, 2:07 AM

May 29 2020

andrew_tao173.riddles.org.uk added a comment to D25038: execvPe: obviate the need for potentially large stack allocations.

While at it, would it be worth adding a check that the stack size is at least MINSIGSTKSZ + PATH_MAX ?

When you say 'adding a check', are you proposing a static assert that PSPAWN_STACK_ALIGNMENT at least fits MINSIGSTKSZ + PATH_MAX , or runtime check just before calling rfork_thread()?

May 29 2020, 5:54 PM
andrew_tao173.riddles.org.uk added a comment to D25038: execvPe: obviate the need for potentially large stack allocations.

Adding an EINVAL return to rfork_thread will cause this code to fall through to the "use vfork instead" logic, hiding the error in unexpected ways.

May 29 2020, 5:20 PM
andrew_tao173.riddles.org.uk added inline comments to D25038: execvPe: obviate the need for potentially large stack allocations.
May 29 2020, 4:43 PM
andrew_tao173.riddles.org.uk added inline comments to D25038: execvPe: obviate the need for potentially large stack allocations.
May 29 2020, 3:02 AM

May 28 2020

andrew_tao173.riddles.org.uk added inline comments to D25038: execvPe: obviate the need for potentially large stack allocations.
May 28 2020, 11:56 PM
andrew_tao173.riddles.org.uk accepted D25038: execvPe: obviate the need for potentially large stack allocations.
May 28 2020, 6:57 PM
andrew_tao173.riddles.org.uk added inline comments to D25024: VFS: Track sequential reads and writes separately.
May 28 2020, 1:38 PM

May 27 2020

andrew_tao173.riddles.org.uk added inline comments to D25024: VFS: Track sequential reads and writes separately.
May 27 2020, 2:48 PM

May 23 2020

andrew_tao173.riddles.org.uk added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

Discussion point: this implementation converts the variable name to upper case for consistency with the way that port option_VARS works. But there are some cases where one might want to set a mixed-case name (such as CFLAGS.arch), so maybe it shouldn't do that and just use the case as written?

May 23 2020, 2:09 PM

May 6 2020

andrew_tao173.riddles.org.uk added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

Incidentally, in case it's not obvious, if my addition is moved to before the inclusion of bsd.default-versions.mk then it remains entirely possible to do

May 6 2020, 2:42 AM
andrew_tao173.riddles.org.uk added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

I really like the idea of being able to simply and cleanly set vars for specific ports from /etc/make.conf. I think the choice of variable naming is exactly right here, and the implementation is clean and simple.

However, I am 100% with @mat here that bsd.default-versions.mk is the wrong place for this. The idea is that the things defined in there choose one from a list of conflicting options. If every port is built with ssl=openssl and one port is overridden with ssl=libressl, then it will be impossible to install that port without uninstalling everything else. I can't think of a scenario where any default version should be overridden.

Can you implement this somewhere else, so that default versions are preserved?

May 6 2020, 1:13 AM
andrew_tao173.riddles.org.uk added a comment to D24492: Change version selection logic in Mk/Uses/lua.mk.

Lua 5.4.0 is planned for release next week, it would be nice to have this resolved sometime reasonably soon.

May 6 2020, 12:02 AM

May 5 2020

andrew_tao173.riddles.org.uk added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..
In D24324#543789, @mat wrote:

What difference is there from having either a Makefile.local with whatever you need in the port's directory, or using what everyone has been using for decades:

.if ${.CURDIR:M*/lang/rust*}
DISABLE_MAKE_JOBS=yes
.endif
May 5 2020, 11:41 PM

May 4 2020

andrew_tao173.riddles.org.uk added a comment to D24565: misc/zoneinfo: split BACKWARD into two options for recent/ancient backward compatibility.

Discussion opened upstream at http://mm.icann.org/pipermail/tz/2020-May/028970.html

May 4 2020, 2:39 AM

Apr 27 2020

andrew_tao173.riddles.org.uk added a comment to D24596: vfs: add restrictions to read(2) of a directory.

I don't think there's a great deal of merit in adding this change just to pander to broken apps (it's not like fstat is hard), but I do think it's actually an improvement from a UX perspective (who amongst us has not been annoyed at some point by cat'ing a directory by mistake).

Apr 27 2020, 8:06 PM

Apr 24 2020

andrew_tao173.riddles.org.uk created D24565: misc/zoneinfo: split BACKWARD into two options for recent/ancient backward compatibility.
Apr 24 2020, 9:54 PM

Apr 23 2020

andrew_tao173.riddles.org.uk updated the diff for D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.

I just noticed that the diff here had been replaced by the one from the first commit, so I'm re-uploading the diff of just the uncommitted part for ease of further review.

Apr 23 2020, 8:28 PM

Apr 19 2020

andrew_tao173.riddles.org.uk updated the test plan for D24492: Change version selection logic in Mk/Uses/lua.mk.
Apr 19 2020, 4:15 PM

Apr 18 2020

andrew_tao173.riddles.org.uk created D24492: Change version selection logic in Mk/Uses/lua.mk.
Apr 18 2020, 11:47 PM
andrew_tao173.riddles.org.uk added a comment to D24430: Update porters handbook for Lua changes.

This needs to stay on hold pending the change to the version selection logic discussed on D14709.

Apr 18 2020, 8:54 PM
andrew_tao173.riddles.org.uk added a comment to D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

Others have supported the "closest to default" rule, so I'll put up a separate patch for that.

Apr 18 2020, 8:51 PM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

In my opinion, it's a bug in Mk/Uses/lua.mk that USES=lua:53+ chooses lua 5.4 over 5.3

What alternative logic do you suggest?

Maybe chose the closest from default version that fits the constraints

Apr 18 2020, 7:19 PM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

In my opinion, it's a bug in Mk/Uses/lua.mk that USES=lua:53+ chooses lua 5.4 over 5.3

Apr 18 2020, 6:03 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

Change the two ports that declared themselves lua:53+ to just lua:53, since they don't seem to respond sanely to attempts to force configuration with 5.4 using environment vars.

Apr 18 2020, 5:14 PM · Restricted Project

Apr 17 2020

andrew_tao173.riddles.org.uk updated the diff for D24430: Update porters handbook for Lua changes.

Add a note about avoiding use of XY+ version specifications

Apr 17 2020, 4:46 PM
andrew_tao173.riddles.org.uk added a comment to D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

Should work with patch -p1

Apr 17 2020, 10:53 AM · Restricted Project

Apr 16 2020

andrew_tao173.riddles.org.uk added a comment to D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

Test results: adding support for 5.4 causes only two ports (archivers/urbackup-server and x11-toolkits/termit) to switch from lua 5.3 to 5.4 when LUA_DEFAULT is 5.2. (They would not switch if the default were 5.3; both are declared as lua:53+, and the default version is chosen if it is in range, otherwise the latest available version in the range.)

Apr 16 2020, 7:00 PM · Restricted Project

Apr 15 2020

andrew_tao173.riddles.org.uk updated the diff for D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

Update to lua 5.4.0-rc1

Apr 15 2020, 6:32 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the summary of D24430: Update porters handbook for Lua changes.
Apr 15 2020, 12:07 PM
andrew_tao173.riddles.org.uk created D24430: Update porters handbook for Lua changes.
Apr 15 2020, 12:05 PM
andrew_tao173.riddles.org.uk added a comment to rP531750: - Fix MASTER_SITES to unbreak the fetch.

This should have been fixed in bsd.sites.mk, which would unbreak a bunch of other ports too.

Apr 15 2020, 8:39 AM

Apr 13 2020

andrew_tao173.riddles.org.uk updated the test plan for D16494: Uses/lua.mk - add flavor support and other options.
Apr 13 2020, 8:38 AM · Restricted Project

Apr 11 2020

andrew_tao173.riddles.org.uk added a comment to D24306: Always install backward compatibility timezones, as they are installed on all major Linux distributions as well as NetBSD and OpenBSD..
In D24306#535952, @ngie wrote:

new installs *should* be using the new timezone mappings, so the need for the old ones will die off over time.

Apr 11 2020, 6:34 AM

Apr 10 2020

andrew_tao173.riddles.org.uk added a comment to D24306: Always install backward compatibility timezones, as they are installed on all major Linux distributions as well as NetBSD and OpenBSD..

does not mean we should remove these links.

Apr 10 2020, 4:31 AM

Apr 9 2020

andrew_tao173.riddles.org.uk added a comment to D24306: Always install backward compatibility timezones, as they are installed on all major Linux distributions as well as NetBSD and OpenBSD..

To explain the full context of the original link:

Apr 9 2020, 10:51 AM
andrew_tao173.riddles.org.uk added a comment to D24306: Always install backward compatibility timezones, as they are installed on all major Linux distributions as well as NetBSD and OpenBSD..

I think this change is a bad idea and should be reverted. (The "backward" file in the IANA db is for ancient compatibility, and FreeBSD has been excluding it by default since 1994 as far as I can tell; this is not the time to be adding it back.)

Apr 9 2020, 9:38 AM

Apr 7 2020

andrew_tao173.riddles.org.uk created D24325: New port lang/guile3.
Apr 7 2020, 8:45 AM
andrew_tao173.riddles.org.uk updated the summary of D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..
Apr 7 2020, 6:38 AM
andrew_tao173.riddles.org.uk created D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..
Apr 7 2020, 6:29 AM

Apr 5 2020

andrew_tao173.riddles.org.uk updated the diff for D16494: Uses/lua.mk - add flavor support and other options.

Fix rebase error that caused a deleted file (lua51-iconv/Makefile) to be revived due to a conflicting trunk commit.

Apr 5 2020, 6:26 AM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D16494: Uses/lua.mk - add flavor support and other options.

Ugh, previous diff was reversed. Fix.

Apr 5 2020, 3:57 AM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D16494: Uses/lua.mk - add flavor support and other options.

Rebase. Un-deprecate lua-iconv, because the only thing keeping it broken is the failure to update bsd.sites.mk in a timely manner.

Apr 5 2020, 3:54 AM · Restricted Project

Mar 26 2020

andrew_tao173.riddles.org.uk updated the diff for D16494: Uses/lua.mk - add flavor support and other options.

Rebase. Fix most of mat's requests. Make the usage of LUA_VER / LUA_VER_STR a bit more consistent. Allow for the option of lua:build,run if needed.

Mar 26 2020, 1:55 AM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D16494: Uses/lua.mk - add flavor support and other options.
Mar 26 2020, 12:55 AM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D16494: Uses/lua.mk - add flavor support and other options.
Mar 26 2020, 12:07 AM · Restricted Project

Mar 25 2020

andrew_tao173.riddles.org.uk added inline comments to D16494: Uses/lua.mk - add flavor support and other options.
Mar 25 2020, 2:44 PM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D16494: Uses/lua.mk - add flavor support and other options.

From discussion just after I posted this, it sounds like math/plplot actually needs a PORTREVISION bump not included in this patch.

Mar 25 2020, 12:49 AM · Restricted Project
andrew_tao173.riddles.org.uk updated the summary of D16494: Uses/lua.mk - add flavor support and other options.
Mar 25 2020, 12:39 AM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D16494: Uses/lua.mk - add flavor support and other options.

Rebase and include fixes.

Mar 25 2020, 12:38 AM · Restricted Project

Mar 10 2020

andrew_tao173.riddles.org.uk updated the diff for D16494: Uses/lua.mk - add flavor support and other options.

This one includes the changes to the actual ports, plus fixes to a few issues in lua.mk.

Mar 10 2020, 1:44 AM · Restricted Project

Feb 12 2020

andrew_tao173.riddles.org.uk updated the diff for D23597: Respect PATH from login.conf in cron..

Fix bug in non-LOGIN_CAP case. Update manpage.

Feb 12 2020, 6:48 AM
andrew_tao173.riddles.org.uk added inline comments to D23597: Respect PATH from login.conf in cron..
Feb 12 2020, 6:42 AM