Page MenuHomeFreeBSD

andrew_tao173.riddles.org.uk (Andrew Gierth)
User

Projects

User Details

User Since
Mar 15 2018, 5:43 AM (323 w, 4 d)

Recent Activity

Dec 24 2023

andrew_tao173.riddles.org.uk added inline comments to D42023: Ensure that automount(8) flushes autofs by checking fsid.
Dec 24 2023, 12:37 AM
andrew_tao173.riddles.org.uk added a comment to D42023: Ensure that automount(8) flushes autofs by checking fsid.

Yeah, something's still wrong, looking into it.

Dec 24 2023, 12:22 AM

Oct 17 2023

andrew_tao173.riddles.org.uk accepted D42023: Ensure that automount(8) flushes autofs by checking fsid.

tested, seems to work.

Oct 17 2023, 2:03 PM

Oct 4 2023

andrew_tao173.riddles.org.uk added a comment to D42023: Ensure that automount(8) flushes autofs by checking fsid.
In D42023#959423, @kib wrote:

fsid for MNT_UPDATE call should be taken from the last statfs, I believe

Oct 4 2023, 12:24 AM

Oct 3 2023

andrew_tao173.riddles.org.uk added a comment to D42023: Ensure that automount(8) flushes autofs by checking fsid.

Sent.

Oct 3 2023, 11:24 PM
andrew_tao173.riddles.org.uk requested changes to D42023: Ensure that automount(8) flushes autofs by checking fsid.

The additional check of the fstype in automount.c got lost in this patch; without it, you get a lot of unnecessary errors (since it will log_err for each covered mountpoint)

Oct 3 2023, 10:54 PM

Sep 28 2023

andrew_tao173.riddles.org.uk added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.
In D40961#953488, @kib wrote:

It feels too hackish, in particular the fact that the type is preserved.

Sep 28 2023, 9:18 PM

Sep 27 2023

andrew_tao173.riddles.org.uk added a comment to D41975: net-p2p/transmission: Reorganize as a metaport.

Take a look at devel/git or mail/postfix which override OPTIONS_FILE to allow different options for flavors.

Could you please suggest Makefile line number for devel/git? I don't see that.

Sep 27 2023, 6:01 PM
andrew_tao173.riddles.org.uk added a comment to D41975: net-p2p/transmission: Reorganize as a metaport.

So, initial thoughts on rework:

After carefully reading bsd.options.mk I came to following coclusions (but I may be wrong):

  1. OPTIONS_FILE being crafted from <category>/<portname>, which means we can't really define any options inside flavors, but in root of Makefile only (to prevent overwriting OPTIONS_FILE by different flavors.
Sep 27 2023, 4:09 PM

Aug 25 2023

andrew_tao173.riddles.org.uk added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.

Unless there is any further comment, would someone commit this please? (w/MFC)

Aug 25 2023, 3:12 AM

Aug 14 2023

andrew_tao173.riddles.org.uk added inline comments to D40961: Fix for automount -c inappropriately clearing important mount flags.
Aug 14 2023, 12:05 AM

Aug 13 2023

andrew_tao173.riddles.org.uk added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.

If the kernel patch is applied, is the automount.c change needed?
(Or does the nmount(2) fail with EINVAL?)

Aug 13 2023, 8:04 PM

Aug 12 2023

andrew_tao173.riddles.org.uk added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.
In D40961#943507, @kib wrote:

Am I right that e.g. the following usage is broken by the patch 'as-is' : mount -u -w /?

Aug 12 2023, 7:40 AM

Aug 11 2023

andrew_tao173.riddles.org.uk added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.
In D40961#943360, @mjg wrote:

but this is only trying to paper over part of the problem and flush_autofs still does not work?

Aug 11 2023, 7:38 PM
andrew_tao173.riddles.org.uk added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.

If the long-term solution is going to involve something new, then how about committing this as it stands in the meantime?

Aug 11 2023, 6:57 PM

Aug 10 2023

andrew_tao173.riddles.org.uk added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.

No, I don't think even that is possible; on 32-bit arch, there are literally zero flag bits available.

Aug 10 2023, 11:35 PM
andrew_tao173.riddles.org.uk added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.

Possible approach: rename existing MNT_BYFSID to MNT_BYFSID_OLD and add a new MNT_BYFSID with a non-colliding value; have nmount support (only) the new value, but leave umount supporting both.

Aug 10 2023, 11:06 PM
andrew_tao173.riddles.org.uk added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.
In D40961#942915, @mjg wrote:

The mount update path should grow support for FSID, which would close the problem.

Check kern_unmount to see what I mean.

Aug 10 2023, 11:04 PM
andrew_tao173.riddles.org.uk updated the summary of D40961: Fix for automount -c inappropriately clearing important mount flags.
Aug 10 2023, 9:27 PM

Aug 6 2023

andrew_tao173.riddles.org.uk added a comment to D41334: Revert "vnode read(2)/write(2): acquire rangelock regardless of do_vn_io_fault()".
In D41334#941330, @kib wrote:

ufs by default uses the vn_io_fault code path, which uses rangelocks, and does not (normally?) reach the pgcache path.

UFS does use pgcache reads.

Aug 6 2023, 11:36 PM
andrew_tao173.riddles.org.uk added a comment to D41334: Revert "vnode read(2)/write(2): acquire rangelock regardless of do_vn_io_fault()".

Do we have documentation of the scalability impact? I think that should be made clear.

Aug 6 2023, 7:16 PM
andrew_tao173.riddles.org.uk added a comment to D41334: Revert "vnode read(2)/write(2): acquire rangelock regardless of do_vn_io_fault()".
In D41334#941270, @mjg wrote:

ufs is the only other pgcache vop user, does it work without rangelocks?

Aug 6 2023, 7:12 PM

Aug 2 2023

andrew_tao173.riddles.org.uk updated the diff for D41285: Document USES=guile..

Reword some long or confusing sentences largely following fernape's suggestions.

Aug 2 2023, 5:51 PM
andrew_tao173.riddles.org.uk added inline comments to D41285: Document USES=guile..
Aug 2 2023, 2:55 PM

Aug 1 2023

andrew_tao173.riddles.org.uk updated the diff for D41285: Document USES=guile..

Fix example domains.

Aug 1 2023, 8:01 PM
andrew_tao173.riddles.org.uk added inline comments to D41285: Document USES=guile..
Aug 1 2023, 7:59 PM
andrew_tao173.riddles.org.uk updated the diff for D41285: Document USES=guile..

Requested whitespace fixes.

Aug 1 2023, 7:47 PM
andrew_tao173.riddles.org.uk updated subscribers of D41285: Document USES=guile..
Aug 1 2023, 7:33 PM
andrew_tao173.riddles.org.uk added a reviewer for D41285: Document USES=guile.: docs.
Aug 1 2023, 7:30 PM
andrew_tao173.riddles.org.uk requested review of D41285: Document USES=guile..
Aug 1 2023, 7:29 PM

Jul 31 2023

andrew_tao173.riddles.org.uk added a comment to D40194: Guile ports: remove conflicts and add flavors.

I will open a separate review shortly for documentation for this in the porters handbook.

Jul 31 2023, 12:42 AM

Jul 28 2023

andrew_tao173.riddles.org.uk updated the diff for D40194: Guile ports: remove conflicts and add flavors.

Pick up CHANGES, MOVED, and finalized PORTREVISION changes from fuz' repo.

Jul 28 2023, 5:56 PM

Jul 24 2023

andrew_tao173.riddles.org.uk accepted D41158: vnode read(2)/write(2): acquire rangelock regardless of do_vn_io_fault().

Tested this the same way as I tested the original report; no failures detected. The approach looks reasonable to me.

Jul 24 2023, 6:18 PM
andrew_tao173.riddles.org.uk updated the summary of D40194: Guile ports: remove conflicts and add flavors.
Jul 24 2023, 6:18 PM

Jul 22 2023

andrew_tao173.riddles.org.uk updated the diff for D40194: Guile ports: remove conflicts and add flavors.

Rebase (on c8adede0fca)

Jul 22 2023, 11:23 AM

Jul 17 2023

andrew_tao173.riddles.org.uk updated the diff for D40961: Fix for automount -c inappropriately clearing important mount flags.

Updated to include manpage fix.

Jul 17 2023, 4:08 PM
andrew_tao173.riddles.org.uk added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.

Maybe the added requirement that fstype must match when MNT_UPDATE is used should go in the manpage? (I can add that)

Jul 17 2023, 12:35 PM

Jul 11 2023

andrew_tao173.riddles.org.uk added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

Still waiting.

Jul 11 2023, 5:58 AM

Jul 10 2023

andrew_tao173.riddles.org.uk requested review of D40961: Fix for automount -c inappropriately clearing important mount flags.
Jul 10 2023, 5:51 PM

Jul 2 2023

andrew_tao173.riddles.org.uk updated the diff for D40194: Guile ports: remove conflicts and add flavors.

Rebase (on de1bf48ce).

Jul 2 2023, 2:26 AM

Jun 17 2023

andrew_tao173.riddles.org.uk updated the diff for D40194: Guile ports: remove conflicts and add flavors.

Rebase on 738e4012 and fix:

Jun 17 2023, 4:00 AM

Jun 13 2023

andrew_tao173.riddles.org.uk added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

The patch literally does nothing unless the variables it checks for are defined. Who is going to be surprised?

Jun 13 2023, 10:29 PM

Jun 12 2023

andrew_tao173.riddles.org.uk updated the test plan for D40194: Guile ports: remove conflicts and add flavors.
Jun 12 2023, 2:28 PM

Jun 11 2023

andrew_tao173.riddles.org.uk requested review of D40491: Fix ports depends-list.sh.
Jun 11 2023, 10:17 PM
andrew_tao173.riddles.org.uk updated the diff for D40194: Guile ports: remove conflicts and add flavors.

Rebase (on 4cec5e5f). Fix some minor issues.

Jun 11 2023, 10:17 PM

Jun 9 2023

andrew_tao173.riddles.org.uk added a comment to D40349: setusercontext(): Better error messages when priority is not set correctly.

I'm not at all sure I approve of the logic of this one. If the caller asked for LOGIN_SETPRIORITY, they may well be explicitly intending that the current process priority not be inherited by the eventual user's process.

Jun 9 2023, 3:21 PM

Jun 8 2023

andrew_tao173.riddles.org.uk added a comment to D40342: login_cap.c: Don't set errno to ERANGE on memory allocation failure.

It's perhaps worth noting that basically all of login_cap's memory handling is dubious - it leaks in several places, the manpages and the code disagree about whether values should be freed by the library or the caller, and it uses non-obvious and undocumented static state.

Jun 8 2023, 6:35 PM

Jun 2 2023

andrew_tao173.riddles.org.uk accepted D40281: dd(1): neutralize SIGINT while non-async-signal safe code is executing.
Jun 2 2023, 4:14 PM

Jun 1 2023

andrew_tao173.riddles.org.uk added inline comments to D40281: dd(1): neutralize SIGINT while non-async-signal safe code is executing.
Jun 1 2023, 2:15 PM

May 31 2023

andrew_tao173.riddles.org.uk added a comment to D40281: dd(1): neutralize SIGINT while non-async-signal safe code is executing.
In D40281#918468, @kib wrote:

How the effects of that are different than the current code, where the ^C handler just set a flag and returns?

May 31 2023, 5:46 PM
andrew_tao173.riddles.org.uk added a comment to D40352: setusercontext(): Set priority from '~/.login_conf' as well.

Should be conditional on LOGIN_SETPRIORITY, no?

May 31 2023, 4:43 PM

May 26 2023

andrew_tao173.riddles.org.uk updated the diff for D40194: Guile ports: remove conflicts and add flavors.

Add remaining guile ports; this should now be complete.

May 26 2023, 2:54 PM

May 23 2023

andrew_tao173.riddles.org.uk updated the diff for D40194: Guile ports: remove conflicts and add flavors.

Update with more ports, and improved logic in guile.mk.

May 23 2023, 11:27 AM

May 22 2023

andrew_tao173.riddles.org.uk abandoned D24325: New port lang/guile3.

Superseded by https://reviews.freebsd.org/D40194

May 22 2023, 9:02 AM

May 21 2023

andrew_tao173.riddles.org.uk added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

so... two years after everyone seems to have accepted it, maybe someone would commit it?

May 21 2023, 9:12 PM
andrew_tao173.riddles.org.uk requested review of D40194: Guile ports: remove conflicts and add flavors.
May 21 2023, 8:22 PM

May 9 2023

andrew_tao173.riddles.org.uk added a comment to D39641: dd: Fix SIGINT handling..

I have to agree with kib here, the right fix is to unblock the signal around open/read/write/close rather than this business with flags.

May 9 2023, 8:36 AM

Oct 10 2021

andrew_tao173.riddles.org.uk added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

The obvious example is doing this in make.conf:

Oct 10 2021, 6:24 AM
andrew_tao173.riddles.org.uk added inline comments to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..
Oct 10 2021, 6:00 AM

Jun 24 2021

andrew_tao173.riddles.org.uk added a comment to D30880: fsck_ufs: fix background fsck in preen mode.

The whole handling of fsreadfd and fswritefd makes me itch. They are opened and closed at random places, and some places test for them being < 0, but they are not statically initialized to -1 nor set to -1 when closed. I would honestly not be surprised if there were some weird combination of options that caused data blocks to be written to stdin rather than the disk.

Jun 24 2021, 5:35 PM
andrew_tao173.riddles.org.uk requested changes to D30880: fsck_ufs: fix background fsck in preen mode.

As far as I can tell, gjournal_check assumes fswritefd is already open, so this is no good.

Jun 24 2021, 5:51 AM

Feb 12 2021

andrew_tao173.riddles.org.uk added a comment to D28633: lualoader: handle local module errors more gracefully.

Looks basically sane to me.

Feb 12 2021, 11:44 PM

Jan 28 2021

andrew_tao173.riddles.org.uk added a comment to D24325: New port lang/guile3.

The comment about aclocal/guile.m4 file is not relevant anymore?

Jan 28 2021, 10:15 AM

Jan 27 2021

andrew_tao173.riddles.org.uk updated the diff for D24325: New port lang/guile3.

Update to 3.0.5, removing patches that were fixed upstream

Jan 27 2021, 9:33 PM

Jan 17 2021

andrew_tao173.riddles.org.uk updated the summary of D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..
Jan 17 2021, 2:04 AM
andrew_tao173.riddles.org.uk updated the diff for D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

Don't fold case of variable names. Allow using var@ to unset variables, since some places distinguish between empty and undefined values.

Jan 17 2021, 2:01 AM

Jan 4 2021

andrew_tao173.riddles.org.uk abandoned D27847: rc scripts vs. .pkgsave.

Abandoning; Mina has taken this over in D27962

Jan 4 2021, 10:35 PM

Dec 30 2020

andrew_tao173.riddles.org.uk added inline comments to D27847: rc scripts vs. .pkgsave.
Dec 30 2020, 7:21 PM
andrew_tao173.riddles.org.uk requested review of D27847: rc scripts vs. .pkgsave.
Dec 30 2020, 2:46 PM

Dec 13 2020

andrew_tao173.riddles.org.uk accepted D27589: lang/lua54 - Update to 5.4.2.

You could have just put this one on bugzilla with maintainer-approval set on the patch, for a routine update putting it up here seems overkill.

Dec 13 2020, 1:48 AM

Nov 15 2020

andrew_tao173.riddles.org.uk added inline comments to D27223: [2/2] _umtx_op: introduce 32-bit/i386 flags for operations.
Nov 15 2020, 12:45 PM

Nov 9 2020

andrew_tao173.riddles.org.uk requested review of D27154: Add error checks to @shell.
Nov 9 2020, 7:58 PM

Oct 19 2020

andrew_tao173.riddles.org.uk updated the diff for D24325: New port lang/guile3.

Update to 3.0.4 plus cherry-picked JIT fixes for arm.

Oct 19 2020, 8:31 PM

Oct 15 2020

andrew_tao173.riddles.org.uk added a comment to D24430: Update porters handbook for Lua changes.

Any chance of some review or action on this please?

Oct 15 2020, 1:19 PM
andrew_tao173.riddles.org.uk updated the diff for D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

Update to 5.4.1

Oct 15 2020, 1:11 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D25797: lang/lua53 - Correct variable order in Makefile..

Here's one that updates to 5.3.6 and has more extensive changes to variable order that satisfies portclippy, barring the use of a few variables it doesn't know about.

Oct 15 2020, 1:07 PM

Aug 10 2020

andrew_tao173.riddles.org.uk added a comment to D25365: Early WIP: convert login.conf to UCL.

Your login.conf changes need to be rebased against an up-to-date version from current - you're undoing the introduction of the "mail" capability and other changes related to environment vars from D21481.

Aug 10 2020, 7:41 AM

Jul 31 2020

andrew_tao173.riddles.org.uk requested review of D25902: Add warning against leapseconds to src.conf manpage..
Jul 31 2020, 2:44 AM

Jul 27 2020

andrew_tao173.riddles.org.uk updated the diff for D24430: Update porters handbook for Lua changes.

Rewrite to match changes to logic, and extend some parts slightly.

Jul 27 2020, 3:35 AM

Jul 26 2020

andrew_tao173.riddles.org.uk added a comment to D25797: lang/lua53 - Correct variable order in Makefile..

Also PORTREVISION should not be changed if there are no functional changes, since you'd just be forcing rebuilds/updates of every dependent port for no reason.

Jul 26 2020, 4:57 AM
andrew_tao173.riddles.org.uk added a comment to D25797: lang/lua53 - Correct variable order in Makefile..

5.3.6 is imminent, if there's any point at all in doing this cosmetic change then it could at least be folded into that.

Jul 26 2020, 4:56 AM

Jul 25 2020

andrew_tao173.riddles.org.uk accepted D25784: Add `flavors` support to devel/lua-luarocks.
Jul 25 2020, 6:05 AM
andrew_tao173.riddles.org.uk added a comment to D14709: [new port] lang/lua54 - new port for Lua 5.4.0.

Ah, I thought I had mucked something. Shall I restore them?

Jul 25 2020, 6:04 AM · Restricted Project

Jul 24 2020

andrew_tao173.riddles.org.uk added a comment to D25784: Add `flavors` support to devel/lua-luarocks.

I still think it's nuts to install multiple luarocks installations when the big feature of luarocks 3.x was the ability to handle multiple lua versions. But I'll withdraw my objection.

Jul 24 2020, 10:22 PM
andrew_tao173.riddles.org.uk added a comment to D14709: [new port] lang/lua54 - new port for Lua 5.4.0.
  • Removed non-relevant ports packages included by mistake
Jul 24 2020, 9:59 PM · Restricted Project
andrew_tao173.riddles.org.uk requested changes to D25784: Add `flavors` support to devel/lua-luarocks.

What's the justification for adding flavors, given that one luarocks install is supposed to be able to manage multiple lua versions?

When I try installing LuaRocks from ports/pkg I always get 5.2, regardless of the installed version of lua (due to the FreeBSD default Lua version of 5.2). The FreeBSD default means Luarocks is also configured for Lua 5.2 and the executable/script is called luarocks52. Perhaps I've done something wrong and there is an easier way around that, but this seems to perfectly fit the use case for flavors?

Jul 24 2020, 11:58 AM

Jul 23 2020

andrew_tao173.riddles.org.uk added a comment to D25784: Add `flavors` support to devel/lua-luarocks.

I think, in fact, the only useful change would be to install config files for every supported lua version rather than just the default one.

Jul 23 2020, 8:54 PM
andrew_tao173.riddles.org.uk added inline comments to D24492: Change version selection logic in Mk/Uses/lua.mk.
Jul 23 2020, 8:44 PM
andrew_tao173.riddles.org.uk added a comment to D25784: Add `flavors` support to devel/lua-luarocks.

What's the justification for adding flavors, given that one luarocks install is supposed to be able to manage multiple lua versions?

Jul 23 2020, 12:54 PM

Jul 21 2020

andrew_tao173.riddles.org.uk added inline comments to D24492: Change version selection logic in Mk/Uses/lua.mk.
Jul 21 2020, 4:09 PM
andrew_tao173.riddles.org.uk added inline comments to D24492: Change version selection logic in Mk/Uses/lua.mk.
Jul 21 2020, 3:26 PM

Jul 6 2020

andrew_tao173.riddles.org.uk updated the diff for D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.

Updates to address comments.

Jul 6 2020, 2:42 AM

Jun 30 2020

andrew_tao173.riddles.org.uk added a comment to D24492: Change version selection logic in Mk/Uses/lua.mk.

Lua 5.4.0 is now released, so this is now a blocking issue for the lua54 port.

Jun 30 2020, 12:21 AM

Jun 23 2020

andrew_tao173.riddles.org.uk updated the diff for D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

Move to an earlier place in processing (in fact the earliest possible place, just after PKGORIGIN is set).

Jun 23 2020, 3:23 AM

Jun 16 2020

andrew_tao173.riddles.org.uk added a comment to D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.
In D22189#557452, @mat wrote:

Is it possible to have the flavors not conflict with each other? Like, the full flavor only install the bits that are enabled by the options.

Jun 16 2020, 8:30 PM

Jun 5 2020

andrew_tao173.riddles.org.uk accepted D25038: execvPe: obviate the need for potentially large stack allocations.

I think this addresses all of my points.

Jun 5 2020, 5:42 PM
andrew_tao173.riddles.org.uk requested changes to D25038: execvPe: obviate the need for potentially large stack allocations.
Jun 5 2020, 3:15 PM
andrew_tao173.riddles.org.uk added inline comments to D25038: execvPe: obviate the need for potentially large stack allocations.
Jun 5 2020, 10:51 AM
andrew_tao173.riddles.org.uk added a comment to D25038: execvPe: obviate the need for potentially large stack allocations.

Will we be able to wrap this up before the conclusion of the 11.4 release cycle, or is this suddenly going to get bumped into SA status?

It's also not clear to me if we're now-satisfied with the changes, including stack alignment.

Jun 5 2020, 2:07 AM

May 29 2020

andrew_tao173.riddles.org.uk added a comment to D25038: execvPe: obviate the need for potentially large stack allocations.

While at it, would it be worth adding a check that the stack size is at least MINSIGSTKSZ + PATH_MAX ?

When you say 'adding a check', are you proposing a static assert that PSPAWN_STACK_ALIGNMENT at least fits MINSIGSTKSZ + PATH_MAX , or runtime check just before calling rfork_thread()?

May 29 2020, 5:54 PM