- User Since
- Mar 15 2018, 5:43 AM (175 w, 2 d)
Thu, Jun 24
The whole handling of fsreadfd and fswritefd makes me itch. They are opened and closed at random places, and some places test for them being < 0, but they are not statically initialized to -1 nor set to -1 when closed. I would honestly not be surprised if there were some weird combination of options that caused data blocks to be written to stdin rather than the disk.
Jun 24 2021
As far as I can tell, gjournal_check assumes fswritefd is already open, so this is no good.
Feb 12 2021
Looks basically sane to me.
Jan 28 2021
Jan 27 2021
Update to 3.0.5, removing patches that were fixed upstream
Jan 17 2021
Don't fold case of variable names. Allow using var@ to unset variables, since some places distinguish between empty and undefined values.
Jan 4 2021
Abandoning; Mina has taken this over in D27962
Dec 30 2020
Dec 13 2020
You could have just put this one on bugzilla with maintainer-approval set on the patch, for a routine update putting it up here seems overkill.
Nov 15 2020
Nov 9 2020
Oct 19 2020
Update to 3.0.4 plus cherry-picked JIT fixes for arm.
Oct 15 2020
Any chance of some review or action on this please?
Update to 5.4.1
Here's one that updates to 5.3.6 and has more extensive changes to variable order that satisfies portclippy, barring the use of a few variables it doesn't know about.
Aug 10 2020
Your login.conf changes need to be rebased against an up-to-date version from current - you're undoing the introduction of the "mail" capability and other changes related to environment vars from D21481.
Jul 31 2020
Jul 27 2020
Rewrite to match changes to logic, and extend some parts slightly.
Jul 26 2020
Also PORTREVISION should not be changed if there are no functional changes, since you'd just be forcing rebuilds/updates of every dependent port for no reason.
5.3.6 is imminent, if there's any point at all in doing this cosmetic change then it could at least be folded into that.
Jul 25 2020
Jul 24 2020
I still think it's nuts to install multiple luarocks installations when the big feature of luarocks 3.x was the ability to handle multiple lua versions. But I'll withdraw my objection.
Jul 23 2020
I think, in fact, the only useful change would be to install config files for every supported lua version rather than just the default one.
What's the justification for adding flavors, given that one luarocks install is supposed to be able to manage multiple lua versions?
Jul 21 2020
Jul 6 2020
Updates to address comments.
Jun 30 2020
Lua 5.4.0 is now released, so this is now a blocking issue for the lua54 port.
Jun 23 2020
Move to an earlier place in processing (in fact the earliest possible place, just after PKGORIGIN is set).
Jun 16 2020
Jun 5 2020
I think this addresses all of my points.
May 29 2020
Adding an EINVAL return to rfork_thread will cause this code to fall through to the "use vfork instead" logic, hiding the error in unexpected ways.
May 28 2020
May 27 2020
May 23 2020
Discussion point: this implementation converts the variable name to upper case for consistency with the way that port option_VARS works. But there are some cases where one might want to set a mixed-case name (such as CFLAGS.arch), so maybe it shouldn't do that and just use the case as written?
May 6 2020
Incidentally, in case it's not obvious, if my addition is moved to before the inclusion of bsd.default-versions.mk then it remains entirely possible to do
Lua 5.4.0 is planned for release next week, it would be nice to have this resolved sometime reasonably soon.
May 5 2020
May 4 2020
Discussion opened upstream at http://mm.icann.org/pipermail/tz/2020-May/028970.html
Apr 27 2020
I don't think there's a great deal of merit in adding this change just to pander to broken apps (it's not like fstat is hard), but I do think it's actually an improvement from a UX perspective (who amongst us has not been annoyed at some point by cat'ing a directory by mistake).
Apr 24 2020
Apr 23 2020
I just noticed that the diff here had been replaced by the one from the first commit, so I'm re-uploading the diff of just the uncommitted part for ease of further review.
Apr 19 2020
Apr 18 2020
This needs to stay on hold pending the change to the version selection logic discussed on D14709.
Others have supported the "closest to default" rule, so I'll put up a separate patch for that.
Change the two ports that declared themselves lua:53+ to just lua:53, since they don't seem to respond sanely to attempts to force configuration with 5.4 using environment vars.
Apr 17 2020
Add a note about avoiding use of XY+ version specifications
Should work with patch -p1
Apr 16 2020
Test results: adding support for 5.4 causes only two ports (archivers/urbackup-server and x11-toolkits/termit) to switch from lua 5.3 to 5.4 when LUA_DEFAULT is 5.2. (They would not switch if the default were 5.3; both are declared as lua:53+, and the default version is chosen if it is in range, otherwise the latest available version in the range.)
Apr 15 2020
Update to lua 5.4.0-rc1
This should have been fixed in bsd.sites.mk, which would unbreak a bunch of other ports too.
Apr 13 2020
Apr 11 2020
Apr 10 2020
Apr 9 2020
To explain the full context of the original link:
I think this change is a bad idea and should be reverted. (The "backward" file in the IANA db is for ancient compatibility, and FreeBSD has been excluding it by default since 1994 as far as I can tell; this is not the time to be adding it back.)
Apr 7 2020
Apr 5 2020
Fix rebase error that caused a deleted file (lua51-iconv/Makefile) to be revived due to a conflicting trunk commit.
Ugh, previous diff was reversed. Fix.
Rebase. Un-deprecate lua-iconv, because the only thing keeping it broken is the failure to update bsd.sites.mk in a timely manner.
Mar 26 2020
Rebase. Fix most of mat's requests. Make the usage of LUA_VER / LUA_VER_STR a bit more consistent. Allow for the option of lua:build,run if needed.
Mar 25 2020
From discussion just after I posted this, it sounds like math/plplot actually needs a PORTREVISION bump not included in this patch.
Rebase and include fixes.
Mar 10 2020
This one includes the changes to the actual ports, plus fixes to a few issues in lua.mk.
Feb 12 2020
Fix bug in non-LOGIN_CAP case. Update manpage.
Feb 10 2020
Feb 5 2020
This got brought up _again_ on IRC, but this time someone (sphex) came up with an actually interesting idea: what if there were a login.conf variable, e.g. cron.setpath, which if set caused cron(8) to respect the PATH from the login class if not overridden in the crontab file? This doesn't seem to hard to implement.
Jan 19 2020
Rebase and add docs.
Jan 18 2020
env.1 manpage will need changes, want me to add those?
Nov 8 2019
Any breakage is probably my fault - I need to pick this one up again and work on it some more.
Nov 5 2019
Fix unneeded dependency on guile-cairo when CAIRO option is off.