- User Since
- Mar 15 2018, 5:43 AM (120 w, 10 h)
Tue, Jun 30
Lua 5.4.0 is now released, so this is now a blocking issue for the lua54 port.
Tue, Jun 23
Move to an earlier place in processing (in fact the earliest possible place, just after PKGORIGIN is set).
Tue, Jun 16
Fri, Jun 5
I think this addresses all of my points.
May 29 2020
Adding an EINVAL return to rfork_thread will cause this code to fall through to the "use vfork instead" logic, hiding the error in unexpected ways.
May 28 2020
May 27 2020
May 23 2020
Discussion point: this implementation converts the variable name to upper case for consistency with the way that port option_VARS works. But there are some cases where one might want to set a mixed-case name (such as CFLAGS.arch), so maybe it shouldn't do that and just use the case as written?
May 6 2020
Incidentally, in case it's not obvious, if my addition is moved to before the inclusion of bsd.default-versions.mk then it remains entirely possible to do
Lua 5.4.0 is planned for release next week, it would be nice to have this resolved sometime reasonably soon.
May 5 2020
May 4 2020
Discussion opened upstream at http://mm.icann.org/pipermail/tz/2020-May/028970.html
Apr 27 2020
I don't think there's a great deal of merit in adding this change just to pander to broken apps (it's not like fstat is hard), but I do think it's actually an improvement from a UX perspective (who amongst us has not been annoyed at some point by cat'ing a directory by mistake).
Apr 24 2020
Apr 23 2020
I just noticed that the diff here had been replaced by the one from the first commit, so I'm re-uploading the diff of just the uncommitted part for ease of further review.
Apr 19 2020
Apr 18 2020
This needs to stay on hold pending the change to the version selection logic discussed on D14709.
Others have supported the "closest to default" rule, so I'll put up a separate patch for that.
Change the two ports that declared themselves lua:53+ to just lua:53, since they don't seem to respond sanely to attempts to force configuration with 5.4 using environment vars.
Apr 17 2020
Add a note about avoiding use of XY+ version specifications
Should work with patch -p1
Apr 16 2020
Test results: adding support for 5.4 causes only two ports (archivers/urbackup-server and x11-toolkits/termit) to switch from lua 5.3 to 5.4 when LUA_DEFAULT is 5.2. (They would not switch if the default were 5.3; both are declared as lua:53+, and the default version is chosen if it is in range, otherwise the latest available version in the range.)
Apr 15 2020
Update to lua 5.4.0-rc1
This should have been fixed in bsd.sites.mk, which would unbreak a bunch of other ports too.
Apr 13 2020
Apr 11 2020
Apr 10 2020
Apr 9 2020
To explain the full context of the original link:
I think this change is a bad idea and should be reverted. (The "backward" file in the IANA db is for ancient compatibility, and FreeBSD has been excluding it by default since 1994 as far as I can tell; this is not the time to be adding it back.)
Apr 7 2020
Apr 5 2020
Fix rebase error that caused a deleted file (lua51-iconv/Makefile) to be revived due to a conflicting trunk commit.
Ugh, previous diff was reversed. Fix.
Rebase. Un-deprecate lua-iconv, because the only thing keeping it broken is the failure to update bsd.sites.mk in a timely manner.
Mar 26 2020
Rebase. Fix most of mat's requests. Make the usage of LUA_VER / LUA_VER_STR a bit more consistent. Allow for the option of lua:build,run if needed.
Mar 25 2020
From discussion just after I posted this, it sounds like math/plplot actually needs a PORTREVISION bump not included in this patch.
Rebase and include fixes.
Mar 10 2020
This one includes the changes to the actual ports, plus fixes to a few issues in lua.mk.
Feb 12 2020
Fix bug in non-LOGIN_CAP case. Update manpage.
Feb 10 2020
Feb 5 2020
This got brought up _again_ on IRC, but this time someone (sphex) came up with an actually interesting idea: what if there were a login.conf variable, e.g. cron.setpath, which if set caused cron(8) to respect the PATH from the login class if not overridden in the crontab file? This doesn't seem to hard to implement.
Jan 19 2020
Rebase and add docs.
Jan 18 2020
env.1 manpage will need changes, want me to add those?
Nov 8 2019
Any breakage is probably my fault - I need to pick this one up again and work on it some more.
Nov 5 2019
Fix unneeded dependency on guile-cairo when CAIRO option is off.
Nov 4 2019
Nov 1 2019
Add flavors (full/lite).
Oct 31 2019
Add build dependency on gettext-tools, to get some stuff (gnulib's lib-link.m4) that actually has nothing to do with gettext :-(
Ugh, build does break for some option combinations due to hidden dependency on gettext-tools (for aclocal/lib-link.m4). Will post new patch after next round of tests.
Oct 30 2019
No, this change is wrong if LUA_PREFIX is something different from /usr/local, since in that case luaconf.h does indeed get modified.
Oct 22 2019
Oct 21 2019
Looks like Roberto snuck some hardcoded -Os options into the makefile, we need to either patch those back out or think of something else to do with them.
Oct 17 2019
You seem to have duplicated a patch? There should be no patch for lua.c other than the extra-patch-libedit-dl one.
- When the ASSERT option is selected, the extra-patch-assert file fails to apply cleanly. I tried to port it over but I there has been a change to lgc.c and I don't know enough about lgc to apply the patch (Help Andrew?).
Oct 6 2019
Style fixes. Rebase.
Now that a 5.4.0-beta release has been made, and there are signs that features are actually stabilizing (there have been many changes since work2), perhaps we could pick this up again. The distinfo needs an update of course.
Sep 18 2019
Further proposal (the patch doesn't do this yet): cron should not override PATH when reading a user crontab; whether it should use the user's path, or daemon's path, rather than the hardcoded default when processing the system crontab is a more open question.
Sep 3 2019
I've been pondering whether limits(1) also needs an option to pick up the environment from the login class, or whether that's better addressed in rc.subr for the case of servicename_class="x" settings.
Sep 1 2019
Aug 31 2019
Why isn't this just CFLAGS+=-fPIC ?
I've been running this myself for a while and have done explicit tests as listed in the test plan, and as far as I'm concerned it's done unless anyone has feedback on comments or docs. Anyone up for committing it?
Aug 29 2019
Aug 23 2019
Add documentation. Update comments. Refine the wording a little.
Aug 21 2019
Aug 19 2019
Jul 23 2019
Apologies for needing another review round. Changes:
Ugh. Hold off on committing, please; there's one more issue to fix.
Philip: are you taking it, or should I find someone else? (I'm not a committer and as far as I know tmunro is only a src committer)
Jul 18 2019
This is my final version unless someone spots a problem with it.
Update PORTREVISION which I forgot before.