- User Since
- Dec 10 2015, 6:03 AM (110 w, 2 d)
Sun, Jan 14
Ran the tests. Results are here:
Thu, Jan 11
Thanks for separating this out from that monster work you did. There was one issue that I noted in a comment (on distinfo). Much of the delay was me not knowing how to use patch (-E). I regenerated the entire patch here:
Wed, Jan 3
Well to my surprise it "compiled". Chapter three is all mashed up and this version doesn't have the changes requested by mat. I'll have to get that revision off a different computer.
Tue, Jan 2
Sun, Dec 31
Hi, I've looked over the failures and I think I'd rather just close this review and comment on the original bugzilla ticket. Not sure how to close a review?
Sat, Dec 30
Removed changes to lua.mk. Review is tracking questions on exp-run failures. Alternatively we can close this and I can use bugzilla.
Nov 27 2017
Nov 24 2017
Nice job adding msbuild. That's going to come in handy for dotnet core 2. I'll try building this again asap.
Nov 8 2017
Nov 7 2017
Nov 5 2017
Thanks so much for the review @mat!