russ.haley_gmail.com (Russell Haley)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 10 2015, 6:03 AM (135 w, 3 d)

Recent Activity

Today

russ.haley_gmail.com created D16274: LuaRocks 3.0.0 Beta2.
Sun, Jul 15, 4:21 AM · Restricted Project
russ.haley_gmail.com updated the diff for D13690: Lua53 - Update to 5.3.5.

Corrected soname value.

Sun, Jul 15, 2:44 AM · Restricted Project
russ.haley_gmail.com updated the test plan for D13690: Lua53 - Update to 5.3.5.
Sun, Jul 15, 2:16 AM · Restricted Project
russ.haley_gmail.com updated the diff for D13690: Lua53 - Update to 5.3.5.

Backported 14709. The Lua 5.3 and 5.4 ports are now identical except version difference and the patch-src__Makefile is slightly different (to be reviewed).

Sun, Jul 15, 2:10 AM · Restricted Project

Yesterday

russ.haley_gmail.com added a comment to D14709: Lua 5.4.0.

Note that work2 is not ready for prime time yet (garbage collector bugs, at least)

I didn't see anything on the mailing list that would preclude adding it to the ports collection, or at the very least performing an expeditionary run (if that's possible). @mat, @dbn, I'm keen to get 5.3.5 or preferably 5.4 "build tested" against other packages because I've got a week off work right now with no kids.

The "uservalue has an incorrect value" thread is the GC bug I know about. Won't affect pure-lua code, but anything that uses uservalues can explode (even just doing require "re" collectgarbage() triggers an invalid access, though it won't crash immediately unless you built with assertions on).

Sat, Jul 14, 10:47 PM · Restricted Project
russ.haley_gmail.com updated the diff for D13690: Lua53 - Update to 5.3.5.

Corrected so name variables. Thanks @andrew_tao173.riddles.org.uk

Sat, Jul 14, 9:54 PM · Restricted Project
russ.haley_gmail.com added a comment to D14709: Lua 5.4.0.

Note that work2 is not ready for prime time yet (garbage collector bugs, at least)

Sat, Jul 14, 9:38 PM · Restricted Project
russ.haley_gmail.com added a comment to D14709: Lua 5.4.0.

It ... doesn't seem to be common style as far as I can see. I'm not keen on the idea.

Sat, Jul 14, 9:32 PM · Restricted Project
russ.haley_gmail.com added inline comments to D14709: Lua 5.4.0.
Sat, Jul 14, 8:35 PM · Restricted Project
russ.haley_gmail.com updated the test plan for D14709: Lua 5.4.0.
Sat, Jul 14, 8:11 PM · Restricted Project
russ.haley_gmail.com updated the test plan for D14709: Lua 5.4.0.
Sat, Jul 14, 8:11 PM · Restricted Project
russ.haley_gmail.com updated the summary of D14709: Lua 5.4.0.
Sat, Jul 14, 8:06 PM · Restricted Project
russ.haley_gmail.com added inline comments to D14709: Lua 5.4.0.
Sat, Jul 14, 8:03 PM · Restricted Project
russ.haley_gmail.com added a comment to D13690: Lua53 - Update to 5.3.5.

@andrew_tao173.riddles.org.uk, I am very grateful for your tutelage and contributions. Do you want to see the readline options from D14709 left in? I had two thoughts: 1) anyone who doesn't want readline support is probably building Lua themselves and 2) with the freebsd target working, we could create an option for the generic target, that does not include readline.

I personally don't feel the extra complexity of the options adds value since the source Makefile is patched to use editline.

I have been working on a new version of the 5.4 port (since the need for NILINTABLE went away, and I wanted to experiment with other options).

Probably not worth adding options just for readline, but what about installing the HTML docs? I think that would be a good option (or indeed a default).

Sat, Jul 14, 7:17 PM · Restricted Project
russ.haley_gmail.com added inline comments to D13690: Lua53 - Update to 5.3.5.
Sat, Jul 14, 6:20 PM · Restricted Project
russ.haley_gmail.com retitled D13690: Lua53 - Update to 5.3.5 from Lua53 revision 3 to Lua53 - Update to 5.3.5.
Sat, Jul 14, 6:15 PM · Restricted Project
russ.haley_gmail.com updated the diff for D13690: Lua53 - Update to 5.3.5.
Sat, Jul 14, 6:15 PM · Restricted Project
russ.haley_gmail.com added a comment to D13690: Lua53 - Update to 5.3.5.

@andrew_tao173.riddles.org.uk, I am very grateful for your tutelage and contributions. Do you want to see the readline options from D14709 left in? I had two thoughts: 1) anyone who doesn't want readline support is probably building Lua themselves and 2) with the freebsd target working, we could create an option for the generic target, that does not include readline.

Sat, Jul 14, 6:06 PM · Restricted Project
russ.haley_gmail.com added inline comments to D13690: Lua53 - Update to 5.3.5.
Sat, Jul 14, 5:54 PM · Restricted Project
russ.haley_gmail.com added inline comments to D13690: Lua53 - Update to 5.3.5.
Sat, Jul 14, 5:42 PM · Restricted Project
russ.haley_gmail.com updated the diff for D13690: Lua53 - Update to 5.3.5.

Update to 5.3.5. See updated summary.

Sat, Jul 14, 7:46 AM · Restricted Project

May 2 2018

russ.haley_gmail.com added a comment to D13870: lang/linux-dotnet-(runtime|sdk): add linux implementation of .NET Core.

Hi David,

May 2 2018, 4:37 AM · Linux Emulation

Mar 18 2018

russ.haley_gmail.com updated the diff for D14709: Lua 5.4.0.

Corrected src/Makefile patch to remove -DLUA_USE_READLINE as per AG. Compiles with and without interactive mode.

Mar 18 2018, 7:19 PM · Restricted Project
russ.haley_gmail.com updated the diff for D14709: Lua 5.4.0.

Updated with improvements from @andrew_tao173.riddles.org.uk :

  • Removed hard coded options
  • Added options for editline/readline library source
  • Added option for experimental NILINTABLE
  • Andrew commented that command names should come from lua.mk. I added a timestamp for tracking. (Updating lua.mk is on my todo list. See D13691)
Mar 18 2018, 4:31 PM · Restricted Project

Mar 17 2018

russ.haley_gmail.com added a comment to D13690: Lua53 - Update to 5.3.5.

Hi Andrew,

Mar 17 2018, 10:29 PM · Restricted Project
russ.haley_gmail.com updated the summary of D14709: Lua 5.4.0.
Mar 17 2018, 4:24 AM · Restricted Project
russ.haley_gmail.com updated the summary of D14709: Lua 5.4.0.
Mar 17 2018, 4:23 AM · Restricted Project
russ.haley_gmail.com updated the diff for D14709: Lua 5.4.0.
  • Updated to build shared object.
  • Removed LUA_NILINTABLE. Will turn it into an option. Any other useful options?
  • Fixed to use MYLIBS not MYLDFLAGS for -ledit
Mar 17 2018, 4:09 AM · Restricted Project

Mar 16 2018

russ.haley_gmail.com added a comment to D14709: Lua 5.4.0.

The so isn't working because there is nothing here to build it; the makefile distributed with Lua does not try to build one and never did, the ports for earlier Lua versions patch the makefile to add it.

Thank you, I didn't remember that I had stripped that out to revise it. I get a few hours here and there for these things.

Mar 16 2018, 8:36 PM · Restricted Project
russ.haley_gmail.com created D14709: Lua 5.4.0.
Mar 16 2018, 6:28 AM · Restricted Project

Mar 10 2018

russ.haley_gmail.com updated the diff for D12921: Three New Chapter for Porters Handbook.

Minor update to make section 3.2.2 a little more readable. I'll push the changes here as well http://envirobotics.ca/portershb/tools-introduction.html

Mar 10 2018, 6:45 AM

Mar 9 2018

russ.haley_gmail.com added a comment to D12921: Three New Chapter for Porters Handbook.

I've posted the output here: http://envirobotics.ca/portershb/ph-introduction.html

Mar 9 2018, 6:49 AM
russ.haley_gmail.com added inline comments to D12921: Three New Chapter for Porters Handbook.
Mar 9 2018, 5:56 AM
russ.haley_gmail.com updated the diff for D12921: Three New Chapter for Porters Handbook.
  • Updated formatting to make it more readable. Still requires a great deal of work.
  • Some revision of the text, no change to the technical content.
Mar 9 2018, 5:43 AM

Feb 8 2018

russ.haley_gmail.com added a comment to D13870: lang/linux-dotnet-(runtime|sdk): add linux implementation of .NET Core.
In D13870#299128, @dbn wrote:

russellh@g1 /u/l/lib> pwd
/usr/local/lib
russellh@g1 /u/l/lib> ll libunwind.so*
lrwxr-xr-x 1 root wheel 18B Jul 26 2017 libunwind.so -> libunwind.so.8.0.1
lrwxr-xr-x 1 root wheel 18B Jul 26 2017 libunwind.so.8 -> libunwind.so.8.0.1
-rwxr-xr-x 1 root wheel 43K Jul 26 2017 libunwind.so.8.0.1

I think your Ports directory was out-of-date. There is a bug with USES=linux in that it ignores missing Linux packages (i.e. if your Ports tree was out-of-date). See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225768 for the patch to check for this case.

Also, note that this is a Linux port, and you need the Linux version of libunwind:

# cd /compat/linux/usr/lib
# ls -l libunwind.so*
lrwxr-xr-x  1 root  wheel     18 Aug  2  2017 libunwind.so.8 -> libunwind.so.8.0.1
-rwxr-xr-x  1 root  wheel  43764 Aug  2  2017 libunwind.so.8.0.1

You can manually install it with pkg install linux-c7-libunwind, however you are likely missing other Linux packages.

I hope this helps?

Feb 8 2018, 7:44 PM · Linux Emulation
russ.haley_gmail.com added a comment to D13869: Add CentOS packages and mark nss as patched.
In D13869#299136, @dbn wrote:

I've double checked and the issue does not appear to be with this revision. We'll work on the issue in https://reviews.freebsd.org/D13870 and if there is an issue relating to these Linux ports we'll report back.

Feb 8 2018, 7:42 PM

Feb 3 2018

russ.haley_gmail.com added a comment to D13869: Add CentOS packages and mark nss as patched.

I'm cross posting an issue with the dotnet runtime, which was the reason this patch was created. Not sure where the source of the issue is yet.

Feb 3 2018, 7:16 PM
russ.haley_gmail.com added a comment to D13870: lang/linux-dotnet-(runtime|sdk): add linux implementation of .NET Core.

Hi David, I'm trying to create a test application from instructions here: https://medium.com/wolox-driving-innovation/how-to-create-your-first-net-e2223dedb74f

Feb 3 2018, 7:11 AM · Linux Emulation

Jan 30 2018

russ.haley_gmail.com added a comment to D13752: lang/mono: update to 5.2.0.215.
In D13752#293261, @dbn wrote:

We have failing ports. Another github distinfo issue, and other isses with ports.

Jan 30 2018, 2:37 AM

Jan 14 2018

russ.haley_gmail.com added a comment to D13752: lang/mono: update to 5.2.0.215.

Hi,
Ran make test.

Jan 14 2018, 4:27 AM

Jan 11 2018

russ.haley_gmail.com added a comment to D13752: lang/mono: update to 5.2.0.215.

Thanks for separating this out from that monster work you did. There was one issue that I noted in a comment (on distinfo). Much of the delay was me not knowing how to use patch (-E). I regenerated the entire patch here:

Jan 11 2018, 7:27 AM

Jan 3 2018

russ.haley_gmail.com added a comment to D12921: Three New Chapter for Porters Handbook.

Well to my surprise it "compiled". Chapter three is all mashed up and this version doesn't have the changes requested by mat. I'll have to get that revision off a different computer.

Jan 3 2018, 7:04 AM

Jan 2 2018

russ.haley_gmail.com added a comment to D12921: Three New Chapter for Porters Handbook.

is there a formatted version of this available somewhere so it can be read in final form?

Jan 2 2018, 8:11 AM

Dec 31 2017

russ.haley_gmail.com added inline comments to D12921: Three New Chapter for Porters Handbook.
Dec 31 2017, 11:07 PM
russ.haley_gmail.com added a comment to D12440: Tracker for mono-related reviews.

Hi David,

Dec 31 2017, 6:21 AM
russ.haley_gmail.com added a comment to D13691: Update bsd.defaults.mk for lua to 5.3 and questions about lua.mk.

Hi, I've looked over the failures and I think I'd rather just close this review and comment on the original bugzilla ticket. Not sure how to close a review?

Dec 31 2017, 4:54 AM

Dec 30 2017

russ.haley_gmail.com updated the diff for D13691: Update bsd.defaults.mk for lua to 5.3 and questions about lua.mk.

Removed changes to lua.mk. Review is tracking questions on exp-run failures. Alternatively we can close this and I can use bugzilla.

Dec 30 2017, 9:22 PM
russ.haley_gmail.com added a comment to D13691: Update bsd.defaults.mk for lua to 5.3 and questions about lua.mk.
Dec 30 2017, 9:10 PM
russ.haley_gmail.com added a comment to D13691: Update bsd.defaults.mk for lua to 5.3 and questions about lua.mk.

There was an exp-run a few months ago and the results were bad.
Maybe lua ports could be flavored...

Dec 30 2017, 7:54 AM
russ.haley_gmail.com added inline comments to D13691: Update bsd.defaults.mk for lua to 5.3 and questions about lua.mk.
Dec 30 2017, 7:38 AM
russ.haley_gmail.com created D13691: Update bsd.defaults.mk for lua to 5.3 and questions about lua.mk.
Dec 30 2017, 7:35 AM
russ.haley_gmail.com added inline comments to D13690: Lua53 - Update to 5.3.5.
Dec 30 2017, 7:29 AM · Restricted Project
russ.haley_gmail.com added inline comments to D13690: Lua53 - Update to 5.3.5.
Dec 30 2017, 7:24 AM · Restricted Project
russ.haley_gmail.com created D13690: Lua53 - Update to 5.3.5.
Dec 30 2017, 7:09 AM · Restricted Project

Nov 27 2017

russ.haley_gmail.com added inline comments to D12440: Tracker for mono-related reviews.
Nov 27 2017, 5:29 AM
russ.haley_gmail.com added inline comments to D12440: Tracker for mono-related reviews.
Nov 27 2017, 5:21 AM

Nov 24 2017

russ.haley_gmail.com added a comment to D12440: Tracker for mono-related reviews.

Nice job adding msbuild. That's going to come in handy for dotnet core 2. I'll try building this again asap.

Nov 24 2017, 6:49 AM

Nov 8 2017

russ.haley_gmail.com added inline comments to D12921: Three New Chapter for Porters Handbook.
Nov 8 2017, 9:56 PM

Nov 7 2017

russ.haley_gmail.com added inline comments to D12921: Three New Chapter for Porters Handbook.
Nov 7 2017, 11:04 PM

Nov 5 2017

russ.haley_gmail.com updated the summary of D12921: Three New Chapter for Porters Handbook.
Nov 5 2017, 7:20 AM
russ.haley_gmail.com updated the summary of D12921: Three New Chapter for Porters Handbook.
Nov 5 2017, 7:20 AM
russ.haley_gmail.com added a comment to D12921: Three New Chapter for Porters Handbook.

Thanks so much for the review @mat!

Nov 5 2017, 7:16 AM

Nov 3 2017

russ.haley_gmail.com created D12921: Three New Chapter for Porters Handbook.
Nov 3 2017, 5:23 AM