- User Since
- Dec 10 2015, 6:03 AM (243 w, 6 d)
Sun, Jul 26
Sat, Jul 25
I've been messing with this port in my time off.
Move lua:flavors from USES to LUAJIT_USES_OFF as per comments.
You seem to be stuck between a luarock and a hard place... :)
Fri, Jul 24
Would really like it if we could all work towards getting Lua 5.4 as the default version on FreeBSD!
- Removed non-relevant ports packages included by mistake
- Copied current Lua53 makefile and adjusted for Lua54.
- Moved OPTIONS variable block below build variables (will submit a correction to lua53 as well)
I have never used that option on any of the three platforms on which I use LuaRocks. Moreover, there is no way currently to generate config files (outside of installation) so a user must manually copy and modify the existing one (I agree that replicating configs is a simple task for an experienced user). I have a "feature request" with the LuaRocks team for a feature to create config files.
Added PORTREVISION. Corrected diff format.
Thu, Jul 23
Updated to use the official release Lua 5.4.0
May 2 2020
Apr 20 2020
Apr 18 2020
Luarocks has already been updated to 3.3.1 and this patch is broken. I'm abandoning this review.
Apr 17 2020
Nov 8 2019
I am testing this patch with LuaRocks (as noted in above). I removed all the OPTIONS that I had created which used flavors and added lua:51-54 to my USES:
Nov 5 2019
Patch out CFLAGS optimization in third party makefile as per handbook:
Oct 22 2019
Patch out targets that added -Os to llex.o, lparser.o, and lcode.o.
Oct 19 2019
This has been implemented as a ports option and is already in the tree
This version is updated to use LUA_FLAVORS from here: https://reviews.freebsd.org/D16494. I have implemented options for each flavor.
I worked with the upstream maintainer to fix the issue with the default FreeBSD unzip(1) implementation. The bug existed because LuaRocks would test for the existance of unzip using the -h option, which is not present in FreeBSD. LuaRocks now implicitly recognizes that FreeBSD has unzip so it doesn't test for it.
Oct 18 2019
Added option for arc4random random seed. I tested running math.random and it looked randomish to me? I don't know what I'm looking for but the flags were present in the build output:
Addressed andrews comments. Fixed missing patch for LIBEDIT_DL and tested LIBEDIT_DL option. twice. :-/
New patch to address comments, thank you Andrew.
Oct 17 2019
Is this patch for arc4random something that we should look at applying?
Updated for the latest Lua 5.4 Beta release.
Oct 15 2019
Jun 16 2019
Updated diff for 3.1.3
Mar 31 2019
Mar 26 2019
Hi @mat, this port update has been languishing for some time now. How do I get this committed without @jbeich removing his change request? I completed the requested changes some time ago and have been using this port update for a few weeks now.
Mar 22 2019
I've installed cqueues, ldoc and penlight on freebsd 12.0 using Lua52. Output for ldoc and penlight installation:
Feb 16 2019
Jan 29 2019
I just tested on 12-Release using a clean /usr/ports directory. The system force me to install Lua5.2 because Mk/bsd.default-versions.mk isn't patched (the upside is luarocks is tested with Lua52 now!). How do I go about getting the default version bumped? I would guess an exp-run would be required? I'd also like to see an exp-run to find out what's not current. @andrew_tao173.riddles.org.uk also has a patch in the works to add FLAVOURS to lua here: https://reviews.freebsd.org/D16494
Add patch that removes use of unsupported -h option. The option is used to check for the existence of unzip, which is present in the base FreeBSD image.
Jan 28 2019
Jan 27 2019
Added comment noting bug.
Jan 26 2019
Removed -pthread options. Added -pthread to LIBS.
Jan 25 2019
Removed whitespace changes, used recommended svn diff options.
Jan 24 2019
Removed commented out code.
Nov 9 2018
Nov 5 2018
Patch file was removed in error. Rebased patch file for src/luarocks/core/cfg.lua.
Quite right. A maintainer should also know better than to look at the patched file in the work directory and come to the incorrect conclusion that the patch is no longer needed. :-/
I'll push a rebased patch and then look why unzip might not be working next chance I get.
Nov 2 2018
Corrections as per feedback from @jbeich.
Argh! Sorry about that @jbeich. I forgot to delete the patch in svn.
Aug 14 2018
Jul 28 2018
Jul 24 2018
"Reverted" whitespace cleanup.
Whitespace alignment. It looks great in geany...
- Updated as per comments. Thanks @mat.
- LuaRocks has been released. Updated port to release download.
Jul 19 2018
Jul 17 2018
Changed no name as per comment from @mat.
Cleanup mistake. Lua counts from 1, ports revisions do not. :)
Cleanup. Added port revision number.
Jul 15 2018
There seems to be a bug in the base LuaRocks Makefile that requires running 'make build' twice. Therefore this patch works if you run make twice. I have a message on the Lua mailing list for further information from Hisham.
Corrected soname value.
Backported D14709. The Lua 5.3 and 5.4 ports are now identical except version difference and the patch-src__Makefile is slightly different (to be reviewed).