lua.mk
ClosedPublic
Actions

Authored by andrew_tao173.riddles.org.uk on Apr 18 2020, 11:47 PM.

Details

Reviewers

antoine
mat

Group Reviewers

portmgr
O5: Ports Framework

Commits

rP543000: Update version selection logic for USES= lua

Summary

Per discussion on D14709, this patch implements Antoine's suggested "closest version" logic in place of the previous "highest version" when the default version is not in the range allowed by the port.

Test Plan

Tested standalone using make -v '...' to display variables with a range of inputs for USES and DEFAULT_VERSIONS, all output correct.

Tested in-situ by testport'ing a sample of lua ports with varying default versions, all builds worked as expected.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew_tao173.riddles.org.uk created this revision.Apr 18 2020, 11:47 PM

andrew_tao173.riddles.org.uk edited the test plan for this revision. (Show Details)Apr 19 2020, 4:15 PM

Lua 5.4.0 is planned for release next week, it would be nice to have this resolved sometime reasonably soon.

Lua 5.4.0 is now released, so this is now a blocking issue for the lua54 port.

antoine added inline comments.Jul 21 2020, 3:16 PM

Mk/Uses/lua.mk
35 ↗	(On Diff #70755)	Can you explain how a tie can happen?

andrew_tao173.riddles.org.uk added inline comments.Jul 21 2020, 3:26 PM

Mk/Uses/lua.mk
35 ↗	(On Diff #70755)	USES=lua:51,53 with 5.2 as the default version.

mat added inline comments.Jul 21 2020, 3:30 PM

Mk/Uses/lua.mk
35 ↗	(On Diff #70755)	Is this an actually existing case, or is this purely academic?

andrew_tao173.riddles.org.uk added inline comments.Jul 21 2020, 4:09 PM

Mk/Uses/lua.mk
35 ↗	(On Diff #70755)	I don't believe any existing port does it, but I do myself have some code (which I do eventually hope to make a port for) that works only with 5.1 or 5.3. This is because the 5.1 compatibility is there only to support luajit, whereas there is no good reason to support 5.2 if 5.3 is available.

mat added inline comments.Jul 23 2020, 12:57 PM

Mk/Uses/lua.mk
35 ↗	(On Diff #70755)	Ok, so, this is code to handle an edge case that does not exist in the ports tree. I don't really like to add code to support non existing cases. I don't know Lua, but looking at their website, Lua 5.1 has been dead 8 years, Lua 5.2 has been dead 5, and Lua 5.3 has been dead 2, maybe it is time to remove 5.1 and 5.2... And plan to remove 5.3 in the next year or so.