Page MenuHomeFreeBSD

Fix ports

Authored by on Jun 11 2023, 6:20 PM.
Referenced Files
F84417971: D40491.id123075.diff
Thu, May 23, 3:25 PM
Unknown Object (File)
Sun, May 12, 3:24 PM
Unknown Object (File)
Thu, May 9, 7:12 AM
Unknown Object (File)
Wed, May 8, 6:07 PM
Unknown Object (File)
Apr 18 2024, 12:20 AM
Unknown Object (File)
Apr 18 2024, 12:19 AM
Unknown Object (File)
Apr 17 2024, 5:04 PM
Unknown Object (File)
Feb 8 2024, 1:00 AM


Summary fails in two ways: one is a simple quoting bug (which would have been detected by shellcheck) which causes empty FLAVOR variables to be propagated; the other is that de-duplication is being done without regard for flavors.

The upshot of these is that where a port depends on a specific flavor (first bug) or on multiple flavors (second bug, usually caused by build dependencies) of another port, the constructed dependency list is incomplete, and so -recursive targets do not do all the required work. (This is especially annoying for fetch-recursive.)

See also on this exact issue which has been open for three months without attention; this diff addresses both the original bug and my followup comment.

Test Plan

Extensively tested locally (I rely on fetch-recursive to fetch all distfiles).

Diff Detail

R11 FreeBSD ports repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

Looks fine to me, unless I'm missing something. @pizzamig do you want to take this as you own the PR too?

This revision was not accepted when it landed; it landed in state Needs Review.Jun 13 2023, 8:13 PM
This revision was automatically updated to reflect the committed changes.