- User Since
- May 26 2014, 5:11 PM (233 w, 3 d)
Tue, Nov 13
Sun, Nov 11
What is the status of this review (and PR 231029) ?
Sat, Nov 10
Sent in a working patch.
Continuing with the original review.
Fri, Nov 9
(Inline comments do not work for pastes?)
Tue, Nov 6
Sun, Nov 4
Fri, Nov 2
Thu, Nov 1
Process most of jbeich's suggestions and rebase onto r483743
Rebase onto r483643, add www/node10
Mon, Oct 29
Updated patch at https://people.freebsd.org/~rene/patches/x11-kms.diff which (apart from the entities) solves all build problems and fixes some style/igor bugs.
Sun, Oct 28
There could be more ports where the QT4 dependency is optional, please recheck all ports.Those ports must not expire, only their QT4 bits should be removed manually. Otherwise rmport will happily remove them.
The build fails for me, because it doesn't know the newly introduced entities:
The wordy version in your example should be
Rebase to r483291 and fix devel/qtcreator
Sat, Oct 27
Clean up some pkg-* files too.
Thu, Oct 25
Tue, Oct 23
LGTM overall, especially all the added reasons.