User Details
- User Since
- Jun 6 2021, 5:11 PM (284 w, 3 d)
Sun, Nov 15
Probably correct. I wonder if there is a built-in for this one. X86 for example has this as a instruction afaik.
Approved for commit.
Sat, Nov 7
Fri, Nov 6
Sun, Nov 1
Sat, Oct 31
Thu, Oct 29
Wed, Oct 21
Added man pages to reviewers (this means @ziaee). Not sure if the phrasing you used is what we would usually write. Code looks fine from what I can say.
Could you add this DR to the C23 wiki page?
Ok, that clears it up.
Please once again seek external review.
Approved commit once you have obtained it.
It may be a good idea to hand this port over to @seuros for mainainership so he can update it with less friction.
Tue, Oct 20
@kfv Note that you can add multiple commits at once. I recommend only pushing an update once things are ready to be reviewed again (or marking intermediate states as WIP) so that reviewers don't waste time reviewing a WIP patch set.
Not qualified to review this one. Please seek external review.
I wonder if this has deadlock potential if due to error the terminal never asserts that it is ready to receive more.
Found one more item, but it's minor. LGTM otherwise.
Oct 19 2026
Oct 18 2026
In src, we have certain people who shall remain nameless that will jump on you if you don't have at least one reviewer (which is ridiculous considering that very same person commits 50% of their submissions with zero reviewers). I don't know if we have any such people in the ports-committers but that's what I am trying to avoid by getting a reviewer on all my changes.
Approved for commit.
You don't really need to patch the test suite to exit with failure if it does not pass, as the make test target is mainly for human operators to look at.
That said, it's your choice and it's ok to do it if you prefer that.
No PORTREVISION bump needed.
Good catch!
>I just took a look and it seems suckless ports have this practice in common; I presume it's because they set CC et al with plain = in config.mk, so make lets those assignments override whatever MAKE_ENV passes in (see x11/slock, x11/tabbed, x11-wm/dwm, and misc/sent). Say, with CC=gcc14 and CFLAGS+=-fanalyzer in make.conf, dropping CC="${CC}" makes build with base cc while still getting our CFLAGS, and staging would fail on unknown argument '-fanalyzer', right? If so, keeping it as-is would be preferred. I might be proper wrong, though, I'm just thinking out loud to find whether there's been a rationale in keeping it this way for such ports, so correct me please if anything.
LGTM, no issues in the Makefile.
Could you do me a favour and only submit your DR once it is complete on your side and you expect no more changes to be done unless the reviewer find something?
It is quite irritating to review a change set and then to have to go back and review it again because you have decided to piggyback more changes onto it.
If you continue doing this, I'll start to let your DRs sit for a few days to “cool off” before I look at them so I can be more certain that I'll have to review only once.
Oct 17 2026
Oct 16 2026
It's strange that you have to pass in CC and so on in MAKE_ARGS. Conventionally they are passed in through MAKE_ENV and it works.
Oct 15 2026
Oct 13 2026
No objection from my part.
Approved for commit once you received positive review from someone else, too.
Oct 11 2026
I would personally prefer if it said “supported until” instead of “EOL,” but I think this way is ok, too.
Please seek additional code review as I am not familiar with this subsystem.
Oct 10 2026
No objection style-wise.
Oct 9 2026
Oh yes we had that discussion before in the project. Try to keep it all ASCII.
Oct 8 2026
LGTM and approved for commit. I'm not sure if + is allowed in COMMENT, please check with portlint.
LGTM and approved for commit.