It's probably a good idea to do this change either way as the current code won't work with CHERI. Perf looks ok and I think we can live with the slight hit. I'll look into landing it.

Oh is that the case for both? How did you select a debug build? If so it's kind of an apples to oranges comparison.
I'm inclined to accept the patch nonetheless as it seems to make things simpler, but do let me think about it some more.

This sounds like a good idea for simplicity indeed.

LIB_DEPENDS goes before USES (sorry for not mentioning it earlier).
Rest looks ok.

LIB_DEPENDS needs to go before USES, still.

LGTM

Could use WRKSRC_SUBDIR but otherwise ok.

LGTM once @arrowd's suggestion is applied.

See my review on D57960; the same issues apply.

See my review on D57960; the same issues apply.

Oh heh... well then ... I thought it was you. I'm too tired for reviews tonight.

This is a consequence of @pkubaj's PPC ABI change most likely.

Looks good to me. I think portmgr needs to be looped in, too.

In D55509#1324293, @royger wrote:

In D55509#1323281, @fuz wrote:

In D55509#1323279, @arrowd wrote:

I didn't get it at all. How is this change related to the STRIP env var?

The change makes it so that STRIP=${STRIP_CMD} is added to MAKE_ENV if USE_BINUTILS=yes is set.
So if a port uses a BSD-style Makefile, e.g. with <bsd.lib.mk>, things go wrong on staging.

OK, I didn't knew that STRIP was a thing outside of the ports makefile, and then the usage of STRIP by bsd.lib.mk looks bogus compared how the other binutils aliases are defined (ie: OBJCOPY and friends). I've created https://reviews.freebsd.org/D57764 to fix it.