Page MenuHomeFreeBSD
Differential D60458

x11/bhotkeys-albert: New port
AcceptedPublic
Actions

Authored by dteske on Thu, Oct 8, 5:04 AM.
Tags
None
Referenced Files
F175287398: D60458.diff
Fri, Oct 9, 4:56 PM
F175218401: D60458.id189025.diff
Fri, Oct 9, 4:53 AM
F175214902: D60458.id189022.diff
Fri, Oct 9, 4:12 AM
F175196255: D60458.diff
Fri, Oct 9, 12:45 AM
F175167127: D60458.id.diff
Thu, Oct 8, 7:44 PM
Unknown Object (File)
Thu, Oct 8, 4:10 PM
Unknown Object (File)
Thu, Oct 8, 2:36 PM
Unknown Object (File)
Thu, Oct 8, 6:41 AM
View All 10 Files
Subscribers
None

Details

Reviewers
jrm
fuz
adrian
emaste
Summary

Super+Space plugin that launches Albert.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77838
Build 74721: arc lint + arc unit

Event Timeline

dteske requested review of this revision.Thu, Oct 8, 5:04 AM
dteske created this revision.
Harbormaster completed remote builds in B77835: Diff 189022.Thu, Oct 8, 5:04 AM
dteske added a parent revision: D60456: x11/bhotkeys: New port.Thu, Oct 8, 5:16 AM
dteske updated this revision to Diff 189025.Thu, Oct 8, 5:18 AM

rebase over bhotkeys

Harbormaster completed remote builds in B77838: Diff 189025.Thu, Oct 8, 5:18 AM
fuz accepted this revision.Thu, Oct 8, 9:22 PM

LGTM and approved for commit. I'm not sure if + is allowed in COMMENT, please check with portlint.

This revision is now accepted and ready to land.Thu, Oct 8, 9:22 PM
jrm accepted this revision.Fri, Oct 9, 1:47 AM
jrm added a comment.Fri, Oct 9, 1:49 AM

Same optional nit as in D60456 about the subject in the commit message.

dteske added a comment.Fri, Oct 9, 2:21 AM
In D60458#1387444, @fuz wrote:

LGTM and approved for commit. I'm not sure if + is allowed in COMMENT, please check with portlint.

dteske@FreeBSD bhotkeys-albert $ grep COMMENT Makefile 
COMMENT=        Super+Space Albert launcher plugin for bhotkeys
dteske@FreeBSD bhotkeys-albert $ portlint
looks fine.
dteske retitled this revision from x11/bhotkeys-albert: new port to x11/bhotkeys-albert: New port.Fri, Oct 9, 2:36 AM

Revision Contents
Changeset List

PathSize
x11/
1 line
bhotkeys-albert/
23 lines
3 lines
2 lines

Diff 189025

View Options

x11/Makefile

Loading...
View Options

x11/bhotkeys-albert/Makefile

Loading...
View Options

x11/bhotkeys-albert/distinfo

Loading...
View Options

x11/bhotkeys-albert/pkg-descr

Loading...