Page MenuHomeFreeBSD

x11/bhotkeys-screenshot: New port
ClosedPublic

Authored by dteske on Sat, Oct 10, 3:04 PM.
Tags
None
Referenced Files
F175486452: D60587.diff
Sun, Oct 11, 5:08 AM
F175470248: D60587.id189386.diff
Sun, Oct 11, 2:30 AM
F175470246: D60587.id189446.diff
Sun, Oct 11, 2:30 AM
F175470244: D60587.id189363.diff
Sun, Oct 11, 2:30 AM
F175470201: D60587.diff
Sun, Oct 11, 2:30 AM
F175424348: D60587.diff
Sat, Oct 10, 6:31 PM
F175408471: D60587.id.diff
Sat, Oct 10, 3:57 PM
F175408463: D60587.id189363.diff
Sat, Oct 10, 3:57 PM
Subscribers
None

Details

Summary

Screenshot hotkeys for bhotkeys.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dteske created this revision.
x11/bhotkeys-screenshot/Makefile
12

Good catches. All worthy adds. Only one minor note: xdotool is optional. window-screenshot can function without it.

Using make all-depends-list we can determine what other dependencies xdotool would add:

dteske@FreeBSD bhotkeys-screenshot $ make all-depends-list > a
dteske@FreeBSD bhotkeys-screenshot $ vi Makefile
# adds xdotool:x11/xdotool to RUN_DEPENDS
dteske@FreeBSD bhotkeys-screenshot $ make all-depends-list > b
dteske@FreeBSD bhotkeys-screenshot $ diff -pu a b | grep ^+/
+/usr/ports/x11/xdotool
+/usr/ports/x11/libXinerama
+/usr/ports/x11/libxkbcommon
+/usr/ports/x11/xkeyboard-config
+/usr/ports/x11/xkbcomp
+/usr/ports/x11/libxkbfile
+/usr/ports/graphics/wayland-protocols

It's that last one that gives me serious pause in adding xdotool as a hard RUN_DEPENDS entry.

I will absolutely add the others.

Add RUN_DEPENDS: x11/xprop x11/xrandr x11/xdpyinfo (jrm)

This revision is now accepted and ready to land.Sat, Oct 10, 8:39 PM
This revision was automatically updated to reflect the committed changes.