Page MenuHomeFreeBSD
Differential D60497

x11/bhotkeys-lid-state: New port
Needs ReviewPublic
Actions

Authored by dteske on Fri, Oct 9, 4:38 AM.
Tags
None
Referenced Files
F175284262: D60497.diff
Fri, Oct 9, 4:35 PM
F175235539: D60497.id189159.diff
Fri, Oct 9, 7:57 AM
F175229936: D60497.id189159.diff
Fri, Oct 9, 6:56 AM
F175228624: D60497.diff
Fri, Oct 9, 6:42 AM
Subscribers
None

Details

Reviewers
fuz
jrm
adrian
emaste
Summary

Super+Z lid stay-awake hotkey for bhotkeys.
lid-switchd holds the lid sysctl for the session.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77881
Build 74764: arc lint + arc unit

Event Timeline

dteske requested review of this revision.Fri, Oct 9, 4:38 AM
dteske created this revision.
Harbormaster completed remote builds in B77881: Diff 189159.Fri, Oct 9, 4:39 AM
dteske added a parent revision: D60456: x11/bhotkeys: New port.Fri, Oct 9, 4:39 AM
jrm added inline comments.Fri, Oct 9, 5:01 PM
x11/bhotkeys-lid-state/pkg-plist
3

Same comment as in another recent review: The RC script does pw groupadd "$lid_switchd_group". It would be better if the port did this. See https://docs.freebsd.org/en/books/porters-handbook/book/#users-and-groups.

Revision Contents
Changeset List

PathSize
x11/
1 line
bhotkeys-lid-state/
20 lines
3 lines
3 lines
8 lines

Diff 189159

View Options

x11/Makefile

Loading...
View Options

x11/bhotkeys-lid-state/Makefile

Loading...
View Options

x11/bhotkeys-lid-state/distinfo

Loading...
View Options

x11/bhotkeys-lid-state/pkg-descr

Loading...
View Options

x11/bhotkeys-lid-state/pkg-plist

Loading...